Bharata B Rao <bhar...@linux.vnet.ibm.com> writes: > @@ -7987,6 +7989,12 @@ static void ppc_cpu_realizefn(DeviceState *dev, Error > **errp) > max_smt, kvm_enabled() ? "KVM" : "TCG"); > return; > } > + threads_shift = log2(smp_threads); > + if (smp_threads != (1 << threads_shift)) { > + error_setg(errp, "Cannot support %d threads on PPC with %s", > + smp_threads, kvm_enabled() ? "KVM" : "TCG"); > + return; > + } > #endif > > if (kvm_enabled()) {
I'd suggest adding "(must be power of 2)" to the error message somewhere. with that, Acked-by: Stewart Smith <stew...@linux.vnet.ibm.com>