On Sun, Feb 09, 2014 at 12:10:20AM +, Peter Maydell wrote:
> On 8 February 2014 23:33, Paolo Bonzini wrote:
> > Il 08/02/2014 18:28, Andreas Färber ha scritto:
> >> Since when is it OK to declare variables in the middle of the block?
>
> > When the code looks better, it is OK since always: ch
Some of my recent changes introduced variable declarations in the middle
of code blocks.
Fix the code so that it compiles without warnings when using
-Wdeclaration-after-statement.
Signed-off-by: Eduardo Habkost
---
target-i386/cpu.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
On 01/30/14 11:20, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert"
>
> Signed-off-by: Dr. David Alan Gilbert
> Reviewed-by: Alex Bennée
> ---
> vl.c | 52 +++-
> 1 file changed, 39 insertions(+), 13 deletions(-)
>
> diff --g
The following changes since commit 1f6b12f75f2c22f861d0202374033a7594c91707:
Merge remote-tracking branch 'remotes/mwalle/tags/lm32-fixes/20140204' into
staging (2014-02-08 15:57:51 +)
are available in the git repository at:
git://repo.or.cz/qemu/kevin.git tags/for-anthony
for you to
From: Hu Tao
n_start can be actually calculated from offset. The number of
sectors to be allocated(n_end - n_start) can be passed in in
num. By removing n_start and n_end, we can save two parameters.
The side effect is there is a bug in qcow2.c:preallocate() that
passes incorrect n_start to qcow
From: Peter Lieven
all these tests do anything of the following and thus fail with any
protocol other than file:
- the tests use rm, cp or mv shell commands which only work on file
- the tests use qcow2.py
- the images construct new filenames (e.g. backing file names) and
the logic is broke
From: Peter Lieven
This patch adds native support for accessing images on NFS
shares without the requirement to actually mount the entire
NFS share on the host.
NFS Images can simply be specified by an url of the form:
nfs:[?param=value[¶m2=value2[&...]]]
For example:
qemu-img create -f qco
From: Peter Lieven
Signed-off-by: Peter Lieven
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/common| 22 +++---
tests/qemu-iotests/common.rc | 3 +++
2 files changed, 22 insertions(+), 3 deletions(-)
diff --git a/tests/qemu-iotests/common b/tests/qemu-iotests/common
in
The qemu-io command sequences make the assumption that an unaligned
request on the format layer will be unaligned on the blkdebug layer as
well. This doesn't necessarily hold true for drivers other than raw.
Signed-off-by: Kevin Wolf
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Benoît Canet
---
t
From: Hu Tao
When cluster size is big enough it can lead to an offset overflow
in qcow2_alloc_clusters_at(). This patch fixes it.
The allocation is stopped each time at L2 table boundary
(see handle_alloc()), so the possible maximum bytes could be
2^(cluster_bits - 3 + cluster_bits)
cluster_
From: Peter Lieven
reopening is currently not supported.
Signed-off-by: Peter Lieven
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/020 | 5 +
1 file changed, 5 insertions(+)
diff --git a/tests/qemu-iotests/020 b/tests/qemu-iotests/020
index 73a0429..2f258dc 100755
--- a/tests/qemu-iot
This fixes a regression introduced in commit 2a05cbe42 ('block: Allow
block devices without files'):
$ qemu-system-x86_64 -drive driver=file
qemu-system-x86_64: block.c:892: bdrv_open_common: Assertion
`!drv->bdrv_needs_filename || filename != ((void *)0)' failed.
Now the respective check must be
The behaviour of the ROUND_UP macro with negative numbers isn't obvious.
It happens to do the right thing in this please, but better avoid it.
Suggested-by: Laszlo Ersek
Signed-off-by: Kevin Wolf
Reviewed-by: Eric Blake
Reviewed-by: Laszlo Ersek
---
block.c | 4 ++--
1 file changed, 2 inserti
This adds assertions that the request that we actually end up passing to
the block driver (which includes RMW data and has therefore potentially
been rounded to alignment boundaries) is fully covered by the
overlap_{offset,size} fields of the associated BdrvTrackedRequest.
Suggested-by: Laszlo Ers
blockdev-add doesn't know about the device that the backend will be
attached to, this is a legacy -drive concept. Move the remaining checks
that use it to drive_init().
Signed-off-by: Kevin Wolf
---
blockdev.c | 45 +++--
1 file changed, 31 insertions(+),
Reported-by: Laszlo Ersek
Signed-off-by: Kevin Wolf
Reviewed-by: Laszlo Ersek
---
block/blkdebug.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/block/blkdebug.c b/block/blkdebug.c
index 56c4cd0..8eb0db0 100644
--- a/block/blkdebug.c
+++ b/block/blkdebug.c
@
On 32 bit hosts, size_t is too small for align as the bitmask
~(align - 1) will zero out the higher 32 bits of the offset.
While at it, change the local overlap_bytes variable to unsigned to
match the field in BdrvTrackedRequest.
Signed-off-by: Kevin Wolf
Reviewed-by: Laszlo Ersek
---
block.c
The error path for a failure in one of the two bdrv_aligned_preadv()
calls leaked head_buf or tail_buf, respectively. This fixes the memory
leak.
Reported-by: Laszlo Ersek
Signed-off-by: Kevin Wolf
Reviewed-by: Eric Blake
Reviewed-by: Laszlo Ersek
---
block.c | 4 ++--
1 file changed, 2 inser
Signed-off-by: Kevin Wolf
---
hw/sd/sdhci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c
index 0906a1d..a0b90ba 100644
--- a/hw/sd/sdhci.c
+++ b/hw/sd/sdhci.c
@@ -26,7 +26,6 @@
#include "sysemu/blockdev.h"
#include "sysemu/dma.h"
#include "qemu/timer.h"
-#in
From: Hu Tao
Reviewed-by: Max Reitz
Signed-off-by: Hu Tao
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/079 | 63 ++
tests/qemu-iotests/079.out | 32 +++
tests/qemu-iotests/group | 1 +
3 files changed, 96 insertions(+)
From: Hu Tao
In the case of a metadata preallocation with a large cluster size,
qcow2_alloc_cluster_offset() can allocate nothing and returns a
NULL l2meta. This patch checks for it and link2 l2 with only valid
l2meta.
Replace 9 and 512 with BDRV_SECTOR_BITS, BDRV_SECTOR_SIZE
respectively while
On Thu, Feb 06, 2014 at 01:45:07PM +0100, Giorgio Zoppi wrote:
> i offer part of my free time as mentor.
>From my original email:
"In order to mentor you must be an established contributor (regularly
contribute patches)."
I couldn't find any commits from you in QEMU, libvirt, or Linux. Did I
mis
a few irrelevant comments below:
On 01/30/14 11:20, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert"
>
> Add flag storage to qemu-thread-* to store the namethreads flag
>
> Signed-off-by: Dr. David Alan Gilbert
> ---
> include/qemu/thread.h| 1 +
> qemu-options.hx
raw copies over the BlockLimits of bs->file during bdrv_open().
However, since commit d34682cd it is immediately overwritten during
bdrv_refresh_limits(). This caused all fields except for
opt_transfer_length and opt_mem_alignment (which happen to be correctly
inherited in generic code) to be zeroe
On Sun, Feb 9, 2014 at 2:46 PM, Paolo Bonzini wrote:
> Il 09/02/2014 01:18, Peter Maydell ha scritto:
>
>> Haven't checked it yet. I just don't really see what the point is
>> in having a huge amount of OS specific code to do something
>> which we already do in a portable way. It might be nice to
Hi Nicholas,
Adding Vadim Rozenfeld who wrote the virtio-scsi driver.
Best regards,
Yan.
On Feb 7, 2014, at 10:14 PM, Nicholas A. Bellinger wrote:
> Hi Yan,
>
> So recently I've been doing some KVM guest performance comparisons
> between the scsi-mq prototype using virtio-scsi + vhost-scsi, a
On Sun, Feb 9, 2014 at 7:36 AM, Paolo Bonzini wrote:
> Il 08/02/2014 18:46, Peter Maydell ha scritto:
>
>>> This adds parameter "argv0" in calling path from main() to
>>> > module_call_init(). So that module loader knows the location of
>>> > executable.
>>
>> This patch looks kind of odd to me. W
From: Peter Lieven
the opt_transfer_length has nothing to do with logical
block provisioning stuff so always copy it from
the block limits VPD page.
Reported-By: Benoit Canet
Signed-off-by: Peter Lieven
Reviewed-by: Benoit Canet
Signed-off-by: Kevin Wolf
---
block/iscsi.c | 5 ++---
1 file
From: Peter Lieven
Signed-off-by: Peter Lieven
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/016 | 2 +-
tests/qemu-iotests/025 | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/qemu-iotests/016 b/tests/qemu-iotests/016
index b87a32b..7ea9e94 100755
--- a/tests/qe
comments below
On 01/30/14 11:20, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert"
>
> If enabled, set the thread name at creation (on GNU systems with
> pthread_set_np)
> Fix up all the callers with a thread name
>
> Signed-off-by: Dr. David Alan Gilbert
> ---
> cpus.c
We had an unwritten rule about declarations having to be at beginning of
blocks. Make it a written rule.
Signed-off-by: Eduardo Habkost
---
CODING_STYLE | 7 +++
1 file changed, 7 insertions(+)
diff --git a/CODING_STYLE b/CODING_STYLE
index dcbce28..f6eb319 100644
--- a/CODING_STYLE
+++ b/C
Before:
$ ./qemu-io-old
qemu-io-old> open -r -o file.driver=nbd
one of path and host must be specified.
qemu-io-old: can't open device (null): Could not open image: Invalid
argument
$ ./qemu-io-old
qemu-io-old> open -r -o file.driver=nbd,file.host=foo,file.path=bar
path
Before:
$ qemu-io-old
qemu-io-old> open -r -o file.driver=nbd
qemu-io-old: can't open device (null): Could not open image: Invalid
argument
$ ./qemu-io-old
qemu-io-old> open -r -o file.driver=nbd,file.host=foo,file.path=bar
path and host may not be used at the same time.
Most of the block drivers are not using the Error** argument to
bdrv_open, and instead just printing errors to stderr. This series
improves that, using Error** instead of abusing errno numbers too.
The only hurdle (caught by qemu-iotests, too) is VMDK, where we
currently parse a file first as ima
Signed-off-by: Paolo Bonzini
---
block/cow.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/block/cow.c b/block/cow.c
index 7fc0b12..43a2150 100644
--- a/block/cow.c
+++ b/block/cow.c
@@ -82,7 +82,7 @@ static int cow_open(BlockDriverState *bs, QDict *options, int
Signed-off-by: Paolo Bonzini
---
include/block/nbd.h | 1 -
nbd.c | 8 ++--
2 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/include/block/nbd.h b/include/block/nbd.h
index e10ab82..1b39c06 100644
--- a/include/block/nbd.h
+++ b/include/block/nbd.h
@@ -63,7 +63,6 @
qemu-nbd is one of the few valid users of qerror_report_err. Move
the error-reporting socket wrappers there.
Signed-off-by: Paolo Bonzini
---
include/block/nbd.h | 4
nbd.c | 50 --
qemu-nbd.c | 52
Currently, "gluster:///volname/img" and (using file. options)
"file.driver=gluster,file.filename=foo" will segfault. Also,
"//host/volname/img" will be rejected, but it is a valid URL
that should be accepted just fine with "file.driver=gluster".
Accept all of these, by inferring missing transport
Currently, we just try reading a VMDK file as both image and descriptor.
This makes it hard to choose which of the two attempts gave the best error.
We'll decide in advance if the file looks like an image or a descriptor,
and this patch is the first step to that end.
Signed-off-by: Paolo Bonzini
Before:
$ ./qemu-io-old
qemu-io-old> open -r -o file.driver=iscsi,file.filename=foo
Failed to parse URL : foo
qemu-io-old: can't open device (null): Could not open 'foo': Invalid
argument
After:
$ ./qemu-io
qemu-io> open -r -o file.driver=iscsi,file.filename=foo
qemu-i
Signed-off-by: Paolo Bonzini
---
block/qcow.c | 16 ++--
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/block/qcow.c b/block/qcow.c
index 948b0c5..23bc691 100644
--- a/block/qcow.c
+++ b/block/qcow.c
@@ -119,17 +119,19 @@ static int qcow_open(BlockDriverState *bs, QDic
Signed-off-by: Paolo Bonzini
---
block/gluster.c | 24 +---
1 file changed, 13 insertions(+), 11 deletions(-)
diff --git a/block/gluster.c b/block/gluster.c
index f9dd37f..bc9c59f 100644
--- a/block/gluster.c
+++ b/block/gluster.c
@@ -175,7 +175,8 @@ out:
return ret;
}
Signed-off-by: Paolo Bonzini
---
block/vmdk.c | 40 +---
1 file changed, 29 insertions(+), 11 deletions(-)
diff --git a/block/vmdk.c b/block/vmdk.c
index 99ca60f..58f4c34 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -529,6 +529,31 @@ static int vmdk_open_vm
Signed-off-by: Paolo Bonzini
---
block/curl.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/block/curl.c b/block/curl.c
index a807584..353bab1 100644
--- a/block/curl.c
+++ b/block/curl.c
@@ -456,30 +456,27 @@ static int curl_open(BlockDriverState *bs, QDict
*
This prepares for propagating errors from vmdk_open_sparse and
vmdk_open_desc_file up to the caller of vmdk_open.
Signed-off-by: Paolo Bonzini
---
block/vmdk.c | 22 +++---
tests/qemu-iotests/059.out | 4 ++--
2 files changed, 17 insertions(+), 9 deletions(-)
diff
Signed-off-by: Paolo Bonzini
---
block/qed.c | 16 ++--
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/block/qed.c b/block/qed.c
index 694e6e2..59bdd58 100644
--- a/block/qed.c
+++ b/block/qed.c
@@ -398,7 +398,7 @@ static int bdrv_qed_open(BlockDriverState *bs, QDict
Signed-off-by: Paolo Bonzini
---
block/vhdx.c | 21 +
1 file changed, 9 insertions(+), 12 deletions(-)
diff --git a/block/vhdx.c b/block/vhdx.c
index 9ee0a61..de1a80a 100644
--- a/block/vhdx.c
+++ b/block/vhdx.c
@@ -402,9 +402,10 @@ int vhdx_update_headers(BlockDriverState *b
Before:
$ ./qemu-io-old
qemu-io-old> open -r -o driver=vvfat,fat-type=24,dir=i386-softmmu
Valid FAT types are only 12, 16 and 32
qemu-io-old: can't open device (null): Could not open image: Invalid
argument
After:
$ ./qemu-io
qemu-io> open -r -o driver=vvfat,fat-type=24,di
Returning "Wrong medium type" for an image that does not have a valid
header is a bit weird. Improve the error by mentioning what format
was trying to open it.
Signed-off-by: Paolo Bonzini
---
block/bochs.c | 3 ++-
block/cow.c | 3 ++-
block/parallels.c | 3 ++-
block/qcow.c | 3
Instead of just putting it in debugging output, we can now put the
value in an Error.
Signed-off-by: Paolo Bonzini
---
block/vdi.c | 25 -
1 file changed, 16 insertions(+), 9 deletions(-)
diff --git a/block/vdi.c b/block/vdi.c
index 68e152c..3859e49 100644
--- a/block/vd
Now that we can return the "right" errors, use the Error** parameter
to pass them back instead of just printing them.
Signed-off-by: Paolo Bonzini
---
block/vmdk.c | 11 ++-
tests/qemu-iotests/059.out | 6 ++
2 files changed, 8 insertions(+), 9 deletions(-)
diff --git
Il 09/02/2014 10:26, Fam Zheng ha scritto:
> The executable directory is not found once and for all, it's recomputed on
> any call to module_load or os_find_datadir.
>
How about compute it for once in main() and load in module_call_init()?
Sure, that's what Peter's suggesting.
Paolo
Am 09.02.2014 09:06, schrieb Eduardo Habkost:
> On Sun, Feb 09, 2014 at 12:10:20AM +, Peter Maydell wrote:
>> On 8 February 2014 23:33, Paolo Bonzini wrote:
>>> Il 08/02/2014 18:28, Andreas Färber ha scritto:
Since when is it OK to declare variables in the middle of the block?
>>
>>> When
Signed-off-by: Paolo Bonzini
---
block/iscsi.c | 45 +++--
1 file changed, 23 insertions(+), 22 deletions(-)
diff --git a/block/iscsi.c b/block/iscsi.c
index 6f4af72..e654a57 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -1065,35 +1065,36 @@ static Qem
On Sat, 08 Feb 2014 15:24:05 +0100
Andreas Färber wrote:
> Paolo,
>
> Am 08.02.2014 11:01, schrieb Paolo Bonzini:
> > Anthony, Peter,
> >
> > The following changes since commit 0169c511554cb0014a00290b0d3d26c31a49818f:
> >
> > Merge remote-tracking branch 'qemu-kvm/uq/master' into staging
>
changes from v1: Added Signed-of by me.
The following changes since commit 1f6b12f75f2c22f861d0202374033a7594c91707:
Merge remote-tracking branch 'remotes/mwalle/tags/lm32-fixes/20140204' into
staging (2014-02-08 15:57:51 +)
are available in the git repository at:
git://people.freedes
From: Christophe Fergeau
As described in https://bugzilla.redhat.com/show_bug.cgi?id=987441 ,
libcacard currently links to all the libraries QEMU is linking to,
including glusterfs libraries, libiscsi, ... libcacard does not need all of
these. This patch ensures it's only linked with the librarie
Despite 1ad3c6abc0d67e00b84abaa5527bc64b70ca2205, supplying invalid
arguments to the QEMU process still leaked a /tmp/qtest-*.pid file.
Fix this by reordering the reading and unlinking to before reading from
QMP socket, which relies on a running process.
Cc: Stefan Hajnoczi
Signed-off-by: Andrea
On Sun, 2014-02-09 at 11:24 +0200, Yan Vugenfirer wrote:
> Hi Nicholas,
>
> Adding Vadim Rozenfeld who wrote the virtio-scsi driver.
>
> Best regards,
> Yan.
>
> On Feb 7, 2014, at 10:14 PM, Nicholas A. Bellinger
> wrote:
>
> > Hi Yan,
> >
> > So recently I've been doing some KVM guest perfo
Am 07.02.2014 17:41, schrieb Peter Maydell:
> On 4 February 2014 08:31, Stefan Hajnoczi wrote:
>> On Mon, Feb 03, 2014 at 04:01:00PM +, Peter Maydell wrote:
>>> On 3 February 2014 15:20, Stefan Hajnoczi wrote:
This pull request has been rebased onto qemu.git/master and retested.
>>>
On 9 February 2014 06:46, Paolo Bonzini wrote:
> Il 09/02/2014 01:18, Peter Maydell ha scritto:
>
>> Haven't checked it yet. I just don't really see what the point is
>> in having a huge amount of OS specific code to do something
>> which we already do in a portable way. It might be nice to abstra
On 9 February 2014 02:15, Peter Crosthwaite
wrote:
> On Sat, Feb 1, 2014 at 1:45 AM, Peter Maydell
> wrote:
>> -{ .name = "CCSIDR", .cp = 15, .crn = 0, .crm = 0, .opc1 = 1, .opc2 = 0,
>> +{ .name = "CCSIDR", .state = ARM_CP_STATE_BOTH,
>> + .opc0 = 3, .crn = 0, .crm = 0, .opc1 = 1,
Cc: Kevin Wolf
Cc: Stefan Hajnoczi
Signed-off-by: Andreas Färber
---
tests/Makefile | 3 +++
tests/virtio-blk-test.c | 34 ++
2 files changed, 37 insertions(+)
create mode 100644 tests/virtio-blk-test.c
diff --git a/tests/Makefile b/tests/Makefile
ind
Cc: Stefan Hajnoczi
Cc: Michael S. Tsirkin
Signed-off-by: Andreas Färber
---
tests/Makefile | 7 +++
tests/e1000-test.c | 33 +
2 files changed, 40 insertions(+)
create mode 100644 tests/e1000-test.c
diff --git a/tests/Makefile b/tests/Makefile
index 4
Hello Stefan and Michael,
This series starts preparing tests to cover optional PCI devices. They don't do
any functional tests but assure that QOM/PCI/VMState refactorings don't break
the basic usage of devices not covered by qom-test.
pcnet-test.c is intended to handle sparc's lance as well.
v2
Test PCI only for now.
Cc: Stefan Hajnoczi
Signed-off-by: Andreas Färber
---
tests/Makefile | 4
tests/pcnet-test.c | 33 +
2 files changed, 37 insertions(+)
create mode 100644 tests/pcnet-test.c
diff --git a/tests/Makefile b/tests/Makefile
index eabd
Note that this will emit a warning:
[vmxnet3][WR][vmxnet3_peer_has_vnet_hdr]: Peer has no virtio extension.
Task offloads will be emulated.
Cc: Dmitry Fleytman
Cc: Stefan Hajnoczi
Signed-off-by: Andreas Färber
---
tests/Makefile | 5 +
tests/vmxnet3-test.c | 33 +
Cc: Alberto Garcia
Signed-off-by: Andreas Färber
---
tests/Makefile | 3 +++
tests/tpci200-test.c | 33 +
2 files changed, 36 insertions(+)
create mode 100644 tests/tpci200-test.c
diff --git a/tests/Makefile b/tests/Makefile
index 4f9dd6d..407b883 100644
Cc: Stefan Hajnoczi
Signed-off-by: Andreas Färber
---
tests/Makefile | 3 +++
tests/rtl8139-test.c | 33 +
2 files changed, 36 insertions(+)
create mode 100644 tests/rtl8139-test.c
diff --git a/tests/Makefile b/tests/Makefile
index 323c600..eabdf98 100644
Cc: Alberto Garcia
Signed-off-by: Andreas Färber
---
tests/Makefile | 7 +++
tests/ipoctal232-test.c | 33 +
2 files changed, 40 insertions(+)
create mode 100644 tests/ipoctal232-test.c
diff --git a/tests/Makefile b/tests/Makefile
index 2a7e104..89
Cc: Michael S. Tsirkin
Signed-off-by: Andreas Färber
---
tests/Makefile | 3 +++
tests/virtio-rng-test.c | 33 +
2 files changed, 36 insertions(+)
create mode 100644 tests/virtio-rng-test.c
diff --git a/tests/Makefile b/tests/Makefile
index 8a35c3c..2a
On Fri, Feb 07, 2014 at 10:02:52AM +0100, Greg Kurz wrote:
> On Wed, 5 Feb 2014 23:31:11 +0200
> "Michael S. Tsirkin" wrote:
> > On Tue, Feb 04, 2014 at 12:51:25PM +0530, Aneesh Kumar K.V wrote:
> > > "Michael S. Tsirkin" writes:
> > >
> > > > On Mon, Feb 03, 2014 at 03:05:10PM +0530, Aneesh Kum
Cc: Stefan Hajnoczi
Signed-off-by: Andreas Färber
---
tests/Makefile| 3 +++
tests/eepro100-test.c | 63 +++
2 files changed, 66 insertions(+)
create mode 100644 tests/eepro100-test.c
diff --git a/tests/Makefile b/tests/Makefile
index 86
Cc: Stefan Hajnoczi
Signed-off-by: Andreas Färber
---
tests/Makefile | 1 +
tests/ne2000-test.c | 33 +
2 files changed, 34 insertions(+)
create mode 100644 tests/ne2000-test.c
diff --git a/tests/Makefile b/tests/Makefile
index 407b883..2bb484f 100644
---
On 9 February 2014 02:50, Peter Crosthwaite
wrote:
> On Sat, Feb 1, 2014 at 1:45 AM, Peter Maydell
> wrote:
>> +typedef enum CPAccessResult {
>> +/* Access is permitted */
>> +CP_ACCESS_OK = 0,
>> +/* Access fails due to a configurable trap or enable which would
>> + * result in
On 9 February 2014 02:59, Peter Crosthwaite
wrote:
> Agreed. With diff-correction based on this scheme:
>
> Reviewed-by: Peter Crosthwaite
>
> But the nice thing about having named fields is it
>> doesn't actually matter what order things go in.
>>
>
> But for similar entries its much more read
Cc: Stefan Hajnoczi
Cc: Michael S. Tsirkin
Signed-off-by: Andreas Färber
---
tests/Makefile | 7 +++
tests/virtio-net-test.c | 33 +
2 files changed, 40 insertions(+)
create mode 100644 tests/virtio-net-test.c
diff --git a/tests/Makefile b/tests/M
Cc: Michael S. Tsirkin
Signed-off-by: Andreas Färber
---
tests/Makefile | 3 +++
tests/virtio-balloon-test.c | 33 +
2 files changed, 36 insertions(+)
create mode 100644 tests/virtio-balloon-test.c
diff --git a/tests/Makefile b/tests/Makefile
index
On 9 February 2014 03:09, Peter Crosthwaite
wrote:
> On Sat, Feb 1, 2014 at 1:45 AM, Peter Maydell
> wrote:
>>
>> +static CPAccessResult ats_access(CPUARMState *env, const ARMCPRegInfo *ri)
>> +{
>> +if (ri->opc2 & 4) {
>> +/* Other states are only available with TrustZone; in
>
> A
On Sun, Feb 9, 2014 at 7:48 PM, Peter Maydell wrote:
> Ah, sorry, I hadn't spotted that. OK, then I think we should use that
> code (and I'll test the MacOS X version), but it should go in a
> called-once-from main init function that stashes the answer in
> a static variable, and then the 'get the
On 9 February 2014 03:27, Peter Crosthwaite
wrote:
> On Sat, Feb 1, 2014 at 1:45 AM, Peter Maydell
> wrote:
>> -/* Access functions for coprocessor registers. These should always succeed.
>> */
>> -typedef int CPReadFn(CPUARMState *env, const ARMCPRegInfo *opaque,
>> - uint6
Am 09.02.2014 02:35, schrieb Peter Crosthwaite:
> On Sat, Feb 1, 2014 at 12:34 AM, Andreas Färber wrote:
>> Replace usages of FROM_I2C_SLAVE() with QOM cast macro and rename parent
>> field to assure we caught all.
>>
>> Signed-off-by: Andreas Färber
>> ---
>> hw/arm/pxa2xx.c | 38 ++
On 9 February 2014 12:24, Andreas Färber wrote:
> Am 09.02.2014 02:35, schrieb Peter Crosthwaite:
>> On Sat, Feb 1, 2014 at 12:34 AM, Andreas Färber wrote:
>>> @@ -1292,10 +1298,12 @@ static void pxa2xx_i2c_event(I2CSlave *i2c, enum
>>> i2c_event event)
>>>
>>> static int pxa2xx_i2c_rx(I2CSlave
Am 09.02.2014 02:53, schrieb Peter Crosthwaite:
> On Sat, Feb 1, 2014 at 12:34 AM, Andreas Färber wrote:
>> Use type-specific QOM cast macros instead.
>>
>
> Should be past tense - "We now use type-specific ...". The imperative
> form of "use" suggests you are making the change in this patch but
Am 31.01.2014 15:34, schrieb Andreas Färber:
> Replace usages of FROM_I2C_SLAVE() with QOM cast macro and rename parent
> field to assure we caught all.
>
> Signed-off-by: Andreas Färber
> ---
> hw/arm/pxa2xx.c | 38 +-
> 1 file changed, 25 insertions(+), 13 d
Am 09.02.2014 02:38, schrieb Peter Crosthwaite:
> On Sat, Feb 1, 2014 at 12:34 AM, Andreas Färber wrote:
>> Replace usages of FROM_I2C_SLAVE() with QOM cast macro.
>>
>> Signed-off-by: Andreas Färber
>
> Reviewed-by: Peter Crosthwaite
Thanks, adding and mentioning the following on top:
diff -
On 9 February 2014 08:06, Eduardo Habkost wrote:
> Sorry for my confusion, but I was not aware of that rule, and I don't
> know what I should use as a guide, if checkpatch.pl and CODING_STYLE are
> not enough. Is there additional coding style documentation or scripts I
> should look at?
Unfortuna
Am 31.01.2014 15:34, schrieb Andreas Färber:
> Replace usages of FROM_I2C_SLAVE() with QOM cast macro.
> Rename parent field.
>
> Signed-off-by: Andreas Färber
> ---
> hw/audio/wm8750.c | 33 -
> 1 file changed, 20 insertions(+), 13 deletions(-)
Follow-up TODO: M
Paolo,
Am 03.02.2014 10:44, schrieb Edgar E. Iglesias:
> Edgar E. Iglesias (22):
> exec: Make tb_invalidate_phys_addr input an AS
> exec: Make iotlb_to_region input an AS
> exec: Always initialize MemorySection address spaces
> exec: Make memory_region_section_get_iotlb use section AS
>
On 09/02/14 04:14, Peter Crosthwaite wrote:
Hi Peter,
Thanks for the review!
(cut)
+/* #define DEBUG_CG3 */
+
+#define CG3_ROM_FILE "QEMU,cgthree.bin"
+#define FCODE_MAX_ROM_SIZE 0x1
+
+#define CG3_REG_SIZE 0x20
+#define CG3_VRAM_SIZE 0x10
+#define CG3_VRAM_OFFSET 0x80
+
+#ifdef
Il 08/02/2014 15:24, Andreas Färber ha scritto:
I had specifically requested to review and take these through qom-next,
like most qdev changes have gone lately. Why are you sending a pull
nontheless? In particular Luiz has not yet replied to the QERR issue I
pointed out.
Because that's not what
On 9 February 2014 13:31, Andreas Färber wrote:
> Paolo,
>
> Am 03.02.2014 10:44, schrieb Edgar E. Iglesias:
>> Edgar E. Iglesias (22):
>> exec: Make tb_invalidate_phys_addr input an AS
>> exec: Make iotlb_to_region input an AS
>> exec: Always initialize MemorySection address spaces
>> exe
On 8 February 2014 16:38, Mark Cave-Ayland
wrote:
> The CG3 framebuffer is a simple 8-bit framebuffer for use with operating
> systems such as early Solaris that do not have drivers for TCX.
>
> +static void cg3_reg_write(void *opaque, hwaddr addr, uint64_t val,
> + unsign
Hi,
Am 08.02.2014 17:38, schrieb Mark Cave-Ayland:
> +static Property cg3_properties[] = {
> +DEFINE_PROP_HEX32("vram_size", CG3State, vram_size, -1),
Paolo is about to drop hex32 ...
> +DEFINE_PROP_UINT16("width",CG3State, width, -1),
> +DEFINE_PROP_UINT16("height",
On 09/02/14 14:41, Peter Maydell wrote:
On 8 February 2014 16:38, Mark Cave-Ayland
wrote:
The CG3 framebuffer is a simple 8-bit framebuffer for use with operating
systems such as early Solaris that do not have drivers for TCX.
+static void cg3_reg_write(void *opaque, hwaddr addr, uint64_t va
On 09/02/14 15:10, Andreas Färber wrote:
Hi Andreas,
Hi,
Am 08.02.2014 17:38, schrieb Mark Cave-Ayland:
+static Property cg3_properties[] = {
+DEFINE_PROP_HEX32("vram_size", CG3State, vram_size, -1),
Paolo is about to drop hex32 ...
H okay...
+DEFINE_PROP_UINT16("width",
Am 08.02.2014 17:38, schrieb Mark Cave-Ayland:
> In order to allow the user to choose the framebuffer for sparc-softmmu, add
> -vga tcx and -vga cg3 options to the QEMU command line. If no option is
> specified, the default TCX framebuffer is used.
>
> Signed-off-by: Mark Cave-Ayland
> CC: Blue S
On 9 February 2014 15:19, Mark Cave-Ayland
wrote:
> On 09/02/14 14:41, Peter Maydell wrote:
>
>> On 8 February 2014 16:38, Mark Cave-Ayland
>> wrote:
>>> +case 4:
>>> +/* This register can be written to as either a long word or a
>>> byte.
>>> + * According to the SBus specif
Am 09.02.2014 16:24, schrieb Mark Cave-Ayland:
> One thing I'm not sure about is how the QOM stuff interacts with sysbus
> - can you quickly point me towards an existing device that does this so
> I can understand how this works?
The ARM MPCore devices come to mind. But really all you've been aske
On Sat, Feb 08, 2014 at 08:58:35PM +0100, Andreas Färber wrote:
> >> ipack: Move IndustryPack out of hw/char/
>
> There were unresolved IRC discussions with Paolo where exactly to
> place which IndustryPack files, so that this series has been lying
> around.
As I had explained some time ago I
1 - 100 of 146 matches
Mail list logo
