07.02.2014 11:13, Paolo Bonzini wrote:
> Il 07/02/2014 01:06, Peter Maydell ha scritto:
>> Why do we need OS specific code to do this when the code
>> in vl.c for getting the executable path to use as a base for
>> finding bios blobs works fine without OS specific code?
>
> That's because right no
do you use xbzrle for live migration ?
- Mail original -
De: "Stefan Priebe"
À: "Dr. David Alan Gilbert"
Cc: "Alexandre DERUMIER" , "qemu-devel"
Envoyé: Jeudi 6 Février 2014 21:00:27
Objet: Re: [Qemu-devel] [pve-devel] QEMU LIve Migration - swap_free: Bad swap
file entry
Hi,
Am 0
Am 07.02.2014 09:15, schrieb Alexandre DERUMIER:
>
> do you use xbzrle for live migration ?
no - i'm really stucked right now with this. Biggest problem i can't
reproduce with test machines ;-(
Stefan
>
> - Mail original -
>
> De: "Stefan Priebe"
> À: "Dr. David Alan Gilbert"
>
Over time, lots of stuff moved from vl.c into separate
files. But include statements has never been cleaned,
and they continue to carry lots of anymore-unused stuff.
Remove includes which are not relevant for vl.c anymore.
Apparently there are more includes like this, because
many are included fr
Il 07/02/2014 09:14, Michael Tokarev ha scritto:
07.02.2014 11:13, Paolo Bonzini wrote:
> Il 07/02/2014 01:06, Peter Maydell ha scritto:
>> Why do we need OS specific code to do this when the code
>> in vl.c for getting the executable path to use as a base for
>> finding bios blobs works fine w
On Fri, 02/07 12:14, Michael Tokarev wrote:
> 07.02.2014 11:13, Paolo Bonzini wrote:
> > Il 07/02/2014 01:06, Peter Maydell ha scritto:
> >> Why do we need OS specific code to do this when the code
> >> in vl.c for getting the executable path to use as a base for
> >> finding bios blobs works fine
* Alexey Kardashevskiy (a...@ozlabs.ru) wrote:
> On 02/06/2014 10:24 PM, Dr. David Alan Gilbert wrote:
> > * Alexey Kardashevskiy (a...@ozlabs.ru) wrote:
> >> On 02/06/2014 03:45 AM, Paolo Bonzini wrote:
> >>> Il 05/02/2014 17:42, Dr. David Alan Gilbert ha scritto:
> Because:
> * the
On Wed, 5 Feb 2014 23:31:11 +0200
"Michael S. Tsirkin" wrote:
> On Tue, Feb 04, 2014 at 12:51:25PM +0530, Aneesh Kumar K.V wrote:
> > "Michael S. Tsirkin" writes:
> >
> > > On Mon, Feb 03, 2014 at 03:05:10PM +0530, Aneesh Kumar K.V wrote:
> > >> "Michael S. Tsirkin" writes:
> > >>
> > >> > Hav
Il 04/02/2014 19:41, Marcelo Tosatti ha scritto:
-mem-prealloc asks to preallocate memory residing on -mem-path path.
Currently QEMU exits in case:
- Memory file has been created but allocation via explicit write
fails.
And it fallbacks to malloc in case:
- Querying huge page size fails.
- La
* Stefan Priebe - Profihost AG (s.pri...@profihost.ag) wrote:
> Am 07.02.2014 09:15, schrieb Alexandre DERUMIER:
> >
> > do you use xbzrle for live migration ?
>
> no - i'm really stucked right now with this. Biggest problem i can't
> reproduce with test machines ;-(
Only being able to test on y
Am 07.02.2014 10:15, schrieb Dr. David Alan Gilbert:
> * Stefan Priebe - Profihost AG (s.pri...@profihost.ag) wrote:
>> Am 07.02.2014 09:15, schrieb Alexandre DERUMIER:
>>>
>>> do you use xbzrle for live migration ?
>>
>> no - i'm really stucked right now with this. Biggest problem i can't
>> repr
do you use xbzrle for live migration ?
no - i'm really stucked right now with this. Biggest problem i can't
reproduce with test machines ;-(
Only being able to test on your production VMs isn't fun;
is it possible or you to run an extra program on these VMs - e.g.
if we came up with a simple (
Hi,
Am 07.02.2014 10:29, schrieb Marcin Gibuła:
> do you use xbzrle for live migration ?
no - i'm really stucked right now with this. Biggest problem i can't
reproduce with test machines ;-(
>>>
>>> Only being able to test on your production VMs isn't fun;
>>> is it possible or y
* Stefan Priebe - Profihost AG (s.pri...@profihost.ag) wrote:
>
> Am 07.02.2014 10:15, schrieb Dr. David Alan Gilbert:
> > * Stefan Priebe - Profihost AG (s.pri...@profihost.ag) wrote:
> >> Am 07.02.2014 09:15, schrieb Alexandre DERUMIER:
> >>>
> >>> do you use xbzrle for live migration ?
> >>
> >
Am 07.02.2014 10:31, schrieb Dr. David Alan Gilbert:
> * Stefan Priebe - Profihost AG (s.pri...@profihost.ag) wrote:
>>
>> Am 07.02.2014 10:15, schrieb Dr. David Alan Gilbert:
>>> * Stefan Priebe - Profihost AG (s.pri...@profihost.ag) wrote:
Am 07.02.2014 09:15, schrieb Alexandre DERUMIER:
>>
For NFS you need to use the sync mount option to force the NFS client to
sync to
server on writes.
Isn't opening with O_DIRECT enough? (for linux nfs client at least)
--
mg
You mean to reproduce?
I'm more interested in seeing what type of corruption is happening;
if you've got a test VM that corrupts memory and we can run a program
in that vm that writes a known pattern into memory and checks it
then see what changed after migration, it might give a clue.
But obvi
Il 06/02/2014 13:32, Igor Mammedov ha scritto:
io_as in not a pure container, that's why
memory_region_find() finds it at all.
This patch only fixes function to behave as it was
originally documented.
The idea was that parent would be a pure container :) but your patch
makes sense and fixes t
On Fri, 02/07 15:01, Fam Zheng wrote:
> I'd like to add persistent dirty bitmap as an idea but I seem to have no
> account on wiki, so I'll just reply here, please help with review and update
> the page if it makes sense. (Who could create an account for me, BTW?)
Now I've got two because Paolo an
On Thu, Feb 06, 2014 at 05:57:38PM +0100, Andreas Färber wrote:
[...]
> And it's true that we could in fact just instantiate the object for
> -device foo,? - it's just that nobody wrote code for that. I didn't do
> the original QOM conversion so I don't feel guilty, I don't normally use
> -device f
Public bug reported:
After a "monitor system_reset" the GDB view to the system state differs
from QEMUs processor state.
Breakpoint 8, _ARMV4_Exception_interrupt () at
/home/sh/rtems-4.11/c/src/../../cpukit/score/cpu/arm/arm_exc_interrupt.S:74
74 mov EXCHANGE_LR, lr
(gdb) info r
On 7 February 2014 07:35, Hu Tao wrote:
> On Fri, Jan 31, 2014 at 03:45:27PM +, Peter Maydell wrote:
>> Make the cache ID system registers (CLIDR, CCSELR, CCSIDR, CTR)
>
> s/CCSELR/CSSELR/
>
>> visible to AArch64. These are mostly simple 64-bit extensions of the
>> existing 32 bit system regis
On Thu, Feb 06, 2014 at 05:57:38PM +0100, Andreas Färber wrote:
[...]
> >> If there's no relation between a CPU model named, e.g., "Haswell" and
> >> the one on an Intel Haswell chip any more, then we should give them
> >> artificial names like "qemu64"; I strongly believe that Haswell
> >> definit
Il 05/02/2014 19:08, Andreas Färber ha scritto:
http://wiki.qemu.org/Features/QOM#TODO
Anthony wants buses to go away completely. So that seems a legacy
concept to me even though they do not seem to be gone tomorrow.
The way I read that, buses would be replaced by controller devices.
This is
Hi all,
I would like to add fault tolerance mechanism.
2014-02-07 11:10 GMT+01:00 Fam Zheng :
> On Fri, 02/07 15:01, Fam Zheng wrote:
> > I'd like to add persistent dirty bitmap as an idea but I seem to have no
> > account on wiki, so I'll just reply here, please help with review and
> update
>
This will enable accounting of aio requests issued from qemu-io aio
read/write commands.
Signed-off-by: Fam Zheng
---
qemu-io-cmds.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c
index f1de24c..d68eb23 100644
--- a/qemu-io-cmds.c
+++ b/qemu-io-cm
This series adds iotest case for IO throttling.
There is a change in qemu-io sub-commands "aio_read" and "aio_write", which
makes the aio requests accounted and the statistics reflected in blockstats.
Note that IO throttling implementation allows overcommiting of requests, so the
actual IO happen
QMP command "block_set_io_throttle" expects underscores in parameters
instead of dashes: {iops,bps}_{rd,wr,max}.
Add optional argument conv_keys (defaults to True, backward compatible),
it will be used in IO throttling test case.
Reviewed-by: Benoit Canet
Signed-off-by: Fam Zheng
---
tests/qem
This case utilizes qemu-io command "aio_{read,write} -q" to verify the
effectiveness of IO throttling options.
It's implemented by driving the vm timer from qtest protocol, so the
throttling timers are signaled with determined time duration. Then we
verify the completed IO requests are within 110%
This will allow test case to run command in qtest protocol. It's
write-only for now.
Signed-off-by: Fam Zheng
---
tests/qemu-iotests/iotests.py | 20 ++--
1 file changed, 18 insertions(+), 2 deletions(-)
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
This removes the dummy scripts/qtest and adds scripts/qtest/qtest.py as
a python library for qtest protocol.
This is a skeleton with a basic "cmd" method to execute a command,
reading and parsing of qtest output will be added later on demand.
Signed-off-by: Fam Zheng
---
scripts/qtest
Il 07/02/2014 11:16, Eduardo Habkost ha scritto:
You are not alone. I remember we spent lots of time trying to convince
Anthony to allow global properties and compat_props affect dynamic
properties not just static properties, and static properties were a big
deal due to reasons I didn't understan
Il 07/02/2014 11:41, Giorgio Zoppi ha scritto:
Hi all,
I would like to add fault tolerance mechanism.
I'm assuming you would contribute as a student rather than a mentor,
since I am not familiar with contributions from you to either libvirt or
QEMU.
In that case, do not worry. The page is
Am 07.02.2014 11:41, schrieb Paolo Bonzini:
> Il 05/02/2014 19:08, Andreas Färber ha scritto:
>> http://wiki.qemu.org/Features/QOM#TODO
>>
>> Anthony wants buses to go away completely. So that seems a legacy
>> concept to me even though they do not seem to be gone tomorrow.
>
> The way I read that
Am 07.02.2014 08:13, schrieb Paolo Bonzini:
> Il 05/02/2014 19:01, Andreas Färber ha scritto:
>> Am 05.02.2014 18:55, schrieb Paolo Bonzini:
>>> Il 05/02/2014 18:51, Andreas Färber ha scritto:
>> So, even though I think this script is a very welcome addition, I
> don't
>> think it helps
Il 07/02/2014 12:00, Andreas Färber ha scritto:
Am 07.02.2014 11:41, schrieb Paolo Bonzini:
Il 05/02/2014 19:08, Andreas Färber ha scritto:
http://wiki.qemu.org/Features/QOM#TODO
Anthony wants buses to go away completely. So that seems a legacy
concept to me even though they do not seem to be
Il 07/02/2014 12:09, Andreas Färber ha scritto:
No matter how much I like QOM (I do), I would rather say that the all
QOM grand plan has been "inconclusive". 99% in-tree uses of QOM are
just a glorified qdev, buses and all. You shouldn't be surprised if
people still care about the "legacy" qdev
Hi,
i was able to reproduce with a longer running test VM running the google
stress test.
And it happens exacly when the migration finishes it does not happen
while the migration is running.
Google Stress Output displays Memory errors:
Page Error:
On 07.02.2014 18:46, Orit Wasserman wrote:
> On 02/07/2014 06:35 AM, Alexey Kardashevskiy wrote:
>> Hi!
>>
>> I have yet another problem with migration. Or NFS.
>>
>> There is one NFS server and 2 test POWER8 machines. There is a shared NFS
>> folder on the server, mounted to both test hosts. There
* Stefan Priebe - Profihost AG (s.pri...@profihost.ag) wrote:
> Hi,
>
> i was able to reproduce with a longer running test VM running the google
> stress test.
Hmm that's quite a fun set of differences; I think I'd like
to understand whether the pattern is related to the pattern of what
the test
Il 07/02/2014 10:41, Marcin Gibuła ha scritto:
>> For NFS you need to use the sync mount option to force the NFS client to
>> sync to
>> server on writes.
>
> Isn't opening with O_DIRECT enough? (for linux nfs client at least)
Yeah, the man page says:
If neither sync nor async is specifie
Hi,
Am 07.02.2014 13:21, schrieb Dr. David Alan Gilbert:
> * Stefan Priebe - Profihost AG (s.pri...@profihost.ag) wrote:
>> Hi,
>>
>> i was able to reproduce with a longer running test VM running the google
>> stress test.
>
> Hmm that's quite a fun set of differences; I think I'd like
> to unders
Il 06/02/2014 15:30, Markus Armbruster ha scritto:
Visitors get passed a pointer to the visited object. The generated
visitors try to cope with this pointer being null in some places, for
instance like this:
visit_start_optional(m, obj ? &(*obj)->has_name : NULL, "name", &err);
visit_start
Il 07/02/2014 13:30, Stefan Priebe - Profihost AG ha scritto:
>> i was able to reproduce with a longer running test VM running the google
>> stress test.
Hmm that's quite a fun set of differences; I think I'd like
to understand whether the pattern is related to the pattern of what
the test is do
Am 07.02.2014 12:21, schrieb Paolo Bonzini:
> Let's stop talking about theory and let's look at the actual ccode, please.
I have posted actual patches, you haven't. I even asked you to myself.
And there's no point continuing discussions about reverts here when
there are actual solutions - by me -
On 02/07/2014 02:10 PM, Alexey Kardashevskiy wrote:
On 07.02.2014 18:46, Orit Wasserman wrote:
On 02/07/2014 06:35 AM, Alexey Kardashevskiy wrote:
Hi!
I have yet another problem with migration. Or NFS.
There is one NFS server and 2 test POWER8 machines. There is a shared NFS
folder on the ser
On Thu, 6 Feb 2014, Andreas Färber wrote:
> Am 06.02.2014 16:55, schrieb Olaf Hering:
> > bdrv_acct_done was called unconditional. But in case the ioreq has no
> > segments there is no matching bdrv_acct_start call. This could lead to
> > bogus accounting values.
> >
> > Found by code inspection.
It is more a NFS issue, if you have a file in NFS that two users in
two different host are accessing (one at least write to it) you will
need to enforce the "sync" option.
Even if you flush all the data and close the file the NFS client can still
have cached data that it didn't sync to the server.
Since introduction of PCIHP, it became problematic to
punch hole in PCI0._CRS statically since PCI hotplug
region size became runtime changeable.
So replace static hole punching with dynamically consumed
resources in a child device on PCI0 bus. i.e generate
PNP0C02 device as a child of PCI0 bus at
This reverts part of commit 61a3f63560ccd2b5e8c9134e9213a1cff36f26bf
that adds Device(CPU_HOTPLUG_RESOURCE_DEVICE) with CPU hotplug IO
resource in its _CRS.
Conflicts:
hw/i386/acpi-dsdt-cpu-hotplug.dsl
Signed-off-by: Igor Mammedov
---
hw/i386/acpi-dsdt-cpu-hotplug.dsl | 11 --
This reverts commit 1aa149b479a479323121251f1e8e676765cb354d.
Signed-off-by: Igor Mammedov
---
hw/i386/acpi-dsdt-pci-crs.dsl |8 +++-
hw/i386/acpi-dsdt.dsl | 32
hw/i386/q35-acpi-dsdt.dsl |8
3 files changed, 7 insertions(+), 41
This reverts commit 562e56a9f8e627b2a4ef60037507361ce3cb4e6d.
Signed-off-by: Igor Mammedov
---
hw/i386/acpi-dsdt-pci-crs.dsl |7 +++
hw/i386/acpi-dsdt.dsl |7 ---
hw/i386/q35-acpi-dsdt.dsl |8
3 files changed, 7 insertions(+), 15 deletions(-)
diff --git
Signed-off-by: Igor Mammedov
---
hw/i386/acpi-build.c | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index ce5f715..5cd0c80 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -70,6 +70,8 @@ typedef struct
Signed-off-by: Igor Mammedov
---
hw/i386/acpi-build.c | 22 ++
1 files changed, 22 insertions(+), 0 deletions(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 5cd0c80..e3d145b 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -72,6 +72,8 @@ ty
with introduction of PCIHP, MMIO range becomes changable
at runtime so it's not possible to statically punch hole
PCI bus _CRS.
Making IO base/length available as readonly properties
allow acpi builder to get values and reserve PCI hotplug
IO range at runtime later.
Signed-off-by: Igor Mammedov
Hi,
Am 07.02.2014 13:44, schrieb Paolo Bonzini:
> Il 07/02/2014 13:30, Stefan Priebe - Profihost AG ha scritto:
>>> >> i was able to reproduce with a longer running test VM running the
>>> google
>>> >> stress test.
>>>
>>> Hmm that's quite a fun set of differences; I think I'd like
>>> to underst
Il 07/02/2014 13:44, Andreas Färber ha scritto:
Am 07.02.2014 12:21, schrieb Paolo Bonzini:
Let's stop talking about theory and let's look at the actual ccode, please.
I have posted actual patches, you haven't.
I have reviewed those, and said that we can apply all three. It's
certainly bet
Signed-off-by: Igor Mammedov
---
hw/i386/acpi-build.c | 28 ++--
1 files changed, 18 insertions(+), 10 deletions(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 6a43a7d..1dbe5ce 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -224,6 +22
Signed-off-by: Igor Mammedov
---
hw/i386/acpi-build.c | 62 ++
1 files changed, 62 insertions(+), 0 deletions(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index f0bedbd..ce5f715 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-
* Stefan Priebe - Profihost AG (s.pri...@profihost.ag) wrote:
> Hi,
>
> Am 07.02.2014 13:44, schrieb Paolo Bonzini:
> > Il 07/02/2014 13:30, Stefan Priebe - Profihost AG ha scritto:
> >>> >> i was able to reproduce with a longer running test VM running the
> >>> google
> >>> >> stress test.
> >>>
Hi,
Am 07.02.2014 14:08, schrieb Dr. David Alan Gilbert:
> * Stefan Priebe - Profihost AG (s.pri...@profihost.ag) wrote:
>> Hi,
>>
>> Am 07.02.2014 13:44, schrieb Paolo Bonzini:
>>> Il 07/02/2014 13:30, Stefan Priebe - Profihost AG ha scritto:
>>> i was able to reproduce with a longer running
* Stefan Priebe - Profihost AG (s.pri...@profihost.ag) wrote:
> Hi,
>
> Am 07.02.2014 14:08, schrieb Dr. David Alan Gilbert:
> > * Stefan Priebe - Profihost AG (s.pri...@profihost.ag) wrote:
> >> first of all i've now a memory image of a VM where i can reproduce it.
> >> reproducing does NOT work
Il 07/02/2014 13:49, Andreas Färber ha scritto:
qdev is a framework from Paul Brook with a bus-tree-oriented graph.
QOM by comparison uses an arbitrary composition tree of child<> nodes.
qdev as such no longer exists since late 2011 / early 2012.
Let me be blunt: to me, this is a huge, huge de
On Thu, 6 Feb 2014, Markus Armbruster wrote:
> Stefano Stabellini writes:
>
> > On Wed, 5 Feb 2014, Markus Armbruster wrote:
> >> [Note cc: Stefano]
> >>
> >> Kevin Wolf writes:
> >>
> >> > Am 30.01.2014 um 13:16 hat Markus Armbruster geschrieben:
> >> >> It's a copy of dev->conf.bs. The copy
Hi,
Am 07.02.2014 14:15, schrieb Dr. David Alan Gilbert:
> * Stefan Priebe - Profihost AG (s.pri...@profihost.ag) wrote:
>> Hi,
>>
>> Am 07.02.2014 14:08, schrieb Dr. David Alan Gilbert:
>>> * Stefan Priebe - Profihost AG (s.pri...@profihost.ag) wrote:
>
first of all i've now a memory image
Il 07/02/2014 14:04, Stefan Priebe - Profihost AG ha scritto:
first of all i've now a memory image of a VM where i can reproduce it.
You mean you start that VM with -incoming 'exec:cat /path/to/vm.img'?
But google stress test doesn't report any error until you start
migration _and_ it finishe
Signed-off-by: Igor Mammedov
---
hw/i386/acpi-build.c | 55 ++
1 files changed, 55 insertions(+), 0 deletions(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 1dbe5ce..f0bedbd 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-
Am 07.02.2014 12:21, schrieb Paolo Bonzini:
> Il 07/02/2014 12:09, Andreas Färber ha scritto:
>>> No matter how much I like QOM (I do), I would rather say that the all
>>> QOM grand plan has been "inconclusive". 99% in-tree uses of QOM are
>>> just a glorified qdev, buses and all. You shouldn't b
On 02/07/2014 02:54 PM, Marcin Gibuła wrote:
It is more a NFS issue, if you have a file in NFS that two users in
two different host are accessing (one at least write to it) you will
need to enforce the "sync" option.
Even if you flush all the data and close the file the NFS client can still
have
Hi,
Am 07.02.2014 14:19, schrieb Paolo Bonzini:
> Il 07/02/2014 14:04, Stefan Priebe - Profihost AG ha scritto:
>> first of all i've now a memory image of a VM where i can reproduce it.
>
> You mean you start that VM with -incoming 'exec:cat /path/to/vm.img'?
> But google stress test doesn't repor
On 07.02.2014 14:36, Orit Wasserman wrote:
Do you know if is applies to linux O_DIRECT writes as well?
From the man of open:
The behaviour of O_DIRECT with NFS will differ from local
filesystems. Older kernels, or kernels configured in certain ways,
may not support t
In the past, IO space could not be mapped into the memory address space
so we introduced a workaround for that. Nowadays it does not look
necessary so we can remove the workaround and make sPAPR PCI
configuration simplier.
Signed-off-by: Greg Kurz
---
There has been a previous post for this patc
it's always the same "pattern" there are too many 0 instead of X.
only seen:
read:0x ... expected:0x
or
read:0x ... expected:0x
or
read:0xbf00bf00 ... expected:0xbfffbfff
or
read:0x ... expected:
Am 07.02.2014 14:06, schrieb Paolo Bonzini:
> Il 07/02/2014 13:44, Andreas Färber ha scritto:
>> Am 07.02.2014 12:21, schrieb Paolo Bonzini:
>>> Let's stop talking about theory and let's look at the actual ccode,
>>> please.
>>
>> I have posted actual patches, you haven't.
>
> I have reviewed thos
On 02/07/2014 03:44 PM, Marcin Gibuła wrote:
On 07.02.2014 14:36, Orit Wasserman wrote:
Do you know if is applies to linux O_DIRECT writes as well?
From the man of open:
The behaviour of O_DIRECT with NFS will differ from local
filesystems. Older kernels, or kernels configu
On 6 February 2014 20:50, Stefan Weil wrote:
> Am 06.02.2014 19:32, schrieb Legorol:
>> I am trying to run Windows 98 SE in Qemu. Under version 1.7.0 on a
>> Windows 7 64-bit host, it fails to boot.
>>
>> The symptom is that the guest hangs on the boot screen with the
>> full-screen Windows 98 log
On 07.02.2014, at 14:44, Greg Kurz wrote:
> In the past, IO space could not be mapped into the memory address space
> so we introduced a workaround for that. Nowadays it does not look
> necessary so we can remove the workaround and make sPAPR PCI
> configuration simplier.
>
> Signed-off-by: Gre
Le Friday 07 Feb 2014 à 09:14:50 (+0530), Bharata B Rao a écrit :
> On Wed, Feb 05, 2014 at 08:25:36PM +0100, Benoît Canet wrote:
> > Le Tuesday 04 Feb 2014 à 14:26:58 (-0500), Jeff Cody a écrit :
> > >
> > > +static void qemu_gluster_parse_flags(int bdrv_flags, int *open_flags)
> > > +{
> > > +
Paolo Bonzini writes:
> Il 06/02/2014 15:30, Markus Armbruster ha scritto:
>> Visitors get passed a pointer to the visited object. The generated
>> visitors try to cope with this pointer being null in some places, for
>> instance like this:
>>
>> visit_start_optional(m, obj ? &(*obj)->has_na
Il 07/02/2014 14:48, Andreas Färber ha scritto:
And let me repeat that
*reverting a broken patch should always be one of the alternatives*.
Yes. But it has never been *mandatory* to revert things first before
fixing them. We usually apply incremental fixes referencing the commit
hash that brok
On 06/02/14 23:40, Paolo Bonzini wrote:
Commit 360e607 (address_space_translate: do not cross page boundaries,
2014-01-30) broke MMIO accesses in cases where the section is shorter
than the full register width. This can happen for example with the
Bochs DISPI registers, which are 16 bits wide b
Recursively walk all properties under /machine and try to retrieve their
value. This is a regression test for link<> properties.
Cf. be2f78b6b062eec5170e2612299fb8953046993f
Signed-off-by: Andreas Färber
---
tests/qom-test.c | 38 ++
1 file changed, 38 insert
Il 07/02/2014 15:23, Markus Armbruster ha scritto:
> No objections to patch 1-9.
What does it take make you accept PATCH 10?
The email you just wrote, basically, :) and removing the NULL pointer
checks in the visitor implementations.
Paolo
bdrv_acct_done was called unconditional. But in case the ioreq has no
segments there is no matching bdrv_acct_start call. This could lead to
bogus accounting values.
Found by code inspection.
Signed-off-by: Olaf Hering
---
v2:
add comment /* fall through */
hw/block/xen_disk.c | 14 +
Commit 360e607 (address_space_translate: do not cross page boundaries,
2014-01-30) broke MMIO accesses in cases where the section is shorter
than the full register width. This can happen for example with the
Bochs DISPI registers, which are 16 bits wide but have only a 1-byte
long MemoryRegion (if
On 02/06/2014 11:26 AM, Lluís Vilanova wrote:
>> > At which point, option 2 would be the best bet, I think.
> Right. For the 3rd option I was also thinking about having per-vCPU tracing
> states (in the case of guest events), so that you can trace separate events
> depending on the vCPU.
>
> Which
On Fri, 7 Feb 2014, Paolo Bonzini wrote:
> Commit 360e607 (address_space_translate: do not cross page boundaries,
> 2014-01-30) broke MMIO accesses in cases where the section is shorter
> than the full register width. This can happen for example with the
> Bochs DISPI registers, which are 16 bits
On Fri, 7 Feb 2014, Olaf Hering wrote:
> bdrv_acct_done was called unconditional. But in case the ioreq has no
> segments there is no matching bdrv_acct_start call. This could lead to
> bogus accounting values.
>
> Found by code inspection.
>
> Signed-off-by: Olaf Hering
added to my queue, I'll
Andreas Färber writes:
> Am 07.02.2014 14:06, schrieb Paolo Bonzini:
>> Il 07/02/2014 13:44, Andreas Färber ha scritto:
>>> Am 07.02.2014 12:21, schrieb Paolo Bonzini:
Let's stop talking about theory and let's look at the actual ccode,
please.
>>>
>>> I have posted actual patches, you h
On Fri, Feb 07, Stefano Stabellini wrote:
> added to my queue, I'll fix the tab manually
Thanks, sorry for the TAB.
Olaf
On 7 February 2014 14:49, Richard Henderson wrote:
> On 02/06/2014 11:26 AM, Lluís Vilanova wrote:
>>> > At which point, option 2 would be the best bet, I think.
>> Right. For the 3rd option I was also thinking about having per-vCPU tracing
>> states (in the case of guest events), so that you can
Peter Maydell writes:
> On 7 February 2014 14:49, Richard Henderson wrote:
>> On 02/06/2014 11:26 AM, Lluís Vilanova wrote:
> At which point, option 2 would be the best bet, I think.
>>> Right. For the 3rd option I was also thinking about having per-vCPU tracing
>>> states (in the case of gu
On Fri, Feb 07, 2014 at 03:22:29PM +0100, Benoît Canet wrote:
> Le Friday 07 Feb 2014 à 09:14:50 (+0530), Bharata B Rao a écrit :
> > On Wed, Feb 05, 2014 at 08:25:36PM +0100, Benoît Canet wrote:
> > > Le Tuesday 04 Feb 2014 à 14:26:58 (-0500), Jeff Cody a écrit :
> > > >
> > > > +static void qem
IRQNoFlags on HPET._CRS crashes WinXP because it causes the HPET
to conflict with the system timer and/or the RTC. It only occurs
on Apple hardware, and even there it is exposed fully only when
OS X is detected (via _OSI). Recent OS X versions work on QEMU
without this statement, so at this time th
Il 06/02/2014 14:38, Gabriel L. Somlo ha scritto:
But anyhow, right now QEMU seems to be making relatively minor tweaks
to something that's firmly at home in SeaBIOS, which is why I sent my
patches to the latter...
Yeah, that's correct. There's really no particular hook in QEMU to do this.
Pa
On Wed, Feb 05, 2014 at 06:01:13PM +0100, Andreas Färber wrote:
> +#include "libqtest.h"
> +
> +#include
> +#include
> +#include "qemu/osdep.h"
Please put includes before "user.h" includes. That way we
can be sure our macros don't mess up system headers.
> +
> +static void nop(void)
> +{
> +}
On Wed, Feb 05, 2014 at 06:01:12PM +0100, Andreas Färber wrote:
> Hello Stefan,
>
> As discussed late last year, this series starts preparing tests to cover
> optional NICs. They don't do any functional tests but assure that QOM/PCI
> refactorings don't break the basic usage of these devices.
>
>
Le Friday 07 Feb 2014 à 20:57:35 (+0530), Bharata B Rao a écrit :
> On Fri, Feb 07, 2014 at 03:22:29PM +0100, Benoît Canet wrote:
> > Le Friday 07 Feb 2014 à 09:14:50 (+0530), Bharata B Rao a écrit :
> > > On Wed, Feb 05, 2014 at 08:25:36PM +0100, Benoît Canet wrote:
> > > > Le Tuesday 04 Feb 2014
This adds assertions that the request that we actually end up passing to
the block driver (which includes RMW data and has therefore potentially
been rounded to alignment boundaries) is fully covered by the
overlap_{offset,size} fields of the associated BdrvTrackedRequest.
Suggested-by: Laszlo Ers
The error path for a failure in one of the two bdrv_aligned_preadv()
calls leaked head_buf or tail_buf, respectively. This fixes the memory
leak.
Reported-by: Laszlo Ersek
Signed-off-by: Kevin Wolf
---
block.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block.c b/blo
1 - 100 of 176 matches
Mail list logo
