[Qemu-devel] [PATCH qom-test] qom-test: Test QOM properties

[Andreas Färber]

Recursively walk all properties under /machine and try to retrieve their
value. This is a regression test for link<> properties.

Cf. be2f78b6b062eec5170e2612299fb8953046993f

Signed-off-by: Andreas Färber <afaer...@suse.de>
---
 tests/qom-test.c | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/tests/qom-test.c b/tests/qom-test.c
index 3316a11..779cd1d 100644
--- a/tests/qom-test.c
+++ b/tests/qom-test.c
@@ -10,6 +10,7 @@
 
 #include <glib.h>
 #include <string.h>
+#include "qemu-common.h"
 #include "qemu/osdep.h"
 #include "qapi/qmp/types.h"
 
@@ -42,6 +43,39 @@ static bool is_blacklisted(const char *arch, const char 
*mach)
     return false;
 }
 
+static void test_properties(const char *path)
+{
+    char *cmd, *child_path;
+    QDict *response, *tuple;
+    QList *list;
+    QListEntry *entry;
+
+    cmd = g_strdup_printf("{ 'execute': 'qom-list',"
+                          "  'arguments': { 'path': '%s' } }", path);
+    response = qmp(cmd);
+    g_free(cmd);
+
+    g_assert(qdict_haskey(response, "return"));
+    list = qobject_to_qlist(qdict_get(response, "return"));
+    QLIST_FOREACH_ENTRY(list, entry) {
+        tuple = qobject_to_qdict(qlist_entry_obj(entry));
+        if (strstart(qdict_get_str(tuple, "type"), "child<", NULL)) {
+            child_path = g_strdup_printf("%s/%s",
+                                         path, qdict_get_str(tuple, "name"));
+            test_properties(child_path);
+            g_free(child_path);
+        } else {
+            cmd = g_strdup_printf("{ 'execute': 'qom-get',"
+                                  "  'arguments': { 'path': '%s',"
+                                  "                 'property': '%s' } }",
+                                  path, qdict_get_str(tuple, "name"));
+            response = qmp(cmd);
+            g_free(cmd);
+            /* This may fail but should not, e.g., segfault. */
+        }
+    }
+}
+
 static void test_machine(gconstpointer data)
 {
     const char *machine = data;
@@ -50,8 +84,12 @@ static void test_machine(gconstpointer data)
 
     args = g_strdup_printf("-machine %s", machine);
     qtest_start(args);
+
+    test_properties("/machine");
+
     response = qmp("{ 'execute': 'quit' }");
     g_assert(qdict_haskey(response, "return"));
+
     qtest_end();
     g_free(args);
 }
-- 
1.8.4.5