Re: [Qemu-devel] [PULL] VirtFS update

2014-02-05 Thread Aneesh Kumar K.V
Adding the correct email address for Anthony. -aneesh "Aneesh Kumar K.V" writes: > Hi Anthony, > > Please pull the below update for VirtFS > > The following changes since commit 2f61120c10da9128357510debc8e66880cd2bfdc: > > Merge remote-tracking branch 'qmp-unstable/queue/qmp' into staging

[Qemu-devel] [PATCH] Revert "nand: Don't inherit from Sysbus"

2014-02-05 Thread Markus Armbruster
This reverts commit 7426aa72c36c908a7d0eae3e38568bb0a70de479. The commit goes into a sensible direction, but it violates qdev design assumptions. Symptom: "info qtree" crashes for all boards including the device (akita, borzoi, spitz, terrier, tosa, axis-dev88). Peter Crosthwaite is working on a

Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus

2014-02-05 Thread Markus Armbruster
Peter Crosthwaite writes: > On Tue, Feb 4, 2014 at 7:28 PM, Markus Armbruster wrote: >> Markus Armbruster writes: >> >>> Peter Crosthwaite writes: >>> On Wed, Jan 8, 2014 at 11:47 PM, Paolo Bonzini wrote: > Il 08/01/2014 14:40, Andreas Färber ha scritto: >> > Either you fix "info

Re: [Qemu-devel] [PATCH] trace backend: introduce multi tracing backend

2014-02-05 Thread Kazuya Saito
(2014/02/04 18:02), Stefan Hajnoczi wrote:> On Tue, Feb 04, 2014 at 02:26:13PM +0900, Kazuya Saito wrote: >> > (2014/01/31 19:37), Stefan Hajnoczi wrote:> On Tue, Jan 28, 2014 at >> > 01:35:20PM +0900, Kazuya Saito wrote: > >> def h(events): > >> +pass >>> > > >>> > > I thought all

Re: [Qemu-devel] [PATCH] Revert "nand: Don't inherit from Sysbus"

2014-02-05 Thread Andreas Färber
Am 05.02.2014 09:39, schrieb Markus Armbruster: > This reverts commit 7426aa72c36c908a7d0eae3e38568bb0a70de479. > > The commit goes into a sensible direction, but it violates qdev design > assumptions. Symptom: "info qtree" crashes for all boards including > the device (akita, borzoi, spitz, terr

Re: [Qemu-devel] [PATCH] sparc/leon3: Initialize stack pointer

2014-02-05 Thread Fabien Chouteau
On 02/03/2014 10:18 AM, Sebastian Huber wrote: > A lot of real world LEON3 systems are shipped with the GRMON boot > loader. This boot loader initializes the stack pointer with the end of > RAM address. The application can use this to detect the RAM size of a > particular board variant. > Looks

Re: [Qemu-devel] migration: broken ram_save_pending

2014-02-05 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > Il 04/02/2014 23:17, Alexey Kardashevskiy ha scritto: > > Well, it will fix it in my particular case but in a long run this does > > not > > feel like a fix - there should be a way for migration_thread() to know > > that > > ram_s

Re: [Qemu-devel] slirp smb with modern win guests when samba is also running on host

2014-02-05 Thread Michael Tokarev
Ping? It's been more than 2 months already... Thanks, /mjt 28.11.2013 23:32, Michael Tokarev wrote: > After numerous reports that -smb (or -netdev user,smb=foo) not working > with modern windows (win7 and vista are reported as non-working), I > started digging myself. And found that indeed it

Re: [Qemu-devel] [PATCH] SPARC: Add and use CPU_FEATURE_CASA

2014-02-05 Thread Fabien Chouteau
On 11/26/2013 03:04 PM, Sebastian Huber wrote: > The LEON3 processor has support for the CASA instruction which is > normally only available for SPARC V9 processors. Binutils 2.24 > and GCC 4.9 will support this instruction for LEON3. GCC uses it to > generate C11 atomic operations. The patch lo

Re: [Qemu-devel] [Qemu-trivial] [PATCH] sparc/leon3: Initialize stack pointer

2014-02-05 Thread Fabien Chouteau
On 02/05/2014 10:02 AM, Fabien Chouteau wrote: > On 02/03/2014 10:18 AM, Sebastian Huber wrote: >> A lot of real world LEON3 systems are shipped with the GRMON boot >> loader. This boot loader initializes the stack pointer with the end of >> RAM address. The application can use this to detect the

Re: [Qemu-devel] [PATCH] SPARC: Add and use CPU_FEATURE_CASA

2014-02-05 Thread Fabien Chouteau
On 02/05/2014 10:21 AM, Fabien Chouteau wrote: > On 11/26/2013 03:04 PM, Sebastian Huber wrote: >> The LEON3 processor has support for the CASA instruction which is >> normally only available for SPARC V9 processors. Binutils 2.24 >> and GCC 4.9 will support this instruction for LEON3. GCC uses i

Re: [Qemu-devel] kvm control qemu-system-aarch64 state

2014-02-05 Thread Claudio Fontana
On 4 February 2014 20:40, Christoffer Dall wrote: > On Tue, Feb 04, 2014 at 04:52:08PM +, Peter Maydell wrote: >> On 4 February 2014 16:37, Claudio Fontana wrote: >> > On 4 February 2014 16:39, Peter Maydell wrote: >> >> On 4 February 2014 15:36, Claudio Fontana wrote: >> >> > I just wanted

Re: [Qemu-devel] [Qemu-ppc] [V2 PATCH 6/9] target-ppc: Load Quadword

2014-02-05 Thread Alexander Graf
On 31.01.2014, at 20:34, Tom Musta wrote: > This patch adds the Book I (user space) Load Quadword (lq) instruction. > This instruction was introduced into Book I in Power ISA V2.07. Previous > versions of the architecture supported this as a privileged instruction. > Previous versions of the ar

Re: [Qemu-devel] [Qemu-ppc] [V2 PATCH 9/9] target-ppc: Add Store Quadword Conditional

2014-02-05 Thread Alexander Graf
On 31.01.2014, at 20:34, Tom Musta wrote: > This patch adds the Store Quadword Conditionl (stqcx.) instruction > which is introduced in Power ISA 2.07. > > Signed-off-by: Tom Musta > --- > V2: Updated linux-user/main.c to use the newly added reserve_val2. > > linux-user/main.c | 18 +++

Re: [Qemu-devel] Bug#728876: qemu: smbd forked by qemu uses global directory /var/run/samba/ncalrpc

2014-02-05 Thread Michael Tokarev
Ping? Again, more than 2 months passed since initial submission. Thanks, /mjt 29.11.2013 00:15, Michael Tokarev wrote: > Jan, there's one more samba-related fix for slirp, also from Michael Büsch. > > Add my > > Signed-off-By: Michael Tokarev > > if needed. > > Thanks, > > /mjt > > 06.11

Re: [Qemu-devel] [PATCH] qemu: Broken -smb with latest SAMBA package. (Unsupported security=share option)

2014-02-05 Thread Michael Tokarev
On Sun, 03 Nov 2013 21:06:22 +0100, Jan Kiszka wrote: > On 2013-11-01 11:10, Michael Tokarev wrote: >> 01.11.2013 13:54, Michael Büsch wrote: >>> On Fri, 01 Nov 2013 13:32:49 +0400 >>> Michael Tokarev wrote: >>> That looks right. Are you okay adding your Signed-off-by to the patch you i

Re: [Qemu-devel] [PATCH] SPARC: Add and use CPU_FEATURE_CASA

2014-02-05 Thread Fabien Chouteau
On 11/28/2013 10:55 AM, Sebastian Huber wrote: > Hello, > > On 2013-11-26 15:04, Sebastian Huber wrote: >> The LEON3 processor has support for the CASA instruction which is >> normally only available for SPARC V9 processors. Binutils 2.24 >> and GCC 4.9 will support this instruction for LEON3. G

Re: [Qemu-devel] qemu segfauls with spiceport chardev and isa-serial

2014-02-05 Thread Dr. David Alan Gilbert
* Peter Crosthwaite (peter.crosthwa...@xilinx.com) wrote: > On Tue, Feb 4, 2014 at 4:45 AM, Dr. David Alan Gilbert > wrote: > > (cc'ing in Peter Crosthwaite and Michael Tokarev due to a serial fifo change > > - see below!) > > > > * Martin Kletzander (mklet...@redhat.com) wrote: > >> Hello, > > >

Re: [Qemu-devel] qemu segfauls with spiceport chardev and isa-serial

2014-02-05 Thread Martin Kletzander
On Tue, Feb 04, 2014 at 07:05:24AM +0100, Martin Kletzander wrote: > On Tue, Feb 04, 2014 at 11:40:41AM +1000, Peter Crosthwaite wrote: > > On Tue, Feb 4, 2014 at 4:45 AM, Dr. David Alan Gilbert > > wrote: > > > (cc'ing in Peter Crosthwaite and Michael Tokarev due to a serial fifo > > > change >

Re: [Qemu-devel] [PATCH v2 09/35] target-arm: A64: Implement MSR (immediate) instructions

2014-02-05 Thread Peter Maydell
On 5 February 2014 06:23, Peter Crosthwaite wrote: > On Sat, Feb 1, 2014 at 1:45 AM, Peter Maydell > wrote: >> Implement the MSR (immediate) instructions, which can update the >> PSTATE SP and DAIF fields. >> >> Signed-off-by: Peter Maydell >> --- >> target-arm/cpu.h | 1 + >> targe

Re: [Qemu-devel] [PATCH v2 12/35] target-arm: Convert performance monitor reginfo to accesfn

2014-02-05 Thread Peter Maydell
On 5 February 2014 06:59, Peter Crosthwaite wrote: > cc Alistair, this may conflict with his timer work. > > On Sat, Feb 1, 2014 at 1:45 AM, Peter Maydell > wrote: >> @@ -624,37 +606,41 @@ static const ARMCPRegInfo v7_cp_reginfo[] = { >> { .name = "PMCNTENSET", .cp = 15, .crn = 9, .crm = 12

Re: [Qemu-devel] [PATCH 13/12] qapi: refine human printing of sizes

2014-02-05 Thread Igor Mammedov
On Thu, 30 Jan 2014 17:42:25 +0100 Paolo Bonzini wrote: > This fixes several bugs or shortcomings of the previous pretty-printer. > In particular: > > * use PRIu64 instead of casting to long long > > * the exact value is included too > > * the correct unit of measure (MiB, GiB, etc.) is used.

Re: [Qemu-devel] [PATCH 00/12] qdev: cleanup legacy properties

2014-02-05 Thread Igor Mammedov
On Thu, 30 Jan 2014 14:09:42 +0100 Paolo Bonzini wrote: > The conversion of qdev to QOM brought with it legacy properties. > Legacy properties are always have a string type (the accessors always > call visit_type_str), and were used to support -device syntax while > keeping QOM properties strongl

[Qemu-devel] [PATCH] Remove trailing space from error message

2014-02-05 Thread Orit Wasserman
Signed-off-by: Orit Wasserman --- migration.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration.c b/migration.c index 25add6f..cc18f6c 100644 --- a/migration.c +++ b/migration.c @@ -482,7 +482,7 @@ void qmp_migrate_set_cache_size(int64_t value, Error **errp) /* Ca

Re: [Qemu-devel] [PATCH] Revert "nand: Don't inherit from Sysbus"

2014-02-05 Thread Markus Armbruster
Andreas Färber writes: > Am 05.02.2014 09:39, schrieb Markus Armbruster: >> This reverts commit 7426aa72c36c908a7d0eae3e38568bb0a70de479. >> >> The commit goes into a sensible direction, but it violates qdev design >> assumptions. Symptom: "info qtree" crashes for all boards including >> the de

[Qemu-devel] Interrupt handling

2014-02-05 Thread Ayaz Akram
According to my understanding of interrupt handling mechanism in QEMU, when some external interrupt comes, related device emulation code (e.g. kbd_update_irq in pckbd.c ---> qemu_set_irq> ) runs in vcpu thread and io-thread when finds that some interrupt has occured sends signal to

Re: [Qemu-devel] [PATCH] Revert "nand: Don't inherit from Sysbus"

2014-02-05 Thread Peter Maydell
On 5 February 2014 12:24, Markus Armbruster wrote: > As to why it's complicated for Peter to fix, here's what Peter wrote: > "That series got very big on me with complications. I think near term > we just proceed with the revert. Sorry for the delay." I have no > reason to second-guess him. > >

Re: [Qemu-devel] WfW setup and DOS display.sys hanging

2014-02-05 Thread Gerd Hoffmann
[ adding seabios list ] On Di, 2014-02-04 at 20:47 +0100, Kevin Wolf wrote: > Hi Gerd, > > Am 09.01.2014 um 00:20 hat Sebastian geschrieben: > > Hi, > > > > I noticed in newer versions of Qemu (Debian Jessie) a regression > > causing DISPLAY.SYS from MS-DOS 6.22 to hang the system as soon as > >

Re: [Qemu-devel] [PATCH V15 01/13] quorum: Create quorum.c, add QuorumSingleAIOCB and QuorumAIOCB.

2014-02-05 Thread Benoît Canet
Le Tuesday 04 Feb 2014 à 13:57:07 (+0100), Kevin Wolf a écrit : > Am 03.02.2014 um 22:51 hat Benoît Canet geschrieben: > > From: Benoît Canet > > > > Signed-off-by: Benoit Canet > > Reviewed-by: Max Reitz > > --- > > block/Makefile.objs | 1 + > > block/quorum.c | 54 > > +++

Re: [Qemu-devel] [PATCH] Remove trailing space from error message

2014-02-05 Thread Eric Blake
On 02/05/2014 04:53 AM, Orit Wasserman wrote: > Signed-off-by: Orit Wasserman > --- > migration.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake > > diff --git a/migration.c b/migration.c > index 25add6f..cc18f6c 100644 > --- a/migration.c > +++ b/migration.c

Re: [Qemu-devel] [PATCH V2] Add Enhanced Three-Speed Ethernet Controller (eTSEC)

2014-02-05 Thread Fabien Chouteau
On 12/10/2013 06:20 PM, Alexander Graf wrote: > On 10.12.2013, at 18:15, Fabien Chouteau wrote: >> Unfortunately I won't have time to fix before January. > Hello Alex, I fixed the compiler errors and I will send version 3 in few minutes. > That works for me. While at it, please also add a pat

[Qemu-devel] [PATCH v6] vl.c: Output error on invalid machine type

2014-02-05 Thread mrezanin
From: Miroslav Rezanina Output error message using qemu's error_report() function when user provides the invalid machine type on the command line. This also saves time to find what issue is when you downgrade from one version of qemu to another that doesn't support required machine type yet (the

Re: [Qemu-devel] [PATCH] tests/Makefile: Run qom-test for every architecture

2014-02-05 Thread Andreas Färber
Am 04.02.2014 10:16, schrieb Markus Armbruster: > Peter Maydell writes: > >> Rather than requiring every new architecture to remember to add a line >> to the Makefile to say that qom-test will work on it, autogenerate >> the list of supported architectures by looking at the files in >> default-co

Re: [Qemu-devel] [PATCH v3 4/9] ide: Drop redundant IDEState member bs

2014-02-05 Thread Markus Armbruster
[Note cc: Stefano] Kevin Wolf writes: > Am 30.01.2014 um 13:16 hat Markus Armbruster geschrieben: >> It's a copy of dev->conf.bs. The copy was needed for non-qdevified >> controllers, which lacked dev. >> >> Note how pci_piix3_xen_ide_unplug() cleared the copy. We'll get back >> to that in th

[Qemu-devel] [PATCH] qdev: Fix qdev_try_create() for bus-less devices

2014-02-05 Thread Andreas Färber
Commit 7426aa72c36c908a7d0eae3e38568bb0a70de479 (nand: Don't inherit from Sysbus) made NAND a device rather than SysBus device. This led to all boards using the device (akita, borzoi, spitz, terrier, tosa, axis-dev88) crashing on "info qtree". The difference to the bus-less ARMCPU is that the devi

Re: [Qemu-devel] [PATCH V15 03/13] quorum: Add quorum_aio_writev and its dependencies.

2014-02-05 Thread Benoît Canet
Le Tuesday 04 Feb 2014 à 14:57:22 (+0100), Kevin Wolf a écrit : > Am 03.02.2014 um 22:51 hat Benoît Canet geschrieben: > > From: Benoît Canet > > > > Signed-off-by: Benoit Canet > > --- > > block/quorum.c | 104 > > + > > 1 file changed,

Re: [Qemu-devel] [PATCH] Revert "nand: Don't inherit from Sysbus"

2014-02-05 Thread Peter Maydell
On 5 February 2014 13:00, Peter Maydell wrote: > On 5 February 2014 12:24, Markus Armbruster wrote: >> As to why it's complicated for Peter to fix, here's what Peter wrote: >> "That series got very big on me with complications. I think near term >> we just proceed with the revert. Sorry for the

[Qemu-devel] [PATCH] nand: Don't use qdev_create() in nand_init()

2014-02-05 Thread Andreas Färber
Commit 7426aa72c36c908a7d0eae3e38568bb0a70de479 (nand: Don't inherit from Sysbus) changed the parent type of TYPE_NAND but continued to use qdev_create(), which handled a NULL BusState as SysBus. Use object_new() instead, and reuse the TYPE_NAND define while at it. Reported-by: Markus Armbruster

Re: [Qemu-devel] [PATCH qom-cpu 00/16 v10] target-i386: convert CPU features into properties

2014-02-05 Thread Igor Mammedov
On Sun, 15 Dec 2013 23:50:47 +0100 Andreas Färber wrote: > Am 27.11.2013 23:28, schrieb Igor Mammedov: > > Igor Mammedov (16): > > target-i386: cleanup 'foo' feature handling' > > target-i386: cleanup 'foo=val' feature handling > > Thanks, I've queued these on qom-cpu-next: > https://github.

Re: [Qemu-devel] [PATCH] nand: Don't use qdev_create() in nand_init()

2014-02-05 Thread Igor Mammedov
On Wed, 5 Feb 2014 15:30:53 +0100 Andreas Färber wrote: > Commit 7426aa72c36c908a7d0eae3e38568bb0a70de479 (nand: Don't inherit > from Sysbus) changed the parent type of TYPE_NAND but continued to use > qdev_create(), which handled a NULL BusState as SysBus. > > Use object_new() instead, and reu

Re: [Qemu-devel] [PATCH] Revert "nand: Don't inherit from Sysbus"

2014-02-05 Thread Markus Armbruster
Peter Maydell writes: > On 5 February 2014 13:00, Peter Maydell wrote: >> On 5 February 2014 12:24, Markus Armbruster wrote: >>> As to why it's complicated for Peter to fix, here's what Peter wrote: >>> "That series got very big on me with complications. I think near term >>> we just proceed w

Re: [Qemu-devel] [PATCH] qtest: don't report signals if qtest driver enabled

2014-02-05 Thread Andreas Färber
Am 04.02.2014 19:06, schrieb Michael S. Tsirkin: > qtest driver always uses signals to kill qemu > no need to report it, whatever the accelerator state. > > Add API to detect qtest driver, and suppress reporting > signals in this case. > > Reported-by: Andreas Färber > Signed-off-by: Michael S.

Re: [Qemu-devel] [PATCH] qtest: don't report signals if qtest driver enabled

2014-02-05 Thread Michael S. Tsirkin
On Wed, Feb 05, 2014 at 04:05:55PM +0100, Andreas Färber wrote: > Am 04.02.2014 19:06, schrieb Michael S. Tsirkin: > > qtest driver always uses signals to kill qemu > > no need to report it, whatever the accelerator state. > > > > Add API to detect qtest driver, and suppress reporting > > signals

Re: [Qemu-devel] [PATCH V15 06/13] quorum: Add quorum mechanism.

2014-02-05 Thread Benoît Canet
Le Tuesday 04 Feb 2014 à 16:40:12 (+0100), Kevin Wolf a écrit : > Am 03.02.2014 um 22:51 hat Benoît Canet geschrieben: > > From: Benoît Canet > > > > Use gnutls's SHA-256 to compare versions. > > > > Signed-off-by: Benoit Canet > > --- > > block/Makefile.objs | 2 +- > > block/quorum.c

[Qemu-devel] [PATCH v6 0/9] Refactor PCI/SHPC/PCIE hotplug to use a more generic hotplug API

2014-02-05 Thread Igor Mammedov
changes since v5: - fixed typos Eric pointed to - fix conflict of [5/9] with new patch "acpi-build: append description for non-hotplug" - rebased on top of todays PCI tree changes since v4: - rebased on top of PCI tree - added wrapper to set hotplug-device property changes since v3: - fixu

[Qemu-devel] [PATCH v6 2/9] qdev: add to BusState "hotplug-handler" link

2014-02-05 Thread Igor Mammedov
It will allow to reuse field with different BUSes, reducing code duplication. Field is intended for replacing 'hotplug_qdev' field in PCIBus and also will allow to avoid adding equivalent field to DimmBus with possiblitity to refactor other BUSes to use it instead of custom field. In addition once

[Qemu-devel] [PATCH v6 3/9] qdev: add "hotpluggable" property to Device

2014-02-05 Thread Igor Mammedov
Currently it's possible to make PCIDevice not hotpluggable by using no_hotplug field of PCIDeviceClass. However it limits this only to PCI devices and prevents from generalizing hotplug code. So add similar field to DeviceClass so it could be reused with other Devices and would allow to replace PC

[Qemu-devel] [PATCH v6 8/9] pci/pcie: convert PCIE hotplug to use hotplug-handler API

2014-02-05 Thread Igor Mammedov
Split pcie_cap_slot_hotplug() into hotplug/unplug callbacks and register them as "hotplug-handler" interface implementation of PCIE_SLOT device. Replace pci_bus_hotplug() wiring with setting link on PCI BUS "hotplug-handler" property to PCI_BRIDGE_DEV device. Signed-off-by: Igor Mammedov --- v2:

[Qemu-devel] [PATCH v6 4/9] hw/acpi: move typeinfo to the file end

2014-02-05 Thread Igor Mammedov
do so to avoid not necessary forward declarations and place typeinfo registration at the file end where it's usually expected. Signed-off-by: Igor Mammedov --- v2: * fix typo in commit message s/usualy/usually/ --- hw/acpi/piix4.c | 92 +++--- 1

[Qemu-devel] [PATCH v6 1/9] define hotplug interface

2014-02-05 Thread Igor Mammedov
Provide a generic hotplug interface for hotplug handlers. Intended for replacing hotplug mechanism used by PCI/PCIE/SHPC code and will be used for memory hotplug. Signed-off-by: Igor Mammedov --- v4: * s/2013/2014/ in copyright headers v3: * amend commit description as requested by Peter Crosthwa

[Qemu-devel] [PATCH v6 7/9] pci/shpc: convert SHPC hotplug to use hotplug-handler API

2014-02-05 Thread Igor Mammedov
Split shpc_device_hotplug() into hotplug/unplug callbacks and register them as "hotplug-handler" interface implementation of PCI_BRIDGE_DEV device. Replace pci_bus_hotplug() wiring with setting link on PCI BUS "hotplug-handler" property to PCI_BRIDGE_DEV device. Signed-off-by: Igor Mammedov ---

[Qemu-devel] [PATCH v6 9/9] hw/pci: switch to a generic hotplug handling for PCIDevice

2014-02-05 Thread Igor Mammedov
make qdev_unplug()/device_set_realized() to call hotplug handler's plug/unplug methods if available and remove not needed anymore hot(un)plug handling from PCIDevice. In case if hotplug handler is not available, revert to the legacy hotplug method for compatibility with not yet converted buses. S

[Qemu-devel] [PATCH v6 5/9] qdev:pci: refactor PCIDevice to use generic "hotpluggable" property

2014-02-05 Thread Igor Mammedov
Get rid of PCIDevice specific PCIDeviceClass.no_hotplug and use generic DeviceClass.hotpluggable field instead. Signed-off-by: Igor Mammedov --- v2: * move generic hotplug checks to "qdev: add "hotpluggable" property to Device" patch * s/hotplugable/hotpluggable/ --- hw/acpi/pcihp.c |

Re: [Qemu-devel] [PATCH 1/2] qom-test: Run for all available machines

2014-02-05 Thread Andreas Färber
Stefano, Am 10.01.2014 14:31, schrieb arm...@redhat.com: > From: Markus Armbruster > > Get available machines via QMP instead of hardcoding a list that's > perpetually out of date. > > A few machines don't work out of the box: [...] > * Xen machines can work only when running under the Xen hype

[Qemu-devel] [PATCH v6 6/9] acpi/piix4pm: convert ACPI PCI hotplug to use hotplug-handler API

2014-02-05 Thread Igor Mammedov
Split piix4_device_hotplug() into hotplug/unplug callbacks and register them as "hotplug-handler" interface implementation of PIIX4_PM device. Replace pci_bus_hotplug() wiring with setting link on PCI BUS "hotplug-handler" property to PIIX4_PM device. Signed-off-by: Igor Mammedov --- v3: * s/Not

[Qemu-devel] Get a vm fd using kvm API's ioctls

2014-02-05 Thread Vincent KHERBACHE
Hi all, I'm trying to get the dirty bitmap of a specific VM, using KVM_GET_DIRTY_LOG ioctl. For this purpose, I should be able to get the file descriptor of an existing VM by doing something like : kvm_fd = open("/dev/kvm") ... b = ioctl(KVM_GET_DIRTY_LOG, vm_fd) I also can see, from the API d

Re: [Qemu-devel] [PATCH v6 2/9] qdev: add to BusState "hotplug-handler" link

2014-02-05 Thread Andreas Färber
Am 05.02.2014 16:36, schrieb Igor Mammedov: > It will allow to reuse field with different BUSes, > reducing code duplication. Field is intended for > replacing 'hotplug_qdev' field in PCIBus and also > will allow to avoid adding equivalent field to > DimmBus with possiblitity to refactor other BUSe

Re: [Qemu-devel] [PATCH] Revert "nand: Don't inherit from Sysbus"

2014-02-05 Thread Paolo Bonzini
Il 05/02/2014 14:00, Peter Maydell ha scritto: While we're talking about regressions: Paolo, do we have a good fix for the PPC boot regression yet or should we revert the patch which caused that? Yes, Antony tested the patch on Xen. I'll send the patch as soon as possible. Paolo

Re: [Qemu-devel] [PATCH V15 12/13] quorum: Add quorum_open() and quorum_close().

2014-02-05 Thread Benoît Canet
Le Tuesday 04 Feb 2014 à 17:08:07 (+0100), Kevin Wolf a écrit : > Am 03.02.2014 um 22:51 hat Benoît Canet geschrieben: > > From: Benoît Canet > > > > Example of command line: > > -drive if=virtio,file.driver=quorum,\ > > file.children.0.file.filename=1.raw,\ > > file.children.0.node-name=1.raw,\

Re: [Qemu-devel] [Qemu-ppc] [V2 PATCH 6/9] target-ppc: Load Quadword

2014-02-05 Thread Tom Musta
On 2/5/2014 3:43 AM, Alexander Graf wrote: > I would've expected the compiler to emit a warning at this point because > you're declaring variables outside of the beginning of a scope? I did not see a warning on either of my test platforms (PowerPC/RHEL/GCC 4.4.7, Intel/Ubuntu/GCC 4.6.3). But I

Re: [Qemu-devel] [PATCH qom-cpu 00/16 v10] target-i386: convert CPU features into properties

2014-02-05 Thread Andreas Färber
Am 05.02.2014 15:40, schrieb Igor Mammedov: > On Sun, 15 Dec 2013 23:50:47 +0100 > Andreas Färber wrote: > >> Am 27.11.2013 23:28, schrieb Igor Mammedov: >>> Igor Mammedov (16): >>> target-i386: cleanup 'foo' feature handling' >>> target-i386: cleanup 'foo=val' feature handling >> >> Thanks,

Re: [Qemu-devel] [Qemu-ppc] [V2 PATCH 9/9] target-ppc: Add Store Quadword Conditional

2014-02-05 Thread Tom Musta
On 2/5/2014 3:48 AM, Alexander Graf wrote: > Does this work? After this val contains reserve_val2, but further down that > one gets checked against reserve_val so the comparison is broken, no? Yes. I believe you are correct. Thanks, Alex.

Re: [Qemu-devel] [Qemu-ppc] [V2 PATCH 6/9] target-ppc: Load Quadword

2014-02-05 Thread Eric Blake
On 02/05/2014 09:12 AM, Tom Musta wrote: > On 2/5/2014 3:43 AM, Alexander Graf wrote: >> I would've expected the compiler to emit a warning at this point because >> you're declaring variables outside of the beginning of a scope? > Only if you enforce C89 compilation. But qemu requires a C99 comp

Re: [Qemu-devel] [PATCH V15 09/13] quorum: Add quorum_co_get_block_status.

2014-02-05 Thread Benoît Canet
Le Tuesday 04 Feb 2014 à 16:49:22 (+0100), Kevin Wolf a écrit : > Am 03.02.2014 um 22:51 hat Benoît Canet geschrieben: > > From: Benoît Canet > > > > Signed-off-by: Benoit Canet > > Reviewed-by: Max Reitz > > --- > > block/quorum.c | 51 +++ > >

Re: [Qemu-devel] [PATCH v6 2/9] qdev: add to BusState "hotplug-handler" link

2014-02-05 Thread Igor Mammedov
On Wed, 05 Feb 2014 16:52:27 +0100 Andreas Färber wrote: > Am 05.02.2014 16:36, schrieb Igor Mammedov: > > It will allow to reuse field with different BUSes, > > reducing code duplication. Field is intended for > > replacing 'hotplug_qdev' field in PCIBus and also > > will allow to avoid adding e

Re: [Qemu-devel] [PATCH] pc_piix: enable legacy hotplug for Xen

2014-02-05 Thread Stefano Stabellini
On Tue, 4 Feb 2014, Sander Eikelenboom wrote: > Tuesday, February 4, 2014, 10:55:18 PM, you wrote: > > > Il 04/02/2014 22:32, Michael S. Tsirkin ha scritto: > >> xenfv has no fwcfg and so does not load acpi from QEMU. > >> as such new acpi features don't work. > >> > >> Reported-by: Sander Eikelen

Re: [Qemu-devel] migration: broken ram_save_pending

2014-02-05 Thread Paolo Bonzini
Il 05/02/2014 10:09, Dr. David Alan Gilbert ha scritto: I think the case Alexey is hitting is: 1 A few dirtied pages 2 but because of the hpratio most of the data is actually zero - indeed most of the target-page sized chunks are zero 3 Thus the data compresses very heavily 4 Whe

Re: [Qemu-devel] [PATCH 00/12] qdev: cleanup legacy properties

2014-02-05 Thread Paolo Bonzini
Il 05/02/2014 12:12, Igor Mammedov ha scritto: with fixed checkpatch error in 13/12 Reviewed-By: Igor Mammedov Andreas, can you ack it so that I can send a pull request myself? Thanks, Paolo

Re: [Qemu-devel] [PULL 0/8] Block patches

2014-02-05 Thread Peter Maydell
On 31 January 2014 21:19, Stefan Hajnoczi wrote: > The following changes since commit 89e4a51ca9546a7bbe1998c4e3d4a3ac3a0c19be: > > Merge remote-tracking branch 'stefanha/tags/tracing-pull-request' into > staging (2014-01-31 11:13:08 +) > > are available in the git repository at: > > > gi

Re: [Qemu-devel] [PATCH] qdev: Fix qdev_try_create() for bus-less devices

2014-02-05 Thread Paolo Bonzini
Il 05/02/2014 15:09, Andreas Färber ha scritto: diff --git a/hw/core/qdev.c b/hw/core/qdev.c index 82a9123..14c8765 100644 --- a/hw/core/qdev.c +++ b/hw/core/qdev.c @@ -131,21 +131,27 @@ DeviceState *qdev_create(BusState *bus, const char *name) DeviceState *qdev_try_create(BusState *bus, const c

Re: [Qemu-devel] [PATCH 00/12] qdev: cleanup legacy properties

2014-02-05 Thread Andreas Färber
Am 05.02.2014 17:36, schrieb Paolo Bonzini: > Il 05/02/2014 12:12, Igor Mammedov ha scritto: >> with fixed checkpatch error in 13/12 >> Reviewed-By: Igor Mammedov > > Andreas, can you ack it so that I can send a pull request myself? Since I just raised a question I cannot ack it yet. ;) But I ca

Re: [Qemu-devel] [PATCH] pc_piix: enable legacy hotplug for Xen

2014-02-05 Thread Stefano Stabellini
On Tue, 4 Feb 2014, Paolo Bonzini wrote: > Il 04/02/2014 22:32, Michael S. Tsirkin ha scritto: > > xenfv has no fwcfg and so does not load acpi from QEMU. > > as such new acpi features don't work. > > > > Reported-by: Sander Eikelenboom > > Signed-off-by: Michael S. Tsirkin > > --- > > > > Sand

Re: [Qemu-devel] migration: broken ram_save_pending

2014-02-05 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > Il 05/02/2014 10:09, Dr. David Alan Gilbert ha scritto: > >I think the case Alexey is hitting is: > > 1 A few dirtied pages > > 2 but because of the hpratio most of the data is actually zero > > - indeed most of the target-page sized chunks are

Re: [Qemu-devel] [PATCH] qdev: Fix qdev_try_create() for bus-less devices

2014-02-05 Thread Andreas Färber
Am 05.02.2014 17:38, schrieb Paolo Bonzini: > Il 05/02/2014 15:09, Andreas Färber ha scritto: >> diff --git a/hw/core/qdev.c b/hw/core/qdev.c >> index 82a9123..14c8765 100644 >> --- a/hw/core/qdev.c >> +++ b/hw/core/qdev.c >> @@ -131,21 +131,27 @@ DeviceState *qdev_create(BusState *bus, const >> ch

Re: [Qemu-devel] [PATCH] pc_piix: enable legacy hotplug for Xen

2014-02-05 Thread Paolo Bonzini
Il 05/02/2014 17:41, Stefano Stabellini ha scritto: > Yeah, especially because nowadays "-M pc" works with Xen. It would be nice if > fw_cfg could be enabled even for Xen on all machines except the legacy "-M > xenfv". > > Stefano, could you give it a shot now that you'll be soon done with 4.4?

Re: [Qemu-devel] [PATCH v6 2/9] qdev: add to BusState "hotplug-handler" link

2014-02-05 Thread Paolo Bonzini
Il 05/02/2014 16:52, Andreas Färber ha scritto: > +object_property_add_link(obj, QDEV_HOTPLUG_HANDLER_PROPERTY, > + TYPE_HOTPLUG_HANDLER, > + (Object **)&bus->hotplug_handler, NULL); Will/should the user ever change that property? If no

Re: [Qemu-devel] migration: broken ram_save_pending

2014-02-05 Thread Paolo Bonzini
Il 05/02/2014 17:42, Dr. David Alan Gilbert ha scritto: Because: * the code is still running and keeps redirtying a small handful of pages * but because we've underestimated our available bandwidth we never stop it and just throw those pages across immediately Ok, I thought Alexey

Re: [Qemu-devel] [PATCH] pc_piix: enable legacy hotplug for Xen

2014-02-05 Thread Stefano Stabellini
On Wed, 5 Feb 2014, Sander Eikelenboom wrote: > > On Tue, 4 Feb 2014, Sander Eikelenboom wrote: > >> Tuesday, February 4, 2014, 10:55:18 PM, you wrote: > >> > >> > Il 04/02/2014 22:32, Michael S. Tsirkin ha scritto: > >> >> xenfv has no fwcfg and so does not load acpi from QEMU. > >> >> as such ne

Re: [Qemu-devel] [PULL 0/7] Trivial patches for 2014-02-02

2014-02-05 Thread Peter Maydell
On 2 February 2014 16:12, Michael Tokarev wrote: > There's nothing exciting in there, some really small things here and there. > > Please pull. > > Thanks, > > /mjt > > The following changes since commit 89e4a51ca9546a7bbe1998c4e3d4a3ac3a0c19be: > > Merge remote-tracking branch 'stefanha/tags/tr

Re: [Qemu-devel] [PATCH qom-cpu 00/16 v10] target-i386: convert CPU features into properties

2014-02-05 Thread Igor Mammedov
On Wed, 05 Feb 2014 17:14:27 +0100 Andreas Färber wrote: > Am 05.02.2014 15:40, schrieb Igor Mammedov: > > On Sun, 15 Dec 2013 23:50:47 +0100 > > Andreas Färber wrote: > > > >> Am 27.11.2013 23:28, schrieb Igor Mammedov: > >>> Igor Mammedov (16): > >>> target-i386: cleanup 'foo' feature handl

Re: [Qemu-devel] [PATCH] pc_piix: enable legacy hotplug for Xen

2014-02-05 Thread Stefano Stabellini
On Wed, 5 Feb 2014, Paolo Bonzini wrote: > Il 05/02/2014 17:41, Stefano Stabellini ha scritto: > > > Yeah, especially because nowadays "-M pc" works with Xen. It would be > > nice if > > > fw_cfg could be enabled even for Xen on all machines except the legacy "-M > > > xenfv". > > > > > > Stefano,

Re: [Qemu-devel] [PATCH] pc_piix: enable legacy hotplug for Xen

2014-02-05 Thread Sander Eikelenboom
Wednesday, February 5, 2014, 5:35:32 PM, you wrote: > On Tue, 4 Feb 2014, Sander Eikelenboom wrote: >> Tuesday, February 4, 2014, 10:55:18 PM, you wrote: >> >> > Il 04/02/2014 22:32, Michael S. Tsirkin ha scritto: >> >> xenfv has no fwcfg and so does not load acpi from QEMU. >> >> as such new ac

[Qemu-devel] [PATCH qom-next 5/5] tests: Add eepro100 qtest

2014-02-05 Thread Andreas Färber
Signed-off-by: Andreas Färber --- tests/Makefile| 3 +++ tests/eepro100-test.c | 61 +++ 2 files changed, 64 insertions(+) create mode 100644 tests/eepro100-test.c diff --git a/tests/Makefile b/tests/Makefile index 867d931..4f9dd6d 100644

[Qemu-devel] [PATCH qom-next 0/5] qtest: Prepare PCI NIC tests

2014-02-05 Thread Andreas Färber
Hello Stefan, As discussed late last year, this series starts preparing tests to cover optional NICs. They don't do any functional tests but assure that QOM/PCI refactorings don't break the basic usage of these devices. pcnet-test.c is intended to handle sparc's lance as well. virtio-net is miss

[Qemu-devel] [PATCH 2/4] virtio-mmio: introduce set_guest_notifiers

2014-02-05 Thread Ying-Shiuan Pan
Same as host notifier of virtio-mmio, most of codes came from virtio-pci. The kvm-arm does not yet support irqfd, need to fix the hard-coded part after kvm-arm gets irqfd support. Signed-off-by: Ying-Shiuan Pan --- hw/virtio/virtio-mmio.c | 60 + 1

[Qemu-devel] [PATCH qom-next 1/5] tests: Add e1000 qtest

2014-02-05 Thread Andreas Färber
Cc: Stefan Hajnoczi Signed-off-by: Andreas Färber --- tests/Makefile | 7 +++ tests/e1000-test.c | 35 +++ 2 files changed, 42 insertions(+) create mode 100644 tests/e1000-test.c diff --git a/tests/Makefile b/tests/Makefile index 42a52ff..57e21fc 100644

[Qemu-devel] [PATCH 3/4] virtio-mmio: start ioeventfd when status gets DRIVER_OK

2014-02-05 Thread Ying-Shiuan Pan
Signed-off-by: Ying-Shiuan Pan --- hw/virtio/virtio-mmio.c | 45 + 1 file changed, 45 insertions(+) diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c index f95b7dd..11964ee 100644 --- a/hw/virtio/virtio-mmio.c +++ b/hw/virtio/virtio-mmio.c

[Qemu-devel] [PATCH qom-next 3/5] tests: Add rtl8139 qtest

2014-02-05 Thread Andreas Färber
Signed-off-by: Andreas Färber --- tests/Makefile | 3 +++ tests/rtl8139-test.c | 35 +++ 2 files changed, 38 insertions(+) create mode 100644 tests/rtl8139-test.c diff --git a/tests/Makefile b/tests/Makefile index 323c600..eabdf98 100644 --- a/tests/Makefi

[Qemu-devel] [PATCH qom-next 4/5] tests: Add PC-Net qtest

2014-02-05 Thread Andreas Färber
Test PCI only for now. Signed-off-by: Andreas Färber --- tests/Makefile | 4 tests/pcnet-test.c | 35 +++ 2 files changed, 39 insertions(+) create mode 100644 tests/pcnet-test.c diff --git a/tests/Makefile b/tests/Makefile index eabdf98..867d931 100644

Re: [Qemu-devel] [PATCH] pc_piix: enable legacy hotplug for Xen

2014-02-05 Thread Paolo Bonzini
Il 05/02/2014 17:54, Stefano Stabellini ha scritto: > I'm not sure how this is related to fw_cfg? fw_cfg is just a simple key-value > store. If hvmloader doesn't use it, it should be a burden. I was referring to the fact that QEMU might not have all the info that need to be written to fw_cfg w

[Qemu-devel] [PATCH qom-next 2/5] tests: Add vmxnet3 qtest

2014-02-05 Thread Andreas Färber
Signed-off-by: Andreas Färber --- tests/Makefile | 5 + tests/vmxnet3-test.c | 35 +++ 2 files changed, 40 insertions(+) create mode 100644 tests/vmxnet3-test.c diff --git a/tests/Makefile b/tests/Makefile index 57e21fc..323c600 100644 --- a/tests/Make

[Qemu-devel] [PATCH 1/4] virtio-mmio: introduce set_host_notifier()

2014-02-05 Thread Ying-Shiuan Pan
set_host_notifier() is introduced into virtio-mmio now. Most of codes came from virtio-pci. Signed-off-by: Ying-Shiuan Pan --- hw/virtio/virtio-mmio.c | 70 + 1 file changed, 70 insertions(+) diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio

Re: [Qemu-devel] [PATCH v3 4/9] ide: Drop redundant IDEState member bs

2014-02-05 Thread Stefano Stabellini
On Wed, 5 Feb 2014, Markus Armbruster wrote: > [Note cc: Stefano] > > Kevin Wolf writes: > > > Am 30.01.2014 um 13:16 hat Markus Armbruster geschrieben: > >> It's a copy of dev->conf.bs. The copy was needed for non-qdevified > >> controllers, which lacked dev. > >> > >> Note how pci_piix3_xen_

Re: [Qemu-devel] [PATCH 01/12] qapi: add size parser to StringInputVisitor

2014-02-05 Thread Andreas Färber
Am 30.01.2014 14:09, schrieb Paolo Bonzini: > Signed-off-by: Paolo Bonzini > --- > qapi/string-input-visitor.c | 24 > 1 file changed, 24 insertions(+) > > diff --git a/qapi/string-input-visitor.c b/qapi/string-input-visitor.c > index 8f1bc41..793548a 100644 > --- a/qapi

[Qemu-devel] [PATCH 4/4] virtio-mmio: add a new property for ioeventfd

2014-02-05 Thread Ying-Shiuan Pan
Make ioeventfd could be enabled or disabled (default). Since ioeventfd is not yet ready in kvm-arm, without this option, qemu will get a problem if it attempts to initialize ioeventfd. To coincide this option of virtio-mmio with virtio-pci, I would like to also move VIRTIO_PCI_FLAG_USE_IOEVENTFD t

Re: [Qemu-devel] [PATCH 01/12] qapi: add size parser to StringInputVisitor

2014-02-05 Thread Paolo Bonzini
Il 05/02/2014 18:13, Andreas Färber ha scritto: > +error_set(errp, QERR_INVALID_PARAMETER_TYPE, name ? name : "null", > + "size"); error_setg()? We're still using error_set for existing errors. In this case, the code is taken from qdev-properties.c. Paolo Otherwi

Re: [Qemu-devel] [PATCH] qdev: Keep global allocation counter per bus

2014-02-05 Thread Paolo Bonzini
Il 04/02/2014 13:14, Markus Armbruster ha scritto: Paolo Bonzini writes: Il 04/02/2014 11:33, Markus Armbruster ha scritto: This breaks migration unless you change bus=ide.0 to bus=ide.1 on the destination. Should be mentioned in release notes. Do we have a place where we collect r

[Qemu-devel] [PATCH 0/4] ioeventfd support for virtio-mmio

2014-02-05 Thread Ying-Shiuan Pan
I added host/guest notifiers support for virtio-mmio, so that qemu can enable vhost-net for kvm-arm. Sorry for that I cannot measure the performance difference because I have only Exynos-5250 arndale boards which only provide a 100 Mbps Ethernet. But in our previous work in kvm-arm (refer: Evaluati

[Qemu-devel] [PATCH v3 1/5] rules.mak: Support .cc as a C++ source file suffix

2014-02-05 Thread Peter Maydell
The A64 disassembler libvixl uses .cc as its suffix for C++ source files, so add support for it (we already support .cpp). Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- rules.mak | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/rules.mak b/rules.mak ind

[Qemu-devel] [PATCH v3 5/5] disas: Implement disassembly output for A64

2014-02-05 Thread Peter Maydell
From: Claudio Fontana Use libvixl to implement disassembly output in debug logs for A64, for use with both AArch64 hosts and targets. Signed-off-by: Claudio Fontana [PMM: * added support for target disassembly * switched to custom QEMUDisassembler so the output format matches what QEMU exp

  1   2   >