Re: [Qemu-devel] [PATCH 11/12] qdev: add enum property types to QAPI schema

2014-01-31 Thread Markus Armbruster
Paolo Bonzini writes: > Prepare for when QOM introspection will be able to piggyback on the QAPI > schema for describing property types. > > Signed-off-by: Paolo Bonzini > --- > hw/core/qdev-properties.c | 18 +++ > hw/i386/kvm/i8254.c | 6 ++--- > hw/timer/mc146818rtc.c|

Re: [Qemu-devel] [PATCH v2] block: handle "rechs" and "large" translation options

2014-01-31 Thread Markus Armbruster
Paolo Bonzini writes: > Sure, CHS translation is an obscure topic, and legacy options for > hard-disk geometries are obscure as well. But since QEMU does nothing > with it except telling the BIOS, and since there "large" and "rechs" > are listed in the enums, parsing them seems to be the bare mi

Re: [Qemu-devel] [PATCHv7 1/5] block: add native support for NFS

2014-01-31 Thread Stefan Hajnoczi
On Thu, Jan 30, 2014 at 10:35 PM, Peter Lieven wrote: > > Am 30.01.2014 um 15:22 schrieb Stefan Hajnoczi : > >> On Wed, Jan 29, 2014 at 05:19:59PM +0100, Benoît Canet wrote: >>> Le Wednesday 29 Jan 2014 à 09:50:21 (+0100), Peter Lieven a écrit : +static int nfs_file_open(BlockDriverState *bs,

Re: [Qemu-devel] [PATCHv7 1/5] block: add native support for NFS

2014-01-31 Thread Peter Lieven
On 31.01.2014 09:57, Stefan Hajnoczi wrote: On Thu, Jan 30, 2014 at 10:35 PM, Peter Lieven wrote: Am 30.01.2014 um 15:22 schrieb Stefan Hajnoczi : On Wed, Jan 29, 2014 at 05:19:59PM +0100, Benoît Canet wrote: Le Wednesday 29 Jan 2014 à 09:50:21 (+0100), Peter Lieven a écrit : +static int nf

[Qemu-devel] [PULL 0/5] s390/kvm: fixes and features

2014-01-31 Thread Christian Borntraeger
Anthony, Peter, The following changes since commit 1cf892ca2689c84960b4ce4d2723b6bee453711c: SPARC: Fix LEON3 power down instruction (2014-01-15 15:37:33 +1000) are available in the git repository at: git://github.com/borntraeger/qemu.git tags/kvm-s390-20140131 for you to fetch changes up

[Qemu-devel] [PULL 3/5] s390-sclp: SCLP Event integration

2014-01-31 Thread Christian Borntraeger
From: "Jason J. Herne" Add an sclp event for "cpu was hot plugged". This allows Qemu to deliver an SCLP interrupt to the guest stating that the requested cpu hotplug was completed. Signed-off-by: Jason J. Herne Reviewed-by: Andreas Färber Signed-off-by: Christian Borntraeger --- hw/s390x/Ma

[Qemu-devel] [PULL 5/5] s390x/kvm: cleanup partial register handling

2014-01-31 Thread Christian Borntraeger
From: Dominik Dingel The partial register handling (introduced with commits 420840e58b85f7f4e5493dca3f273566f261090a and 3474b679486caa8f6448bae974e131370f360c13 ) aimed to improve intercept handling performance. It made the code more complicated though. During development for life migration/ini

[Qemu-devel] [PULL 1/5] s390-sclp: Define New SCLP Codes

2014-01-31 Thread Christian Borntraeger
From: "Jason J. Herne" Define new SCLP codes to improve code readability. Signed-off-by: Jason J. Herne Signed-off-by: Christian Borntraeger --- hw/s390x/sclp.c | 2 +- include/hw/s390x/sclp.h | 8 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/hw/s390x/sclp.c

[Qemu-devel] [PULL 2/5] s390-sclp: SCLP CPU Info

2014-01-31 Thread Christian Borntraeger
From: "Jason J. Herne" Implement the CPU data in SCLP "Read SCP Info". And implement "Read CPU Info" SCLP command. This data will be used by the guest to get information about hot plugged cpus. Signed-off-by: Jason J. Herne Signed-off-by: Christian Borntraeger --- hw/s390x/sclp.c | 5

[Qemu-devel] [PULL 4/5] sclp-s390: Define new SCLP codes and structures

2014-01-31 Thread Christian Borntraeger
From: Matthew Rosato Define new SCLP codes and structures that will be needed for s390 memory hotplug. Signed-off-by: Matthew Rosato Signed-off-by: Christian Borntraeger --- include/hw/s390x/sclp.h | 34 ++ 1 file changed, 34 insertions(+) diff --git a/include

[Qemu-devel] [PATCH v2] qga: Don't require 'time' argument in guest-set-time command

2014-01-31 Thread Michal Privoznik
As the description to the guest-set-time states, the command is there to ease time synchronization after resume. If guest was suspended for longer period of time, its system time can go off so badly, that even NTP refuses to set it. That's why the command was invented: to give users chance to set t

[Qemu-devel] [PATCH] qmp: expose list of supported character device backends

2014-01-31 Thread Martin Kletzander
Introduce 'query-chardev-backends' QMP command which lists all supported character device backends. Signed-off-by: Martin Kletzander --- qapi-schema.json | 22 ++ qemu-char.c | 19 +++ qmp-commands.hx | 41 + 3 fil

Re: [Qemu-devel] [PATCH] trace backend: introduce multi tracing backend

2014-01-31 Thread Stefan Hajnoczi
On Tue, Jan 28, 2014 at 01:35:20PM +0900, Kazuya Saito wrote: Okay, more feedback after looking at the rest of the patch. I think "ust" backend support will simplify the patch a little (see details below). Looking forward to the next revision. Let me know if you have any questions about my feed

Re: [Qemu-devel] [PATCH v5 0/2] target-ppc: CPU device tree id

2014-01-31 Thread Thomas Huth
On Fri, 31 Jan 2014 17:07:36 +1100 Alexey Kardashevskiy wrote: > On 01/22/2014 03:20 PM, Alexey Kardashevskiy wrote: > > On 01/10/2014 07:20 PM, Alexey Kardashevskiy wrote: > >> On 12/20/2013 12:16 AM, Alexey Kardashevskiy wrote: > >>> On 12/10/2013 07:16 PM, Alexey Kardashevskiy wrote: > On

Re: [Qemu-devel] [PATCHv7 1/5] block: add native support for NFS

2014-01-31 Thread Stefan Hajnoczi
On Fri, Jan 31, 2014 at 10:11 AM, Peter Lieven wrote: > On 31.01.2014 09:57, Stefan Hajnoczi wrote: >> >> On Thu, Jan 30, 2014 at 10:35 PM, Peter Lieven wrote: >>> >>> Am 30.01.2014 um 15:22 schrieb Stefan Hajnoczi : >>> On Wed, Jan 29, 2014 at 05:19:59PM +0100, Benoīt Canet wrote: > >>>

Re: [Qemu-devel] [PATCH 0/2] qtest: don't leak pid files and UNIX domain sockets

2014-01-31 Thread Stefan Hajnoczi
On Fri, Jan 31, 2014 at 1:07 AM, Peter Maydell wrote: > On 21 November 2013 11:03, Stefan Hajnoczi wrote: >> GLib uses abort(3) to exit failed test cases. As a result, the pid file and >> UNIX domain sockets for a running test are leaked upon failure. >> >> Since abort(3) does not call atexit(3)

Re: [Qemu-devel] [PULL v2 00/35] acpi, pci, pc, virtio fixes and enhancements

2014-01-31 Thread Peter Maydell
On 28 January 2014 11:21, Michael S. Tsirkin wrote: > Hi Peter, > could you merge the below please? > Thanks in advance! > > On Sun, Jan 26, 2014 at 06:05:14PM +0200, Michael S. Tsirkin wrote: >> Hi Anthony, >> I forgot to Cc you on the previous version of this pull request. >> So here's v2 - it a

Re: [Qemu-devel] [PATCHv7 1/5] block: add native support for NFS

2014-01-31 Thread Peter Lieven
On 31.01.2014 11:46, Stefan Hajnoczi wrote: On Fri, Jan 31, 2014 at 10:11 AM, Peter Lieven wrote: On 31.01.2014 09:57, Stefan Hajnoczi wrote: On Thu, Jan 30, 2014 at 10:35 PM, Peter Lieven wrote: Am 30.01.2014 um 15:22 schrieb Stefan Hajnoczi : On Wed, Jan 29, 2014 at 05:19:59PM +0100, Ben

Re: [Qemu-devel] [PULL 0/4] Tracing patches

2014-01-31 Thread Peter Maydell
On 27 January 2014 14:53, Stefan Hajnoczi wrote: > The following changes since commit 0169c511554cb0014a00290b0d3d26c31a49818f: > > Merge remote-tracking branch 'qemu-kvm/uq/master' into staging (2014-01-24 > 15:52:44 -0800) > > are available in the git repository at: > > > git://github.com/s

Re: [Qemu-devel] [PATCH 11/12] qdev: add enum property types to QAPI schema

2014-01-31 Thread Paolo Bonzini
Il 31/01/2014 09:05, Markus Armbruster ha scritto: If you want the obsolete ways to specify translation accept the new values, too, then the patch to do that (currently "[PATCH v2] block: handle "rechs" and "large" translation options") should immediately follow the first one, or be squashed int

Re: [Qemu-devel] [uq/master PATCH 0/7] x86 CPU subclasses, take 7

2014-01-31 Thread Andreas Färber
Am 30.01.2014 22:47, schrieb Paolo Bonzini: > Il 30/01/2014 20:48, Eduardo Habkost ha scritto: >> Is there any hope to get this into QEMU 2.0, or it is now too late? I got >> almost no feedback on take 6 (submitted November 27). > > It's not too late, not for me at least. I wanted to send the nex

Re: [Qemu-devel] [PATCHv7 1/5] block: add native support for NFS

2014-01-31 Thread Peter Lieven
On 29.01.2014 17:19, Benoît Canet wrote: Le Wednesday 29 Jan 2014 à 09:50:21 (+0100), Peter Lieven a écrit : This patch adds native support for accessing images on NFS shares without the requirement to actually mount the entire NFS share on the host. NFS Images can simply be specified by an url

Re: [Qemu-devel] [uq/master PATCH 2/7] target-i386: Don't change x86_def_t struct on cpu_x86_register()

2014-01-31 Thread Paolo Bonzini
Il 30/01/2014 20:48, Eduardo Habkost ha scritto: As eventually the x86_def_t data is going to be provided by the CPU class, it's better to not touch it, and handle the special cases on the X86CPU object itself. Current behavior of the code should stay exactly the same. Signed-off-by: Eduardo Ha

[Qemu-devel] [PATCHv8 5/5] qemu-iotests: blacklist test 020 for NFS protocol

2014-01-31 Thread Peter Lieven
reopening is currently not supported. Signed-off-by: Peter Lieven --- tests/qemu-iotests/020 |5 + 1 file changed, 5 insertions(+) diff --git a/tests/qemu-iotests/020 b/tests/qemu-iotests/020 index 73a0429..2f258dc 100755 --- a/tests/qemu-iotests/020 +++ b/tests/qemu-iotests/020 @@ -49,

[Qemu-devel] [PATCHv8 3/5] qemu-iotests: enable support for NFS protocol

2014-01-31 Thread Peter Lieven
Signed-off-by: Peter Lieven --- tests/qemu-iotests/common| 22 +++--- tests/qemu-iotests/common.rc |3 +++ 2 files changed, 22 insertions(+), 3 deletions(-) diff --git a/tests/qemu-iotests/common b/tests/qemu-iotests/common index 8b4e22c..5795358 100644 --- a/tests/qemu

Re: [Qemu-devel] [uq/master PATCH 3/7] target-i386: Move KVM default-vendor hack to instance_init

2014-01-31 Thread Paolo Bonzini
Il 30/01/2014 20:48, Eduardo Habkost ha scritto: As we will not have a cpu_x86_find_by_name() function anymore, move the KVM default-vendor hack to instance_init. Unfortunately we can't move that code to class_init because it depends on KVM being initialized. Signed-off-by: Eduardo Habkost ---

Re: [Qemu-devel] [uq/master PATCH 6/7] target-i386: Rename x86_def_t to X86CPUDefinition

2014-01-31 Thread Paolo Bonzini
Il 30/01/2014 20:48, Eduardo Habkost ha scritto: As the new X86CPU subclass code is going to change lots of the code invoving x86_def_t, let's rename the struct to match coding style first. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 26 +- 1 file changed, 13

Re: [Qemu-devel] [PATCH v17 00/10] Shared library module support

2014-01-31 Thread Paolo Bonzini
Il 28/01/2014 10:33, Fam Zheng ha scritto: Ping? This version has a slight conflict with current qemu.git. Do you want a respin, Paolo? I was waiting for test results from Peter. I can rebase myself. Paolo

Re: [Qemu-devel] [uq/master PATCH 1/7] target-i386: Eliminate CONFIG_KVM #ifdefs

2014-01-31 Thread Paolo Bonzini
Il 30/01/2014 20:48, Eduardo Habkost ha scritto: The compiler is already able to eliminate the kvm_arch_get_supported_cpuid() calls in kvm_cpu_fill_host() and filter_features_for_kvm(), so we can eliminate the CONFIG_KVM #ifdefs there. Also, kvm_cpu_fill_host() and host_cpuid() don't need to che

[Qemu-devel] [PATCHv8 2/5] qemu-iotests: change _supported_proto to file for various tests

2014-01-31 Thread Peter Lieven
all these tests do anything of the following and thus fail with any protocol other than file: - the tests use rm, cp or mv shell commands which only work on file - the tests use qcow2.py - the images construct new filenames (e.g. backing file names) and the logic is broken for anything else t

Re: [Qemu-devel] [PATCH v5 0/2] target-ppc: CPU device tree id

2014-01-31 Thread Andreas Färber
Am 31.01.2014 07:07, schrieb Alexey Kardashevskiy: > On 01/22/2014 03:20 PM, Alexey Kardashevskiy wrote: >> On 01/10/2014 07:20 PM, Alexey Kardashevskiy wrote: >>> On 12/20/2013 12:16 AM, Alexey Kardashevskiy wrote: On 12/10/2013 07:16 PM, Alexey Kardashevskiy wrote: > On 12/03/2013 02:30

Re: [Qemu-devel] [uq/master PATCH 4/7] target-i386: Rename cpu_x86_register() to x86_cpu_load_def()

2014-01-31 Thread Paolo Bonzini
Il 30/01/2014 20:48, Eduardo Habkost ha scritto: There isn't any kind of "registration" involved in cpu_x86_register() anymore: it is simply looking up a CPU model name and loading the model definition data into the X86CPU object. Rename it to x86_cpu_load_def() to reflect what it does. Signed-o

[Qemu-devel] [PATCHv8 4/5] qemu-iotests: enable test 016 and 025 to work with NFS protocol

2014-01-31 Thread Peter Lieven
Signed-off-by: Peter Lieven --- tests/qemu-iotests/016 |2 +- tests/qemu-iotests/025 |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/016 b/tests/qemu-iotests/016 index b87a32b..7ea9e94 100755 --- a/tests/qemu-iotests/016 +++ b/tests/qemu-iotests/01

Re: [Qemu-devel] [uq/master PATCH 0/7] x86 CPU subclasses, take 7

2014-01-31 Thread Paolo Bonzini
Il 31/01/2014 12:30, Andreas Färber ha scritto: Further, I was under the impression that this series depends on Igor's feature property series, which I haven't found time to rework and haven't noticed anyone else do either. So if there's no prereqs (why uq/master?) I'll happily start reviewing an

Re: [Qemu-devel] [uq/master PATCH 0/7] x86 CPU subclasses, take 7

2014-01-31 Thread Eduardo Habkost
On Fri, Jan 31, 2014 at 12:30:17PM +0100, Andreas Färber wrote: > Am 30.01.2014 22:47, schrieb Paolo Bonzini: > > Il 30/01/2014 20:48, Eduardo Habkost ha scritto: > >> Is there any hope to get this into QEMU 2.0, or it is now too late? I got > >> almost no feedback on take 6 (submitted November 27)

[Qemu-devel] [PATCHv8 0/5] block: add native support for NFS

2014-01-31 Thread Peter Lieven
This adds v6 of the NFS protocol driver + qemu-iotest adjustments. v7->v8: - bump libnfs requirement to 1.9.2 - renamed NFSRPC->status to NFSRPC->ret [Benoit] - avoid double invocation of nfs_client_close in nfs_file_create [Benoit] - fixed error propagation in nfs_file_open [Benoit] v6->v7:

Re: [Qemu-devel] [PATCH] dataplane: Comment fix

2014-01-31 Thread Stefan Hajnoczi
On Thu, Jan 30, 2014 at 04:34:12PM +0100, Markus Armbruster wrote: > > Signed-off-by: Markus Armbruster > --- > hw/block/dataplane/virtio-blk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan

Re: [Qemu-devel] [uq/master PATCH 0/7] x86 CPU subclasses, take 7

2014-01-31 Thread Eduardo Habkost
On Fri, Jan 31, 2014 at 12:42:08PM +0100, Paolo Bonzini wrote: > Il 31/01/2014 12:30, Andreas Färber ha scritto: > >Further, I was under the impression that this series depends on Igor's > >feature property series, which I haven't found time to rework and > >haven't noticed anyone else do either. S

[Qemu-devel] [PATCHv8 1/5] block: add native support for NFS

2014-01-31 Thread Peter Lieven
This patch adds native support for accessing images on NFS shares without the requirement to actually mount the entire NFS share on the host. NFS Images can simply be specified by an url of the form: nfs:[?param=value[¶m2=value2[&...]]] For example: qemu-img create -f qcow2 nfs://10.0.0.1/qem

Re: [Qemu-devel] [PATCH] qemu-iotests: only run 071 on qcow2

2014-01-31 Thread Stefan Hajnoczi
On Wed, Jan 29, 2014 at 04:33:54PM +0100, Stefan Hajnoczi wrote: > The 071 test is designed for IMGFMT=qcow2 because it uses the l2_load > blkdebug event. Its output filtering also assumes that IMGFMT is not > raw since 071.out contains "format=raw" but IMGFMT=raw would filter the > output to "for

Re: [Qemu-devel] [PATCH 1/2] qom-test: Run for all available machines

2014-01-31 Thread Andreas Färber
Am 10.01.2014 14:31, schrieb arm...@redhat.com: > From: Markus Armbruster > > Get available machines via QMP instead of hardcoding a list that's > perpetually out of date. > > A few machines don't work out of the box: > > * Several ppcemb machines can't initialize their CPU. > > * Xen machines

Re: [Qemu-devel] [PATCH] qmp: expose list of supported character device backends

2014-01-31 Thread Eric Blake
On 01/31/2014 03:35 AM, Martin Kletzander wrote: > Introduce 'query-chardev-backends' QMP command which lists all > supported character device backends. > > Signed-off-by: Martin Kletzander > --- > qapi-schema.json | 22 ++ > qemu-char.c | 19 +++ > qmp-c

[Qemu-devel] [PATCH v3 3/5] pcihp: make pci_read() mmio calback compatible with legacy ACPI hotplug

2014-01-31 Thread Igor Mammedov
due to recent change introduced by: "pcihp: reduce number of device check events" 'up' field is cleared right after it's read. This is incompatible with legacy BIOS ACPI code where PCNF ACPI method reads this field 32 times. To make pci_read mmio callback compatible with legacy 'up' behavior, pci

[Qemu-devel] [PATCH v3 2/5] pcihp: make PCI hotplug mmio handlers indifferent to PCI_HOTPLUG_ADDR

2014-01-31 Thread Igor Mammedov
... removes dependency of mmio handler on PCI_HOTPLUG_ADDR. It will be needed in case of Q35 where base could be different. Signed-off-by: Igor Mammedov --- hw/acpi/pcihp.c | 24 1 files changed, 12 insertions(+), 12 deletions(-) diff --git a/hw/acpi/pcihp.c b/hw/acpi

[Qemu-devel] [PATCH v3 0/5] pc: make ACPI pcihp more reusable

2014-01-31 Thread Igor Mammedov
changes since v2: - rename 'use_acpi_pci_hotplug' field to 'legacy_piix' and corresponding properties - drop excessive checks for legacy mode - rework legacy vmstate handling to use AcpiPciHpPciStatus[0] structure which reduced acpi/piix4.c by another 50 LOC - move legacy initialization

[Qemu-devel] [PATCH v3 1/5] pcihp: replace enable|disable_device() with oneliners

2014-01-31 Thread Igor Mammedov
enable_device() and disable_device() functions aren't reused anywere, so replace them with respective oneliners at call sites. Signed-off-by: Igor Mammedov --- hw/acpi/pcihp.c | 14 ++ 1 files changed, 2 insertions(+), 12 deletions(-) diff --git a/hw/acpi/pcihp.c b/hw/acpi/pcihp.c

[Qemu-devel] [PATCH v3 4/5] pcihp: remove unused AcpiPciHpPciStatus.device_present field

2014-01-31 Thread Igor Mammedov
Remove now unused 'device_present' field wich was obsoleted by patch "pcihp: reduce number of device check events" Signed-off-by: Igor Mammedov --- include/hw/acpi/pcihp.h |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/include/hw/acpi/pcihp.h b/include/hw/acpi/pcihp.h i

[Qemu-devel] [PATCH v3 5/5] hw:piix4:acpi: reuse pcihp code for legacy PCI hotplug

2014-01-31 Thread Igor Mammedov
reduces acpi PCI hotplug code duplication by ~200LOC Signed-off-by: Igor Mammedov --- v3: - remove exessive checks for compat mode - replace up/down fields of pci_status with corresponding fields form AcpiPciHpPciStatus in vmstate wich allow to remove extra 50 LOC of legacy code - move l

Re: [Qemu-devel] [PATCH 1/2] qom-test: Run for all available machines

2014-01-31 Thread Markus Armbruster
Andreas Färber writes: > Am 10.01.2014 14:31, schrieb arm...@redhat.com: >> From: Markus Armbruster >> >> Get available machines via QMP instead of hardcoding a list that's >> perpetually out of date. >> >> A few machines don't work out of the box: >> >> * Several ppcemb machines can't initia

[Qemu-devel] [PATCH v2] Define the architecture for compressed dump format.

2014-01-31 Thread Ekaterina Tumanova
Signed-off-by: Ekaterina Tumanova --- dump.c | 7 +-- target-i386/cpu.h | 2 ++ target-s390x/cpu.h | 1 + 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/dump.c b/dump.c index 8f64aab..25503bc 100644 --- a/dump.c +++ b/dump.c @@ -32,6 +32,9 @@ #ifdef CONFIG_SNAPPY

[Qemu-devel] [PATCH v2] Define guest architecture for the compressed dump header.

2014-01-31 Thread Ekaterina Tumanova
You're right about the warning. I removed it. I also added the cast for the destination argument, which caused a warning as well. I tested on s390 and i386 laptop. If you ok with the patch, can you push it on top of this series? Thank you, Regards, Kate. Ekaterina Tumanova (1): Define the ar

Re: [Qemu-devel] [PATCH v2] Define the architecture for compressed dump format.

2014-01-31 Thread Christian Borntraeger
On 31/01/14 14:45, Ekaterina Tumanova wrote: > Signed-off-by: Ekaterina Tumanova Acked-by: Christian Borntraeger > --- > dump.c | 7 +-- > target-i386/cpu.h | 2 ++ > target-s390x/cpu.h | 1 + > 3 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/dump.c b/dump.c

Re: [Qemu-devel] [Qemu-ppc] [PATCH v5 2/2] target-ppc: spapr: e500: fix to use cpu_dt_id

2014-01-31 Thread Alexander Graf
On 03.12.2013, at 04:30, Alexey Kardashevskiy wrote: > This makes use of @cpu_dt_id and related API in: > 1. emulated XICS hypercall handlers as they receive fixed CPU indexes; > 2. XICS-KVM to enable in-kernel XICS on right CPU; > 3. device-tree renderer. > > This removes @cpu_index fixup as @

Re: [Qemu-devel] [PATCH v2] Define the architecture for compressed dump format.

2014-01-31 Thread Laszlo Ersek
one not-so-important comment below: On 01/31/14 14:45, Ekaterina Tumanova wrote: > Signed-off-by: Ekaterina Tumanova > --- > dump.c | 7 +-- > target-i386/cpu.h | 2 ++ > target-s390x/cpu.h | 1 + > 3 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/dump.c b/dump

Re: [Qemu-devel] [PATCH v4 0/4] Create ARM KVM VGIC with device control API

2014-01-31 Thread Peter Maydell
On 29 January 2014 13:21, Peter Maydell wrote: > On 28 January 2014 20:28, Christoffer Dall > wrote: >> This patch series adds generic support for issuing device control >> related ioctls and supports creating the ARM KVM-accelerated VGIC using >> the device control API while maintaining backwar

[Qemu-devel] [PATCH 08/11] lm832x: QOM'ify

2014-01-31 Thread Andreas Färber
Replace usages of FROM_I2C_SLAVE() with QOM cast macro. Rename parent field. Signed-off-by: Andreas Färber --- hw/input/lm832x.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/hw/input/lm832x.c b/hw/input/lm832x.c index f583cf0..4ae1cd9 100644 --- a/h

[Qemu-devel] [PATCH 03/11] tosa: QOM'ify DAC

2014-01-31 Thread Andreas Färber
Replace usages of FROM_I2C_SLAVE() with QOM cast macro. Rename parent field. Signed-off-by: Andreas Färber --- hw/arm/tosa.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/hw/arm/tosa.c b/hw/arm/tosa.c index dd224d3..2069f55 100644 --- a/hw/arm/tosa.c +++ b

[Qemu-devel] [PATCH 00/11] I2C QOM'ification, part 1

2014-01-31 Thread Andreas Färber
Hello, This series prepares for converting I2C to QOM realize. Didn't finish that so far, but I'd like to apply this to qom-next before it starts to conflict. Regards, Andreas Cc: Anthony Liguori Cc: Peter Maydell Andreas Färber (11): i2c: Rename i2c_bus to I2CBus pxa2xx: QOM'ify I2C sla

[Qemu-devel] [PATCH 01/11] i2c: Rename i2c_bus to I2CBus

2014-01-31 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/acpi/piix4.c | 6 +++--- hw/arm/exynos4210.c | 2 +- hw/arm/musicpal.c | 4 ++-- hw/arm/nseries.c| 2 +- hw/arm/pxa2xx.c | 6 +++--- hw/arm/realview.c | 4 ++-- hw/arm/spitz.c |

[Qemu-devel] [PATCH 07/11] max7310: QOM'ify

2014-01-31 Thread Andreas Färber
Replace FROM_I2C_SLAVE() usages with QOM cast macro. Rename parent field. Signed-off-by: Andreas Färber --- hw/gpio/max7310.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/hw/gpio/max7310.c b/hw/gpio/max7310.c index 59b2877..cfcd89c 100644 --- a/hw/

[Qemu-devel] [PATCH 02/11] pxa2xx: QOM'ify I2C slave

2014-01-31 Thread Andreas Färber
Replace usages of FROM_I2C_SLAVE() with QOM cast macro and rename parent field to assure we caught all. Signed-off-by: Andreas Färber --- hw/arm/pxa2xx.c | 38 +- 1 file changed, 25 insertions(+), 13 deletions(-) diff --git a/hw/arm/pxa2xx.c b/hw/arm/pxa2xx.c

[Qemu-devel] [PATCH 04/11] z2: QOM'ify AER915

2014-01-31 Thread Andreas Färber
Replace usages of FROM_I2C_SLAVE() with QOM cast macro. Signed-off-by: Andreas Färber --- hw/arm/z2.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/hw/arm/z2.c b/hw/arm/z2.c index 97ec381..69c4d38 100644 --- a/hw/arm/z2.c +++ b/hw/arm/z2.c @@ -193,15 +19

[Qemu-devel] [PATCH 09/11] ds1338: QOM'ify

2014-01-31 Thread Andreas Färber
Replace usages of FROM_I2C_SLAVE() with QOM cast macro. Rename parent field. Signed-off-by: Andreas Färber --- hw/timer/ds1338.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/hw/timer/ds1338.c b/hw/timer/ds1338.c index 8987cdc..bb2f8ee 100644 --- a/hw

[Qemu-devel] [PATCH 11/11] i2c: Drop FROM_I2C_SLAVE() macro

2014-01-31 Thread Andreas Färber
Use type-specific QOM cast macros instead. Signed-off-by: Andreas Färber --- include/hw/i2c/i2c.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/hw/i2c/i2c.h b/include/hw/i2c/i2c.h index 9df987b..4986ebc 100644 --- a/include/hw/i2c/i2c.h +++ b/include/hw/i2c/i2c.h @@ -59,8 +59,6 @@

[Qemu-devel] [PATCH 05/11] wm8750: QOM'ify

2014-01-31 Thread Andreas Färber
Replace usages of FROM_I2C_SLAVE() with QOM cast macro. Rename parent field. Signed-off-by: Andreas Färber --- hw/audio/wm8750.c | 33 - 1 file changed, 20 insertions(+), 13 deletions(-) diff --git a/hw/audio/wm8750.c b/hw/audio/wm8750.c index 6b5a349..c18f245 10

[Qemu-devel] [PATCH 0/5] tcg/i386 support for bmi

2014-01-31 Thread Richard Henderson
There are three separate architecture extensions for logical operations, BMI, BMI2, and TBM. The first two are supported on Intel Haswell and AMD Excavator, while slightly earlier AMD support only BMI and TBM. The following adds support for the interesting BMI and BMI2 instructions, where it is e

[Qemu-devel] [PATCH 1/5] disas/i386: Disassemble ANDN/SHLX/SHRX/SHAX

2014-01-31 Thread Richard Henderson
Signed-off-by: Richard Henderson --- disas/i386.c | 146 +-- 1 file changed, 132 insertions(+), 14 deletions(-) diff --git a/disas/i386.c b/disas/i386.c index 044e02c..104524f 100644 --- a/disas/i386.c +++ b/disas/i386.c @@ -171,6 +171,7 @@

[Qemu-devel] [PATCH 2/5] tcg/i386: Move TCG_CT_CONST_* to tcg-target.c

2014-01-31 Thread Richard Henderson
These are not needed by users of tcg-target.h. No need to recompile when we adjust them. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c | 4 tcg/i386/tcg-target.h | 3 --- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target

[Qemu-devel] [PATCH 5/5] tcg/i386: Use SHLX/SHRX/SARX instructions

2014-01-31 Thread Richard Henderson
These three-operand shift instructions do not require the shift count to be placed into ECX. This reduces the number of mov insns required, with the mere addition of a new register constraint. Don't attempt to get rid of the matching constraint, as that's impossible to manipulate with just a new

[Qemu-devel] [PATCH 3/5] tcg/i386: Add tcg_out_vex_modrm

2014-01-31 Thread Richard Henderson
Prepare for emitting BMI insns which require VEX encoding. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c | 41 ++--- 1 file changed, 38 insertions(+), 3 deletions(-) diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c index 7008b0e..00dbc3

[Qemu-devel] [PATCH 8/8] tcg/optimize: Add more identity simplifications

2014-01-31 Thread Richard Henderson
Recognize 0 operand to andc, and -1 operands to and, orc, eqv. Signed-off-by: Richard Henderson --- tcg/optimize.c | 39 --- 1 file changed, 24 insertions(+), 15 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index a703f8c..8d7100e 100644 --- a/tcg

[Qemu-devel] [PATCH 4/8] tcg/optimize: add known-zero bits compute for load ops

2014-01-31 Thread Richard Henderson
From: Aurelien Jarno Cc: Paolo Bonzini Signed-off-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/optimize.c | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 1cf017a..d3b099a 100644 --- a/tcg/optimiz

[Qemu-devel] [PATCH 7/8] tcg/optimize: Optmize ANDC X, Y, Y to MOV X, 0

2014-01-31 Thread Richard Henderson
Like we already do for SUB and XOR. Signed-off-by: Richard Henderson --- tcg/optimize.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tcg/optimize.c b/tcg/optimize.c index cdfc746..a703f8c 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -945,6 +945,7 @@ static TCGArg *tcg_constant_fold

[Qemu-devel] [PATCH v18 01/10] util: Split out qemu_exec_dir from os_find_datadir

2014-01-31 Thread Paolo Bonzini
From: Fam Zheng This can be reused by module loading routines. Signed-off-by: Fam Zheng Signed-off-by: Paolo Bonzini --- include/qemu/osdep.h | 4 os-posix.c | 40 ++-- os-win32.c | 19 +-- util/oslib-posix.c | 45

[Qemu-devel] [PATCH v18 06/10] rules.mak: introduce DSO rules

2014-01-31 Thread Paolo Bonzini
From: Fam Zheng Add necessary rules and flags for shared object generation. The new rules introduced here are: 1) %.o in $(common-obj-m) is compiled to %.o, then linked to %.so. 2) %.mo in $(common-obj-m) is the placeholder for %.so for pattern matching in Makefile. It's linked to "-shared" wit

[Qemu-devel] [PATCH v18 10/10] block: convert block drivers linked with libs to modules

2014-01-31 Thread Paolo Bonzini
From: Fam Zheng The converted block drivers are: curl iscsi rbd ssh glusterfs Signed-off-by: Fam Zheng Signed-off-by: Paolo Bonzini --- configure | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/configure b/configure index 7aff69e..a30ec76 10

[Qemu-devel] [PATCH 3/8] tcg/optimize: improve known-zero bits for 32-bit ops

2014-01-31 Thread Richard Henderson
From: Aurelien Jarno The shl_i32 op might set some bits of the unused 32 high bits of the mask. Fix that by clearing the unused 32 high bits for all 32-bit ops except load/store which operate on tl values. Cc: Paolo Bonzini Signed-off-by: Aurelien Jarno Signed-off-by: Richard Henderson --- t

[Qemu-devel] [PATCH v18 09/10] Makefile: introduce common-obj-m and block-obj-m for DSO

2014-01-31 Thread Paolo Bonzini
From: Fam Zheng $(common-obj-m) will include $(block-obj-m), like $(common-obj-y) does for $(block-obj-y). Signed-off-by: Fam Zheng Signed-off-by: Paolo Bonzini --- Makefile| 4 +++- Makefile.objs | 2 ++ Makefile.target | 6 +- 3 files changed, 10 insertions(+), 2 deletions(-)

[Qemu-devel] [PATCH v18 04/10] block: use per-object cflags and libs

2014-01-31 Thread Paolo Bonzini
From: Fam Zheng No longer adds flags and libs for them to global variables, instead create config-host.mak variables like FOO_CFLAGS and FOO_LIBS, which is used as per object cflags and libs. This removes unwanted dependencies from libcacard. Signed-off-by: Fam Zheng [Split from Fam's patch to

[Qemu-devel] [PATCH v18 08/10] Makefile: install modules with "make install"

2014-01-31 Thread Paolo Bonzini
From: Fam Zheng Install all the modules to ${MODDIR}. Signed-off-by: Fam Zheng Signed-off-by: Paolo Bonzini --- Makefile | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Makefile b/Makefile index 07d1ed7..b434b2e 100644 --- a/Makefile +++ b/Makefile @@ -368,6 +368,12 @@ install-datad

[Qemu-devel] [PATCH v18 05/10] darwin: do not use -mdynamic-no-pic

2014-01-31 Thread Paolo Bonzini
While -mdynamic-no-pic can speed up the code somewhat, it is only used on the legacy PowerPC Mac OS X, and I am not sure if anyone is still testing that. Disabling PIC can cause problems when enabling modules, so do not do that. Signed-off-by: Paolo Bonzini --- configure | 2 -- 1 file changed,

[Qemu-devel] [PATCH v18 07/10] module: implement module loading

2014-01-31 Thread Paolo Bonzini
From: Fam Zheng This patch adds loading, stamp checking and initialization of modules. The init function of dynamic module is no longer directly called as __attribute__((constructor)) in static linked version, it is called only after passed the checking of presense of stamp symbol: qemu_sta

[Qemu-devel] [PATCH 0/8] tcg optimization improvements

2014-01-31 Thread Richard Henderson
The first 4 of these are ones that Aurelien posted some time ago, and I reviewed, but never seemed to get committed. The second 4 address optimization issues that I noticed with the BMI instruction set extension, adding ANDC support to x86_64. r~ Aurelien Jarno (4): tcg/optimize: fix known-z

[Qemu-devel] [PATCH 10/11] twl92230: QOM'ify

2014-01-31 Thread Andreas Färber
Replace usages of FROM_I2C_SLAVE() with QOM cast macro. Rename parent field. Signed-off-by: Andreas Färber --- hw/timer/twl92230.c | 35 +-- 1 file changed, 21 insertions(+), 14 deletions(-) diff --git a/hw/timer/twl92230.c b/hw/timer/twl92230.c index f3ea365..85

[Qemu-devel] [PATCH v3 0/1] Detect arch for dump compressed header.

2014-01-31 Thread Ekaterina Tumanova
True! Fixed. Tested. Can you please put it into push-queue? Thanks, Kate. Ekaterina Tumanova (1): Define the architecture for compressed dump format. dump.c | 7 +-- target-i386/cpu.h | 2 ++ target-s390x/cpu.h | 1 + 3 files changed, 8 insertions(+), 2 deletions(-) -- 1.8

[Qemu-devel] [PATCH v3 1/1] Define the architecture for compressed dump format.

2014-01-31 Thread Ekaterina Tumanova
Signed-off-by: Ekaterina Tumanova --- dump.c | 7 +-- target-i386/cpu.h | 2 ++ target-s390x/cpu.h | 1 + 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/dump.c b/dump.c index 8f64aab..8d85255 100644 --- a/dump.c +++ b/dump.c @@ -32,6 +32,9 @@ #ifdef CONFIG_SNAPPY

[Qemu-devel] [PULL v2 00/34] target-arm queue

2014-01-31 Thread Peter Maydell
fanha/tags/tracing-pull-request' into staging (2014-01-31 11:13:08 +) are available in the git repository at: git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20140131 for you to fetch changes up to 5b0adce156216fb24dcc5f1683e8b686f3793fff: arm_gic: Fix G

Re: [Qemu-devel] [uq/master PATCH 0/7] x86 CPU subclasses, take 7

2014-01-31 Thread Eduardo Habkost
(CCing Luiz, in case he can give some advice about the expectations of QMP semantics stability) On Fri, Jan 31, 2014 at 03:48:53PM +0100, Igor Mammedov wrote: > On Thu, 30 Jan 2014 17:48:52 -0200 > Eduardo Habkost wrote: > > > Is there any hope to get this into QEMU 2.0, or it is now too late? I

Re: [Qemu-devel] [uq/master PATCH 0/7] x86 CPU subclasses, take 7

2014-01-31 Thread Paolo Bonzini
Il 31/01/2014 16:10, Eduardo Habkost ha scritto: I don't mind which command is used, as long as we have the same effect. I used object-add in my example because device_add rejects the CPU classes by now (because they have cannot_instantiate_with_device_add_yet=true). But now I have one question:

Re: [Qemu-devel] [uq/master PATCH 0/7] x86 CPU subclasses, take 7

2014-01-31 Thread Paolo Bonzini
Il 31/01/2014 15:48, Igor Mammedov ha scritto: that's abusing of object-add interface and due to recent changes, object-add won't accept arbitrary objects. I hope that sooner or later device hotplug will be doable with object-add too. But yes, in the meanwhile device_add could work, and this

Re: [Qemu-devel] [uq/master PATCH 0/7] x86 CPU subclasses, take 7

2014-01-31 Thread Eduardo Habkost
On Fri, Jan 31, 2014 at 03:50:23PM +0100, Paolo Bonzini wrote: > Il 31/01/2014 15:48, Igor Mammedov ha scritto: > >that's abusing of object-add interface and due to recent changes, object-add > >won't accept arbitrary objects. > > I hope that sooner or later device hotplug will be doable with > ob

[Qemu-devel] [PATCH 5/8] tcg/optimize: Handle known-zeros masks for ANDC

2014-01-31 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/optimize.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/tcg/optimize.c b/tcg/optimize.c index d3b099a..3291a08 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -727,6 +727,17 @@ static TCGArg *tcg_constant_folding(TCGContext *s, uin

Re: [Qemu-devel] [uq/master PATCH 0/7] x86 CPU subclasses, take 7

2014-01-31 Thread Igor Mammedov
On Thu, 30 Jan 2014 17:48:52 -0200 Eduardo Habkost wrote: > Is there any hope to get this into QEMU 2.0, or it is now too late? I got > almost no feedback on take 6 (submitted November 27). > > This is the main blocker to allow libvirt finally implement an equivalent to > the > "enforce" flag,

[Qemu-devel] [PATCH v18 02/10] rules.mak: fix $(obj) to a real relative path

2014-01-31 Thread Paolo Bonzini
From: Fam Zheng Makefile.target includes rule.mak and unnested common-obj-y, then prefix them with '../', this will ignore object specific QEMU_CFLAGS in subdir Makefile.objs: $(obj)/curl.o: QEMU_CFLAGS += $(CURL_CFLAGS) Because $(obj) here is './block', instead of '../block'. This doesn't

[Qemu-devel] [PATCH v18 00/10] Shared library module support

2014-01-31 Thread Paolo Bonzini
Yet another rebase of the loadable module series, with the following changes: 1) reworked a bit the build system magic so that "make foo.o" will pick the right flags when foo.o is part of a module. 2) redid the split between patches 6/7/9, doing first the makefile rules, then the C code to load t

[Qemu-devel] [PATCH 1/8] tcg/optimize: fix known-zero bits for right shift ops

2014-01-31 Thread Richard Henderson
From: Aurelien Jarno 32-bit versions of sar and shr ops should not propagate known-zero bits from the unused 32 high bits. For sar it could even lead to wrong code being generated. Cc: Paolo Bonzini Cc: qemu-sta...@nongnu.org Signed-off-by: Aurelien Jarno Signed-off-by: Richard Henderson ---

[Qemu-devel] [PATCH v18 03/10] rules.mak: allow per object cflags and libs

2014-01-31 Thread Paolo Bonzini
From: Fam Zheng Adds extract-libs in LINK to expand any "per object libs", the syntax to define such a libs options is like: foo.o-libs := $(CURL_LIBS) in block/Makefile.objs. Similarly, foo.o-cflags := $(FOO_CFLAGS) is also supported. "foo.o" must be listed in a nested var

[Qemu-devel] [PATCH 6/8] tcg/optimize: Simply some logical ops to NOT

2014-01-31 Thread Richard Henderson
Given, of course, an appropriate constant. These could be generated from the "canonical" operation for inversion on the guest, or via other optimizations. Signed-off-by: Richard Henderson --- tcg/optimize.c | 57 + 1 file changed, 57 inser

[Qemu-devel] [PATCH 2/8] tcg/optimize: fix known-zero bits optimization

2014-01-31 Thread Richard Henderson
From: Aurelien Jarno Known-zero bits optimization is a great idea that helps to generate more optimized code. However the current implementation only works in very few cases as the computed mask is not saved. Fix this to make it really working. Cc: Paolo Bonzini Signed-off-by: Aurelien Jarno

[Qemu-devel] [PATCH v2 10/35] target-arm: Stop underdecoding ARM946 PRBS registers

2014-01-31 Thread Peter Maydell
The ARM946 has 8 PRBS (protection region base and size) registers. Currently we implement these with a CP_ANY reginfo; however this underdecodes (since there are 16 possible values of CRm but only 8 registers) and we catch the invalid values in the read and write functions. However this causes issu

  1   2   3   >