Re: [Qemu-devel] [PATCH v4 4/5] qmp: full introspection support for QMP

2014-01-27 Thread Amos Kong
CC Libvirt-list Original discussion: http://marc.info/?l=qemu-devel&m=139048842504757&w=2 [Qemu-devel] [PATCH v4 0/5] QMP full introspection On Fri, Jan 24, 2014 at 06:48:31PM +0800, Fam Zheng wrote: > On Thu, 01/23 22:46, Amos Kong wrote: > > This patch introduces a new monitor command to qu

[Qemu-devel] [PATCH] tests/.gitignore: Ignore tests/check-qom-interface

2014-01-27 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/.gitignore b/tests/.gitignore index 1aed224..9ba9d96 100644 --- a/tests/.gitignore +++ b/tests/.gitignore @@ -4,6 +4,7 @@ check-qint check-qjson check-qlist check-qstring +check-qom-interfac

Re: [Qemu-devel] [PATCH] target-ppc: Make ppc40x CPUs available in ppcemb

2014-01-27 Thread Alexander Graf
On 23.01.2014, at 17:56, Andreas Färber wrote: > Not only 44x CPUs (BookE) but also 40x CPUs can run with 1k page size. > > Move the criteria to a central inline function to avoid repetition > and #ifdef'fery. Update qom-test to no longer exempt them. > > Signed-off-by: Andreas Färber Thanks

Re: [Qemu-devel] [PATCH] ppcemb-softmmu: Drop Mac and e500 emulation

2014-01-27 Thread Alexander Graf
On 23.01.2014, at 16:40, Andreas Färber wrote: > They are still available in ppc-softmmu and ppc64-softmmu. > > Signed-off-by: Andreas Färber Thanks, applied to ppc-next. Alex

Re: [Qemu-devel] [PATCH] MAINTAINERS: add self as virtio co-maintainer

2014-01-27 Thread Kevin Wolf
Am 26.01.2014 um 11:40 hat Michael S. Tsirkin geschrieben: > This will help make sure I get Cc'd on patches. You wish... This won't change the actual responsibility, i.e. patches to virtio-blk are still meant to be merged through the block tree, right? It's just so you get a chance to comment? K

Re: [Qemu-devel] [PATCH v4 4/5] qmp: full introspection support for QMP

2014-01-27 Thread Paolo Bonzini
Il 27/01/2014 09:17, Amos Kong ha scritto: CC Libvirt-list Original discussion: http://marc.info/?l=qemu-devel&m=139048842504757&w=2 [Qemu-devel] [PATCH v4 0/5] QMP full introspection On Fri, Jan 24, 2014 at 06:48:31PM +0800, Fam Zheng wrote: On Thu, 01/23 22:46, Amos Kong wrote: This pat

Re: [Qemu-devel] [PATCH v4 4/5] qmp: full introspection support for QMP

2014-01-27 Thread Amos Kong
On Mon, Jan 27, 2014 at 04:17:56PM +0800, Amos Kong wrote: > CC Libvirt-list > > Original discussion: > http://marc.info/?l=qemu-devel&m=139048842504757&w=2 > [Qemu-devel] [PATCH v4 0/5] QMP full introspection > > On Fri, Jan 24, 2014 at 06:48:31PM +0800, Fam Zheng wrote: > > On Thu, 01/23 22

Re: [Qemu-devel] [PATCH v4 4/5] qmp: full introspection support for QMP

2014-01-27 Thread Amos Kong
On Mon, Jan 27, 2014 at 10:38:24AM +0100, Paolo Bonzini wrote: > Il 27/01/2014 09:17, Amos Kong ha scritto: > >CC Libvirt-list > > > >Original discussion: > > http://marc.info/?l=qemu-devel&m=139048842504757&w=2 > > [Qemu-devel] [PATCH v4 0/5] QMP full introspection > > > >On Fri, Jan 24, 2014 at

Re: [Qemu-devel] [PATCH v4 4/5] qmp: full introspection support for QMP

2014-01-27 Thread Paolo Bonzini
Il 27/01/2014 11:07, Amos Kong ha scritto: > No, I don't like this. > > QAPI types are perfectly able to "describe themselves", there is no > need to escape to JSON. > > Let's just do what this series is doing, minus the unnecessary recursion. The recursion extend was requested by Libvirt, they

Re: [Qemu-devel] [resend] fix/re-do query-command-line-options

2014-01-27 Thread Amos Kong
Hi QEMU/Libvirt list, When I worked on query-command-line-options, I first used some marcos [1] to generate two config & option tables. This will cover all the options, but it returns a string, it's difficult for libvirt to parse and use it. | {"execute": "query-config", "arguments" : {"name": "b

[Qemu-devel] [PATCH] monitor: Cleanup mon->outbuf on write error

2014-01-27 Thread Stratos Psomadakis
In case monitor_flush() fails to write the contents of mon->outbuf to the output device, mon->outbuf is not cleaned up properly. Check the return code of the qemu_chr_fe_write() function and cleanup the outbuf if it fails. References: http://lists.nongnu.org/archive/html/qemu-devel/2014-01/msg028

Re: [Qemu-devel] [PATCH v4 4/5] qmp: full introspection support for QMP

2014-01-27 Thread Fam Zheng
On Mon, 01/27 10:38, Paolo Bonzini wrote: > Il 27/01/2014 09:17, Amos Kong ha scritto: > >CC Libvirt-list > > > >Original discussion: > > http://marc.info/?l=qemu-devel&m=139048842504757&w=2 > > [Qemu-devel] [PATCH v4 0/5] QMP full introspection > > > >On Fri, Jan 24, 2014 at 06:48:31PM +0800, Fa

Re: [Qemu-devel] [PATCH] MAINTAINERS: add self as virtio co-maintainer

2014-01-27 Thread Michael S. Tsirkin
On Mon, Jan 27, 2014 at 10:37:16AM +0100, Kevin Wolf wrote: > Am 26.01.2014 um 11:40 hat Michael S. Tsirkin geschrieben: > > This will help make sure I get Cc'd on patches. > > You wish... > > This won't change the actual responsibility, i.e. patches to virtio-blk > are still meant to be merged t

Re: [Qemu-devel] [PATCH] MAINTAINERS: add self as virtio co-maintainer

2014-01-27 Thread Stefan Hajnoczi
On Mon, Jan 27, 2014 at 10:37:16AM +0100, Kevin Wolf wrote: > Am 26.01.2014 um 11:40 hat Michael S. Tsirkin geschrieben: > > This will help make sure I get Cc'd on patches. > > You wish... > > This won't change the actual responsibility, i.e. patches to virtio-blk > are still meant to be merged t

Re: [Qemu-devel] [PATCH] tests/.gitignore: Ignoretests/check-qom-interfacee

2014-01-27 Thread Alex Bennée
f...@redhat.com writes: > Signed-off-by: Fam Zheng > --- > tests/.gitignore | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/.gitignore b/tests/.gitignore > index 1aed224..9ba9d96 100644 > --- a/tests/.gitignore > +++ b/tests/.gitignore > @@ -4,6 +4,7 @@ check-qint > check-qjson

Re: [Qemu-devel] [Qemu/Virtio-scsi]The feature of 'raw device mapping' cannot isolate the LUN to the owning virtual machine

2014-01-27 Thread Paolo Bonzini
Il 27/01/2014 03:50, Qixiaozhen ha scritto: A scsi report command was executed in the instance, for example “sg_luns /dev/vdb”. However, It returned the list of the Luns in the SAN. This is a known problem in virtio-blk's SCSI emulation. Just don't use it, use virtio-scsi or another SCSI adap

[Qemu-devel] [PATCH RFC V2 2/6] xen: move Xen PV machine files to hw/xenpv

2014-01-27 Thread Wei Liu
Signed-off-by: Wei Liu --- hw/i386/Makefile.objs|2 +- hw/xenpv/Makefile.objs |2 ++ hw/{i386 => xenpv}/xen_domainbuild.c |0 hw/{i386 => xenpv}/xen_domainbuild.h |0 hw/{i386 => xenpv}/xen_machine_pv.c |0 5 files changed, 3 insertions(+), 1 del

[Qemu-devel] [PATCH RFC V2 3/6] xen: move Xen HVM files under hw/i386/xen

2014-01-27 Thread Wei Liu
Signed-off-by: Wei Liu --- hw/i386/Makefile.objs|2 +- hw/i386/xen/Makefile.objs|1 + hw/{ => i386}/xen/xen_apic.c |0 hw/{ => i386}/xen/xen_platform.c |0 hw/{ => i386}/xen/xen_pvdevice.c |0 hw/xen/Makefile.objs |1 - 6 files changed,

[Qemu-devel] [PATCH RFC V2 6/6] xen: introduce xenpv-softmmu.mak

2014-01-27 Thread Wei Liu
Signed-off-by: Wei Liu --- configure |7 +-- default-configs/xenpv-softmmu.mak |2 ++ 2 files changed, 7 insertions(+), 2 deletions(-) create mode 100644 default-configs/xenpv-softmmu.mak diff --git a/configure b/configure index 549b9cc..b713d93 100755 --- a/

[Qemu-devel] [PATCH RFC V2 4/6] xen: factor out common functions

2014-01-27 Thread Wei Liu
So common functions used by both HVM and PV are factored out from xen-all.c to xen-common.c. Finally rename xen-all.c to xen-hvm.c, as those functions are only useful to HVM guest. Create *-stub files and modify Makefile.target to reflect the changes. Signed-off-by: Wei Liu --- Makefile.target

[Qemu-devel] [PATCH RFC V2 1/6] configure: factor out list of supported Xen/KVM targets

2014-01-27 Thread Wei Liu
From: Paolo Bonzini Signed-off-by: Paolo Bonzini --- configure | 58 +++--- 1 file changed, 35 insertions(+), 23 deletions(-) diff --git a/configure b/configure index 07b6be3..549b9cc 100755 --- a/configure +++ b/configure @@ -4372,6 +4372,

[Qemu-devel] [PATCH RFC V2 0/6] Xen: introduce Xen PV target

2014-01-27 Thread Wei Liu
This is a prototype based on QEMU's master branch. In fact it's more or less the same as the last version. The first 3 patches refactor some code to disentangle Xen PV and HVM guest in QEMU. They are quite safe to go in. The 4th patch has the real meat. It introduces Xen PV target, which contains

[Qemu-devel] [PATCH RFC V2 5/6] xen: implement Xen PV target

2014-01-27 Thread Wei Liu
Basically it's a dummy CPU that doens't do anything. This patch contains necessary hooks to make QEMU compile. Signed-off-by: Wei Liu --- arch_init.c|2 ++ cpu-exec.c |2 ++ include/sysemu/arch_init.h |1 + target-xenpv/Makefile.objs |1 + target-x

Re: [Qemu-devel] [Qemu/Virtio-scsi]The feature of 'raw device mapping' cannot isolate the LUN to the owning virtual machine

2014-01-27 Thread Qixiaozhen
> > Il 27/01/2014 03:50, Qixiaozhen ha scritto: > > A scsi report command was executed in the instance, for example > > "sg_luns /dev/vdb". However, It returned the list of the Luns in the SAN. > > This is a known problem in virtio-blk's SCSI emulation. Just don't use it, > use > virtio-scsi or

Re: [Qemu-devel] [Qemu/Virtio-scsi]The feature of 'raw device mapping' cannot isolate the LUN to the owning virtual machine

2014-01-27 Thread Paolo Bonzini
Il 27/01/2014 13:22, Qixiaozhen ha scritto: This is not using virtio-scsi. A virtio-scsi disk would appear as /devs/sda in the VM. For example: You can now tr

Re: [Qemu-devel] [PATCH] pcihp: reduce number of device check events

2014-01-27 Thread Igor Mammedov
On Sun, 26 Jan 2014 12:37:09 +0200 "Michael S. Tsirkin" wrote: > PIIX created a made-up value for the UP register since it was read by > guest 32 times for each interrupt. > There's no reason to do this for the new PCIHP: register is only read > once for each interrupt, so clean up code by making

Re: [Qemu-devel] [PATCH] scsi: Change scsi sense buf size to 252

2014-01-27 Thread Paolo Bonzini
Il 26/01/2014 07:11, Benoît Canet ha scritto: Le Friday 24 Jan 2014 à 15:02:24 (+0800), Fam Zheng a écrit : Current buffer size fails the assersion check in like hw/scsi/scsi-bus.c:1655:assert(req->sense_len <= sizeof(req->sense)); when backend (block/iscsi.c) returns more data then 96

[Qemu-devel] [PATCH] scsi: report thin provisioning errors with werror=report

2014-01-27 Thread Paolo Bonzini
SCSI defines a status code for when a thin-provisioned LUNs would exceed the allocated space, map ENOSPC to it. Signed-off-by: Paolo Bonzini --- hw/scsi/scsi-bus.c | 5 + hw/scsi/scsi-disk.c| 3 +++ include/hw/scsi/scsi.h | 2 ++ 3 files changed, 10 insertions(+) diff --git a/hw/scs

Re: [Qemu-devel] [PATCH] MAINTAINERS: add self as virtio co-maintainer

2014-01-27 Thread Michael S. Tsirkin
On Mon, Jan 27, 2014 at 11:51:05AM +0100, Stefan Hajnoczi wrote: > On Mon, Jan 27, 2014 at 10:37:16AM +0100, Kevin Wolf wrote: > > Am 26.01.2014 um 11:40 hat Michael S. Tsirkin geschrieben: > > > This will help make sure I get Cc'd on patches. > > > > You wish... > > > > This won't change the act

Re: [Qemu-devel] [PATCH] pcihp: reduce number of device check events

2014-01-27 Thread Michael S. Tsirkin
On Mon, Jan 27, 2014 at 01:48:44PM +0100, Igor Mammedov wrote: > On Sun, 26 Jan 2014 12:37:09 +0200 > "Michael S. Tsirkin" wrote: > > > PIIX created a made-up value for the UP register since it was read by > > guest 32 times for each interrupt. > > There's no reason to do this for the new PCIHP:

Re: [Qemu-devel] [PULL 7/9] KVM: Retry KVM_CREATE_VM on EINTR

2014-01-27 Thread Alexander Graf
On 20.01.2014, at 15:44, Paolo Bonzini wrote: > From: thomas knych > > Upstreaming this change from Android > (https://android-review.googlesource.com/54211). > > On heavily loaded machines with many VM instances we see KVM_CREATE_VM > failing with EINTR on this path: > > kvm_dev_ioctl_crea

Re: [Qemu-devel] [PULL 7/9] KVM: Retry KVM_CREATE_VM on EINTR

2014-01-27 Thread Paolo Bonzini
Il 27/01/2014 14:44, Alexander Graf ha scritto: On 20.01.2014, at 15:44, Paolo Bonzini wrote: From: thomas knych Upstreaming this change from Android (https://android-review.googlesource.com/54211). On heavily loaded machines with many VM instances we see KVM_CREATE_VM failing with EINTR

Re: [Qemu-devel] live migration between amd fam15h-fam10h

2014-01-27 Thread Markus Kovero
Hi, I am getting a frozen guest when migrating from an Opteron 6274 host (amd fam15h) to an Opteron 6174 host (amd fam10h). The live migration completes succesfully, but the guest is frozen: vcn screen is still there, but no input is possible and no kernel output is seen. Trying "c" on the qe

Re: [Qemu-devel] [PATCH 3/4] hw:acpi:pcihp: assume root PCI bus if bus has no ACPI_PCIHP_PROP_BSEL property

2014-01-27 Thread Igor Mammedov
On Sun, 26 Jan 2014 12:02:23 +0200 "Michael S. Tsirkin" wrote: > On Tue, Jan 21, 2014 at 03:40:05PM +0100, Igor Mammedov wrote: > > when running with machine types older than 1.7 (i.e. without ACPI > > builtin tables), PCI bus won't have ACPI_PCIHP_PROP_BSEL property > > set. > > Taking in accoun

Re: [Qemu-devel] [PATCH] readline: Add missing GCC_FMT_ATTR

2014-01-27 Thread Stefan Hajnoczi
On Sat, Jan 25, 2014 at 06:18:23PM +0100, Stefan Weil wrote: > This fixes a compiler warning with -Werror=missing-format-attribute > and allows improved compiler checks for variable argument lists. > > Signed-off-by: Stefan Weil > --- > include/qemu/readline.h |3 ++- > monitor.c

Re: [Qemu-devel] [Qemu/Virtio-scsi]The feature of 'raw device mapping' cannot isolate the LUN to the owning virtual machine

2014-01-27 Thread Stefan Hajnoczi
On Mon, Jan 27, 2014 at 02:50:04AM +, Qixiaozhen wrote: > A instance was created by virsh command in the CentOS 6.4. > > The LUN in the Storage Array Network(SAN) was attached to the instance with > the following xml. > > > > > >function='0x0'/> > > > >

Re: [Qemu-devel] [PATCH] block/vmdk: add basic .bdrv_check support

2014-01-27 Thread Stefan Hajnoczi
On Mon, Jan 13, 2014 at 12:24:06PM +0100, Peter Lieven wrote: > +for (;;) { > +if (sector_num >= total_sectors) { > +return 0; > +} > +extent = find_extent(s, sector_num, extent); > +if (!extent) { > +fprintf(stderr, "ERROR: could not find

Re: [Qemu-devel] [Qemu-ppc] [V5 PATCH 00/22] target-ppc: PowerPC VSX Stage 3

2014-01-27 Thread Alexander Graf
On 02.01.2014, at 23:21, Tom Musta wrote: > This is the third series of patches to add PowerPC VSX emulation support > to QEMU. > > This series adds the floating point arithmetic, compare, conversion and > rounding instructions. Instructions are implemented using helpers and > wherever practic

[Qemu-devel] [PATCH v2 0/4] pc: make ACPI pcihp more reusable

2014-01-27 Thread Igor Mammedov
changes since v1: - add BSEL property to root bus when in compatibility mode as result dropped "hw:acpi:pcihp: assume root PCI bus if bus has no ACPI_PCIHP_PROP_BSEL property" - rebasing on top of "pcihp: reduce number of device check events" added patch 3/4. Reuses new pcihp code for h

Re: [Qemu-devel] [Qemu-ppc] [V7 PATCH 00/18] target-ppc: VSX Stage 4

2014-01-27 Thread Alexander Graf
On 15.01.2014, at 15:10, Tom Musta wrote: > This is the fourth and final series of patches that add emulation support > to QEMU for the PowerPC Vector Scalar Extension (VSX). > > This series adds the instructions that were newly introduced with Power ISA > V2.07. This includes 3 scalar load in

[Qemu-devel] [PATCH] KVM: Use return value for error print

2014-01-27 Thread Alexander Graf
Commit 94ccff13 introduced a more verbose failure message and retry operations on KVM VM creation. However, it ended up using a variable for its failure message that hasn't been initialized yet. Fix it to use the value it meant to set. Signed-off-by: Alexander Graf --- kvm-all.c | 2 +- 1 file

[Qemu-devel] [PATCH] sclp-s390: Define new SCLP codes and structures

2014-01-27 Thread Matthew Rosato
Define new SCLP codes and structures that will be needed for s390 memory hotplug. Signed-off-by: Matthew Rosato --- include/hw/s390x/sclp.h | 35 +++ 1 file changed, 35 insertions(+) Note: As requested, this patch is fit on: git://github.com/borntraeger/qemu.g

Re: [Qemu-devel] [PATCH target-arm v2] display: avoid multi-statement macro

2014-01-27 Thread Laszlo Ersek
On 01/24/14 20:08, Paolo Bonzini wrote: > For blizzard, pl110 and tc6393xb this is harmless, but for pxa2xx > Coverity noticed that it is used inside an "if" statement. > Fix it because it's the file with the highest number of defects > in the whole QEMU tree! Use "do...while(0)", or just remove t

Re: [Qemu-devel] [PATCH V6 8/8] block: Use graph node name as reference in bdrv_file_open().

2014-01-27 Thread Benoît Canet
Le Friday 24 Jan 2014 à 15:54:39 (+0100), Max Reitz a écrit : > On 24.01.2014 15:48, Kevin Wolf wrote: > >Am 24.01.2014 um 14:37 hat Max Reitz geschrieben: > >>On 24.01.2014 14:26, Kevin Wolf wrote: > >>>Am 23.01.2014 um 21:31 hat Benoît Canet geschrieben: > Signed-off-by: Benoit Canet > -

[Qemu-devel] [PULL 0/4] Tracing patches

2014-01-27 Thread Stefan Hajnoczi
The following changes since commit 0169c511554cb0014a00290b0d3d26c31a49818f: Merge remote-tracking branch 'qemu-kvm/uq/master' into staging (2014-01-24 15:52:44 -0800) are available in the git repository at: git://github.com/stefanha/qemu.git tags/tracing-pull-request for you to fetch cha

[Qemu-devel] [PULL 0/4] Net patches

2014-01-27 Thread Stefan Hajnoczi
The following changes since commit 0169c511554cb0014a00290b0d3d26c31a49818f: Merge remote-tracking branch 'qemu-kvm/uq/master' into staging (2014-01-24 15:52:44 -0800) are available in the git repository at: git://github.com/stefanha/qemu.git tags/net-pull-request for you to fetch changes

[Qemu-devel] [PULL 1/4] tracing: start trace processing thread in final child process

2014-01-27 Thread Stefan Hajnoczi
From: Michael Mueller When running with trace backend e.g. "simple" the writer thread needs to be implemented in the same process context as the trace points that will be processed. Under libvirtd control, qemu gets first started in daemonized mode to privide its capabilities. Creating the writer

Re: [Qemu-devel] [Qemu-ppc] [V4 PATCH 00/22] target-ppc: Base ISA V2.06 for Power7/Power8

2014-01-27 Thread Alexander Graf
On 07.01.2014, at 17:05, Tom Musta wrote: > The QEMU emulation models for Power7 and Power8 are still missing some > of the base instructions that were introduced in Power ISA 2.06 and > even a few that were introduced prior to that. > > This patch series gets these models caught up with respec

Re: [Qemu-devel] [PATCH v3] Describe flaws in qcow/qcow2 encryption in the docs

2014-01-27 Thread Stefan Hajnoczi
On Wed, Jan 22, 2014 at 03:47:10PM +, Daniel P. Berrange wrote: > The qemu-img.texi / qemu-doc.texi files currently describe the > qcow2/qcow2 encryption thus > > "Encryption uses the AES format which is very secure (128 bit >keys). Use a long password (16 characters) to get maximum >

Re: [Qemu-devel] [PATCH] MAINTAINERS: add self as virtio co-maintainer

2014-01-27 Thread Kevin Wolf
Am 27.01.2014 um 11:53 hat Michael S. Tsirkin geschrieben: > On Mon, Jan 27, 2014 at 10:37:16AM +0100, Kevin Wolf wrote: > > Am 26.01.2014 um 11:40 hat Michael S. Tsirkin geschrieben: > > > This will help make sure I get Cc'd on patches. > > > > You wish... > > > > This won't change the actual re

[Qemu-devel] [PULL 1/4] net: Use g_strdup_printf instead of snprintf.

2014-01-27 Thread Stefan Hajnoczi
From: Hani Benhabiles assign_name() in net/net.c is using snprintf + g_strdup to get the same result as g_strdup_printf. Signed-off-by: Hani Benhabiles Signed-off-by: Stefan Hajnoczi --- net/net.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/net/net.c b/net/net.c in

Re: [Qemu-devel] [PATCHv6 0/6] block: add native support for NFS

2014-01-27 Thread Stefan Hajnoczi
On Mon, Jan 13, 2014 at 11:21:52AM +0100, Peter Lieven wrote: > This adds v6 of the NFS protocol driver + qemu-iotest adjustments. > > v5->v6: > - use internal qemu function to parse the NFS url [Kevin] > - zero pad short reads [Kevin, Paolo] > - added qemu-iotests patches for basic nfs protoco

Re: [Qemu-devel] [PULL 3/4] trace: add glib 2.32+ static GMutex support

2014-01-27 Thread Daniel P. Berrange
On Mon, Jan 27, 2014 at 03:53:05PM +0100, Stefan Hajnoczi wrote: > The GStaticMutex API was deprecated in glib 2.32. We cannot switch over > to GMutex unconditionally since we would drop support for older glib > versions. But the deprecated API warnings during build are annoying so > use static G

[Qemu-devel] [PULL 2/4] trace: [simple] Do not include "trace/simple.h" in generated tracer headers

2014-01-27 Thread Stefan Hajnoczi
From: Lluís Vilanova The header is not necessary, given that the simple backend does not define any inlined tracing routines. Signed-off-by: Lluís Vilanova Signed-off-by: Stefan Hajnoczi --- scripts/tracetool/backend/simple.py | 3 --- trace/simple.c | 1 + 2 files change

[Qemu-devel] [PATCH] Human Monitor: migrate command (without -d) now blocks correctly

2014-01-27 Thread Soramichi AKIYAMA
This patch fixes a timing issue that migrate command (without -d) does not block in some cases. The original version of hmp.c:hmp_migrate_status_cb checks if the migration status is 'active' or not to detect the complition of a migration. However, if this function is executed when the migration s

[Qemu-devel] [PULL 4/4] tap-linux: Get features once and use it many times

2014-01-27 Thread Stefan Hajnoczi
From: Kusanagi Kouichi Signed-off-by: Kusanagi Kouichi Signed-off-by: Stefan Hajnoczi --- net/tap-linux.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/net/tap-linux.c b/net/tap-linux.c index 36c09e2..812bf2d 100644 --- a/net/tap-linux.c +++ b/net/tap-linux

[Qemu-devel] [PATCH v2 1/4] hw:piix4:acpi: replace enable|disable_device() with oneliners

2014-01-27 Thread Igor Mammedov
enable_device() and disable_device() functions aren't reused anywere, so replace them with respective oneliners at call sites. Signed-off-by: Igor Mammedov --- hw/acpi/pcihp.c | 14 ++ 1 files changed, 2 insertions(+), 12 deletions(-) diff --git a/hw/acpi/pcihp.c b/hw/acpi/pcihp.c

[Qemu-devel] [PATCH v2 3/4] pcihp: make pci_read() mmio calback compatible with legacy ACPI hotplug

2014-01-27 Thread Igor Mammedov
due to recent change introduced by: "pcihp: reduce number of device check events" 'up' field is cleared right after it's read. This is incompatible with legacy BIOS ACPI code where PCNF ACPI method reads this field 32 times. To make pci_read mmio callback compatible with legacy 'up' behavior, pci

Re: [Qemu-devel] [PATCH 3/4] hw:acpi:pcihp: assume root PCI bus if bus has no ACPI_PCIHP_PROP_BSEL property

2014-01-27 Thread Michael S. Tsirkin
On Mon, Jan 27, 2014 at 03:01:12PM +0100, Igor Mammedov wrote: > On Sun, 26 Jan 2014 12:02:23 +0200 > "Michael S. Tsirkin" wrote: > > > On Tue, Jan 21, 2014 at 03:40:05PM +0100, Igor Mammedov wrote: > > > when running with machine types older than 1.7 (i.e. without ACPI > > > builtin tables), PCI

[Qemu-devel] [PULL 3/4] trace: add glib 2.32+ static GMutex support

2014-01-27 Thread Stefan Hajnoczi
The GStaticMutex API was deprecated in glib 2.32. We cannot switch over to GMutex unconditionally since we would drop support for older glib versions. But the deprecated API warnings during build are annoying so use static GMutex when possible. Signed-off-by: Stefan Hajnoczi --- trace/simple.c

[Qemu-devel] [PULL 4/4] trace: fix simple trace "disable" keyword

2014-01-27 Thread Stefan Hajnoczi
The trace-events "disable" keyword turns an event into a nop at compile-time. This is important for high-frequency events that can impact performance. The "disable" keyword is currently broken in the simple trace backend. This patch fixes the problem as follows: Trace events are identified by th

[Qemu-devel] [PULL 2/4] Fix lan9118 TX "CMD A" handling

2014-01-27 Thread Stefan Hajnoczi
From: Roy Franz The 9118 ethernet controller supports transmission of multi-buffer packets with arbitrary byte alignment of the start and end bytes. All writes to the packet fifo are 32 bits, so the controller discards bytes at the beginning and end of each buffer based on the 'Data start offset

[Qemu-devel] [PULL 3/4] Fix lan9118 buffer length handling

2014-01-27 Thread Stefan Hajnoczi
From: Roy Franz The 9118 ethernet controller supports transmission of multi-buffer packets with arbitrary byte alignment of the start and end bytes. All writes to the packet fifo are 32 bits, so the controller discards bytes at the beginning and end of each buffer based on the 'Data start offset

Re: [Qemu-devel] [PATCH 2/9] target-arm: Add AArch32 FP VRINTA, VRINTN, VRINTP and VRINTM

2014-01-27 Thread Peter Maydell
On 14 January 2014 16:43, Will Newton wrote: > Add support for AArch32 ARMv8 FP VRINTA, VRINTN, VRINTP and VRINTM > instructions. > +static const uint8_t fp_decode_rm[] = { > +FPROUNDING_TIEAWAY, > +FPROUNDING_TIEEVEN, > +FPROUNDING_POSINF, > +FPROUNDING_NEGINF, > +}; This could

Re: [Qemu-devel] [PATCH v6 0/8] Vhost and vhost-net support for userspace based backends

2014-01-27 Thread Michael S. Tsirkin
On Mon, Jan 27, 2014 at 05:37:02PM +0100, Antonios Motakis wrote: > Hello again, > > > On Wed, Jan 15, 2014 at 3:49 PM, Michael S. Tsirkin wrote: > > > > On Wed, Jan 15, 2014 at 01:50:47PM +0100, Antonios Motakis wrote: > > > > > > > > > > > > On Wed, Jan 15, 2014 at 10:07 AM, Michael S. Tsirkin

Re: [Qemu-devel] [PATCH 1/9] target-arm: Move arm_rmode_to_sf to a shared location.

2014-01-27 Thread Peter Maydell
On 14 January 2014 16:43, Will Newton wrote: > This function will be needed for AArch32 ARMv8 support, so move it to > helper.c where it can be used by both targets. Also moves the code out > of line, but as it is quite a large function I don't believe this > should be a significant performance im

[Qemu-devel] [PATCH v2 4/4] hw:piix4:acpi: reuse pcihp code for legacy PCI hotplug

2014-01-27 Thread Igor Mammedov
reduces acpi PCI hotplug code duplication by ~150LOC, and makes pcihp less dependend on piix specific code. Signed-off-by: Igor Mammedov --- v2: - replace obsolete 'device_present' with 'up' field - add/set ACPI_PCIHP_PROP_BSEL to 0 when running in compatibility mode with old machine types.

Re: [Qemu-devel] [PATCH v6 0/8] Vhost and vhost-net support for userspace based backends

2014-01-27 Thread Antonios Motakis
Hello again, On Wed, Jan 15, 2014 at 3:49 PM, Michael S. Tsirkin wrote: > > On Wed, Jan 15, 2014 at 01:50:47PM +0100, Antonios Motakis wrote: > > > > > > > > On Wed, Jan 15, 2014 at 10:07 AM, Michael S. Tsirkin > > wrote: > > > > On Tue, Jan 14, 2014 at 07:13:43PM +0100, Antonios Motakis w

Re: [Qemu-devel] [PATCH 7/9] target-arm: Add set_neon_rmode helper

2014-01-27 Thread Peter Maydell
On 14 January 2014 16:43, Will Newton wrote: > This helper sets the rounding mode in the standard_fp_status word to > allow NEON instructions to modify the rounding mode whilst using the > standard FPSCR values for everything else. > > Signed-off-by: Will Newton Reviewed-by: Peter Maydell than

[Qemu-devel] [PATCH] memory: Pass a target address to walk_memory_regions_1() not a page index.

2014-01-27 Thread Huw Davies
Signed-off-by: Huw Davies --- translate-all.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/translate-all.c b/translate-all.c index 105c25a..e7ed09c 100644 --- a/translate-all.c +++ b/translate-all.c @@ -1641,7 +1641,8 @@ int walk_memory_regions(void *priv, walk_memory_re

Re: [Qemu-devel] [PATCH 8/9] target-arm: Add support for AArch32 SIMD VRINTZ

2014-01-27 Thread Peter Maydell
On 14 January 2014 16:43, Will Newton wrote: > Add support for the AArch32 Advanced SIMD VRINTZ instruction. > > Signed-off-by: Will Newton Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH 6/9] target-arm: Add support for AArch32 SIMD VRINTX

2014-01-27 Thread Peter Maydell
On 14 January 2014 16:43, Will Newton wrote: > Add support for the AArch32 Advanced SIMD VRINTX instruction. > > Signed-off-by: Will Newton Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH 9/9] target-arm: Add AArch32 SIMD VRINTA, VRINTN, VRINTP and VRINTM

2014-01-27 Thread Peter Maydell
On 14 January 2014 16:43, Will Newton wrote: > Add support for the AArch32 Advanced SIMD VRINTA, VRINTN, VRINTP > and VRINTM instructions. > +case NEON_2RM_VRINTN: > +case NEON_2RM_VRINTA: > +case NEON_2RM_VRINTM: > +

Re: [Qemu-devel] fix/re-do query-command-line-options

2014-01-27 Thread Eric Blake
On 12/22/2013 07:19 PM, Amos Kong wrote: > Problem: > * QemuOpts was designed just for options with parameter, some new option > without parameters is lost in query output (eg: -enable-fips) > * block drive uses three QemuOpts, it's legacy issue. > * QemuOpts of some options aren't updated, it m

[Qemu-devel] Support for Emulated SMSC 911X

2014-01-27 Thread Romanic Dean
We are trying to provide support for Emulated SMSC911X Ethernet controller.Current Qemu already had support for SMSC91X controller which looks near SMSC91X controller. For providing support to SMSC911x we have done the following modifications related to kernel changes : 1. modified the versatile

Re: [Qemu-devel] [PATCH 3/9] target-arm: Add support for AArch32 FP VRINTR

2014-01-27 Thread Peter Maydell
On 14 January 2014 16:43, Will Newton wrote: > Add support for the AArch32 floating-point VRINTR instruction. > > Signed-off-by: Will Newton > --- > target-arm/translate.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/target-arm/translate.c b/target-arm/translate.c > inde

[Qemu-devel] [PATCH v2 2/4] hw:piix4:acpi: make PCI hotplug mmio handlers indifferent to PCI_HOTPLUG_ADDR

2014-01-27 Thread Igor Mammedov
... removes dependency of mmio handler on PCI_HOTPLUG_ADDR. It will be needed in case of Q35 where base could be different. Signed-off-by: Igor Mammedov --- hw/acpi/pcihp.c | 24 1 files changed, 12 insertions(+), 12 deletions(-) diff --git a/hw/acpi/pcihp.c b/hw/acpi

Re: [Qemu-devel] Support for Emulated SMSC 911X

2014-01-27 Thread Peter Maydell
On 27 January 2014 16:55, Romanic Dean wrote: > We are trying to provide support for Emulated SMSC911X Ethernet > controller.Current Qemu already had support for SMSC91X controller which > looks near SMSC91X controller. We already support the SMSC 9118 (see hw/net/lan9118.c). What do you need tha

Re: [Qemu-devel] [PATCH 09/10] block: Reuse success path from bdrv_open()

2014-01-27 Thread Jeff Cody
On Sun, Jan 26, 2014 at 08:02:42PM +0100, Max Reitz wrote: > The fail and success paths of bdrv_file_open() may be further shortened > by reusing code already existent in bdrv_open(). This includes > bdrv_file_open() not taking the reference to options which allows the > removal of QDECREF(options)

Re: [Qemu-devel] [PATCH target-arm v5 3/5] zynq_slcr: Implement CPU reset

2014-01-27 Thread Peter Maydell
On 15 January 2014 09:14, Peter Crosthwaite wrote: > Implement the CPU reset IO line of the A9_CPU_RST_CTRL register > (offset 0x244). This is trivial GPIO mapping straight to the register > bits. > > Signed-off-by: Peter Crosthwaite Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH target-arm v5 1/5] arm: zynq: Macroify OCM Base and Size

2014-01-27 Thread Peter Maydell
On 15 January 2014 09:13, Peter Crosthwaite wrote: > Convert magic numbers for OCM to Macros. > > Signed-off-by: Peter Crosthwaite > --- > > hw/arm/xilinx_zynq.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c > index 9

Re: [Qemu-devel] [PATCH target-arm v5 2/5] arm: zynq: added SMP support

2014-01-27 Thread Peter Maydell
On 15 January 2014 09:13, Peter Crosthwaite wrote: > Added Linux SMP support for the Xilinx Zynq platform (2x CPUs are > supported) > > Signed-off-by: Peter Crosthwaite Reviewed-by: Peter Maydell thanks -- PMM

[Qemu-devel] [PATCH 0/8] target-ppc: Base ISA V2.07 for Power8

2014-01-27 Thread Tom Musta
This patch series adds the branch and integer instructions that were introduced in Power ISA 2.07. Specifically, - There is a new conditional Branch to Address Register (bctar) instruction. - The load/store quadword instructions are now supported in user mode (Book I). - Quadword atomic i

Re: [Qemu-devel] [PATCH target-arm v5 4/5] arm: Implement reset GPIO.

2014-01-27 Thread Peter Maydell
On 15 January 2014 09:14, Peter Crosthwaite wrote: > Implement a reset GPIO for ARM CPUs. This allows individual reset of ARM > CPUs from device land without the need for the much unwanted reset API > calls. > > The CPU is halted as long as the pin is held in reset. Releasing the > reset starts th

[Qemu-devel] [PATCH 6/8] target-ppc: Store Quadword

2014-01-27 Thread Tom Musta
This patch adds support for the Store Quadword instruction in user mode. Prior to Power ISA 2.07, stq was legal only in privileged mode. Support for Little Endian mode is also new in ISA 2.07. Signed-off-by: Tom Musta --- target-ppc/translate.c | 43 --

[Qemu-devel] [PATCH 1/8] target-ppc: Add Flag for bctar

2014-01-27 Thread Tom Musta
This patch adds a flag for the bctar instruction. This instruction is being introduced via Power ISA 2.07. Also, the flag is added to the Power8 machine model since the P8 processor supports this instruction. Signed-off-by: Tom Musta --- target-ppc/cpu.h|6 -- target-ppc/tr

[Qemu-devel] [PATCH 4/8] target-ppc: Add Flag for ISA 2.07 Load/Store Quadword Instructions

2014-01-27 Thread Tom Musta
This patch adds a flag to identify the load/store quadword instructions that are introduced with Power ISA 2.07. The flag is added to the Power8 model since P8 supports these instructions. Signed-off-by: Tom Musta --- target-ppc/cpu.h|4 +++- target-ppc/translate_init.c |3 +

[Qemu-devel] [PATCH 5/8] target-ppc: Load Quadword

2014-01-27 Thread Tom Musta
This patch adds the Book I (user space) Load Quadword (lq) instruction. This instruction was introduced into Book I in Power ISA V2.07. Previous versions of the architecture supported this as a privileged instruction. Previous versions of the architecture also did not support Little Endian mode.

[Qemu-devel] [PATCH 7/8] target-ppc: Add Load Quadword and Reserve

2014-01-27 Thread Tom Musta
This patch adds the Load Quadword and Reserve (lqarx) instruction, which is new in Power ISA 2.07. Signed-off-by: Tom Musta --- target-ppc/translate.c | 34 ++ 1 files changed, 34 insertions(+), 0 deletions(-) diff --git a/target-ppc/translate.c b/target-ppc/tr

[Qemu-devel] [PATCH 3/8] target-ppc: Add bctar Instruction

2014-01-27 Thread Tom Musta
This patch adds the Branch Conditional to Address Register (bctar) instruction. Signed-off-by: Tom Musta --- target-ppc/translate.c | 11 ++- 1 files changed, 10 insertions(+), 1 deletions(-) diff --git a/target-ppc/translate.c b/target-ppc/translate.c index f245946..90cbb72 100644 --

[Qemu-devel] [PATCH 2/8] target-ppc: Add Target Address SPR (TAR) to Power8

2014-01-27 Thread Tom Musta
This patch adds support for the Target Address Register (TAR) to the Power8 model. Because supported SPRs are typically identified in an init_proc_*() function and because the Power8 model is currently just using the init_proc_POWER7() function, a new init_proc_POWER8() function is added and plugg

Re: [Qemu-devel] [PATCH target-arm v2] display: avoid multi-statement macro

2014-01-27 Thread Peter Maydell
On 24 January 2014 19:08, Paolo Bonzini wrote: > For blizzard, pl110 and tc6393xb this is harmless, but for pxa2xx > Coverity noticed that it is used inside an "if" statement. > Fix it because it's the file with the highest number of defects > in the whole QEMU tree! Use "do...while(0)", or just

[Qemu-devel] [PATCH 8/8] target-ppc: Add Store Quadword Conditional

2014-01-27 Thread Tom Musta
This patch adds the Store Quadword Conditionl (stqcx.) instruction which is introduced in Power ISA 2.07. Signed-off-by: Tom Musta --- target-ppc/translate.c | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/target-ppc/translate.c b/target-ppc/translat

Re: [Qemu-devel] [PATCH arm-midr v3 0/2] Make ARM-MIDR a property and use in Zynq

2014-01-27 Thread Peter Maydell
On 20 January 2014 00:09, Alistair Francis wrote: > This series converts cpu->midr (the MIDR register) to a property. > This allows it to be set after init which is useful for specific > boards (such as Zynq). The change has been done in such a way that > it doesn't break compatibility with boards

Re: [Qemu-devel] target-arm: aarch64: ask for suggestion, a few insn implementations for review.

2014-01-27 Thread Peter Maydell
On 23 December 2013 08:13, Dennis Lan (dlan) wrote: > On Mon, Dec 23, 2013 at 4:09 PM, Dennis Lan (dlan) > wrote: >>The problem is that there are still a few insn implementations >> missing in matz's repo, >> so I try to implement them myself[4]. I'm not familiar with qemu tcg, >> so those pa

[Qemu-devel] [PATCH target-arm v3] display: avoid multi-statement macro

2014-01-27 Thread Paolo Bonzini
For blizzard, pl110 and tc6393xb this is harmless, but for pxa2xx Coverity noticed that it is used inside an "if" statement. Fix it because it's the file with the highest number of defects in the whole QEMU tree! Use "do...while (0)", or just remove the semicolon if there's a single statement in t

Re: [Qemu-devel] [PATCHv6 0/6] block: add native support for NFS

2014-01-27 Thread Peter Lieven
Am 27.01.2014 17:11, schrieb Stefan Hajnoczi: > On Mon, Jan 13, 2014 at 11:21:52AM +0100, Peter Lieven wrote: >> This adds v6 of the NFS protocol driver + qemu-iotest adjustments. >> >> v5->v6: >> - use internal qemu function to parse the NFS url [Kevin] >> - zero pad short reads [Kevin, Paolo] >

Re: [Qemu-devel] [PATCH v4 1/3] util/fifo8: implement push/pop of multiple bytes

2014-01-27 Thread Peter Maydell
On 26 January 2014 21:39, Beniamino Galvani wrote: > In some circumstances it is useful to be able to push the entire > content of a memory buffer to the fifo or to pop multiple bytes with a > single operation. > > The functions fifo8_has_space() and fifo8_push_all() added by this > patch allow to

Re: [Qemu-devel] [PATCH] block/vmdk: add basic .bdrv_check support

2014-01-27 Thread Peter Lieven
Am 27.01.2014 16:37, schrieb Stefan Hajnoczi: > On Mon, Jan 13, 2014 at 12:24:06PM +0100, Peter Lieven wrote: >> +for (;;) { >> +if (sector_num >= total_sectors) { >> +return 0; >> +} >> +extent = find_extent(s, sector_num, extent); >> +if (!extent) {

Re: [Qemu-devel] [PATCH v4 2/3] hw/net: add support for Allwinner EMAC Fast Ethernet controller

2014-01-27 Thread Peter Maydell
On 26 January 2014 21:39, Beniamino Galvani wrote: > This patch adds support for the Fast Ethernet MAC found on Allwinner > SoCs, together with a basic emulation of Realtek RTL8201CP PHY. > > Since there is no public documentation of the Allwinner controller, the > implementation is based on Linux

  1   2   >