[Qemu-devel] [PATCH v2] drive mirror:fix memory leak

2014-01-23 Thread Zhang Min
In the function mirror_iteration() -> qemu_iovec_init(), it allocates memory for op->qiov.iov, when the write request calls back, but in the function mirror_iteration_done(), it only frees the op, not free the op->qiov.iov, so this causes memory leak. It should use qemu_iovec_destroy() to free op

Re: [Qemu-devel] [PATCH v3 3/3] spapr-hcall: add address-translation-mode-on-interrupt resource in H_SET_MODE

2014-01-23 Thread Aneesh Kumar K.V
Alexey Kardashevskiy writes: > This adds handling of the RESOURCE_ADDR_TRANS_MODE resource from > the H_SET_MODE, for POWER8 (PowerISA 2.07) only. > > Signed-off-by: Alexey Kardashevskiy > --- > hw/ppc/spapr_hcall.c | 26 ++ > target-ppc/cpu.h | 2 ++ > 2 files chan

[Qemu-devel] [PATCH 1/5] qemu-fd-exchange: provide common methods for exchange fd

2014-01-23 Thread Lei Li
Signed-off-by: Lei Li --- include/qemu/fd-exchange.h | 25 +++ util/Makefile.objs |1 + util/qemu-fd-exchange.c| 97 3 files changed, 123 insertions(+), 0 deletions(-) create mode 100644 include/qemu/fd-exchange.h create m

[Qemu-devel] [PATCH 5/5] virtio-9p-proxy: replace v9fs_receivefd with qemu_recv_with_fd

2014-01-23 Thread Lei Li
Signed-off-by: Lei Li --- hw/9pfs/virtio-9p-proxy.c | 60 ++-- 1 files changed, 3 insertions(+), 57 deletions(-) diff --git a/hw/9pfs/virtio-9p-proxy.c b/hw/9pfs/virtio-9p-proxy.c index 5f44bb7..f34b845 100644 --- a/hw/9pfs/virtio-9p-proxy.c +++ b/hw/9pf

[Qemu-devel] [PATCH 0/5 v2] Provide common methods for exchange FD

2014-01-23 Thread Lei Li
This patch series tries to refactor the functions used for exchange of FD in current code, provide common methods for it. I just tested it through page flipping migration, and tap/ bridge-helper a bit, but have some environment problem on proxy fs driver. So it'd be appreciated if someone could h

[Qemu-devel] [PATCH 4/5] virtfs-proxy-helper: replace send_fd with qemu_send_with_fd

2014-01-23 Thread Lei Li
Signed-off-by: Lei Li --- fsdev/virtfs-proxy-helper.c | 51 ++ hw/9pfs/virtio-9p-proxy.h |5 2 files changed, 8 insertions(+), 48 deletions(-) diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c index 713a7b2..44c6e61 100644

[Qemu-devel] [PATCH 2/5] qemu-bridge-helper: replace send_fd with qemu_send_with_fd

2014-01-23 Thread Lei Li
Signed-off-by: Lei Li --- Makefile |2 +- qemu-bridge-helper.c | 31 +++ 2 files changed, 4 insertions(+), 29 deletions(-) diff --git a/Makefile b/Makefile index bdff4e4..6850f35 100644 --- a/Makefile +++ b/Makefile @@ -195,7 +195,7 @@ qemu-img$(EXES

[Qemu-devel] [PATCH 3/5] net/tap: replace recv_fd with qemu_recv_with_fd

2014-01-23 Thread Lei Li
Signed-off-by: Lei Li --- net/tap.c | 40 +++- 1 files changed, 3 insertions(+), 37 deletions(-) diff --git a/net/tap.c b/net/tap.c index 39c1cda..97ee2e8 100644 --- a/net/tap.c +++ b/net/tap.c @@ -39,6 +39,7 @@ #include "sysemu/sysemu.h" #include "qemu-co

[Qemu-devel] [PATCH] qapi: cleanup redundant variable

2014-01-23 Thread Amos Kong
No need to re-append an expr list, it's ok to return schema.exprs Signed-off-by: Amos Kong --- scripts/qapi.py | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/scripts/qapi.py b/scripts/qapi.py index 7b92689..718f1ad 100644 --- a/scripts/qapi.py +++ b/scripts/qapi.py @@ -1

Re: [Qemu-devel] [Xen-devel] Project idea: make QEMU more flexible

2014-01-23 Thread Paolo Bonzini
Il 22/01/2014 17:09, Wei Liu ha scritto: On Wed, Jan 22, 2014 at 11:20:38AM +0100, Paolo Bonzini wrote: Il 21/01/2014 19:27, Wei Liu ha scritto: Googling "disable tcg" would have provided an answer, but the patches were old enough to be basically useless. I'll refresh the current version in t

Re: [Qemu-devel] [PATCH V5 0/7] Giving names to BlockDriverState graph nodes

2014-01-23 Thread Kevin Wolf
Am 22.01.2014 um 22:44 hat Benoît Canet geschrieben: > Le Tuesday 21 Jan 2014 à 16:44:49 (+0100), Kevin Wolf a écrit : > > Am 21.01.2014 um 16:36 hat Benoît Canet geschrieben: > > > Le Tuesday 21 Jan 2014 à 15:33:09 (+0100), Kevin Wolf a écrit : > > > > Am 12.12.2013 um 16:33 hat Benoît Canet gesch

Re: [Qemu-devel] Possible bug in monitor code

2014-01-23 Thread Stratos Psomadakis
On 01/23/2014 05:07 AM, Fam Zheng wrote: > On Wed, 01/22 17:53, Stratos Psomadakis wrote: >> Hi, >> >> we've encountered a weird issue regarding monitor (qmp and hmp) behavior >> with qemu-1.7 (and qemu-1.5). The following steps will reproduce the issue: >> >> 1) Client A connects to qmp socket

Re: [Qemu-devel] [PATCH V5 7/7] qmp: Allow to take external snapshots on bs graphs node.

2014-01-23 Thread Kevin Wolf
Am 22.01.2014 um 22:33 hat Benoît Canet geschrieben: > Le Tuesday 21 Jan 2014 à 15:28:49 (+0100), Kevin Wolf a écrit : > > Am 12.12.2013 um 16:34 hat Benoît Canet geschrieben: > > > Signed-off-by: Benoit Canet > > > --- > > > blockdev.c | 55 > > > ++

Re: [Qemu-devel] KVM and variable-endianness guest CPUs

2014-01-23 Thread Peter Maydell
On 23 January 2014 00:22, Victor Kamensky wrote: > Peter, could I please ask you a favor. Could you please > stop deleting pieces of your and my previous responses > when you reply. No, sorry. It produces excessively long and totally unreadable emails for everybody else if people don't trim for c

Re: [Qemu-devel] [PATCH] configure: helpfully output package names for some missing dependencies.

2014-01-23 Thread Peter Maydell
On 23 January 2014 06:21, Stefan Weil wrote: > My personal impression is that the current hints in configure are > sufficient (with the one exception DTC) and that the QEMU wiki is a > better place to document build dependencies for the different platforms. I tend to agree, with the exception tha

Re: [Qemu-devel] [PATCH v3 00/29] block: Support for 512b-on-4k emulation

2014-01-23 Thread Kevin Wolf
Am 22.01.2014 um 21:30 hat Christian Borntraeger geschrieben: > On 17/01/14 15:14, Kevin Wolf wrote: > > This patch series adds code to the block layer that allows performing > > I/O requests in smaller granularities than required by the host backend > > (most importantly, O_DIRECT restrictions). I

Re: [Qemu-devel] [Qemu-ppc] KVM and variable-endianness guest CPUs

2014-01-23 Thread Alexander Graf
On 23.01.2014, at 05:25, Victor Kamensky wrote: > Hi Alex, > > Sorry, for delayed reply, I was focusing on discussion > with Peter. Hope you and other folks may get something > out of it :). > > Please see responses inline > > On 22 January 2014 02:52, Alexander Graf wrote: >> >> On 22.01.2

Re: [Qemu-devel] [PATCH 10/10] PPC: e500: Move to u-boot as firmware

2014-01-23 Thread Alexander Graf
On 23.01.2014, at 01:23, Scott Wood wrote: > On Mon, 2014-01-20 at 00:44 +0100, Alexander Graf wrote: >> Almost all platforms QEMU emulates have some sort of firmware they can load >> to expose a guest environment that closely resembles the way it would look >> like on real hardware. >> >> This

Re: [Qemu-devel] [PATCH v2] drive mirror:fix memory leak

2014-01-23 Thread Kevin Wolf
Am 23.01.2014 um 08:59 hat Zhang Min geschrieben: > > In the function mirror_iteration() -> qemu_iovec_init(), > it allocates memory for op->qiov.iov, when the write request calls back, > but in the function mirror_iteration_done(), it only frees the op, > not free the op->qiov.iov, so this causes

Re: [Qemu-devel] [PATCH] qapi: store raw expressions to QAPISchema

2014-01-23 Thread Markus Armbruster
Amos Kong writes: > After cleaning up the comments of qapi-schema.json file, we get > an range of raw expressions, they are also converted to ordered > dictionaries. > > This patch just addes a member to QAPISchema to store the raw > expressions. > > Actually this patch was split from QMP introsp

Re: [Qemu-devel] [Qemu-ppc] KVM and variable-endianness guest CPUs

2014-01-23 Thread Greg Kurz
On Wed, 22 Jan 2014 20:25:05 -0800 Victor Kamensky wrote: > Hi Alex, > > Sorry, for delayed reply, I was focusing on discussion > with Peter. Hope you and other folks may get something > out of it :). > > Please see responses inline > > On 22 January 2014 02:52, Alexander Graf wrote: > > > >

Re: [Qemu-devel] [PATCH] configure: helpfully output package names for some missing dependencies.

2014-01-23 Thread Stewart Smith
Stefan Weil writes: > Am 23.01.2014 05:54, schrieb Stewart Smith: >> diff --git a/configure b/configure >> index 3782a6a..87303f6 100755 >> --- a/configure >> +++ b/configure >> @@ -1532,7 +1532,9 @@ EOF >> : >> else >> error_exit "zlib check failed" \ >> -"Make

Re: [Qemu-devel] [PATCH v3 00/29] block: Support for 512b-on-4k emulation

2014-01-23 Thread Christian Borntraeger
On 23/01/14 11:29, Kevin Wolf wrote: > Am 22.01.2014 um 21:30 hat Christian Borntraeger geschrieben: >> On 17/01/14 15:14, Kevin Wolf wrote: >>> This patch series adds code to the block layer that allows performing >>> I/O requests in smaller granularities than required by the host backend >>> (mos

Re: [Qemu-devel] [PATCH] cpu: implementing victim TLB for QEMU system emulated TLB

2014-01-23 Thread Alex Bennée
trent.t...@gmail.com writes: > This patch adds a victim TLB to the QEMU system mode TLB. > > QEMU system mode page table walks are expensive. Taken by running QEMU > qemu-system-x86_64 system mode on Intel PIN , a TLB miss and walking a > 4-level page tables in guest Linux OS takes ~450 X86 instr

Re: [Qemu-devel] Possible bug in monitor code

2014-01-23 Thread Fam Zheng
Bcc: Subject: Re: [Qemu-devel] Possible bug in monitor code Reply-To: In-Reply-To: <52e0ec4b.7010...@grnet.gr> On Thu, 01/23 12:17, Stratos Psomadakis wrote: > On 01/23/2014 05:07 AM, Fam Zheng wrote: > > On Wed, 01/22 17:53, Stratos Psomadakis wrote: > >> Hi, > >> > >> we've encountered a weird

Re: [Qemu-devel] [Qemu-ppc] [PATCH 07/10] PPC: guts: Add emulation of a few more registers

2014-01-23 Thread Alexander Graf
On 23.01.2014, at 01:08, Scott Wood wrote: > On Mon, 2014-01-20 at 00:44 +0100, Alexander Graf wrote: >> The GUTS device is used by system software to find out about hardware >> details of the current system. >> >> We only emulate the bare minimum to be able to reboot a guest which is >> not su

[Qemu-devel] [PULL 0/5] SCSI changes for 2014-01-23

2014-01-23 Thread Paolo Bonzini
Anthony, the following changes since commit 1cf892ca2689c84960b4ce4d2723b6bee453711c: SPARC: Fix LEON3 power down instruction (2014-01-15 15:37:33 +1000) are available in the git repository at: git://github.com/bonzini/qemu.git scsi-next for you to fetch changes up to 1cb27d9233d572826b45b

[Qemu-devel] [PULL 3/5] virtio-scsi: Prevent assertion on missed events

2014-01-23 Thread Paolo Bonzini
From: Eric Farman In some cases, an unplug can cause events to be dropped, which leads to an assertion failure when preparing to notify the guest kernel. Signed-off-by: Eric Farman Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini --- hw/scsi/virtio-scsi.c | 2 +- 1 file changed, 1 inse

Re: [Qemu-devel] [PATCH] qapi: store raw expressions to QAPISchema

2014-01-23 Thread Amos Kong
On Thu, Jan 23, 2014 at 11:53:24AM +0100, Markus Armbruster wrote: > Amos Kong writes: > > > After cleaning up the comments of qapi-schema.json file, we get > > an range of raw expressions, they are also converted to ordered > > dictionaries. > > > > This patch just addes a member to QAPISchema t

[Qemu-devel] [PULL 1/5] scsi: Assign cancel_io vector for scsi_disk_emulate_ops

2014-01-23 Thread Paolo Bonzini
Some emulated disk operations (MODE SELECT, UNMAP, WRITE SAME) can trigger asynchronous I/Os. Provide the cancel_io callback to ensure that AIOCBs are properly cleaned up. Signed-off-by: Eric Farman Cc: qemu-sta...@nongnu.org [Tweak commit message. - Paolo] Signed-off-by: Paolo Bonzini --- hw/

[Qemu-devel] [PULL 2/5] virtio-scsi: Cleanup of I/Os that never started

2014-01-23 Thread Paolo Bonzini
From: Eric Farman There is still a small window that occurs when a cancel I/O affects an asynchronous I/O operation that hasn't started. In other words, when the residual data length equals the expected data length. Today, the routine virtio_scsi_command_complete fails because the VirtIOSCSIReq

[Qemu-devel] [PULL 5/5] scsi: Support TEST UNIT READY in the dummy LUN0

2014-01-23 Thread Paolo Bonzini
SeaBIOS waits for LUN0 to respond to the TEST UNIT READY command in order to decide whether it should part of the boot sequence. If LUN0 does not respond to the command, boot is delayed by up to 5 seconds. This currently happens when there is no LUN0 on a target. Fix that by adding a trivial impl

[Qemu-devel] [PULL 4/5] block: add .bdrv_reopen_prepare() stub for iscsi

2014-01-23 Thread Paolo Bonzini
From: Jeff Cody To suppport reopen(), the .bdrv_reopen_prepare() stub must exist. iSCSI does not have anything that needs to be done to support reopen, so we can just implement the _prepare() stub. Signed-off-by: Jeff Cody Signed-off-by: Paolo Bonzini --- block/iscsi.c | 9 + 1 file c

Re: [Qemu-devel] [PATCH 01/24] target-arm/kvm-consts.h: Define QEMU constants for known KVM CPUs

2014-01-23 Thread Peter Maydell
On 21 January 2014 20:12, Peter Maydell wrote: > -#ifndef TARGET_AARCH64 > +#ifdef TARGET_AARCH64 > +MISMATCH_CHECK(QEMU_KVM_ARM_TARGET_AEM_V8, KVM_ARM_TARGET_ARM_V8) It's been pointed out that there's a typo here which means this won't build on AArch64 hosts: it should read 'KVM_ARM_TARGET_AEM_V

Re: [Qemu-devel] [PATCH] hw/pci: fix error flow in pci multifunction init

2014-01-23 Thread Marcel Apfelbaum
On Tue, 2014-01-21 at 18:37 +0200, Marcel Apfelbaum wrote: > Scenario: > - There is a non multifunction pci device A on 00:0X.0. > - Hot-plug another multifunction pci device B at 00:0X.1. > - The operation will fail of course. > - Try to hot-plug the B device 2-3 more times, qemu will cras

Re: [Qemu-devel] [PATCH v3 1/2] hw/net: add support for Allwinner EMAC Fast Ethernet controller

2014-01-23 Thread Peter Crosthwaite
On Mon, Jan 20, 2014 at 9:25 AM, Beniamino Galvani wrote: > This patch adds support for the Fast Ethernet MAC found on Allwinner > SoCs, together with a basic emulation of Realtek RTL8201CP PHY. > > Since there is no public documentation of the Allwinner controller, the > implementation is based o

Re: [Qemu-devel] [PATCH v3 2/2] hw/arm/allwinner-a10: initialize EMAC

2014-01-23 Thread Peter Crosthwaite
On Mon, Jan 20, 2014 at 9:25 AM, Beniamino Galvani wrote: > Signed-off-by: Beniamino Galvani > --- > hw/arm/allwinner-a10.c | 16 > hw/arm/cubieboard.c|7 +++ > include/hw/arm/allwinner-a10.h |3 +++ > 3 files changed, 26 insertions(+) > > diff

Re: [Qemu-devel] [PATCH arm-midr v3 1/2] ARM: Convert MIDR to a property

2014-01-23 Thread Peter Crosthwaite
On Mon, Jan 20, 2014 at 10:09 AM, Alistair Francis wrote: > Convert the MIDR register to a property. This allows boards to later set > a custom MIDR value. This has been done in such a way to maintain > compatibility with all existing CPUs and boards > > Signed-off-by: Alistair Francis Reviewed-

Re: [Qemu-devel] [PATCH arm-midr v3 2/2] ZYNQ: Implement board MIDR control for Zynq

2014-01-23 Thread Peter Crosthwaite
You should add an "arm:" arch prefix to the patch subject. We also tend not to use all caps for "Zynq" in-tree. On Mon, Jan 20, 2014 at 10:09 AM, Alistair Francis wrote: > This patch uses the fact that the midr variable is now a property > This patch sets the midr variable to the boards custom mi

Re: [Qemu-devel] [PATCH arm-midr v3 1/2] ARM: Convert MIDR to a property

2014-01-23 Thread Andreas Färber
Am 23.01.2014 14:08, schrieb Peter Crosthwaite: > On Mon, Jan 20, 2014 at 10:09 AM, Alistair Francis > wrote: >> Convert the MIDR register to a property. This allows boards to later set >> a custom MIDR value. This has been done in such a way to maintain >> compatibility with all existing CPUs and

[Qemu-devel] [PATCH] vnc: Fix qemu crashed when vnc client disconnect suddenly

2014-01-23 Thread Gonglei (Arei)
Hi, When I use RealVNC viewer client (http://www.realvnc.com/) to connect vnc server, the client disconnect suddenly, and I click reconnect button immediately, then the Qemu crashed. In the function vnc_worker_thread_loop, will call vnc_async_encoding_start to set the local vs->output buffer b

Re: [Qemu-devel] [PATCH v3 2/3] qapi: change qapi to convert schema json

2014-01-23 Thread Luiz Capitulino
On Thu, 23 Jan 2014 11:05:06 +0800 Amos Kong wrote: > On Wed, Jan 22, 2014 at 01:06:51PM -0500, Luiz Capitulino wrote: > > On Sun, 5 Jan 2014 20:02:30 +0800 > > Amos Kong wrote: > > > > > QMP schema is defined in a json file, it will be parsed by > > > qapi scripts and generate C files. > > >

Re: [Qemu-devel] [PATCH 01/16] qemu-char: Allocate CharDriverState in qemu_chr_new_from_opts

2014-01-23 Thread Andreas Färber
Am 12.11.2013 17:33, schrieb Corey Minyard: > This allocates the CharDriverState structure and passes it in to the > open routine. This allows a coming option to automatically attempt to > reconnect a chardev if the connection fails. The chardev has to be > kept around so a reconnect can be done

Re: [Qemu-devel] [PATCH] hw/pci: fix error flow in pci multifunction init

2014-01-23 Thread Markus Armbruster
Marcel Apfelbaum writes: > Scenario: > - There is a non multifunction pci device A on 00:0X.0. > - Hot-plug another multifunction pci device B at 00:0X.1. > - The operation will fail of course. > - Try to hot-plug the B device 2-3 more times, qemu will crash. > > Reason: The error flow le

[Qemu-devel] [PATCH v2 2/7] Don't specify hypervisor system identity

2014-01-23 Thread Vadim Rozenfeld
According to "Requirements for Implementing the Microsoft Hypervisor Interface" (http://msdn.microsoft.com/library/windows/hardware/hh975392) page 5, this leaf is recommended but not required. It may be used for diagnostic and reporting purposes. Signed-off-by: Vadim Rozenfeld --- target-i386/kv

[Qemu-devel] [PATCH v2 1/7] Don't report "Microsoft" as the vendor ID signature.

2014-01-23 Thread Vadim Rozenfeld
According to "Requirements for Implementing the Microsoft Hypervisor Interface" (http://msdn.microsoft.com/library/windows/hardware/hh975392) page 4, conformant hypervisors are not required to report the vendor id signature. Guest use this information for reporting and diagnostic purposes only. Si

[Qemu-devel] [PATCH v2 0/7] Hyper-V parameters update

2014-01-23 Thread Vadim Rozenfeld
This series consists of several clean-ups, hyper-v MSRs migration fixes, and adding support for new "hv-time" parameter, which designed for activating hyper-v timers feature. v2 -> v1 Split the previous series into small pieces. Vadim Rozenfeld (7): Don't report "Microsoft" as the vendor I

[Qemu-devel] [PATCH v2 4/7] Don't report the KVM signature twice, since it's already reported in KVM_CPUID_SIGNATURE CPUID leaf.

2014-01-23 Thread Vadim Rozenfeld
Signed-off-by: Vadim Rozenfeld --- target-i386/kvm.c | 8 1 file changed, 8 deletions(-) diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 8adf27e..c1bc8c0 100644 --- a/target-i386/kvm.c +++ b/target-i386/kvm.c @@ -498,14 +498,6 @@ int kvm_arch_init_vcpu(CPUState *cs)

[Qemu-devel] [PATCH v2 3/7] Don't specify implementation limits

2014-01-23 Thread Vadim Rozenfeld
According to "Requirements for Implementing the Microsoft Hypervisor Interface" (http://msdn.microsoft.com/library/windows/hardware/hh975392) page 7, parameters "The maximum number of virtual processors supported" and "The maximum number of logical processors supported" are not required and may be

[Qemu-devel] [PATCH v2 5/7] make hyperv hypercall and guest os id MSRs migratable.

2014-01-23 Thread Vadim Rozenfeld
Signed-off-by: Vadim Rozenfeld --- target-i386/cpu.h | 2 ++ target-i386/kvm.c | 25 - target-i386/machine.c | 23 +++ 3 files changed, 45 insertions(+), 5 deletions(-) diff --git a/target-i386/cpu.h b/target-i386/cpu.h index 1d94a9d..3bfaf87

[Qemu-devel] [PATCH v2 7/7] add support for hyper-v timers http://msdn.microsoft.com/en-us/library/windows/hardware/ff541625%28v=vs.85%29.aspx This code is generic for activating reference time counte

2014-01-23 Thread Vadim Rozenfeld
Signed-off-by: Vadim Rozenfeld --- linux-headers/asm-x86/hyperv.h | 3 +++ linux-headers/linux/kvm.h | 1 + target-i386/cpu-qom.h | 1 + target-i386/cpu.c | 1 + target-i386/cpu.h | 1 + target-i386/kvm.c | 21 - target

[Qemu-devel] [PATCH v2 6/7] make hyperv vapic assist page migratable

2014-01-23 Thread Vadim Rozenfeld
Signed-off-by: Vadim Rozenfeld --- target-i386/cpu.h | 1 + target-i386/kvm.c | 16 +--- target-i386/machine.c | 22 ++ 3 files changed, 36 insertions(+), 3 deletions(-) diff --git a/target-i386/cpu.h b/target-i386/cpu.h index 3bfaf87..d75a793 100644 ---

Re: [Qemu-devel] [PATCH] cpu: implementing victim TLB for QEMU system emulated TLB

2014-01-23 Thread Xin Tong
On Thu, Jan 23, 2014 at 5:23 AM, Alex Bennée wrote: > > trent.t...@gmail.com writes: > >> This patch adds a victim TLB to the QEMU system mode TLB. >> >> QEMU system mode page table walks are expensive. Taken by running QEMU >> qemu-system-x86_64 system mode on Intel PIN , a TLB miss and walking a

Re: [Qemu-devel] [Xen-devel] Project idea: make QEMU more flexible

2014-01-23 Thread Wei Liu
On Thu, Jan 23, 2014 at 10:11:57AM +0100, Paolo Bonzini wrote: > Il 22/01/2014 17:09, Wei Liu ha scritto: > >On Wed, Jan 22, 2014 at 11:20:38AM +0100, Paolo Bonzini wrote: > >>Il 21/01/2014 19:27, Wei Liu ha scritto: > > > >Googling "disable tcg" would have provided an answer, but the patch

Re: [Qemu-devel] [PATCH 09/13 v7] dump: add API to write dump_bitmap

2014-01-23 Thread Laszlo Ersek
comments below On 01/17/14 08:46, qiaonuohan wrote: > functions are used to write 1st and 2nd dump_bitmap of kdump-compressed > format, > which is used to indicate whether the corresponded page is existed in vmcore. > 1st and 2nd dump_bitmap are same, because dump level is specified to 1 here. >

Re: [Qemu-devel] Possible bug in monitor code

2014-01-23 Thread Luiz Capitulino
On Thu, 23 Jan 2014 08:44:02 -0500 Luiz Capitulino wrote: > On Thu, 23 Jan 2014 19:23:51 +0800 > Fam Zheng wrote: > > > Bcc: > > Subject: Re: [Qemu-devel] Possible bug in monitor code > > Reply-To: > > In-Reply-To: <52e0ec4b.7010...@grnet.gr> > > > > On Thu, 01/23 12:17, Stratos Psomadakis w

Re: [Qemu-devel] [PATCH arm-ccnt v3 1/1] ARM-CCNT: Implements the ARM PMCCNTR register

2014-01-23 Thread Peter Crosthwaite
Same subject-prefix as commented by Andreas. Should be "target-arm". On Wed, Jan 22, 2014 at 9:40 AM, Alistair Francis wrote: > This patch implements the ARM PMCCNTR register including > the disable and reset components of the PMCR register. > > Signed-off-by: Alistair Francis > --- > This patch

Re: [Qemu-devel] [PATCH 01/16] qemu-char: Allocate CharDriverState in qemu_chr_new_from_opts

2014-01-23 Thread Andreas Färber
Am 23.01.2014 14:32, schrieb Andreas Färber: > Am 12.11.2013 17:33, schrieb Corey Minyard: >> This allocates the CharDriverState structure and passes it in to the >> open routine. This allows a coming option to automatically attempt to >> reconnect a chardev if the connection fails. The chardev h

[Qemu-devel] [PATCH] prep: Drop from ppcemb-softmmu

2014-01-23 Thread Andreas Färber
ppcemb covers only embedded processors, which does not include PReP. Signed-off-by: Andreas Färber --- default-configs/ppc-softmmu.mak| 1 + default-configs/ppc64-softmmu.mak | 1 + default-configs/ppcemb-softmmu.mak | 5 - hw/ppc/Makefile.objs | 2 +- 4 files changed, 3 i

Re: [Qemu-devel] [PATCH] hw/pci: fix error flow in pci multifunction init

2014-01-23 Thread Michael S. Tsirkin
On Tue, Jan 21, 2014 at 06:37:51PM +0200, Marcel Apfelbaum wrote: > Scenario: > - There is a non multifunction pci device A on 00:0X.0. > - Hot-plug another multifunction pci device B at 00:0X.1. > - The operation will fail of course. > - Try to hot-plug the B device 2-3 more times, qemu wi

Re: [Qemu-devel] Possible bug in monitor code

2014-01-23 Thread Luiz Capitulino
On Thu, 23 Jan 2014 19:23:51 +0800 Fam Zheng wrote: > Bcc: > Subject: Re: [Qemu-devel] Possible bug in monitor code > Reply-To: > In-Reply-To: <52e0ec4b.7010...@grnet.gr> > > On Thu, 01/23 12:17, Stratos Psomadakis wrote: > > On 01/23/2014 05:07 AM, Fam Zheng wrote: > > > On Wed, 01/22 17:53,

Re: [Qemu-devel] [PATCH] prep: Drop from ppcemb-softmmu

2014-01-23 Thread Alexander Graf
On 23.01.2014, at 15:04, Andreas Färber wrote: > ppcemb covers only embedded processors, which does not include PReP. > > Signed-off-by: Andreas Färber Thanks, applied to ppc-next. Alex

Re: [Qemu-devel] [PATCH v4 1/4] qcow2: remove n_start and n_end of qcow2_alloc_cluster_offset()

2014-01-23 Thread Kevin Wolf
Am 23.01.2014 um 04:04 hat Hu Tao geschrieben: > n_start can be actually calculated from offset. The number of > sectors to be allocated(n_end - n_start) can be passed in in > num. By removing n_start and n_end, we can save two parameters. > > The side effect is there is a bug in qcow2.c:prealloca

Re: [Qemu-devel] [PATCH 08/13 v7] dump: add API to write dump header

2014-01-23 Thread Ekaterina Tumanova
On 01/17/2014 11:46 AM, qiaonuohan wrote: the functions are used to write header of kdump-compressed format to vmcore. Header of kdump-compressed format includes: 1. common header: DiskDumpHeader32 / DiskDumpHeader64 2. sub header: KdumpSubHeader32 / KdumpSubHeader64 3. extra information: only el

Re: [Qemu-devel] [PATCH] ifname=xxx for -netdev bridge

2014-01-23 Thread William Dauchy
On Mon, Jan 20, 2014 at 10:23 PM, Alexandre Kandalintsev wrote: > I was worried that the amount of changes would > turn the maintainers away from the patch. > > Another problem is that I think there is little demand > for this patch. > > But let's try to push it once again. Give me a week or > two

Re: [Qemu-devel] [PATCH] dataplane: fix shadowed return value

2014-01-23 Thread Peter Maydell
On 15 January 2014 03:46, Stefan Hajnoczi wrote: > On Mon, Jan 13, 2014 at 06:47:39PM +0800, Stefan Hajnoczi wrote: >> Propagate the error return value from get_indirect(). >> >> Signed-off-by: Stefan Hajnoczi >> --- >> hw/virtio/dataplane/vring.c | 2 +- >> 1 file changed, 1 insertion(+), 1 del

Re: [Qemu-devel] [PATCH 1/2] qom-test: Run for all available machines

2014-01-23 Thread Andreas Färber
Am 10.01.2014 15:17, schrieb Andreas Färber: > Am 10.01.2014 14:42, schrieb Markus Armbruster: >> arm...@redhat.com writes: >> >>> From: Markus Armbruster >>> >>> Get available machines via QMP instead of hardcoding a list that's >>> perpetually out of date. >>> >>> A few machines don't work out o

Re: [Qemu-devel] [PATCH] vmdk: Fix format specific information (create type) for streamOptimized

2014-01-23 Thread Kevin Wolf
Am 23.01.2014 um 08:10 hat Fam Zheng geschrieben: > Previously the field is wrong: > > $ ./qemu-img create -f vmdk -o subformat=streamOptimized /tmp/a.vmdk 1G > > $ ./qemu-img info /tmp/a.vmdk > image: /tmp/a.vmdk > file format: vmdk > virtual size: 1.0G (1073741824 bytes) >

[Qemu-devel] [PATCH v4 3/5] qobject: introduce qobject_get_str()

2014-01-23 Thread Amos Kong
Signed-off-by: Amos Kong --- include/qapi/qmp/qstring.h | 1 + qobject/qstring.c | 19 +++ 2 files changed, 20 insertions(+) diff --git a/include/qapi/qmp/qstring.h b/include/qapi/qmp/qstring.h index 1bc3666..56b17cb 100644 --- a/include/qapi/qmp/qstring.h +++ b/include

[Qemu-devel] [PATCH v4 0/5] QMP full introspection

2014-01-23 Thread Amos Kong
This is an implement of qmp full-introspection, parse and convert the json schema to a dynamical tree, return it to management through QMP command output. The whole output of query-qmp-schema command: http://i-kvm.rhcloud.com/static/pub/v4/qmp-introspection.output.txt http://i-kvm.rhcloud.com/st

[Qemu-devel] [PATCH v4 1/5] qapi: introduce DataObject to describe dynamic structs

2014-01-23 Thread Amos Kong
This patch introduced a DataObject union in qapi-schema.json, we use it to describe dynamic data structs. We will use it in following patches to support to QMP full introspection. We have many kinds of schema in json file, they all can be described by DataObject. This patch also added a doc: qmp-

[Qemu-devel] [PATCH v4 2/5] qapi: add qapi-introspect.py code generator

2014-01-23 Thread Amos Kong
This is a code generator for qapi introspection. It will parse qapi-schema.json, extend schema definitions and generate a schema table with metadata, it references to the new structs which we used to describe dynamic data structs. The metadata will help C code to allocate right structs and provide

[Qemu-devel] [PATCH v4 5/5] update docs/qmp-full-introspection.txt

2014-01-23 Thread Amos Kong
Signed-off-by: Amos Kong --- docs/qmp-full-introspection.txt | 38 ++ 1 file changed, 38 insertions(+) diff --git a/docs/qmp-full-introspection.txt b/docs/qmp-full-introspection.txt index 8ecbc0c..4cb1b9e 100644 --- a/docs/qmp-full-introspection.txt +++ b/docs

[Qemu-devel] [PATCH v4 4/5] qmp: full introspection support for QMP

2014-01-23 Thread Amos Kong
This patch introduces a new monitor command to query QMP schema information, the return data is a range of schema structs, which contains the useful metadata to help management to check supported features, QMP commands detail, etc. We use qapi-introspect.py to parse all json definition in qapi-sch

Re: [Qemu-devel] [PATCH 10/13 v7] dump: add APIs to operate DataCache

2014-01-23 Thread Laszlo Ersek
one comment below On 01/17/14 08:46, qiaonuohan wrote: > DataCache is used to store data temporarily, then the data will be written to > vmcore. These functions will be called later when writing data of page to > vmcore. > > Signed-off-by: Qiao Nuohan > Reviewed-by: Laszlo Ersek > --- > dump.c

Re: [Qemu-devel] [PATCH 1/2] qom-test: Run for all available machines

2014-01-23 Thread Markus Armbruster
arm...@redhat.com writes: > From: Markus Armbruster > > Get available machines via QMP instead of hardcoding a list that's > perpetually out of date. > > A few machines don't work out of the box: > > * Several ppcemb machines can't initialize their CPU. > > * Xen machines can work only when runni

Re: [Qemu-devel] [PATCH] dataplane: fix shadowed return value

2014-01-23 Thread Kevin Wolf
Am 23.01.2014 um 15:38 hat Peter Maydell geschrieben: > On 15 January 2014 03:46, Stefan Hajnoczi wrote: > > On Mon, Jan 13, 2014 at 06:47:39PM +0800, Stefan Hajnoczi wrote: > >> Propagate the error return value from get_indirect(). > >> > >> Signed-off-by: Stefan Hajnoczi > >> --- > >> hw/virti

Re: [Qemu-devel] KVM and variable-endianness guest CPUs

2014-01-23 Thread Victor Kamensky
On 23 January 2014 02:23, Peter Maydell wrote: > On 23 January 2014 00:22, Victor Kamensky wrote: >> Peter, could I please ask you a favor. Could you please >> stop deleting pieces of your and my previous responses >> when you reply. > > No, sorry. It produces excessively long and totally unreada

Re: [Qemu-devel] [PATCH 12/13 v7] dump: make kdump-compressed format available for 'dump-guest-memory'

2014-01-23 Thread Ekaterina Tumanova
On 01/17/2014 11:46 AM, qiaonuohan wrote: Make monitor command 'dump-guest-memory' be able to dump in kdump-compressed format. The command's usage: dump [-p] protocol [begin] [length] [format] 'format' is used to specified the format of vmcore and can be: 1. 'elf': ELF format, without compre

[Qemu-devel] [PATCH v2 3/8] target-arm: A64: Add SIMD scalar 3 same add, sub and compare ops

2014-01-23 Thread Peter Maydell
Implement the add, sub and compare ops from the SIMD "scalar three same" group. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- target-arm/translate-a64.c | 131 - 1 file changed, 130 insertions(+), 1 deletion(-) diff --git a/target-a

[Qemu-devel] [PATCH v2 6/8] target-arm: A64: Add integer ops from SIMD 3-same group

2014-01-23 Thread Peter Maydell
Add some of the integer operations in the SIMD 3-same group: specifically, the comparisons, addition and subtraction. Signed-off-by: Peter Maydell --- target-arm/translate-a64.c | 158 - 1 file changed, 157 insertions(+), 1 deletion(-) diff --git a/ta

Re: [Qemu-devel] [PULL 24/49] target-i386: Remove gen_op_movl_T0_im*

2014-01-23 Thread Kevin Wolf
Am 07.01.2014 um 22:00 hat Richard Henderson geschrieben: > Propagate the definition of gen_op_movl_T0_im to all users. > The function gen_op_movl_T0_imu was unused. > > Reviewed-by: Peter Maydell > Signed-off-by: Richard Henderson > --- > target-i386/translate.c | 32 ++

[Qemu-devel] [PATCH v2 5/8] target-arm: A64: Add logic ops from SIMD 3 same group

2014-01-23 Thread Peter Maydell
Add support for the logical operations (ORR, AND, BIC, ORN, EOR, BSL, BIT and BIF) from the SIMD 3 register same group (C3.6.16). Signed-off-by: Alex Bennée Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- target-arm/translate-a64.c | 73 +

[Qemu-devel] [PATCH v2 8/8] target-arm: A64: Add SIMD shift by immediate

2014-01-23 Thread Peter Maydell
From: Alex Bennée This implements a subset of the AdvSIMD shift operations (namely all the none saturating or narrowing ones). The actual shift generation code itself is common for both the scalar and vector cases but wrapped with either vector element iteration or the fp reg access. The roundin

Re: [Qemu-devel] [PATCH 11/13 v7] dump: add API to write dump pages

2014-01-23 Thread Laszlo Ersek
On 01/17/14 08:46, qiaonuohan wrote: > functions are used to write page to vmcore. vmcore is written page by page. > page desc is used to store the information of a page, including a page's size, > offset, compression format, etc. > > Signed-off-by: Qiao Nuohan > --- > dump.c| 2

Re: [Qemu-devel] KVM and variable-endianness guest CPUs

2014-01-23 Thread Peter Maydell
On 23 January 2014 15:06, Victor Kamensky wrote: > In [1] I wrote > > "I don't see why you so attached to desire to describe > data part of memory transaction as just one of int > types. If we are talking about bunch of hypothetical > cases imagine such bus that allow transaction with > size of 6

Re: [Qemu-devel] Possible bug in monitor code

2014-01-23 Thread Stratos Psomadakis
On 01/23/2014 03:54 PM, Luiz Capitulino wrote: > On Thu, 23 Jan 2014 08:44:02 -0500 > Luiz Capitulino wrote: > >> On Thu, 23 Jan 2014 19:23:51 +0800 >> Fam Zheng wrote: >> >>> Bcc: >>> Subject: Re: [Qemu-devel] Possible bug in monitor code >>> Reply-To: >>> In-Reply-To: <52e0ec4b.7010...@grnet.

[Qemu-devel] [PATCH v2 2/8] target-arm: A64: Add SIMD three-different ABDL instructions

2014-01-23 Thread Peter Maydell
Implement the absolute-difference instructions in the SIMD three-different group: SABAL, SABAL2, UABAL, UABAL2, SABDL, SABDL2, UABDL, UABDL2. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- target-arm/translate-a64.c | 35 +-- 1 file changed, 33 i

[Qemu-devel] [PATCH v2 1/8] target-arm: A64: Add SIMD three-different multiply accumulate insns

2014-01-23 Thread Peter Maydell
Add support for the multiply-accumulate instructions from the SIMD three-different instructions group (C3.6.15): * skeleton decode of unallocated encodings and split of the group into its three sub-parts * framework for handling the 64x64->128 widening subpart * implementation of the multiply

[Qemu-devel] [PATCH v2 4/8] target-arm: A64: Add top level decode for SIMD 3-same group

2014-01-23 Thread Peter Maydell
Add top level decode for the A64 SIMD three regs same group (C3.6.16), splitting it into the pairwise, logical, float and integer subgroups. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- target-arm/translate-a64.c | 45 - 1 file chan

[Qemu-devel] [PATCH v2 0/8] target-arm: A64 Neon instructions, set 2

2014-01-23 Thread Peter Maydell
This is the second set of patches for A64 Neon. The last patch set did a complete coverage of some of the smaller and simpler instruction groupings; this patch set attacks a few of the larger groupings (3-same; scalar 3-same; 3-different; shift-imm; scalar shift-imm) and doesn't attempt complete co

[Qemu-devel] [PATCH v2 7/8] target-arm: A64: Add simple SIMD 3-same floating point ops

2014-01-23 Thread Peter Maydell
Implement a simple subset of the SIMD 3-same floating point operations. This includes a common helper function used for both scalar and vector ops; FABD is the only currently implemented shared op. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- target-arm/translate-a64.c | 191

Re: [Qemu-devel] [PATCH 1/2] qom-test: Run for all available machines

2014-01-23 Thread Peter Maydell
On 23 January 2014 14:41, Andreas Färber wrote: > As indicated on IRC, I want to get those fixed before transforming one > notation to another. Especially this patch is throwing them all in one > bucket dropping any annotation hinting at why and how it may be fixed. Would you accept a version whe

[Qemu-devel] [PATCH] ppcemb-softmmu: Drop Mac and e500 emulation

2014-01-23 Thread Andreas Färber
They are still available in ppc-softmmu and ppc64-softmmu. Signed-off-by: Andreas Färber --- default-configs/ppc-softmmu.mak| 1 + default-configs/ppc64-softmmu.mak | 1 + default-configs/ppcemb-softmmu.mak | 20 hw/ppc/Makefile.objs | 4 ++-- 4 files c

Re: [Qemu-devel] [PATCH 1/2] qom-test: Run for all available machines

2014-01-23 Thread Andreas Färber
Am 23.01.2014 16:40, schrieb Peter Maydell: > On 23 January 2014 14:41, Andreas Färber wrote: >> As indicated on IRC, I want to get those fixed before transforming one >> notation to another. Especially this patch is throwing them all in one >> bucket dropping any annotation hinting at why and how

Re: [Qemu-devel] [PATCH 1/2] qom-test: Run for all available machines

2014-01-23 Thread Peter Maydell
On 23 January 2014 15:45, Andreas Färber wrote: > I have also now sent out a patch covering Macs and e500. So the answer > is, I will accept a patch that has a reasonably small blacklist. The > time you're arguing about this on IRC and here you could've spent > actually helping investigate and fix

[Qemu-devel] [PATCH] tests/Makefile: Run qom-test for every architecture

2014-01-23 Thread Peter Maydell
Rather than requiring every new architecture to remember to add a line to the Makefile to say that qom-test will work on it, autogenerate the list of supported architectures by looking at the files in default-configs (as configure does), and add qom-test to the test list for all of them automatical

Re: [Qemu-devel] KVM and variable-endianness guest CPUs

2014-01-23 Thread Victor Kamensky
On 23 January 2014 07:33, Peter Maydell wrote: > On 23 January 2014 15:06, Victor Kamensky wrote: >> In [1] I wrote >> >> "I don't see why you so attached to desire to describe >> data part of memory transaction as just one of int >> types. If we are talking about bunch of hypothetical >> cases i

Re: [Qemu-devel] [Xen-devel] Project idea: make QEMU more flexible

2014-01-23 Thread Wei Liu
On Thu, Jan 23, 2014 at 01:54:40PM +, Wei Liu wrote: > On Thu, Jan 23, 2014 at 10:11:57AM +0100, Paolo Bonzini wrote: > > Il 22/01/2014 17:09, Wei Liu ha scritto: > > >On Wed, Jan 22, 2014 at 11:20:38AM +0100, Paolo Bonzini wrote: > > >>Il 21/01/2014 19:27, Wei Liu ha scritto: > > > > > >>>

Re: [Qemu-devel] [PATCH v2 1/8] target-arm: A64: Add SIMD three-different multiply accumulate insns

2014-01-23 Thread Richard Henderson
On 01/23/2014 07:28 AM, Peter Maydell wrote: > Add support for the multiply-accumulate instructions from the > SIMD three-different instructions group (C3.6.15): > * skeleton decode of unallocated encodings and split of >the group into its three sub-parts > * framework for handling the 64x64-

  1   2   >