[Qemu-devel] [PATCH 1/3] cleanup hyper-v interface initialization

2014-01-21 Thread Vadim Rozenfeld
Signed-off-by: Vadim Rozenfeld --- target-i386/kvm.c | 46 +- 1 file changed, 17 insertions(+), 29 deletions(-) diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 7522e98..768ca1d 100644 --- a/target-i386/kvm.c +++ b/target-i386/kvm.c @@ -71,6 +7

[Qemu-devel] [PATCH 0/3] Hyper-V parameters

2014-01-21 Thread Vadim Rozenfeld
From: Vadim Rozenfeld This series conists of three patches and addresses the following issues: - adjusting hyperv parameters according to MS requirements http://msdn.microsoft.com/library/windows/hardware/hh975392 - make hyperv hypercall and vapic pages migratable - add support for enabling

[Qemu-devel] [PATCH 3/3] add support for hyperv time parameter

2014-01-21 Thread Vadim Rozenfeld
From: Vadim Rozenfeld Signed-off-by: Vadim Rozenfeld --- linux-headers/asm-x86/hyperv.h | 3 +++ linux-headers/linux/kvm.h | 1 + target-i386/cpu-qom.h | 1 + target-i386/cpu.c | 1 + target-i386/cpu.h | 1 + target-i386/kvm.c | 19 +

[Qemu-devel] [PATCH 2/3] make hyperv hypercall, vapic, and os id MSRs migratable

2014-01-21 Thread Vadim Rozenfeld
Signed-off-by: Vadim Rozenfeld --- target-i386/cpu.h | 4 target-i386/kvm.c | 30 +- target-i386/machine.c | 24 3 files changed, 53 insertions(+), 5 deletions(-) diff --git a/target-i386/cpu.h b/target-i386/cpu.h index 1d94a9d..

[Qemu-devel] [PATCH 0/3] Hyper-V parameters

2014-01-21 Thread Vadim Rozenfeld
From: Vadim Rozenfeld This series conists of three patches and addresses the following issues: - adjusting hyperv parameters according to MS requirements http://msdn.microsoft.com/library/windows/hardware/hh975392 - make hyperv hypercall and vapic pages migratable - add support for enabling

Re: [Qemu-devel] [RFC PATCH] elf loader: exit if incompatible architecture is detected

2014-01-21 Thread Alexander Graf
> Am 21.01.2014 um 05:04 schrieb Alexey Kardashevskiy : > >> On 01/21/2014 02:11 AM, Alexander Graf wrote: >> >>> On 07.01.2014, at 05:35, Alexey Kardashevskiy wrote: >>> >>> If we know for sure that the image in "-kernel" is an ELF and we know its >>> architecture and it is not supported by

Re: [Qemu-devel] Exposing and calculating CPU APIC IDs (was Re: [RFC 1/3] target-i386: moving registers of vmstate from cpu_exec_init() to x86_cpu_realizefn())

2014-01-21 Thread Igor Mammedov
On Tue, 21 Jan 2014 15:12:45 +0800 Chen Fan wrote: > On Mon, 2014-01-20 at 13:29 +0100, Igor Mammedov wrote: > > On Fri, 17 Jan 2014 17:13:55 -0200 > > Eduardo Habkost wrote: > > > > > On Wed, Jan 15, 2014 at 03:37:04PM +0100, Igor Mammedov wrote: > > > > On Wed, 15 Jan 2014 20:24:01 +0800 > >

Re: [Qemu-devel] Exposing and calculating CPU APIC IDs (was Re: [RFC 1/3] target-i386: moving registers of vmstate from cpu_exec_init() to x86_cpu_realizefn())

2014-01-21 Thread Chen Fan
On Tue, 2014-01-21 at 10:31 +0100, Igor Mammedov wrote: > On Tue, 21 Jan 2014 15:12:45 +0800 > Chen Fan wrote: > > > On Mon, 2014-01-20 at 13:29 +0100, Igor Mammedov wrote: > > > On Fri, 17 Jan 2014 17:13:55 -0200 > > > Eduardo Habkost wrote: > > > > > > > On Wed, Jan 15, 2014 at 03:37:04PM +01

Re: [Qemu-devel] [PATCH 00/13 v7] Make 'dump-guest-memory' dump in kdump-compressed format

2014-01-21 Thread Qiao Nuohan
Hello, Do you have some comments on the version? On 01/17/2014 03:46 PM, qiaonuohan wrote: Hi, all The last version is here: http://lists.nongnu.org/archive/html/qemu-devel/2014-01/msg00209.html Command 'dump-guest-memory' was introduced to dump guest's memory. But the vmcore's format is only

Re: [Qemu-devel] [PATCH] spapr-pci: enable adding PHB via -device

2014-01-21 Thread Alexey Kardashevskiy
On 01/21/2014 06:56 PM, Markus Armbruster wrote: > Alexey Kardashevskiy writes: > >> On 01/21/2014 02:27 AM, Markus Armbruster wrote: >>> Alexey Kardashevskiy writes: >>> Recent changes introduced cannot_instantiate_with_device_add_yet and removed capability of adding yet another PCI h

Re: [Qemu-devel] [PATCH] target-i386: enable x2apic by default on more recent CPU models

2014-01-21 Thread Paolo Bonzini
Il 20/01/2014 23:13, Andreas Färber ha scritto: > I don't like the argument that we can put arbitrary stuff in our model > definitions and rely on TCG not having implemented it to make it > correct. Is x2apic something that TCG can never implement for some > reason? Then that needs a better explana

Re: [Qemu-devel] [PATCH 0/7 RESEND] target-i386: Simplify kvm_cpu_fill_host() and kvm_check_features_against_host()

2014-01-21 Thread Paolo Bonzini
Il 20/01/2014 21:39, Michael S. Tsirkin ha scritto: >>> > > Resend of series submitted on 24 November 2013, that didn't get any >>> > > reply. Only >>> > > change is a trivial conflict on patch 7/7. >> > >> > Question: which tree is the most appropriate to get this in? qom-cpu? >> > kvm? > Either

[Qemu-devel] [PATCH v2 2/2] spapr-hcall: fix H_SET_MODE

2014-01-21 Thread Alexey Kardashevskiy
This changes resource code definitions to ones used in the host kernel. This fixes H_SET_MODE_RESOURCE_LE (change between big endian and little endian) to update registers from KVM before changing LPCR value. This adds handling of H_SET_MODE_RESOURCE_ADDR_TRANS_MODE, for POWER8 (PowerISA 2.07) on

[Qemu-devel] [PATCH v2 0/2] spapr: fix H_SET_MODE

2014-01-21 Thread Alexey Kardashevskiy
This is v2 of "spapr: reset @kvm_vcpu_dirty before starting CPU" Does it make much sense to split "spapr-hcall: fix H_SET_MODE"? Please comment. Thanks! Alexey Kardashevskiy (2): target-ppc: introduce powerisa-207-server flag spapr-hcall: fix H_SET_MODE hw/ppc/spapr_hcall.c| 64 ++

[Qemu-devel] [PATCH v2 1/2] target-ppc: introduce powerisa-207-server flag

2014-01-21 Thread Alexey Kardashevskiy
This flag will be used to decide whether to emulate some bits of H_SET_MODE hypercall because some are POWER8-only. While we are here, add 2.05 flag to POWER8 family too. POWER7/7+ already has it. Signed-off-by: Alexey Kardashevskiy --- target-ppc/cpu.h| 2 ++ target-ppc/translate_i

Re: [Qemu-devel] Exposing and calculating CPU APIC IDs (was Re: [RFC 1/3] target-i386: moving registers of vmstate from cpu_exec_init() to x86_cpu_realizefn())

2014-01-21 Thread Andreas Färber
Am 21.01.2014 10:51, schrieb Chen Fan: > On Tue, 2014-01-21 at 10:31 +0100, Igor Mammedov wrote: >> On Tue, 21 Jan 2014 15:12:45 +0800 >> Chen Fan wrote: >>> On Mon, 2014-01-20 at 13:29 +0100, Igor Mammedov wrote: On Fri, 17 Jan 2014 17:13:55 -0200 Eduardo Habkost wrote: > On Wed, J

Re: [Qemu-devel] [PATCH 00/13 v7] Make 'dump-guest-memory' dump in kdump-compressed format

2014-01-21 Thread Laszlo Ersek
Hi, On 01/21/14 10:56, Qiao Nuohan wrote: > Do you have some comments on the version? it's in my review queue. The last version took a lot of energy on my part to review (it's long and complex) so I'm still "gearing up". I very much hope I can review this version by diffing it with the last ver

Re: [Qemu-devel] [PATCH 1/3] cleanup hyper-v interface initialization

2014-01-21 Thread Paolo Bonzini
Il 21/01/2014 09:02, Vadim Rozenfeld ha scritto: > Signed-off-by: Vadim Rozenfeld > --- > target-i386/kvm.c | 46 +- > 1 file changed, 17 insertions(+), 29 deletions(-) Please split this part into multiple parts and document each in the commit message.

Re: [Qemu-devel] [PATCH 2/3] make hyperv hypercall, vapic, and os id MSRs migratable

2014-01-21 Thread Paolo Bonzini
Il 21/01/2014 09:02, Vadim Rozenfeld ha scritto: > Signed-off-by: Vadim Rozenfeld > --- > target-i386/cpu.h | 4 > target-i386/kvm.c | 30 +- > target-i386/machine.c | 24 > 3 files changed, 53 insertions(+), 5 deletions(-) > > d

Re: [Qemu-devel] [PATCH] spapr-pci: enable adding PHB via -device

2014-01-21 Thread Andreas Färber
Am 21.01.2014 02:37, schrieb Alexey Kardashevskiy: > On 01/21/2014 02:27 AM, Markus Armbruster wrote: >> Alexey Kardashevskiy writes: >> >>> Recent changes introduced cannot_instantiate_with_device_add_yet >>> and removed capability of adding yet another PCI host bridge via >>> command line for SP

Re: [Qemu-devel] [PATCH 0/7 RESEND] target-i386: Simplify kvm_cpu_fill_host() and kvm_check_features_against_host()

2014-01-21 Thread Andreas Färber
Am 21.01.2014 11:03, schrieb Paolo Bonzini: > Il 20/01/2014 21:39, Michael S. Tsirkin ha scritto: >> Resend of series submitted on 24 November 2013, that didn't get any >> reply. Only >> change is a trivial conflict on patch 7/7. Question: which tree is the most appropriate t

[Qemu-devel] [PATCH 1/1] hda-codec: disable streams on reset

2014-01-21 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/audio/hda-codec.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/hw/audio/hda-codec.c b/hw/audio/hda-codec.c index 07a43bf..986f2a9 100644 --- a/hw/audio/hda-codec.c +++ b/hw/audio/hda-codec.c @@ -559,6 +559,21 @@ static int hda_audio_p

[Qemu-devel] [PULL 0/1] hda-codec: disable streams on reset

2014-01-21 Thread Gerd Hoffmann
Hi, Audio patch queue with a single fix. please pull, Gerd The following changes since commit 1cf892ca2689c84960b4ce4d2723b6bee453711c: SPARC: Fix LEON3 power down instruction (2014-01-15 15:37:33 +1000) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-audio

Re: [Qemu-devel] [PATCH 3/3] add support for hyperv time parameter

2014-01-21 Thread Paolo Bonzini
Il 21/01/2014 09:02, Vadim Rozenfeld ha scritto: > From: Vadim Rozenfeld > > Signed-off-by: Vadim Rozenfeld > --- > linux-headers/asm-x86/hyperv.h | 3 +++ > linux-headers/linux/kvm.h | 1 + > target-i386/cpu-qom.h | 1 + > target-i386/cpu.c | 1 + > target-i386/c

[Qemu-devel] [PULL 0/2] usb: add support for microsoft os descriptors

2014-01-21 Thread Gerd Hoffmann
Hi, Small usb patch queue, featuring support for microsoft os descriptors. please pull, Gerd The following changes since commit 1cf892ca2689c84960b4ce4d2723b6bee453711c: SPARC: Fix LEON3 power down instruction (2014-01-15 15:37:33 +1000) are available in the git repository at: git://g

[Qemu-devel] [PATCH 2/2] usb-hid: add microsoft os descriptor support

2014-01-21 Thread Gerd Hoffmann
Set SelectiveSuspendEnabled registy entry to one. This makes Windows use remote suspend by default, without manual registry fiddeling. Signed-off-by: Gerd Hoffmann --- hw/usb/dev-hid.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/usb/dev-hid.c b/hw/usb/dev-hid.c index 5e667f0..

[Qemu-devel] [PATCH 1/2] usb: add support for microsoft os descriptors

2014-01-21 Thread Gerd Hoffmann
This patch adds support for special usb descriptors used by microsoft windows. They allow more fine-grained control over driver binding and adding entries to the registry for configuration. As this is a guest-visible change the "msos-desc" compat property has been added to turn this off for 1.7 +

Re: [Qemu-devel] [PATCH 1/1] hda-codec: disable streams on reset

2014-01-21 Thread Andreas Färber
Am 21.01.2014 11:19, schrieb Gerd Hoffmann: > Signed-off-by: Gerd Hoffmann > --- > hw/audio/hda-codec.c | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a/hw/audio/hda-codec.c b/hw/audio/hda-codec.c > index 07a43bf..986f2a9 100644 > --- a/hw/audio/hda-codec.c > +++ b/hw

Re: [Qemu-devel] RFC: ACPI, HPET._CRS, MacOSX vs. WinXP

2014-01-21 Thread Paolo Bonzini
Il 20/01/2014 22:25, Gabriel L. Somlo ha scritto: > > "Implementation Note > Place the routine that identifies the operating system in an _INI method > under the \_SB scope so that _OSI can run as early as possible. This > placement is important because the operating system makes features >

Re: [Qemu-devel] [PATCH 4/7] target-i386: kvm_cpu_fill_host(): No need to check xlevel2

2014-01-21 Thread Paolo Bonzini
Il 20/01/2014 17:41, Eduardo Habkost ha scritto: > -eax = kvm_arch_get_supported_cpuid(s, 0xC000, 0, R_EAX); > -if (eax >= 0xC001) { > -/* Support VIA max extended level */ > -x86_cpu_def->xlevel2 = eax; > -x86_cpu_def->features[FEAT_C000_0001_EDX] = > -

Re: [Qemu-devel] [PATCH v4] hw/display/qxl: fix signed to unsigned comparison

2014-01-21 Thread Gerd Hoffmann
On Mo, 2014-01-20 at 18:57 +0200, Alon Levy wrote: > Several small signedness / overflow corrections to > qxl_create_guest_primary: > 1. use 64 bit unsigned for size to avoid overflow possible from two 32 > bit multiplicants. > 2. correct sign for requested_height > 3. add a more verbose error mess

Re: [Qemu-devel] [PATCH 2/2] qxl: clear irq on reset

2014-01-21 Thread Gerd Hoffmann
On Mo, 2014-01-20 at 12:44 +0200, Alon Levy wrote: > Without this we occasionally trigger an assert at > hw/pci/pci.c:pcibus_reset that asserts the irq_count is zero on reset. > > This has become a problem with the new drm driver for linux, since > doing > a reboot from console causes a race betwe

Re: [Qemu-devel] [PATCH] qcow2: fix wrong value of L1E_OFFSET_MASK, L2E_OFFSET_MASK and REFT_OFFSET_MASK

2014-01-21 Thread Kevin Wolf
Am 21.01.2014 um 04:30 hat Hu Tao geschrieben: > Accoring to qcow spec, the offset fields in l1e, l2e and ref table entry > start at bit 9. The offset is cluster offset, and the smallest possible > cluster size is 512 bytes. > > Signed-off-by: Hu Tao Thanks, applied to the block branch (and remo

Re: [Qemu-devel] RFC: ACPI, HPET._CRS, MacOSX vs. WinXP

2014-01-21 Thread Michael S. Tsirkin
On Tue, Jan 21, 2014 at 11:33:00AM +0100, Paolo Bonzini wrote: > Il 20/01/2014 22:25, Gabriel L. Somlo ha scritto: > > > > "Implementation Note > > Place the routine that identifies the operating system in an _INI method > > under the \_SB scope so that _OSI can run as early as possible. This

Re: [Qemu-devel] [PATCH v1 3/3] qcow2: check for NULL l2meta

2014-01-21 Thread Kevin Wolf
Am 21.01.2014 um 07:02 hat Hu Tao geschrieben: > On Tue, Jan 21, 2014 at 11:33:18AM +0800, Hu Tao wrote: > > On Mon, Jan 20, 2014 at 04:17:16PM +0100, Kevin Wolf wrote: > > > Am 20.01.2014 um 04:04 hat Hu Tao geschrieben: > > > > On Sun, Jan 19, 2014 at 05:18:05PM +0100, Max Reitz wrote: > > > > >

Re: [Qemu-devel] RFC: ACPI, HPET._CRS, MacOSX vs. WinXP

2014-01-21 Thread Paolo Bonzini
Il 21/01/2014 12:02, Michael S. Tsirkin ha scritto: > > I think it is safe to assume that no OSPM will do those crazy things > > with OS-defined _OSI strings (it's quite plausible that they do it with > > feature _OSI strings). > > > > First, because IMHO it is completely insane. > > Insane, yes.

Re: [Qemu-devel] [PATCH] vmdk: Check for overhead when opening

2014-01-21 Thread Kevin Wolf
Am 21.01.2014 um 08:07 hat Fam Zheng geschrieben: > Report an error if file size is even smaller than metadata. > > Signed-off-by: Fam Zheng Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] RFC: ACPI, HPET._CRS, MacOSX vs. WinXP

2014-01-21 Thread Michael S. Tsirkin
On Mon, Jan 20, 2014 at 04:25:18PM -0500, Gabriel L. Somlo wrote: > On Mon, Jan 20, 2014 at 10:31:56PM +0200, Michael S. Tsirkin wrote: > > > And later: > > > > > > Device (HPET) { > > > ... > > > Method (_STA, 0, NotSerialized) { > > >

[Qemu-devel] [PATCH] drive-mirror: fix memory leak

2014-01-21 Thread Chentao (Boby)
In the function mirror_iteration() -> qemu_iovec_init(), it alloc memory for op->qiov.iov, when the write request call back, but in the function mirror_iteration_done(), it only free the op, not free the op->qiov.iov, so this cause memory leak. Signed-off-by: Zhang Min mailto:rudy.zhang...

Re: [Qemu-devel] [PATCH] migration: Fix free XBZRLE decoded_buf wrong

2014-01-21 Thread Gonglei (Arei)
> -Original Message- > From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: Saturday, January 18, 2014 11:00 PM > To: Gonglei (Arei) > Cc: quint...@redhat.com; anth...@codemonkey.ws; pbonz...@redhat.com; > chenliang (T); qemu-sta...@nongnu.org; Luonengjun; > qemu-devel@nongnu.org;

[Qemu-devel] [PATCH v2] migration:fix free XBZRLE decoded_buf wrong

2014-01-21 Thread Gonglei (Arei)
Hi, This is an update of my patch. Modifications in v2: * Removing excess check for g_free * The structure of XBZRLE is divided into two halves.One is for * src side, another is for dest side. Signed-off-by: chenliang --- arch_init.c | 23 ++- include/mig

Re: [Qemu-devel] RFC: ACPI, HPET._CRS, MacOSX vs. WinXP

2014-01-21 Thread Michael S. Tsirkin
On Tue, Jan 21, 2014 at 12:05:21PM +0100, Paolo Bonzini wrote: > Il 21/01/2014 12:02, Michael S. Tsirkin ha scritto: > > > I think it is safe to assume that no OSPM will do those crazy things > > > with OS-defined _OSI strings (it's quite plausible that they do it with > > > feature _OSI strings).

Re: [Qemu-devel] [PATCH v2] migration:fix free XBZRLE decoded_buf wrong

2014-01-21 Thread Orit Wasserman
On 01/21/2014 02:11 PM, Gonglei (Arei) wrote: Hi, This is an update of my patch. Modifications in v2: * Removing excess check for g_free * The structure of XBZRLE is divided into two halves.One is for * src side, another is for dest side. What is the benefit of splitting the structure? decode

[Qemu-devel] [PATCH] smbios: catch zero-length strings

2014-01-21 Thread Gerd Hoffmann
qemu may pass us zero-length strings for smbios fields, when starting qemu this way ... qemu -smbios type=1,version=,serial=test ... for example. Today we don't specifically handle them and simply append them to the string list. Therefore we get two string-terminating zeros in a row. R

Re: [Qemu-devel] [PATCH v2 0/2] spapr: fix H_SET_MODE

2014-01-21 Thread Alexander Graf
On 21.01.2014, at 11:05, Alexey Kardashevskiy wrote: > This is v2 of "spapr: reset @kvm_vcpu_dirty before starting CPU" Looks good to me :). > Does it make much sense to split "spapr-hcall: fix H_SET_MODE"? I don't understand? You mean split into subfunctions by resource? Yes, probably. > Pl

Re: [Qemu-devel] [PATCH v3 01/29] block: Move initialisation of BlockLimits to bdrv_refresh_limits()

2014-01-21 Thread Benoît Canet
Le Friday 17 Jan 2014 à 15:14:51 (+0100), Kevin Wolf a écrit : > This function separates filling the BlockLimits from bdrv_open(), which > allows it to call it from other operations which may change the limits > (e.g. modifications to the backing file chain or bdrv_reopen) > > Signed-off-by: Kevin

Re: [Qemu-devel] [PATCH v3 07/29] block: rename buffer_alignment to guest_block_size

2014-01-21 Thread Benoît Canet
Le Friday 17 Jan 2014 à 15:14:57 (+0100), Kevin Wolf a écrit : > From: Paolo Bonzini > > The alignment field is now set to the value that is promised to the > guest, rather than required by the host. The next patches will make > QEMU aware of the host-provided values, so make this clear. > > Th

Re: [Qemu-devel] [PATCH v2] migration:fix free XBZRLE decoded_buf wrong

2014-01-21 Thread Gonglei (Arei)
> -Original Message- > From: Orit Wasserman [mailto:owass...@redhat.com] > Sent: Tuesday, January 21, 2014 8:24 PM > To: Gonglei (Arei); qemu-devel@nongnu.org; qemu-sta...@nongnu.org; Peter > Maydell; anth...@codemonkey.ws; pbonz...@redhat.com > Cc: chenliang (T); Luonengjun; Huangweidong

Re: [Qemu-devel] [PATCH] spapr-pci: enable adding PHB via -device

2014-01-21 Thread Alexey Kardashevskiy
On 01/21/2014 09:19 PM, Andreas Färber wrote: > Am 21.01.2014 02:37, schrieb Alexey Kardashevskiy: >> On 01/21/2014 02:27 AM, Markus Armbruster wrote: >>> Alexey Kardashevskiy writes: >>> Recent changes introduced cannot_instantiate_with_device_add_yet and removed capability of adding ye

Re: [Qemu-devel] [PATCH v3 08/29] raw: Probe required direct I/O alignment

2014-01-21 Thread Benoît Canet
Le Friday 17 Jan 2014 à 15:14:58 (+0100), Kevin Wolf a écrit : > From: Paolo Bonzini > > Add a bs->request_alignment field that contains the required > offset/length alignment for I/O requests and fill it in the raw block > drivers. Use ioctls if possible, else see what alignment it takes for > O

Re: [Qemu-devel] [PATCH v2] migration:fix free XBZRLE decoded_buf wrong

2014-01-21 Thread Peter Maydell
On 21 January 2014 12:24, Orit Wasserman wrote: > On 01/21/2014 02:11 PM, Gonglei (Arei) wrote: >> >> Hi, >> >> This is an update of my patch. >> Modifications in v2: >> * Removing excess check for g_free >> * The structure of XBZRLE is divided into two halves.One is for >> * src side, another is

Re: [Qemu-devel] [PATCH v3 09/29] block: Introduce bdrv_aligned_preadv()

2014-01-21 Thread Benoît Canet
Le Friday 17 Jan 2014 à 15:14:59 (+0100), Kevin Wolf a écrit : > This separates the part of bdrv_co_do_readv() that needs to happen > before the request is modified to match the backend alignment, and a > part that needs to be executed afterwards and passes the request to the > BlockDriver. > > Si

Re: [Qemu-devel] [SeaBIOS] [PATCH] smbios: catch zero-length strings

2014-01-21 Thread Markus Armbruster
Gerd Hoffmann writes: > qemu may pass us zero-length strings for smbios fields, when starting > qemu this way ... > > qemu -smbios type=1,version=,serial=test > > ... for example. > > Today we don't specifically handle them and simply append them to the > string list. Therefore we get two

Re: [Qemu-devel] [PATCH v3 10/29] block: Introduce bdrv_co_do_preadv()

2014-01-21 Thread Benoît Canet
Le Friday 17 Jan 2014 à 15:15:00 (+0100), Kevin Wolf a écrit : > Similar to bdrv_pread(), which aligns byte-aligned request to 512 byte > sectors, bdrv_co_do_preadv() takes a byte-aligned request and aligns it > to the alignment specified in bs->request_alignment. > > Signed-off-by: Kevin Wolf >

Re: [Qemu-devel] [PATCH v3 08/29] raw: Probe required direct I/O alignment

2014-01-21 Thread Kevin Wolf
Am 21.01.2014 um 14:03 hat Benoît Canet geschrieben: > Le Friday 17 Jan 2014 à 15:14:58 (+0100), Kevin Wolf a écrit : > > From: Paolo Bonzini > > > > Add a bs->request_alignment field that contains the required > > offset/length alignment for I/O requests and fill it in the raw block > > drivers.

Re: [Qemu-devel] [PATCH v3 11/29] block: Introduce bdrv_aligned_pwritev()

2014-01-21 Thread Benoît Canet
Le Friday 17 Jan 2014 à 15:15:01 (+0100), Kevin Wolf a écrit : > This separates the part of bdrv_co_do_writev() that needs to happen > before the request is modified to match the backend alignment, and a > part that needs to be executed afterwards and passes the request to the > BlockDriver. > > S

Re: [Qemu-devel] [PATCH v6 0/8] Vhost and vhost-net support for userspace based backends

2014-01-21 Thread Antonios Motakis
On Wed, Jan 15, 2014 at 10:07 AM, Michael S. Tsirkin wrote: > On Tue, Jan 14, 2014 at 07:13:43PM +0100, Antonios Motakis wrote: >> >> >> >> On Tue, Jan 14, 2014 at 12:33 PM, Michael S. Tsirkin wrote: >> >> On Mon, Jan 13, 2014 at 03:25:11PM +0100, Antonios Motakis wrote: >> > In this patc

Re: [Qemu-devel] [PATCH v3 12/29] block: write: Handle COR dependency after I/O throttling

2014-01-21 Thread Benoît Canet
Le Friday 17 Jan 2014 à 15:15:02 (+0100), Kevin Wolf a écrit : > First waiting for all COR requests to complete and calling the > throttling function afterwards means that the request could be delayed > and we still need to wait for the COR request even if it was issued only > after the throttled w

Re: [Qemu-devel] [PATCH v6 0/8] Vhost and vhost-net support for userspace based backends

2014-01-21 Thread Antonios Motakis
Hello, On Wed, Jan 15, 2014 at 11:05 AM, Michael S. Tsirkin wrote: > > On Mon, Jan 13, 2014 at 03:25:11PM +0100, Antonios Motakis wrote: > > In this patch series we would like to introduce our approach for putting a > > virtio-net backend in an external userspace process. Our eventual target is

Re: [Qemu-devel] [PATCH v3 13/29] block: Introduce bdrv_co_do_pwritev()

2014-01-21 Thread Benoît Canet
Le Friday 17 Jan 2014 à 15:15:03 (+0100), Kevin Wolf a écrit : > This is going to become the bdrv_co_do_preadv() equivalent for writes. > In this patch, however, just a function taking byte offsets is created, > it doesn't align anything yet. > > Signed-off-by: Kevin Wolf > --- > block.c | 24 ++

Re: [Qemu-devel] KVM call agenda for 2014-01-21

2014-01-21 Thread Juan Quintela
Juan Quintela wrote: > Hi > > Please, send any topic that you are interested in covering. > > Thanks, Juan. As there are no topics, call gets cancelled. Happy hacking, Juan.

Re: [Qemu-devel] [PATCH v2] migration:fix free XBZRLE decoded_buf wrong

2014-01-21 Thread Eric Blake
On 01/21/2014 05:11 AM, Gonglei (Arei) wrote: > Hi, This greeting... > > This is an update of my patch. > Modifications in v2: ...and this mention of what you changed in v2,... > * Removing excess check for g_free > * The structure of XBZRLE is divided into two halves.One is for > * src side,

Re: [Qemu-devel] [PATCH v3 14/29] block: Switch BdrvTrackedRequest to byte granularity

2014-01-21 Thread Benoît Canet
Le Friday 17 Jan 2014 à 15:15:04 (+0100), Kevin Wolf a écrit : > Signed-off-by: Kevin Wolf > --- > block.c | 52 > +++ > block/backup.c| 7 ++- > include/block/block_int.h | 4 ++-- > 3 files changed, 42 insertions(+

[Qemu-devel] adaptation of emu

2014-01-21 Thread Herbei Dacian
hi All, would anyone be interested to adapt qemu to show some information visually as the operating system on top runs? The run must be completely emulated. of coursed I don't expect it for free. regards, dacian On Tuesday, 14 January 2014, 15:34, Herbei Dacian wrote: Hi Lluis, thank you

Re: [Qemu-devel] [PATCH] target-i386: enable x2apic by default on more recent CPU models

2014-01-21 Thread Eduardo Habkost
On Mon, Jan 20, 2014 at 11:13:11PM +0100, Andreas Färber wrote: > Am 20.01.2014 15:36, schrieb Eduardo Habkost: > > This enables x2apic on the following CPU models: Conroe, Penryn, > > Nehalem, Westmere, Opteron_G[12345]. > > > > Normally we try to keep the CPU model definitions as close as the re

Re: [Qemu-devel] [PATCH] target-i386: enable x2apic by default on more recent CPU models

2014-01-21 Thread Eduardo Habkost
On Tue, Jan 21, 2014 at 11:03:15AM +0100, Paolo Bonzini wrote: > Il 20/01/2014 23:13, Andreas Färber ha scritto: > > I don't like the argument that we can put arbitrary stuff in our model > > definitions and rely on TCG not having implemented it to make it > > correct. Is x2apic something that TCG

Re: [Qemu-devel] [PATCH V5 2/7] block: Allow the user to define "node-name" option.

2014-01-21 Thread Kevin Wolf
Am 12.12.2013 um 16:33 hat Benoît Canet geschrieben: > Signed-off-by: Benoit Canet > --- > block.c | 38 ++ > 1 file changed, 38 insertions(+) I think you should add an optional 'node-name' field to BlockdevOptionsBase in the QAPI schema, so that this can't on

Re: [Qemu-devel] [PATCH V5 4/7] qmp: Allow to change password on named block driver states.

2014-01-21 Thread Kevin Wolf
Am 12.12.2013 um 16:33 hat Benoît Canet geschrieben: > There was two candidate ways to implement named node manipulation: > > 1) > { 'command': 'block_passwd', 'data': {'*device': 'str', > '*node-name': 'str', 'password': 'str'} > } > > 2) > > { 'command': '

Re: [Qemu-devel] outlined TLB lookup on x86

2014-01-21 Thread Xin Tong
Hi I have found that adding a small (8-entry) fully associative victim TLB (http://en.wikipedia.org/wiki/Victim_Cache) before the refill path (page table walking) improves the performance of QEMU x86_64 system emulation mode significantly on the specint2006 benchmarks. This is primarily due to the

Re: [Qemu-devel] outlined TLB lookup on x86

2014-01-21 Thread Peter Maydell
On 21 January 2014 14:22, Xin Tong wrote: > I have found that adding a small (8-entry) fully associative victim > TLB (http://en.wikipedia.org/wiki/Victim_Cache) before the refill path > (page table walking) improves the performance of QEMU x86_64 system > emulation mode significantly on the speci

Re: [Qemu-devel] [PATCH V5 7/7] qmp: Allow to take external snapshots on bs graphs node.

2014-01-21 Thread Kevin Wolf
Am 12.12.2013 um 16:34 hat Benoît Canet geschrieben: > Signed-off-by: Benoit Canet > --- > blockdev.c | 55 --- > hmp.c| 4 +++- > qapi-schema.json | 13 ++--- > qmp-commands.hx | 11 ++- > 4 files changed, 71

Re: [Qemu-devel] [PATCH 1/3] qemu-progress: Drop unused include

2014-01-21 Thread Benoît Canet
Le Monday 20 Jan 2014 à 15:17:19 (+0100), Kevin Wolf a écrit : > Signed-off-by: Kevin Wolf > --- > util/qemu-progress.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/util/qemu-progress.c b/util/qemu-progress.c > index 9a3f96c..ad33fee 100644 > --- a/util/qemu-progress.c > +++ b/util/qe

Re: [Qemu-devel] [PATCH 2/3] qemu-progress: Fix progress printing on SIGUSR1

2014-01-21 Thread Benoît Canet
Le Monday 20 Jan 2014 à 15:17:20 (+0100), Kevin Wolf a écrit : > Since commit a7aae221 ('Switch SIG_IPI to SIGUSR1'), SIGUSR1 is blocked > during startup, breaking the progress report in tools. > > This patch reenables the signal when initialising a progress report. > > Signed-off-by: Kevin Wolf

Re: [Qemu-devel] [PATCH V5 0/7] Giving names to BlockDriverState graph nodes

2014-01-21 Thread Kevin Wolf
Am 12.12.2013 um 16:33 hat Benoît Canet geschrieben: > v5: > block empty node names [Kevin] > factorize setting of node-name option [Kevin] > NULL terminate node_name on removal [Kevin] > make query-named-block-nodes return BlockDeviceInfo structure [Eric] > Change some doc in q

Re: [Qemu-devel] [PATCH 3/3] Documentation: qemu-img: Mention SIGUSR1 progress report

2014-01-21 Thread Benoît Canet
Le Monday 20 Jan 2014 à 15:17:21 (+0100), Kevin Wolf a écrit : > Document the SIGUSR1 behaviour of qemu-img. Also, added compare to the > list of subcommands that support -p. > > Signed-off-by: Kevin Wolf > --- > qemu-img.texi | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff

[Qemu-devel] [PATCH 0/4] pc: make ACPI pcihp more reusable

2014-01-21 Thread Igor Mammedov
Reuses new pcihp code for handling legacy PCI hotplug in acpi/piix4_pm, which significantly reduces code duplication between piix4_pm and pcihp amd makes pcihp less dependend on piix4 specific details. It also allows cleaner rebase of generic hotplug refactoring, by not increasing code duplication

[Qemu-devel] [PATCH 1/4] hw:piix4:acpi: replace enable|disable_device() with oneliners

2014-01-21 Thread Igor Mammedov
enable_device() and disable_device() functions aren't reused anywere, so replace them with respective oneliners at call sites. Signed-off-by: Igor Mammedov --- hw/acpi/pcihp.c | 14 ++ 1 files changed, 2 insertions(+), 12 deletions(-) diff --git a/hw/acpi/pcihp.c b/hw/acpi/pcihp.c

[Qemu-devel] [PATCH 2/4] hw:piix4:acpi: make PCI hotplug mmio handlers indifferent to PCI_HOTPLUG_ADDR

2014-01-21 Thread Igor Mammedov
... removes dependency of mmio handler on PCI_HOTPLUG_ADDR. It will be needed in case of Q35 where base could be different. Signed-off-by: Igor Mammedov --- hw/acpi/pcihp.c | 24 1 files changed, 12 insertions(+), 12 deletions(-) diff --git a/hw/acpi/pcihp.c b/hw/acpi

[Qemu-devel] [PATCH 4/4] hw:piix4:acpi: reuse pcihp code for legacy PCI hotplug

2014-01-21 Thread Igor Mammedov
reduces acpi PCI hotplug code duplication by 150LOC, and makes pcihp less dependend on piix specific code. Signed-off-by: Igor Mammedov --- hw/acpi/pcihp.c | 10 +-- hw/acpi/piix4.c | 196 +-- include/hw/acpi/pcihp.h |8 ++- 3 fi

[Qemu-devel] [PATCH 3/4] hw:acpi:pcihp: assume root PCI bus if bus has no ACPI_PCIHP_PROP_BSEL property

2014-01-21 Thread Igor Mammedov
when running with machine types older than 1.7 (i.e. without ACPI builtin tables), PCI bus won't have ACPI_PCIHP_PROP_BSEL property set. Taking in account that acpi hotplug handler in 1.7 and older machines is called only for root PCI bus, to make pcihp code compatible with legacy machine types ass

Re: [Qemu-devel] [PATCH v2 0/4] X86/KVM: enable Intel MPX for KVM

2014-01-21 Thread Liu, Jinsong
Paolo Bonzini wrote: > Il 12/12/2013 12:09, Liu, Jinsong ha scritto: >> Paolo Bonzini wrote: >>> Il 12/12/2013 06:47, Liu, Jinsong ha scritto: Paolo Bonzini wrote: > Il 11/12/2013 09:31, Liu, Jinsong ha scritto: >> Paolo, comments for version 2? > > I think I commented that it

Re: [Qemu-devel] [PATCH v2] qemu 1.7.0 does not build on NetBSD

2014-01-21 Thread Richard Henderson
On 01/18/2014 05:59 AM, Peter Maydell wrote: > On 18 January 2014 13:47, Martin Husemann wrote: >> Do not rely on int8_t (and friends) not being preprocessor >> symbols (or symbols expanding to themselves). On NetBSD (for example) the >> glue(u, SDATA_TYPE) results in u__int8_t, which is undefi

Re: [Qemu-devel] [PATCH V5 0/7] Giving names to BlockDriverState graph nodes

2014-01-21 Thread Benoît Canet
Le Tuesday 21 Jan 2014 à 15:33:09 (+0100), Kevin Wolf a écrit : > Am 12.12.2013 um 16:33 hat Benoît Canet geschrieben: > > v5: > > block empty node names [Kevin] > > factorize setting of node-name option [Kevin] > > NULL terminate node_name on removal [Kevin] > > make query-named-bl

Re: [Qemu-devel] [PATCH v2] qemu 1.7.0 does not build on NetBSD

2014-01-21 Thread Andreas Färber
Am 18.01.2014 14:47, schrieb Martin Husemann: > Do not rely on int8_t (and friends) not being preprocessor > symbols (or symbols expanding to themselves). On NetBSD (for example) the > glue(u, SDATA_TYPE) results in u__int8_t, which is undefined. There is no way > to stop cpp expanding inner ma

Re: [Qemu-devel] [PATCH V5 0/7] Giving names to BlockDriverState graph nodes

2014-01-21 Thread Kevin Wolf
Am 21.01.2014 um 16:36 hat Benoît Canet geschrieben: > Le Tuesday 21 Jan 2014 à 15:33:09 (+0100), Kevin Wolf a écrit : > > Am 12.12.2013 um 16:33 hat Benoît Canet geschrieben: > > > v5: > > > block empty node names [Kevin] > > > factorize setting of node-name option [Kevin] > > > NULL t

Re: [Qemu-devel] [PATCH 0/3 v2] S390 SCLP improvements for CPU Hotplug

2014-01-21 Thread Christian Borntraeger
On 20/01/14 20:51, Jason J. Herne wrote: > From: "Jason J. Herne" > > Improvements to SCLP, mainly the Read SCP/CPU Info subcommands, to support > future cpu hotplug operations on the s390 target. > > Jason J. Herne (3): > s390-sclp: Define New SCLP Codes > s390-sclp: SCLP CPU Info > s390-

Re: [Qemu-devel] [PATCH 3/3 v2] s390-sclp: SCLP Event integration

2014-01-21 Thread Andreas Färber
Am 20.01.2014 20:51, schrieb Jason J. Herne: > From: "Jason J. Herne" > > Add an sclp event for "cpu was hot plugged". This allows Qemu to deliver an > SCLP interrupt to the guest stating that the requested cpu hotplug was > completed. > > Signed-off-by: Jason J. Herne Reviewed-by: Andreas Fä

Re: [Qemu-devel] [PATCH] target-i386: enable x2apic by default on more recent CPU models

2014-01-21 Thread Andreas Färber
Am 21.01.2014 11:03, schrieb Paolo Bonzini: > Il 20/01/2014 23:13, Andreas Färber ha scritto: >> I don't like the argument that we can put arbitrary stuff in our model >> definitions and rely on TCG not having implemented it to make it >> correct. Is x2apic something that TCG can never implement fo

Re: [Qemu-devel] [PATCH 2/3 v2] s390-sclp: SCLP CPU Info

2014-01-21 Thread Andreas Färber
Am 20.01.2014 20:51, schrieb Jason J. Herne: > From: "Jason J. Herne" > > Implement the CPU data in SCLP "Read SCP Info". And implement "Read CPU Info" > SCLP command. This data will be used by the guest to get information about hot > plugged cpus. > > Signed-off-by: Jason J. Herne Reviewed-b

Re: [Qemu-devel] [PATCH] target-i386: enable x2apic by default on more recent CPU models

2014-01-21 Thread Paolo Bonzini
Il 21/01/2014 16:51, Andreas Färber ha scritto: > We already do that for other bits (e.g. XSAVE/OSXSAVE), Please point me to the commit, a search for xsave did not come up with a commit changing such a thing - either it did not go through my queue or it slipped me through: Bugs are no excuse to

Re: [Qemu-devel] [PATCH] block: remove unnecessary code; image always r/w if snapshot=on

2014-01-21 Thread Eric Blake
On 01/21/2014 09:14 AM, Jeff Cody wrote: > Important note: this patch should only be applied after patch > "block: do not allow read-only=on and snapshot=on to be used together" > > Now that 'read-only=on' and 'snapshot=on' are not allowed together, > forcing open_flags to have BDRV_O_RDWR set is

[Qemu-devel] [PATCH] block: remove unnecessary code; image always r/w if snapshot=on

2014-01-21 Thread Jeff Cody
Important note: this patch should only be applied after patch "block: do not allow read-only=on and snapshot=on to be used together" Now that 'read-only=on' and 'snapshot=on' are not allowed together, forcing open_flags to have BDRV_O_RDWR set is redundant code, and can be removed. This is becau

[Qemu-devel] [PATCH] hda-audio: qom cleanups

2014-01-21 Thread Gerd Hoffmann
Add HDA_AUDIO type and macro, drop DO_UPCAST(). Had to add a abstract hda audio class as parent for all hda-* variants to make that fly. Killed some init code duplication while being at it. Cc: Andreas Färber Signed-off-by: Gerd Hoffmann --- hw/audio/hda-codec.c | 60 +

Re: [Qemu-devel] [PATCH] target-i386: enable x2apic by default on more recent CPU models

2014-01-21 Thread Eduardo Habkost
On Tue, Jan 21, 2014 at 04:51:42PM +0100, Andreas Färber wrote: > Am 21.01.2014 11:03, schrieb Paolo Bonzini: > > Il 20/01/2014 23:13, Andreas Färber ha scritto: > >> I don't like the argument that we can put arbitrary stuff in our model > >> definitions and rely on TCG not having implemented it to

[Qemu-devel] [PATCH v2 1/3] block: resize backing file image during offline commit, if necessary

2014-01-21 Thread Jeff Cody
Currently, if an image file is logically larger than its backing file, commiting it via 'qemu-img commit' will fail. For instance, if we have a base image with a virtual size 10G, and a snapshot image of size 20G, then committing the snapshot offline with 'qemu-img commit' will likely fail. This

[Qemu-devel] [PATCH v2 3/3] block: update block commit documentation regarding image truncation

2014-01-21 Thread Jeff Cody
This updates the documentation for commiting snapshot images. Specifically, this highlights what happens when the base image is either smaller or larger than the snapshot image being committed. In the case of the base image being smaller, it is resized to the larger size of the snapshot image. In

[Qemu-devel] [PATCH v2 0/3] block: commits of snapshots larger than backing files

2014-01-21 Thread Jeff Cody
Changes, v1->v2: Patch 1/3: Added error check for bdrv_getlength() return (Stefan) Patch 2/3: Restore flags in commit_active_start() on failures after the bdrv_reopen() (Fam) Patch 3/3: New patch, adds documentation clarification for the behavior of both offline commit, and

Re: [Qemu-devel] [PATCH] block: remove unnecessary code; image always r/w if snapshot=on

2014-01-21 Thread Kevin Wolf
Am 21.01.2014 um 17:17 hat Eric Blake geschrieben: > On 01/21/2014 09:14 AM, Jeff Cody wrote: > > Important note: this patch should only be applied after patch > > "block: do not allow read-only=on and snapshot=on to be used together" > > > > Now that 'read-only=on' and 'snapshot=on' are not allo

Re: [Qemu-devel] [PATCH v2 3/3] block: update block commit documentation regarding image truncation

2014-01-21 Thread Eric Blake
On 01/21/2014 09:31 AM, Jeff Cody wrote: > This updates the documentation for commiting snapshot images. > Specifically, this highlights what happens when the base image > is either smaller or larger than the snapshot image being committed. > > In the case of the base image being smaller, it is re

Re: [Qemu-devel] [PATCH] TCG: Fix I64-on-32bit-host temporaries

2014-01-21 Thread Richard Henderson
On 01/19/2014 07:53 AM, Alexander Graf wrote: > We have cache pools of temporaries that we can reuse later when they've > already been allocated before. > > These cache pools differenciate between the target TCG variable type they > contain. So we have one pool for I32 and one pool for I64 variabl

  1   2   >