Re: [Qemu-devel] [PATCH v2] vmdk: Allow vmdk_create to work with protocol

2013-12-20 Thread Stefan Hajnoczi
On Fri, Dec 20, 2013 at 09:48:48AM +0800, Fam Zheng wrote: > This improves vmdk_create to use bdrv_* functions to replace qemu_open > and other fd functions. The error handling are improved as well. One > difference is that bdrv_pwrite will round up buffer to sectors, so for > description file, an

Re: [Qemu-devel] [Bug 1262650] [NEW] Latest git version fails to compile in block/iscsi.o

2013-12-20 Thread Stefan Hajnoczi
On Thu, Dec 19, 2013 at 12:49:36PM -, Nigel Horne wrote: > Public bug reported: > > Git version f46e720a82ccdf1a521cf459448f3f96ed895d43 (and possibly > b91f93243bbe36dc436a64a662a9bbfb2362534a) fail to build under Linux > using gcc 4.8.1: > > block/iscsi.c: In function ‘iscsi_co_readv’: > bl

Re: [Qemu-devel] [PATCH] acpi unit-test: Create temporary disk file under /tmp

2013-12-20 Thread Michael Tokarev
20.12.2013 11:05, Fam Zheng wrote: > As other tests, the image file is created in /tmp other than current > dir. Thus there will not be an unignored file under tests for intree > build. > > Signed-off-by: Fam Zheng > --- > tests/acpi-test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Qemu-devel] [PATCH] qemu-iotests: drop duplicate virtio-blk initialization failure

2013-12-20 Thread Stefan Hajnoczi
On Thu, Dec 19, 2013 at 04:26:44PM +0100, Stefan Hajnoczi wrote: > Commit 75884afd5c6c42e523b08565e289dbe319e17ad9 ("virtio-blk: Convert to > QOM realize") dropped a duplicate error_report() call. Now we no longer > get the following error message twice: > > QEMU_PROG: -drive if=virtio: Device

[Qemu-devel] [PATCH] block/iscsi: return -ENOMEM if an async call fails immediately

2013-12-20 Thread Peter Lieven
if an async libiscsi call fails directly it can only be due to an out of memory condition. All other errors are returned through the callback. Signed-off-by: Peter Lieven --- block/iscsi.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/block/iscsi.c b/block/is

Re: [Qemu-devel] [PULL 25/32] Add xxsel

2013-12-20 Thread Alexander Graf
On 20.12.2013, at 07:54, Stefan Weil wrote: > Hi, > > this patch or one of the two following patches breaks compilation with > --enable-debug (lots of TCGv_i32 - TCGv_i64 mismatches). Bleks. Didn't we have buildbots for that? I guess I will have to add a compile run with --enable-debug to my

Re: [Qemu-devel] [PATCH] acpi unit-test: Create temporary disk file under /tmp

2013-12-20 Thread Fam Zheng
On 12/20/13 16:36, Michael Tokarev wrote: 20.12.2013 11:05, Fam Zheng wrote: As other tests, the image file is created in /tmp other than current dir. Thus there will not be an unignored file under tests for intree build. Signed-off-by: Fam Zheng --- tests/acpi-test.c | 2 +- 1 file changed

Re: [Qemu-devel] [PATCH v6 03/22] qdict: Add qdict_array_split()

2013-12-20 Thread Stefan Hajnoczi
On Thu, Dec 19, 2013 at 08:47:04PM +0100, Max Reitz wrote: > This function splits a QDict consisting of entries prefixed by > incrementally enumerated indices into a QList of QDicts. > > Signed-off-by: Max Reitz > Reviewed-by: Kevin Wolf > --- > include/qapi/qmp/qdict.h | 1 + > qobject/qdict.

Re: [Qemu-devel] [PATCH v6 04/22] qapi: extend qdict_flatten() for QLists

2013-12-20 Thread Stefan Hajnoczi
On Thu, Dec 19, 2013 at 08:47:05PM +0100, Max Reitz wrote: > Reversing qdict_array_split(), qdict_flatten() should flatten QLists as > well by interpreting them as QDicts where every entry's key is its > index. > > This allows bringing QDicts with QLists from QMP commands to the same > form as the

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-20 Thread Peter Lieven
On 17.12.2013 17:47, Stefan Hajnoczi wrote: On Tue, Dec 17, 2013 at 10:15:25AM +0100, Peter Lieven wrote: This patch adds native support for accessing images on NFS shares without the requirement to actually mount the entire NFS share on the host. NFS Images can simply be specified by an url of

[Qemu-devel] [PATCH 0/2] ppc-e500: Adding pci-pin to irq callback and some cleanup

2013-12-20 Thread Bharat Bhushan
First patch is doing some cleanup and second patch adds the PCI-PIN (INT[A-D]) to its interrupt number mapping callback. This is required to support pci device passthrough using VFIO. Bharat Bhushan (2): ppc-e500: some pci related cleanup ppc-e500: implement PCI INTx routing hw/pci-host/ppce

[Qemu-devel] [PATCH 1/2] ppc-e500: some pci related cleanup

2013-12-20 Thread Bharat Bhushan
- Use PCI_NUM_PINS rather than hardcoding - use "pin" wherever possible Signed-off-by: Bharat Bhushan --- hw/pci-host/ppce500.c | 16 hw/ppc/e500.c | 12 +++- 2 files changed, 15 insertions(+), 13 deletions(-) diff --git a/hw/pci-host/ppce500.c b/hw/pci-ho

[Qemu-devel] [Bug 1042388] Re: qemu: Unsupported syscall: 257 (timer_create)

2013-12-20 Thread Erik de Castro Lopo
If someone wants to fix what's currently in Ubtuntu they should make a package which includes those two patches. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1042388 Title: qemu: Unsupported sysca

[Qemu-devel] [Bug 1042388] Re: qemu: Unsupported syscall: 257 (timer_create)

2013-12-20 Thread Erik de Castro Lopo
Its currently in git HEAD. It will be in the next full release which I think is 2.0. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1042388 Title: qemu: Unsupported syscall: 257 (timer_create) Stat

Re: [Qemu-devel] [PATCH 11/21] target-arm: Update generic cpreg code for AArch64

2013-12-20 Thread Peter Maydell
On 20 December 2013 04:24, Peter Crosthwaite wrote: > On Thu, Dec 19, 2013 at 7:11 PM, Peter Maydell > wrote: >> Almost all the shared registers appear as 32 bit on the AArch32 >> side and 64 bits on the AArch64 side. > > Really? Reading v8, there are many 32 bit regs with these op0 AArch64 > en

[Qemu-devel] [PATCH] PPC: Fix compilation with TCG debug

2013-12-20 Thread Alexander Graf
The recent VSX patches broken compilation of QEMU when configurated with --enable-debug, as it was treating "target long" TCG variables as "i64" which is not true for 32bit targets. This patch fixes all the places that the compiler has found to use the correct variable type and if necessary manual

[Qemu-devel] [PATCH 2/2] ppc-e500: implement PCI INTx routing

2013-12-20 Thread Bharat Bhushan
This patch adds pci pin to irq_num routing callback. This callback is called from pci_device_route_intx_to_irq to find which pci device maps to which irq. This is used for pci-device passthrough using vfio. Also without this patch we gets below warning " PCI: Bug - unimplemented PCI INTx routi

Re: [Qemu-devel] [PATCH] target-arm: use c13_context field for CONTEXTIDR

2013-12-20 Thread Peter Maydell
On 20 December 2013 06:33, Sergey Fedorov wrote: > Use c13_context field instead of c13_fcse for CONTEXTIDR register > definition. > > Signed-off-by: Sergey Fedorov > Reviewed-by: Peter Crosthwaite > --- > target-arm/helper.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -

Re: [Qemu-devel] [RFC PATCH v3 1/6] block: introduce prealloc_mode

2013-12-20 Thread Stefan Hajnoczi
On Thu, Dec 19, 2013 at 10:27:36AM +0800, Hu Tao wrote: > diff --git a/include/block/block.h b/include/block/block.h > index 36efaea..3732f25 100644 > --- a/include/block/block.h > +++ b/include/block/block.h > @@ -527,4 +527,10 @@ int bdrv_debug_remove_breakpoint(BlockDriverState *bs, > const cha

Re: [Qemu-devel] [RFC PATCH v3 2/6] block: add BlockDriver.bdrv_preallocate.

2013-12-20 Thread Stefan Hajnoczi
On Thu, Dec 19, 2013 at 10:27:37AM +0800, Hu Tao wrote: > diff --git a/block.c b/block.c > index 64e7d22..b901587 100644 > --- a/block.c > +++ b/block.c > @@ -3216,6 +3216,19 @@ bool bdrv_can_write_zeroes_with_unmap(BlockDriverState > *bs) > return false; > } > > +int bdrv_preallocate(Bloc

Re: [Qemu-devel] [RFC PATCH v3 3/6] block/raw-posix: implement bdrv_preallocate

2013-12-20 Thread Stefan Hajnoczi
On Thu, Dec 19, 2013 at 10:27:38AM +0800, Hu Tao wrote: > +static int raw_preallocate2(int fd, int64_t offset, int64_t length) > +{ > +int ret = -1; > + > +ret = fallocate(fd, 0, offset, length); > + > +/* fallback to posix_fallocate() if fallocate() is not supported */ > +if (ret <

Re: [Qemu-devel] [PATCH v2] vmdk: Allow vmdk_create to work with protocol

2013-12-20 Thread Peter Lieven
On 20.12.2013 02:48, Fam Zheng wrote: This improves vmdk_create to use bdrv_* functions to replace qemu_open and other fd functions. The error handling are improved as well. One difference is that bdrv_pwrite will round up buffer to sectors, so for description file, an extra bdrv_truncate is used

Re: [Qemu-devel] [RFC PATCH v3 5/6] qcow2: implement bdrv_preallocate

2013-12-20 Thread Stefan Hajnoczi
On Thu, Dec 19, 2013 at 10:27:40AM +0800, Hu Tao wrote: > Signed-off-by: Hu Tao > --- > block/qcow2.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/block/qcow2.c b/block/qcow2.c > index 32cb39f..487a595 100644 > --- a/block/qcow2.c > +++ b/block/qcow2.c > @@ -2188,6 +2188,12 @@

Re: [Qemu-devel] [RFC PATCH v3 6/6] qcow2: Add full image preallocation option

2013-12-20 Thread Stefan Hajnoczi
On Thu, Dec 19, 2013 at 10:27:41AM +0800, Hu Tao wrote: > -static int preallocate(BlockDriverState *bs) > +static int preallocate(BlockDriverState *bs, enum prealloc_mode mode) > { > uint64_t nb_sectors; > uint64_t offset; > @@ -1395,9 +1395,19 @@ static int preallocate(BlockDriverState

Re: [Qemu-devel] [RFC PATCH v3 0/6] qemu-img: add preallocation=full

2013-12-20 Thread Stefan Hajnoczi
On Thu, Dec 19, 2013 at 10:27:35AM +0800, Hu Tao wrote: > This series implements full image preallocation to create a non-sparse image > file at creation time, both for raw and qcow2 format. The purpose is to avoid > performance deterioration of the guest cause by sparse image. I'm not sure the ne

Re: [Qemu-devel] [PATCH 2/2] ppc-e500: implement PCI INTx routing

2013-12-20 Thread Alexander Graf
On 20.12.2013, at 10:42, Bharat Bhushan wrote: > This patch adds pci pin to irq_num routing callback. > This callback is called from pci_device_route_intx_to_irq to find which pci > device > maps to which irq. This is used for pci-device passthrough using vfio. > > Also without this patch we g

Re: [Qemu-devel] [PATCH 0/5] targe-ppc: 970/p5+/p7/p7+/p8 SPRs cleanup

2013-12-20 Thread Alexander Graf
On 20.12.2013, at 07:41, Alexey Kardashevskiy wrote: > This removes not supported SPR from CPU classes. Thanks a lot! Applied all to ppc-next. Alex

Re: [Qemu-devel] [PATCH -V7 3/3] target-ppc: Fix page table lookup with kvm enabled

2013-12-20 Thread Alexander Graf
On 20.12.2013, at 06:24, Aneesh Kumar K.V wrote: > Alexander Graf writes: > >> On 19.12.2013, at 07:55, Aneesh Kumar K.V >> wrote: >> >>> Alexander Graf writes: >>> On 07.11.2013, at 15:31, Aneesh Kumar K.V wrote: > From: "Aneesh Kumar K.V" > > With kvm en

Re: [Qemu-devel] [PATCH V4] kvm: Add a new machine property kvm-type

2013-12-20 Thread Alexander Graf
On 19.12.2013, at 17:04, Aneesh Kumar K.V wrote: > From: "Aneesh Kumar K.V" > > Targets like ppc64 support different typed of KVM, one which use > hypervisor mode and the other which doesn't. Add a new machine > property kvm-type that helps in selecting the respective ones > We also add a new

[Qemu-devel] [RFC] test: QOM interface casting

2013-12-20 Thread Igor Mammedov
--- tests/Makefile |3 + tests/check-qom-interface.c | 102 +++ 2 files changed, 105 insertions(+), 0 deletions(-) create mode 100644 tests/check-qom-interface.c diff --git a/tests/Makefile b/tests/Makefile index 379cdd9..dfb6cce 100644 -

Re: [Qemu-devel] [PATCH] qdev-monitor: Improve error message for -device nonexistant

2013-12-20 Thread Andreas Färber
Am 19.12.2013 15:30, schrieb arm...@redhat.com: > From: Markus Armbruster > > Once upon a time, the error message was: > > qemu: -device nonexistant: "Device "nonexistant" not found. Try -device > '?' for a list. > > But progress marches on, and conversion to QError (commit 0204276) > cha

Re: [Qemu-devel] [PATCH v3 4/4] ioapic: QOM'ify ioapic

2013-12-20 Thread Andreas Färber
Am 19.12.2013 15:20, schrieb Paolo Bonzini: > Il 18/12/2013 19:03, Andreas Färber ha scritto: @@ -61,7 +69,6 @@ static void ioapic_common_realize(DeviceState *dev, Error **errp) { IOAPICCommonState *s = IOAPIC_COMMON(dev); IOAPICCommonClass *info; -stat

Re: [Qemu-devel] [PATCH v3] Fix QEMU build on OpenBSD on x86 archs

2013-12-20 Thread Brad Smith
On 14/12/13 11:27 PM, Brad Smith wrote: On 10/12/13 7:49 PM, Brad Smith wrote: This resolves the build issue with building the ROMs on OpenBSD on x86 archs. As of OpenBSD 5.3 the compiler builds PIE binaries by default and thus the whole OS/packages and so forth. The ROMs need to have PIE disabl

Re: [Qemu-devel] [PATCH 2/2] ppc-e500: implement PCI INTx routing

2013-12-20 Thread bharat.bhus...@freescale.com
> -Original Message- > From: Alexander Graf [mailto:ag...@suse.de] > Sent: Friday, December 20, 2013 4:01 PM > To: Bhushan Bharat-R65777 > Cc: Michael S. Tsirkin; Wood Scott-B07421; qemu-ppc; QEMU Developers; Bhushan > Bharat-R65777 > Subject: Re: [PATCH 2/2] ppc-e500: implement PCI INTx

Re: [Qemu-devel] [RFC] test: QOM interface casting

2013-12-20 Thread Peter Crosthwaite
On Fri, Dec 20, 2013 at 9:08 PM, Igor Mammedov wrote: > --- > tests/Makefile |3 + > tests/check-qom-interface.c | 102 > +++ > 2 files changed, 105 insertions(+), 0 deletions(-) > create mode 100644 tests/check-qom-interface.c > > diff

Re: [Qemu-devel] [PATCH 2/2] qom: detect bad reentrance during object_class_foreach

2013-12-20 Thread Andreas Färber
Am 19.12.2013 12:38, schrieb Alexey Kardashevskiy: > On 12/16/2013 08:23 AM, Andreas Färber wrote: >> Am 04.12.2013 06:51, schrieb Peter Crosthwaite: >>> On Wed, Dec 4, 2013 at 1:42 AM, Paolo Bonzini wrote: From: Hervé Poussineau We should not modify the type hash table while it is

[Qemu-devel] [PATCHv3] block: add native support for NFS

2013-12-20 Thread Peter Lieven
This patch adds native support for accessing images on NFS shares without the requirement to actually mount the entire NFS share on the host. NFS Images can simply be specified by an url of the form: nfs: For example: qemu-img create -f qcow2 nfs://10.0.0.1/qemu-images/test.qcow2 You need li

Re: [Qemu-devel] [PATCH] target-arm: use c13_context field for CONTEXTIDR

2013-12-20 Thread Peter Crosthwaite
On Fri, Dec 20, 2013 at 8:04 PM, Peter Maydell wrote: > On 20 December 2013 06:33, Sergey Fedorov wrote: >> Use c13_context field instead of c13_fcse for CONTEXTIDR register >> definition. >> >> Signed-off-by: Sergey Fedorov >> Reviewed-by: Peter Crosthwaite >> --- >> target-arm/helper.c |

Re: [Qemu-devel] [PATCH 2/2] qom: detect bad reentrance during object_class_foreach

2013-12-20 Thread Alexey Kardashevskiy
On 12/20/2013 10:29 PM, Andreas Färber wrote: > Am 19.12.2013 12:38, schrieb Alexey Kardashevskiy: >> On 12/16/2013 08:23 AM, Andreas Färber wrote: >>> Am 04.12.2013 06:51, schrieb Peter Crosthwaite: On Wed, Dec 4, 2013 at 1:42 AM, Paolo Bonzini wrote: > From: Hervé Poussineau >

Re: [Qemu-devel] [PATCH v2 2/2] full introspection support for QMP

2013-12-20 Thread Amos Kong
(resend without big attachment) Hello Eric, other We had "command, enumeration, type, unionobj" in Eric suggested DataObject union, it's helpful for us to provide meaningful metadata in the output. but there still exists some problem. We should describe some arbitrary data struct, I would like t

Re: [Qemu-devel] [RFC] test: QOM interface casting

2013-12-20 Thread Peter Maydell
On 20 December 2013 11:08, Igor Mammedov wrote: > --- > tests/Makefile |3 + > tests/check-qom-interface.c | 102 > +++ > 2 files changed, 105 insertions(+), 0 deletions(-) > create mode 100644 tests/check-qom-interface.c > > diff --git

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-20 Thread Stefan Hajnoczi
On Fri, Dec 20, 2013 at 10:48:41AM +0100, Peter Lieven wrote: > On 17.12.2013 17:47, Stefan Hajnoczi wrote: > >On Tue, Dec 17, 2013 at 10:15:25AM +0100, Peter Lieven wrote: > >>This patch adds native support for accessing images on NFS shares without > >>the requirement to actually mount the entire

Re: [Qemu-devel] [RFC PATCH v3 1/6] block: introduce prealloc_mode

2013-12-20 Thread Eric Blake
On 12/18/2013 07:27 PM, Hu Tao wrote: > This patch prepares for the subsequent patches. > > Signed-off-by: Hu Tao > --- > block/qcow2.c | 6 +++--- > include/block/block.h | 6 ++ > 2 files changed, 9 insertions(+), 3 deletions(-) > > +++ b/include/block/block.h > @@ -527,4 +527,10

Re: [Qemu-devel] [RFC] test: QOM interface casting

2013-12-20 Thread Andreas Färber
Hi, Am 20.12.2013 12:08, schrieb Igor Mammedov: > --- > tests/Makefile |3 + > tests/check-qom-interface.c | 102 > +++ > 2 files changed, 105 insertions(+), 0 deletions(-) > create mode 100644 tests/check-qom-interface.c Apart from the

Re: [Qemu-devel] [PATCH 03/27] pc: add 'etc/reserved-memory-end' fw_cfg interface for SeaBIOS

2013-12-20 Thread Igor Mammedov
On Thu, 19 Dec 2013 16:35:05 +0200 "Michael S. Tsirkin" wrote: > On Thu, Nov 21, 2013 at 03:38:24AM +0100, Igor Mammedov wrote: > > 'etc/reserved-memory-end' will allow QEMU to tell BIOS where PCI > > BARs mapping could safely start in high memory. > > > > Allowing BIOS to start mapping 64-bit P

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-20 Thread Peter Lieven
On 20.12.2013 13:19, Stefan Hajnoczi wrote: On Fri, Dec 20, 2013 at 10:48:41AM +0100, Peter Lieven wrote: On 17.12.2013 17:47, Stefan Hajnoczi wrote: On Tue, Dec 17, 2013 at 10:15:25AM +0100, Peter Lieven wrote: This patch adds native support for accessing images on NFS shares without the requ

Re: [Qemu-devel] [RFC PATCH v3 0/6] qemu-img: add preallocation=full

2013-12-20 Thread Eric Blake
On 12/20/2013 03:30 AM, Stefan Hajnoczi wrote: > On Thu, Dec 19, 2013 at 10:27:35AM +0800, Hu Tao wrote: >> This series implements full image preallocation to create a non-sparse image >> file at creation time, both for raw and qcow2 format. The purpose is to avoid >> performance deterioration of t

Re: [Qemu-devel] [PATCHv3] block: add native support for NFS

2013-12-20 Thread Stefan Hajnoczi
On Fri, Dec 20, 2013 at 12:31:57PM +0100, Peter Lieven wrote: > - DID NOT add full implementation of bdrv_get_allocated_file_size because > we are not in a coroutine context and I cannot do an async call here. > I could do a sync call if there would be a guarantee that no requests > are in fl

Re: [Qemu-devel] [PATCH 07/21] target-arm: A64: add support for 3 src data proc insns

2013-12-20 Thread Peter Maydell
On 19 December 2013 19:29, Richard Henderson wrote: > On 12/17/2013 07:12 AM, Peter Maydell wrote: >> +tcg_gen_mul_i64(tcg_tmp, tcg_op1, tcg_op2); >> +if (is_sub) { >> +tcg_gen_sub_i64(cpu_reg(s, rd), cpu_reg(s, ra), tcg_tmp); >> +} else { >> +tcg_gen_add_i64(cpu_reg(s,

Re: [Qemu-devel] [RFC] test: QOM interface casting

2013-12-20 Thread Igor Mammedov
On Fri, 20 Dec 2013 13:47:32 +0100 Andreas Färber wrote: > Hi, > > Am 20.12.2013 12:08, schrieb Igor Mammedov: > > --- > > tests/Makefile |3 + > > tests/check-qom-interface.c | 102 > > +++ > > 2 files changed, 105 insertions(+), 0 del

Re: [Qemu-devel] [PATCHv3] block: add native support for NFS

2013-12-20 Thread Peter Lieven
On 20.12.2013 14:07, Stefan Hajnoczi wrote: On Fri, Dec 20, 2013 at 12:31:57PM +0100, Peter Lieven wrote: - DID NOT add full implementation of bdrv_get_allocated_file_size because we are not in a coroutine context and I cannot do an async call here. I could do a sync call if there would be

Re: [Qemu-devel] [PATCH 13/21] target-arm: A64: Implement MRS/MSR/SYS/SYSL

2013-12-20 Thread Peter Maydell
On 19 December 2013 20:30, Richard Henderson wrote: > On 12/17/2013 07:12 AM, Peter Maydell wrote: >> +/* Force a TB lookup after an instruction that changes the CPU state */ >> +static inline void gen_lookup_tb(DisasContext *s) >> +{ >> +gen_a64_set_pc_im(s->pc); >> +s->is_jmp = DISAS_UPD

[Qemu-devel] [PATCH] test: QOM interface casting

2013-12-20 Thread Igor Mammedov
Add basic regression testing for QOM Interface usage. Signed-off-by: Igor Mammedov --- v2: - Peter Crosthwaite * s/Parent/parent_obj/ * s/parent/parent_class/ - Peter Maydell * s/interfacei/interface/ * tests/Makefile split too long line - Andreas Färber * consolidate QOM cor

Re: [Qemu-devel] [PULL 00/13] QMP queue

2013-12-20 Thread Luiz Capitulino
On Fri, 20 Dec 2013 14:00:21 +1000 Peter Crosthwaite wrote: > On Fri, Dec 20, 2013 at 10:49 AM, Anthony Liguori > wrote: > > On Wed, Dec 18, 2013 at 8:59 AM, Luiz Capitulino > > wrote: > >> The following changes since commit > >> e157b8fdd412d48eacfbb8c67d3d58780154faa3: > >> > >> Merge re

Re: [Qemu-devel] [PATCH] test: QOM interface casting

2013-12-20 Thread Peter Maydell
On 20 December 2013 13:26, Igor Mammedov wrote: > Add basic regression testing for QOM Interface usage. > > +/* > + * OQM interface test. Still says "OQM" not "QOM"... thanks -- PMM

Re: [Qemu-devel] [PULL 11/13] monitor: add object-add (QMP) and object_add (HMP) command

2013-12-20 Thread Luiz Capitulino
On Fri, 20 Dec 2013 12:15:53 +1000 Peter Crosthwaite wrote: > On Thu, Dec 19, 2013 at 3:00 AM, Luiz Capitulino > wrote: > > From: Paolo Bonzini > > > > Add two commands that are the monitor counterparts of -object. The commands > > have the same Visitor-based implementation, but use different

Re: [Qemu-devel] [PATCH V7 2/6] qcow2: add error message in qcow2_write_snapshots()

2013-12-20 Thread Stefan Hajnoczi
On Thu, Dec 05, 2013 at 08:02:48PM +0800, Wenchao Xia wrote: > @@ -227,24 +236,40 @@ static int qcow2_write_snapshots(BlockDriverState *bs) > > ret = bdrv_pwrite(bs->file, offset, &h, sizeof(h)); > if (ret < 0) { > +error_setg_errno(errp, -ret, > +

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-20 Thread Stefan Hajnoczi
On Fri, Dec 20, 2013 at 1:53 PM, Peter Lieven wrote: > On 20.12.2013 13:19, Stefan Hajnoczi wrote: >> >> On Fri, Dec 20, 2013 at 10:48:41AM +0100, Peter Lieven wrote: >>> >>> On 17.12.2013 17:47, Stefan Hajnoczi wrote: On Tue, Dec 17, 2013 at 10:15:25AM +0100, Peter Lieven wrote: > +

Re: [Qemu-devel] [PATCH] test: QOM interface casting

2013-12-20 Thread Andreas Färber
Am 20.12.2013 14:26, schrieb Igor Mammedov: > Add basic regression testing for QOM Interface usage. > > Signed-off-by: Igor Mammedov > --- > v2: > - Peter Crosthwaite >* s/Parent/parent_obj/ >* s/parent/parent_class/ > - Peter Maydell >* s/interfacei/interface/ >* tests/Makefi

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-20 Thread Peter Lieven
On 20.12.2013 14:57, Stefan Hajnoczi wrote: On Fri, Dec 20, 2013 at 1:53 PM, Peter Lieven wrote: On 20.12.2013 13:19, Stefan Hajnoczi wrote: On Fri, Dec 20, 2013 at 10:48:41AM +0100, Peter Lieven wrote: On 17.12.2013 17:47, Stefan Hajnoczi wrote: On Tue, Dec 17, 2013 at 10:15:25AM +0100, Pet

Re: [Qemu-devel] [PATCH] test: QOM interface casting

2013-12-20 Thread Igor Mammedov
On Fri, 20 Dec 2013 14:58:07 +0100 Andreas Färber wrote: > Am 20.12.2013 14:26, schrieb Igor Mammedov: > > Add basic regression testing for QOM Interface usage. > > > > Signed-off-by: Igor Mammedov > > --- > > v2: > > - Peter Crosthwaite > >* s/Parent/parent_obj/ > >* s/parent/parent_

Re: [Qemu-devel] [PATCH 07/21] target-arm: A64: add support for 3 src data proc insns

2013-12-20 Thread Richard Henderson
On 12/20/2013 05:18 AM, Peter Maydell wrote: > On 19 December 2013 19:29, Richard Henderson wrote: >> On 12/17/2013 07:12 AM, Peter Maydell wrote: >>> +tcg_gen_mul_i64(tcg_tmp, tcg_op1, tcg_op2); >>> +if (is_sub) { >>> +tcg_gen_sub_i64(cpu_reg(s, rd), cpu_reg(s, ra), tcg_tmp); >>>

[Qemu-devel] [PATCH v4 2/7] Decouple vhost from kernel interface

2013-12-20 Thread Mian M. Hamayun
From: Antonios Motakis We introduce the concept of vhost-backend, which can be either vhost-kernel or vhost-user. The existing vhost interface to the kernel is abstracted behind the vhost-kernel backend. We replace all direct ioctls to the kernel with a vhost_call to the backend. vhost dev->cont

[Qemu-devel] [PATCH v4 0/7] Vhost and vhost-net support for userspace based backends

2013-12-20 Thread Mian M. Hamayun
From: "Mian M. Hamayun" In this patch series we would like to introduce our approach for putting a virtio-net backend in an external userspace process. Our eventual target is to run the network backend in the Snabbswitch ethernet switch, while receiving traffic from a guest inside QEMU/KVM which

[Qemu-devel] [PATCH v4 6/7] Add new vhost-user netdev backend

2013-12-20 Thread Mian M. Hamayun
From: Antonios Motakis Add a new QEMU netdev backend that is intended to invoke vhost_net with the vhost-user backend. Also decouple virtio-net from the tap backend. Signed-off-by: Antonios Motakis Signed-off-by: Nikolay Nikolaev --- hmp-commands.hx | 4 +- hw/net/vhost_net.c

[Qemu-devel] [PATCH v4 3/7] Add vhost-user skeleton

2013-12-20 Thread Mian M. Hamayun
From: Antonios Motakis Add empty vhost_call, init and cleanup for the vhost-user backend. Signed-off-by: Antonios Motakis Signed-off-by: Nikolay Nikolaev --- hw/net/vhost_net.c| 57 ++- hw/virtio/vhost-backend.c | 35

[Qemu-devel] [PATCH v4 1/7] Convert -mem-path to QemuOpts and add prealloc, share and unlink properties

2013-12-20 Thread Mian M. Hamayun
From: Antonios Motakis Extend -mem-path with additional properties: - prealloc=on|off - default off, same as -mem-prealloc - share=on|off - default off, memory is mmapped with MAP_SHARED flag - unlink=on|off - default on, inlink the file after openinng it Signed-off-by: Antonios Motakis Sig

[Qemu-devel] [PATCH v4 5/7] Add vhost-user calls implementation

2013-12-20 Thread Mian M. Hamayun
From: Antonios Motakis Each ioctl request of vhost-kernel has a vhost-user message equivalent, which is sent over the control socket. The general approach is to copy the data from the supplied argument pointer to a designated field in the message. If a file descriptor is to be passed, it should

[Qemu-devel] [PATCH v4 4/7] Add domain socket communication for vhost-user backend

2013-12-20 Thread Mian M. Hamayun
From: Antonios Motakis Add structures for passing vhost-user messages over a unix domain socket. This is the equivalent to the existing vhost-kernel ioctls. Connect to the named unix domain socket. The system call sendmsg is used for communication. To be able to pass file descriptors between pro

[Qemu-devel] [PATCH v4 7/7] Add vhost-user reconnection

2013-12-20 Thread Mian M. Hamayun
From: Antonios Motakis At runtime vhost-user netdev will detect if the vhost backend is up or down. Upon disconnection it will set link_down accordingly and notify virtio-net. Signed-off-by: Antonios Motakis Signed-off-by: Nikolay Nikolaev --- hw/net/vhost_net.c| 16 ++

Re: [Qemu-devel] [RFC PATCH 18/21] target-arm: switch banked CP registers

2013-12-20 Thread Fedorov Sergey
On 12/19/2013 03:38 PM, Peter Maydell wrote: On 19 December 2013 07:27, Fedorov Sergey wrote: Yes, this banking scheme makes state changing events quite heavy. But maintaining the active copies allows to keep translation table walking code untouched. I think there is a trade-off between state

Re: [Qemu-devel] [PATCH 07/21] target-arm: A64: add support for 3 src data proc insns

2013-12-20 Thread Peter Maydell
On 20 December 2013 14:10, Richard Henderson wrote: > On 12/20/2013 05:18 AM, Peter Maydell wrote: >> On 19 December 2013 19:29, Richard Henderson wrote: >>> On 12/17/2013 07:12 AM, Peter Maydell wrote: +tcg_gen_mul_i64(tcg_tmp, tcg_op1, tcg_op2); +if (is_sub) { +tc

[Qemu-devel] [Bug 1042388] Re: qemu: Unsupported syscall: 257 (timer_create)

2013-12-20 Thread LocutusOfBorg
mmm I don't know, I built it in my ppa, with your patch. Upgraded the system https://code.launchpad.net/~costamagnagianfranco/+archive/firefox/+packages Preparing to replace qemu-user 1.5.0+dfsg-3ubuntu5.2 (using .../qemu-user_1.7.0+dfsg-2ubuntu4~saucy1_amd64.deb) ... Unpacking replacement qemu-us

Re: [Qemu-devel] [PATCH V7 4/6] qcow2: cancel the modification on fail in qcow2_snapshot_create()

2013-12-20 Thread Stefan Hajnoczi
On Thu, Dec 05, 2013 at 08:02:50PM +0800, Wenchao Xia wrote: > +restore_refcount: > +if (qcow2_update_snapshot_refcount(bs, s->l1_table_offset, s->l1_size, > -1) > +< 0 && errp) { > +/* Nothing can be done now, need image check later */ > +error_setg(&err, "%s\nqcow2: E

Re: [Qemu-devel] [PATCH V7 1/6] snapshot: add parameter *errp in snapshot create

2013-12-20 Thread Stefan Hajnoczi
On Thu, Dec 05, 2013 at 08:02:47PM +0800, Wenchao Xia wrote: > @@ -366,7 +368,8 @@ int qcow2_snapshot_create(BlockDriverState *bs, > QEMUSnapshotInfo *sn_info) > > /* Check that the ID is unique */ > if (find_snapshot_by_id_and_name(bs, sn_info->id_str, NULL) >= 0) { > -return

Re: [Qemu-devel] [PATCH V7 0/6] qcow2: rollback the modification on fail in snapshot creation

2013-12-20 Thread Stefan Hajnoczi
On Thu, Dec 05, 2013 at 08:02:46PM +0800, Wenchao Xia wrote: > V2: > 1: all fail case will goto fail section. > 2: add the goto code. > > v3: > Address Stefan's comments: > 2: don't goto fail after allocation failure. > 3: use sn->l1size correctly in qcow2_free_cluster(). > 4-7: add te

Re: [Qemu-devel] [RFC PATCH 18/21] target-arm: switch banked CP registers

2013-12-20 Thread Peter Maydell
On 20 December 2013 14:12, Fedorov Sergey wrote: > I've briefly looked at the v8 ARM ARM. As I can see there is no banked > system control registers in AArch64. Seems the concept is changed to provide > separate registers for each meaningful execution level. Please, correct me > if I am wrong. Ye

Re: [Qemu-devel] [RFC PATCH 18/21] target-arm: switch banked CP registers

2013-12-20 Thread Fedorov Sergey
On 12/20/2013 06:33 PM, Peter Maydell wrote: > On 20 December 2013 14:12, Fedorov Sergey wrote: >> I've briefly looked at the v8 ARM ARM. As I can see there is no banked >> system control registers in AArch64. Seems the concept is changed to provide >> separate registers for each meaningful execu

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-20 Thread Stefan Hajnoczi
On Fri, Dec 20, 2013 at 3:07 PM, Peter Lieven wrote: > On 20.12.2013 14:57, Stefan Hajnoczi wrote: >> >> On Fri, Dec 20, 2013 at 1:53 PM, Peter Lieven wrote: >>> >>> On 20.12.2013 13:19, Stefan Hajnoczi wrote: On Fri, Dec 20, 2013 at 10:48:41AM +0100, Peter Lieven wrote: > > On

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-20 Thread Peter Lieven
On 20.12.2013 15:38, Stefan Hajnoczi wrote: On Fri, Dec 20, 2013 at 3:07 PM, Peter Lieven wrote: On 20.12.2013 14:57, Stefan Hajnoczi wrote: On Fri, Dec 20, 2013 at 1:53 PM, Peter Lieven wrote: On 20.12.2013 13:19, Stefan Hajnoczi wrote: On Fri, Dec 20, 2013 at 10:48:41AM +0100, Peter Lieve

Re: [Qemu-devel] [PATCH] PPC: Fix compilation with TCG debug

2013-12-20 Thread Tom Musta
On 12/20/2013 4:01 AM, Alexander Graf wrote: > The recent VSX patches broken compilation of QEMU when configurated > with --enable-debug, as it was treating "target long" TCG variables > as "i64" which is not true for 32bit targets. > > This patch fixes all the places that the compiler has found t

[Qemu-devel] [PATCH] scsi-disk: add non-zero MAX UNMAP LBA COUNT to block limits VPD page

2013-12-20 Thread Paolo Bonzini
Linux prefers WRITE SAME to UNMAP if the count is zero, and WRITE SAME does not discard anything unless the device can guarantee that the resulting block is zero. This fixes thin provisioning on glusterfs. Reported-by: Bharata B Rao Signed-off-by: Paolo Bonzini --- hw/scsi/scsi-disk.c | 11 +++

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-20 Thread ronnie sahlberg
The sync calls uses a trivial eventloop built into libnfs using poll(). Mixing the _async() and _sync() interfaces in libnfs means you may risk running nested eventloops. Pain and tears lie behind that door. On Fri, Dec 20, 2013 at 6:43 AM, Peter Lieven wrote: > On 20.12.2013 15:38, Stefan Hajno

Re: [Qemu-devel] [PATCH] block/iscsi: return -ENOMEM if an async call fails immediately

2013-12-20 Thread ronnie sahlberg
Looks good. Reviewed-by: Ronnie Sahlberg On Fri, Dec 20, 2013 at 1:02 AM, Peter Lieven wrote: > if an async libiscsi call fails directly it can only be due > to an out of memory condition. All other errors are returned > through the callback. > > Signed-off-by: Peter Lieven > --- > block/iscs

Re: [Qemu-devel] [PATCH] test: QOM interface casting

2013-12-20 Thread Igor Mammedov
On Fri, 20 Dec 2013 14:26:11 +0100 Igor Mammedov wrote: Andreas, test shows that commit: "qom: Do not register interface "types" in the type table " https://github.com/afaerber/qemu-cpu/commit/7f00136ff5534ee651f4f10475170b8db18e5c03 regresses QOM Interface in case where interface is implement

Re: [Qemu-devel] [PATCH] PPC: Fix compilation with TCG debug

2013-12-20 Thread Alexander Graf
On 20.12.2013, at 15:44, Tom Musta wrote: > On 12/20/2013 4:01 AM, Alexander Graf wrote: >> The recent VSX patches broken compilation of QEMU when configurated >> with --enable-debug, as it was treating "target long" TCG variables >> as "i64" which is not true for 32bit targets. >> >> This patc

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-20 Thread Stefan Hajnoczi
On Fri, Dec 20, 2013 at 3:43 PM, Peter Lieven wrote: > On 20.12.2013 15:38, Stefan Hajnoczi wrote: >> >> On Fri, Dec 20, 2013 at 3:07 PM, Peter Lieven wrote: >>> >>> On 20.12.2013 14:57, Stefan Hajnoczi wrote: On Fri, Dec 20, 2013 at 1:53 PM, Peter Lieven wrote: > > On 20.12.20

Re: [Qemu-devel] [PATCH v7 0/7] block: allow commit active as top

2013-12-20 Thread Stefan Hajnoczi
On Mon, Dec 16, 2013 at 02:45:26PM +0800, Fam Zheng wrote: > Previously live commit of active block device is not supported, this series > implements it and updates corresponding qemu-iotests cases. > > This series is based on BlockJobType enum QAPI series. > > v7: Fix "Since 1.8" to "Since 2.0".

Re: [Qemu-devel] [PATCH] PPC: Fix compilation with TCG debug

2013-12-20 Thread Richard Henderson
On 12/20/2013 07:27 AM, Alexander Graf wrote: > Yes, please. Make sure to always compile ppc-softmmu alongside ppc64-softmmu > and use --enable-debug when working on TCG. Or --enable-debug-tcg. If you only ever use --enable-debug, you can miss warnings generated by the optimizer (e.g. may be use

[Qemu-devel] [PULL 05/18] dataplane: replace hostmem with memory_region_find

2013-12-20 Thread Stefan Hajnoczi
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- hw/virtio/dataplane/Makefile.objs | 2 +- hw/virtio/dataplane/hostmem.c | 183 -- hw/virtio/dataplane/vring.c | 78 +-- include/hw/virtio/dat

[Qemu-devel] [PULL 04/18] dataplane: change vring API to use VirtQueueElement

2013-12-20 Thread Stefan Hajnoczi
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- hw/block/dataplane/virtio-blk.c | 85 ++--- hw/virtio/dataplane/vring.c | 56 +++- include/hw/virtio/dataplane/vring.h | 7 ++- 3 files changed,

[Qemu-devel] [PULL 01/18] sheepdog: fix dynamic grow for running qcow2 format

2013-12-20 Thread Stefan Hajnoczi
From: Liu Yuan When running qcow2 over sheepdog, we might meet following problem qemu-system-x86_64: shrinking is not supported And cause IO errors to Guest. This is because we abuse bs->total_sectors, which is manipulated by generic block layer and race with sheepdog code. We should directl

[Qemu-devel] [PULL 16/18] commit: Support commit active layer

2013-12-20 Thread Stefan Hajnoczi
From: Fam Zheng If active is top, it will be mirrored to base, (with block/mirror.c code), then the image is switched when user completes the block job. QMP documentation is updated. Signed-off-by: Fam Zheng Signed-off-by: Stefan Hajnoczi --- block/mirror.c | 11 +++ blockdev.c

[Qemu-devel] [PULL 02/18] vring: create a common function to parse descriptors

2013-12-20 Thread Stefan Hajnoczi
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- hw/virtio/dataplane/vring.c | 113 1 file changed, 51 insertions(+), 62 deletions(-) diff --git a/hw/virtio/dataplane/vring.c b/hw/virtio/dataplane/vring.c index 35

[Qemu-devel] [PULL 12/18] qemu-iotests: drop duplicate virtio-blk initialization failure

2013-12-20 Thread Stefan Hajnoczi
Commit 75884afd5c6c42e523b08565e289dbe319e17ad9 ("virtio-blk: Convert to QOM realize") dropped a duplicate error_report() call. Now we no longer get the following error message twice: QEMU_PROG: -drive if=virtio: Device initialization failed. Update qemu-iotests 051. Signed-off-by: Stefan Haj

[Qemu-devel] [PULL 13/18] mirror: Don't close target

2013-12-20 Thread Stefan Hajnoczi
From: Fam Zheng Let reference count manage target and don't call bdrv_close here. Signed-off-by: Fam Zheng Reviewed-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- block/mirror.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/mirror.c b/block/mirror.c index 6dc27ad..5b2c119 10064

[Qemu-devel] [PULL 06/18] qapi-schema: fix QEMU 1.8 references

2013-12-20 Thread Stefan Hajnoczi
We are moving boldly on to QEMU 2.0 in the next release. Some patches written at a time where we assumed 1.8 would be the next version number managed to sneak in. s/1.8/2.0/ in qapi-schema.json Signed-off-by: Stefan Hajnoczi Reviewed-by: Fam Zheng Reviewed-by: Eric Blake --- qapi-schema.json

[Qemu-devel] [PULL 15/18] block: Add commit_active_start()

2013-12-20 Thread Stefan Hajnoczi
From: Fam Zheng commit_active_start is implemented in block/mirror.c, It will create a job with "commit" type and designated base in block-commit command. This will be used for committing active layer of device. Sync mode is removed from MirrorBlockJob because there's no proper type for commit.

[Qemu-devel] [PULL 17/18] qemu-iotests: Update test cases for commit active

2013-12-20 Thread Stefan Hajnoczi
From: Fam Zheng Factor out commit test common logic into super class, and update test of committing the active image. Signed-off-by: Fam Zheng Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/040 | 74 ++ 1 file changed, 32 insertions(+), 4

[Qemu-devel] [PULL 09/18] docs: updated qemu-img man page and qemu-doc to reflect VHDX support.

2013-12-20 Thread Stefan Hajnoczi
From: Jeff Cody The man page for qemu-img, and the qemu-doc, did not mention VHDX as a supported format. This adds in reference to VHDX in those documents. [Stefan Weil suggested s/Block Size/Block size/ for consistency. I have made this change. --Stefan] Signed-off-by: Jeff Cody Reviewed-b

  1   2   3   >