Hi, Am 20.12.2013 12:08, schrieb Igor Mammedov: > --- > tests/Makefile | 3 + > tests/check-qom-interface.c | 102 > +++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 105 insertions(+), 0 deletions(-) > create mode 100644 tests/check-qom-interface.c
Apart from the style issues and typos that the two Peter's have pointed out, I'd like to point out that this is missing Signed-off-by and commit message. In particular, is this a test that should be committed alongside the interface cast fixes or anything else that I have queued? Or just to improve overall test coverage? Either way I'm in favor of having them. Concerning PMM's comment, don't we already have a qdev properties unit test from Eduardo where we might share QOM dependencies via some Makefile variable? Grouping the check-* tests also makes sense to me than just adding at the bottom. Anything in particular that you'd like comments on, this being an RFC? Regards, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
