Re: [Qemu-devel] [PATCH] block: add native support for NFS

2013-12-17 Thread Fam Zheng
On 2013年12月17日 15:53, Peter Lieven wrote: Hi Fam, On 17.12.2013 05:07, Fam Zheng wrote: On 2013年12月16日 23:34, Peter Lieven wrote: +static int coroutine_fn nfs_co_writev(BlockDriverState *bs, +int64_t sector_num, int nb_sectors, +

Re: [Qemu-devel] [PATCH] spapr-pci: remove io ports workaround

2013-12-17 Thread Alexey Kardashevskiy
On 12/17/2013 06:52 PM, Greg Kurz wrote: > On Wed, 11 Dec 2013 18:07:58 +1100 > Alexey Kardashevskiy wrote: >> >> Hm. Nack. This fails: >> >> ./qemu-system-ppc64 \ >> -trace "events=qemu_trace_events" \ >> -L "qemu-ppc64-bios/" \ >> -nographic \ >> -vga "none" \ >> -device \ >> virtio-blk-pc

Re: [Qemu-devel] [PATCH] block: add native support for NFS

2013-12-17 Thread Peter Lieven
On 17.12.2013 09:29, Fam Zheng wrote: On 2013年12月17日 15:53, Peter Lieven wrote: Hi Fam, On 17.12.2013 05:07, Fam Zheng wrote: On 2013年12月16日 23:34, Peter Lieven wrote: +static int coroutine_fn nfs_co_writev(BlockDriverState *bs, +int64_t sector_num, int

Re: [Qemu-devel] [PATCH] block: add native support for NFS

2013-12-17 Thread Fam Zheng
于2013年12月17日 星期二 16时46分50秒,Peter Lieven写到: On 17.12.2013 09:29, Fam Zheng wrote: On 2013年12月17日 15:53, Peter Lieven wrote: Hi Fam, On 17.12.2013 05:07, Fam Zheng wrote: On 2013年12月16日 23:34, Peter Lieven wrote: +static int coroutine_fn nfs_co_writev(BlockDriverState *bs, +

Re: [Qemu-devel] [PATCH] block: add native support for NFS

2013-12-17 Thread Peter Lieven
On 17.12.2013 09:51, Fam Zheng wrote: 于2013年 12月17日 星期二 16时46分50秒,Peter Lieven写到: On 17.12.2013 09:29, Fam Zheng wrote: On 2013年12月17日 15:53, Peter Lieven wrote: Hi Fam, On 17.12.2013 05:07, Fam Zheng wrote: On 2013年12月16日 23:34, Peter Lieven wrote: +static int coroutine_fn nfs_co_writev(Bl

[Qemu-devel] qemu 1.7.0 does not build on NetBSD (patch)

2013-12-17 Thread Martin Husemann
On NetBSD int8_t and friends are preprocessor macros expanding to __int8_t (which is a typedef provided by machine dependent headers). include/exec/softmmu_template.h tries to safe 3 lines of code by using preprosseor concatenation, which only will work if int8_t is not a define, or defined to in

Re: [Qemu-devel] [PATCH] block: add native support for NFS

2013-12-17 Thread Fam Zheng
On 2013年12月17日 16:55, Peter Lieven wrote: On 17.12.2013 09:51, Fam Zheng wrote: 于2013年 12月17日 星期二 16时46分50秒,Peter Lieven写到: On 17.12.2013 09:29, Fam Zheng wrote: On 2013年12月17日 15:53, Peter Lieven wrote: Hi Fam, On 17.12.2013 05:07, Fam Zheng wrote: On 2013年12月16日 23:34, Peter Lieven wrote:

Re: [Qemu-devel] [PATCH] block: add native support for NFS

2013-12-17 Thread Peter Lieven
On 17.12.2013 10:01, Fam Zheng wrote: On 2013年12月17日 16:55, Peter Lieven wrote: On 17.12.2013 09:51, Fam Zheng wrote: 于2013年 12月17日 星期二 16时46分50秒,Peter Lieven写到: On 17.12.2013 09:29, Fam Zheng wrote: On 2013年12月17日 15:53, Peter Lieven wrote: Hi Fam, On 17.12.2013 05:07, Fam Zheng wrote: On

Re: [Qemu-devel] [PATCH V4] char: restore read callback on a reattached (hotplug) chardev

2013-12-17 Thread Gal Hammer
On 16/12/2013 22:32, Amit Shah wrote: On (Sun) 15 Dec 2013 [12:26:37], Gal Hammer wrote: Fix a bug that was introduced in commit 386a5a1e. A removal of a device set the chr handlers to NULL. However when the device is plugged back, its read callback is not restored so data can't be transferred f

[Qemu-devel] [Bug 1261268] Re: save guest running time is more than 450s with AVX running.

2013-12-17 Thread chao zhou
after re-check , the first bad commit is: commit 3e469dbfe413c25d48321c3a19ddfae0727dc6e5 Author: Andrea Arcangeli Date: Thu Jul 25 12:11:15 2013 +0200 exec: always use MADV_DONTFORK MADV_DONTFORK prevents fork to fail with -ENOMEM if the default overcommit heuristics decides there

[Qemu-devel] [Bug 1261268] Re: save guest running time is more than 450s with AVX running.

2013-12-17 Thread chao zhou
after re-check , the first bad commit is: commit 3e469dbfe413c25d48321c3a19ddfae0727dc6e5 Author: Andrea Arcangeli Date: Thu Jul 25 12:11:15 2013 +0200 exec: always use MADV_DONTFORK MADV_DONTFORK prevents fork to fail with -ENOMEM if the default overcommit heuristics decides there

[Qemu-devel] [Bug 1261268] Re: save guest running time is more than 450s with AVX running.

2013-12-17 Thread chao zhou
after re-check , the first bad commit is: commit 3e469dbfe413c25d48321c3a19ddfae0727dc6e5 Author: Andrea Arcangeli Date: Thu Jul 25 12:11:15 2013 +0200 exec: always use MADV_DONTFORK MADV_DONTFORK prevents fork to fail with -ENOMEM if the default overcommit heuristics decides there

[Qemu-devel] [Bug 1261268] Re: save guest running time is more than 450s with AVX running.

2013-12-17 Thread chao zhou
after re-check , the first bad commit is: commit 3e469dbfe413c25d48321c3a19ddfae0727dc6e5 Author: Andrea Arcangeli Date: Thu Jul 25 12:11:15 2013 +0200 exec: always use MADV_DONTFORK MADV_DONTFORK prevents fork to fail with -ENOMEM if the default overcommit heuristics decides there

[Qemu-devel] [Bug 1261268] Re: save guest running time is more than 450s with AVX running.

2013-12-17 Thread chao zhou
after re-check , the first bad commit is: commit 3e469dbfe413c25d48321c3a19ddfae0727dc6e5 Author: Andrea Arcangeli Date: Thu Jul 25 12:11:15 2013 +0200 exec: always use MADV_DONTFORK MADV_DONTFORK prevents fork to fail with -ENOMEM if the default overcommit heuristics decides there

[Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-17 Thread Peter Lieven
This patch adds native support for accessing images on NFS shares without the requirement to actually mount the entire NFS share on the host. NFS Images can simply be specified by an url of the form: nfs: For example: qemu-img create -f qcow2 nfs://10.0.0.1/qemu-images/test.qcow2 You need li

[Qemu-devel] [PATCH] qom: fix cast results caching

2013-12-17 Thread Sergey Fedorov
A single cast cache is used for both an object casting and a class casting. In case of interface presence a class cast result may be not the same pointer as opposite to an object casting. So do not cache cast results for an object casting in a presence of interfaces. Signed-off-by: Sergey Fedorov

[Qemu-devel] [PATCH] qom: fix cast results caching

2013-12-17 Thread Sergey Fedorov
A single cast cache is used for both an object casting and a class casting. In case of interface presence a class cast result may be not the same pointer as opposite to an object casting. So do not cache cast results for an object casting in a presence of interfaces. Signed-off-by: Sergey Fedorov

Re: [Qemu-devel] [PATCH] qom: fix cast results caching

2013-12-17 Thread Peter Crosthwaite
On Tue, Dec 17, 2013 at 7:20 PM, Sergey Fedorov wrote: > A single cast cache is used for both an object casting and a class > casting. In case of interface presence a class cast result may be not > the same pointer as opposite to an object casting. So do not cache cast > results for an object cas

Re: [Qemu-devel] [PATCH] block: add native support for NFS

2013-12-17 Thread Fam Zheng
On 2013年12月17日 17:07, Peter Lieven wrote: On 17.12.2013 10:01, Fam Zheng wrote: On 2013年12月17日 16:55, Peter Lieven wrote: On 17.12.2013 09:51, Fam Zheng wrote: 于2013年 12月17日 星期二 16时46分50秒,Peter Lieven写到: On 17.12.2013 09:29, Fam Zheng wrote: On 2013年12月17日 15:53, Peter Lieven wrote: Hi Fam,

Re: [Qemu-devel] [PATCH] qom: fix cast results caching

2013-12-17 Thread Fedorov Sergey
On 12/17/2013 01:40 PM, Peter Crosthwaite wrote: On Tue, Dec 17, 2013 at 7:20 PM, Sergey Fedorov wrote: A single cast cache is used for both an object casting and a class casting. In case of interface presence a class cast result may be not the same pointer as opposite to an object casting. S

Re: [Qemu-devel] [PATCH 1/5] Add the standby-mem machine option

2013-12-17 Thread Paolo Bonzini
Il 16/12/2013 21:51, Matthew Rosato ha scritto: > Add the machine=...,standby-mem={size} option and associated > documentation. See how Igor Mammedov's x86 memory hotplug instead added "-m NN,maxmem=NN". You could use these two patches: http://lists.gnu.org/archive/html/qemu-devel/2013-11/msg034

Re: [Qemu-devel] strange failures with SATA drive but not with IDE drive

2013-12-17 Thread Paolo Bonzini
Il 17/12/2013 05:12, Michael Tokarev ha scritto: > > When you switch from bus=ahci.0 to bus=ide.0 on the qemu command line > above, it all works fine and does not spew any warnings like that > about emulation failure. > > It looks like we have some uninitialized data on sata emulation > (in addit

Re: [Qemu-devel] qemu 1.7.0 does not build on NetBSD (patch)

2013-12-17 Thread Paolo Bonzini
Il 17/12/2013 09:55, Martin Husemann ha scritto: > On NetBSD int8_t and friends are preprocessor macros expanding to __int8_t > (which is a typedef provided by machine dependent headers). > > include/exec/softmmu_template.h tries to safe 3 lines of code by using > preprosseor concatenation, which

Re: [Qemu-devel] [PATCH] block: add native support for NFS

2013-12-17 Thread Peter Lieven
On 17.12.2013 10:46, Fam Zheng wrote: On 2013年12月17日 17:07, Peter Lieven wrote: On 17.12.2013 10:01, Fam Zheng wrote: On 2013年12月17日 16:55, Peter Lieven wrote: On 17.12.2013 09:51, Fam Zheng wrote: 于2013年 12月17日 星期二 16时46分50秒,Peter Lieven写到: On 17.12.2013 09:29, Fam Zheng wrote: On 2013年12月

Re: [Qemu-devel] [PATCH 5/7] hw/arm/boot: Allow easier swapping in of different loader code

2013-12-17 Thread Peter Maydell
On 17 December 2013 01:24, Peter Crosthwaite wrote: > On Tue, Dec 17, 2013 at 10:58 AM, Peter Maydell > wrote: >> On 17 December 2013 00:52, Peter Crosthwaite >> wrote: >>> On Fri, Dec 13, 2013 at 8:05 PM, Peter Maydell >>> wrote: On 13 December 2013 03:19, Peter Crosthwaite wrote:

Re: [Qemu-devel] [PATCH RFC 1/2] rng-egd: improve egd backend performance

2013-12-17 Thread Amit Shah
On (Tue) 17 Dec 2013 [08:47:34], Markus Armbruster wrote: > Amos Kong writes: > > > Bugzilla: https://bugs.launchpad.net/qemu/+bug/1253563 > > > > We have a requests queue to cache the random data, but the second > > will come in when the first request is returned, so we always > > only have one

[Qemu-devel] [qemu-kvm PATCH] block: vhdx - improve error message, and .bdrv_check implementation

2013-12-17 Thread Jeff Cody
If there is a dirty log file to be replayed in a VHDX image, it is replayed in .vhdx_open(). However, if the file is opened read-only, then a somewhat cryptic error message results. This adds a more helpful error message for the user. If an image file contains a log to be replayed, and is opened

Re: [Qemu-devel] [PATCH 09/11] ACPI: move PRST OperationRegion into SSDT

2013-12-17 Thread Michael S. Tsirkin
On Mon, Dec 16, 2013 at 10:53:24PM +0100, Igor Mammedov wrote: > On Mon, 16 Dec 2013 22:13:30 +0100 > Laszlo Ersek wrote: > > > On 12/16/13 21:38, Igor Mammedov wrote: > > > On Mon, 16 Dec 2013 21:30:14 +0200 > > > "Michael S. Tsirkin" wrote: > > > > > >> On Fri, Dec 13, 2013 at 05:22:14PM +010

Re: [Qemu-devel] [PATCH v2] x86: gigabyte alignment for ram

2013-12-17 Thread Gerd Hoffmann
Hi, > > Problem is that the firmware places the xbar @ 0xb00. > > Hardcoded, assuming qemu will not map ram above 0xb000. > > Can't bios figure out the size of memory below 4G from fwcfg? > I refer to 7db16f2480db5e246d34d0c453cff4f58549df0e specifically. It can, but it doesn't. Addit

Re: [Qemu-devel] [Bug 1261450] [NEW] libvirtd reload and hooks problem routed-net

2013-12-17 Thread Stefan Hajnoczi
On Mon, Dec 16, 2013 at 05:00:51PM -, Chris Weltzien wrote: > if we do a reload of libvirt, some iptables rules, which are created through > /etc/libvirt/hooks/qemu are not working anymore. > Every time a other (one or two,thee) vm is affected. Please report this to the libvirt project: http

Re: [Qemu-devel] [PATCH v3 1/7] Add -mem-share option

2013-12-17 Thread Paolo Bonzini
Il 16/12/2013 16:47, Igor Mammedov ha scritto: > memdev is introduced here: > http://lists.gnu.org/archive/html/qemu-devel/2013-11/msg02532.html > > as for mem-path & mem-prealloc, I was thinking about adding HugePageMem > backend > to handle hugepage specifics. mem-share could be a part of Shar

Re: [Qemu-devel] [PATCH 01/42] ui/sdl2 : initial port to SDL 2.0 (v2.0)

2013-12-17 Thread Gerd Hoffmann
Hi, > > +if test $sdlabi == "2.0"; then > > Please replace '==' by a single '=' here. dash (and maybe other less > sophisticated shells) don't like '=='. I'll fix it up. > I know that sdl2.c is based on sdl.c which was coded before the > introduction of the current coding rules, but would you

[Qemu-devel] [PATCH v2 0/5] Monitor commands for object-add/del

2013-12-17 Thread Paolo Bonzini
These allow hotplugging (and hot-unplugging without leaking an object) virtio-rng devices. They can also be used for memory hotplug. v1->v2: fix mistyped underscores in qapi-schema.json Paolo Bonzini (5): rng: initialize file descriptor to -1 qom: fix leak for objects created with -object

[Qemu-devel] [PATCH v2 5/5] monitor: add object-del (QMP) and object_del (HMP) command

2013-12-17 Thread Paolo Bonzini
These two commands invoke the "unparent" method of Object. Signed-off-by: Paolo Bonzini --- hmp-commands.hx | 14 ++ hmp.c| 9 + hmp.h| 1 + qapi-schema.json | 14 ++ qmp-commands.hx | 24 qmp.c| 12

[Qemu-devel] [PATCH v2 1/5] rng: initialize file descriptor to -1

2013-12-17 Thread Paolo Bonzini
The file descriptor is never initialized to -1, which makes rng-random close stdin if an object is created and immediately destroyed. If we change it to -1, we also need to protect qemu_set_fd_handler from receiving a bogus file descriptor. Signed-off-by: Paolo Bonzini --- backends/rng-random.c

[Qemu-devel] [PATCH v2 3/5] qom: catch errors in object_property_add_child

2013-12-17 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- qom/object.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/qom/object.c b/qom/object.c index fc19cf6..68fe07a 100644 --- a/qom/object.c +++ b/qom/object.c @@ -988,17 +988,22 @@ static void object_finalize_child_property(Object *obj,

[Qemu-devel] [PATCH v2 2/5] qom: fix leak for objects created with -object

2013-12-17 Thread Paolo Bonzini
The object must be unref-ed when its variable goes out of scope. Signed-off-by: Paolo Bonzini --- vl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/vl.c b/vl.c index 8d5d874..6917fd1 100644 --- a/vl.c +++ b/vl.c @@ -2807,12 +2807,13 @@ static int object_create(QemuOpts *

[Qemu-devel] [PATCH v2 4/5] monitor: add object-add (QMP) and object_add (HMP) command

2013-12-17 Thread Paolo Bonzini
Add two commands that are the monitor counterparts of -object. The commands have the same Visitor-based implementation, but use different kinds of visitors so that the HMP command has a DWIM string-based syntax, while the QMP variant accepts a stricter JSON-based properties dictionary. Signed-off

Re: [Qemu-devel] [PATCH 5/7] hw/arm/boot: Allow easier swapping in of different loader code

2013-12-17 Thread Peter Crosthwaite
On Tue, Dec 17, 2013 at 8:31 PM, Peter Maydell wrote: > On 17 December 2013 01:24, Peter Crosthwaite > wrote: >> On Tue, Dec 17, 2013 at 10:58 AM, Peter Maydell >> wrote: >>> On 17 December 2013 00:52, Peter Crosthwaite >>> wrote: On Fri, Dec 13, 2013 at 8:05 PM, Peter Maydell wrote

Re: [Qemu-devel] [PATCH 2/7] target-arm: Clean up handling of AArch64 PSTATE

2013-12-17 Thread Peter Maydell
On 17 December 2013 04:45, Christoffer Dall wrote: > I think this could be written slightly more clearly for the uninitiated, > but maybe I'm just not qemu-savy enough. It was a bit compressed; I've reworded it to: /* PSTATE isn't an architectural register for ARMv8. However, it is * con

Re: [Qemu-devel] [PATCH 5/7] hw/arm/boot: Allow easier swapping in of different loader code

2013-12-17 Thread Peter Maydell
On 17 December 2013 11:36, Peter Crosthwaite wrote: > On Tue, Dec 17, 2013 at 8:31 PM, Peter Maydell > wrote: >> I'm not convinced about this at all -- this would be letting the >> "I know about booting Linux" code spread out from boot.c >> where it currently is into every device. That sounds li

Re: [Qemu-devel] [PATCH v2 4/5] monitor: add object-add (QMP) and object_add (HMP) command

2013-12-17 Thread Peter Crosthwaite
On Tue, Dec 17, 2013 at 9:26 PM, Paolo Bonzini wrote: > Add two commands that are the monitor counterparts of -object. The commands > have the same Visitor-based implementation, but use different kinds of > visitors so that the HMP command has a DWIM string-based syntax, while > the QMP variant a

Re: [Qemu-devel] [PATCH v2] x86: gigabyte alignment for ram

2013-12-17 Thread Michael S. Tsirkin
On Tue, Dec 17, 2013 at 11:54:46AM +0100, Gerd Hoffmann wrote: > Hi, > > > > Problem is that the firmware places the xbar @ 0xb00. > > > Hardcoded, assuming qemu will not map ram above 0xb000. > > > > Can't bios figure out the size of memory below 4G from fwcfg? > > I refer to 7db16f248

Re: [Qemu-devel] [PATCH 00/11 v3] Refactor PCI/SHPC/PCIE hotplug to use a more generic hotplug API

2013-12-17 Thread Igor Mammedov
On Mon, 16 Dec 2013 15:26:37 -0800 Anthony Liguori wrote: > Igor Mammedov writes: > > > changes since v2: > > * s/hotplugable/hotpluggable/ > > * move hotplug check to an earlier patch: > > "qdev: add "hotpluggable" property to Device" > > -- > > Refactor PCI specific hotplug API to a more ge

[Qemu-devel] [PATCH] vmdk: Allow vmdk_create to work with protocol

2013-12-17 Thread Fam Zheng
This changes vmdk_create to use bdrv_* functions to replace qemu_open and other fd functions. The error handling are improved as well. One difference is that bdrv_pwrite will round up buffer to sectors, so for description file, an extra bdrv_truncate is used in the end to drop ending zeros. I test

Re: [Qemu-devel] [PATCH 5/7] hw/arm/boot: Allow easier swapping in of different loader code

2013-12-17 Thread Peter Crosthwaite
On Tue, Dec 17, 2013 at 9:47 PM, Peter Maydell wrote: > On 17 December 2013 11:36, Peter Crosthwaite > wrote: >> On Tue, Dec 17, 2013 at 8:31 PM, Peter Maydell >> wrote: >>> I'm not convinced about this at all -- this would be letting the >>> "I know about booting Linux" code spread out from bo

[Qemu-devel] [PATCH v2 6/7] hw/arm/boot: Add boot support for AArch64 processor

2013-12-17 Thread Peter Maydell
From: "Mian M. Hamayun" This commit adds support for booting a single AArch64 CPU by setting appropriate registers. The bootloader includes placehoders for Board-ID that are used to implement uniform indexing across different bootloaders. Signed-off-by: Mian M. Hamayun Signed-off-by: Peter Mayd

[Qemu-devel] [PATCH v2 7/7] default-configs: Add config for aarch64-softmmu

2013-12-17 Thread Peter Maydell
Add a config for aarch64-softmmu; this enables building of this target. The resulting executable doesn't know about any 64 bit CPUs, but all the 32 bit CPUs and board models work. Signed-off-by: Peter Maydell Message-id: 1385645602-18662-8-git-send-email-peter.mayd...@linaro.org --- default-conf

[Qemu-devel] [PATCH v2 5/7] hw/arm/boot: Allow easier swapping in of different loader code

2013-12-17 Thread Peter Maydell
For AArch64 we will obviously require a different set of primary and secondary boot loader code fragments. However currently we hardcode the offsets into the loader code where we must write the entrypoint and other data into arm_load_kernel(). This makes it hard to substitute a different loader fra

Re: [Qemu-devel] [PATCH v2 4/5] monitor: add object-add (QMP) and object_add (HMP) command

2013-12-17 Thread Paolo Bonzini
Il 17/12/2013 12:54, Peter Crosthwaite ha scritto: >> +visit_start_struct(opts_get_visitor(ov), &dummy, NULL, NULL, 0, &err); >> +if (error_is_set(&err)) { >> +goto out_clean; >> +} > > So I have been thinking about repeated if(error_is_set(&err)) { goto > foo; } and how to red

[Qemu-devel] [PATCH v2 3/7] target-arm: Add minimal KVM AArch64 support

2013-12-17 Thread Peter Maydell
From: "Mian M. Hamayun" Add the bare minimum set of functions needed for control of an AArch64 KVM vcpu: * CPU initialization * minimal get/put register functions which only handle the basic state of the CPU Signed-off-by: Mian M. Hamayun Signed-off-by: Peter Maydell Message-id: 138564560

[Qemu-devel] [PATCH v2 0/7] target-arm: Support AArch64 KVM

2013-12-17 Thread Peter Maydell
This patchset adds support for basic AArch64 KVM VM control; it's based on current master. This is a quick resend with the very minor nits Christoffer pointed out fixed; I'm planning to put it into a target-arm pullreq in the next day or two. This patch series supports: * 64 bit KVM VM control *

[Qemu-devel] [PATCH v2 4/7] configure: Enable KVM for aarch64 host/target combination

2013-12-17 Thread Peter Maydell
Enable KVM if the host and target CPU are both aarch64. Note that host aarch64 + target arm is not valid for KVM acceleration: the 64 bit kernel does not support the ioctl interface for 32 bit CPUs. 32 bit VMs on 64 bit hosts need to be created using the 64 bit ioctl interface; when QEMU supports t

[Qemu-devel] [PATCH v2 1/7] target-arm/kvm: Split 32 bit only code into its own file

2013-12-17 Thread Peter Maydell
Split ARM KVM support code which is 32 bit specific out into its own file, which we only compile on 32 bit hosts. This will give us a place to add the 64 bit support code without adding lots of ifdefs to kvm.c. Signed-off-by: Peter Maydell Message-id: 1385645602-18662-2-git-send-email-peter.mayd.

[Qemu-devel] [PATCH v2 2/7] target-arm: Clean up handling of AArch64 PSTATE

2013-12-17 Thread Peter Maydell
The env->pstate field is a little odd since it doesn't strictly speaking represent an architectural register. However it's convenient for QEMU to use it to hold the various PSTATE architectural bits in the same format the architecture specifies for SPSR registers (since this is the same format the

Re: [Qemu-devel] [PATCH 00/11 v3] Refactor PCI/SHPC/PCIE hotplug to use a more generic hotplug API

2013-12-17 Thread Paolo Bonzini
Il 17/12/2013 00:26, Anthony Liguori ha scritto: > Sharing hot plug code is a good thing. Making hotplug a qdev-level > concept seems like a bad thing to me. Can you explain what you mean? > The series is a net add of code so I don't think we're winning anything > by generalizing here. Any gene

Re: [Qemu-devel] [PATCH v2 4/5] monitor: add object-add (QMP) and object_add (HMP) command

2013-12-17 Thread Peter Crosthwaite
On Tue, Dec 17, 2013 at 10:24 PM, Paolo Bonzini wrote: > Il 17/12/2013 12:54, Peter Crosthwaite ha scritto: >>> +visit_start_struct(opts_get_visitor(ov), &dummy, NULL, NULL, 0, &err); >>> +if (error_is_set(&err)) { >>> +goto out_clean; >>> +} >> >> So I have been thinking about

Re: [Qemu-devel] [PATCH v2 7/7] default-configs: Add config for aarch64-softmmu

2013-12-17 Thread Peter Crosthwaite
On Tue, Dec 17, 2013 at 10:15 PM, Peter Maydell wrote: > Add a config for aarch64-softmmu; this enables building of this target. > The resulting executable doesn't know about any 64 bit CPUs, but all > the 32 bit CPUs and board models work. > > Signed-off-by: Peter Maydell Reviewed-by: Peter Cro

Re: [Qemu-devel] [PATCH qom-cpu 00/16 v10] target-i386: convert CPU features into properties

2013-12-17 Thread Igor Mammedov
On Mon, 16 Dec 2013 16:26:55 -0200 Eduardo Habkost wrote: > On Mon, Dec 16, 2013 at 04:01:05PM +0100, Igor Mammedov wrote: > > On Sun, 15 Dec 2013 23:50:47 +0100 > > Andreas Färber wrote: > > > > > Am 27.11.2013 23:28, schrieb Igor Mammedov: > > > > Igor Mammedov (16): > > > > target-i386: cl

Re: [Qemu-devel] [PATCH v2 6/7] hw/arm/boot: Add boot support for AArch64 processor

2013-12-17 Thread Peter Crosthwaite
On Tue, Dec 17, 2013 at 10:15 PM, Peter Maydell wrote: > From: "Mian M. Hamayun" > > This commit adds support for booting a single AArch64 CPU by setting > appropriate registers. The bootloader includes placehoders for Board-ID "placeholders" > that are used to implement uniform indexing across

Re: [Qemu-devel] [PATCH v2 4/5] monitor: add object-add (QMP) and object_add (HMP) command

2013-12-17 Thread Markus Armbruster
Peter Crosthwaite writes: > On Tue, Dec 17, 2013 at 10:24 PM, Paolo Bonzini wrote: >> Il 17/12/2013 12:54, Peter Crosthwaite ha scritto: +visit_start_struct(opts_get_visitor(ov), &dummy, NULL, NULL, 0, &err); +if (error_is_set(&err)) { +goto out_clean; +}

Re: [Qemu-devel] [PATCH v2 6/7] hw/arm/boot: Add boot support for AArch64 processor

2013-12-17 Thread Peter Maydell
On 17 December 2013 13:04, Peter Crosthwaite wrote: > On Tue, Dec 17, 2013 at 10:15 PM, Peter Maydell > wrote: >> From: "Mian M. Hamayun" >> >> This commit adds support for booting a single AArch64 CPU by setting >> appropriate registers. The bootloader includes placehoders for Board-ID > > "pla

[Qemu-devel] [PATCH 0/8] s390 sigp, chsc and diag bugfixes/cleanups

2013-12-17 Thread Jens Freimann
Alex, this is mostly bugfixes and cleanup patches, except for Patch 4/8 which implements a SIGP order code for "cpu start". regards Jens Cornelia Huck (1): s390x/kvm: Fix diagnose handling. Thomas Huth (7): s390x/kvm: Removed duplicated SIGP defines s390x/kvm: Removed s390_store_status

[Qemu-devel] [PATCH 1/8] s390x/kvm: Fix diagnose handling.

2013-12-17 Thread Jens Freimann
From: Cornelia Huck The instruction intercept handler for diagnose used only the displacement when trying to calculate the function code. This is only correct for base 0, however; we need to perform a complete base/displacement address calculation and use bits 48-63 as the function code. Reviewe

[Qemu-devel] [PATCH 4/8] s390x/kvm: Fix coding style in handle_sigp()

2013-12-17 Thread Jens Freimann
From: Thomas Huth To make scripts/checkpatch.pl happy for the following patches, the coding style in handle_sigp() has to be fixed first. Signed-off-by: Thomas Huth Acked-by: Cornelia Huck Signed-off-by: Jens Freimann --- target-s390x/kvm.c | 24 1 file changed, 12 i

[Qemu-devel] [PATCH 8/8] s390x/ioinst: CHSC has to set a condition code

2013-12-17 Thread Jens Freimann
From: Thomas Huth I missed to set the CC in the CHSC instruction when I refactored the CC setting in the IO instructions with the following commit: 5d9bf1c07c1369ab3506fc82cc65a10f4415d867 s390/ioinst: Moved the CC setting to the IO instruction handlers This patch now restores the

[Qemu-devel] [PATCH 2/8] s390x/kvm: Removed duplicated SIGP defines

2013-12-17 Thread Jens Freimann
From: Thomas Huth The SIGP order defines are also available in cpu.h, so there is no need to re-define them in kvm.c. Signed-off-by: Thomas Huth Reviewed-by: Cornelia Huck Signed-off-by: Jens Freimann --- target-s390x/kvm.c | 5 - 1 file changed, 5 deletions(-) diff --git a/target-s390x

[Qemu-devel] [PATCH 3/8] s390x/kvm: Removed s390_store_status stub

2013-12-17 Thread Jens Freimann
From: Thomas Huth The SIGP order STORE STATUS AT ADDRESS will be handled in kernel space, so we do not need the stub in QEMU anymore. Signed-off-by: Thomas Huth Reviewed-by: Cornelia Huck Signed-off-by: Jens Freimann --- target-s390x/kvm.c | 22 -- 1 file changed, 22 dele

[Qemu-devel] [PATCH 5/8] s390x/kvm: Implemented SIGP START

2013-12-17 Thread Jens Freimann
From: Thomas Huth This patch adds the missing START order to the SIGP instruction handler. Signed-off-by: Thomas Huth Reviewed-by: Cornelia Huck Signed-off-by: Jens Freimann --- target-s390x/kvm.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/target-s390x/kvm.c b/target-s3

[Qemu-devel] [PATCH 6/8] s390x/kvm: Simplified the calculation of the SIGP order code

2013-12-17 Thread Jens Freimann
From: Thomas Huth We've already got a helper function for calculating the base/displacement of RS formatted instructions, so we can get rid of the manual calculation of the SIGP order code. Signed-off-by: Thomas Huth Reviewed-by: Cornelia Huck Signed-off-by: Jens Freimann --- target-s390x/kv

[Qemu-devel] [PATCH 7/8] s390x/kvm: Fixed condition code for unknown SIGP orders

2013-12-17 Thread Jens Freimann
From: Thomas Huth If SIGP is called with an unknown order code, it has to return CC1 instead of CC3 and set the "invalid order" bit in the return status. Signed-off-by: Thomas Huth Reviewed-by: Cornelia Huck Signed-off-by: Jens Freimann --- target-s390x/kvm.c | 17 +++-- 1 file c

Re: [Qemu-devel] [PATCH V3 00/13] Stage 2 VSX Support

2013-12-17 Thread Alexander Graf
On 03.12.2013, at 17:11, Tom Musta wrote: > On 11/1/2013 8:21 AM, Tom Musta wrote: >> NOTE: this is a resubmission of this patch series. Alex discovered some >> corruption in the patches from my previous submission. >> >> This patch series continues adding support for the PowerPC Vector Scalar

Re: [Qemu-devel] [PATCH 7/7] default-configs: Add config for aarch64-softmmu

2013-12-17 Thread Christopher Covington
On 12/16/2013 06:40 PM, Christoffer Dall wrote: > On Thu, Nov 28, 2013 at 01:33:22PM +, Peter Maydell wrote: >> Add a config for aarch64-softmmu; this enables building of this target. >> The resulting executable doesn't know about any 64 bit CPUs, but all >> the 32 bit CPUs and board models wor

Re: [Qemu-devel] [Qemu-ppc] [PATCH V3 01/19] Fix float64_to_uint64

2013-12-17 Thread Alexander Graf
On 01.11.2013, at 14:35, Tom Musta wrote: > The comment preceding the float64_to_uint64 routine suggests that > the implementation is broken. And this is, indeed, the case. > > This patch properly implements the conversion of a 64-bit floating > point number to an unsigned, 64 bit integer. >

Re: [Qemu-devel] [PATCH v2 6/7] hw/arm/boot: Add boot support for AArch64 processor

2013-12-17 Thread Peter Crosthwaite
On Tue, Dec 17, 2013 at 11:14 PM, Peter Maydell wrote: > On 17 December 2013 13:04, Peter Crosthwaite > wrote: >> On Tue, Dec 17, 2013 at 10:15 PM, Peter Maydell >> wrote: >>> From: "Mian M. Hamayun" >>> >>> This commit adds support for booting a single AArch64 CPU by setting >>> appropriate re

Re: [Qemu-devel] [PATCH v10 0/6] hw/arm: add initial support for Canon DIGIC SoC

2013-12-17 Thread Peter Maydell
On 16 December 2013 10:15, Antony Pavlov wrote: > Changes since v9: > 1. rebase over Peter Crosthwaite's "Fix Support for ARM CBAR and > reset-hivecs" v5 patch series > 2. qom-test: add "canon-a1100" to arm machines list > 3. include a diffstat in the cover letter (use --cover-letter option

Re: [Qemu-devel] outlined TLB lookup on x86

2013-12-17 Thread Xin Tong
On Sun, Dec 8, 2013 at 2:54 AM, Xin Tong wrote: > > > > On Thu, Nov 28, 2013 at 8:12 AM, Lluís Vilanova wrote: >> >> Xin Tong writes: >> >> > Hi LIuis >> > we can probably generate vector intrinsics using the tcg, e.g. add >> > support to >> > tcg to emit vector instructions directly in code cach

Re: [Qemu-devel] [Qemu-ppc] [PATCH V3 01/19] Fix float64_to_uint64

2013-12-17 Thread Peter Maydell
On 17 December 2013 13:42, Alexander Graf wrote: > Softfloat really isn't my area of expertise and I'd prefer to see these > patches go in through a different tree :). Peter, do you want to take > care of this patch and "Add float32_to_uint64()"? Or at least give > me your reviewed-by tag and I'll

Re: [Qemu-devel] [PATCH 5/8] s390x/kvm: Implemented SIGP START

2013-12-17 Thread Alexander Graf
On 17.12.2013, at 14:22, Jens Freimann wrote: > From: Thomas Huth > > This patch adds the missing START order to the SIGP instruction handler. Does the spec define what happens on START when the CPU is already running? Does START modify any register state? Alex > > Signed-off-by: Thomas

Re: [Qemu-devel] [qemu-kvm PATCH] block: vhdx - improve error message, and .bdrv_check implementation

2013-12-17 Thread Eric Blake
On 12/17/2013 03:33 AM, Jeff Cody wrote: > If there is a dirty log file to be replayed in a VHDX image, it is > replayed in .vhdx_open(). However, if the file is opened read-only, > then a somewhat cryptic error message results. > > This adds a more helpful error message for the user. If an imag

Re: [Qemu-devel] hindsight on qcow2v3 format

2013-12-17 Thread Stefan Hajnoczi
On Mon, Dec 16, 2013 at 05:24:53PM -0700, Eric Blake wrote: > Is it worth tweaking docs/specs/qcow2.txt to permanently change the > incompatible_features field to be 4 bytes (76-79) and mandate that bytes > 72-75 always be 0, as a conservative way to prevent other misbehavior of > programs like lib

Re: [Qemu-devel] [PATCH 8/8] s390x/ioinst: CHSC has to set a condition code

2013-12-17 Thread Alexander Graf
On 17.12.2013, at 14:22, Jens Freimann wrote: > From: Thomas Huth > > I missed to set the CC in the CHSC instruction when I refactored > the CC setting in the IO instructions with the following commit: > 5d9bf1c07c1369ab3506fc82cc65a10f4415d867 > s390/ioinst: Moved the CC setting t

Re: [Qemu-devel] [Qemu-ppc] [PATCH V3 01/19] Fix float64_to_uint64

2013-12-17 Thread Alexander Graf
On 17.12.2013, at 14:52, Peter Maydell wrote: > On 17 December 2013 13:42, Alexander Graf wrote: >> Softfloat really isn't my area of expertise and I'd prefer to see these >> patches go in through a different tree :). Peter, do you want to take >> care of this patch and "Add float32_to_uint64()

Re: [Qemu-devel] [PATCH] specs: mandate qcow2 v2 end-of-extensions in v3 header

2013-12-17 Thread Stefan Hajnoczi
On Mon, Dec 16, 2013 at 05:52:08PM -0700, Eric Blake wrote: > At least libvirt 0.10.2 has a bug where it can be provoked > into attempting to search for extension headers (in particular, > the backing file format header) without first validating that > a particular file is qcow2 version 2. Fortuna

Re: [Qemu-devel] [PATCH v13 0/6] add allwinner A10 SoC support

2013-12-17 Thread Peter Maydell
On 16 December 2013 02:01, liguang wrote: > lay a foundation for allwinner A10 SoC with a cortex-a8 > processor, and will add more devices later. Thanks; applied all to target-arm.next. -- PMM

Re: [Qemu-devel] [PATCH v10 5/6] hw/arm/digic: add NOR ROM support

2013-12-17 Thread Peter Maydell
On 16 December 2013 10:15, Antony Pavlov wrote: > +static void digic_load_rom(DigicBoardState *s, hwaddr addr, > + hwaddr max_size, const char *def_filename) > +{ > +target_long rom_size; > +const char *filename; > + > +if (bios_name) { > +filename = b

Re: [Qemu-devel] [PATCH v2] block/iscsi: Fix compilation for libiscsi 1.4.0 (API change)

2013-12-17 Thread Stefan Hajnoczi
On Tue, Dec 17, 2013 at 08:57:10AM +0100, Stefan Weil wrote: > Function iscsi_read10_task got additional parameters starting with version > libiscsi 1.5.0. > > libiscsi 1.4.0 is still widely used (Debian wheezy, jessie and other Linux > distributions currently provide packages for QEMU which use i

Re: [Qemu-devel] [PATCH 5/8] s390x/kvm: Implemented SIGP START

2013-12-17 Thread Thomas Huth
Hi Alex, On Tue, 17 Dec 2013 14:56:33 +0100 Alexander Graf wrote: > > On 17.12.2013, at 14:22, Jens Freimann wrote: > > > From: Thomas Huth > > > > This patch adds the missing START order to the SIGP instruction handler. > > Does the spec define what happens on START when the CPU is alre

Re: [Qemu-devel] [PATCH 5/8] s390x/kvm: Implemented SIGP START

2013-12-17 Thread Alexander Graf
On 17.12.2013, at 15:26, Thomas Huth wrote: > > Hi Alex, > > On Tue, 17 Dec 2013 14:56:33 +0100 > Alexander Graf wrote: > >> >> On 17.12.2013, at 14:22, Jens Freimann wrote: >> >>> From: Thomas Huth >>> >>> This patch adds the missing START order to the SIGP instruction handler. >> >>

Re: [Qemu-devel] [PATCH v3 00/13] target-arm: A64 decoder set 2: misc logic and bit ops

2013-12-17 Thread Peter Maydell
On 9 December 2013 12:37, Peter Maydell wrote: > Third revision of the second chunk of A64 decoder patches: > a grabbag of miscellaneous logic and bit-twiddling operations, > plus some other minor stuff like ADR and conditional-select. Applied to target-arm.next since all patches in this set have

[Qemu-devel] [Bug 1261743] [NEW] trace-backend "simple" doesn't support "disable" property of event

2013-12-17 Thread bkantor
Public bug reported: trace-backend "simple" generates wrong eventid in trace/generated- tracers.c after "disable" property occured in trace-events record. Result: missing or mixing logs in trace file. ** Affects: qemu Importance: Undecided Status: New -- You received this bug not

Re: [Qemu-devel] [PATCH v3 00/12] target-arm: A64 decoder, foundation plus branches

2013-12-17 Thread Peter Maydell
On 5 December 2013 12:39, Peter Maydell wrote: > Round three of the first-chunk of A64 decoder work, updated > following code review. Applied to target-arm.next since all patches in this group have now got review. thanks -- PMM

[Qemu-devel] [PATCH 07/21] target-arm: A64: add support for 3 src data proc insns

2013-12-17 Thread Peter Maydell
From: Alexander Graf This patch adds emulation for the "Data-processing (3 source)" family of instructions, namely MADD, MSUB, SMADDL, SMSUBL, SMULH, UMADDL, UMSUBL, UMULH. Signed-off-by: Alexander Graf Signed-off-by: Alex Bennée Signed-off-by: Peter Maydell --- target-arm/translate-a64.c |

[Qemu-devel] [PATCH 02/21] target-arm: A64: add support for ld/st unsigned imm

2013-12-17 Thread Peter Maydell
From: Alex Bennée This adds support for the forms of ld/st with a 12 bit unsigned immediate offset. Signed-off-by: Alex Bennée Signed-off-by: Peter Maydell --- target-arm/translate-a64.c | 89 +- 1 file changed, 88 insertions(+), 1 deletion(-) diff

[Qemu-devel] [PATCH 18/21] target-arm: aarch64: add support for ld lit

2013-12-17 Thread Peter Maydell
From: Alexander Graf Adds support for Load Register (literal), both normal and SIMD/FP forms. Signed-off-by: Alexander Graf Signed-off-by: Alex Bennée Signed-off-by: Peter Maydell --- target-arm/translate-a64.c | 47 -- 1 file changed, 45 insertion

[Qemu-devel] [PATCH 14/21] target-arm: A64: Implement minimal set of EL0-visible sysregs

2013-12-17 Thread Peter Maydell
Implement an initial minimal set of EL0-visible system registers: * NZCV * FPCR * FPSR * CTR_EL0 * DCZID_EL0 Signed-off-by: Peter Maydell --- target-arm/cpu.h | 3 ++- target-arm/helper.c| 58 ++ target-arm/translate-a64.c | 54

Re: [Qemu-devel] [PATCH] qemu will core dump with "-smp 254, , sockets=2, cores=3, threads=2"

2013-12-17 Thread lijun
As Eric and Eduardo's suggestions, use is_power_of_2 to check whether nr_cores and nr_threads is the power of 2 in function x86_apicid_from_cpu_idx in file target-i386/topology.h. This check is very simple, I prefer add it in a function to write a new function. Thanks for Eric and Eduardo. Best

[Qemu-devel] [PATCH 02/38] memory: cpu_physical_memory_set_dirty_flags() result is never used

2013-12-17 Thread Juan Quintela
So return void. Signed-off-by: Juan Quintela Reviewed-by: Orit Wasserman Reviewed-by: Eric Blake --- include/exec/memory-internal.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h index d0e0633..c71a5e6 100

[Qemu-devel] [PATCH v3 00/38] bitmap queue

2013-12-17 Thread Juan Quintela
Hi This is the last version of the bitmap patches, changes from last submission: - cleanups: now it passes checkpatch - all coments from Eric & Paolo addressed - fixed problem with DIRTY_MEMORY_NUM - tested by Vinod and numbers are very good - move bitmap operations to take long as index - round

[Qemu-devel] [PATCH 05/38] memory: create function to set a single dirty bit

2013-12-17 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Orit Wasserman Reviewed-by: Eric Blake --- cputlb.c | 2 +- include/exec/memory-internal.h | 6 ++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/cputlb.c b/cputlb.c index fff0afb..72452e5 100644 --- a/cputlb.c +

  1   2   3   >