Re: [Qemu-devel] [fixed-up][PATCH v5 3/5] hw/intc: add sunxi interrupt controller device

2013-11-27 Thread Li Guang
Peter Crosthwaite wrote: On Wed, Nov 27, 2013 at 4:12 PM, liguang wrote: Signed-off-by: liguang --- default-configs/arm-softmmu.mak |1 + hw/intc/Makefile.objs |1 + hw/intc/sunxi-pic.c | 247 +++ include/hw/intc/sunxi-

Re: [Qemu-devel] [fixed-up][PATCH v5 3/5] hw/intc: add sunxi interrupt controller device

2013-11-27 Thread Peter Crosthwaite
On Wed, Nov 27, 2013 at 5:58 PM, Li Guang wrote: > Peter Crosthwaite wrote: >> >> On Wed, Nov 27, 2013 at 4:12 PM, liguang wrote: >> >>> >>> Signed-off-by: liguang >>> --- >>> default-configs/arm-softmmu.mak |1 + >>> hw/intc/Makefile.objs |1 + >>> hw/intc/sunxi-pic.c

Re: [Qemu-devel] [PATCH] configure: fix ambiguous 'DTC not present' message

2013-11-27 Thread Peter Crosthwaite
On Wed, Nov 27, 2013 at 6:12 PM, Antony Pavlov wrote: > The word "DTC" (device tree compiler) sometimes > sounds ambiguous. > > "DTC not present" sounds like "dt compiler > not present" but QEMU does not need the dt compiler > itself but only libfdt library from DTC distribution. > > The phrase "I

[Qemu-devel] [PATCH v6 4/5] hw/arm: add sunxi machine type

2013-11-27 Thread liguang
Signed-off-by: liguang --- hw/arm/Makefile.objs |1 + hw/arm/sunxi-soc.c | 98 ++ 2 files changed, 99 insertions(+), 0 deletions(-) create mode 100644 hw/arm/sunxi-soc.c diff --git a/hw/arm/Makefile.objs b/hw/arm/Makefile.objs index 3671b4

[Qemu-devel] [PATCH v6 1/5] hw/ptimer: add VMSTATE_PTIMER_ARRAY

2013-11-27 Thread liguang
Signed-off-by: liguang --- include/hw/ptimer.h |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/include/hw/ptimer.h b/include/hw/ptimer.h index 28fcaf1..a9b8f1d 100644 --- a/include/hw/ptimer.h +++ b/include/hw/ptimer.h @@ -27,6 +27,9 @@ void ptimer_stop(ptimer_state *s)

[Qemu-devel] [PATCH v6 2/5] hw/timer: add sunxi timer device

2013-11-27 Thread liguang
Signed-off-by: liguang --- default-configs/arm-softmmu.mak |2 + hw/timer/Makefile.objs |1 + hw/timer/sunxi-pit.c| 252 +++ include/hw/timer/sunxi-pit.h| 56 + 4 files changed, 311 insertions(+), 0 deletions(-) crea

[Qemu-devel] [PATCH v6 0/5] add sunxi machine type

2013-11-27 Thread liguang
this patch-set implemented a device-reduced machine type for Allwinner's sunxi series SoC, like sunxi-4i/5i/7i ... now, It can support sunxi-4i with a cortex-a8 processor. and will support more later, like sunxi-7i with cortex-a7, and will add more devices. v2: split timer and interrupt controll

[Qemu-devel] [PATCH v6 3/5] hw/intc: add sunxi interrupt controller device

2013-11-27 Thread liguang
Signed-off-by: liguang --- default-configs/arm-softmmu.mak |1 + hw/intc/Makefile.objs |1 + hw/intc/sunxi-pic.c | 218 +++ include/hw/intc/sunxi-pic.h | 40 +++ 4 files changed, 260 insertions(+), 0 deletions(-) create

[Qemu-devel] [PATCH v6 5/5] MAINTAINERS: add myself to maintain sunxi machine

2013-11-27 Thread liguang
Signed-off-by: liguang --- MAINTAINERS |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 77edacf..232e1a1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -284,6 +284,15 @@ M: Peter Maydell S: Maintained F: hw/*/stellaris* +Sunxi +M

Re: [Qemu-devel] [PATCH v6 0/5] add sunxi machine type

2013-11-27 Thread Peter Crosthwaite
Hi Liguang, On Wed, Nov 27, 2013 at 6:23 PM, liguang wrote: > this patch-set implemented a device-reduced > machine type for Allwinner's sunxi series SoC, > like sunxi-4i/5i/7i ... > > now, It can support sunxi-4i with a cortex-a8 processor. > and will support more later, like sunxi-7i with corte

[Qemu-devel] [fixed-up][PATCH v6 2/5] hw/timer: add sunxi timer device

2013-11-27 Thread liguang
Signed-off-by: liguang --- default-configs/arm-softmmu.mak |2 + hw/timer/Makefile.objs |1 + hw/timer/sunxi-pit.c| 254 +++ include/hw/timer/sunxi-pit.h| 56 + 4 files changed, 313 insertions(+), 0 deletions(-) crea

Re: [Qemu-devel] [PATCH v6 0/5] add sunxi machine type

2013-11-27 Thread Li Guang
Peter Crosthwaite wrote: Hi Liguang, On Wed, Nov 27, 2013 at 6:23 PM, liguang wrote: this patch-set implemented a device-reduced machine type for Allwinner's sunxi series SoC, like sunxi-4i/5i/7i ... now, It can support sunxi-4i with a cortex-a8 processor. and will support more later, lik

[Qemu-devel] [PATCH arm-devs v1 0/6] Fix Support for ARM A9 CBAR

2013-11-27 Thread Peter Crosthwaite
Hi Peter, This patch series fixed the Configuration base address init logic for ARM CPUs, most notably for A9. Fixes both Zynq and Highbank which both hade broken CBAR. Regards, Peter Peter Crosthwaite (6): target-arm: Define and use ARM_FEATURE_CBAR target-arm/cpu: Convert reset CBAR to a

[Qemu-devel] [PATCH arm-devs v1 1/6] target-arm: Define and use ARM_FEATURE_CBAR

2013-11-27 Thread Peter Crosthwaite
Some processors (notably A9 within Highbank) define and use the CP15 configuration base address (CBAR). This is vendor specific so its best implemented as a CPU property (otherwise we would need vendor specific child classes for every ARM implementation). This patch prepares support for converting

[Qemu-devel] [PATCH arm-devs v1 2/6] target-arm/cpu: Convert reset CBAR to a property

2013-11-27 Thread Peter Crosthwaite
The reset Value of the CP15 CBAR is a vendor (machine) configurable property. Define arm_cpu_properties and add it. Signed-off-by: Peter Crosthwaite --- target-arm/cpu.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/target-arm/cpu.c b/target-arm/cpu.c index a82fa61..f1c5f6b 100644

[Qemu-devel] [PATCH arm-devs v1 3/6] arm/highbank: Use object_new() rather than cpu_arm_init()

2013-11-27 Thread Peter Crosthwaite
To allow the machine model to set device properties before CPU realization. Signed-off-by: Peter Crosthwaite --- hw/arm/highbank.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/hw/arm/highbank.c b/hw/arm/highbank.c index fe98ef1..70831ba 100644 --- a/hw/arm/

[Qemu-devel] [PATCH arm-devs v1 4/6] arm/highbank: Fix CBAR intialisation

2013-11-27 Thread Peter Crosthwaite
Fix the CBAR initialisation by using the newly defined static property. CBAR is now set before realization, so the intended value is now actually used. So I have kinda tested this. I booted an ARM kernel on Highbank with the stock Highbank DTB. It doesnt boot (and I will be doing something wrong),

[Qemu-devel] [PATCH arm-devs v1 6/6] arm/xilinx_zynq: Implement CBAR intialisation

2013-11-27 Thread Peter Crosthwaite
Fix the CBAR initialisation by using the newly defined static property. Zynq will now correctly init the CBAR to the SCU base address. Needed to boot Linux on the xilinx_zynq machine model. Signed-off-by: Peter Crosthwaite --- hw/arm/xilinx_zynq.c | 9 - 1 file changed, 8 insertions(+)

[Qemu-devel] [PATCH arm-devs v1 5/6] arm/xilinx_zynq: Use object_new() rather than cpu_arm_init()

2013-11-27 Thread Peter Crosthwaite
To allow the machine model to set device properties before CPU realization. Signed-off-by: Peter Crosthwaite --- hw/arm/xilinx_zynq.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c index 46924a0..b4553e8 100644 --- a/h

Re: [Qemu-devel] [PATCH arm-devs v1 3/6] arm/highbank: Use object_new() rather than cpu_arm_init()

2013-11-27 Thread Peter Maydell
On 27 November 2013 09:02, Peter Crosthwaite wrote: > To allow the machine model to set device properties before CPU > realization. > > Signed-off-by: Peter Crosthwaite > --- > > hw/arm/highbank.c | 13 ++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/hw/arm/high

Re: [Qemu-devel] [PATCH arm-devs v1 2/6] target-arm/cpu: Convert reset CBAR to a property

2013-11-27 Thread Peter Maydell
On 27 November 2013 09:01, Peter Crosthwaite wrote: > The reset Value of the CP15 CBAR is a vendor (machine) configurable > property. Define arm_cpu_properties and add it. > > Signed-off-by: Peter Crosthwaite > --- > > target-arm/cpu.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --gi

Re: [Qemu-devel] [PATCH v4 3/4] hw/arm: add sunxi machine type

2013-11-27 Thread Andreas Färber
Hi, Am 26.11.2013 10:22, schrieb Peter Crosthwaite: > On Tue, Nov 26, 2013 at 5:22 PM, liguang wrote: >> Signed-off-by: liguang >> --- >> hw/arm/Makefile.objs |1 + >> hw/arm/sunxi-soc.c | 98 >> ++ >> 2 files changed, 99 insertions(+), 0

Re: [Qemu-devel] [PATCH v4 3/4] hw/arm: add sunxi machine type

2013-11-27 Thread Andreas Färber
Am 27.11.2013 10:22, schrieb Andreas Färber: > Hi, > > Am 26.11.2013 10:22, schrieb Peter Crosthwaite: >> On Tue, Nov 26, 2013 at 5:22 PM, liguang wrote: >>> Signed-off-by: liguang >>> --- >>> hw/arm/Makefile.objs |1 + >>> hw/arm/sunxi-soc.c | 98 >>> ++

Re: [Qemu-devel] [PATCHv2] qdev: Validate hex properties

2013-11-27 Thread Andreas Färber
Am 27.11.2013 08:52, schrieb Hannes Reinecke: > strtoul(l) might overflow, in which case it'll return '-1' and set > the appropriate error code. So update the calls to strtoul(l) when > parsing hex properties to avoid silent overflows. > > Cc: Peter Maydell > Cc: Eric Blake > Signed-off-by: Hann

Re: [Qemu-devel] [PATCH for-1.7 0/2] block/drive-mirror: Reuse backing HD for sync=none

2013-11-27 Thread Kevin Wolf
Am 26.11.2013 um 19:02 hat Anthony Liguori geschrieben: > Max Reitz writes: > > > This series fixes the drive-mirror blockjob in case of "none" sync mode > > to always use the old (current) image file as the backing file of the > > newly created mirrored file (in case of "absolute-paths" mode). >

Re: [Qemu-devel] [PATCH arm-devs v1 2/6] target-arm/cpu: Convert reset CBAR to a property

2013-11-27 Thread Andreas Färber
Am 27.11.2013 10:14, schrieb Peter Maydell: > On 27 November 2013 09:01, Peter Crosthwaite > wrote: >> The reset Value of the CP15 CBAR is a vendor (machine) configurable >> property. Define arm_cpu_properties and add it. >> >> Signed-off-by: Peter Crosthwaite >> --- >> >> target-arm/cpu.c | 7 +

Re: [Qemu-devel] [PATCH 16/27] acpi: ich9: allow guest to clear SCI rised by GPE

2013-11-27 Thread Paolo Bonzini
Il 27/11/2013 02:48, Li Guang ha scritto: > I am never going say EC is deemed to be simpler or better, > for me, it's just flexible. I think it's entirely the same. Instead of the I/O address space you would use EC OperationRegions, instead of _Exx you would use _Qxx. If we had an embedded cont

Re: [Qemu-devel] [PATCH arm-devs v1 3/6] arm/highbank: Use object_new() rather than cpu_arm_init()

2013-11-27 Thread Andreas Färber
Am 27.11.2013 10:10, schrieb Peter Maydell: > On 27 November 2013 09:02, Peter Crosthwaite > wrote: >> To allow the machine model to set device properties before CPU >> realization. >> >> Signed-off-by: Peter Crosthwaite >> --- >> >> hw/arm/highbank.c | 13 ++--- >> 1 file changed, 10 in

Re: [Qemu-devel] [PATCH v2 2/2] full introspection support for QMP

2013-11-27 Thread Kevin Wolf
Am 27.11.2013 um 03:32 hat Amos Kong geschrieben: > On Fri, Jul 19, 2013 at 04:05:16PM -0600, Eric Blake wrote: > > On 07/16/2013 04:37 AM, Amos Kong wrote: > > > { 'type': 'DataObject', > > > 'data': { '*key': 'str', '*type': 'str', '*data': ['DataObject'] } } > > > > > > Not all the keys in da

Re: [Qemu-devel] [RFC PATCH v2 5/6] qcow2: implement bdrv_preallocate

2013-11-27 Thread Peter Lieven
Am 27.11.2013 07:40, schrieb Fam Zheng: > On 2013年11月27日 14:01, Hu Tao wrote: >> On Wed, Nov 27, 2013 at 11:01:23AM +0800, Fam Zheng wrote: >>> On 2013年11月27日 10:15, Hu Tao wrote: Signed-off-by: Hu Tao --- block/qcow2.c | 7 +++ 1 file changed, 7 insertions(+)

[Qemu-devel] [PATCHv3 1.8 2/9] qemu-img: fix usage instruction for qemu-img convert

2013-11-27 Thread Peter Lieven
Reviewed-by: Eric Blake Reviewed-by: Paolo Bonzini Signed-off-by: Peter Lieven --- qemu-img.c |1 - 1 file changed, 1 deletion(-) diff --git a/qemu-img.c b/qemu-img.c index 49a123b..0c2e557 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -105,7 +105,6 @@ static void help(void) "

[Qemu-devel] [PATCHv3 1.8 3/9] block/iscsi: set bdi->cluster_size

2013-11-27 Thread Peter Lieven
this patch aims to set bdi->cluster_size to the internal page size of the iscsi target so that enabled callers can align requests properly. Reviewed-by: Paolo Bonzini Signed-off-by: Peter Lieven --- block/iscsi.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/block/iscsi.c b/bloc

[Qemu-devel] [PATCHv3 1.8 1/9] qemu-img: add support for skipping zeroes in input during convert

2013-11-27 Thread Peter Lieven
we currently do not check if a sector is allocated during convert. This means if a sector is unallocated that we allocate a bounce buffer of zeroes, find out its zero later and do not write it in the best case. In the worst case this can lead to reading blocks from a raw device (like iSCSI) altough

[Qemu-devel] [PATCHv3 1.8 4/9] block: add opt_transfer_length to BlockLimits

2013-11-27 Thread Peter Lieven
Reviewed-by: Paolo Bonzini Signed-off-by: Peter Lieven --- include/block/block_int.h |3 +++ 1 file changed, 3 insertions(+) diff --git a/include/block/block_int.h b/include/block/block_int.h index 95140b6..a09f1b5 100644 --- a/include/block/block_int.h +++ b/include/block/block_int.h @@ -2

[Qemu-devel] [PATCHv3 1.8 0/9] qemu-img convert optimizations

2013-11-27 Thread Peter Lieven
this series adds some optimizations for qemu-img during convert which have been developed recently: - skipping input based on get_block_status - variable I/O buffer size - align write requests to cluster_size v2->v3: - added Paolos comments in Patch 1 - changed the comment in patch 7 [Paolo]

[Qemu-devel] [PATCHv3 1.8 8/9] qemu-img: increase min_sparse to 128 sectors (64kb)

2013-11-27 Thread Peter Lieven
Suggested-by: Paolo Bonzini Reviewed-by: Paolo Bonzini Signed-off-by: Peter Lieven --- qemu-img.c|4 ++-- qemu-img.texi |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 9bb1f6f..8b5f3da 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -1

[Qemu-devel] [PATCHv3 1.8 7/9] qemu-img: round down request length to an aligned sector

2013-11-27 Thread Peter Lieven
this patch shortens requests to end at an aligned sector so that the next request starts aligned. Reviewed-by: Paolo Bonzini Signed-off-by: Peter Lieven --- qemu-img.c | 34 -- 1 file changed, 24 insertions(+), 10 deletions(-) diff --git a/qemu-img.c b/qemu-im

[Qemu-devel] [PATCHv3 1.8 6/9] qemu-img: dynamically adjust iobuffer size during convert

2013-11-27 Thread Peter Lieven
since the convert process is basically a sync operation it might be benificial in some case to change the hardcoded I/O buffer size to a greater value. This patch increases the I/O buffer size if the output driver advertises an optimal transfer length or discard alignment that is greater than the

[Qemu-devel] [PATCHv3 1.8 9/9] qemu-img: decrease progress update interval on convert

2013-11-27 Thread Peter Lieven
when doing very large jobs updating the progress only every 2% is too rare. Signed-off-by: Peter Lieven --- qemu-img.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-img.c b/qemu-img.c index 8b5f3da..be72274 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -1227,7 +1227,7

[Qemu-devel] [PATCHv3 1.8 5/9] block/iscsi: set bs->bl.opt_transfer_length

2013-11-27 Thread Peter Lieven
Reviewed-by: Paolo Bonzini Signed-off-by: Peter Lieven --- block/iscsi.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index 75d6b87..829d444 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -1457,6 +1457,9 @@ static int iscsi_open(BlockDriverState *bs,

[Qemu-devel] [RFC] allow special paths for libusbx

2013-11-27 Thread Erik Rull
Hi all, I don't have libusbx installed on my system but the source package is available and compiled for development. This may also help other users to enable the libusbx support without having it actually installed on the compile machine. It's a first attempt, feel free to optimize it. I would b

Re: [Qemu-devel] [RFC PATCH v2 5/6] qcow2: implement bdrv_preallocate

2013-11-27 Thread Fam Zheng
On 2013年11月27日 18:03, Peter Lieven wrote: Am 27.11.2013 07:40, schrieb Fam Zheng: On 2013年11月27日 14:01, Hu Tao wrote: On Wed, Nov 27, 2013 at 11:01:23AM +0800, Fam Zheng wrote: On 2013年11月27日 10:15, Hu Tao wrote: Signed-off-by: Hu Tao --- block/qcow2.c | 7 +++ 1 file changed, 7 ins

Re: [Qemu-devel] [RFC PATCH v2 5/6] qcow2: implement bdrv_preallocate

2013-11-27 Thread Peter Lieven
Am 27.11.2013 11:07, schrieb Fam Zheng: > On 2013年11月27日 18:03, Peter Lieven wrote: >> Am 27.11.2013 07:40, schrieb Fam Zheng: >>> On 2013年11月27日 14:01, Hu Tao wrote: On Wed, Nov 27, 2013 at 11:01:23AM +0800, Fam Zheng wrote: > On 2013年11月27日 10:15, Hu Tao wrote: >> Signed-off-by: Hu T

Re: [Qemu-devel] [RFC] allow special paths for libusbx

2013-11-27 Thread Paolo Bonzini
Il 27/11/2013 11:09, Erik Rull ha scritto: > I don't have libusbx installed on my system but the source package is > available > and compiled for development. > This may also help other users to enable the libusbx support without having it > actually installed on the compile machine. > > It's a f

Re: [Qemu-devel] [PATCH arm-devs v1 2/6] target-arm/cpu: Convert reset CBAR to a property

2013-11-27 Thread Peter Maydell
On 27 November 2013 09:42, Andreas Färber wrote: > If we turn it into a dynamic property, we could register it conditional > to ARM_FEATURE_CBAR. Unfortunately feature flags only get set at realize (in the per-cpu init function), so we don't know at the point where we're registering properties wh

[Qemu-devel] Linux multiqueue block layer thoughts

2013-11-27 Thread Stefan Hajnoczi
I finally got around to reading the Linux multiqueue block layer paper and wanted to share some thoughts about how it relates to QEMU and dataplane/QContext: http://kernel.dk/blk-mq.pdf I think Jens has virtio-blk multiqueue patches. So let's imagine that the virtio-blk device has multiple virtqu

Re: [Qemu-devel] [PATCHv3 1.8 1/9] qemu-img: add support for skipping zeroes in input during convert

2013-11-27 Thread Paolo Bonzini
Il 27/11/2013 11:07, Peter Lieven ha scritto: > we currently do not check if a sector is allocated during convert. > This means if a sector is unallocated that we allocate a bounce > buffer of zeroes, find out its zero later and do not write it > in the best case. In the worst case this can lead to

Re: [Qemu-devel] [RFC] allow special paths for libusbx

2013-11-27 Thread Erik Rull
> On November 27, 2013 at 11:14 AM Paolo Bonzini wrote: > > > Il 27/11/2013 11:09, Erik Rull ha scritto: > > I don't have libusbx installed on my system but the source package is > > available > > and compiled for development. > > This may also help other users to enable the libusbx support withou

Re: [Qemu-devel] [RFC] allow special paths for libusbx

2013-11-27 Thread Daniel P. Berrange
On Wed, Nov 27, 2013 at 11:09:19AM +0100, Erik Rull wrote: > Hi all, > > I don't have libusbx installed on my system but the source package is > available > and compiled for development. > This may also help other users to enable the libusbx support without having it > actually installed on the c

Re: [Qemu-devel] [PATCH arm-devs v1 2/6] target-arm/cpu: Convert reset CBAR to a property

2013-11-27 Thread Andreas Färber
Am 27.11.2013 11:15, schrieb Peter Maydell: > On 27 November 2013 09:42, Andreas Färber wrote: >> If we turn it into a dynamic property, we could register it conditional >> to ARM_FEATURE_CBAR. > > Unfortunately feature flags only get set at realize (in the > per-cpu init function), so we don't k

Re: [Qemu-devel] [PATCH arm-devs v1 2/6] target-arm/cpu: Convert reset CBAR to a property

2013-11-27 Thread Peter Maydell
On 27 November 2013 10:27, Andreas Färber wrote: > Am 27.11.2013 11:15, schrieb Peter Maydell: >> On 27 November 2013 09:42, Andreas Färber wrote: >>> If we turn it into a dynamic property, we could register it conditional >>> to ARM_FEATURE_CBAR. >> >> Unfortunately feature flags only get set at

Re: [Qemu-devel] [RFC] allow special paths for libusbx

2013-11-27 Thread Paolo Bonzini
Il 27/11/2013 11:24, Erik Rull ha scritto: > no I have no libusbx installed. I just downloaded the tar.bz2, unpacked it, > configure'd it and called make. I think your patch wouldn't be enough to actually run QEMU, because the path to libusbx.so is not in LD_LIBRARY_PATH (and if you can change LD_

Re: [Qemu-devel] [PATCH 46/60] e1000: Discard oversized packets based on SBP|LPE

2013-11-27 Thread Amos Kong
On Mon, Feb 04, 2013 at 02:40:56PM +0400, Michael Tokarev wrote: > From: Michael Contreras > > Discard packets longer than 16384 when !SBP to match the hardware behavior. > > Signed-off-by: Michael Contreras > Signed-off-by: Stefan Hajnoczi > (cherry picked from commit 2c0331f4f7d241995452b99a

Re: [Qemu-devel] [PATCH] qcow2: Zero-initialise first cluster for new images

2013-11-27 Thread Paolo Bonzini
Il 26/11/2013 11:48, Kevin Wolf ha scritto: > Strictly speaking, this is only required for has_zero_init() == false, > but it's easy enough to just do a cluster-aligned write that is padded > with zeros after the header. > > This fixes that after 'qemu-img create' header extensions are attempted >

Re: [Qemu-devel] [PATCH v2 19/19] bsd-user: fix linking conflicts with FreeBSD libcrypto

2013-11-27 Thread Paolo Bonzini
Il 08/11/2013 17:33, Stacey Son ha scritto: > FreeBSD has it's own AES_set_decrypt_key, etc. in libcrypto. This > change fixes these conflicts and allows statically linking BSD > user mode qemu. > > Signed-off-by: Stacey Son > --- > include/qemu/aes.h |9 + > 1 files changed, 9 inse

Re: [Qemu-devel] [PATCH v2 02/19] bsd-user: add HOST_ABI_DIR for the various *BSD dependent code.

2013-11-27 Thread Paolo Bonzini
Il 08/11/2013 17:33, Stacey Son ha scritto: > This change adds HOST_ABI_DIR (similar to TARGET_ABI_DIR) so the various > BSD OS dependent code can be seperated into its own directories rather > than using #ifdef's. I would say this is not exactly an ABI, so it would be better to call it HOST_VARIA

Re: [Qemu-devel] [PATCH v2 14/19] bsd-user: add support for thread related system calls

2013-11-27 Thread Paolo Bonzini
Il 08/11/2013 17:33, Stacey Son ha scritto: > diff --git a/include/qemu/tls.h b/include/qemu/tls.h > index b92ea9d..ae7d79d 100644 > --- a/include/qemu/tls.h > +++ b/include/qemu/tls.h > @@ -38,7 +38,7 @@ > * TODO: proper implementations via Win32 .tls sections and > * POSIX pthread_getspecific

Re: [Qemu-devel] [PATCH v2 00/19] bsd-user: Add system call and mips/arm support.

2013-11-27 Thread Paolo Bonzini
Il 26/11/2013 22:01, Ed Maste ha scritto: > On 8 November 2013 11:33, Stacey Son wrote: >> [v2] >> >> - Rebases to 1.7.0-rc0. (Requires, however, Andreas Tobler's patch to >> build: see >> http://lists.nongnu.org/archive/html/qemu-devel/2013-11/msg0.html) >> - Fixes deadlock in the _umtx_o

Re: [Qemu-devel] [PATCH 1/2] vmdk: Allow read only open of VMDK version 3

2013-11-27 Thread Paolo Bonzini
Il 27/11/2013 03:06, Fam Zheng ha scritto: > +} else if (le32_to_cpu(header.version) == 3 && flags & BDRV_O_RDWR) { Parentheses around "flags & BDRV_O_RDWR", please. I'll try to patch checkpatch.pl to flag this. Paolo > +error_setg(errp, "VMDK version 3 must be read only"); > +

Re: [Qemu-devel] [RFC] allow special paths for libusbx

2013-11-27 Thread Erik Rull
> On November 27, 2013 at 11:38 AM Paolo Bonzini wrote: > > > Il 27/11/2013 11:24, Erik Rull ha scritto: > > no I have no libusbx installed. I just downloaded the tar.bz2, unpacked it, > > configure'd it and called make. > > I think your patch wouldn't be enough to actually run QEMU, because the >

Re: [Qemu-devel] [PATCH 46/60] e1000: Discard oversized packets based on SBP|LPE

2013-11-27 Thread Amos Kong
On Wed, Nov 27, 2013 at 07:14:30PM +0800, Amos Kong wrote: > On Mon, Feb 04, 2013 at 02:40:56PM +0400, Michael Tokarev wrote: > > From: Michael Contreras > > > > Discard packets longer than 16384 when !SBP to match the hardware behavior. > > > > Signed-off-by: Michael Contreras > > Signed-off-b

Re: [Qemu-devel] [PATCH arm-devs v1 2/6] target-arm/cpu: Convert reset CBAR to a property

2013-11-27 Thread Peter Crosthwaite
Hi Andreas, On Wed, Nov 27, 2013 at 8:27 PM, Andreas Färber wrote: > Am 27.11.2013 11:15, schrieb Peter Maydell: >> On 27 November 2013 09:42, Andreas Färber wrote: >>> If we turn it into a dynamic property, we could register it conditional >>> to ARM_FEATURE_CBAR. >> >> Unfortunately feature fl

Re: [Qemu-devel] [PATCH arm-devs v1 2/6] target-arm/cpu: Convert reset CBAR to a property

2013-11-27 Thread Peter Maydell
On 27 November 2013 11:39, Peter Crosthwaite wrote: > Is the "periphbase" ever runtime configurable? If not I'm not sure we > need the "reset". You can't runtime configure it (it's a bunch of signals into the core that determine where the decoder sits the peripherals in the memory map). However,

Re: [Qemu-devel] [PATCH] piix: fix 32bit pci hole

2013-11-27 Thread Laszlo Ersek
On 11/27/13 07:46, Gerd Hoffmann wrote: > >>> +i440fx->pci_info.w32.begin = ram_size; > >> But this patch also obliterates the high bound, 0xe000, which can >> lead to: >> - w32.end - w32.begin <= 512M, or >> - a special case of the former, w32.end < w32.begin. > > ram_size is not the to

[Qemu-devel] [PATCH v2] piix: fix 32bit pci hole

2013-11-27 Thread Gerd Hoffmann
Make the 32bit pci hole start at end of ram, so all possible address space is covered. Of course the firmware can use less than that. Leaving space unused is no problem, mapping pci bars outside the hole causes problems though. Signed-off-by: Gerd Hoffmann --- hw/pci-host/piix.c | 10 +-

Re: [Qemu-devel] [RFC qom-cpu v4 09/10] piix4: implement function cpu_status_write() for vcpu ejection

2013-11-27 Thread Chen Fan
On Mon, 2013-11-25 at 19:38 +0100, Vasilis Liaskovitis wrote: > On Fri, Nov 22, 2013 at 09:02:27AM +0100, Vasilis Liaskovitis wrote: > > Hi, > > > > On Wed, Oct 09, 2013 at 05:43:17PM +0800, Chen Fan wrote: > > > When OS eject a vcpu (like: echo 1 > > > > /sys/bus/acpi/devices/LNXCPUXX/eject), >

Re: [Qemu-devel] [PATCH v2] piix: fix 32bit pci hole

2013-11-27 Thread Laszlo Ersek
On 11/27/13 12:57, Gerd Hoffmann wrote: > Make the 32bit pci hole start at end of ram, so all possible address > space is covered. Of course the firmware can use less than that. > Leaving space unused is no problem, mapping pci bars outside the > hole causes problems though. > > Signed-off-by: Ge

Re: [Qemu-devel] [Qemu-stable] [PATCH] qcow2: Zero-initialise first cluster for new images

2013-11-27 Thread Kevin Wolf
Am 26.11.2013 um 13:18 hat Fam Zheng geschrieben: > On 2013年11月26日 18:48, Kevin Wolf wrote: > >Strictly speaking, this is only required for has_zero_init() == false, > >but it's easy enough to just do a cluster-aligned write that is padded > >with zeros after the header. > > > >This fixes that afte

Re: [Qemu-devel] [PATCHv2] qdev: Validate hex properties

2013-11-27 Thread Eric Blake
On 11/27/2013 12:52 AM, Hannes Reinecke wrote: > strtoul(l) might overflow, in which case it'll return '-1' and set > the appropriate error code. So update the calls to strtoul(l) when > parsing hex properties to avoid silent overflows. > > Cc: Peter Maydell > Cc: Eric Blake > Signed-off-by: Han

[Qemu-devel] [RFC PATCH v2] i386: Add _PXM ACPI method to CPU objects

2013-11-27 Thread Vasilis Liaskovitis
This patch adds a _PXM method to ACPI CPU objects for the pc machine. The _PXM value is derived from the passed in guest info, same way as CPU SRAT entries. Currently, CPU SRAT entries are only enabled for cpus that are already present in the system. The SRAT entries for hotpluggable processors ar

[Qemu-devel] [Bug 1253777] Re: OpenBSD VM running on OpenBSD host has sleep calls taking twice as long as they should

2013-11-27 Thread Paolo Bonzini
Hi, please test qemu 1.7.0-rc. There were several changes to the timer machinery that can help this bug. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1253777 Title: OpenBSD VM running on OpenBSD

[Qemu-devel] [Bug 1100843] Re: Live Migration Causes Performance Issues

2013-11-27 Thread Paolo Bonzini
Fix will be part of QEMU 1.7.0 (commit fc1c4a5, migration: drop MADVISE_DONT_NEED for incoming zero pages, 2013-10-24). ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://

Re: [Qemu-devel] [PATCH v2 0/3] Device tree cleanups

2013-11-27 Thread Peter Crosthwaite
Ping! On Mon, Nov 11, 2013 at 6:14 PM, wrote: > From: Peter Crosthwaite > > Fix the name stem of the devicetree API (P1 - s/qemu_devtree/qemu_fdt) > and cleanup error report (P3). Trivial patch P2 fixing an arugment name > along the way. > > Tested using: > > 1: Alex's e500 test vector. > 2: Xi

[Qemu-devel] [Bug 659351] Re: QEMU uses obsolete gethostbyname and inet_aton rather than getaddrinfo

2013-11-27 Thread Paolo Bonzini
Fixed by commit d5c5dac (use inet_listen()/inet_connect() to support ipv6 migration, 2012-05-11), released with QEMU 1.2. ** Changed in: qemu Status: In Progress => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH arm-devs v1 2/6] target-arm/cpu: Convert reset CBAR to a property

2013-11-27 Thread Andreas Färber
Hi, Am 27.11.2013 12:39, schrieb Peter Crosthwaite: > On Wed, Nov 27, 2013 at 8:27 PM, Andreas Färber wrote: >> Am 27.11.2013 11:15, schrieb Peter Maydell: >>> On 27 November 2013 09:42, Andreas Färber wrote: If we turn it into a dynamic property, we could register it conditional to AR

Re: [Qemu-devel] outlined TLB lookup on x86

2013-11-27 Thread Lluís Vilanova
Xin Tong writes: > I am trying to implement a out-of-line TLB lookup for QEMU softmmu-x86-64 on > x86-64 machine, potentially for better instruction cache performance, I have a > few questions. > 1. I see that tcg_out_qemu_ld_slow_path/tcg_out_qemu_st_slow_path are > generated > when tcg_out_tb_

[Qemu-devel] Win 8 Driver for QEMU USB Hub?

2013-11-27 Thread Erik Rull
Hi all, is there a Windows driver for the QEMU USB Hub that gets created automagically when exposing more than 5 USB host ports to QEMU? I didn't find something that fits my needs. The device is listed with an exclamation mark in Windows 8. Thanks. Best regards, Erik

Re: [Qemu-devel] [RFC] allow special paths for libusbx

2013-11-27 Thread Erik Rull
> On November 27, 2013 at 11:38 AM Paolo Bonzini wrote: > > > Il 27/11/2013 11:24, Erik Rull ha scritto: > > no I have no libusbx installed. I just downloaded the tar.bz2, unpacked it, > > configure'd it and called make. > > I think your patch wouldn't be enough to actually run QEMU, because the >

Re: [Qemu-devel] [fixed-up][PATCH v6 2/5] hw/timer: add sunxi timer device

2013-11-27 Thread Peter Crosthwaite
On Wed, Nov 27, 2013 at 6:29 PM, liguang wrote: > Signed-off-by: liguang > --- > default-configs/arm-softmmu.mak |2 + > hw/timer/Makefile.objs |1 + > hw/timer/sunxi-pit.c| 254 > +++ > include/hw/timer/sunxi-pit.h| 56 +++

Re: [Qemu-devel] [qemu PATCH] hw/i386/pc_sysfw: support more than one flash drive

2013-11-27 Thread Markus Armbruster
Laszlo Ersek writes: > On 11/26/13 13:53, Markus Armbruster wrote: > >> Thus, we grab *all* if=pflash drives for this purpose. >> >> Your stated use case wants just two. >> >> Hmm. Are we sure we'll never want to map an if=pflash device somewhere >> else? > > No, I'm not sure. Perhaps grabbin

Re: [Qemu-devel] [qemu PATCH] hw/i386/pc_sysfw: support more than one flash drive

2013-11-27 Thread Markus Armbruster
Jordan Justen writes: > On Tue, Nov 26, 2013 at 5:32 AM, Laszlo Ersek wrote: >> On 11/26/13 13:36, Markus Armbruster wrote: >> >>> Your stated purpose for multiple -pflash: >>> >>> This accommodates the following use case: suppose that OVMF is split in >>> two parts, a writeable host fil

Re: [Qemu-devel] [qemu PATCH] hw/i386/pc_sysfw: support more than one flash drive

2013-11-27 Thread Laszlo Ersek
On 11/27/13 14:52, Markus Armbruster wrote: > Jordan Justen writes: > >> On Tue, Nov 26, 2013 at 5:32 AM, Laszlo Ersek wrote: >>> On 11/26/13 13:36, Markus Armbruster wrote: >>> Your stated purpose for multiple -pflash: This accommodates the following use case: suppose that OV

Re: [Qemu-devel] [qemu PATCH] hw/i386/pc_sysfw: support more than one flash drive

2013-11-27 Thread Laszlo Ersek
On 11/27/13 14:49, Markus Armbruster wrote: > Laszlo Ersek writes: > >> On 11/26/13 13:53, Markus Armbruster wrote: >> >>> Thus, we grab *all* if=pflash drives for this purpose. >>> >>> Your stated use case wants just two. >>> >>> Hmm. Are we sure we'll never want to map an if=pflash device some

Re: [Qemu-devel] [PATCH 05/27] qapi: add SIZE type parser to string_input_visitor

2013-11-27 Thread Markus Armbruster
Eric Blake writes: > On 11/25/2013 09:32 AM, Paolo Bonzini wrote: > >>> Yes please. Firing up a calculator to figure out how much is 1G is not >>> friendly, neither is firing it up to figure out what did management do >>> with QMP. It should be a text based interface not a binary one. > > Right n

Re: [Qemu-devel] console muti-head some more design input

2013-11-27 Thread John Baboval
On 11/26/2013 11:29 PM, Dave Airlie wrote: On Fri, Nov 22, 2013 at 6:41 PM, Gerd Hoffmann wrote: Hi, While thinking about this: A completely different approach to tackle this would be to implement touchscreen emulation. So we don't have a single usb-tablet, but multiple (one per display)

Re: [Qemu-devel] [RFC qom-cpu v4 05/10] qmp: add 'cpu-del' command support

2013-11-27 Thread Eric Blake
On 10/09/2013 03:43 AM, Chen Fan wrote: > Signed-off-by: Chen Fan > --- > hw/i386/pc.c | 6 ++ > hw/i386/pc_piix.c| 3 ++- > include/hw/boards.h | 2 ++ > include/hw/i386/pc.h | 1 + > qapi-schema.json | 12 > qmp-commands.hx | 23 +++

Re: [Qemu-devel] [PATCH V16 09/11] NUMA: set guest numa nodes memory policy

2013-11-27 Thread Paolo Bonzini
Il 22/11/2013 03:08, Wanlong Gao ha scritto: > +static int set_node_mem_policy(int nodeid) > +{ > +#ifdef __linux__ > +void *ram_ptr; > +RAMBlock *block; > +ram_addr_t len, ram_offset = 0; > +int bind_mode; > +int i; > + > +QTAILQ_FOREACH(block, &ram_list.blocks, next) { > +

[Qemu-devel] [Bug 1038136] Re: lack of keycode 89 for br-abnt2 keyboards

2013-11-27 Thread rslemos
I've managed to resolve it applying the following patch (without "-k pt- br"): --- qemu-1.6.0+dfsg.orig/ui/x_keymap.c +++ qemu-1.6.0+dfsg/ui/x_keymap.c @@ -94,7 +94,7 @@ static const uint8_t x_keycode_to_pc_key */ static const uint8_t evdev_keycode_to_pc_keycode[61] = { -0, /* 97

Re: [Qemu-devel] [PATCH 07/27] add memdev backend infrastructure

2013-11-27 Thread Igor Mammedov
On Mon, 25 Nov 2013 17:09:37 +0100 Paolo Bonzini wrote: > Il 25/11/2013 17:01, Igor Mammedov ha scritto: > >> > So this is why you need a new command-line option. > >> > > >> > I think we need a generic mechanism for post-initialization of whatever > >> > is given on the command line. Perhaps y

Re: [Qemu-devel] [qemu PATCH] hw/i386/pc_sysfw: support more than one flash drive

2013-11-27 Thread Markus Armbruster
Laszlo Ersek writes: > On 11/27/13 14:52, Markus Armbruster wrote: >> Jordan Justen writes: >> >>> On Tue, Nov 26, 2013 at 5:32 AM, Laszlo Ersek wrote: On 11/26/13 13:36, Markus Armbruster wrote: > Your stated purpose for multiple -pflash: > > This accommodates the fo

[Qemu-devel] [Bug 1038136] Re: lack of keycode 89 for br-abnt2 keyboards

2013-11-27 Thread rslemos
Attached patch (may not apply cleanly as I edited it manually to correct for space alignment; but c'mon, it is so straight forward). ** Patch added: "Proposed patch" https://bugs.launchpad.net/qemu/+bug/1038136/+attachment/3918380/+files/abnt2.patch -- You received this bug notification beca

[Qemu-devel] Changed host CPU from Core2Duo to Core i3 or i5 => Windows 8 reboots infinitely

2013-11-27 Thread Erik Rull
Hi all, I have the following qemu commandline on an i3 or i5 CPU (both behave the same), Windows XP (Standard PC installation) runs fine, Windows 7 and Windows 8 reboot in an infinite loop either shortly before the logo is displayed (Windows 7) or after the boot logo is displayed (Windows 8). On a

Re: [Qemu-devel] [PATCH V16 09/11] NUMA: set guest numa nodes memory policy

2013-11-27 Thread Wanlong Gao
On 11/27/2013 10:35 PM, Paolo Bonzini wrote: > Il 22/11/2013 03:08, Wanlong Gao ha scritto: >> +static int set_node_mem_policy(int nodeid) >> +{ >> +#ifdef __linux__ >> +void *ram_ptr; >> +RAMBlock *block; >> +ram_addr_t len, ram_offset = 0; >> +int bind_mode; >> +int i; >> + >>

Re: [Qemu-devel] [qemu PATCH] hw/i386/pc_sysfw: support more than one flash drive

2013-11-27 Thread Laszlo Ersek
On 11/27/13 15:45, Markus Armbruster wrote: > Laszlo Ersek writes: > >> On 11/27/13 14:52, Markus Armbruster wrote: >>> Jordan Justen writes: >>> On Tue, Nov 26, 2013 at 5:32 AM, Laszlo Ersek wrote: > On 11/26/13 13:36, Markus Armbruster wrote: > >> Your stated purpose for mult

Re: [Qemu-devel] [PATCH 04/27] vl: convert -m to qemu_opts_parse()

2013-11-27 Thread Markus Armbruster
Igor Mammedov writes: > On Tue, 26 Nov 2013 15:49:05 +0100 > Markus Armbruster wrote: > >> Igor Mammedov writes: >> >> > On Thu, 21 Nov 2013 11:12:43 +0100 >> > Markus Armbruster wrote: >> > >> >> Igor Mammedov writes: >> >> > [...] >> Two separate issues here: >> >> 1. The "no qemu_mem_op

Re: [Qemu-devel] [PATCH 07/27] add memdev backend infrastructure

2013-11-27 Thread Eric Blake
On 11/20/2013 07:38 PM, Igor Mammedov wrote: > Provides framework for splitting host RAM allocation/ > policies into a separate backend that could be used > by devices. It would allow to separate host specific > options from device model like it's done for netdev & co. Just an interface review: >

Re: [Qemu-devel] [PATCH 04/27] vl: convert -m to qemu_opts_parse()

2013-11-27 Thread Igor Mammedov
On Wed, 27 Nov 2013 15:35:09 +0100 Markus Armbruster wrote: > Igor Mammedov writes: > > > On Tue, 26 Nov 2013 15:49:05 +0100 > > Markus Armbruster wrote: > > > >> Igor Mammedov writes: > >> > >> > On Thu, 21 Nov 2013 11:12:43 +0100 > >> > Markus Armbruster wrote: > >> > > >> >> Igor Mammedo

Re: [Qemu-devel] [PATCH 0/2] vmdk: Allow version 3 read only open

2013-11-27 Thread Stefan Hajnoczi
On Wed, Nov 27, 2013 at 10:06:29AM +0800, Fam Zheng wrote: > According to an update on VMware Knowledge Base [KB 2064959], we should be > safe > to open version 3 as read only. This is meaningful as an compatibility > improvement, so let's enable it. Acked-by: Stefan Hajnoczi But please add a c

Re: [Qemu-devel] [RFC PATCH v2] i386: Add _PXM ACPI method to CPU objects

2013-11-27 Thread Igor Mammedov
On Wed, 27 Nov 2013 14:02:43 +0100 Vasilis Liaskovitis wrote: > This patch adds a _PXM method to ACPI CPU objects for the pc machine. The _PXM > value is derived from the passed in guest info, same way as CPU SRAT entries. > > Currently, CPU SRAT entries are only enabled for cpus that are alread

Re: [Qemu-devel] [PATCH 07/27] add memdev backend infrastructure

2013-11-27 Thread Igor Mammedov
On Wed, 27 Nov 2013 16:21:23 +0100 Paolo Bonzini wrote: > Il 27/11/2013 15:37, Igor Mammedov ha scritto: > > It looks like "realize" for -object / object-add implemented via > > an interface. > > It does---but without unrealize and with the additional get_base_path. > > > Maybe it should be ren

  1   2   >