Re: [Qemu-devel] [PULL for-1.8 1/2] pc: disable pci-info

2013-11-26 Thread Laszlo Ersek
On 11/18/13 12:53, Michael S. Tsirkin wrote: > From: Igor Mammedov > > The BIOS that we ship in 1.7 does not use pci info > from host and so far isn't going to use it. > Taking in account problems it caused see 9604f70fdf and > to avoid future incompatibility issues, it's safest to > disable that

Re: [Qemu-devel] [PATCH v4 1/4] hw/timer: add sunxi timer device

2013-11-26 Thread Peter Crosthwaite
On Tue, Nov 26, 2013 at 5:22 PM, liguang wrote: > Signed-off-by: liguang > --- > default-configs/arm-softmmu.mak |2 + > hw/timer/Makefile.objs |1 + > hw/timer/sunxi-pit.c| 295 > +++ > include/hw/timer/sunxi-pit.h| 37 +++

[Qemu-devel] [PATCHv2 1.8 1/9] qemu-img: add support for skipping zeroes in input during convert

2013-11-26 Thread Peter Lieven
we currently do not check if a sector is allocated during convert. This means if a sector is unallocated that we allocate a bounce buffer of zeroes, find out its zero later and do not write it in the best case. In the worst case this can lead to reading blocks from a raw device (like iSCSI) altough

[Qemu-devel] [PATCHv2 1.8 4/9] block: add opt_transfer_length to BlockLimits

2013-11-26 Thread Peter Lieven
Signed-off-by: Peter Lieven --- include/block/block_int.h |3 +++ 1 file changed, 3 insertions(+) diff --git a/include/block/block_int.h b/include/block/block_int.h index 95140b6..6499516 100644 --- a/include/block/block_int.h +++ b/include/block/block_int.h @@ -242,6 +242,9 @@ typedef struc

[Qemu-devel] [PATCHv2 1.8 2/9] qemu-img: fix usage instruction for qemu-img convert

2013-11-26 Thread Peter Lieven
Reviewed-by: Eric Blake Signed-off-by: Peter Lieven --- qemu-img.c |1 - 1 file changed, 1 deletion(-) diff --git a/qemu-img.c b/qemu-img.c index efb744c..e2d1a0a 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -105,7 +105,6 @@ static void help(void) " conversion. If the numbe

[Qemu-devel] [PATCHv2 1.8 3/9] block/iscsi: set bdi->cluster_size

2013-11-26 Thread Peter Lieven
this patch aims to set bdi->cluster_size to the internal page size of the iscsi target so that enabled callers can align requests properly. Reviewed-by: Paolo Bonzini Signed-off-by: Peter Lieven --- block/iscsi.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/block/iscsi.c b/bloc

[Qemu-devel] [PATCHv2 1.8 5/9] block/iscsi: set bs->bl.opt_transfer_length

2013-11-26 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block/iscsi.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index 75d6b87..1109d8c 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -1457,6 +1457,9 @@ static int iscsi_open(BlockDriverState *bs, QDict *options, int flags,

[Qemu-devel] [PATCHv2 1.8 9/9] qemu-img: increase min_sparse to 128 sectors (64kb)

2013-11-26 Thread Peter Lieven
Suggested-by: Paolo Bonzini Signed-off-by: Peter Lieven --- qemu-img.c|4 ++-- qemu-img.texi |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index cc7540f..6f1179b 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -101,7 +101,7 @@ static void h

[Qemu-devel] [PATCHv2 1.8 0/9] qemu-img convert optimizations

2013-11-26 Thread Peter Lieven
this series adds some optimizations for qemu-img during convert which have been developed recently: - skipping input based on get_block_status - variable I/O buffer size - align write requests to cluster_size - show progress in sectors or percent v1->v2: - introduce opt_transfer_length in BlockL

[Qemu-devel] [PATCHv2 1.8 6/9] qemu-img: dynamically adjust iobuffer size during convert

2013-11-26 Thread Peter Lieven
since the convert process is basically a sync operation it might be benificial in some case to change the hardcoded I/O buffer size to a greater value. This patch increases the I/O buffer size if the output driver advertises an optimal transfer length or discard alignment that is greater than the

[Qemu-devel] [PATCHv2 1.8 8/9] qemu-img: add option to show progress in sectors

2013-11-26 Thread Peter Lieven
Signed-off-by: Peter Lieven --- qemu-img-cmds.hx |4 ++-- qemu-img.c | 31 --- qemu-img.texi|4 +++- 3 files changed, 33 insertions(+), 6 deletions(-) diff --git a/qemu-img-cmds.hx b/qemu-img-cmds.hx index da1d965..6c8183b 100644 --- a/qemu-img-cmd

[Qemu-devel] [PATCHv2 1.8 7/9] qemu-img: round down request length to an aligned sector

2013-11-26 Thread Peter Lieven
this patch shortens requests to end at an aligned sector so that the next request starts aligned. Signed-off-by: Peter Lieven --- qemu-img.c | 30 -- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index b076d44..1421f0f 10064

Re: [Qemu-devel] [PATCH v4 1/4] hw/timer: add sunxi timer device

2013-11-26 Thread Li Guang
Peter Crosthwaite wrote: On Tue, Nov 26, 2013 at 5:22 PM, liguang wrote: Signed-off-by: liguang --- default-configs/arm-softmmu.mak |2 + hw/timer/Makefile.objs |1 + hw/timer/sunxi-pit.c| 295 +++ include/hw/timer/sunxi

Re: [Qemu-devel] [PATCH for-1.7 0/2] block/drive-mirror: Reuse backing HD for sync=none

2013-11-26 Thread Paolo Bonzini
Il 25/11/2013 20:28, Max Reitz ha scritto: > This series fixes the drive-mirror blockjob in case of "none" sync mode > to always use the old (current) image file as the backing file of the > newly created mirrored file (in case of "absolute-paths" mode). > > It is rather important to get this into

Re: [Qemu-devel] [PATCH v4 2/4] hw/intc: add sunxi interrupt controller device

2013-11-26 Thread Peter Crosthwaite
On Tue, Nov 26, 2013 at 5:22 PM, liguang wrote: > Signed-off-by: liguang > --- > default-configs/arm-softmmu.mak |1 + > hw/intc/Makefile.objs |1 + > hw/intc/sunxi-pic.c | 238 > +++ > include/hw/intc/sunxi-pic.h | 20 +++

Re: [Qemu-devel] [PATCH rebased for-1.8] i386: pc: align gpa<->hpa on 1GB boundary (v6)

2013-11-26 Thread Paolo Bonzini
Il 25/11/2013 22:05, Michael S. Tsirkin ha scritto: >> > Signed-off-by: Marcelo Tosatti >> > [Reorganize code, keep same logic. - Paolo] >> > Signed-off-by: Paolo Bonzini > BTW how about a unit-test for this? > Can be something along the lines of the acpi tests: > run BIOS, probe what it reported

Re: [Qemu-devel] [PULL for-1.8 1/2] pc: disable pci-info

2013-11-26 Thread Michael S. Tsirkin
On Tue, Nov 26, 2013 at 09:12:50AM +0100, Laszlo Ersek wrote: > On 11/18/13 12:53, Michael S. Tsirkin wrote: > > From: Igor Mammedov > > > > The BIOS that we ship in 1.7 does not use pci info > > from host and so far isn't going to use it. > > Taking in account problems it caused see 9604f70fdf a

Re: [Qemu-devel] [PATCH v4 2/4] hw/intc: add sunxi interrupt controller device

2013-11-26 Thread Li Guang
Peter Crosthwaite wrote: On Tue, Nov 26, 2013 at 5:22 PM, liguang wrote: Signed-off-by: liguang --- default-configs/arm-softmmu.mak |1 + hw/intc/Makefile.objs |1 + hw/intc/sunxi-pic.c | 238 +++ include/hw/intc/sunxi-

Re: [Qemu-devel] [PATCH v4 1/4] hw/timer: add sunxi timer device

2013-11-26 Thread Peter Crosthwaite
On Tue, Nov 26, 2013 at 6:59 PM, Li Guang wrote: > Peter Crosthwaite wrote: >> >> On Tue, Nov 26, 2013 at 5:22 PM, liguang wrote: >> >>> >>> Signed-off-by: liguang >>> --- >>> default-configs/arm-softmmu.mak |2 + >>> hw/timer/Makefile.objs |1 + >>> hw/timer/sunxi-pit.c

Re: [Qemu-devel] [PATCH v4 1/4] hw/timer: add sunxi timer device

2013-11-26 Thread Li Guang
Peter Crosthwaite wrote: On Tue, Nov 26, 2013 at 6:59 PM, Li Guang wrote: Peter Crosthwaite wrote: On Tue, Nov 26, 2013 at 5:22 PM, liguang wrote: Signed-off-by: liguang --- default-configs/arm-softmmu.mak |2 + hw/timer/Makefile.objs |1 + hw/time

Re: [Qemu-devel] [PATCH v4 2/7] block: Introduce op_blockers to BlockDriverState

2013-11-26 Thread Paolo Bonzini
Il 26/11/2013 03:07, Fam Zheng ha scritto: >>> >>> +void bdrv_op_unblock(BlockDriverState *bs, BlockOpType op, Error >>> *reason) >> >> What about making BlockOpType a bitmask, and having bdrv_op_{,un}block >> take multiple ORed BlockOpTypes? >> >> bdrv_op_{,un}block_all then are not necessary, you

Re: [Qemu-devel] [PATCH v4 3/4] hw/arm: add sunxi machine type

2013-11-26 Thread Peter Crosthwaite
On Tue, Nov 26, 2013 at 5:22 PM, liguang wrote: > Signed-off-by: liguang > --- > hw/arm/Makefile.objs |1 + > hw/arm/sunxi-soc.c | 98 > ++ > 2 files changed, 99 insertions(+), 0 deletions(-) > create mode 100644 hw/arm/sunxi-soc.c > > di

Re: [Qemu-devel] [PATCH v4 1/4] hw/timer: add sunxi timer device

2013-11-26 Thread Peter Crosthwaite
On Tue, Nov 26, 2013 at 7:19 PM, Li Guang wrote: > Peter Crosthwaite wrote: >> >> On Tue, Nov 26, 2013 at 6:59 PM, Li Guang wrote: >> >>> >>> Peter Crosthwaite wrote: >>> On Tue, Nov 26, 2013 at 5:22 PM, liguang wrote: > > Signed-off-by: liguang > --- >

Re: [Qemu-devel] [PATCHv2 1.8 2/9] qemu-img: fix usage instruction for qemu-img convert

2013-11-26 Thread Paolo Bonzini
Il 26/11/2013 09:56, Peter Lieven ha scritto: > Reviewed-by: Eric Blake > Signed-off-by: Peter Lieven > --- > qemu-img.c |1 - > 1 file changed, 1 deletion(-) > > diff --git a/qemu-img.c b/qemu-img.c > index efb744c..e2d1a0a 100644 > --- a/qemu-img.c > +++ b/qemu-img.c > @@ -105,7 +105,6 @@

Re: [Qemu-devel] [PATCHv2 1.8 5/9] block/iscsi: set bs->bl.opt_transfer_length

2013-11-26 Thread Paolo Bonzini
Il 26/11/2013 09:56, Peter Lieven ha scritto: > Signed-off-by: Peter Lieven > --- > block/iscsi.c |3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/block/iscsi.c b/block/iscsi.c > index 75d6b87..1109d8c 100644 > --- a/block/iscsi.c > +++ b/block/iscsi.c > @@ -1457,6 +1457,9 @@ stati

Re: [Qemu-devel] [PATCHv2 1.8 4/9] block: add opt_transfer_length to BlockLimits

2013-11-26 Thread Paolo Bonzini
Il 26/11/2013 09:56, Peter Lieven ha scritto: > Signed-off-by: Peter Lieven > --- > include/block/block_int.h |3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/block/block_int.h b/include/block/block_int.h > index 95140b6..6499516 100644 > --- a/include/block/block_int.h > +

Re: [Qemu-devel] [PATCHv2 1.8 6/9] qemu-img: dynamically adjust iobuffer size during convert

2013-11-26 Thread Paolo Bonzini
Il 26/11/2013 09:56, Peter Lieven ha scritto: > since the convert process is basically a sync operation it might > be benificial in some case to change the hardcoded I/O buffer > size to a greater value. > > This patch increases the I/O buffer size if the output > driver advertises an optimal tran

Re: [Qemu-devel] [PATCHv2 1.8 7/9] qemu-img: round down request length to an aligned sector

2013-11-26 Thread Paolo Bonzini
Il 26/11/2013 09:56, Peter Lieven ha scritto: > this patch shortens requests to end at an aligned sector so that > the next request starts aligned. > > Signed-off-by: Peter Lieven > --- > qemu-img.c | 30 -- > 1 file changed, 20 insertions(+), 10 deletions(-) > > d

Re: [Qemu-devel] [PATCHv2 1.8 9/9] qemu-img: increase min_sparse to 128 sectors (64kb)

2013-11-26 Thread Paolo Bonzini
Il 26/11/2013 09:56, Peter Lieven ha scritto: > Suggested-by: Paolo Bonzini > Signed-off-by: Peter Lieven > --- > qemu-img.c|4 ++-- > qemu-img.texi |2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/qemu-img.c b/qemu-img.c > index cc7540f..6f1179b 100644 > -

Re: [Qemu-devel] [PATCH 14/16] pc: Postpone adding ACPI and SMBIOS to fw_cfg

2013-11-26 Thread Michael S. Tsirkin
On Thu, Nov 14, 2013 at 07:40:31AM -0600, Corey Minyard wrote: > On 11/14/2013 07:38 AM, Michael S. Tsirkin wrote: > > On Thu, Nov 14, 2013 at 07:28:00AM -0600, Corey Minyard wrote: > >> On 11/14/2013 01:30 AM, Michael S. Tsirkin wrote: > >>> On Tue, Nov 12, 2013 at 10:33:13AM -0600, Corey Minyard

Re: [Qemu-devel] os x boot broken by commit 11948748495841bd54721b250d68c7b3cb0475ef

2013-11-26 Thread Michael S. Tsirkin
On Thu, Nov 21, 2013 at 05:02:07PM -0500, Gabriel L. Somlo wrote: > Added qemu-devel, since that is where this stuff belongs now. Everyone > else, sorry for the dupe... > > On Thu, Nov 21, 2013 at 07:14:27PM +0100, Paolo Bonzini wrote: > > Can you remind us about your DSDT modifications? It shoul

Re: [Qemu-devel] [PATCHv2 1.8 1/9] qemu-img: add support for skipping zeroes in input during convert

2013-11-26 Thread Paolo Bonzini
Il 26/11/2013 09:56, Peter Lieven ha scritto: > we currently do not check if a sector is allocated during convert. > This means if a sector is unallocated that we allocate a bounce > buffer of zeroes, find out its zero later and do not write it > in the best case. In the worst case this can lead to

Re: [Qemu-devel] [PATCHv2 1.8 8/9] qemu-img: add option to show progress in sectors

2013-11-26 Thread Paolo Bonzini
I think the right way to do this would be to add the functionality to qemu-progress.c (i.e. pass a number of sectors and let it choose between printing % or sectors). I don't like the qemu-progress.c API anyway, so a rewrite would be welcome. :) Paolo Il 26/11/2013 09:56, Peter Lieven ha scritto

Re: [Qemu-devel] os x boot broken by commit 11948748495841bd54721b250d68c7b3cb0475ef

2013-11-26 Thread Michael S. Tsirkin
On Fri, Nov 22, 2013 at 10:00:20AM +0100, Paolo Bonzini wrote: > Il 21/11/2013 23:02, Gabriel L. Somlo ha scritto: > > On Thu, Nov 21, 2013 at 07:14:27PM +0100, Paolo Bonzini wrote: > >> > Can you remind us about your DSDT modifications? It should be possible > >> > to patch the HPET and applesmc

Re: [Qemu-devel] [PATCH v4 2/7] block: Introduce op_blockers to BlockDriverState

2013-11-26 Thread Paolo Bonzini
Il 26/11/2013 11:19, Fam Zheng ha scritto: >> So that you can add the same Error to multiple items of the array with a >> single bdrv_op_block call (by ORing them into the second parameter). > > What data type to contain this? I'm not sure 64 is enough in long term... I would just use an uint64_t

Re: [Qemu-devel] [PATCH v4 2/7] block: Introduce op_blockers to BlockDriverState

2013-11-26 Thread Fam Zheng
On Tue, Nov 26, 2013 at 6:25 PM, Paolo Bonzini wrote: > Il 26/11/2013 11:19, Fam Zheng ha scritto: >>> So that you can add the same Error to multiple items of the array with a >>> single bdrv_op_block call (by ORing them into the second parameter). >> >> What data type to contain this? I'm not sur

Re: [Qemu-devel] [PATCH v4 2/7] block: Introduce op_blockers to BlockDriverState

2013-11-26 Thread Fam Zheng
On Tue, Nov 26, 2013 at 5:22 PM, Paolo Bonzini wrote: > Il 26/11/2013 03:07, Fam Zheng ha scritto: +void bdrv_op_unblock(BlockDriverState *bs, BlockOpType op, Error *reason) >>> >>> What about making BlockOpType a bitmask, and having bdrv_op_{,un}block >>> take multiple ORed BlockOp

Re: [Qemu-devel] [PATCH v4 2/7] block: Introduce op_blockers to BlockDriverState

2013-11-26 Thread Paolo Bonzini
Il 26/11/2013 11:31, Fam Zheng ha scritto: >> > I would just use an uint64_t, I think you have ~20 operations now. >> > There is still quite some breathing room. >> > > OK. Then, can we still use QAPI enum? Because I think being possible > to query blockers makes sense, that way the user doesn't ha

[Qemu-devel] [PATCH] qcow2: Zero-initialise first cluster for new images

2013-11-26 Thread Kevin Wolf
Strictly speaking, this is only required for has_zero_init() == false, but it's easy enough to just do a cluster-aligned write that is padded with zeros after the header. This fixes that after 'qemu-img create' header extensions are attempted to be parsed that are really just random leftover data.

Re: [Qemu-devel] [PULL for-1.8 1/2] pc: disable pci-info

2013-11-26 Thread Gerd Hoffmann
Hi, > I think it's down to other qemu bugs (such as _CRS not covering > all of PCI memory), we shall just fix them. i.e. the attached patch should fixup things. cheers, Gerd >From a81b8d66e24fd298ce7654d424a378337e6cf132 Mon Sep 17 00:00:00 2001 From: Gerd Hoffmann Date: Tue, 26 Nov 2013 1

Re: [Qemu-devel] [PATCH v4 7/7] block: Allow backup on referenced named BlockDriverState

2013-11-26 Thread Kevin Wolf
Am 26.11.2013 um 04:06 hat Fam Zheng geschrieben: > On 2013年11月25日 19:23, Kevin Wolf wrote: > >Am 22.11.2013 um 06:24 hat Fam Zheng geschrieben: > >>Drive backup is a read only operation on source bs. We want to allow > >>this specific case to enable image-fleecing. Note that when > >>image-fleecin

Re: [Qemu-devel] [PATCH v4 2/7] block: Introduce op_blockers to BlockDriverState

2013-11-26 Thread Fam Zheng
On Tue, Nov 26, 2013 at 6:41 PM, Paolo Bonzini wrote: > Il 26/11/2013 11:31, Fam Zheng ha scritto: >>> > I would just use an uint64_t, I think you have ~20 operations now. >>> > There is still quite some breathing room. >>> > >> OK. Then, can we still use QAPI enum? Because I think being possible

Re: [Qemu-devel] [PATCH 0/17 v3] Localhost migration with side channel for ram

2013-11-26 Thread Lei Li
On 11/25/2013 05:48 PM, Paolo Bonzini wrote: Il 25/11/2013 08:29, Lei Li ha scritto: In this case, if the migration would fail just because the misconfiguration of device state on destination, in the meantime the outgoing migration has no aware of this failure, I think it should add such handli

Re: [Qemu-devel] [PATCH 0/17 v3] Localhost migration with side channel for ram

2013-11-26 Thread Paolo Bonzini
Il 26/11/2013 12:07, Lei Li ha scritto: >> Basically, "-incoming" without "-S" is a broken option because of the >> missing handshake at the end of migration. With "-S" something else >> (either a human or a program) can check that everything went well and >> choose whether to restart the source o

Re: [Qemu-devel] [PATCH 10/17] migration-local: override save_page for page transmit

2013-11-26 Thread Paolo Bonzini
Il 21/11/2013 10:11, Lei Li ha scritto: > This patch implements save_page callback for the outside > of page flipping. It will write the address of the page > on the Unix socket and flip the page data on pipe by > vmsplice(). Every page address would have a header flag > RAM_SAVE_FLAG_HOOK, which w

Re: [Qemu-devel] [PATCH] SPARC: Fix LEON3 power down instruction

2013-11-26 Thread Fabien Chouteau
On 11/25/2013 03:22 PM, Sebastian Huber wrote: > The env->pc is not necessarily up-to-date in the helper function. Use > the program counter of the disassembly context instead. > Looks good. Thanks Sebastian. Reviewed-by: Fabien Chouteau > Signed-off-by: Sebastian Huber > --- > target-sparc

Re: [Qemu-devel] [PATCH 12/17] migration-local: override hook_ram_load

2013-11-26 Thread Paolo Bonzini
Il 21/11/2013 10:11, Lei Li ha scritto: > +static int qemu_local_ram_load(QEMUFile *f, void *opaque, > + uint64_t flags) > +{ > +QEMUFileLocal *s = opaque; > +ram_addr_t addr; > +struct iovec iov; > +ssize_t ret = -EINVAL; > + > +/* > + * PIPE f

Re: [Qemu-devel] [PATCH 06/17] migration-local: add send_pipefd()

2013-11-26 Thread Paolo Bonzini
Il 21/11/2013 10:11, Lei Li ha scritto: > +struct cmsghdr *cmptr; > +char req[1] = { 0x01 }; About this, see my reply to patch 8. > +if (pipefd < 0) { > +msg.msg_control = NULL; > +msg.msg_controllen = 0; > +/* Negative status means error */ > +req[0] =

Re: [Qemu-devel] [PATCH 08/17] add unix_msgfd_lookup() to callback get_buffer

2013-11-26 Thread Lei Li
On 11/21/2013 05:11 PM, Lei Li wrote: The control message for exchange of pipe file descriptor should be received by recvmsg, and it might be eaten to stream file by qemu_recv() when receiving by two callbacks. So this patch adds unix_msgfd_lookup() to callback get_buffer as the only one receiver

Re: [Qemu-devel] [PATCH 08/17] add unix_msgfd_lookup() to callback get_buffer

2013-11-26 Thread Paolo Bonzini
Il 21/11/2013 10:11, Lei Li ha scritto: > +/* > + * recvmsg is called here to catch the control message for > + * the exchange of PIPE file descriptor until it is received. > + */ > +len = recvmsg(s->sockfd, &msg, 0); > +if (le

Re: [Qemu-devel] [PATCH 16/17] migration: adjust migration_thread() process for page flipping

2013-11-26 Thread Paolo Bonzini
Il 21/11/2013 10:11, Lei Li ha scritto: > Signed-off-by: Lei Li > --- > migration.c | 10 +++--- > 1 files changed, 7 insertions(+), 3 deletions(-) > > diff --git a/migration.c b/migration.c > index 4ac466b..0f98ac1 100644 > --- a/migration.c > +++ b/migration.c > @@ -579,10 +579,11 @@ sta

Re: [Qemu-devel] [PATCH 29/60] AArch64: Add orri instruction emulation

2013-11-26 Thread Claudio Fontana
On 09/27/2013 09:42 PM, Richard Henderson wrote: > On 09/26/2013 05:48 PM, Alexander Graf wrote: >> +if (setflags) { >> +tcg_dst = cpu_reg(dest); >> +} else { >> +tcg_dst = cpu_reg_sp(dest); >> +} > > Never sp for logicals. This should be ok in my view, the manual expl

Re: [Qemu-devel] [PATCH 16/17] migration: adjust migration_thread() process for page flipping

2013-11-26 Thread Lei Li
On 11/26/2013 07:32 PM, Paolo Bonzini wrote: Il 21/11/2013 10:11, Lei Li ha scritto: Signed-off-by: Lei Li --- migration.c | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/migration.c b/migration.c index 4ac466b..0f98ac1 100644 --- a/migration.c +++ b/migrati

Re: [Qemu-devel] [PATCH 29/60] AArch64: Add orri instruction emulation

2013-11-26 Thread Laurent Desnogues
On Tue, Nov 26, 2013 at 12:56 PM, Claudio Fontana wrote: > On 09/27/2013 09:42 PM, Richard Henderson wrote: >> On 09/26/2013 05:48 PM, Alexander Graf wrote: >>> +if (setflags) { >>> +tcg_dst = cpu_reg(dest); >>> +} else { >>> +tcg_dst = cpu_reg_sp(dest); >>> +} >> >> Ne

Re: [Qemu-devel] [PATCH 10/17] migration-local: override save_page for page transmit

2013-11-26 Thread Lei Li
On 11/26/2013 07:22 PM, Paolo Bonzini wrote: Il 21/11/2013 10:11, Lei Li ha scritto: This patch implements save_page callback for the outside of page flipping. It will write the address of the page on the Unix socket and flip the page data on pipe by vmsplice(). Every page address would have a h

Re: [Qemu-devel] [PATCH 12/17] migration-local: override hook_ram_load

2013-11-26 Thread Lei Li
On 11/26/2013 07:25 PM, Paolo Bonzini wrote: Il 21/11/2013 10:11, Lei Li ha scritto: +static int qemu_local_ram_load(QEMUFile *f, void *opaque, + uint64_t flags) +{ +QEMUFileLocal *s = opaque; +ram_addr_t addr; +struct iovec iov; +ssize_t ret = -EINV

Re: [Qemu-devel] [Qemu-stable] [PATCH] qcow2: Zero-initialise first cluster for new images

2013-11-26 Thread Fam Zheng
On 2013年11月26日 18:48, Kevin Wolf wrote: Strictly speaking, this is only required for has_zero_init() == false, but it's easy enough to just do a cluster-aligned write that is padded with zeros after the header. This fixes that after 'qemu-img create' header extensions are attempted to be parsed

Re: [Qemu-devel] [PATCH 1.7] [PATCH v3 1/2] linux-user: create target_structsheader to place ipc_perm and shmid_dss

2013-11-26 Thread Petar Jovanovic
ping http://patchwork.ozlabs.org/patch/287211/ http://patchwork.ozlabs.org/patch/287213/ Can we get these two changes in 1.7? It has been reviewed and waiting for someone who has commits rights for two months now. Regards, Petar From: Petar Jovanovic Sen

Re: [Qemu-devel] [PATCHv2 1.8 8/9] qemu-img: add option to show progress in sectors

2013-11-26 Thread Peter Lieven
On 26.11.2013 11:04, Paolo Bonzini wrote: I think the right way to do this would be to add the functionality to qemu-progress.c (i.e. pass a number of sectors and let it choose between printing % or sectors). I was thinking about the same, but is this not beyond the scope of this patch? ;-) I d

Re: [Qemu-devel] [PATCH 14/17] add new RanState RAN_STATE_MEMORY_STALE

2013-11-26 Thread Paolo Bonzini
Il 21/11/2013 10:11, Lei Li ha scritto: > > { RUN_STATE_DEBUG, RUN_STATE_SUSPENDED }, DEBUG -> MEMORY_STALE is missing. Paolo > { RUN_STATE_RUNNING, RUN_STATE_SUSPENDED }, > { RUN_STATE_SUSPENDED, RUN_STATE_RUNNING }, > { RUN_STATE_SUSPENDED, RUN_STATE_FINISH_MIGRATE }, > +

Re: [Qemu-devel] [qemu PATCH] hw/i386/pc_sysfw: support more than one flash drive

2013-11-26 Thread Markus Armbruster
Laszlo Ersek writes: > On 11/25/13 16:22, Markus Armbruster wrote: >> Laszlo Ersek writes: >> >>> On 11/22/13 13:21, Markus Armbruster wrote: Laszlo Ersek writes: > This patch allows the user to usefully specify > > -drive file=img_1,if=pflash,format=raw,readonly \

Re: [Qemu-devel] [PATCHv2 1.8 8/9] qemu-img: add option to show progress in sectors

2013-11-26 Thread Paolo Bonzini
Il 26/11/2013 13:23, Peter Lieven ha scritto: >> I think the right way to do this would be to add the functionality to >> qemu-progress.c (i.e. pass a number of sectors and let it choose between >> printing % or sectors). > I was thinking about the same, but is this not beyond the scope of this > p

[Qemu-devel] [RFC] create a single workqueue for each vm to update vm irq routing table

2013-11-26 Thread Zhanghaoyu (A)
Hi all, When guest set irq smp_affinity, VMEXIT occurs, then the vcpu thread will IOCTL return to QEMU from hypervisor, then vcpu thread ask the hypervisor to update the irq routing table, in kvm_set_irq_routing, synchronize_rcu is called, current vcpu thread is blocked for so much time to wait

Re: [Qemu-devel] [RFC] create a single workqueue for each vm to update vm irq routing table

2013-11-26 Thread Paolo Bonzini
Il 26/11/2013 13:40, Zhanghaoyu (A) ha scritto: > When guest set irq smp_affinity, VMEXIT occurs, then the vcpu thread will > IOCTL return to QEMU from hypervisor, then vcpu thread ask the hypervisor to > update the irq routing table, > in kvm_set_irq_routing, synchronize_rcu is called, current v

Re: [Qemu-devel] [RFC] create a single workqueue for each vm to update vm irq routing table

2013-11-26 Thread Gleb Natapov
On Tue, Nov 26, 2013 at 12:40:36PM +, Zhanghaoyu (A) wrote: > Hi all, > > When guest set irq smp_affinity, VMEXIT occurs, then the vcpu thread will > IOCTL return to QEMU from hypervisor, then vcpu thread ask the hypervisor to > update the irq routing table, Why vcpu thread ask the hyperviso

Re: [Qemu-devel] [RFC] create a single workqueue for each vm to update vm irq routing table

2013-11-26 Thread Gleb Natapov
On Tue, Nov 26, 2013 at 02:48:10PM +0200, Gleb Natapov wrote: > On Tue, Nov 26, 2013 at 12:40:36PM +, Zhanghaoyu (A) wrote: > > Hi all, > > > > When guest set irq smp_affinity, VMEXIT occurs, then the vcpu thread will > > IOCTL return to QEMU from hypervisor, then vcpu thread ask the hypervis

Re: [Qemu-devel] [qemu PATCH] hw/i386/pc_sysfw: support more than one flash drive

2013-11-26 Thread Markus Armbruster
Laszlo Ersek writes: > On 11/22/13 13:21, Markus Armbruster wrote: >> Laszlo Ersek writes: >> >>> This patch allows the user to usefully specify >>> >>> -drive file=img_1,if=pflash,format=raw,readonly \ >>> -drive file=img_2,if=pflash,format=raw >>> >>> on the command line. The flash images

Re: [Qemu-devel] [PATCH 16/17] migration: adjust migration_thread() process for page flipping

2013-11-26 Thread Paolo Bonzini
Il 26/11/2013 13:03, Lei Li ha scritto: >>> >>> +if (pending_size && pending_size >= max_size && >>> +!runstate_needs_reset()) { >>> qemu_savevm_state_iterate(s->file); >> I'm not sure why you need this. > > The adjustment here is to avoid the iteratio

Re: [Qemu-devel] [RFC] create a single workqueue for each vm to update vm irq routing table

2013-11-26 Thread Gleb Natapov
On Tue, Nov 26, 2013 at 01:47:03PM +0100, Paolo Bonzini wrote: > Il 26/11/2013 13:40, Zhanghaoyu (A) ha scritto: > > When guest set irq smp_affinity, VMEXIT occurs, then the vcpu thread will > > IOCTL return to QEMU from hypervisor, then vcpu thread ask the hypervisor > > to update the irq routin

Re: [Qemu-devel] virtio-net: network stops responding in Win2k3 server

2013-11-26 Thread ing. Mario De Chenno
Since it's a production machine, I had to try a remedy first: I changed one network card (pub, of course) to e1000 and now it's up from 62 hours (maybe a record!) Here is the output for the other card (virtio): I guess parameters should have been the same for the affected interface too (they are n

Re: [Qemu-devel] [qemu PATCH] hw/i386/pc_sysfw: support more than one flash drive

2013-11-26 Thread Markus Armbruster
Laszlo Ersek writes: > On 11/25/13 16:32, Markus Armbruster wrote: >> Laszlo Ersek writes: >> >>> This patch allows the user to usefully specify >>> >>> -drive file=img_1,if=pflash,format=raw,readonly \ >>> -drive file=img_2,if=pflash,format=raw >>> >>> on the command line. The flash images

Re: [Qemu-devel] [RFC] create a single workqueue for each vm to update vm irq routing table

2013-11-26 Thread Paolo Bonzini
Il 26/11/2013 13:56, Gleb Natapov ha scritto: > > I don't think a workqueue is even needed. You just need to use call_rcu > > to free "old" after releasing kvm->irq_lock. > > > > What do you think? > > It should be rate limited somehow. Since it guest triggarable guest may cause > host to alloca

Re: [Qemu-devel] [PATCH 04/27] vl: convert -m to qemu_opts_parse()

2013-11-26 Thread Igor Mammedov
On Thu, 21 Nov 2013 11:12:43 +0100 Markus Armbruster wrote: > Igor Mammedov writes: > > > Along with conversion extend -m option to support following parameters: > > Please split this into two patches: first conversion to QemuOpts, then > extension. > > > "mem" - startup memory amount > >

Re: [Qemu-devel] [RFC] create a single workqueue for each vm to update vm irq routing table

2013-11-26 Thread Avi Kivity
On Tue, Nov 26, 2013 at 2:47 PM, Paolo Bonzini wrote: > Il 26/11/2013 13:40, Zhanghaoyu (A) ha scritto: >> When guest set irq smp_affinity, VMEXIT occurs, then the vcpu thread will IOCTL return to QEMU from hypervisor, then vcpu thread ask the hypervisor to update the irq routing table, >> in kvm_

[Qemu-devel] sparc64 with openbios-sparc64

2013-11-26 Thread Mahmood Naderan
Hello, Is there any news on emulating sparc64 machine with openbios-sparc64 on a x86_64 host machine? I followed some posts regarding this from 2010 however didn't end-up with a conclusion.   Regards, Mahmood

Re: [Qemu-devel] [qemu PATCH] hw/i386/pc_sysfw: support more than one flash drive

2013-11-26 Thread Laszlo Ersek
On 11/26/13 13:53, Markus Armbruster wrote: > Thus, we grab *all* if=pflash drives for this purpose. > > Your stated use case wants just two. > > Hmm. Are we sure we'll never want to map an if=pflash device somewhere > else? No, I'm not sure. Thanks Laszlo

Re: [Qemu-devel] [qemu PATCH] hw/i386/pc_sysfw: support more than one flash drive

2013-11-26 Thread Laszlo Ersek
On 11/26/13 13:36, Markus Armbruster wrote: > Your stated purpose for multiple -pflash: > > This accommodates the following use case: suppose that OVMF is split in > two parts, a writeable host file for non-volatile variable storage, and a > read-only part for bootstrap and decompress

Re: [Qemu-devel] [qemu PATCH] hw/i386/pc_sysfw: support more than one flash drive

2013-11-26 Thread Laszlo Ersek
On 11/26/13 14:11, Markus Armbruster wrote: > Laszlo Ersek writes: > >> On 11/25/13 16:32, Markus Armbruster wrote: >>> Laszlo Ersek writes: >>> This patch allows the user to usefully specify -drive file=img_1,if=pflash,format=raw,readonly \ -drive file=img_2,if=pflash,fo

Re: [Qemu-devel] [PATCHv2 1.8 1/9] qemu-img: add support for skipping zeroes in input during convert

2013-11-26 Thread Peter Lieven
On 26.11.2013 11:02, Paolo Bonzini wrote: Il 26/11/2013 09:56, Peter Lieven ha scritto: we currently do not check if a sector is allocated during convert. This means if a sector is unallocated that we allocate a bounce buffer of zeroes, find out its zero later and do not write it in the best cas

Re: [Qemu-devel] [edk2] [qemu PATCH] hw/i386/pc_sysfw: support more than one flash drive

2013-11-26 Thread Paolo Bonzini
Il 25/11/2013 20:45, Laszlo Ersek ha scritto: > From looking at "hw/block/pflash_cfi01.c", it seems that the guest can > interrogate the flash device about its size (nb_blocs is stored in > cfi_table starting at 0x2D, and cfi_table can be queried by command 0x98 > in pflash_read()). So, if the gues

[Qemu-devel] [PATCH] virtio-rng: correct the default limit rate

2013-11-26 Thread Amos Kong
We have the following comment about the default limit rate: /* Set a default rate limit of 2^47 bytes per minute or roughly 2TB/s. If * you have an entropy source capable of generating more entropy than this * and you can pass it through via virtio-rng, then hats off to you. Until * then, thi

Re: [Qemu-devel] [RFC] create a single workqueue for each vm to update vm irq routing table

2013-11-26 Thread Paolo Bonzini
Il 26/11/2013 14:18, Avi Kivity ha scritto: > >> I don't think a workqueue is even needed. You just need to use call_rcu >> to free "old" after releasing kvm->irq_lock. >> >> What do you think? > > Can this cause an interrupt to be delivered to the wrong (old) vcpu? No, this would be exactly th

Re: [Qemu-devel] [edk2] [qemu PATCH] hw/i386/pc_sysfw: support more than one flash drive

2013-11-26 Thread Laszlo Ersek
On 11/26/13 14:41, Paolo Bonzini wrote: > Il 25/11/2013 20:45, Laszlo Ersek ha scritto: >> From looking at "hw/block/pflash_cfi01.c", it seems that the guest can >> interrogate the flash device about its size (nb_blocs is stored in >> cfi_table starting at 0x2D, and cfi_table can be queried by comm

Re: [Qemu-devel] [PATCH 16/17] migration: adjust migration_thread() process for page flipping

2013-11-26 Thread Lei Li
On 11/26/2013 08:54 PM, Paolo Bonzini wrote: Il 26/11/2013 13:03, Lei Li ha scritto: +if (pending_size && pending_size >= max_size && +!runstate_needs_reset()) { qemu_savevm_state_iterate(s->file); I'm not sure why you need this. The adjustment he

Re: [Qemu-devel] [PATCH] virtio-rng: correct the default limit rate

2013-11-26 Thread Paolo Bonzini
Il 26/11/2013 14:43, Amos Kong ha scritto: > /* Set a default rate limit of 2^47 bytes per minute or roughly 2TB/s. If > * you have an entropy source capable of generating more entropy than this > * and you can pass it through via virtio-rng, then hats off to you. Until > * then, this is unlim

Re: [Qemu-devel] [PULL for-1.8 1/2] pc: disable pci-info

2013-11-26 Thread Michael S. Tsirkin
On Tue, Nov 26, 2013 at 12:00:51PM +0100, Gerd Hoffmann wrote: > Hi, > > > I think it's down to other qemu bugs (such as _CRS not covering > > all of PCI memory), we shall just fix them. > > i.e. the attached patch should fixup things. > > cheers, > Gerd > Yes, I think it's a start. Q35 is

Re: [Qemu-devel] [PATCH 08/17] add unix_msgfd_lookup() to callback get_buffer

2013-11-26 Thread Lei Li
On 11/26/2013 07:31 PM, Paolo Bonzini wrote: Il 21/11/2013 10:11, Lei Li ha scritto: +/* + * recvmsg is called here to catch the control message for + * the exchange of PIPE file descriptor until it is received. + */ +len = recvmsg(s->s

Re: [Qemu-devel] [PATCH 14/17] add new RanState RAN_STATE_MEMORY_STALE

2013-11-26 Thread Lei Li
On 11/26/2013 08:28 PM, Paolo Bonzini wrote: Il 21/11/2013 10:11, Lei Li ha scritto: { RUN_STATE_DEBUG, RUN_STATE_SUSPENDED }, DEBUG -> MEMORY_STALE is missing. Good catch, I will add it, thanks. :) Paolo { RUN_STATE_RUNNING, RUN_STATE_SUSPENDED }, { RUN_STATE_SUSPEND

[Qemu-devel] [PATCH] SPARC: Add and use CPU_FEATURE_CASA

2013-11-26 Thread Sebastian Huber
The LEON3 processor has support for the CASA instruction which is normally only available for SPARC V9 processors. Binutils 2.24 and GCC 4.9 will support this instruction for LEON3. GCC uses it to generate C11 atomic operations. --- target-sparc/cpu.c |3 +- target-sparc/cpu.h

Re: [Qemu-devel] [edk2] [qemu PATCH] hw/i386/pc_sysfw: support more than one flash drive

2013-11-26 Thread Paolo Bonzini
Il 26/11/2013 14:53, Laszlo Ersek ha scritto: >> > >> > IIUC in the case of OVMF the guest "just knows" that there are multiple >> > devices backing the range. Is that right? > No, the guest (the flash driver) is unaware of that. It could know if it > wanted to, but it doesn't care. It cares abou

Re: [Qemu-devel] [PULL for-1.8 1/2] pc: disable pci-info

2013-11-26 Thread Laszlo Ersek
On 11/26/13 10:10, Michael S. Tsirkin wrote: > seabios manages to enumerate PCI with information exported from qemu > so why can't OVMF? SeaBIOS and qemu duplicate logic (code) between each other. src/fw/pciinit.c grabs RamSize over fw_cfg, and i440fx_mem_addr_setup() sets "pcimem_start" to one

Re: [Qemu-devel] [PATCH 16/17] migration: adjust migration_thread() process for page flipping

2013-11-26 Thread Paolo Bonzini
Il 26/11/2013 14:53, Lei Li ha scritto: > 1) ram_save_setup stage, it will send all the bytes in this stages >to destination, and send_pipefd by ram_control_before_iterate >at the end of it. ram_save_setup runs doesn't send anything from guest RAM. It sends the lengths of the various bloc

Re: [Qemu-devel] [PULL for-1.8 1/2] pc: disable pci-info

2013-11-26 Thread Laszlo Ersek
On 11/26/13 15:04, Michael S. Tsirkin wrote: > On Tue, Nov 26, 2013 at 12:00:51PM +0100, Gerd Hoffmann wrote: >> Hi, >> >>> I think it's down to other qemu bugs (such as _CRS not covering >>> all of PCI memory), we shall just fix them. >> >> i.e. the attached patch should fixup things. >> >> chee

Re: [Qemu-devel] [PATCH] virtio-rng: correct the default limit rate

2013-11-26 Thread Amos Kong
On Tue, Nov 26, 2013 at 02:58:26PM +0100, Paolo Bonzini wrote: > Il 26/11/2013 14:43, Amos Kong ha scritto: > > /* Set a default rate limit of 2^47 bytes per minute or roughly 2TB/s. If > > * you have an entropy source capable of generating more entropy than this > > * and you can pass it throug

Re: [Qemu-devel] [PATCH] virtio-rng: correct the default limit rate

2013-11-26 Thread Eric Blake
[adding libvirt] On 11/26/2013 06:58 AM, Paolo Bonzini wrote: > Il 26/11/2013 14:43, Amos Kong ha scritto: >> /* Set a default rate limit of 2^47 bytes per minute or roughly 2TB/s. If >> * you have an entropy source capable of generating more entropy than this >> * and you can pass it through v

Re: [Qemu-devel] KVM call agenda for 2013-11-26

2013-11-26 Thread Juan Quintela
Juan Quintela wrote: > Hi > > Please, send any topic that you are interested in covering. As there are no topics for agenda, call is cancelled. Later, Juan. > Thanks, Juan. > > Call details: > > 10:00 AM to 11:00 AM EDT > Every two weeks > > If you need phone number details, contact me pri

Re: [Qemu-devel] [RFC] create a single workqueue for each vm to update vm irq routing table

2013-11-26 Thread Avi Kivity
On Tue, Nov 26, 2013 at 3:47 PM, Paolo Bonzini wrote: > Il 26/11/2013 14:18, Avi Kivity ha scritto: > > > >> I don't think a workqueue is even needed. You just need to use call_rcu > >> to free "old" after releasing kvm->irq_lock. > >> > >> What do you think? > > > > Can this cause an interrupt

Re: [Qemu-devel] [PATCH 4/4] tpm: Provide libtpms software TPM backend

2013-11-26 Thread Corey Bryant
On 11/25/2013 10:04 PM, Xu, Quan wrote: Thanks Bryant, this problem has been solved by following "http://www.mail-archive.com/qemu-devel@nongnu.org/msg200808.html";. But there is another problem when run configure with "./configure --target-list=x86_64-softmmu --enable-tpm". The va

Re: [Qemu-devel] [PATCH] virtio-rng: correct the default limit rate

2013-11-26 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 26/11/2013 15:32, Eric Blake ha scritto: > Hmm. Libvirt is already converting a user's rate of bytes/period > into the qemu parameters, defaulting to 1 second as its default > period. Am I correct that as long as libvirt specified both rate > AND

Re: [Qemu-devel] [RFC] create a single workqueue for each vm to update vm irq routing table

2013-11-26 Thread Paolo Bonzini
Il 26/11/2013 15:36, Avi Kivity ha scritto: > > No, this would be exactly the same code that is running now: > > mutex_lock(&kvm->irq_lock); > old = kvm->irq_routing; > kvm_irq_routing_update(kvm, new); > mutex_unlock(&kvm->irq_lock); > >

  1   2   3   >