[Qemu-devel] [PATCH 0/2] block: Enable BDRV_O_SNAPSHOT with driver-specific options

2013-11-19 Thread Kevin Wolf
Currently you have to decide whether you want to use -snapshot/snapshot=on or driver-specific options, they don't go together. This series removes this limitation. Kevin Wolf (2): block: Enable BDRV_O_SNAPSHOT with driver-specific options qemu-iotests: Test snapshot mode block.c

[Qemu-devel] [PATCH 2/2] qemu-iotests: Test snapshot mode

2013-11-19 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- tests/qemu-iotests/051 | 17 +++ tests/qemu-iotests/051.out | 54 +- 2 files changed, 66 insertions(+), 5 deletions(-) diff --git a/tests/qemu-iotests/051 b/tests/qemu-iotests/051 index 3a75bda..b23d91b 100

Re: [Qemu-devel] [PATCH 1/2] block: Enable BDRV_O_SNAPSHOT with driver-specific options

2013-11-19 Thread Eric Blake
On 11/19/2013 08:37 AM, Kevin Wolf wrote: > In the case of snapshot=on, don't rely on the backing file path in the > temporary image any more, but override the backing file with the given > set of options. This way, block drivers that don't use a file name can > be accessed with snapshot=on, for ex

Re: [Qemu-devel] [PATCH 2/2] qemu-iotests: Test snapshot mode

2013-11-19 Thread Eric Blake
On 11/19/2013 08:37 AM, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/051 | 17 +++ > tests/qemu-iotests/051.out | 54 > +- > 2 files changed, 66 insertions(+), 5 deletions(-) Reviewed-by: Eric Blake -- Er

Re: [Qemu-devel] [RFC] Architecture to connect a userspace ethernet switch to QEMU guests via Virtio

2013-11-19 Thread Stefan Hajnoczi
On Tue, Nov 19, 2013 at 11:17:40AM +0100, Antonios Motakis wrote: > There have been discussions before on these lists on the topic of > connecting a QEMU guest running a virtio_net driver, with an external > userspace ethernet switch (Snabbswitch in particular). The essential > requirement in this

[Qemu-devel] [PULL] migration queue

2013-11-19 Thread Juan Quintela
Hi Anthony This includes the mmap() optimization from Peter Lieven. Please apply The following changes since commit 5c5432e7d630592ddcc1876ac8a1505f8f14ef15: Merge remote-tracking branch 'luiz/queue/qmp' into staging (2013-11-13 11:49:27 -0800) are available in the git repository at:

Re: [Qemu-devel] [PATCH for-1.7] pci: unregister vmstate_pcibus on unplug

2013-11-19 Thread Bandan Das
Andreas Färber writes: > Am 06.11.2013 23:52, schrieb Bandan Das: >> >> PCIBus registers a vmstate during init. Unregister it upon >> removal/unplug. >> >> Signed-off-by: Bandan Das > > Michael, this patch looks good for 1.7 to me, are you planning to still > pick it up? Only one small comment

[Qemu-devel] KVM call agenda for 2013-11-26

2013-11-19 Thread Juan Quintela
Hi Please, send any topic that you are interested in covering. Thanks, Juan. Call details: 10:00 AM to 11:00 AM EDT Every two weeks If you need phone number details, contact me privately.

[Qemu-devel] [PATCH v2 01/20] block: generalize BlockLimits handling to cover bdrv_aio_discard too

2013-11-19 Thread Paolo Bonzini
bdrv_co_discard is only covering drivers which have a .bdrv_co_discard() implementation, but not those with .bdrv_aio_discard(). Not very nice, and easy to avoid. Suggested-by: Kevin Wolf Signed-off-by: Paolo Bonzini --- block.c | 80 +

[Qemu-devel] [PATCH v2 05/20] block: handle ENOTSUP from discard in generic code

2013-11-19 Thread Paolo Bonzini
Similar to write_zeroes, let the generic code receive a ENOTSUP for discard operations. Since bdrv_discard has advisory semantics, we can just swallow the error. Signed-off-by: Paolo Bonzini --- block.c | 2 +- block/raw-posix.c | 12 ++-- 2 files changed, 7 insertions(+), 7

[Qemu-devel] [PATCH v2 08/20] block drivers: add discard/write_zeroes properties to bdrv_get_info implementation

2013-11-19 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- block/qcow2.c | 2 ++ block/qed.c | 2 ++ block/vdi.c | 3 +++ block/vhdx.c | 3 +++ block/vpc.c | 2 ++ 5 files changed, 12 insertions(+) diff --git a/block/qcow2.c b/block/qcow2.c index 2fe37ed..92ed895 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -

[Qemu-devel] [PATCH v2 03/20] block: add flags argument to bdrv_co_write_zeroes tracepoint

2013-11-19 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- block.c | 2 +- trace-events | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c index 909fddb..0c3f410 100644 --- a/block.c +++ b/block.c @@ -2880,7 +2880,7 @@ int coroutine_fn bdrv_co_write_zeroes(BlockDriverState *bs,

[Qemu-devel] [PATCH v2 09/20] block drivers: expose requirement for write same alignment from formats

2013-11-19 Thread Paolo Bonzini
This will let misaligned but large requests use zero clusters. This is important because the cluster size is not guest visible. Signed-off-by: Paolo Bonzini --- block/qcow2.c | 1 + block/qed.c | 1 + block/vmdk.c | 4 3 files changed, 6 insertions(+) diff --git a/block/qcow2.c b/block

[Qemu-devel] [PATCH v2 00/20] block & scsi: write_zeroes support through the whole stack

2013-11-19 Thread Paolo Bonzini
This series fixes the implementation of WRITE SAME in the SCSI emulation layer. On top of this, it ensures that zero writes from the guest can be offloaded to the host device or filesystem if that's supported. This is a relatively important part of the thin provisioning feature, and builds on the

[Qemu-devel] [PATCH v2 12/20] block/iscsi: check WRITE SAME support differently depending on MAY_UNMAP

2013-11-19 Thread Paolo Bonzini
The current check is right for MAY_UNMAP=1. For MAY_UNMAP=0, just try and fall back to regular writes as soon as a WRITE SAME command fails. Signed-off-by: Paolo Bonzini --- block/iscsi.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/block/iscsi.c b/bl

[Qemu-devel] [PATCH v2 13/20] block/iscsi: use UNMAP to write zeroes if LBPRZ=1

2013-11-19 Thread Paolo Bonzini
The latest revision of SCSI SBC clarifies the semantics of LBPRZ in a way that lets the iscsi driver remove the distinction between bdrv_unallocated_blocks_are_zero and bdrv_can_write_zeroes_with_unmap. See Table 8: "[If] the LBA became mapped as the result of an autonomous transition, and

[Qemu-devel] [PATCH v2 15/20] raw-posix: implement write_zeroes with MAY_UNMAP for block devices

2013-11-19 Thread Paolo Bonzini
See the next commit for the description of the Linux kernel problem that is worked around in raw_open_common. Signed-off-by: Paolo Bonzini --- block/raw-posix.c | 37 + 1 file changed, 37 insertions(+) diff --git a/block/raw-posix.c b/block/raw-posix.c index

[Qemu-devel] [PATCH v2 20/20] scsi-disk: correctly implement WRITE SAME

2013-11-19 Thread Paolo Bonzini
Fetch the data to be written from the input buffer. If it is all zeroes, we can use the write_zeroes call (possibly with the new MAY_UNMAP flag). Otherwise, do as many write cycles as needed, writing 512k at a time. Strictly speaking, this is still incorrect because a zero cluster should only be

[Qemu-devel] [PATCH v2 17/20] qemu-iotests: 033 is fast

2013-11-19 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- tests/qemu-iotests/group | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group index b18b241..4f86046 100644 --- a/tests/qemu-iotests/group +++ b/tests/qemu-iotests/group @@ -39,7 +39,7 @@ 030 rw a

[Qemu-devel] [PATCH v2 18/20] scsi-disk: catch write protection errors in UNMAP

2013-11-19 Thread Paolo Bonzini
This is the same that is already done for WRITE SAME. Signed-off-by: Paolo Bonzini --- hw/scsi/scsi-disk.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 74e6a14..4138268 100644 --- a/hw/scsi/scsi-disk.c +++ b/hw/scsi/scsi-disk.c @@ -154

[Qemu-devel] [PATCH v2 19/20] scsi-disk: reject ANCHOR=1 for UNMAP and WRITE SAME commands

2013-11-19 Thread Paolo Bonzini
Since we report ANC_SUP==0 in VPD page B2h, we need to return an error (ILLEGAL REQUEST/INVALID FIELD IN CDB) for all WRITE SAME requests with ANCHOR==1. Inspired by a similar patch to the LIO in-kernel target. Signed-off-by: Paolo Bonzini --- hw/scsi/scsi-disk.c | 12 +++- 1 file chang

Re: [Qemu-devel] [PATCH for 1.7] target-i386: do not override nr_cores for -cpu host

2013-11-19 Thread Benoît Canet
Le Tuesday 19 Nov 2013 à 17:49:46 (+0100), Paolo Bonzini a écrit : > Commit 787aaf5 (target-i386: forward CPUID cache leaves when -cpu host is > used, 2013-09-02) brings bits 31..26 of CPUID leaf 04h out of sync with > the APIC IDs that QEMU reserves for each package. This number must come > from

[Qemu-devel] [PATCH v2 02/20] block: add flags to BlockRequest

2013-11-19 Thread Paolo Bonzini
This lets bdrv_co_do_rw receive flags, so that it can be used for zero writes. Signed-off-by: Paolo Bonzini --- block.c | 17 +++-- include/block/block.h | 1 + 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/block.c b/block.c index 2e37040..909fddb 100

Re: [Qemu-devel] [PATCH 26/60] AArch64: Add ADR instruction emulation

2013-11-19 Thread Claudio Fontana
Hello all, On 09/27/2013 02:48 AM, Alexander Graf wrote: > This patch adds emulation support for the adr instruction. > > Signed-off-by: Alexander Graf > --- > target-arm/translate-a64.c | 24 > 1 file changed, 24 insertions(+) > > diff --git a/target-arm/translate-a64

Re: [Qemu-devel] [PATCH v2 20/20] scsi-disk: correctly implement WRITE SAME

2013-11-19 Thread ronnie sahlberg
+#define SCSI_WRITE_SAME_MAX 524288 ... +data->iov.iov_len = MIN(data->nb_sectors * 512, SCSI_WRITE_SAME_MAX); I don't think you should just clamp the data to 512k, instead I think you should report the 512k max write same size through BlockLimitsVPD/MaximumWriteSameLength to the init

[Qemu-devel] [PATCH for 1.7] target-i386: do not override nr_cores for -cpu host

2013-11-19 Thread Paolo Bonzini
Commit 787aaf5 (target-i386: forward CPUID cache leaves when -cpu host is used, 2013-09-02) brings bits 31..26 of CPUID leaf 04h out of sync with the APIC IDs that QEMU reserves for each package. This number must come from "-smp" options rather than from the host CPUID. It also turns out that thi

Re: [Qemu-devel] [PATCH v2 20/20] scsi-disk: correctly implement WRITE SAME

2013-11-19 Thread ronnie sahlberg
That means the initiator will do the "split into smaller manageable chunks" for you and you get a 1-to-1 mapping between WS10/16 that the initiator issues to qemu and the write-same calls that qemu generates. On Tue, Nov 19, 2013 at 9:23 AM, ronnie sahlberg wrote: > +#define SCSI_WRITE_SAME_MAX

Re: [Qemu-devel] [PATCH v2 20/20] scsi-disk: correctly implement WRITE SAME

2013-11-19 Thread Paolo Bonzini
Il 19/11/2013 18:23, ronnie sahlberg ha scritto: > +#define SCSI_WRITE_SAME_MAX 524288 > ... > +data->iov.iov_len = MIN(data->nb_sectors * 512, SCSI_WRITE_SAME_MAX); > > I don't think you should just clamp the data to 512k, instead I think > you should report the 512k max write same s

[Qemu-devel] [PATCH v2 11/20] block/iscsi: updated copyright

2013-11-19 Thread Paolo Bonzini
From: Peter Lieven added myself to reflect recent work on the iscsi block driver. Signed-off-by: Peter Lieven Signed-off-by: Paolo Bonzini --- block/iscsi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/iscsi.c b/block/iscsi.c index b6b62aa..20f4f55 100644 --- a/block/iscsi.c +++

Re: [Qemu-devel] [PATCH for-1.7] pci: unregister vmstate_pcibus on unplug

2013-11-19 Thread Andreas Färber
Am 19.11.2013 18:03, schrieb Bandan Das: > Andreas Färber writes: > >> Am 06.11.2013 23:52, schrieb Bandan Das: >>> >>> PCIBus registers a vmstate during init. Unregister it upon >>> removal/unplug. >>> >>> Signed-off-by: Bandan Das >> >> Michael, this patch looks good for 1.7 to me, are you pla

Re: [Qemu-devel] [PATCH for-1.7] pci: unregister vmstate_pcibus on unplug

2013-11-19 Thread Paolo Bonzini
Il 19/11/2013 18:33, Andreas Färber ha scritto: > Why? I still think that would be wrong. We had previously discussed with > Paolo that VMState is global state, which according to Anthony should > not be registered before realization. So far we have a mix of PCI host > bridges instantiating PCIBus

Re: [Qemu-devel] [PATCH for-1.7] pci: unregister vmstate_pcibus on unplug

2013-11-19 Thread Bandan Das
Andreas Färber writes: > Am 19.11.2013 18:03, schrieb Bandan Das: >> Andreas Färber writes: >> >>> Am 06.11.2013 23:52, schrieb Bandan Das: PCIBus registers a vmstate during init. Unregister it upon removal/unplug. Signed-off-by: Bandan Das >>> >>> Michael, this patch

[Qemu-devel] [PATCH v2 16/20] raw-posix: add support for write_zeroes on XFS and block devices

2013-11-19 Thread Paolo Bonzini
The code is similar to the implementation of discard and write_zeroes with UNMAP. However, failure must be propagated up to block.c. The stale page cache problem can be reproduced as follows: # modprobe scsi-debug lbpws=1 lbprz=1 # ./qemu-io /dev/sdXX qemu-io> write -P 0xcc 0 2M

Re: [Qemu-devel] [PATCH 26/60] AArch64: Add ADR instruction emulation

2013-11-19 Thread Claudio Fontana
On 11/19/2013 06:17 PM, Claudio Fontana wrote: > Hello all, > > On 09/27/2013 02:48 AM, Alexander Graf wrote: >> This patch adds emulation support for the adr instruction. >> >> Signed-off-by: Alexander Graf >> --- >> target-arm/translate-a64.c | 24 >> 1 file changed, 2

Re: [Qemu-devel] [PATCH for-1.7?] the calculation of bytes_xfer in qemu_put_buffer() is wrong

2013-11-19 Thread Stefan Weil
Am 19.11.2013 09:19, schrieb Paolo Bonzini: > Il 19/11/2013 06:53, Wangting (Kathy) ha scritto: >> In qemu_put_buffer(), bytes_xfer += size is wrong,it will be more than >> expected,and should be bytes_xfer += l. >> >> Signed-off-by: zhangmin >> --- >> savevm.c |2 +- >> 1 files changed, 1 inse

[Qemu-devel] [PATCH v2 04/20] block: add bdrv_aio_write_zeroes

2013-11-19 Thread Paolo Bonzini
This will be used by the SCSI layer. Signed-off-by: Paolo Bonzini --- block.c | 11 +++ include/block/block.h | 3 +++ trace-events | 1 + 3 files changed, 15 insertions(+) diff --git a/block.c b/block.c index 0c3f410..f5428f4 100644 --- a/block.c +++ b/block.c

[Qemu-devel] [PATCH v2 07/20] vpc, vhdx: add get_info

2013-11-19 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- block/vhdx.c | 11 +++ block/vpc.c | 14 ++ 2 files changed, 25 insertions(+) diff --git a/block/vhdx.c b/block/vhdx.c index 7d1af96..9ab2b39 100644 --- a/block/vhdx.c +++ b/block/vhdx.c @@ -1043,6 +1043,16 @@ static void vhdx_block_translate

Re: [Qemu-devel] [PATCH 26/60] AArch64: Add ADR instruction emulation

2013-11-19 Thread Peter Maydell
On 19 November 2013 17:52, Claudio Fontana wrote: > static void disas_pc_rel_adr(DisasContext *s, uint32_t insn) > { > /* > * 31 30 29 28 27 26 25 24 23 5 4 0 > * op immlo 1 0 0 0 0 immhi Rd > */ > unsigned int page, imm, rd, len; /* op -> page, immhi:immlo ->

Re: [Qemu-devel] [PATCH for-1.7?] the calculation of bytes_xfer in qemu_put_buffer() is wrong

2013-11-19 Thread Paolo Bonzini
Il 19/11/2013 18:55, Stefan Weil ha scritto: >>> >> diff --git a/savevm.c b/savevm.c >>> >> index 2f631d4..3f912dd 100644 >>> >> --- a/savevm.c >>> >> +++ b/savevm.c >>> >> @@ -794,7 +794,7 @@ void qemu_put_buffer(QEMUFile *f, const uint8_t >>> >> *buf, int size) >>> >> if (l > size) >>>

Re: [Qemu-devel] [PATCH 26/60] AArch64: Add ADR instruction emulation

2013-11-19 Thread Peter Maydell
On 19 November 2013 18:03, Peter Maydell wrote: > On 19 November 2013 17:52, Claudio Fontana wrote: >> static void disas_pc_rel_adr(DisasContext *s, uint32_t insn) >> { >> /* >> * 31 30 29 28 27 26 25 24 23 5 4 0 >> * op immlo 1 0 0 0 0 immhi Rd >> */ >> unsig

[Qemu-devel] [PATCH v2 14/20] raw-posix: implement write_zeroes with MAY_UNMAP for files

2013-11-19 Thread Paolo Bonzini
Writing zeroes to a file can be done by punching a hole if MAY_UNMAP is set. Note that in this case ENOTSUP is not ignored, but makes the block layer fall back to the generic implementation. Signed-off-by: Paolo Bonzini --- block/raw-posix.c | 66

[Qemu-devel] [PATCH v2 06/20] block: make bdrv_co_do_write_zeroes stricter in producing aligned requests

2013-11-19 Thread Paolo Bonzini
Right now, bdrv_co_do_write_zeroes will only try to align the beginning of the request. However, it is simpler for many formats to expect the block layer to separate both the head *and* the tail. This makes sure that the format's bdrv_co_write_zeroes function will be called with aligned sector_nu

[Qemu-devel] [PATCH] Don't crash on keyboard input with no handler

2013-11-19 Thread Don Koch
Prevent a call to put_kbd if null. On shutdown of some OSes, the keyboard handler goes away before the system is down. If a key is typed during this window, qemu crashes. Signed-off-by: Don Koch --- I left the printf call, originally for testing, but useful as a sanity check if the user wonders

[Qemu-devel] [PATCH v2 10/20] block/iscsi: remove .bdrv_has_zero_init

2013-11-19 Thread Paolo Bonzini
From: Peter Lieven since commit 3ac21627 the default value changed to 0. Signed-off-by: Peter Lieven Signed-off-by: Paolo Bonzini --- block/iscsi.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index b7b5238..b6b62aa 100644 --- a/block/iscsi.c +++ b/b

[Qemu-devel] [PATCH 1/2] smbios: Add type 41 structure (Onboard Devices Extended Information).

2013-11-19 Thread Ivan Mironov
Signed-off-by: Ivan Mironov --- hw/i386/smbios.c | 219 ++- include/hw/i386/smbios.h | 11 +++ qemu-options.hx | 42 - 3 files changed, 268 insertions(+), 4 deletions(-) diff --git a/hw/i386/smbios.c b/hw/i386/smbios.c index

[Qemu-devel] [PATCH 0/2] Add support for biosdevname inside VM

2013-11-19 Thread Ivan Mironov
Hello! These patches adds support for providing SMBIOS "Onboard Devices Extended Information" fields to the guest i386/x86_64 system. This could be used in conjunction with biosdevname to provide "consistent network device naming" inside VM. I will also send corresponding patches to seab...@se

[Qemu-devel] [PATCH 2/2] smbios: Allow device ID instead of PCI address for type 41.

2013-11-19 Thread Ivan Mironov
Signed-off-by: Ivan Mironov --- hw/i386/pc.c | 12 + hw/i386/smbios.c | 129 +++ include/hw/i386/smbios.h | 1 + qemu-options.hx | 8 ++- 4 files changed, 128 insertions(+), 22 deletions(-) diff --git a/hw/i386/pc.

Re: [Qemu-devel] [PATCH] Don't crash on keyboard input with no handler

2013-11-19 Thread Stefan Weil
Am 19.11.2013 19:26, schrieb Don Koch: > Prevent a call to put_kbd if null. > > On shutdown of some OSes, the keyboard handler goes away before the > system is down. If a key is typed during this window, qemu crashes. > > Signed-off-by: Don Koch > --- > I left the printf call, originally for testi

Re: [Qemu-devel] [PATCH] Don't crash on keyboard input with no handler

2013-11-19 Thread Don Koch
On 11/19/2013 02:17 PM, Stefan Weil wrote: > Am 19.11.2013 19:26, schrieb Don Koch: >> Prevent a call to put_kbd if null. >> >> On shutdown of some OSes, the keyboard handler goes away before the >> system is down. If a key is typed during this window, qemu crashes. >> >> Signed-off-by: Don Koch >

Re: [Qemu-devel] [PATCH 4/4] tpm: Provide libtpms software TPM backend

2013-11-19 Thread Stefan Berger
On 11/06/2013 09:39 AM, Corey Bryant wrote: This patch provides a software TPM backend implementation. The core software TPM functionality is provided by the libtpms library. With this patch, multiple guests can run with their own emulated TPMs. The libtpms repository can be found at: https://g

Re: [Qemu-devel] [PATCH 0/4] tpm: Provide a software vTPM

2013-11-19 Thread Anthony Liguori
On Wed, Nov 6, 2013 at 6:38 AM, Corey Bryant wrote: > This patch series provides support for a software Trusted Platform > Module (otherwise known as a vTPM). This support is provided via a > new backend that works with the existing QEMU tpm-tis front end. We do device emulation within QEMU. Th

[Qemu-devel] ARM cpu object, setting properties from board model

2013-11-19 Thread Peter Maydell
I find myself with a use case where I would like to set a CPU object property from the board model init function (specifically, I'd like the board model to be able to say "this CPU will boot via PSCI so if you're KVM then start it appropriately"). I could just reach in and fiddle with the ARMCPU f

[Qemu-devel] [PATCH v2] Don't crash on keyboard input with no handler

2013-11-19 Thread Don Koch
Prevent a call to put_kbd if null. On shutdown of some OSes, the keyboard handler goes away before the system is down. If a key is typed during this window, qemu crashes. Signed-off-by: Don Koch --- v2: punt printf() ui/input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Qemu-devel] ARM cpu object, setting properties from board model

2013-11-19 Thread Peter Maydell
On 19 November 2013 20:01, Peter Maydell wrote: > I find myself with a use case where I would like to set > a CPU object property from the board model init function > (specifically, I'd like the board model to be able to say > "this CPU will boot via PSCI so if you're KVM then start > it appropria

Re: [Qemu-devel] ARM cpu object, setting properties from board model

2013-11-19 Thread Igor Mammedov
On Tue, 19 Nov 2013 20:01:28 + Peter Maydell wrote: > I find myself with a use case where I would like to set > a CPU object property from the board model init function > (specifically, I'd like the board model to be able to say > "this CPU will boot via PSCI so if you're KVM then start > it

Re: [Qemu-devel] [PATCH 23/60] AArch64: Add AdvSIMD modified immediate group handling

2013-11-19 Thread Janne Grunau
On 2013-09-27 02:48:17 +0200, Alexander Graf wrote: > This patch adds support for the AdvSIMD modified immediate group with > all its suboperations (movi, orr, fmov, mvni, bic). > > Signed-off-by: Alexander Graf > --- > target-arm/translate-a64.c | 129 >

Re: [Qemu-devel] [PATCH 50/60] AArch64: Add "Floating-point<->fixed-point

2013-11-19 Thread Janne Grunau
On 2013-09-27 02:48:44 +0200, Alexander Graf wrote: > This patch adds emulation for the instruction group labeled > "Floating-point <-> fixed-point conversions" in the ARM ARM. > > Namely this includes the instructions SCVTF, UCVTF, FCVTZS, FCVTZU > (scalar, fixed-point). > > Signed-off-by: Alexa

Re: [Qemu-devel] [PATCH 1/4] qcow2: Move reading nb_snapshots in qcow2_open

2013-11-19 Thread Eric Blake
On 11/17/2013 07:18 AM, Max Reitz wrote: > Any goto fail between having read nb_snapshots (returning a non-zero > value) and allocating s->snapshots (through qcow2_read_snapshots()) > results in qcow2_free_snapshots() being called, dereferencing > s->snapshots which is still NULL. > > Fix this by

Re: [Qemu-devel] [PATCH 2/4] qcow2-refcount: Sanitize refcount table size

2013-11-19 Thread Eric Blake
On 11/17/2013 07:18 AM, Max Reitz wrote: > Make sure the refcount table size will not overflow when multiplied by > sizeof(uint64_t) and implicitly casted to int. s/casted/cast/ > > Signed-off-by: Max Reitz > --- > block/qcow2-refcount.c | 4 > 1 file changed, 4 insertions(+) Reviewed-by

Re: [Qemu-devel] [PATCH 3/4] qcow2: Sanitize refcount table size

2013-11-19 Thread Eric Blake
On 11/17/2013 07:18 AM, Max Reitz wrote: > Make sure there were no overflows when calculating the in-memory > refcount table size from the number of its clusters in-file. > > Signed-off-by: Max Reitz > --- > block/qcow2.c | 8 > 1 file changed, 8 insertions(+) Reviewed-by: Eric Blake

Re: [Qemu-devel] [PATCH 4/4] qcow2: Check validity of backing file name length

2013-11-19 Thread Eric Blake
On 11/17/2013 07:18 AM, Max Reitz wrote: > The len variable is a signed integer, therefore it may overflow when > reading the backing file name length from the qcow2 image header. This > case should be handled explicitly. > > Signed-off-by: Max Reitz > --- > block/qcow2.c | 5 + > 1 file cha

Re: [Qemu-devel] [edk2] [edk2 PATCH 0/1] OvmfPkg: grab ACPI tables from QEMU

2013-11-19 Thread Michael S. Tsirkin
On Tue, Nov 19, 2013 at 01:31:39PM +0100, Laszlo Ersek wrote: > On 11/19/13 09:54, Gerd Hoffmann wrote: > > Hi, > > > >> ACPI PciWindow32: Base=0xA000 End=0xFEEF Length=0x5EF0 > > > >> begin32=c000 end32=fec0 begin64=0 end64=0 > > > > qemu & seabios pick a 32bit window siz

Re: [Qemu-devel] [edk2] [edk2 PATCH 0/1] OvmfPkg: grab ACPI tables from QEMU

2013-11-19 Thread Michael S. Tsirkin
On Tue, Nov 19, 2013 at 01:31:39PM +0100, Laszlo Ersek wrote: > On 11/19/13 09:54, Gerd Hoffmann wrote: > > Hi, > > > >> ACPI PciWindow32: Base=0xA000 End=0xFEEF Length=0x5EF0 > > > >> begin32=c000 end32=fec0 begin64=0 end64=0 > > > > qemu & seabios pick a 32bit window siz

Re: [Qemu-devel] [PATCH 0/4] tpm: Provide a software vTPM

2013-11-19 Thread Corey Bryant
On 11/19/2013 02:50 PM, Anthony Liguori wrote: On Wed, Nov 6, 2013 at 6:38 AM, Corey Bryant wrote: This patch series provides support for a software Trusted Platform Module (otherwise known as a vTPM). This support is provided via a new backend that works with the existing QEMU tpm-tis front

Re: [Qemu-devel] [edk2] [edk2 PATCH 0/1] OvmfPkg: grab ACPI tables from QEMU

2013-11-19 Thread Laszlo Ersek
On 11/19/13 22:13, Michael S. Tsirkin wrote: > On Tue, Nov 19, 2013 at 01:31:39PM +0100, Laszlo Ersek wrote: >> On 11/19/13 09:54, Gerd Hoffmann wrote: >>> Hi, >>> ACPI PciWindow32: Base=0xA000 End=0xFEEF Length=0x5EF0 >>> begin32=c000 end32=fec0 begin64=0 end64=

Re: [Qemu-devel] [edk2] [edk2 PATCH 0/1] OvmfPkg: grab ACPI tables from QEMU

2013-11-19 Thread Michael S. Tsirkin
On Tue, Nov 19, 2013 at 10:39:06PM +0100, Laszlo Ersek wrote: > On 11/19/13 22:13, Michael S. Tsirkin wrote: > > On Tue, Nov 19, 2013 at 01:31:39PM +0100, Laszlo Ersek wrote: > >> On 11/19/13 09:54, Gerd Hoffmann wrote: > >>> Hi, > >>> > ACPI PciWindow32: Base=0xA000 End=0xFEEF Len

[Qemu-devel] commit b1bbfe72 causes huge slowdown with no kvm

2013-11-19 Thread Luigi Rizzo
I recently found out that without kvm enabled, and especially with -smp 2 or greater, qemu becomes incredibly slow (to the point that you can see kernel messages in the quest print one character at a time). This happens with a Linux host (even with -smp 1) and with FreeBSD host (in this case -smp

Re: [Qemu-devel] [PATCH 0/4] tpm: Provide a software vTPM

2013-11-19 Thread Anthony Liguori
On Tue, Nov 19, 2013 at 1:32 PM, Corey Bryant wrote: > > On 11/19/2013 02:50 PM, Anthony Liguori wrote: >> >> On Wed, Nov 6, 2013 at 6:38 AM, Corey Bryant >> wrote: >>> >>> This patch series provides support for a software Trusted Platform >>> Module (otherwise known as a vTPM). This support is

Re: [Qemu-devel] [PATCH v3 1/2] linux-user: create target_structsheader to place ipc_perm and shmid_dss

2013-11-19 Thread Petar Jovanovic
ping http://patchwork.ozlabs.org/patch/287211/ http://patchwork.ozlabs.org/patch/287213/ From: Petar Jovanovic Sent: Tuesday, November 12, 2013 4:40 PM To: qemu-devel@nongnu.org; riku.voi...@linaro.org Cc: Petar Jovanovic; peter.mayd...@linaro.org; aurel...

[Qemu-devel] [PATCH v2 0/2] Add support for biosdevname inside VM

2013-11-19 Thread Ivan Mironov
Hello! These patches adds support for providing SMBIOS "Onboard Devices Extended Information" fields to the guest i386/x86_64 system. This could be used in conjunction with biosdevname to provide "consistent network device naming" inside VM. I will also send corresponding patches to seab...@se

[Qemu-devel] [PATCH v2 1/2] smbios: Add type 41 structure (Onboard Devices Extended Information).

2013-11-19 Thread Ivan Mironov
Signed-off-by: Ivan Mironov --- hw/i386/smbios.c | 219 ++- include/hw/i386/smbios.h | 11 +++ qemu-options.hx | 42 - 3 files changed, 268 insertions(+), 4 deletions(-) diff --git a/hw/i386/smbios.c b/hw/i386/smbios.c index

[Qemu-devel] [PATCH v2 2/2] smbios: Allow device ID instead of PCI address for type 41.

2013-11-19 Thread Ivan Mironov
Signed-off-by: Ivan Mironov --- hw/i386/pc.c | 12 + hw/i386/smbios.c | 129 +++ include/hw/i386/smbios.h | 1 + qemu-options.hx | 8 ++- 4 files changed, 128 insertions(+), 22 deletions(-) diff --git a/hw/i386/pc.

Re: [Qemu-devel] Are there any IOMMU emulation in QEMU for x86 platform

2013-11-19 Thread Jiang, Yunhong
> -Original Message- > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Tuesday, November 19, 2013 1:14 AM > To: Jiang, Yunhong > Cc: qemu-devel@nongnu.org; da...@gibson.dropbear.id.au; > eduard.munte...@linux360.ro > Subject: Re: Are there any IOM

[Qemu-devel] [PATCH SeaBIOS v4] map 64-bit PCI BARs at location provided by emulator

2013-11-19 Thread Igor Mammedov
Currently 64-bit PCI BARs are unconditionally mapped by BIOS right over 4G + RamSizeOver4G location, which doesn't allow to reserve extra space before 64-bit PCI window. For memory hotplug an extra RAM space might be reserved after present 64-bit RAM end and BIOS should map 64-bit PCI BARs after it

Re: [Qemu-devel] [SeaBIOS] [PATCH SeaBIOS v4] map 64-bit PCI BARs at location provided by emulator

2013-11-19 Thread Igor Mammedov
On Wed, 20 Nov 2013 01:08:33 +0100 Igor Mammedov wrote: Sorry for noise, patch doesn't apply on top of current master. I'll resubmit rebased v5. -- Regards, Igor

[Qemu-devel] [PATCH SeaBIOS v5] map 64-bit PCI BARs at location provided by emulator

2013-11-19 Thread Igor Mammedov
Currently 64-bit PCI BARs are unconditionally mapped by BIOS right over 4G + RamSizeOver4G location, which doesn't allow to reserve extra space before 64-bit PCI window. For memory hotplug an extra RAM space might be reserved after present 64-bit RAM end and BIOS should map 64-bit PCI BARs after it

Re: [Qemu-devel] [V2 PATCH 12/14] target-ppc: VSX Stage 4: Add Scalar SP Fused Multiply-Adds

2013-11-19 Thread Richard Henderson
On 11/19/2013 11:40 PM, Tom Musta wrote: > +/* NOTE: in order to get accurate results, we must first round back */ > \ > +/* to single precision and use the fused multiply add routine */ > \ > +/* for 32-bit floats. */ > \

Re: [Qemu-devel] [PATCH 0/7] virtio endian-ambivalent target fixes.

2013-11-19 Thread Rusty Russell
Thomas Huth writes: > On Thu, 17 Oct 2013 14:23:35 +1030 > Rusty Russell wrote: > >> This is a re-transmit of the core of the virtio endian code. Since >> there seems to be some interest in ARM BE virtio, I've separated this from >> the direct problem I was solving: PowerPC LE. >> >> Please app

Re: [Qemu-devel] [PATCH v5 0/4] Use blkdebug to make test deterministic

2013-11-19 Thread Fam Zheng
On 2013年11月19日 23:31, Stefan Hajnoczi wrote: On Mon, Nov 18, 2013 at 03:01:47PM +0800, Fam Zheng wrote: This adds "remove_break" command to block, which removes a break point defined with "break". It is used in iotests.py to pause and resume drive in block job cases to make the test deterministi

[Qemu-devel] [PATCH v6 4/4] qemu-iotests: Make test case 030, 040 and 055 deterministic

2013-11-19 Thread Fam Zheng
Pause the drive and start the block job, so we won't miss the block job. Signed-off-by: Fam Zheng --- tests/qemu-iotests/030 | 16 +++- tests/qemu-iotests/040 | 4 +++- tests/qemu-iotests/055 | 14 +++--- 3 files changed, 25 insertions(+), 9 deletions(-) diff --git a/tests/

[Qemu-devel] [PATCH v6 0/4] Use blkdebug to make test deterministic

2013-11-19 Thread Fam Zheng
This adds "remove_break" command to block, which removes a break point defined with "break". It is used in iotests.py to pause and resume drive in block job cases to make the test deterministic. v6: [04] Fix 055 race condition by keeping sleep after resume_drive. (Stefan) v5: Addressing Max's com

[Qemu-devel] [PATCH v6 1/4] qemu-iotests: Drop local version of cancel_and_wait from 040

2013-11-19 Thread Fam Zheng
iotests.py already has one. Signed-off-by: Fam Zheng --- tests/qemu-iotests/040 | 15 --- 1 file changed, 15 deletions(-) diff --git a/tests/qemu-iotests/040 b/tests/qemu-iotests/040 index a2e18c5..0e85136 100755 --- a/tests/qemu-iotests/040 +++ b/tests/qemu-iotests/040 @@ -39,21 +3

[Qemu-devel] [PATCH v6 3/4] qemu-iotest: Add pause_drive and resume_drive methods

2013-11-19 Thread Fam Zheng
They wrap blkdebug "break" and "remove_break". Add optional argument "resume" to cancel_and_wait(). Signed-off-by: Fam Zheng --- tests/qemu-iotests/iotests.py | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotest

[Qemu-devel] [PATCH v6 2/4] blkdebug: add "remove_break" command

2013-11-19 Thread Fam Zheng
This adds "remove_break" command which is the reverse of blkdebug command "break": it removes all breakpoints with given tag and resumes all the requests. Signed-off-by: Fam Zheng --- block.c | 13 + block/blkdebug.c | 27 +++ includ

Re: [Qemu-devel] [PATCH 0/4 v4] block, arm: Fix buffered flash writes on VExpress

2013-11-19 Thread Roy Franz
Peter - is this series acceptable? I have reviewed the patches based on our conversation at Connect, and patch 3 already handles returning the status based on device width as we discussed. If device and bank width are different, it repeats the status based on device width. Otherwise, if both wid

[Qemu-devel] [PATCH v2 0/2] qemu-iotests: Filter out "qemu-io> " in all tests

2013-11-19 Thread Fam Zheng
The second patch is too large as a mail, you can pull from: https://github.com/famz/qemu.git 035-filter-qemu-io v2: Rebase to current master. [01] Add Reviewed-by for Eric. [02] Update comment to describe the command for mechanical substitution. (Eric) Fam Zheng (2): qemu-iotests:

[Qemu-devel] [PATCH v2 2/2] qemu-iotests: Filter out 'qemu-io> ' prompt

2013-11-19 Thread Fam Zheng
This removes "qemu-io> " prompt from qemu-io output in _filter_qemu_io, and updates all the output files with the following command: cd tests/qemu-iotests && sed -i "s/qemu-io> //g" *.out Signed-off-by: Fam Zheng --- This patch is snipped because the size would be rejected by list. See cover

[Qemu-devel] [PATCH v2 1/2] qemu-iotests: Filter qemu-io output in 025

2013-11-19 Thread Fam Zheng
Signed-off-by: Fam Zheng Reviewed-by: Eric Blake --- tests/qemu-iotests/025 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/025 b/tests/qemu-iotests/025 index a7241cc..9426c93 100755 --- a/tests/qemu-iotests/025 +++ b/tests/qemu-iotests/025 @@ -56,7 +56,7 @

Re: [Qemu-devel] [RFC PATCH v3 0/2] Point-in-time snapshot exporting over NBD

2013-11-19 Thread Ian Main
On Thu, Oct 17, 2013 at 01:36:41PM +0800, Fam Zheng wrote: > This series adds for point-in-time snapshot NBD exporting based on > blockdev-backup (variant of drive-backup with existing device as target). In general this seems to work great. I did a bunch of testing and was able to mount filesyste

Re: [Qemu-devel] [PATCH v2 2/2] qemu-iotests: Filter out 'qemu-io> ' prompt

2013-11-19 Thread Eric Blake
On 11/19/2013 07:25 PM, Fam Zheng wrote: > This removes "qemu-io> " prompt from qemu-io output in _filter_qemu_io, > and updates all the output files with the following command: > > cd tests/qemu-iotests && sed -i "s/qemu-io> //g" *.out > > Signed-off-by: Fam Zheng > --- > > This patch is snip

Re: [Qemu-devel] console muti-head some more design input

2013-11-19 Thread Dave Airlie
On Tue, Nov 19, 2013 at 6:11 PM, Gerd Hoffmann wrote: > Hi, > >> So I felt I had a choice here for sharing a single output surface >> amongst outputs: >> >> a) have multiple QemuConsole reference multiple DisplaySurface wihch >> reference a single pixman image, > > This one. > >> In either case

Re: [Qemu-devel] console muti-head some more design input

2013-11-19 Thread John Baboval
On Nov 19, 2013, at 9:59 PM, Dave Airlie wrote: > On Tue, Nov 19, 2013 at 6:11 PM, Gerd Hoffmann wrote: >> Hi, >> >>> So I felt I had a choice here for sharing a single output surface >>> amongst outputs: >>> >>> a) have multiple QemuConsole reference multiple DisplaySurface wihch >>> refer

Re: [Qemu-devel] console muti-head some more design input

2013-11-19 Thread Dave Airlie
>> Have a look the virtio-gpu branch in my repo (don't look at the >> history, its ugly, just the final state), you'll see code in sdl2.c to >> do input translation from window coordinates to the overall screen >> space. So we need at least the x,y offset in the ui code, and I think >> we need to c

Re: [Qemu-devel] console muti-head some more design input

2013-11-19 Thread Dave Airlie
On Wed, Nov 20, 2013 at 3:17 PM, Dave Airlie wrote: >>> Have a look the virtio-gpu branch in my repo (don't look at the >>> history, its ugly, just the final state), you'll see code in sdl2.c to >>> do input translation from window coordinates to the overall screen >>> space. So we need at least t

Re: [Qemu-devel] [PATCH for-1.7?] the calculation of bytes_xfer in qemu_put_buffer() is wrong

2013-11-19 Thread Wangting (Kathy)
Hi Paolo and Stefan, I am really sorry for my email before that I didn't say clearly about the bug fix. f->bytes_xfer means the number of bytes which is send from source to destination during the migration. It is limited by the f->xfer_limit which is converted from bandwidth. That means if byt

[Qemu-devel] [PATCH] spapr-iommu: extend SPAPR_TCE_TABLE class

2013-11-19 Thread Alexey Kardashevskiy
This adds a put_tce() callback to the SPAPR TCE TABLE device class. The new callback allows to have different IOMMU types such as upcoming VFIO IOMMU and it will be used more by the upcoming Multi-TCE support. This reworks the H_PUT_TCE handler to make use of the new put_tce() callback. Signed-of

[Qemu-devel] [PATCH 2/8] console: add state notifiers for ui<->display

2013-11-19 Thread Dave Airlie
From: Dave Airlie These are to be used for the UI to signal the video display, and vice-versa about changes in the state of a console, like size and offsets in relation to other consoles for input handling. Signed-off-by: Dave Airlie --- include/ui/console.h | 8 +++- ui/console.c

[Qemu-devel] [RFC] virtio-gpu and sdl2 so far

2013-11-19 Thread Dave Airlie
Hey, I thought I should post this for a bit more feedback and show where I've gone so far, all available in git http://cgit.freedesktop.org/~airlied/qemu/log/?h=virtio-gpu The first patch is the sdl2 port with some minor changes I posted before, then there are a bunch of console changes that I t

[Qemu-devel] [PATCH 4/8] console: add ability to wrap a console.

2013-11-19 Thread Dave Airlie
From: Dave Airlie In order to implement virtio-vga on top of virtio-gpu we need to be able to wrap the first console virtio-gpu registers from inside virtio-vga which initialises after virtio-gpu. With this interface virtio-vga can store the virtio-gpu interfaces, and call them from its own ones.

[Qemu-devel] [PATCH 1/8] ui/sdl2 : initial port to SDL 2.0 (v1.2)

2013-11-19 Thread Dave Airlie
From: Dave Airlie I've ported the SDL1.2 code over, and rewritten it to use the SDL2 interface. The biggest changes were in the input handling, where SDL2 has done a major overhaul, and I've had to include a generated translation file to get from SDL2 codes back to qemu compatible ones. I'm stil

<    1   2   3   >