On 11/17/2013 07:18 AM, Max Reitz wrote: > Any goto fail between having read nb_snapshots (returning a non-zero > value) and allocating s->snapshots (through qcow2_read_snapshots()) > results in qcow2_free_snapshots() being called, dereferencing > s->snapshots which is still NULL. > > Fix this by moving the reading of nb_snapshots right before the call to > qcow2_read_snapshots(). > > Signed-off-by: Max Reitz <mre...@redhat.com> > --- > block/qcow2.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-)
Are you intending this series as a bug fix for 1.7? Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
