Re: [Qemu-devel] [PATCH] qemu-img create: set nocow flag by default

2013/11/12 Fam Zheng > On 2013年11月07日 16:08, Chunyan Liu wrote: > >> Set NOCOW flag to newly created images to solve performance issues on >> btrfs. >> >> Btrfs has terrible performance when hosting VM images, even more when the >> guest >> in those VM are also using btrfs as file system. One way

Re: [Qemu-devel] audit needed for signal handlers

On Mo, 2013-11-11 at 18:47 +0100, Paolo Bonzini wrote: > Il 11/11/2013 18:13, Peter Maydell ha scritto: > >> > That said, aren't all signals in QEMU (except SIG_IPI) caught with > >> > signalfd and the handlers run synchronously in the iothread? > > Eric specifically points out one which is not. >

[Qemu-devel] [PATCH] curses: fixup SIGWINCH handler mess

Don't run code in the signal handler, only set a flag. Use sigaction(2) to avoid non-portable signal(2) semantics. Make #ifdefs less messy. Signed-off-by: Gerd Hoffmann --- ui/curses.c | 44 1 file changed, 28 insertions(+), 16 deletions(-) diff --gi

Re: [Qemu-devel] [PATCHv7 10/17] block: honour BlockLimits in bdrv_co_discard

On 11.11.2013 14:20, Kevin Wolf wrote: Am 24.10.2013 um 12:06 hat Peter Lieven geschrieben: Reviewed-by: Eric Blake Signed-off-by: Peter Lieven --- block.c | 37 - 1 file changed, 36 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c index 0c0

Re: [Qemu-devel] [PATCH] qga: Fix shutdown command of guest agent to work with SysV

What about patch? Will it be applied? Or should it be rewritten? On Thu, 07 Nov 2013 11:45:25 +0900, whitearchey wrote: On Wed, 06 Nov 2013 18:20:36 +0900, Michael Tokarev wrote: 06.11.2013 05:54, whitearchey wrote: For now guest agent uses following command to shutdown system: shutdown -P

Re: [Qemu-devel] [PATCHv7 10/17] block: honour BlockLimits in bdrv_co_discard

Il 12/11/2013 09:53, Peter Lieven ha scritto: > Good point. I wonder noone noticed before ;-) > > Do you want me to respin or is ok to send a follow up patch? > Stefan has it already in block-next. This patch doesn't make > the situation worse and we need follow up patches for > all the drivers to

Re: [Qemu-devel] [PATCHv7 10/17] block: honour BlockLimits in bdrv_co_discard

On 12.11.2013 10:19, Paolo Bonzini wrote: Il 12/11/2013 09:53, Peter Lieven ha scritto: Good point. I wonder noone noticed before ;-) Do you want me to respin or is ok to send a follow up patch? Stefan has it already in block-next. This patch doesn't make the situation worse and we need follow

Re: [Qemu-devel] [PATCHv7 10/17] block: honour BlockLimits in bdrv_co_discard

Am 12.11.2013 um 10:21 hat Peter Lieven geschrieben: > On 12.11.2013 10:19, Paolo Bonzini wrote: > >Il 12/11/2013 09:53, Peter Lieven ha scritto: > >>Good point. I wonder noone noticed before ;-) > >> > >>Do you want me to respin or is ok to send a follow up patch? > >>Stefan has it already in bloc

Re: [Qemu-devel] [PATCH v3 4/6] qemu-option: support +foo/-foo command line agruments

On Tue, 12 Nov 2013 10:49:58 +1100 Alexey Kardashevskiy wrote: > On 11/12/2013 01:25 AM, Igor Mammedov wrote: > > On Mon, 11 Nov 2013 13:41:05 +0100 > > Andreas Färber wrote: > > > >> Am 11.11.2013 08:44, schrieb Alexey Kardashevskiy: > >>> This converts +foo/-foo to "foo=on"/"foo=off" respecti

Re: [Qemu-devel] [RFC PATCH 2/4] block/raw-posix: implement bdrv_zero_init

Am 12.11.2013 um 08:47 hat Hu Tao geschrieben: > Implement bdrv_zero_init using posix_fallocate. > > Signed-off-by: Hu Tao > --- > block/raw-posix.c | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/block/raw-posix.c b/block/raw-posix.c > index f6d48bb..8798599 100644 > --

Re: [Qemu-devel] [RFC PATCH 4/4] qcow2: Add full image preallocation option

Am 12.11.2013 um 08:47 hat Hu Tao geschrieben: > This adds a preallocation=full mode to qcow2 image creation, which > creates a non-sparse image file. > > Signed-off-by: Hu Tao > --- > block/qcow2.c | 28 ++-- > 1 file changed, 22 insertions(+), 6 deletions(-) > > diff -

Re: [Qemu-devel] [PATCH v2] block: per caller dirty bitmap

Am 04.11.2013 um 10:30 hat Fam Zheng geschrieben: > Previously a BlockDriverState has only one dirty bitmap, so only one > caller (e.g. a block job) can keep track of writing. This changes the > dirty bitmap to a list and creates a BdrvDirtyBitmap for each caller, the > lifecycle is managed with th

Re: [Qemu-devel] [RFC] target-arm: provide skeleton for a64 insn decoding

claudio.font...@linaro.org writes: > provide a skeleton for a64 instruction decoding in translate-a64.c, > by dividing instructions into the classes defined by the > ARM Architecture Reference Manual(DDI0487A_a) C3 > > Signed-off-by: Claudio Fontana > --- > The following patch has been started d

Re: [Qemu-devel] [PATCH for-1.7] target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid()

On 11 November 2013 23:21, Anthony Liguori wrote: > We're not talking about something obscure here. It's eliminating an > if(0) block. No, we're not talking about a simple "if (0)" expression. What we had in this case was if (!(env->features[FEAT_1_ECX] & CPUID_EXT_XSAVE) || !kvm_enabled()) {

Re: [Qemu-devel] [PATCH v3] qmp: access the local QemuOptsLists for drive option

Am 09.11.2013 um 05:15 hat Amos Kong geschrieben: > Currently we have three QemuOptsList (qemu_common_drive_opts, > qemu_legacy_drive_opts, and qemu_drive_opts), only qemu_drive_opts > is added to vm_config_groups[]. > > This patch changes query-command-line-options to access three local > QemuOpt

Re: [Qemu-devel] [PATCH v5 1/2] target-arm: Move call to disas_vfp_insn out of disas_coproc_insn.

On 15 October 2013 16:09, Will Newton wrote: > > Floating point is an extension to the instruction set rather than > a coprocessor, so call it directly from the ARM and Thumb decode > functions. > > Signed-off-by: Will Newton > --- > target-arm/translate.c | 29 - > 1

Re: [Qemu-devel] [PATCH 0/7] virtio endian-ambivalent target fixes.

On Thu, 17 Oct 2013 14:23:35 +1030 Rusty Russell wrote: > This is a re-transmit of the core of the virtio endian code. Since > there seems to be some interest in ARM BE virtio, I've separated this from > the direct problem I was solving: PowerPC LE. > > Please apply! > Rusty. > > Rusty Russell

Re: [Qemu-devel] [PATCH] curses: fixup SIGWINCH handler mess

comments below On 11/12/13 09:43, Gerd Hoffmann wrote: > Don't run code in the signal handler, only set a flag. > Use sigaction(2) to avoid non-portable signal(2) semantics. > Make #ifdefs less messy. > > Signed-off-by: Gerd Hoffmann > --- > ui/curses.c | 44

Re: [Qemu-devel] audit needed for signal handlers

On 11/11/13 18:47, Paolo Bonzini wrote: > Il 11/11/2013 18:13, Peter Maydell ha scritto: That said, aren't all signals in QEMU (except SIG_IPI) caught with signalfd and the handlers run synchronously in the iothread? >> Eric specifically points out one which is not. >> (I'm pretty sure th

Re: [Qemu-devel] [PATCH for-1.7] target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid()

Il 12/11/2013 12:07, Peter Maydell ha scritto: > On 11 November 2013 23:21, Anthony Liguori wrote: >> We're not talking about something obscure here. It's eliminating an >> if(0) block. > > No, we're not talking about a simple "if (0)" expression. > What we had in this case was > if (!(env->fea

Re: [Qemu-devel] [PATCH] curses: fixup SIGWINCH handler mess

Hi, > > +static bool got_sigwinch; > > The type "volatile sig_atomic_t" would be more pedantic > . Will do for v2. Hmm, checkpatch barfs on "volatile", with a reference which looks linux kernel related

Re: [Qemu-devel] [PATCH for-1.7] target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid()

On 12 November 2013 12:09, Paolo Bonzini wrote: > Il 12/11/2013 12:07, Peter Maydell ha scritto: >> For the compiler to eliminate this we are relying on: >> * dead-code elimination of code following a 'break' >>statement in a case block >> * constant-folding of "something || 1" to 1 >> * th

Re: [Qemu-devel] [PATCH] curses: fixup SIGWINCH handler mess

Il 12/11/2013 12:53, Laszlo Ersek ha scritto: > Also, I grepped the source for SIGWINCH, and I think it is never masked > with pthread_sigmask(), or -- while the process is single-threaded > initially -- with sigprocmask(). Hence this signal can be delivered at > any time and interrupt interruptibl

Re: [Qemu-devel] audit needed for signal handlers

On 11/11/13 19:03, Max Filippov wrote: > On Mon, Nov 11, 2013 at 8:50 PM, Eric Blake wrote: >> Quick - identify the bug in this code (from ui/curses.c): >> >> static void curses_winch_handler(int signum) >> { >> struct winsize { >> unsigned short ws_row; >> unsigned short ws_co

Re: [Qemu-devel] [PATCH] curses: fixup SIGWINCH handler mess

On 11/12/13 13:16, Gerd Hoffmann wrote: >> justification for the patch.) My point though is that after this patch a >> narrow window seems to exist where you can lose a signal, namely between >> checking "got_sigwinch" and resetting it. > > Doesn't matter. The signal just says "terminal size has

Re: [Qemu-devel] [PATCH v3 4/6] qemu-option: support +foo/-foo command line agruments

On 12.11.2013 20:58, Igor Mammedov wrote: > On Tue, 12 Nov 2013 10:49:58 +1100 > Alexey Kardashevskiy wrote: > >> On 11/12/2013 01:25 AM, Igor Mammedov wrote: >>> On Mon, 11 Nov 2013 13:41:05 +0100 >>> Andreas Färber wrote: >>> Am 11.11.2013 08:44, schrieb Alexey Kardashevskiy: > This c

Re: [Qemu-devel] [PATCH v3 4/6] qemu-option: support +foo/-foo command line agruments

Am 12.11.2013 13:39, schrieb Alexey Kardashevskiy: > On 12.11.2013 20:58, Igor Mammedov wrote: >> PS: >> extending QemuOpts to parsing +/-opts format, seems like good workaround >> above problem. But I was under impression that general movement was to >> convert >> custom formats to canonical form

Re: [Qemu-devel] i386: pc: align gpa<->hpa on 1GB boundary (v5)

On Sun, 10 Nov 2013 18:47:53 -0200 Marcelo Tosatti wrote: [...] > @@ -1177,10 +1182,50 @@ FWCfgState *pc_memory_init(MemoryRegion > *system_memory, > e820_add_entry(0, below_4g_mem_size, E820_RAM); > if (above_4g_mem_size > 0) { > ram_above_4g = g_malloc(sizeof(*ram_above_4g)

[Qemu-devel] [PATCH 1.7] qcow2: fix possible corruption when reading multiple clusters

if multiple sectors spanning multiple clusters are read the function count_contiguous_clusters should ensure that the cluster type should not change between the clusters. Especially the for-loop should break when we have one or more normal clusters followed by a compressed cluster. Unfortunately

Re: [Qemu-devel] [PATCH v2] block: per caller dirty bitmap

On 11/12/2013 03:46 AM, Kevin Wolf wrote: >> +++ b/block/qapi.c >> @@ -204,14 +204,6 @@ void bdrv_query_info(BlockDriverState *bs, >> info->io_status = bs->iostatus; >> } >> >> -if (bs->dirty_bitmap) { >> -info->has_dirty = true; >> -info->dirty = g_malloc0(size

Re: [Qemu-devel] [PATCH v3 4/6] qemu-option: support +foo/-foo command line agruments

On Tue, 12 Nov 2013 23:39:27 +1100 Alexey Kardashevskiy wrote: > On 12.11.2013 20:58, Igor Mammedov wrote: > > On Tue, 12 Nov 2013 10:49:58 +1100 > > Alexey Kardashevskiy wrote: > > > >> On 11/12/2013 01:25 AM, Igor Mammedov wrote: > >>> On Mon, 11 Nov 2013 13:41:05 +0100 > >>> Andreas Färber

Re: [Qemu-devel] [PATCH for-1.7] target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid()

Il 12/11/2013 13:16, Peter Maydell ha scritto: > On 12 November 2013 12:09, Paolo Bonzini wrote: >> Il 12/11/2013 12:07, Peter Maydell ha scritto: >>> For the compiler to eliminate this we are relying on: >>> * dead-code elimination of code following a 'break' >>>statement in a case block >>>

Re: [Qemu-devel] [PATCH for-1.7] target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid()

On 12 November 2013 13:12, Paolo Bonzini wrote: > I'm saying it's *reasonable* to expect that "-O0" means "reduce compile > time, make debugging produce expected results, and try (not too hard) to > not break what works at -O2". And that's what we've got. There's no requirement, even at -O2, to e

Re: [Qemu-devel] [PATCH for-1.7] target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid()

On Tue, Nov 12, 2013 at 02:12:56PM +0100, Paolo Bonzini wrote: > Il 12/11/2013 13:16, Peter Maydell ha scritto: > > On 12 November 2013 12:09, Paolo Bonzini wrote: > >> Il 12/11/2013 12:07, Peter Maydell ha scritto: > >>> For the compiler to eliminate this we are relying on: > >>> * dead-code eli

Re: [Qemu-devel] [PATCH for-1.7] target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid()

On Tue, Nov 12, 2013 at 01:21:51PM +, Peter Maydell wrote: > (Similarly, > you can put code that's a syntax error inside #if 0, > but that won't work inside an "if (0)". The solution > is not to do that.) > That's the advantage of using "if (0)" ins

[Qemu-devel] [RFC v2] target-arm: provide skeleton for a64 insn decoding

provide a skeleton for a64 instruction decoding in translate-a64.c, by dividing instructions into the classes defined by the ARM Architecture Reference Manual(DDI0487A_a) C3 Signed-off-by: Claudio Fontana Signed-off-by: Alex Bennée Reviewed-by: Alex Bennée --- target-arm/translate-a64.c | 368

Re: [Qemu-devel] [PATCH for-1.7] target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid()

Il 12/11/2013 14:23, Gleb Natapov ha scritto: >> If -O0 does not do that, let's move debug builds to -O1. > > Why not enable dce with -fdce? First, because clang doesn't have fine-tuned optimization options (at least I couldn't find them and -fdce doesn't work). Second, because most optimization

[Qemu-devel] [PATCH for-1.8 0/2 v3] pc: inform SeaBIOS where 64-bit PCI hole begins

* simplify PCI address space mapping into system address space, replacing code duplication in piix/q53 PCs with a helper function * add fw_cfg 'etc/reserved-memory-end' to allow QEMU reserve additional address space before 64-bit PCI hole. Which will be need for reserving memory hotplug regi

[Qemu-devel] [PATCH 1/2] pc: map PCI address space as catchall region for not mapped addresses

From: "Michael S. Tsirkin" With a help of negative memory region priority PCI address space is mapped underneath RAM regions effectively catching every access to addresses not mapped by any other region. It simplifies PCI address space mapping into system address space. Signed-off-by: Michael S.

[Qemu-devel] [PATCH 2/2] pc: add 'etc/reserved-memory-end' fw_cfg interface for SeaBIOS

'etc/reserved-memory-end' will allow QEMU to tell BIOS where PCI BARs mapping could safely start in high memory. Allowing BIOS to start mapping 64-bit PCI BARs at address where it wouldn't conflict with other mappings QEMU might place before it. That permits QEMU to reserve extra address space be

Re: [Qemu-devel] [PATCH for-1.7] target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid()

On 12 November 2013 13:12, Paolo Bonzini wrote: > If -O0 does not do that, let's move debug builds to -O1. Isn't this going to sacrifice debuggability? That also seems like the wrong tradeoff to me. -- PMM

Re: [Qemu-devel] [PATCH for-1.7] target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid()

On Tue, Nov 12, 2013 at 02:57:49PM +0100, Paolo Bonzini wrote: > Il 12/11/2013 14:23, Gleb Natapov ha scritto: > >> If -O0 does not do that, let's move debug builds to -O1. > > > > Why not enable dce with -fdce? > > First, because clang doesn't have fine-tuned optimization options (at > least I co

Re: [Qemu-devel] [PATCH for-1.7] target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid()

On 12 November 2013 14:09, Gleb Natapov wrote: > On Tue, Nov 12, 2013 at 02:57:49PM +0100, Paolo Bonzini wrote: >> Il 12/11/2013 14:23, Gleb Natapov ha scritto: >> >> If -O0 does not do that, let's move debug builds to -O1. >> > >> > Why not enable dce with -fdce? >> >> First, because clang doesn'

[Qemu-devel] ARM testing image

Hi I would like to know where i get can 32bit ARM image with appropriate network driver. thank you, Xin

Re: [Qemu-devel] ARM testing image

On 12 November 2013 14:27, Xin Tong wrote: > Hi > > I would like to know where i get can 32bit ARM image For which board? > with appropriate network driver. Appropriate for what? http://people.debian.org/~aurel32/qemu/armel/ has a simple versatile kernel/initrd/filesystem (it's a little old, t

[Qemu-devel] [RFC V2 0/3] Giving names to BlockDriverState graph nodes

This series fix the issues of V1 and add the skeletton of a new QMP command useful to communicate a bs graph to libvirt. The minimum is exposed to the management to avoid binding it too much with QEMU. Tell me if you think it's worth implementing. Best regards Benoît v2: s/give/gives/ [Eric]

[Qemu-devel] [RFC V2 2/3] block: Allow the user to define "node-name" option.

Signed-off-by: Benoit Canet --- block.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c index c397ee9..6690e3d 100644 --- a/block.c +++ b/block.c @@ -872,6 +872,7 @@ int bdrv_file_open(BlockDriverState **pbs, const char *filename,

[Qemu-devel] [RFC V2 1/3] block: Add bs->node_name to hold the name of a bs node of the bs graph.

Add the minimum of code to prepare the followings patches. Signed-off-by: Benoit Canet --- block.c | 72 ++- block/blkverify.c | 2 +- block/iscsi.c | 2 +- block/vmdk.c | 2 +- block/vvfat.c

[Qemu-devel] [RFC V2 3/3] qapi: Add skeletton of command to query a drive bs graph.

--- blockdev.c | 8 qapi-schema.json | 32 2 files changed, 40 insertions(+) diff --git a/blockdev.c b/blockdev.c index 911ee7e..bfaeda0 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1938,6 +1938,14 @@ void qmp_drive_backup(const char *device, const

Re: [Qemu-devel] KVM call agenda for 2013-11-12

Juan Quintela wrote: > Hi > > Please, send any topic that you are interested in covering. > > Thanks, Juan. As there are no topics, call is cancelled. Have a nice day, Juan.

Re: [Qemu-devel] [PATCH v2 2/4] apic: QOM'ify apic & icc_bus

Resending yesterday's message since it hasn't arrived on qemu-devel... Am 11.11.2013 04:58, schrieb 赵小强: > 于 11/05/2013 04:51 PM, 赵小强 写道: >> 于 2013年11月05日 16:25, Chen Fan 写道: >>> On Tue, 2013-11-05 at 15:55 +0800, xiaoqiang zhao wrote: [...] diff --git a/include/hw/cpu/icc_bus.h b/include/hw/

Re: [Qemu-devel] [PATCH for-1.7] target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid()

Il 12/11/2013 15:09, Gleb Natapov ha scritto: > On Tue, Nov 12, 2013 at 02:57:49PM +0100, Paolo Bonzini wrote: >> Il 12/11/2013 14:23, Gleb Natapov ha scritto: If -O0 does not do that, let's move debug builds to -O1. >>> >>> Why not enable dce with -fdce? >> >> First, because clang doesn't hav

Re: [Qemu-devel] [ANNOUNCE] Key Signing Party at KVM Forum 2013

On 24 July 2013 13:50, Anthony Liguori wrote: > > I will be hosting a key signing party at this year's KVM Forum. > > http://wiki.qemu.org/KeySigningParty2013 Can somebody provide known-good instructions for how to sign and return keys? I looked on the web and found four different possible ways t

[Qemu-devel] [edk2 PATCH 1/1] OvmfPkg/AcpiPlatformDxe: download ACPI tables from QEMU

Qemu v1.7.0-rc0 features an ACPI linker/loader interface, available over fw_cfg, written by Michael Tsirkin. Qemu composes all ACPI tables on the host side, according to the target hardware configuration, and makes the tables available to any guest firmware over fw_cfg. The feature moves the burd

[Qemu-devel] [edk2 PATCH 0/1] OvmfPkg: grab ACPI tables from QEMU

I'll put only some testing and usage notes in the blurb. The commit message for the patch and the comment block in the code go into some implementation detail. First, this patch has no guest-visible consequences when upgrading from qemu v1.6 or earlier to v1.7 or later, as long as the qemu machine

Re: [Qemu-devel] [PATCH for-1.7] target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid()

On 12 November 2013 14:57, Paolo Bonzini wrote: > Il 12/11/2013 15:09, Gleb Natapov ha scritto: >> On Tue, Nov 12, 2013 at 02:57:49PM +0100, Paolo Bonzini wrote: >>> Il 12/11/2013 14:23, Gleb Natapov ha scritto: > If -O0 does not do that, let's move debug builds to -O1. Why not enabl

Re: [Qemu-devel] [ANNOUNCE] Key Signing Party at KVM Forum 2013

Peter, On Tue, Nov 12, 2013 at 02:57:36PM +, Peter Maydell wrote: > Can somebody provide known-good instructions for how to > sign and return keys? I looked on the web and found four > different possible ways to do this (most notably, there > seems to be a split between "just send keys back to

Re: [Qemu-devel] [PATCH for-1.7] target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid()

Il 12/11/2013 16:13, Peter Maydell ha scritto: >>> >> >>> >> -O1 then for clang. >> > >> > We can even test in configure for the exact optimizations we want, in >> > fact. But I think -O1 doesn't sacrifice debuggability that much: > I'm afraid I still don't see why you'd want to sacrifice it > at

Re: [Qemu-devel] [PATCH for-1.7] target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid()

On 12 November 2013 15:21, Paolo Bonzini wrote: > Il 12/11/2013 16:13, Peter Maydell ha scritto: >> >> -O1 then for clang. >>> > >>> > We can even test in configure for the exact optimizations we want, in >>> > fact. But I think -O1 doesn't sacrifice debuggability that much: >> I'm afra

Re: [Qemu-devel] [PATCH v3 1/2] linux-user: create target_structsheader to place ipc_perm and shmid_dss

ping http://patchwork.ozlabs.org/patch/287211/ http://patchwork.ozlabs.org/patch/287213/ Riku? Regards, Petar

Re: [Qemu-devel] [ANNOUNCE] Key Signing Party at KVM Forum 2013

On 11/12/2013 08:18 AM, Gabriel L. Somlo wrote: > Peter, > > On Tue, Nov 12, 2013 at 02:57:36PM +, Peter Maydell wrote: >> Can somebody provide known-good instructions for how to >> sign and return keys? I looked on the web and found four >> different possible ways to do this (most notably, th

Re: [Qemu-devel] [ANNOUNCE] Key Signing Party at KVM Forum 2013

On 12 November 2013 15:42, Eric Blake wrote: > I personally like how 'pius' automates the sending of > signatures to other recipients. I had a look at 'pius' since some of the signed-key emails I've received used it; however I couldn't find any way to make it write the emails to a file for sendin

Re: [Qemu-devel] [PATCH] e1000/rtl8139: update HMP NIC when every bit is written

On 11/10/2013 07:11 AM, Michael S. Tsirkin wrote: On Fri, Nov 08, 2013 at 02:42:27PM -0500, Vlad Yasevich wrote: What about this approach? This only updates the monitory when all the bits have been written to. -vlad Thanks! Some comments below. -- >8 -- Subject: [PATCH] e1000/rtl8139: upd

[Qemu-devel] [PATCH 00/11] block & scsi: write_zeroes support through the whole stack

This series fixes the implementation of WRITE SAME in the SCSI emulation layer. On top of this, it ensures that zero writes from the guest can be offloaded to the host device or filesystem if that's supported. This is a relatively important part of the thin provisioning feature, and builds on the

[Qemu-devel] [PATCH 06/11] scsi-disk: correctly implement WRITE SAME

The WRITE SAME command is implemented incorrectly. WRITE SAME with the UNMAP bit set should _not_ unmap the sectors unless the written data matches the payload of the WRITE SAME command; currently, QEMU is not looking at the payload at all. Thus, fetch the data to be written from the input buffer

[Qemu-devel] [PATCH 04/11] scsi-disk: catch write protection errors in UNMAP

This is the same that is already done for WRITE SAME. Signed-off-by: Paolo Bonzini --- hw/scsi/scsi-disk.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 74e6a14..4138268 100644 --- a/hw/scsi/scsi-disk.c +++ b/hw/scsi/scsi-disk.c @@ -154

[Qemu-devel] [PATCH 01/11] block: generalize BlockLimits handling to cover bdrv_aio_discard too

bdrv_co_discard is only covering drivers which have a .bdrv_co_discard() implementation, but not those with .bdrv_aio_discard(). Not very nice, and easy to avoid. Suggested-by: Kevin Wolf Signed-off-by: Paolo Bonzini --- block.c | 80 +

[Qemu-devel] [PATCH 10/11] raw-posix: add support for write_zeroes on XFS and block devices

The code is similar to the implementation of discard and write_zeroes with UNMAP. There is no fallocate flag for this operation (yet?) so we must write XFS-specific code like xfs_discard. With an image stored on XFS, doing this in the guest: # sg_write_same --in /dev/zero --num=256 --lba=0 /

[Qemu-devel] [PATCH 07/11] block: handle ENOTSUP from discard in generic code

Similar to write_zeroes, let the generic code receive a ENOTSUP for discard operations. Since bdrv_discard has advisory semantics, we can just swallow the error. Signed-off-by: Paolo Bonzini --- block.c | 2 +- block/raw-posix.c | 12 ++-- 2 files changed, 7 insertions(+), 7

[Qemu-devel] [PATCH 03/11] block: add bdrv_aio_write_zeroes

This will be used by the SCSI layer. Signed-off-by: Paolo Bonzini --- block.c | 11 +++ include/block/block.h | 3 +++ trace-events | 1 + 3 files changed, 15 insertions(+) diff --git a/block.c b/block.c index 7ea2361..f195a64 100644 --- a/block.c +++ b/block.c

[Qemu-devel] [PATCH 08/11] raw-posix: implement write_zeroes with MAY_UNMAP for files

Writing zeroes to a file can be done by punching a hole if MAY_UNMAP is set. Note that in this case handle_aiocb_discard's ENOTSUP return code is not ignored, but makes the block layer fall back to the generic implementation. Signed-off-by: Paolo Bonzini --- block/raw-posix.c | 64 +

[Qemu-devel] [PATCH 02/11] block: add flags to BlockRequest

This lets bdrv_co_do_rw receive flags, so that it can be used for zero writes. Signed-off-by: Paolo Bonzini --- block.c | 17 +++-- include/block/block.h | 1 + 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/block.c b/block.c index ba6872e..7ea2361 100

[Qemu-devel] [PATCH 11/11] qemu-iotests: 033 is fast

Signed-off-by: Paolo Bonzini --- tests/qemu-iotests/group | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group index c57ff35..cdd4b00 100644 --- a/tests/qemu-iotests/group +++ b/tests/qemu-iotests/group @@ -39,7 +39,7 @@ 030 rw a

[Qemu-devel] [PATCH 09/11] raw-posix: implement write_zeroes with MAY_UNMAP for block devices

See the next commit for the description of the Linux kernel problem that is worked around in raw_open_common. Signed-off-by: Paolo Bonzini --- block/raw-posix.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/block/raw-posix.c b/block/raw-posix.c index

Re: [Qemu-devel] [PATCH for-1.7] target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid()

Il 12/11/2013 16:32, Peter Maydell ha scritto: > > Is this FUD or do you have examples of bad debuggability of -O1 code? > > The clang manpage says specifically "Note that Clang debug > information works best at -O0. ", and I see no reason to > disbelieve it. In particular, they don't say "we defin

Re: [Qemu-devel] [edk2 PATCH 0/1] OvmfPkg: grab ACPI tables from QEMU

On Tue, 12 Nov 2013 16:11:49 +0100 Laszlo Ersek wrote: > Second, I tested the patch under the following circumstances: > - 3.10-based host kernel, > - qemu v1.7.0-rc0, with additional patches that shrink the "pci-hole" > memory range to just below "system.flash" (see the parallel discussion >

Re: [Qemu-devel] [PATCH for-1.7] target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid()

On 12 November 2013 15:58, Paolo Bonzini wrote: > I don't really see a reason why QEMU should give clang more weight than > Windows or Mac OS X. I'm not asking for more weight (and actually my main reason for caring about clang is exactly MacOSX). I'm just asking that when a bug is reported whose

Re: [Qemu-devel] [PATCH v2 2/4] apic: QOM'ify apic & icc_bus

Hi, Am 12.11.2013 02:28, schrieb Chen Fan: > [...] not long ago， I had sent a path about refactor > apic, though, there was not commented, if you are interested in it， > please help to review it: > https://lists.gnu.org/archive/html/qemu-devel/2013-10/msg02823.html You sent your series on Oct 22n

Re: [Qemu-devel] [edk2 PATCH 0/1] OvmfPkg: grab ACPI tables from QEMU

On 11/12/13 17:05, Igor Mammedov wrote: > On Tue, 12 Nov 2013 16:11:49 +0100 > Laszlo Ersek wrote: > > >> Second, I tested the patch under the following circumstances: >> - 3.10-based host kernel, >> - qemu v1.7.0-rc0, with additional patches that shrink the "pci-hole" >> memory range to just

Re: [Qemu-devel] [PATCH 1/2] pc: map PCI address space as catchall region for not mapped addresses

On 11/12/13 14:58, Igor Mammedov wrote: > From: "Michael S. Tsirkin" > > With a help of negative memory region priority PCI address space > is mapped underneath RAM regions effectively catching every access > to addresses not mapped by any other region. > It simplifies PCI address space mapping i

[Qemu-devel] [PATCH 00/16] Add an IPMI device to QEMU

There are two (sets of) patches to the general code beyond the IPMI device addition. One set adds an option to qemu-char net devices to automatically try to reconnect if the connection disconnects. This lets the IPMI device connect to a remote BMC and recover if that BMC fails. The other set all

[Qemu-devel] [PATCH 04/16] qemu-char: Close fd at end of file

The chardev backends that used qemu_chr_open_fd did not get their file descriptors closed at end of file or when the chardev was closed. This could result in a file descriptor leak. Signed-off-by: Corey Minyard --- qemu-char.c | 35 +-- 1 file changed, 29 insertio

[Qemu-devel] [PATCH 03/16] qemu-char: remove free of chr from win_stdio_close

This will result in a double free on close, because it's freed in qemu_chr_delete() right after calling the close function. Signed-off-by: Corey Minyard --- qemu-char.c | 1 - 1 file changed, 1 deletion(-) diff --git a/qemu-char.c b/qemu-char.c index 23d7647..935066d 100644 --- a/qemu-char.c ++

[Qemu-devel] [PATCH 14/16] pc: Postpone adding ACPI and SMBIOS to fw_cfg

Postpone the addition of the ACPI and SMBIOS tables until after device initialization. This allows devices to add entries to these tables. Signed-off-by: Corey Minyard --- hw/i386/pc.c | 38 ++ 1 file changed, 30 insertions(+), 8 deletions(-) diff --git a/hw

[Qemu-devel] [PATCH 01/16] qemu-char: Allocate CharDriverState in qemu_chr_new_from_opts

This allocates the CharDriverState structure and passes it in to the open routine. This allows a coming option to automatically attempt to reconnect a chardev if the connection fails. The chardev has to be kept around so a reconnect can be done on it. Signed-off-by: Corey Minyard --- backends/

[Qemu-devel] [PATCH 05/16] Add a base IPMI interface

Add the basic IPMI types and infrastructure to QEMU. Low-level interfaces and simulation interfaces will register with this; it's kind of the go-between to tie them together. Signed-off-by: Corey Minyard --- default-configs/i386-softmmu.mak | 1 + default-configs/x86_64-softmmu.mak | 1 +

[Qemu-devel] [PATCH 07/16] ipmi: Add a KCS low-level interface

This provides the simulation of the KCS hardware interface. Signed-off-by: Corey Minyard --- default-configs/i386-softmmu.mak | 1 + default-configs/x86_64-softmmu.mak | 1 + hw/ipmi/Makefile.objs | 1 + hw/ipmi/ipmi_kcs.c | 345 ++

[Qemu-devel] [PATCH 06/16] ipmi: Add a PC ISA type structure

This provides the base infrastructure to tie IPMI low-level interfaces into a PC ISA bus. Signed-off-by: Corey Minyard --- default-configs/i386-softmmu.mak | 1 + default-configs/x86_64-softmmu.mak | 1 + hw/ipmi/Makefile.objs | 1 + hw/ipmi/isa_ipmi.c | 148

[Qemu-devel] [PATCH 11/16] ipmi: Add tests

Test the KCS interface with a local BMC and a BT interface with an external BMC. Signed-off-by: Corey Minyard --- tests/Makefile| 4 + tests/ipmi-bt-test.c | 440 ++ tests/ipmi-kcs-test.c | 294 + 3 files

[Qemu-devel] [PATCH 08/16] ipmi: Add a BT low-level interface

This provides the simulation of the BT hardware interface for IPMI. Signed-off-by: Corey Minyard --- default-configs/i386-softmmu.mak | 1 + default-configs/x86_64-softmmu.mak | 1 + hw/ipmi/Makefile.objs | 1 + hw/ipmi/ipmi_bt.c | 367 ++

[Qemu-devel] [PATCH for-1.7] acpi unit-test: add signatures and checksum verification

Loaded all ACPI tables from guest, making a good environment for further unit tests. Checked that ACPI tables are corrected pointed within the ACPI tree using their signatures. Verified checksum for all the tables. Signed-off-by: Marcel Apfelbaum --- To be applied on top of: [PATCH v2 2/2] acpi-

[Qemu-devel] [PATCH 15/16] smbios: Add a function to directly add an entry

There was no way to directly add a table entry to the SMBIOS table, even though the BIOS supports this. So add a function to do this. This is in preparation for the IPMI handler adding it's SMBIOS table entry. Signed-off-by: Corey Minyard --- hw/i386/smbios.c | 27 +++ 1

[Qemu-devel] [PATCH 16/16] ipmi: Add SMBIOS table entry

Add an IPMI table entry to the SMBIOS. --- hw/ipmi/isa_ipmi.c | 29 + include/hw/i386/smbios.h | 14 ++ 2 files changed, 43 insertions(+) diff --git a/hw/ipmi/isa_ipmi.c b/hw/ipmi/isa_ipmi.c index b38c846..e40ca90 100644 --- a/hw/ipmi/isa_ipmi.c +++ b

[Qemu-devel] [PATCH 12/16] ipmi: Add documentation

Add some basic documentation for the IPMI device. Signed-off-by: Corey Minyard --- qemu-options.hx | 35 +++ 1 file changed, 35 insertions(+) diff --git a/qemu-options.hx b/qemu-options.hx index 5bcfaa0..500d7c8 100644 --- a/qemu-options.hx +++ b/qemu-options.hx

[Qemu-devel] [PATCH 05/11] scsi-disk: reject ANCHOR=1 for UNMAP and WRITE SAME commands

Since we report ANC_SUP==0 in VPD page B2h, we need to return an error (ILLEGAL REQUEST/INVALID FIELD IN CDB) for all WRITE SAME requests with ANCHOR==1. Inspired by a similar patch to the LIO in-kernel target. Signed-off-by: Paolo Bonzini --- hw/scsi/scsi-disk.c | 12 +++- 1 file chang

[Qemu-devel] [PATCH 13/16] ipmi: Add migration capability to the IPMI device.

Signed-off-by: Corey Minyard io_length = 3; memory_region_init_io(&s->io, OBJECT(s), &ipmi_bt_io_ops, bt, "ipmi-bt", 3); +vmstate_register(NULL, 0, &vmstate_ipmi_bt, bt); return 0; } diff --git a/hw/ipmi/ipmi_extern.c b/hw/ipmi/ipmi_extern.c index 1cd7c11..d66797d 100644 --- a/h

Re: [Qemu-devel] [PATCH 02/16] qemu-char: Allow a chardev to reconnect if disconnected

On 11/12/2013 09:33 AM, Corey Minyard wrote: > Allow a socket that connects to reconnect on a periodic basis if it > fails to connect at startup or if the connection drops while in use. > > Signed-off-by: Corey Minyard > --- > include/sysemu/char.h | 3 ++ > qemu-char.c | 88 > ++

[Qemu-devel] [PATCH 09/16] ipmi: Add a local BMC simulation

This provides a minimal local BMC, basically enough to comply with the spec and provide a complete watchdog timer (including a sensor, SDR, and event). Signed-off-by: Corey Minyard --- default-configs/i386-softmmu.mak |1 + default-configs/x86_64-softmmu.mak |1 + hw/ipmi/Makefile.objs

[Qemu-devel] snapshots [was: Qemu-devel Digest, Vol 128, Issue 93]

On 11/05/2013 08:27 PM, 宫文超 wrote: > hello evryone,who can give me a detail explain of the qemu code of the online > snapshot?THX Top-posting and replying to a digest message (especially without changing the subject line) is poor netiquette. Better would have been starting a new thread. Your qu

[Qemu-devel] [PATCH 02/16] qemu-char: Allow a chardev to reconnect if disconnected

Allow a socket that connects to reconnect on a periodic basis if it fails to connect at startup or if the connection drops while in use. Signed-off-by: Corey Minyard --- include/sysemu/char.h | 3 ++ qemu-char.c | 88 --- qemu-options.hx

  1   2   >