[Qemu-devel] [PATCH] vmdk: fix VMFS extent parsing

2013-10-18 Thread Fam Zheng
The VMFS extent line in description file doesn't have start offset as FLAT lines does, and it should be defaulted to 0. The flat_offset variable is initialized to -1, so we need to set it in this case. Signed-off-by: Fam Zheng --- block/vmdk.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [Qemu-devel] [Bug 1174654] Re: qemu-system-x86_64 takes 100% CPU after host machine resumed from suspend to ram

2013-10-18 Thread tobias appelo
Hello Mike, Thanks a lot for getting back on this. Is the "cpu idle driver" a command line option I need to specify for qemu (the -cpu option ?) I could not find a reference to "idle" in the man page. regards, Tobias. On 18-10-13 04:33, mike wrote: On 10/18/2013 04:29 AM, tobias wrote: hi,

Re: [Qemu-devel] [Bug 1174654] Re: qemu-system-x86_64 takes 100% CPU after host machine resumed from suspend to ram

2013-10-18 Thread mike
On 10/18/2013 03:12 PM, tobias wrote: Hello Mike, Thanks a lot for getting back on this. Is the "cpu idle driver" a command line option I need to specify for qemu (the -cpu option ?) I could not find a reference to "idle" in the man page. You need to check the guest kernel config file. Thanks

Re: [Qemu-devel] [Bug 1174654] Re: qemu-system-x86_64 takes 100% CPU after host machine resumed from suspend to ram

2013-10-18 Thread tobias
Hello MIke, but this concerns a windows guest. you mean a kernel configuration within the guest (aka recompile ?) or a boot parameter within the guest ? regards, Tobias. On 18-10-13 09:26, mike wrote: > On 10/18/2013 03:12 PM, tobias wrote: >> Hello Mike, >> >> Thanks a lot for getting back on

Re: [Qemu-devel] virtio-blk wierd memcpy

2013-10-18 Thread Christian Borntraeger
On 17/10/13 20:49, Dave Airlie wrote: > In my failing attempts to valgrind qemu (how to people live like > this?), I spotted this in the logs What are the failures? Do you use emulation or KVM? I know that there seems to be some issues regarding async I/O but otherwise that that it seems to run.

Re: [Qemu-devel] [PATCH v4 0/5] Fix UST backend for LTTng 2.x

2013-10-18 Thread Alex Bennée
mohamad.ge...@gmail.com writes: > Version 4 > > * Update documentation Good stuff. I notice you haven't added my Reviewed-by tags to your commits. See http://wiki.qemu.org/Contribute/SubmitAPatch. Anyway it all looks good to me. Reviewed-by: Alex Bennée -- Alex Bennée

[Qemu-devel] [PATCH 1/2] linux-user: Add target struct defs needed for POSIX timer syscalls.

2013-10-18 Thread mle+tools
From: Erik de Castro Lopo --- linux-user/syscall_defs.h | 28 1 file changed, 28 insertions(+) diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h index 5f53a28..899da88 100644 --- a/linux-user/syscall_defs.h +++ b/linux-user/syscall_defs.h @@ -168,6

[Qemu-devel] [PATCH 2/2] linux-user: Implement handling of 5 POSIX timer syscalls.

2013-10-18 Thread mle+tools
From: Erik de Castro Lopo Implement timer_create, timer_settime, timer_gettime, timer_getoverrun and timer_delete. --- linux-user/syscall.c | 199 +++ 1 file changed, 199 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index

Re: [Qemu-devel] [Bug 1174654] Re: qemu-system-x86_64 takes 100% CPU after host machine resumed from suspend to ram

2013-10-18 Thread tobias
Hi, ok confusion cleared :-) actually i only have this issue with windows guests. linux guests do not show a high cpu usage after suspend resume. so are there any recommendations you would have to work around it ? regards, Tobias. On 18-10-13 09:42, mike wrote: > On 10/18/2013 03:41 PM, tobia

Re: [Qemu-devel] [PATCH v2] mirror: drop local_err in mirror_complete

2013-10-18 Thread Stefan Hajnoczi
On Thu, Oct 17, 2013 at 03:00:23PM +0200, Kevin Wolf wrote: > Am 17.10.2013 um 14:49 hat Stefan Hajnoczi geschrieben: > > On Wed, Oct 16, 2013 at 08:56:49PM +0200, Max Reitz wrote: > > > On 2013-10-15 04:23, Fam Zheng wrote: > > > The reason I object it here is that error_propagate *currently* is a

Re: [Qemu-devel] [PATCH v2] mirror: drop local_err in mirror_complete

2013-10-18 Thread Fam Zheng
On Thu, 10/17 15:00, Kevin Wolf wrote: > Am 17.10.2013 um 14:49 hat Stefan Hajnoczi geschrieben: > > On Wed, Oct 16, 2013 at 08:56:49PM +0200, Max Reitz wrote: > > > On 2013-10-15 04:23, Fam Zheng wrote: > > > The reason I object it here is that error_propagate *currently* is a > > > no-op. But thi

Re: [Qemu-devel] [PATCH 1/1] e820: pass high memory too.

2013-10-18 Thread Gerd Hoffmann
Hi, > > > The premise that "this will also allow to pass non-contiguous memory" > > > is partly false, as you can't use the e820 API below 4g so there's no > > > way to create non contiguous memory with this mix-cmos-e820-API. > > > > Sure you can. Why do you think you can't? > > How do you s

Re: [Qemu-devel] [PATCH v2] net/net: Change the default mac address of nic

2013-10-18 Thread Stefan Hajnoczi
On Fri, Oct 18, 2013 at 10:54:13AM +0800, mike wrote: > >NACK > > > >I'm not going to merge this patch: > > > >If you terminate QEMU and launch it again the NIC gets a different MAC > >address. Some guest operating systems are sensitive to this - under > For these users must use -device ,mac=XX:XX

[Qemu-devel] [PATCH 01/13] block: use type MonitorEvent directly

2013-10-18 Thread Wenchao Xia
block_int.h included monitor.h, so it knows the typedef. Signed-off-by: Wenchao Xia Reviewed-by: Eric Blake --- block.c |2 +- include/block/block_int.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c index fd05a80..2c15e5d 10064

[Qemu-devel] [PATCH 07/13] error: make error_print_loc() static

2013-10-18 Thread Wenchao Xia
Signed-off-by: Wenchao Xia --- include/qemu/error-report.h |1 - util/qemu-error.c |2 +- 2 files changed, 1 insertions(+), 2 deletions(-) diff --git a/include/qemu/error-report.h b/include/qemu/error-report.h index 5297e65..a08ee95 100644 --- a/include/qemu/error-report.h +++

[Qemu-devel] [PATCH 02/13] block: do not include monitor.h in block.c

2013-10-18 Thread Wenchao Xia
block_int.h already included it. Signed-off-by: Wenchao Xia Reviewed-by: Eric Blake --- block.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/block.c b/block.c index 2c15e5d..e92a556 100644 --- a/block.c +++ b/block.c @@ -24,7 +24,6 @@ #include "config-host.h" #incl

[Qemu-devel] [Bug 1042388] Re: qemu: Unsupported syscall: 257 (timer_create)

2013-10-18 Thread Erik de Castro Lopo
The two patches have been sent to the qemu-devel mailing list and I will also attach them here. ?field.comment=The two patches have been sent to the qemu-devel mailing list and I will also attach them here. ** Attachment added: "posix-timer-patch.tgz" https://bugs.launchpad.net/qemu/+bug/10

[Qemu-devel] [PATCH 05/13] error: define struct Error in only one place

2013-10-18 Thread Wenchao Xia
Signed-off-by: Wenchao Xia --- include/qapi/error.h |5 - qobject/qerror.c |7 --- util/error.c |6 -- 3 files changed, 4 insertions(+), 14 deletions(-) diff --git a/include/qapi/error.h b/include/qapi/error.h index 7d4c696..8688aaf 100644 --- a/include/qapi/e

[Qemu-devel] [PATCH 03/13] qapi: move MonitorEvent define

2013-10-18 Thread Wenchao Xia
Signed-off-by: Wenchao Xia --- include/monitor/monitor.h | 38 +- include/qapi/qmp/qevent.h | 66 + include/qapi/qmp/types.h |1 + 3 files changed, 68 insertions(+), 37 deletions(-) create mode 100644 include/qapi/qmp/q

[Qemu-devel] [PATCH 09/13] error: print progname with error_vprintf()

2013-10-18 Thread Wenchao Xia
This remove additional code path about where to print the error, error_vprintf() is only the controller now, making future change easier. The logic is not changed since when cur_mon = NULL, error_vprintf() will still print to stderr. Signed-off-by: Wenchao Xia --- util/qemu-error.c | 11 +

[Qemu-devel] [PATCH 04/13] qapi: rename MonitorEvent to QEvent

2013-10-18 Thread Wenchao Xia
Signed-off-by: Wenchao Xia Reviewed-by: Eric Blake --- block.c|2 +- include/block/block_int.h |2 +- include/monitor/monitor.h |2 +- include/qapi/qmp/qevent.h |4 ++-- monitor.c | 12 ++-- stubs/mon-protocol-event.c |2 +- u

[Qemu-devel] [PATCH 10/13] qerror: deref once in qerror_report()

2013-10-18 Thread Wenchao Xia
Signed-off-by: Wenchao Xia --- qobject/qerror.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/qobject/qerror.c b/qobject/qerror.c index 5b487f3..685167a 100644 --- a/qobject/qerror.c +++ b/qobject/qerror.c @@ -77,7 +77,6 @@ static void qerror_print(QError *qerror)

[Qemu-devel] [PATCH 13/13] stubs: do not call monitor_printf()

2013-10-18 Thread Wenchao Xia
stubs/pci-drive-host-add.o is packaged together with /stubs/mon-printf.o so it would not work normal, remove it. Signed-off-by: Wenchao Xia --- stubs/pci-drive-hot-add.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/stubs/pci-drive-hot-add.c b/stubs/pci-drive-hot-add.c

[Qemu-devel] [PATCH 12/13] monitor: hide *cur_mon in monitor_get_fd()

2013-10-18 Thread Wenchao Xia
All existing caller are using *cur_mon as its parameter, and *cur_mon is an internal variable which used inside monitor.c. This patch reduce the exposing of details in monitor.c, by introduce a new function monitor_get_fd_cur() and make old one static. Signed-off-by: Wenchao Xia --- dump.c

Re: [Qemu-devel] [PATCH 2/2] linux-user: Implement handling of 5 POSIX timer syscalls.

2013-10-18 Thread Peter Maydell
On 18 October 2013 09:05, wrote: > From: Erik de Castro Lopo > > Implement timer_create, timer_settime, timer_gettime, timer_getoverrun > and timer_delete. > --- > linux-user/syscall.c | 199 > +++ > 1 file changed, 199 insertions(+) > > diff --g

Re: [Qemu-devel] [PATCH 02/13] block: do not include monitor.h in block.c

2013-10-18 Thread Paolo Bonzini
Il 18/10/2013 03:11, Wenchao Xia ha scritto: > block_int.h already included it. > > Signed-off-by: Wenchao Xia > Reviewed-by: Eric Blake > --- > block.c |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/block.c b/block.c > index 2c15e5d..e92a556 100644 > --- a/block

Re: [Qemu-devel] [PATCH 03/13] qapi: move MonitorEvent define

2013-10-18 Thread Paolo Bonzini
Il 18/10/2013 03:11, Wenchao Xia ha scritto: > Signed-off-by: Wenchao Xia > --- > include/monitor/monitor.h | 38 +- > include/qapi/qmp/qevent.h | 66 > + > include/qapi/qmp/types.h |1 + > 3 files changed, 68 insertion

Re: [Qemu-devel] [PATCH 05/13] error: define struct Error in only one place

2013-10-18 Thread Paolo Bonzini
Il 18/10/2013 03:11, Wenchao Xia ha scritto: > Signed-off-by: Wenchao Xia > --- > include/qapi/error.h |5 - > qobject/qerror.c |7 --- > util/error.c |6 -- > 3 files changed, 4 insertions(+), 14 deletions(-) > > diff --git a/include/qapi/error.h b/include/qa

[Qemu-devel] [PATCH 11/13] qerror: folder qerror emit logic

2013-10-18 Thread Wenchao Xia
The code about how to print the message, is foldered into a function, so if we want to change the print behavior in the future, just modify that function only. Signed-off-by: Wenchao Xia --- qobject/qerror.c | 28 1 files changed, 16 insertions(+), 12 deletions(-)

Re: [Qemu-devel] [PATCH 06/13] error: remove error_printf_unless_qmp()

2013-10-18 Thread Paolo Bonzini
Il 18/10/2013 03:11, Wenchao Xia ha scritto: > monitor_vprintf() is called in the code path, and it will not print > when monitor is in qmp mode, so checking monitor mode in > error_printf_unless_qmp() is useless, remove it to simplify the code. > > Signed-off-by: Wenchao Xia Reviewed-by: Paolo

[Qemu-devel] [PATCH 08/13] error: don't set sep when print progname

2013-10-18 Thread Wenchao Xia
The behavior to set sep brings trouble to modification later, the logic is not changed by add tailing space in fprintf(). Signed-off-by: Wenchao Xia --- util/qemu-error.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/util/qemu-error.c b/util/qemu-error.c index 0ccd

[Qemu-devel] [PATCH 06/13] error: remove error_printf_unless_qmp()

2013-10-18 Thread Wenchao Xia
monitor_vprintf() is called in the code path, and it will not print when monitor is in qmp mode, so checking monitor mode in error_printf_unless_qmp() is useless, remove it to simplify the code. Signed-off-by: Wenchao Xia --- hw/usb/bus.c|2 +- hw/usb/hcd-ehci.c |

Re: [Qemu-devel] [PATCH 08/13] error: don't set sep when print progname

2013-10-18 Thread Paolo Bonzini
Il 18/10/2013 03:11, Wenchao Xia ha scritto: > The behavior to set sep brings trouble to modification later, > the logic is not changed by add tailing space in fprintf(). > > Signed-off-by: Wenchao Xia > --- > util/qemu-error.c |5 ++--- > 1 files changed, 2 insertions(+), 3 deletions(-) >

[Qemu-devel] [PATCH 00/13] trivial patches for event, error and monitor

2013-10-18 Thread Wenchao Xia
I was trying to decouple components between block and qemu code, and reduce stub files. I found fixing some small code problem found could help, so pick up those which can benifit upstream code either and send them as separate series. patch 1 to 4 comes from my RFC series earlier with title: Remov

Re: [Qemu-devel] [PATCH v2] net/net: Change the default mac address of nic

2013-10-18 Thread mike
On 10/18/2013 05:00 PM, Stefan Hajnoczi wrote: On Fri, Oct 18, 2013 at 10:54:13AM +0800, mike wrote: NACK I'm not going to merge this patch: If you terminate QEMU and launch it again the NIC gets a different MAC address. Some guest operating systems are sensitive to this - under For these us

Re: [Qemu-devel] [PATCH 09/13] error: print progname with error_vprintf()

2013-10-18 Thread Paolo Bonzini
Il 18/10/2013 03:11, Wenchao Xia ha scritto: > This remove additional code path about where to print the error, > error_vprintf() is only the controller now, making future change > easier. > > The logic is not changed since when cur_mon = NULL, error_vprintf() > will still print to stderr. > > Si

Re: [Qemu-devel] [PATCH 10/13] qerror: deref once in qerror_report()

2013-10-18 Thread Paolo Bonzini
Il 18/10/2013 03:11, Wenchao Xia ha scritto: > Signed-off-by: Wenchao Xia > --- > qobject/qerror.c |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/qobject/qerror.c b/qobject/qerror.c > index 5b487f3..685167a 100644 > --- a/qobject/qerror.c > +++ b/qobject/qerror.c >

Re: [Qemu-devel] [PATCH 11/13] qerror: folder qerror emit logic

2013-10-18 Thread Paolo Bonzini
Il 18/10/2013 03:11, Wenchao Xia ha scritto: > The code about how to print the message, is foldered into a function, > so if we want to change the print behavior in the future, just modify > that function only. > > Signed-off-by: Wenchao Xia > --- > qobject/qerror.c | 28 --

Re: [Qemu-devel] [PATCH 12/13] monitor: hide *cur_mon in monitor_get_fd()

2013-10-18 Thread Paolo Bonzini
Il 18/10/2013 03:11, Wenchao Xia ha scritto: > All existing caller are using *cur_mon as its parameter, and *cur_mon > is an internal variable which used inside monitor.c. This patch reduce > the exposing of details in monitor.c, by introduce a new function > monitor_get_fd_cur() and make old one s

Re: [Qemu-devel] [PATCH 13/13] stubs: do not call monitor_printf()

2013-10-18 Thread Paolo Bonzini
Il 18/10/2013 03:11, Wenchao Xia ha scritto: > stubs/pci-drive-host-add.o is packaged together with /stubs/mon-printf.o > so it would not work normal, remove it. > > Signed-off-by: Wenchao Xia > --- > stubs/pci-drive-hot-add.c |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > dif

Re: [Qemu-devel] [RFC PATCH v3 2/2] qmp: add command 'blockdev-backup'

2013-10-18 Thread Paolo Bonzini
Il 17/10/2013 07:36, Fam Zheng ha scritto: > Similar to drive-backup, but this command uses a device id as target > instead of creating/opening an image file. > > Signed-off-by: Fam Zheng > --- > blockdev.c | 63 > > qapi-schema.jso

Re: [Qemu-devel] [PATCH 0/2] fix updating of nic info

2013-10-18 Thread Stefan Hajnoczi
On Thu, Oct 17, 2013 at 12:34:27PM +0300, Michael S. Tsirkin wrote: > On Thu, Oct 17, 2013 at 04:31:22PM +0800, Amos Kong wrote: > > On Thu, Oct 17, 2013 at 11:15:21AM +0300, Michael S. Tsirkin wrote: > > > On Thu, Oct 17, 2013 at 09:58:47AM +0200, Stefan Hajnoczi wrote: > > > > On Thu, Oct 17, 201

Re: [Qemu-devel] [RFC PATCH v3 1/2] block: parse "backing" option to reference existing BDS

2013-10-18 Thread Fam Zheng
On Thu, 10/17 13:36, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > block.c | 27 ++- > 1 file changed, 22 insertions(+), 5 deletions(-) > > diff --git a/block.c b/block.c > index fd05a80..38b3e80 100644 > --- a/block.c > +++ b/block.c > @@ -1158,11 +1158,28 @@ int b

Re: [Qemu-devel] [PATCH 2/2] linux-user: Implement handling of 5 POSIX timer syscalls.

2013-10-18 Thread Erik de Castro Lopo
Peter Maydell wrote: > Is there a good reason for doing these all via manual syscalls > rather than just using the host's libc interface to them? Thats a really good question. As you can see from the commit date I wrote this patch over a year ago and I can't remember why it ended up like it did.

Re: [Qemu-devel] [PATCH v2] net/net: Change the default mac address of nic

2013-10-18 Thread Stefan Hajnoczi
On Fri, Oct 18, 2013 at 11:44 AM, mike wrote: > On 10/18/2013 05:00 PM, Stefan Hajnoczi wrote: > > On Fri, Oct 18, 2013 at 10:54:13AM +0800, mike wrote: > > NACK > > I'm not going to merge this patch: > > If you terminate QEMU and launch it again the NIC gets a different MAC > address. Some guest

Re: [Qemu-devel] [PATCH v8 0/3] block: Add support for Secure Shell (ssh) block device.

2013-10-18 Thread Stefan Hajnoczi
On Thu, Oct 17, 2013 at 09:19:41AM +0100, Richard W.M. Jones wrote: > On Tue, Apr 09, 2013 at 10:56:30AM +0100, Richard W.M. Jones wrote: > > Changes since v7: > > > > - fsync (ie. bdrv_co_flush_to_disk) is now supported, *if* you have > > the following patches to libssh2 and OpenSSH: > > > > htt

Re: [Qemu-devel] [PATCH] virtio: Remove unneeded memcpy

2013-10-18 Thread Stefan Hajnoczi
On Thu, Oct 17, 2013 at 09:23:26PM +0200, Stefan Weil wrote: > Report from valgrind: > > ==19521== Source and destination overlap in memcpy(0x31d38938, 0x31d38938, 64) > ==19521==at 0x4A0A343: memcpy@@GLIBC_2.14 (in > /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) > ==19521==by 0x4

Re: [Qemu-devel] [PATCH v8 0/3] hw/arm: Add 'virt' platform

2013-10-18 Thread Peter Maydell
On 17 October 2013 17:48, Peter Maydell wrote: > This patch series adds a 'virt' platform which uses the > kernel's mach-virt (fully device-tree driven) support > to create a simple minimalist platform intended for > use for KVM VM guests. > Changes v7->v8: > * iterate through virtio-mmio nodes

Re: [Qemu-devel] [PATCH 2/2] acpi-test: basic acpi unit-test

2013-10-18 Thread Michael S. Tsirkin
On Fri, Oct 18, 2013 at 07:30:48AM +0200, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > We run bios, and boot a minimal boot sector that immediately halts. > > Then poke at memory to find ACPI tables. > > > > This only checks that RSDP is there. > > More will be added later. > > >

Re: [Qemu-devel] [PATCH 05/13] error: define struct Error in only one place

2013-10-18 Thread Markus Armbruster
Paolo Bonzini writes: > Il 18/10/2013 03:11, Wenchao Xia ha scritto: >> Signed-off-by: Wenchao Xia >> --- >> include/qapi/error.h |5 - >> qobject/qerror.c |7 --- >> util/error.c |6 -- >> 3 files changed, 4 insertions(+), 14 deletions(-) >> >> diff --git a

Re: [Qemu-devel] [PATCH] net: disallow to specify multicast MAC address

2013-10-18 Thread Stefan Hajnoczi
On Thu, Oct 17, 2013 at 07:06:28PM +0400, Dmitry Krivenok wrote: > Added explicit check of MAC address specified via macaddr option. > Multicast MAC addresses are no longer allowed. > This fixes bug #495566. > > Signed-off-by: Dmitry V. Krivenok > --- > net/net.c | 5 + > net/util.c | 5 +++

Re: [Qemu-devel] [PATCH] net: update nic info during device reset

2013-10-18 Thread Stefan Hajnoczi
On Thu, Oct 17, 2013 at 04:38:34PM +0800, Amos Kong wrote: > macaddr is reset during device reset, but nic info > isn't updated, this problem exists in e1000 & rtl8139 > > Signed-off-by: Amos Kong > --- > hw/net/e1000.c | 1 + > hw/net/rtl8139.c | 1 + > 2 files changed, 2 insertions(+) Thank

Re: [Qemu-devel] [PATCH v8 0/3] hw/arm: Add 'virt' platform

2013-10-18 Thread Alexander Graf
On 18.10.2013, at 13:12, Peter Maydell wrote: > On 17 October 2013 17:48, Peter Maydell wrote: >> This patch series adds a 'virt' platform which uses the >> kernel's mach-virt (fully device-tree driven) support >> to create a simple minimalist platform intended for >> use for KVM VM guests. >

Re: [Qemu-devel] [PATCH 06/13] error: remove error_printf_unless_qmp()

2013-10-18 Thread Markus Armbruster
Wenchao Xia writes: > monitor_vprintf() is called in the code path, and it will not print > when monitor is in qmp mode, so checking monitor mode in > error_printf_unless_qmp() is useless, remove it to simplify the code. Suggest to reword: error_printf_unless_qmp() is no longer useful, because

Re: [Qemu-devel] [PULL 0/1] e820: pass high memory too.

2013-10-18 Thread Gerd Hoffmann
On Do, 2013-10-17 at 13:09 +0200, Gerd Hoffmann wrote: > Hi, > > See patch description for all the details. Patch has been out for > review for a while without objections. Revoking pull request. There are objections now. cheers, Gerd

Re: [Qemu-devel] [PATCH] block: mask NOR flash buffered write length

2013-10-18 Thread Stefan Hajnoczi
On Thu, Oct 17, 2013 at 07:30:02PM -0700, Roy Franz wrote: > For buffered writes, mask the length with the maximum supported > length. This is required for block writes to work on the ARM vexpress > platform, where the flash interface is 32 bits wide. For buffered writes > to the 2 16 bit flashes

Re: [Qemu-devel] [PATCH v2] vmdk: Only read cid from image file when opening

2013-10-18 Thread Stefan Hajnoczi
On Fri, Oct 18, 2013 at 01:17:19PM +0800, Fam Zheng wrote: > Previously cid of parent is parsed from image file for every IO request. > We already have L1/L2 cache and don't have assumption that parent image > can be updated behind us, so remove this to get more efficiency. > > The parent CID is c

Re: [Qemu-devel] [PATCH] vmdk: fix VMFS extent parsing

2013-10-18 Thread Stefan Hajnoczi
On Fri, Oct 18, 2013 at 03:07:33PM +0800, Fam Zheng wrote: > The VMFS extent line in description file doesn't have start offset as > FLAT lines does, and it should be defaulted to 0. The flat_offset > variable is initialized to -1, so we need to set it in this case. > > Signed-off-by: Fam Zheng >

Re: [Qemu-devel] [PATCH 2/2] acpi-test: basic acpi unit-test

2013-10-18 Thread Markus Armbruster
Paolo Bonzini writes: > Il 18/10/2013 07:30, Markus Armbruster ha scritto: >> > +static void test_acpi_tcg(void) >> > +{ >> > +test_acpi_one("-machine accel=tcg"); >> > +} >> >> Since qtest_init() adds your parameters at the end, this should result >> in a command line ending with "-machine

[Qemu-devel] [PATCH v3 0/1] integrator: fix Linux boot failure

2013-10-18 Thread alex . bennee
>From Alex Bennée # This line is ignored. Hi, I finally got a chance to follow up on the review comments from Peter and Andreas. Changes for v3: * Moved into hw/arm/integrator_debug.c * Expanded QOM symbol to INTEGRATOR_DEBUG, moved to header * Use __func__, HWADDR_PRIx and PRIu64 for debug out

[Qemu-devel] [PATCH v3] integrator: fix Linux boot failure by emulating dbg region

2013-10-18 Thread alex . bennee
From: Alex Bennée Commit 9b8c69243 (since reverted) broke the ability to boot the kernel as the value returned by unassigned_mem_read returned non-zero and left the kernel looping forever waiting for it to change (see integrator_led_set in the kernel code). Relying on a varying implementation de

Re: [Qemu-devel] [PATCH v7 19/19] block: vhdx qemu-iotest - log replay of data sector

2013-10-18 Thread Stefan Hajnoczi
On Fri, Oct 11, 2013 at 02:17:39PM -0400, Jeff Cody wrote: > This tests the replay of a data sector in a VHDX image file. > > The image file is a 10G dynamic image, with 4MB block size. The > image was created with qemu-img, and the log left unplayed by > modification of the vhdx image format dri

Re: [Qemu-devel] [PATCH v3] integrator: fix Linux boot failure by emulating dbg region

2013-10-18 Thread Peter Maydell
On 18 October 2013 12:45, wrote: > +typedef struct { > +SysBusDevice parent_obj; > + > +MemoryRegion iomem; > + > +uint32_t alpha; > +uint32_t leds; > +uint32_t switches; These three fields are never used, or did I miss something? > +} IntegratorDebugState; Looks good other

Re: [Qemu-devel] [PATCH 1/2] qtest: don't configure icount if qtest not allowed

2013-10-18 Thread Paolo Bonzini
Il 17/10/2013 23:52, Michael S. Tsirkin ha scritto: > This makes it possible to run bios under qtest Alternatively, let's split qtest_init into a part for "-machine accel=qtest" and one for -qtest. Also has the advantage of fixing an assertion with "qemu-system-x86_64 -machine accel=qtest". Pa

Re: [Qemu-devel] [PATCH v7 11/19] block: vhdx write support

2013-10-18 Thread Stefan Hajnoczi
On Fri, Oct 11, 2013 at 02:17:31PM -0400, Jeff Cody wrote: > +/* check the payload block state */ > +switch (s->bat[sinfo.bat_idx] & VHDX_BAT_STATE_BIT_MASK) { > +case PAYLOAD_BLOCK_ZERO: > +/* in this case, we need to preserve zero writes for > +

Re: [Qemu-devel] [PATCH 1/2] qtest: don't configure icount if qtest not allowed

2013-10-18 Thread Michael S. Tsirkin
On Fri, Oct 18, 2013 at 01:51:11PM +0200, Paolo Bonzini wrote: > Il 17/10/2013 23:52, Michael S. Tsirkin ha scritto: > > This makes it possible to run bios under qtest > > Alternatively, let's split qtest_init into a part for "-machine > accel=qtest" and one for -qtest. > > Also has the advantag

Re: [Qemu-devel] [PATCH v7 11/19] block: vhdx write support

2013-10-18 Thread Stefan Hajnoczi
On Fri, Oct 11, 2013 at 02:17:31PM -0400, Jeff Cody wrote: > +case PAYLOAD_BLOCK_FULLY_PRESENT: > +/* if the file offset address is in the header zone, > + * there is a problem */ > +if (sinfo.file_offset < (1024 * 1024)) { When a block i

Re: [Qemu-devel] [PATCH v7 10/19] block: vhdx - add log write support

2013-10-18 Thread Stefan Hajnoczi
On Fri, Oct 11, 2013 at 02:17:30PM -0400, Jeff Cody wrote: > +/* Perform a log write, and then immediately flush the entire log */ > +int vhdx_log_write_and_flush(BlockDriverState *bs, BDRVVHDXState *s, > + void *data, uint32_t length, uint64_t offset) > +{ > +int re

Re: [Qemu-devel] [PATCH v7 00/19] VHDX log replay and write support, .bdrv_create()

2013-10-18 Thread Stefan Hajnoczi
On Fri, Oct 11, 2013 at 02:17:20PM -0400, Jeff Cody wrote: > This patch series contains the initial VHDX log parsing, replay, > write support, and image creation. > > === v7 changes === > https://github.com/codyprime/qemu-kvm-jtc/tree/vhdx-write-v7-upstream > > Rebased to latest qemu/master (pick

Re: [Qemu-devel] [PATCHv4 16/17] qemu-img: conditionally zero out target on convert

2013-10-18 Thread Stefan Hajnoczi
On Tue, Oct 08, 2013 at 01:58:10PM +0200, Peter Lieven wrote: > If the target has_zero_init = 0, but supports efficiently > writing zeroes by unmapping we call bdrv_zeroize to s/bdrv_zeroize/bdrv_make_zero/ No need to respin.

Re: [Qemu-devel] [PATCH 08/13] error: don't set sep when print progname

2013-10-18 Thread Markus Armbruster
Paolo Bonzini writes: > Il 18/10/2013 03:11, Wenchao Xia ha scritto: >> The behavior to set sep brings trouble to modification later, >> the logic is not changed by add tailing space in fprintf(). >> >> Signed-off-by: Wenchao Xia >> --- >> util/qemu-error.c |5 ++--- >> 1 files changed, 2

Re: [Qemu-devel] [PATCH v4 0/2] vmdk: Implement bdrv_get_specific_info

2013-10-18 Thread Eric Blake
On 10/17/2013 09:12 PM, Fam Zheng wrote: > The new information looks like: > > v4: Rebase to master. > Free create_type if open fails. (Stefan) > Set create_type for monolithcSparse in no description file case. > > v3: Rebase to kevin's block branch. > > > Fam Zheng (2): > qapi: Add

Re: [Qemu-devel] [PATCH v3] integrator: fix Linux boot failure by emulating dbg region

2013-10-18 Thread Alex Bennée
peter.mayd...@linaro.org writes: > On 18 October 2013 12:45, wrote: >> +typedef struct { >> +SysBusDevice parent_obj; >> + >> +MemoryRegion iomem; >> + >> +uint32_t alpha; >> +uint32_t leds; >> +uint32_t switches; > > These three fields are never used, or did I miss somethin

Re: [Qemu-devel] [PATCH 03/13] qapi: move MonitorEvent define

2013-10-18 Thread Eric Blake
On 10/18/2013 03:36 AM, Paolo Bonzini wrote: > Il 18/10/2013 03:11, Wenchao Xia ha scritto: >> Signed-off-by: Wenchao Xia >> --- >> include/monitor/monitor.h | 38 +- >> include/qapi/qmp/qevent.h | 66 >> + >> include/qapi/q

Re: [Qemu-devel] [PATCHv4 14/17] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks

2013-10-18 Thread Stefan Hajnoczi
On Tue, Oct 08, 2013 at 01:58:08PM +0200, Peter Lieven wrote: > this patch does 2 things: > a) only do additional call outs if BDRV_BLOCK_ZERO is not already set. > b) use the newly introduced bdrv_has_discard_zeroes() to return the >zero state of an unallocated block. the used callout to >

Re: [Qemu-devel] [PATCH 07/13] error: make error_print_loc() static

2013-10-18 Thread Eric Blake
On 10/17/2013 07:11 PM, Wenchao Xia wrote: > Signed-off-by: Wenchao Xia > --- > include/qemu/error-report.h |1 - > util/qemu-error.c |2 +- > 2 files changed, 1 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvir

Re: [Qemu-devel] [PATCHv4 14/17] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks

2013-10-18 Thread Paolo Bonzini
Il 18/10/2013 14:38, Stefan Hajnoczi ha scritto: > On Tue, Oct 08, 2013 at 01:58:08PM +0200, Peter Lieven wrote: >> this patch does 2 things: >> a) only do additional call outs if BDRV_BLOCK_ZERO is not already set. >> b) use the newly introduced bdrv_has_discard_zeroes() to return the >>zero s

Re: [Qemu-devel] [PATCH v3] integrator: fix Linux boot failure by emulating dbg region

2013-10-18 Thread Peter Maydell
On 18 October 2013 12:45, wrote: > From: Alex Bennée > > Commit 9b8c69243 (since reverted) broke the ability to boot the kernel > as the value returned by unassigned_mem_read returned non-zero and left > the kernel looping forever waiting for it to change (see > integrator_led_set in the kernel

Re: [Qemu-devel] [PATCH v3] integrator: fix Linux boot failure by emulating dbg region

2013-10-18 Thread Alex Bennée
peter.mayd...@linaro.org writes: > On 18 October 2013 12:45, wrote: >> From: Alex Bennée >> >> Commit 9b8c69243 (since reverted) broke the ability to boot the kernel >> as the value returned by unassigned_mem_read returned non-zero and left >> the kernel looping forever waiting for it to chang

Re: [Qemu-devel] [PATCHv4 14/17] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks

2013-10-18 Thread Peter Lieven
On 18.10.2013 14:38, Stefan Hajnoczi wrote: On Tue, Oct 08, 2013 at 01:58:08PM +0200, Peter Lieven wrote: this patch does 2 things: a) only do additional call outs if BDRV_BLOCK_ZERO is not already set. b) use the newly introduced bdrv_has_discard_zeroes() to return the zero state of an unal

Re: [Qemu-devel] [PATCHv4 14/17] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks

2013-10-18 Thread Stefan Hajnoczi
On Fri, Oct 18, 2013 at 02:49:11PM +0200, Paolo Bonzini wrote: > Il 18/10/2013 14:38, Stefan Hajnoczi ha scritto: > > On Tue, Oct 08, 2013 at 01:58:08PM +0200, Peter Lieven wrote: > >> this patch does 2 things: > >> a) only do additional call outs if BDRV_BLOCK_ZERO is not already set. > >> b) use

Re: [Qemu-devel] [PATCH v7 11/19] block: vhdx write support

2013-10-18 Thread Stefan Hajnoczi
On Fri, Oct 18, 2013 at 02:01:03PM +0200, Stefan Hajnoczi wrote: > On Fri, Oct 11, 2013 at 02:17:31PM -0400, Jeff Cody wrote: > > +/* check the payload block state */ > > +switch (s->bat[sinfo.bat_idx] & VHDX_BAT_STATE_BIT_MASK) { > > +case PAYLOAD_BLOCK_ZERO: >

Re: [Qemu-devel] [PATCHv4 14/17] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks

2013-10-18 Thread Peter Lieven
On 18.10.2013 14:49, Paolo Bonzini wrote: Il 18/10/2013 14:38, Stefan Hajnoczi ha scritto: On Tue, Oct 08, 2013 at 01:58:08PM +0200, Peter Lieven wrote: this patch does 2 things: a) only do additional call outs if BDRV_BLOCK_ZERO is not already set. b) use the newly introduced bdrv_has_discard_

Re: [Qemu-devel] [PATCH v3] integrator: fix Linux boot failure by emulating dbg region

2013-10-18 Thread Peter Maydell
On 18 October 2013 14:19, Alex Bennée wrote: > > peter.mayd...@linaro.org writes: >> Oh, and this belongs in hw/misc/, since it's a standalone >> device model. > Ahh I was pondering this. Surely as it's only associated with ARM (and > specifically integrator) it gets grouped with that? No, the o

Re: [Qemu-devel] Watching Resource consumption of guest from Qemu ?

2013-10-18 Thread Alex Bennée
sunil.ag...@gmail.com writes: > Hello List, > > I am a graduate student trying to learn about virtualization. I wanted > to understand if there is any way to tell about resource consumption > of guest through Qemu ? e.g. if guest starts doing something cpu > intensive, would qemu be aware of that

Re: [Qemu-devel] [PATCH 1/1] e820: pass high memory too.

2013-10-18 Thread Andrea Arcangeli
On Fri, Oct 18, 2013 at 10:55:12AM +0200, Gerd Hoffmann wrote: > Hi, > > > > > The premise that "this will also allow to pass non-contiguous memory" > > > > is partly false, as you can't use the e820 API below 4g so there's no > > > > way to create non contiguous memory with this mix-cmos-e820-A

[Qemu-devel] [PATCH] spapr_vscsi: Fix REPORT_LUNS handling

2013-10-18 Thread Nathan Whitehorn
Intercept REPORT_LUNS commands addressed either to SRP LUN 0 or the well-known LUN for REPORT_LUNS commands. This is required to implement the SAM and SPC specifications. Since SRP implements only a single SCSI target port per connection, the SRP target is required to report all available LUNs in

[Qemu-devel] [PULL 3/4] net/rtl8139: update network information when macaddr is changed in guest

2013-10-18 Thread Stefan Hajnoczi
From: Amos Kong rtl8139 has same problem as e1000, nic info isn't updated when macaddr is changed in guest. This patch updates the nic info when the last bit of macaddr is written. Signed-off-by: Amos Kong Signed-off-by: Stefan Hajnoczi --- hw/net/rtl8139.c | 6 +- 1 file changed, 5 inse

[Qemu-devel] [PULL 1/4] net: update nic info during device reset

2013-10-18 Thread Stefan Hajnoczi
From: Amos Kong macaddr is reset during device reset, but nic info isn't updated, this problem exists in e1000 & rtl8139 Signed-off-by: Amos Kong Acked-by: Michael S. Tsirkin Signed-off-by: Stefan Hajnoczi --- hw/net/e1000.c | 1 + hw/net/rtl8139.c | 1 + 2 files changed, 2 insertions(+)

[Qemu-devel] [PULL 2/4] net/e1000: update network information when macaddr is changed in guest

2013-10-18 Thread Stefan Hajnoczi
From: Amos Kong If we change macaddr in guest by 'ifconfig eth0 hw ether 12:12:12:34:35:36', the mac register of e1000 is already updated, but we don't update network information in qemu. Therefor, the information in monitor is wrong. This patch updates nic info when the second part of macaddr i

[Qemu-devel] [PULL 0/4] Net patches

2013-10-18 Thread Stefan Hajnoczi
The following changes since commit 1680d485777ecf436d724631ea8722cc0c66990e: Merge remote-tracking branch 'rth/tcg-ldst-6' into staging (2013-10-14 09:59:59 -0700) are available in the git repository at: git://github.com/stefanha/qemu.git net for you to fetch changes up to 6e6247e54da991c

[Qemu-devel] [PULL 4/4] net: disallow to specify multicast MAC address

2013-10-18 Thread Stefan Hajnoczi
From: Dmitry Krivenok Added explicit check of MAC address specified via macaddr option. Multicast MAC addresses are no longer allowed. This fixes bug lp#495566. Signed-off-by: Dmitry V. Krivenok Signed-off-by: Stefan Hajnoczi --- net/net.c | 5 + net/util.c | 5 + net/util.h | 2 ++

Re: [Qemu-devel] [PATCH] block: mask NOR flash buffered write length

2013-10-18 Thread Peter Maydell
On 18 October 2013 12:38, Stefan Hajnoczi wrote: > On Thu, Oct 17, 2013 at 07:30:02PM -0700, Roy Franz wrote: >> For buffered writes, mask the length with the maximum supported >> length. This is required for block writes to work on the ARM vexpress >> platform, where the flash interface is 32 bi

Re: [Qemu-devel] [PATCHv4 14/17] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks

2013-10-18 Thread Paolo Bonzini
Il 18/10/2013 15:26, Peter Lieven ha scritto: >> >> >> - bdrv_discard_zeroes for bdrv_has_discard_write_zeroes > This would conform to the linux ioctl BLKDISCARDZEROES. > However, we need the write_zeroes operation for a guarantee > that zeroes are return. Yes. I'm fine with the current names act

Re: [Qemu-devel] [PATCHv4 14/17] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks

2013-10-18 Thread Peter Lieven
On 18.10.2013 15:24, Stefan Hajnoczi wrote: On Fri, Oct 18, 2013 at 02:49:11PM +0200, Paolo Bonzini wrote: Il 18/10/2013 14:38, Stefan Hajnoczi ha scritto: On Tue, Oct 08, 2013 at 01:58:08PM +0200, Peter Lieven wrote: this patch does 2 things: a) only do additional call outs if BDRV_BLOCK_ZERO

Re: [Qemu-devel] [PATCH] block: mask NOR flash buffered write length

2013-10-18 Thread Roy Franz
On Fri, Oct 18, 2013 at 6:36 AM, Peter Maydell wrote: > On 18 October 2013 12:38, Stefan Hajnoczi wrote: >> On Thu, Oct 17, 2013 at 07:30:02PM -0700, Roy Franz wrote: >>> For buffered writes, mask the length with the maximum supported >>> length. This is required for block writes to work on the

Re: [Qemu-devel] [PATCHv4 14/17] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks

2013-10-18 Thread Paolo Bonzini
Il 18/10/2013 15:52, Peter Lieven ha scritto: > > Regarding putting this info into the BDI I am fine with that, but I > would keep the wrapper functions. > On the other hand, bdrv_has_zero_init is also not in the BDI... I had it > in the BDI and got the request > to move it to separate functions.

Re: [Qemu-devel] [PATCH] block: mask NOR flash buffered write length

2013-10-18 Thread Peter Maydell
On 18 October 2013 14:54, Roy Franz wrote: > On Fri, Oct 18, 2013 at 6:36 AM, Peter Maydell > wrote: >> Probably instead of a single "width" property we should have two, >> similar to the device tree binding's pair: >> - bank-width : Width (in bytes) of the bank. Equal to the >>device widt

Re: [Qemu-devel] [PATCH v4 4/5] Update documentation for LTTng ust tracing

2013-10-18 Thread Stefan Hajnoczi
On Fri, Oct 18, 2013 at 02:39:52AM -0400, Mohamad Gebai wrote: > +Package lttng-tools is required for userspace tracing. You must ensure that > the > +current user belongs to the "tracing" group, or manually launch the > +lttng-sessiond daemon for the current user prior to running any instance of

Re: [Qemu-devel] [PATCH v4 1/5] Fix configure script for LTTng 2.x

2013-10-18 Thread Stefan Hajnoczi
On Fri, Oct 18, 2013 at 02:39:49AM -0400, Mohamad Gebai wrote: > Signed-off-by: Mohamad Gebai > --- > configure |9 - > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/configure b/configure > index 23dbaaf..627054c 100755 > --- a/configure > +++ b/configure > @@ -328

  1   2   >