On Mi, 2013-10-02 at 15:41 +0300, Marcel Apfelbaum wrote:
> --- a/hw/usb/hcd-uhci.c
> +++ b/hw/usb/hcd-uhci.c
> @@ -381,7 +381,7 @@ static void uhci_update_irq(UHCIState *s)
> } else {
> level = 0;
> }
> -qemu_set_irq(s->dev.irq[s->irq_pin], level);
> +pci_set_irq(&s->dev
On Mon, 2013-10-07 at 09:02 +0200, Gerd Hoffmann wrote:
> On Mi, 2013-10-02 at 15:41 +0300, Marcel Apfelbaum wrote:
> > --- a/hw/usb/hcd-uhci.c
> > +++ b/hw/usb/hcd-uhci.c
> > @@ -381,7 +381,7 @@ static void uhci_update_irq(UHCIState *s)
> > } else {
> > level = 0;
> > }
> > -
On Mi, 2013-10-02 at 15:14 +0200, Jan Kiszka wrote:
> On 2013-09-19 11:34, Gerd Hoffmann wrote:
> > The usb-host code has been rewritten for qemu 1.5 to use libusb,
> > the old code has been left in as temporary fallback. Now we are
> > two releases further out, targeting the 1.7 release. No majo
On 2013-10-04 17:31, Eric Blake wrote:
On 10/04/2013 09:14 AM, Max Reitz wrote:
On 2013-10-02 14:39, Benoît Canet wrote:
Example of command line:
-drive if=virtio,file.driver=quorum,\
file.children.0.file.filename=1.qcow2,\
file.children.1.file.filename=2.qcow2,\
file.children.2.file.filename=3
Am 05.10.2013 23:45, schrieb Juergen Lock:
> On Sat, Oct 05, 2013 at 08:06:22PM +0200, Stefan Weil wrote:
>> Am 05.10.2013 19:54, schrieb Juergen Lock:
>>> On Fri, Oct 04, 2013 at 09:15:37AM +0200, Jan Kiszka wrote:
On 2013-10-03 18:05, Peter Maydell wrote:
> On 3 October 2013 23:09, Juerg
Interrupt pin is selected and saved into PCI_INTERRUPT_PIN
register during device initialization. Devices should not call
directly qemu_set_irq and specify the INTx pin.
Added pci_* wrappers to replace qemu_set_irq, qemu_irq_raise,
qemu_irq_lower and qemu_irq_pulse, setting the irq
based on PCI_IN
qemu_allocate_irq returns a single qemu_irq.
The interface allows to specify an interrupt number.
qemu_free_irq frees it.
Signed-off-by: Marcel Apfelbaum
---
hw/core/irq.c| 16
include/hw/irq.h | 7 +++
2 files changed, 23 insertions(+)
diff --git a/hw/core/irq.c b/hw
Interrupt pin is selected and saved into PCI_INTERRUPT_PIN
register during device initialization. Devices should not call
directly qemu_set_irq and specify the INTx pin on each call.
Added pci_* wrappers to replace qemu_set_irq, qemu_irq_raise,
qemu_irq_lower and qemu_irq_pulse, setting the irq
ba
pci_set_irq uses PCI_INTERRUPT_PIN config register
to compute device INTx pin to assert/deassert.
An assert is used to ensure that intx received
from the quest OS corresponds to PCI_INTERRUPT_PIN.
Signed-off-by: Marcel Apfelbaum
---
Changes from v2:
- Addressed Alex Williamson's comments
-
pci_set_irq and the other pci irq wrappers use
PCI_INTERRUPT_PIN config register to compute device
INTx pin to assert/deassert.
An irq is allocated using pci_allocate_irq wrapper
only if is needed by non pci devices.
Removed irq related fields from state if not used anymore.
Signed-off-by: Marce
Instead of exposing the the irq field,
pci wrappers to qemu_set_irq or qemu_irq_*
can be used.
Signed-off-by: Marcel Apfelbaum
---
hw/pci/pci.c | 2 --
include/hw/pci/pci.h | 3 ---
2 files changed, 5 deletions(-)
diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index fbfd8f7..f8d0b81 100644
--
The PCI_INTERRUPT_PIN will be used by shpc init, so
was moved before the call to shpc_init.
Signed-off-by: Marcel Apfelbaum
---
hw/pci-bridge/pci_bridge_dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/pci-bridge/pci_bridge_dev.c b/hw/pci-bridge/pci_bridge_dev.c
index
The fields hpev_intx and aer_intx were removed because
both AER and hot-plug events must use device's interrupt.
Assert/deassert interrupts using pci irq wrappers instead.
Signed-off-by: Marcel Apfelbaum
---
Changes from v2:
- Addressed Alex Williamson's comments
- replaced calls to pci_set_i
pci_set_irq and the other pci irq wrappers use
PCI_INTERRUPT_PIN config register to compute device
INTx pin to assert/deassert.
save INTX pin into the config register before calling
pci_set_irq
Signed-off-by: Marcel Apfelbaum
---
Changes from v2:
- Addressed Alex Williamson's comments
- repl
On Fr, 2013-10-04 at 15:20 +0200, Igor Mammedov wrote:
> On Wed, 21 Aug 2013 13:01:32 +0200
> Gerd Hoffmann wrote:
>
> > Hi,
> >
> > > +#define ICH9_PROC_BASE 0xaf00
> > > +#define ICH9_PROC_LEN 32
> >
> > No, please don't. It makes it impossible to assign the 0xa000 -> 0xafff
> > I/O port w
On Mon, Oct 07, 2013 at 10:36:39AM +0300, Marcel Apfelbaum wrote:
> pci_set_irq and the other pci irq wrappers use
> PCI_INTERRUPT_PIN config register to compute device
> INTx pin to assert/deassert.
>
> An irq is allocated using pci_allocate_irq wrapper
> only if is needed by non pci devices.
>
On Mon, Oct 07, 2013 at 11:03:47AM +0300, Michael S. Tsirkin wrote:
> On Mon, Oct 07, 2013 at 10:36:39AM +0300, Marcel Apfelbaum wrote:
> > pci_set_irq and the other pci irq wrappers use
> > PCI_INTERRUPT_PIN config register to compute device
> > INTx pin to assert/deassert.
> >
> > An irq is allo
On Wed, Oct 02, 2013 at 09:53:01AM -0600, Eric Blake wrote:
> On 09/24/2013 07:35 AM, Peter Lieven wrote:
> > this patch adds BlockLimits which introduces discard and write_zeroes
> > limits and alignment information to the BlockDriverState.
> >
> > Signed-off-by: Peter Lieven
> > ---
> > includ
> > > static void uhci_reset(void *opaque)
> > > @@ -1240,8 +1239,7 @@ static int usb_uhci_common_initfn(PCIDevice *dev)
> > > /* TODO: reset value should be 0. */
> > > pci_conf[USB_SBRN] = USB_RELEASE_1; // release number
> > >
> > > -s->irq_pin = u->info.irq_pin;
> > > -pci
Il 07/10/2013 07:59, Peter Lieven ha scritto:
> if a raw device like an iscsi target or host device is used
> the current implementation makes a second call out to get
> the block status of bs->file.
>
> Signed-off-by: Peter Lieven
> ---
> v5: add a generic get_lba_status function in the raw driv
On Tue, Sep 24, 2013 at 03:35:02PM +0200, Peter Lieven wrote:
> @@ -4245,7 +4250,37 @@ int coroutine_fn bdrv_co_discard(BlockDriverState *bs,
> int64_t sector_num,
> }
>
> if (bs->drv->bdrv_co_discard) {
> -return bs->drv->bdrv_co_discard(bs, sector_num, nb_sectors);
> +
On Tue, Sep 24, 2013 at 03:35:07PM +0200, Peter Lieven wrote:
> this patch adds a call to completely zero out a block device.
> the operation is sped up by checking the block status and
> only writing zeroes to the device if they currently do not
> return zeroes. optionally the zero writing can be
Am 07.10.2013 um 10:29 schrieb Stefan Hajnoczi :
> On Tue, Sep 24, 2013 at 03:35:02PM +0200, Peter Lieven wrote:
>> @@ -4245,7 +4250,37 @@ int coroutine_fn bdrv_co_discard(BlockDriverState
>> *bs, int64_t sector_num,
>> }
>>
>> if (bs->drv->bdrv_co_discard) {
>> -return bs->drv-
On Wed, Oct 02, 2013 at 11:11:05AM -0600, Eric Blake wrote:
> On 09/24/2013 07:35 AM, Peter Lieven wrote:
> > Signed-off-by: Peter Lieven
> > ---
> > block/raw_bsd.c |1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/block/raw_bsd.c b/block/raw_bsd.c
> > index 8dc7bba..7af26ad 100
Am 07.10.2013 um 10:34 schrieb Stefan Hajnoczi :
> On Tue, Sep 24, 2013 at 03:35:07PM +0200, Peter Lieven wrote:
>> this patch adds a call to completely zero out a block device.
>> the operation is sped up by checking the block status and
>> only writing zeroes to the device if they currently do
Am 07.10.2013 um 10:38 schrieb Stefan Hajnoczi :
> On Wed, Oct 02, 2013 at 11:11:05AM -0600, Eric Blake wrote:
>> On 09/24/2013 07:35 AM, Peter Lieven wrote:
>>> Signed-off-by: Peter Lieven
>>> ---
>>> block/raw_bsd.c |1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/block/raw_bs
On Tue, Sep 24, 2013 at 03:34:54PM +0200, Peter Lieven wrote:
> this patch adds the ability for targets to stay sparse during
> block migration (if the zero_blocks capability is set) and qemu-img convert
> even if the target does not have has_zero_init = 1.
>
> the series was especially developed
Am 07.10.2013 um 10:42 schrieb Stefan Hajnoczi :
> On Tue, Sep 24, 2013 at 03:34:54PM +0200, Peter Lieven wrote:
>> this patch adds the ability for targets to stay sparse during
>> block migration (if the zero_blocks capability is set) and qemu-img convert
>> even if the target does not have has_
On Thu, Oct 03, 2013 at 01:31:27AM +0800, Dunrong Huang wrote:
> The content filename point to may be erased by qemu_opts_absorb_qdict()
> in raw_open_common() in drv->bdrv_file_open()
>
> So it's better to use bs->filename.
>
> Signed-off-by: Dunrong Huang
> ---
> block.c | 4 ++--
> 1 file ch
libnuma choosed 128 for MAX_NODES, so we follow libnuma here.
Signed-off-by: Wanlong Gao
---
include/sysemu/sysemu.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h
index 861cd77..995cf3b 100644
--- a/include/sysemu/sysemu.h
+
Signed-off-by: Wanlong Gao
---
qapi-schema.json | 19 ++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/qapi-schema.json b/qapi-schema.json
index 8cf0179..d291f28 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -3912,7 +3912,8 @@
##
{ 'union': 'NumaOption
Add "-numa mem," option like following as Paolo suggested:
-numa mem,nodeid=0,size=1G
This new option will make later coming memory hotplug better.
We will use the new options to specify nodes memory info,
and just remain "-numa node,mem=xx" as legacy.
Reviewed-by: Laszlo Ersek
Signed-off-
Set the guest numa nodes memory policies using the mbind(2)
system call node by node.
After this patch, we are able to set guest nodes memory policies
through the QEMU options, this arms to solve the guest cross
nodes memory access performance issue.
And as you all know, if PCI-passthrough is used,
Add the numa_info structure to contain the numa nodes memory,
VCPUs information and the future added numa nodes host memory
policies.
Reviewed-by: Eduardo Habkost
Signed-off-by: Andre Przywara
Signed-off-by: Wanlong Gao
---
hw/i386/pc.c| 4 ++--
include/sysemu/sysemu.h | 8 ++
Reviewed-by: Luiz Capitulino
Signed-off-by: Wanlong Gao
---
hmp.c | 57 +
hmp.h | 1 +
monitor.c | 21 +
3 files changed, 59 insertions(+), 20 deletions(-)
diff --git a/hmp.c b/hmp.c
index 5891507..64cc570 1006
The memory policy setting format is like:
policy={default|membind|interleave|preferred}[,relative=true],host-nodes=N-N
And we are adding this setting as a suboption of "-numa mem,",
the memory policy then can be set like following:
-numa node,nodeid=0,cpus=0 \
-numa node,nodeid=1,cpus=1
If the total number of the assigned numa nodes memory is not
equal to the assigned ram size, it will write the wrong data
to ACPI talb, then the guest will ignore the wrong ACPI table
and recognize all memory to one node. It's buggy, we should
check it to ensure that we write the right data to ACPI
As you know, QEMU can't direct it's memory allocation now, this may cause
guest cross node access performance regression.
And, the worse thing is that if PCI-passthrough is used,
direct-attached-device uses DMA transfer between device and qemu process.
All pages of the guest will be pinned by get_u
Signed-off-by: Wanlong Gao
---
include/sysemu/sysemu.h | 3 +-
numa.c | 148 +++-
qapi-schema.json| 30 ++
vl.c| 11 +++-
4 files changed, 114 insertions(+), 78 deletions(-)
diff --git a/include/
Add qmp command query-numa to show guest NUMA information.
Reviewed-by: Luiz Capitulino
Signed-off-by: Wanlong Gao
---
numa.c | 66
qapi-schema.json | 36 +++
qmp-commands.hx | 48 +++
On 24.09.2013 14:03, Juan Quintela wrote:
From: Isaku Yamahata
Later is_zero_page will be used for non TARGET_PAGE_SIZE
range.
And rename it to is_zero_range as it isn't page size any more.
Signed-off-by: Isaku Yamahata
Signed-off-by: Juan Quintela
---
arch_init.c | 9 -
1 file ch
Add a method to scan pci buses in a predictable order.
Useful for ACPI hotplug.
Document that order is not guaranteed for pci_for_each_device,
and re-implement using that.
Signed-off-by: Michael S. Tsirkin
---
include/hw/pci/pci.h | 14 ++
hw/pci/pci.c | 28 ++
This is on top of patchset generating ACPI tables in qemu.
Please review and consider for 1.7.
Changes from v2:
- split new code out to a separate file: acpi/pcihp.c
this way we can reuse it for q35 later
- rebased on top of the latest acpi-build patchset
Changes from v1:
- fixe
Add support for acpi pci hotplug using the
new infrastructure.
PIIX4 legacy interface is maintained as is for
machine types 1.6 and older.
Signed-off-by: Michael S. Tsirkin
---
include/hw/i386/pc.h | 5
hw/acpi/piix4.c | 75 +---
2 files
Add ACPI based PCI hotplug library with bridge hotplug
support.
Design
- each bus gets assigned "bsel" property.
- ACPI code writes this number
to a new BNUM register, then uses existing
UP/DOWN registers to probe slot status;
to eject, write number to BNUM register,
then
Signed-off-by: Wanlong Gao
---
Makefile.target | 2 +-
cpus.c | 14
include/sysemu/cpus.h | 1 -
include/sysemu/sysemu.h | 3 +
numa.c | 182
vl.c| 139 +---
This enables support for device hotplug behind
pci bridges. Bridge devices themselves need
to be pre-configured on qemu command line.
Design:
- at machine init time, assign "bsel" property to bridges with
hotplug support
- dynamically (At ACPI table read) generate ACPI code to handle
On 10/05/13 09:37, Richard Henderson wrote:
> On 10/04/2013 02:15 PM, Claudio Fontana wrote:
>> At first glance I think we should add X4 to the list of restrictions in
>> function `target_parse_constraint':
>
> No, we've consumed all of the inputs at this point. We only
> need list those registe
The madvise for zeroed out pages was introduced when every transferred
zero page was memset to zero and thus allocated. Since commit
211ea740 we check for zeroness of a target page before we memset
it to zero. Additionally we memmap target memory so it is essentially
zero initalized (except for e.g
On 07.10.2013 10:25, Paolo Bonzini wrote:
Il 07/10/2013 07:59, Peter Lieven ha scritto:
if a raw device like an iscsi target or host device is used
the current implementation makes a second call out to get
the block status of bs->file.
Signed-off-by: Peter Lieven
---
v5: add a generic get_lba_
On Fr, 2013-10-04 at 13:10 +0200, Marc-André Lureau wrote:
> hose API are deprecated since 0.11, and qemu depends on 0.12 already.
Added to spice patch queue.
thanks,
Gerd
This code can also be found here:
git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git acpi
While this patch still uses info not available in QOM, I think it's reasonable
to merge it and then refactor as QOM properties cover more ground.
In particular, merging this patchset blocks other projects so
now that a typedef for struct Error is available,
use it in qom/object.h to match coding style rules.
Reviewed-by: Paolo Bonzini
Reviewed-by: Gerd Hoffmann
Tested-by: Gerd Hoffmann
Signed-off-by: Michael S. Tsirkin
---
include/qom/object.h | 50 +---
Make it easy to add read-only helpers for simple
integer properties in memory.
Reviewed-by: Paolo Bonzini
Reviewed-by: Gerd Hoffmann
Tested-by: Gerd Hoffmann
Signed-off-by: Michael S. Tsirkin
---
include/qom/object.h | 21 ++
qom/object.c | 60 +
Support ROM blobs not mapped into guest memory:
same as ROM files really but use caller's buffer.
Support invoking callback on access and
return memory pointer making it easier
for caller to update memory if necessary.
Reviewed-by: Gerd Hoffmann
Tested-by: Gerd Hoffmann
Reviewed-by: Laszlo Erse
BAR base was calculated incorrectly.
Use existing pci_bar_address to get it right.
Tested-by: Igor Mammedov
Signed-off-by: Michael S. Tsirkin
---
hw/pci/pci.c | 20
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index 00554a0..c3f
Address is already exposed, expose size for symmetry.
Reviewed-by: Gerd Hoffmann
Tested-by: Gerd Hoffmann
Signed-off-by: Michael S. Tsirkin
---
include/hw/pci/pcie_host.h | 1 +
hw/pci-host/q35.c | 14 ++
2 files changed, 15 insertions(+)
diff --git a/include/hw/pci/pcie
Make it possible to test unmapped status through QMP.
Reviewed-by: Gerd Hoffmann
Tested-by: Gerd Hoffmann
Signed-off-by: Michael S. Tsirkin
---
include/hw/pci/pcie_host.h | 3 +++
hw/pci/pcie_host.c | 3 ---
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/hw/pci/
Reviewed-by: Gerd Hoffmann
Tested-by: Gerd Hoffmann
Signed-off-by: Michael S. Tsirkin
---
include/hw/nvram/fw_cfg.h | 4
hw/nvram/fw_cfg.c | 33 -
2 files changed, 32 insertions(+), 5 deletions(-)
diff --git a/include/hw/nvram/fw_cfg.h b/include/hw
Detect presence of IASL compiler and use it
to process ASL source. If not there, use pre-compiled
files in-tree. Add script to update the in-tree files.
Note: distros are known to silently update iasl
so detect correct iasl flags for the installed version on each run as
opposed to at configure tim
Callers pass in the address so it's helpful for
them to be able to decode it.
Reviewed-by: Gerd Hoffmann
Tested-by: Gerd Hoffmann
Signed-off-by: Michael S. Tsirkin
---
include/hw/pci/pcie_host.h | 21 +
hw/pci/pcie_host.c | 21 -
2 files changed,
Avoid a bit of code duplication, make
max file path constant reusable.
Suggested-by: Laszlo Ersek
Reviewed-by: Gerd Hoffmann
Tested-by: Gerd Hoffmann
Signed-off-by: Michael S. Tsirkin
---
include/hw/nvram/fw_cfg.h | 4 +++-
hw/core/loader.c | 2 +-
2 files changed, 4 insertions(+), 2
Useful to make it accessible through QOM.
Reviewed-by: Gerd Hoffmann
Tested-by: Gerd Hoffmann
Signed-off-by: Michael S. Tsirkin
---
include/hw/pci/pcie_host.h | 2 ++
hw/pci-host/q35.c | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/include/hw/pci/pcie_host.h b/i
Add API to find HPET using QOM.
Reviewed-by: Gerd Hoffmann
Tested-by: Gerd Hoffmann
Signed-off-by: Michael S. Tsirkin
---
include/hw/timer/hpet.h | 2 ++
hw/timer/hpet.c | 5 +
2 files changed, 7 insertions(+)
diff --git a/include/hw/timer/hpet.h b/include/hw/timer/hpet.h
index 75
We don't really support CPU throttling, so supply 0 PBLK length.
Reviewed-by: Gerd Hoffmann
Tested-by: Gerd Hoffmann
Signed-off-by: Michael S. Tsirkin
---
hw/i386/ssdt-proc.dsl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/i386/ssdt-proc.dsl b/hw/i386/ssdt-proc.dsl
ind
Il 07/10/2013 08:38, Peter Lieven ha scritto:
> On 06.10.2013 15:57, Zhang Haoyu wrote:
>>> >From my testing this has been fixed in the saucy version (1.5.0) of
>> qemu. It is fixed by this patch:
>>> f1c72795af573b24a7da5eb52375c9aba8a37972
>>>
>>> However later in the history this commit was reve
update generated file, not sure what changed
Reviewed-by: Gerd Hoffmann
Tested-by: Gerd Hoffmann
Signed-off-by: Michael S. Tsirkin
---
hw/i386/ssdt-pcihp.hex.generated | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/i386/ssdt-pcihp.hex.generated b/hw/i386/ssdt-pc
This adds a dynamic bios linker/loader.
This will be used by acpi table generation
code to:
- load each table in the appropriate memory segment
- link tables to each other
- fix up checksums after said linking
Reviewed-by: Gerd Hoffmann
Tested-by: Gerd Hoffmann
Signed-off-by: Michael
Don't abort if machine done callbacks add ROMs.
Reviewed-by: Gerd Hoffmann
Tested-by: Gerd Hoffmann
Signed-off-by: Michael S. Tsirkin
---
include/hw/loader.h | 1 +
hw/core/loader.c| 6 +-
vl.c| 3 +++
3 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/includ
This defines a structure that will be used to fill in acpi tables
where relevant properties are not yet available using QOM.
Reviewed-by: Laszlo Ersek
Reviewed-by: Gerd Hoffmann
Tested-by: Gerd Hoffmann
Signed-off-by: Michael S. Tsirkin
---
include/hw/i386/pc.h | 9 +
hw/i386/pc.c
Reviewed-by: Gerd Hoffmann
Tested-by: Gerd Hoffmann
Signed-off-by: Michael S. Tsirkin
---
include/hw/i386/pc.h | 10 ++
hw/acpi/piix4.c | 6 +++---
2 files changed, 13 insertions(+), 3 deletions(-)
diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index 085a621..5aefc5b 10
This adds APIs that will be used to fill in guest acpi tables.
Some required information is still lacking in QOM, so we
fall back on lookups by type and returning explicit types.
Reviewed-by: Gerd Hoffmann
Tested-by: Gerd Hoffmann
Signed-off-by: Michael S. Tsirkin
---
include/hw/acpi/piix4.h |
This adds APIs that will be used to fill in
acpi tables, implemented using QOM,
to various ich9 components.
Some information is still missing in QOM,
so we fall back on lookups by type instead.
Reviewed-by: Gerd Hoffmann
Tested-by: Gerd Hoffmann
Signed-off-by: Michael S. Tsirkin
---
include/hw
Add API to find pvpanic device and get its io port.
Will be used to fill in guest info structure.
Reviewed-by: Gerd Hoffmann
Tested-by: Gerd Hoffmann
Signed-off-by: Michael S. Tsirkin
---
include/hw/i386/pc.h | 1 +
hw/misc/pvpanic.c| 13 -
2 files changed, 13 insertions(+), 1
Il 07/10/2013 11:22, Peter Lieven ha scritto:
> The madvise for zeroed out pages was introduced when every transferred
> zero page was memset to zero and thus allocated. Since commit
> 211ea740 we check for zeroness of a target page before we memset
> it to zero. Additionally we memmap target memor
I apologize for the stupid ticket.
Problem with a bad GDB configuration.
** Changed in: qemu
Status: New => Invalid
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1235306
Title:
Wrong memor
On 07.10.2013 11:37, Paolo Bonzini wrote:
Il 07/10/2013 08:38, Peter Lieven ha scritto:
On 06.10.2013 15:57, Zhang Haoyu wrote:
>From my testing this has been fixed in the saucy version (1.5.0) of
qemu. It is fixed by this patch:
f1c72795af573b24a7da5eb52375c9aba8a37972
However later in the
Update generated ssdt proc hex file (used for systems
lacking IASL) after P_BLK length change.
Reviewed-by: Gerd Hoffmann
Tested-by: Gerd Hoffmann
Signed-off-by: Michael S. Tsirkin
---
hw/i386/ssdt-proc.hex.generated | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git
Il 07/10/2013 11:49, Peter Lieven ha scritto:
>> It's in general not easy to do this if you take non-x86 targets into
>> account.
> What about the dirty way to zero out all non zero pages at the beginning of
> ram_load?
I'm not sure I follow?
Paolo
Am 07.10.2013 11:22, schrieb Peter Lieven:
> The madvise for zeroed out pages was introduced when every transferred
> zero page was memset to zero and thus allocated. Since commit
> 211ea740 we check for zeroness of a target page before we memset
> it to zero. Additionally we memmap target memory s
On Mon, Oct 07, 2013 at 10:36:33AM +0300, Marcel Apfelbaum wrote:
> Interrupt pin is selected and saved into PCI_INTERRUPT_PIN
> register during device initialization. Devices should not call
> directly qemu_set_irq and specify the INTx pin.
>
> Added pci_* wrappers to replace qemu_set_irq, qemu_i
On 10/04/2013 07:49 PM, Peter Maydell wrote:
> On 5 October 2013 01:57, Fabien Chouteau wrote:
> >> @@ -47,7 +48,9 @@
>> #include "hw/xen/xen.h"
>> #include "hw/i386/apic_internal.h"
>> #endif
>> +#include "monitor/monitor_def.h"
>>
>> +extern const MonitorDef i386_monitor_defs[];
>
> Declare
On 10/04/2013 07:52 PM, Peter Maydell wrote:
>> +#include "monitor/monitor_def.h"
>> +
>> +const MonitorDef arm_monitor_defs[] = {
>> +{ "r0", offsetof(CPUARMState, regs[0]) },
>> +{ "r1", offsetof(CPUARMState, regs[1]) },
>
> These fields are all 32 bits, not target_long,
> so t
From: Igor Mammedov
qapi/error.h is simple enough to be included in qom/object.h
direcly and prepares qom/object.h to use Error typedef.
Signed-off-by: Igor Mammedov
Signed-off-by: Michael S. Tsirkin
---
include/qom/object.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/
Il 07/10/2013 10:42, Stefan Hajnoczi ha scritto:
> Could you make bdrv_co_write_zeroes() always use UNMAP, if possible, and
> avoid adding the new BDRV_REQ_MAY_UNMAP flag? While reading the first
> few patches in this series I wondered why there is a need to expose
> flags at all...
>
> Sometimes
On Thu, 03 Oct 2013 07:53:02 -0700
Richard Henderson wrote:
> On 10/02/2013 04:33 AM, Michael Mueller wrote:
> > +/* set a specific bit in facility set */
> > +static void set_facility(unsigned int nr, void *facilities)
> > +{
> > +unsigned char *ptr;
> > +
> > +if (nr >= MAX_S390_FACILIT
The following changes since commit a684f3cf9b9b9c3cb82be87aafc463de8974610c:
Merge remote-tracking branch 'kraxel/seabios-1.7.3.2' into staging
(2013-09-30 17:15:27 -0500)
are available in the git repository at:
git://github.com/stefanha/qemu.git block
for you to fetch changes up to d4cea
From: Max Reitz
If an inactive L1 table is loaded from disk, its entries are in big
endian and have to be converted to host byte order before using them.
Signed-off-by: Max Reitz
Reviewed-by: Kevin Wolf
Signed-off-by: Stefan Hajnoczi
---
block/qcow2-refcount.c | 4 ++--
1 file changed, 2 ins
From: Max Reitz
CHECK_OFLAG_COPIED as a parameter to check_refcounts_l1 and
check_refcounts_l2 is obselete now, since the OFLAG_COPIED consistency
check is actually no longer performed by these functions (but by
check_oflag_copied).
Signed-off-by: Max Reitz
Reviewed-by: Kevin Wolf
Signed-off-b
From: Max Reitz
Because l2_allocate now frees the unused L2 cluster on error, the
according test cases in 026 don't result in one leaked cluster anymore.
Signed-off-by: Max Reitz
Signed-off-by: Stefan Hajnoczi
---
tests/qemu-iotests/026.out | 32
tests
From: Jeff Cody
This blocks migration for VHDX image files, until the
functionality can be supported.
Signed-off-by: Jeff Cody
Signed-off-by: Stefan Hajnoczi
---
block/vhdx.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/block/vhdx.c b/block/vhdx.c
index b8aa49c..6cb0412 100
From: Max Reitz
Switching the L1 table in memory should be an atomic operation, as far
as possible. Calling qcow2_free_clusters on the old L1 table on disk is
not a good idea when the old L1 table is no longer valid and the address
to the new one hasn't yet been written into the corresponding
BDR
From: Max Reitz
If an error occurs in l2_allocate, the allocated (but unused) L2 cluster
should be freed.
Signed-off-by: Max Reitz
Reviewed-by: Benoit Canet
Signed-off-by: Stefan Hajnoczi
---
block/qcow2-cluster.c | 4
1 file changed, 4 insertions(+)
diff --git a/block/qcow2-cluster.c
From: Dunrong Huang
The content filename point to will be erased by qemu_opts_absorb_qdict()
in raw_open_common() in drv->bdrv_file_open()
So it's better to use bs->filename.
Signed-off-by: Dunrong Huang
Reviewed-by: Max Reitz
Signed-off-by: Stefan Hajnoczi
---
block.c | 4 ++--
1 file chan
On 7 October 2013 19:11, Fabien Chouteau wrote:
> On 10/04/2013 07:49 PM, Peter Maydell wrote:
>> On 5 October 2013 01:57, Fabien Chouteau wrote:
>> >> @@ -47,7 +48,9 @@
>>> #include "hw/xen/xen.h"
>>> #include "hw/i386/apic_internal.h"
>>> #endif
>>> +#include "monitor/monitor_def.h"
>>>
>>>
From: Dunrong Huang
The content filename point to may be erased by qemu_opts_absorb_qdict()
in raw_open_common() in drv->bdrv_file_open()
So it's better to use bs->filename.
Signed-off-by: Dunrong Huang
Reviewed-by: Max Reitz
Signed-off-by: Stefan Hajnoczi
---
block.c | 4 ++--
1 file chang
Il 30/09/2013 15:34, Alex Bligh ha scritto:
>
> I think the most likely change here is that the walkers might
> move outside the BQL. Given modification of this list is so rare,
> the lock would be very very read heavy, so RCU is probably a
> sensible option.
I agree. Keeping the write side on t
Stefan, will you pick this up next week or shall I?
I have patches for thread-safe icount almost ready to post, and I am not
sure through whom they are going to go.
Paolo
Il 25/09/2013 08:20, Liu Ping Fan ha scritto:
> v5:
> fine rename some variable in patch2&4.
> fix commit log for patch1
mohamad.ge...@gmail.com writes:
> Version 2
>
> * Fix tracepoint generation error in first version.
> * Avoid warnings and errors specific to LTTng ust 2.0.
> * If using LTTng ust 2.0, we can't avoid getting warnings because of the
> --warn-common option given to the linker. This is fixed in m
The problem showed up this morning again, same top commit:
10/07 01:34:42 INFO | git:0150| git commit ID is
a684f3cf9b9b9c3cb82be87aafc463de8974610c (tag v1.4.0-4237-ga684f3c)
This time around, debug symbols were enabled on the configure line:
10/07 01:35:31 DEBUG|build_help:0588| Enablin
1 - 100 of 143 matches
Mail list logo
