[Qemu-devel] [PULL 09/17] s390/sclpconsole: Add code to support live migration for sclpconsole

2013-09-24 Thread Christian Borntraeger
From: Heinz Graalfs This patch adds the necessary life migration pieces to the sclp code by using vmstate_register. Signed-off-by: Heinz Graalfs Reviewed-by: Alexander Graf Signed-off-by: Christian Borntraeger --- hw/char/sclpconsole.c | 18 ++ 1 file changed, 18 insertions(+

[Qemu-devel] [PULL 00/17] s390 patches

2013-09-24 Thread Christian Borntraeger
The following changes since commit 6c2679fc19560699679200fb42ab4659bcbe7f79: Merge remote-tracking branch 'kiszka/queues/slirp' into staging (2013-09-17 10:01:24 -0500) are available in the git repository at: git://github.com/borntraeger/qemu.git tags/s390-next-20130924 for yo

[Qemu-devel] [PULL 11/17] s390/sclp: add reset() functions

2013-09-24 Thread Christian Borntraeger
From: Heinz Graalfs Add reset() functions for event-facility, sclpconsole, and sclpquiesce. The reset() functions perform variable initialization at IPL and e.g. when monitor system_reset is called. Signed-off-by: Heinz Graalfs Reviewed-by: Thomas Huth Reviewed-by: Alexander Graf Signed-off-b

[Qemu-devel] [PULL 10/17] s390/sclpquiesce: Add code to support live migration

2013-09-24 Thread Christian Borntraeger
From: Heinz Graalfs This patch adds the necessary life migration pieces to sclpquiesce by using the vmstate_register. Signed-off-by: Heinz Graalfs Reviewed-by: Alexander Graf Signed-off-by: Christian Borntraeger --- hw/s390x/sclpquiesce.c | 13 + 1 file changed, 13 insertions(+)

[Qemu-devel] [PULL 14/17] s390/eventfacility: remove unused event_type variable

2013-09-24 Thread Christian Borntraeger
The event_type variable is never used. Get rid of it. Signed-off-by: Christian Borntraeger Reviewed-by: Alexander Graf --- hw/char/sclpconsole.c | 1 - hw/s390x/sclpquiesce.c| 2 -- include/hw/s390x/event-facility.h | 1 - 3 files changed, 4 deletions(-) diff --git a/hw

[Qemu-devel] [PULL 12/17] s390/eventfacility: fix multiple Read Event Data sources

2013-09-24 Thread Christian Borntraeger
From: Ralf Hoppe Make the handler for SCLP Read Event Data deal with notifications for multiple sources correctly. Signed-off-by: Ralf Hoppe Reviewed-by: Thomas Huth Signed-off-by: Christian Borntraeger [split bigger patch into smaller independent chunks] Reviewed-by: Alexander Graf --- hw/

[Qemu-devel] [PULL 17/17] s390/sclplmconsole: Add support for SCLP line-mode console

2013-09-24 Thread Christian Borntraeger
From: Heinz Graalfs Add simple support for SCLP line-mode also known as operating system messages. This can be added in addition to or instead of the SCLP full screen console with -device sclplmconsole. Signed-off-by: Heinz Graalfs Reviewed-by: Alexander Graf Signed-off-by: Christian Borntraeg

[Qemu-devel] [PULL 03/17] s390/ipl: Fix waiting for virtio processing

2013-09-24 Thread Christian Borntraeger
From: Cornelia Huck The guest side must not manipulate the index for the used buffers. Instead, remember the state of the used buffer locally and wait until it has moved. Signed-off-by: Cornelia Huck Acked-by: Alexander Graf Signed-off-by: Christian Borntraeger --- pc-bios/s390-ccw/virtio.c

[Qemu-devel] [PULL 13/17] s390/eventfacility: Fix receive/send masks

2013-09-24 Thread Christian Borntraeger
Currently we announce interchanged receive/send masks. This did not trigger a bug, since the sclp console has the same masks for send/receive and the Linux guest does not check the sclp mask for simple events like quiesce. With other event users like the sclp line mode console, we will have differe

[Qemu-devel] [PULL 08/17] s390/sclpconsole: modify definition of input buffer

2013-09-24 Thread Christian Borntraeger
From: Heinz Graalfs To use VMState for migration, we need to adapt some sclp code: - allocate console buffer as part of the console - change semantic of sclpconsole offset fields Signed-off-by: Heinz Graalfs Reviewed-by: Alexander Graf Signed-off-by: Christian Borntraeger --- hw/char/s

[Qemu-devel] [PULL 16/17] s390/ebcdic: Move conversion tables to header file

2013-09-24 Thread Christian Borntraeger
From: Heinz Graalfs Move conversion tables to header file. - In SCLP line mode processing EBCDIC/ASCII conversion is needed. - An additional EBCDIC to ASCII conversion function is added. Signed-off-by: Heinz Graalfs Reviewed-by: Alexander Graf Signed-off-by: Christian Borntraeger --- i

[Qemu-devel] [PULL 05/17] s390/cpu: Make setcc() function available to other files

2013-09-24 Thread Christian Borntraeger
From: Thomas Huth Moved the setcc() function to cpu.h so that it can be used by other files, too. It now also does not modify the kvm state anymore since this gets updated during kvm_arch_put_registers() anyway. Signed-off-by: Thomas Huth Signed-off-by: Christian Borntraeger --- target-s390x/

[Qemu-devel] [PULL 04/17] s390/ipl: Update the s390-ccw.img rom

2013-09-24 Thread Christian Borntraeger
Rebuild of the virtio-ccw rom containing these patches: 1. s390/ipl: Fix waiting for virtio processing Signed-off-by: Christian Borntraeger --- pc-bios/s390-ccw.img | Bin 9432 -> 9336 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/pc-bios/s390-ccw.img b/pc-bios/s390-ccw.img

[Qemu-devel] [PULL 15/17] s390/eventfacility: allow childs to handle more than 1 event type

2013-09-24 Thread Christian Borntraeger
Currently all handlers (quiesce, console) only handle one event type. Some drivers will handle multiple (compatible) event types. Rework the code accordingly. Signed-off-by: Christian Borntraeger Reviewed-by: Alexander Graf --- hw/char/sclpconsole.c | 6 +++--- hw/s390x/event-facili

[Qemu-devel] [PULL 02/17] s390/dump: zero out padding bytes in notes sections

2013-09-24 Thread Christian Borntraeger
The prstatus of an s390x dump contains several padding areas. Zero out these bytes to make reading the notes section easier with a hexdump. Signed-off-by: Christian Borntraeger --- target-s390x/arch_dump.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target-s390x/arch_dump.c b/target-s390

[Qemu-devel] [PULL 07/17] s390/kexec: Implement diag308 subcode 0

2013-09-24 Thread Christian Borntraeger
This patch implements subcode 0 of diag 308. This is necessary for kexec (without kdump). The main difference to subcode 1 is that all CPUs get a full reset, instead of the architectured CPU reset (which leaves all registers untouched). Signed-off-by: Christian Borntraeger --- target-s390x/misc_

[Qemu-devel] [PULL 01/17] s390/kvm: Add check for priviledged SCLP handler

2013-09-24 Thread Christian Borntraeger
From: Thomas Huth The SCLP instruction is priviledged, so we should make sure that we generate an exception when it is called from the problem state. Signed-off-by: Thomas Huth Signed-off-by: Christian Borntraeger --- target-s390x/kvm.c | 4 1 file changed, 4 insertions(+) diff --git a/

[Qemu-devel] [PULL 06/17] s390/ioinst: Moved the CC setting to the IO instruction handlers

2013-09-24 Thread Christian Borntraeger
From: Thomas Huth The IO instruction handlers now take care of setting the CC value on their own, so that the confusing return code magic in kvm_handle_css_inst() is not needed anymore. Signed-off-by: Thomas Huth Reviewed-by: Cornelia Huck Signed-off-by: Christian Borntraeger --- target-s390

[Qemu-devel] [PATCH v3 0/2] tests: Fixes for in-tree build

2013-09-24 Thread armbru
From: Markus Armbruster Hasn't gotten maintainer attention for two months. Retrying via qemu-trivial. v3: Trivially rebased v2: Nominate for qemu-stable (Andreas) Markus Armbruster (2): tests: Fix schema parser test for in-tree build tests: Update .gitignore for test-int128 and test-bitops

[Qemu-devel] [PATCH v3 2/2] tests: Update .gitignore for test-int128 and test-bitops

2013-09-24 Thread armbru
From: Markus Armbruster Forgotten in commit 6046c62 and 3464700. Cc: qemu-sta...@nongnu.org Reviewed-by: Andreas Färber Reviewed-by: Laszlo Ersek Signed-off-by: Markus Armbruster --- tests/.gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/.gitignore b/tests/.gitignore in

[Qemu-devel] [PATCH v3 1/2] tests: Fix schema parser test for in-tree build

2013-09-24 Thread armbru
From: Markus Armbruster Commit 4f193e3 added the test, but screwed up in-tree builds (SRCDIR=.): the tests's output overwrites the expected output, and is thus compared to itself. Cc: qemu-sta...@nongnu.org Reported-by: Laszlo Ersek Reviewed-by: Andreas Färber Reviewed-by: Laszlo Ersek Signed

Re: [Qemu-devel] KVM Guest keymap issue

2013-09-24 Thread Markus Armbruster
Not specific to KVM, adding qemu-devel. Matej Mailing writes: > Dear list, > > I have a problem with a Windows XP guest that I connect to via VNC and > is using "sl" keymap (option -k sl). > > The guest is Windows XP and the problematic characters are s, c and z > with caron... when I type them

Re: [Qemu-devel] [PATCH 04/17] blockdev: 'blockdev-add' QMP command

2013-09-24 Thread Kevin Wolf
Am 24.09.2013 um 07:18 hat Fam Zheng geschrieben: > On Fri, 09/20 13:54, Kevin Wolf wrote: > > For examples see the changes to qmp-commands.hx. > > > > Signed-off-by: Kevin Wolf > > --- > > blockdev.c | 57 > > qapi-schema.json | 270 > > +

[Qemu-devel] Query: Support for various hardware types

2013-09-24 Thread Nehal J Wani
Hello! I am currently developing an API for libvirt to print out the leases info for a given network. Since dnsmasq supports hardware types other than ethernet, I want to know whether there are any on going developments or plans for introducing other hardware types (example: IEEE1394 clients u

Re: [Qemu-devel] [PATCH] hw/pci: completed master-abort emulation

2013-09-24 Thread Marcel Apfelbaum
On Mon, 2013-09-23 at 21:45 +0300, Michael S. Tsirkin wrote: > On Mon, Sep 23, 2013 at 08:49:53PM +0300, Marcel Apfelbaum wrote: > > On Mon, 2013-09-23 at 18:10 +0300, Michael S. Tsirkin wrote: > > > On Mon, Sep 23, 2013 at 05:43:38PM +0300, Marcel Apfelbaum wrote: > > > > On Mon, 2013-09-23 at 16:

Re: [Qemu-devel] [PATCH v4 1/4] seqlock: introduce read-write seqlock

2013-09-24 Thread Paolo Bonzini
Il 24/09/2013 07:33, liu ping fan ha scritto: > On Mon, Sep 23, 2013 at 2:21 PM, Jan Kiszka wrote: >> On 2013-09-22 10:11, Liu Ping Fan wrote: >>> This lets the read-side access run outside the BQL. >> >> In fact, not only BQL. Didn't the original commit provide a changlog >> about the content of

Re: [Qemu-devel] [PATCH V2 2/4] qemu-nbd: support internal snapshot export

2013-09-24 Thread Paolo Bonzini
Il 24/09/2013 04:56, Wenchao Xia ha scritto: > 于 2013/9/23 18:25, Paolo Bonzini 写道: >> Il 22/09/2013 11:39, Wenchao Xia ha scritto: >>> Now it is possible to directly export an internal snapshot, which >>> can be used to probe the snapshot's contents without qemu-img >>> convert. >>> >>> Signed-off

Re: [Qemu-devel] [PATCH] migration: add version supporting macros for struct pointer

2013-09-24 Thread Juan Quintela
Alexey Kardashevskiy wrote: > This adds version supporting macros VMSTATE_STRUCT_POINTER_TEST_V > and VMSTATE_STRUCT_POINTER_V in addition to the already existing > VMSTATE_STRUCT_POINTER and VMSTATE_STRUCT_POINTER_TEST macros. > > Cc: Andreas Färber > Signed-off-by: Alexey Kardashevskiy Review

Re: [Qemu-devel] [PATCH v2] migration: Fix debug print type

2013-09-24 Thread Juan Quintela
Christoffer Dall wrote: > The printf args are uint64_t and with -Werr QEMU doesn't compile with > migration debugging turned on unless this is fixed. Fix it. > > Signed-off-by: Christoffer Dall Reviewed-by: Juan Quintela

Re: [Qemu-devel] [PATCH v3 1/2] arch_init: make is_zero_page accept size

2013-09-24 Thread Juan Quintela
Isaku Yamahata wrote: > Later is_zero_page will be used for non TARGET_PAGE_SIZE > range. > And rename it to is_zero_range as it isn't page size any more. > > Signed-off-by: Isaku Yamahata Reviewed-by: Juan Quintela

Re: [Qemu-devel] [PATCH v3 2/2] migration: ram_handle_compressed

2013-09-24 Thread Juan Quintela
Isaku Yamahata wrote: > ram_handle_compressed() should be aware of size > TARGET_PAGE_SIZE. > migration-rdma can call it with larger size. > > Signed-off-by: Isaku Yamahata Reviewed-by: Juan Quintela

[Qemu-devel] [PULL 0/4] audio patch queue

2013-09-24 Thread Gerd Hoffmann
Hi, My first audio pull request. malc seems to have disappeared. I'll go try to take care for the audio bits for the time being. This pull request carries a MAINTAINERS update and patches to make mixer support in hda-audio a runtime option (was compile time option depending on CONFIG_MIXEMU b

[Qemu-devel] [PATCH 1/4] audio maintainers update

2013-09-24 Thread Gerd Hoffmann
av1...@comtv.ru bounces, and I havn't seen malc @ qemu-devel for quite a while (anyone knows what is up?). Adding myself as audio maintainer, so audio patches don't fall through the cracks that easily. Signed-off-by: Gerd Hoffmann --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --gi

[Qemu-devel] [PATCH 2/4] hda-codec: refactor common definitions into a header file

2013-09-24 Thread Gerd Hoffmann
From: Bandan Das Move common defines and structs to a header file. The next commit will include it twice, once for a device with a mixer, and once for device without a mixer. Signed-off-by: Bandan Das Signed-off-by: Gerd Hoffmann --- hw/audio/hda-codec-common.h | 449 +

[Qemu-devel] [PATCH 3/4] hda-codec: make mixemu selectable at runtime

2013-09-24 Thread Gerd Hoffmann
From: Bandan Das Define PARAM so that we have two versions of the "desc_codec and family" structs. Add a property called "mixer" whose default value depends on whether CONFIG_MIXEMU is defined or not which will help us call the appropriate instance init functions. Signed-off-by: Bandan Das Sign

[Qemu-devel] [PATCH 4/4] audio: remove CONFIG_MIXEMU configure option

2013-09-24 Thread Gerd Hoffmann
From: Bandan Das Signed-off-by: Bandan Das Signed-off-by: Gerd Hoffmann --- audio/mixeng.c | 6 -- configure| 8 hw/audio/hda-codec.c | 30 -- 3 files changed, 44 deletions(-) diff --git a/audio/mixeng.c b/audio/mixeng.c index 02a9d

Re: [Qemu-devel] [PATCH] hw/pci: completed master-abort emulation

2013-09-24 Thread Marcel Apfelbaum
On Tue, 2013-09-24 at 11:29 +0300, Michael S. Tsirkin wrote: > On Tue, Sep 24, 2013 at 11:07:19AM +0300, Marcel Apfelbaum wrote: > > On Mon, 2013-09-23 at 21:45 +0300, Michael S. Tsirkin wrote: > > > On Mon, Sep 23, 2013 at 08:49:53PM +0300, Marcel Apfelbaum wrote: > > > > On Mon, 2013-09-23 at 18:

Re: [Qemu-devel] [PATCH] hw/pci: completed master-abort emulation

2013-09-24 Thread Michael S. Tsirkin
corrected Anthony's mail. On Tue, Sep 24, 2013 at 11:44:57AM +0300, Marcel Apfelbaum wrote: > > Not necessarily. Another bridge can claim it then > > terminate with MA. > > > > Example: > > > > -[:00]-+-00.0 > >+-02.0 > >+-16.0 > >+-16.3 > >+-1

Re: [Qemu-devel] [PATCH] linux-user: Fix wrong use of stat instead of stat64 for sparc64

2013-09-24 Thread Riku Voipio
On Mon, Sep 23, 2013 at 09:05:03PM +0900, Peter Maydell wrote: > On 23 September 2013 20:57, Riku Voipio wrote: > > On Thu, Sep 19, 2013 at 07:31:51PM +0200, Stefan Weil wrote: > >> Ping? Are there any more opinions how qemu-sparc64 should be fixed? > >> Should we choose Peter's approach (which is

Re: [Qemu-devel] [PATCH] hw/pci: completed master-abort emulation

2013-09-24 Thread Michael S. Tsirkin
On Tue, Sep 24, 2013 at 11:07:19AM +0300, Marcel Apfelbaum wrote: > On Mon, 2013-09-23 at 21:45 +0300, Michael S. Tsirkin wrote: > > On Mon, Sep 23, 2013 at 08:49:53PM +0300, Marcel Apfelbaum wrote: > > > On Mon, 2013-09-23 at 18:10 +0300, Michael S. Tsirkin wrote: > > > > On Mon, Sep 23, 2013 at 0

Re: [Qemu-devel] [PATCH v4 00/23] qemu: generate acpi tables for the guest

2013-09-24 Thread Gerd Hoffmann
On So, 2013-09-22 at 16:37 +0300, Michael S. Tsirkin wrote: > This code can also be found here: > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git acpi Program received signal SIGSEGV, Segmentation fault. qobject_to_qint (obj=obj@entry=0x0) at /home/kraxel/projects/qemu/qobject/qint.c:51 51

Re: [Qemu-devel] [PATCH 4/7] usb-hcd-xhci: Remove unused sstreamsm member from XHCIStreamContext

2013-09-24 Thread Gerd Hoffmann
On Mo, 2013-09-23 at 20:54 +0200, Hans de Goede wrote: > Signed-off-by: Hans de Goede Patch doesn't apply. That are bits for the (not fully implemented yet) secondary stream arrays btw. We might complete the implementation instead of kicking them out. I have no idea whenever there is a reasona

[Qemu-devel] [PULL][RESEND] char: fix segfault on chardev detach

2013-09-24 Thread Amit Shah
Hi Anthony, Please pull to receive a fix for a segfault in the char layer. The patches have been on the list for a week, and Gerd has reviewed them. (I'm overloading the virtio-serial git tree for this series, haven't gotten around to setting up a separate tree for char yet.) The following cha

Re: [Qemu-devel] [PATCH 1/6] kvm: Add KVM_GET_EMULATED_CPUID

2013-09-24 Thread Borislav Petkov
On Mon, September 23, 2013 6:28 pm, Eduardo Habkost wrote: > On Sun, Sep 22, 2013 at 04:44:50PM +0200, Borislav Petkov wrote: >> From: Borislav Petkov >> >> Add a kvm ioctl which states which system functionality kvm emulates. >> The format used is that of CPUID and we return the corresponding CPU

[Qemu-devel] Attaching PCI devices to the PCIe root complex

2013-09-24 Thread Laine Stump
When I added support for the Q35-based machinetypes to libvirt, I specifically prohibited attaching any PCI devices (with the exception of graphics controllers) to the PCIe root complex, and had planned to prevent attaching them to PCIe root ports (ioh3420 device) and PCIe downstream switch ports (

Re: [Qemu-devel] [PATCH 1/6] kvm: Add KVM_GET_EMULATED_CPUID

2013-09-24 Thread Gleb Natapov
On Tue, Sep 24, 2013 at 11:57:00AM +0200, Borislav Petkov wrote: > On Mon, September 23, 2013 6:28 pm, Eduardo Habkost wrote: > > On Sun, Sep 22, 2013 at 04:44:50PM +0200, Borislav Petkov wrote: > >> From: Borislav Petkov > >> > >> Add a kvm ioctl which states which system functionality kvm emulat

Re: [Qemu-devel] [PATCH] spapr: increase temporary fdt buffer size

2013-09-24 Thread mike
On 09/24/2013 01:59 PM, Alexey Kardashevskiy wrote: At the moment the size of the buffer is set to 64K which is enough for approximately 150 VCPUs which is not the limit. This increases the buffer up to 256K which allows having a tree for approximately 600 VCPUs which is way beyond the real numb

[Qemu-devel] [PATCH] block: use correct filename for error report

2013-09-24 Thread Dunrong Huang
The content filename point to will be erased by qemu_opts_absorb_qdict() in raw_open_common() in drv->bdrv_file_open() So it's better to use bs->filename. Signed-off-by: Dunrong Huang --- block.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c index ea4

Re: [Qemu-devel] [PATCH 04/17] blockdev: 'blockdev-add' QMP command

2013-09-24 Thread Paolo Bonzini
Il 20/09/2013 13:54, Kevin Wolf ha scritto: > + * For now, simply forbidding the combination for all drivers will do. */ > +if (options->has_aio && options->aio == BLOCKDEV_A_I_O_OPTIONS_NATIVE) { Let's call it BlockdevAioOptions instead? Paolo > +bool direct = options->cache->h

Re: [Qemu-devel] [PATCH 04/17] blockdev: 'blockdev-add' QMP command

2013-09-24 Thread Paolo Bonzini
Il 20/09/2013 16:01, Benoît Canet ha scritto: >> > +if (error_is_set(&local_err)) { >> > +error_propagate(errp, local_err); >> > +goto fail; > There is nothing to execute between error_propagate and fail: maybe we could > get rid of the goto. Or perhaps of the "else". Paolo >

Re: [Qemu-devel] [PATCH] hw/pci: completed master-abort emulation

2013-09-24 Thread Marcel Apfelbaum
On Tue, 2013-09-24 at 11:58 +0300, Michael S. Tsirkin wrote: > corrected Anthony's mail. > > On Tue, Sep 24, 2013 at 11:44:57AM +0300, Marcel Apfelbaum wrote: > > > Not necessarily. Another bridge can claim it then > > > terminate with MA. > > > > > > Example: > > > > > > -[:00]-+-00.0 > > >

Re: [Qemu-devel] Query: Support for various hardware types

2013-09-24 Thread Paolo Bonzini
Il 24/09/2013 10:04, Nehal J Wani ha scritto: > Hello! > I am currently developing an API for libvirt to print out the > leases info for a given network. Since dnsmasq supports hardware types > other than ethernet, I want to know whether there are any on going > developments or plans for intro

Re: [Qemu-devel] [PATCH] hw/pci: completed master-abort emulation

2013-09-24 Thread Peter Maydell
On 24 September 2013 19:44, Marcel Apfelbaum wrote: > We need to check all the bridges on each bus encountered > for their address range; if it corresponds to the transaction address, > we pass the bridge to the other bus(depending on transaction's direction). I haven't looked at all at the detai

Re: [Qemu-devel] [PATCH 04/17] blockdev: 'blockdev-add' QMP command

2013-09-24 Thread Kevin Wolf
Am 24.09.2013 um 12:41 hat Paolo Bonzini geschrieben: > Il 20/09/2013 16:01, Benoît Canet ha scritto: > >> > +if (error_is_set(&local_err)) { > >> > +error_propagate(errp, local_err); > >> > +goto fail; > > There is nothing to execute between error_propagate and fail: maybe we c

Re: [Qemu-devel] [PATCH] hw/pci: completed master-abort emulation

2013-09-24 Thread Marcel Apfelbaum
On Tue, 2013-09-24 at 19:55 +0900, Peter Maydell wrote: > On 24 September 2013 19:44, Marcel Apfelbaum wrote: > > We need to check all the bridges on each bus encountered > > for their address range; if it corresponds to the transaction address, > > we pass the bridge to the other bus(depending on

Re: [Qemu-devel] [PATCH] hw/pci: completed master-abort emulation

2013-09-24 Thread Peter Maydell
On 24 September 2013 20:17, Marcel Apfelbaum wrote: > I was suggesting an algorithm to find the MA device in order > to set MA Received Bit in its Status(Sec_Status) register. > > The algorithm was to traverse the PCI buses for finding the > MA device using the transaction address. Yes. My point

Re: [Qemu-devel] [Bug 1228285] [NEW] e1000 nic TCP performances

2013-09-24 Thread Stefan Hajnoczi
On Fri, Sep 20, 2013 at 05:21:23PM -, Vincent Autefage wrote: > Here is the context : > > $ qemu -name A -m 1024 -net nic vlan=0,model=e1000 -net > socket,vlan=0,listen=127.0.0.1:7000 > $ qemu -name B -m 1024 -net nic vlan=0,model=e1000 -net > socket,vlan=0,connect=127.0.0.1:7000 > > The ba

Re: [Qemu-devel] [PATCH] qemu-iotests: Do not execute 052 with -nocache

2013-09-24 Thread Stefan Hajnoczi
On Mon, Sep 23, 2013 at 04:38:33PM +0200, Max Reitz wrote: > Test 052 uses qemu-io -s which will result in bdrv_open trying to create > a temporary snapshot file in /tmp. However, since O_DIRECT and tmpfs > do not work well together, disable this test for -nocache. > > Signed-off-by: Max Reitz >

Re: [Qemu-devel] [PATCH] hw/pci: completed master-abort emulation

2013-09-24 Thread Marcel Apfelbaum
On Tue, 2013-09-24 at 20:21 +0900, Peter Maydell wrote: > On 24 September 2013 20:17, Marcel Apfelbaum wrote: > > I was suggesting an algorithm to find the MA device in order > > to set MA Received Bit in its Status(Sec_Status) register. > > > > The algorithm was to traverse the PCI buses for find

Re: [Qemu-devel] [PATCH v2 0/0] .travis and minor compile fixes

2013-09-24 Thread Stefan Hajnoczi
On Mon, Sep 23, 2013 at 05:07:27PM +0100, alex.ben...@linaro.org wrote: > Given I found a couple of issues while doing this I think this is > useful alongside the existing buildbot efforts. It allows developers > to run simple smoke-tests without access to the buildbot > infrastructure (but of cour

[Qemu-devel] [PATCH] qcow2: Don't shadow return value

2013-09-24 Thread Max Reitz
When trying to update the refcounts for a snapshot, the return value of update_refcount on a compressed cluster was pretty much ignored, cancelling the update on error but returning 0. This is caused by an inner "ret" variable shadowing the outer one (the latter is used in the return statement). S

[Qemu-devel] [PULL 0/9] migration queue

2013-09-24 Thread Juan Quintela
Hi Anthony This are the migration patches on the list at the moment, could you apply? * cleanup patches from Isaku * change is_zero_page() prototype * cleanups from Lei Li * cleanup from Christoffer Dall * new VMSTATE macro from Alexey They are quite easy, passed virt-test without trouble. Tha

[Qemu-devel] [PATCH 2/9] savevm: fix wrong initialization by ram_control_load_hook

2013-09-24 Thread Juan Quintela
From: Lei Li It should set negative error value rather than 0 in QEMUFile if there has been an error. Reviewed-by: Michael R. Hines Signed-off-by: Lei Li Signed-off-by: Juan Quintela --- savevm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/savevm.c b/savevm.c index a8

[Qemu-devel] [PATCH 4/9] rdma: clean up of qemu_rdma_cleanup()

2013-09-24 Thread Juan Quintela
From: Isaku Yamahata - It can't be determined by RDMAContext::cm_id != NULL if the connection is established or not. - RDMAContext::cm_id is leaked and not destroyed because it is set to NULL too early. - RDMAContext::qp is created by rdma_create_qp() so that it should be destroyed by rdma_

[Qemu-devel] [PATCH 5/9] rdma: constify ram_chunk_{index, start, end}

2013-09-24 Thread Juan Quintela
From: Isaku Yamahata Signed-off-by: Isaku Yamahata Signed-off-by: Juan Quintela --- migration-rdma.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/migration-rdma.c b/migration-rdma.c index 3679acb..f94f3b4 100644 --- a/migration-rdma.c +++ b/migration-rdma.c @@ -5

[Qemu-devel] [PATCH 3/9] arch_init: right return for ram_save_iterate

2013-09-24 Thread Juan Quintela
From: Lei Li qemu_file_rate_limit() never return negative value since the refactor by Commit 1964a39, this patch gets rid of the negative check for it, adjust bytes_transferred and return value correspondingly in ram_save_iterate(). Signed-off-by: Lei Li Signed-off-by: Paolo Bonzini Signed-off

[Qemu-devel] [PATCH 6/9] migration: add version supporting macros for struct pointer

2013-09-24 Thread Juan Quintela
From: Alexey Kardashevskiy This adds version supporting macros VMSTATE_STRUCT_POINTER_TEST_V and VMSTATE_STRUCT_POINTER_V in addition to the already existing VMSTATE_STRUCT_POINTER and VMSTATE_STRUCT_POINTER_TEST macros. Cc: Andreas Färber Signed-off-by: Alexey Kardashevskiy Signed-off-by: Jua

[Qemu-devel] [PATCH 8/9] arch_init: make is_zero_page accept size

2013-09-24 Thread Juan Quintela
From: Isaku Yamahata Later is_zero_page will be used for non TARGET_PAGE_SIZE range. And rename it to is_zero_range as it isn't page size any more. Signed-off-by: Isaku Yamahata Signed-off-by: Juan Quintela --- arch_init.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff -

[Qemu-devel] [PATCH 1/9] savevm: add comments for qemu_file_get_error()

2013-09-24 Thread Juan Quintela
From: Lei Li Add comments for qemu_file_get_error(), as its return value is not very clear. Signed-off-by: Lei Li Signed-off-by: Juan Quintela --- savevm.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/savevm.c b/savevm.c index 4a3c819..a834c6f 100644 --- a/savevm.c +++ b/savevm.

[Qemu-devel] [PATCH 7/9] migration: Fix debug print type

2013-09-24 Thread Juan Quintela
From: Christoffer Dall The printf args are uint64_t and with -Werr QEMU doesn't compile with migration debugging turned on unless this is fixed. Fix it. Signed-off-by: Christoffer Dall Signed-off-by: Juan Quintela --- migration.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[Qemu-devel] [PATCH 9/9] migration: ram_handle_compressed

2013-09-24 Thread Juan Quintela
From: Isaku Yamahata ram_handle_compressed() should be aware of size > TARGET_PAGE_SIZE. migration-rdma can call it with larger size. Signed-off-by: Isaku Yamahata Signed-off-by: Juan Quintela --- arch_init.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/arch

Re: [Qemu-devel] [PATCH 3/3] block/stream.c: ensure copy always set

2013-09-24 Thread Stefan Hajnoczi
On Mon, Sep 23, 2013 at 05:07:30PM +0100, alex.ben...@linaro.org wrote: > From: Alex Bennée > > This only showed up when compiling with > --enable-trace-backend=stderr|ftrace at which point the compiler > complains with the following: > > block/stream.c: In function ‘stream_run’: > block/stream.

Re: [Qemu-devel] [PATCH] block: use correct filename for error report

2013-09-24 Thread Max Reitz
On 2013-09-24 12:14, Dunrong Huang wrote: The content filename point to will be erased by qemu_opts_absorb_qdict() in raw_open_common() in drv->bdrv_file_open() So it's better to use bs->filename. Signed-off-by: Dunrong Huang --- block.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletion

Re: [Qemu-devel] Qxl problem with xen domU, is xen spice and/or qemu bugs?

2013-09-24 Thread Gerd Hoffmann
Hi, > Someone can help me to find the problem that makes qxl unusable please? #1 git cherry-pick c58c7b959b93b864a27fd6b3646ee1465ab8832b #2 When using f19 try without X11 first. You should have a working framebuffer console on qxldrmfb before trying to get X11 going. #3 qxl has a bunch o

[Qemu-devel] [PATCH V3] introduce .bdrv_needs_filename

2013-09-24 Thread Benoît Canet
v3: Add comment [Eric] v1-2: simplify assertion [Kevin] add .bdrv_needs_filename only to driver to having .bdrv_parse_filename nor .bdrv_open [Kevin] Tested that raw, qed and ssh protocols works fine. Benoît Canet (1): block: introduce BlockDriver.bdrv_needs_filename to e

[Qemu-devel] [PATCH V3] block: introduce BlockDriver.bdrv_needs_filename to enable some drivers.

2013-09-24 Thread Benoît Canet
Some drivers will have driver specifics options but no filename. This new bool allow the block layer to treat them correctly. The .bdrv_needs_filename is set in drivers not having .bdrv_parse_filename and not having .bdrv_open. The first exception to this rule will be the quorum driver. Signed-o

Re: [Qemu-devel] [PATCH] tracing: start trace processing thread in final child process

2013-09-24 Thread Stefan Hajnoczi
On Mon, Sep 23, 2013 at 04:36:54PM +0200, Christian Borntraeger wrote: > From: Michael Mueller > > When running with trace backend e.g. "simple" the writer thread needs to be > implemented in the same process context as the trace points that will be > processed. Under libvirtd control, qemu gets

Re: [Qemu-devel] [PATCH v2 0/0] .travis and minor compile fixes

2013-09-24 Thread Stefan Hajnoczi
On Mon, Sep 23, 2013 at 05:07:27PM +0100, alex.ben...@linaro.org wrote: > I've updated the .travis.yml following feedback from Stefan to greatly > increase the number of compiles it does. In the process: > > * Disabled ust backend (horribly broken) > * Found gov/gprof builds don't enforce --disabl

Re: [Qemu-devel] [PATCH 1/2] qemu-iotests: fix test case 059

2013-09-24 Thread Stefan Hajnoczi
On Tue, Sep 24, 2013 at 10:49:33AM +0800, Fam Zheng wrote: > Since commit "block: Error parameter for open functions", error output > is more verbose. Update test case output file to follow the change. This doesn't explain the "Formatting ..." trailing space change. If this has changed, please sp

Re: [Qemu-devel] [PATCH v2] vmdk: fix cluster size check for flat extents

2013-09-24 Thread Stefan Hajnoczi
On Mon, Sep 23, 2013 at 05:18:29PM +0800, Fam Zheng wrote: > We use the extent size as cluster size for flat extents (where no L1/L2 > table is allocated so it's safe) reuse sector calculating code with > sparse extents. > > Don't pass in the cluster size for adding flat extent, just set it to > s

Re: [Qemu-devel] [PATCH V3] block: introduce BlockDriver.bdrv_needs_filename to enable some drivers.

2013-09-24 Thread Eric Blake
On 09/24/2013 06:27 AM, Benoît Canet wrote: > Some drivers will have driver specifics options but no filename. > This new bool allow the block layer to treat them correctly. > > The .bdrv_needs_filename is set in drivers not having .bdrv_parse_filename and > not having .bdrv_open. > > The first e

Re: [Qemu-devel] [RFC 00/16] TCG indirect registers

2013-09-24 Thread Artyom Tarasenko
On Mon, Sep 23, 2013 at 8:06 PM, Richard Henderson wrote: > On 09/23/2013 10:23 AM, Blue Swirl wrote: >> On Fri, Sep 20, 2013 at 12:24 AM, Richard Henderson wrote: >>> >>> This is an attempt to improve performance of target-sparc >>> by exposing the windowed registers as TCG globals, and all >>>

[Qemu-devel] [PATCHv3 01/20] block: make BdrvRequestFlags public

2013-09-24 Thread Peter Lieven
Reviewed-by: Eric Blake Signed-off-by: Peter Lieven --- block.c |5 - include/block/block.h |5 + 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/block.c b/block.c index ea4956d..8eefb97 100644 --- a/block.c +++ b/block.c @@ -51,11 +51,6 @@ #define

[Qemu-devel] [PATCHv3 02/20] block: add flags to bdrv_*_write_zeroes

2013-09-24 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block-migration.c |2 +- block.c | 20 +++- block/backup.c|3 ++- block/qcow2-cluster.c |2 +- block/qcow2.c |2 +- block/qed.c |3 ++- block/raw_bsd.c

[Qemu-devel] [PATCHv3 04/20] block: introduce bdrv_has_discard_zeroes and bdrv_has_discard_write_zeroes

2013-09-24 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block.c | 29 + include/block/block.h |2 ++ include/block/block_int.h | 13 + 3 files changed, 44 insertions(+) diff --git a/block.c b/block.c index e7bf6af..ac35cb5 100644 --- a/block.c +++ b/

[Qemu-devel] [PATCHv3 03/20] block: introduce BDRV_REQ_MAY_UNMAP request flag

2013-09-24 Thread Peter Lieven
Reviewed-by: Eric Blake Signed-off-by: Peter Lieven --- block-migration.c |3 ++- block.c |4 block/backup.c|2 +- include/block/block.h |7 +++ 4 files changed, 14 insertions(+), 2 deletions(-) diff --git a/block-migration.c b/block-migration.

[Qemu-devel] [PATCHv3 11/20] iscsi: add bdrv_has_discard_zeroes and bdrv_has_discard_write_zeroes

2013-09-24 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block/iscsi.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/block/iscsi.c b/block/iscsi.c index 90dc7c2..f6cd322 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -1449,6 +1449,18 @@ static int iscsi_has_zero_init(BlockDrive

[Qemu-devel] [PATCHv3 16/20] block/get_block_status: avoid redundant callouts on raw devices

2013-09-24 Thread Peter Lieven
if a raw device like an iscsi target or host device is used the current implementation makes a second call out to get the block status of bs->file. however, the raw driver already has called bdrv_get_block_status on bs->file. Reviewed-by: Eric Blake Signed-off-by: Peter Lieven --- block.c |

[Qemu-devel] [PATCHv3 18/20] qemu-img: add support for fully allocated images

2013-09-24 Thread Peter Lieven
Signed-off-by: Peter Lieven --- qemu-img.c |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 926f0a0..c6eff15 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -100,8 +100,10 @@ static void help(void) " '-h' with or without a comma

[Qemu-devel] [PATCHv3 07/20] block: honour BlockLimits in bdrv_co_do_write_zeroes

2013-09-24 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block.c | 65 +++ 1 file changed, 49 insertions(+), 16 deletions(-) diff --git a/block.c b/block.c index ac35cb5..580570a 100644 --- a/block.c +++ b/block.c @@ -2710,32 +2710,65 @@ int coroutine_fn bdrv

[Qemu-devel] [PATCHv3 14/20] block/get_block_status: set *pnum = 0 on error

2013-09-24 Thread Peter Lieven
if the call is invoked through bdrv_is_allocated the caller might expect *pnum = 0 on error. however, a new implementation of bdrv_get_block_status might only return a negative exit value on error while keeping *pnum untouched. Reviewed-by: Eric Blake Signed-off-by: Peter Lieven --- block.c |

[Qemu-devel] [PATCHv3 13/20] block: introduce bdrv_zeroize

2013-09-24 Thread Peter Lieven
this patch adds a call to completely zero out a block device. the operation is sped up by checking the block status and only writing zeroes to the device if they currently do not return zeroes. optionally the zero writing can be sped up by setting the flag BDRV_REQ_MAY_UNMAP to emulate the zero wri

[Qemu-devel] [PATCHv3 17/20] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks

2013-09-24 Thread Peter Lieven
this patch does 2 things: a) only do additional call outs if BDRV_BLOCK_ZERO is not already set. b) use the newly introduced bdrv_has_discard_zeroes() to return the zero state of an unallocated block. the used callout to bdrv_has_zero_init() is only valid right after bdrv_create. Reviewed-by

[Qemu-devel] [PATCHv3 20/20] block/raw: copy BlockLimits on raw_open

2013-09-24 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block/raw_bsd.c |1 + 1 file changed, 1 insertion(+) diff --git a/block/raw_bsd.c b/block/raw_bsd.c index 8dc7bba..7af26ad 100644 --- a/block/raw_bsd.c +++ b/block/raw_bsd.c @@ -159,6 +159,7 @@ static int raw_open(BlockDriverState *bs, QDict *options, int fla

[Qemu-devel] [PATCHv3 19/20] qemu-img: conditionally zero out target on convert

2013-09-24 Thread Peter Lieven
If the target has_zero_init = 0, but supports efficiently writing zeroes by unmapping we call bdrv_zeroize to avoid fully allocating the target. Ihis currently is designed especially for iscsi. Reviewed-by: Eric Blake Signed-off-by: Peter Lieven --- qemu-img.c | 10 +- 1 file changed,

[Qemu-devel] [PATCHv3 12/20] iscsi: add bdrv_co_write_zeroes

2013-09-24 Thread Peter Lieven
Reviewed-by: Eric Blake Signed-off-by: Peter Lieven --- block/iscsi.c | 59 + 1 file changed, 59 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index f6cd322..8f52ef8 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -56,6 +56,

[Qemu-devel] [PATCHv3 15/20] block/get_block_status: avoid segfault if there is no backing_hd

2013-09-24 Thread Peter Lieven
Reviewed-by: Eric Blake Signed-off-by: Peter Lieven --- block.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block.c b/block.c index 3499c90..3bf1163 100644 --- a/block.c +++ b/block.c @@ -3266,7 +3266,7 @@ static int64_t coroutine_fn bdrv_co_get_block_status(BlockDriv

[Qemu-devel] [PATCHv3 05/20] block/raw: add bdrv_has_discard_zeroes and bdrv_has_discard_write_zeroes

2013-09-24 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block/raw_bsd.c | 56 +-- 1 file changed, 34 insertions(+), 22 deletions(-) diff --git a/block/raw_bsd.c b/block/raw_bsd.c index d5ab295..8dc7bba 100644 --- a/block/raw_bsd.c +++ b/block/raw_bsd.c @@ -131,6 +13

[Qemu-devel] [PATCHv3 10/20] iscsi: set limits in BlockDriverState

2013-09-24 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block/iscsi.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index ce8823d..90dc7c2 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -1367,6 +1367,20 @@ static int iscsi_open(BlockDriverState *bs, QDict *option

Re: [Qemu-devel] [RFC] [PATCHv10 00/31] aio / timers: Add AioContext timers and use ppoll

2013-09-24 Thread Stefan Hajnoczi
On Wed, Sep 18, 2013 at 11:25:25AM +0200, Paolo Bonzini wrote: > Il 18/09/2013 11:02, Alex Bligh ha scritto: > > Paolo, > > > > On 18 Sep 2013, at 09:23, Alex Bligh wrote: > > > >>> Yes, that was my understanding too. Can we do it for 1.7? > > > > Whilst we are changing the calling semantics, d

  1   2   >