Re: [Qemu-devel] [PATCH v3 02/18] arm/boot: Turn arm_load_kernel() into no-op for qtest without -kernel

2013-09-23 Thread Andreas Färber
Am 23.09.2013 15:35, schrieb Andreas Färber: > Signed-off-by: Andreas Färber > --- > hw/arm/boot.c | 4 > 1 file changed, 4 insertions(+) Sorry, I forgot that Grant Likely had an alternative patch [1] not restricted to qtest. Last thing I read was that PMM had similar/further patches. How t

Re: [Qemu-devel] [PATCH v4 04/12] xics: replace fprintf with error_report

2013-09-23 Thread Andreas Färber
Am 30.08.2013 07:28, schrieb Alexey Kardashevskiy: > This replaces old-style fprintf with new style error_report. > > Signed-off-by: Alexey Kardashevskiy Reviewed-by: Andreas Färber Thanks, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Gu

[Qemu-devel] [PATCH v3 08/18] omap_sx1: Don't enforce use of kernel or flash for qtest

2013-09-23 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/arm/omap_sx1.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/arm/omap_sx1.c b/hw/arm/omap_sx1.c index b0f8664..235fed8 100644 --- a/hw/arm/omap_sx1.c +++ b/hw/arm/omap_sx1.c @@ -32,6 +32,7 @@ #include "hw/arm/arm.h" #include "hw/bl

[Qemu-devel] [PATCH v3 06/18] z2: Don't enforce use of -pflash for qtest

2013-09-23 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/arm/z2.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/arm/z2.c b/hw/arm/z2.c index 2e0d5d4..61c9ca7 100644 --- a/hw/arm/z2.c +++ b/hw/arm/z2.c @@ -24,6 +24,7 @@ #include "ui/console.h" #include "audio/audio.h" #include "exec/a

[Qemu-devel] [PATCH 04/10] target-s390: Raise OPERATION exception for disabled insns

2013-09-23 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-s390x/translate.c | 12 1 file changed, 12 insertions(+) diff --git a/target-s390x/translate.c b/target-s390x/translate.c index 5aac7b0..c8bbedb 100644 --- a/target-s390x/translate.c +++ b/target-s390x/translate.c @@ -53,6 +53,7 @@ struct

Re: [Qemu-devel] [PATCH 5/5] hw: arm_gic_kvm: Add KVM VGIC save/restore logic

2013-09-23 Thread Christoffer Dall
On Mon, Sep 23, 2013 at 09:02:44PM +0900, Peter Maydell wrote: > On 23 September 2013 11:14, Christoffer Dall > wrote: > > On Sat, Sep 21, 2013 at 06:38:19PM +0900, Peter Maydell wrote: > > (2) How does the arm_gic_kvm.c code detect the underlying host CPU that > > the kernel read the regist

[Qemu-devel] [PATCH v3 17/18] leon3: Don't enforce use of -bios with qtest

2013-09-23 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/sparc/leon3.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/sparc/leon3.c b/hw/sparc/leon3.c index 390f3e4..c583c3d 100644 --- a/hw/sparc/leon3.c +++ b/hw/sparc/leon3.c @@ -26,6 +26,7 @@ #include "hw/ptimer.h" #include "sysemu/char

[Qemu-devel] [PATCH v2 0/0] .travis and minor compile fixes

2013-09-23 Thread alex . bennee
Hi, I've updated the .travis.yml following feedback from Stefan to greatly increase the number of compiles it does. In the process: * Disabled ust backend (horribly broken) * Found gov/gprof builds don't enforce --disable-pie * Fixed a minor compiler warning when stderr/ftrace back-end enabled I

[Qemu-devel] [PATCH 1/3] .travis.yml: basic compile and check recipes

2013-09-23 Thread alex . bennee
From: Alex Bennée While QEMU already has various continuous integration set-ups in buildbot and commercial Jenkins setups there is some value in supporting travis-ci as well. It is well integrated into GitHub work flow and will trigger on all branch pushes and pull requests. This makes it easier

[Qemu-devel] [PATCH 2/3] .travis.yml: greatly expand the coverage + more builds

2013-09-23 Thread alex . bennee
From: Alex Bennée I've made the definitions more modular to allow for greater build control in each part of the matrix. I've confined the additional stuff to x86/x86_64 for convenience. --- .travis.yml | 38 +- 1 file changed, 37 insertions(+), 1 deletion(-)

Re: [Qemu-devel] [RFC PATCH 4/8] qapi: rename MonitorEvent to QEvent

2013-09-23 Thread Eric Blake
On 09/12/2013 03:15 AM, Wenchao Xia wrote: > Signed-off-by: Wenchao Xia > --- > block.c|2 +- > include/block/block_int.h |2 +- > include/monitor/monitor.h |2 +- > include/qapi/qmp/qevent.h |4 ++-- > monitor.c | 12 ++-- > stubs

Re: [Qemu-devel] [PATCH 05/17] blockdev: Separate ID generation from DriveInfo creation

2013-09-23 Thread Eric Blake
On 09/20/2013 05:54 AM, Kevin Wolf wrote: > blockdev-add shouldn't automatically generate IDs, but will keep most of > the DriveInfo creation code. > > Signed-off-by: Kevin Wolf > --- > blockdev.c| 32 +--- > include/qemu/option.h | 1 + > util/qemu-optio

[Qemu-devel] [PATCH 3/3] block/stream.c: ensure copy always set

2013-09-23 Thread alex . bennee
From: Alex Bennée This only showed up when compiling with --enable-trace-backend=stderr|ftrace at which point the compiler complains with the following: block/stream.c: In function ‘stream_run’: block/stream.c:141:22: error: ‘copy’ may be used uninitialized in this function [-Werror=uninitializ

Re: [Qemu-devel] ChrEMU - Virtualization in the Browser

2013-09-23 Thread Alex Bennée
stefa...@gmail.com writes: > On Tue, Sep 10, 2013 at 08:08:22PM -0400, Joey Carlini wrote: >> I managed to get QEMU running on a Crouton install, virtual box not being >> possible with the Chrome OS kermel with the KVM mods required, and even a >> couple distros running. Since I enjoy pain and/or

Re: [Qemu-devel] [PATCH 6/6] qemu: Add support for emulated CPU features

2013-09-23 Thread Eduardo Habkost
(CCing qemu-devel and libvir-list) On Sun, Sep 22, 2013 at 04:44:55PM +0200, Borislav Petkov wrote: > From: Borislav Petkov > > Add support for the KVM_GET_EMULATED_CPUID ioctl and leave feature bits > enabled, when requested by userspace, if kvm emulates them. > > Signed-off-by: Borislav Petko

Re: [Qemu-devel] [RFC PATCH 2/8] block: do not include monitor.h in block.c

2013-09-23 Thread Eric Blake
On 09/12/2013 03:15 AM, Wenchao Xia wrote: > block_int.h already included it. > > Signed-off-by: Wenchao Xia > --- > block.c |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) Reviewed-by: Eric Blake > > diff --git a/block.c b/block.c > index 2e2774d..a532eaa 100644 > --- a/block.c

Re: [Qemu-devel] [RFC PATCH 1/8] block: use type MonitorEvent directly

2013-09-23 Thread Eric Blake
On 09/12/2013 03:15 AM, Wenchao Xia wrote: > block_int.h included monitor.h, so it knows the typedef. > > Signed-off-by: Wenchao Xia > --- > block.c |2 +- > include/block/block_int.h |2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake -

Re: [Qemu-devel] [PATCH V2] block: introduce BlockDriver.bdrv_needs_filename to enable some drivers.

2013-09-23 Thread Eric Blake
On 09/23/2013 05:52 AM, Benoît Canet wrote: > Some drivers will have driver specifics options but no filename. > This new bool allow the block layer to treat them correctly. > > The .bdrv_needs_filename is set in drivers not having .bdrv_parse_filename and > not having .bdrv_open. > > The first e

Re: [Qemu-devel] [RFC 00/16] TCG indirect registers

2013-09-23 Thread Blue Swirl
On Fri, Sep 20, 2013 at 12:24 AM, Richard Henderson wrote: > > This is an attempt to improve performance of target-sparc > by exposing the windowed registers as TCG globals, and all > the optimization that we can do there. > > This is done via allowing tcg_global_mem_new to be used > with any base

Re: [Qemu-devel] [RFC 00/16] TCG indirect registers

2013-09-23 Thread Richard Henderson
On 09/23/2013 10:23 AM, Blue Swirl wrote: > On Fri, Sep 20, 2013 at 12:24 AM, Richard Henderson wrote: >> >> This is an attempt to improve performance of target-sparc >> by exposing the windowed registers as TCG globals, and all >> the optimization that we can do there. >> >> This is done via allo

Re: [Qemu-devel] [PATCH 1/6] kvm: Add KVM_GET_EMULATED_CPUID

2013-09-23 Thread Eduardo Habkost
On Sun, Sep 22, 2013 at 04:44:50PM +0200, Borislav Petkov wrote: > From: Borislav Petkov > > Add a kvm ioctl which states which system functionality kvm emulates. > The format used is that of CPUID and we return the corresponding CPUID > bits set for which we do emulate functionality. Let me che

Re: [Qemu-devel] [RFC PATCH 3/8] qapi: move MonitorEvent define

2013-09-23 Thread Eric Blake
On 09/12/2013 03:15 AM, Wenchao Xia wrote: > Signed-off-by: Wenchao Xia > --- > new file mode 100644 > index 000..aef71d9 > --- /dev/null > +++ b/include/qapi/qmp/qevent.h > @@ -0,0 +1,41 @@ > +#ifndef QEVENT_H No copyright notice? Fix that. -- Eric Blake eblake redhat com+1-919-301

Re: [Qemu-devel] [PATCH] hw/pci: completed master-abort emulation

2013-09-23 Thread Marcel Apfelbaum
On Mon, 2013-09-23 at 18:10 +0300, Michael S. Tsirkin wrote: > On Mon, Sep 23, 2013 at 05:43:38PM +0300, Marcel Apfelbaum wrote: > > On Mon, 2013-09-23 at 16:45 +0300, Michael S. Tsirkin wrote: > > > On Mon, Sep 23, 2013 at 03:37:43PM +0300, Marcel Apfelbaum wrote: > > > > On Mon, 2013-09-23 at 14:

[Qemu-devel] [PATCH 2/7] usb-host-libusb: Configuration 0 may be a valid configuration

2013-09-23 Thread Hans de Goede
Quoting from: linux/Documentation/ABI/stable/sysfs-bus-usb: Note that some devices, in violation of the USB spec, have a configuration with a value equal to 0. Writing 0 to bConfigurationValue for these devices will install that configuration, rather then unconfigur

[Qemu-devel] [PATCH 6/7] usb-hcd-xhci: Report completion of active transfer with CC_STOPPED on ep stop

2013-09-23 Thread Hans de Goede
As we should per the XHCI spec "4.6.9 Stop Endpoint". Signed-off-by: Hans de Goede --- hw/usb/hcd-xhci.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 9845554..4890344 100644 --- a/hw/usb/hcd-xhci.c +++

[Qemu-devel] [PATCH 4/7] usb-hcd-xhci: Remove unused sstreamsm member from XHCIStreamContext

2013-09-23 Thread Hans de Goede
Signed-off-by: Hans de Goede --- hw/usb/hcd-xhci.c | 8 1 file changed, 8 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 286d272..b343235 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -374,7 +374,6 @@ struct XHCIStreamContext { dma_addr_t pctx;

[Qemu-devel] [PATCH 5/7] usb-hcd-xhci: Remove unused cancelled member from XHCITransfer

2013-09-23 Thread Hans de Goede
Since qemu's USB model is geared towards emulated devices cancellation is instanteneous, so no need to wait for cancellation to complete, as such there is no wait for cancellation code, and the cancelled bool as well as the bogus comment about it can be removed. Signed-off-by: Hans de Goede ---

[Qemu-devel] [PATCH 3/7] usb-host-libusb: Detach kernel drivers earlier

2013-09-23 Thread Hans de Goede
If we detach the kernel drivers on the first set_config, then they will be still attached when the device gets its initial reset. Causing the drivers to re-initialize the device after the reset, dirtying the device state. Signed-off-by: Hans de Goede --- hw/usb/host-libusb.c | 7 +-- 1 file

[Qemu-devel] [PATCH 7/7] usb-hcd-xhci: Update endpoint context dequeue pointer for streams too

2013-09-23 Thread Hans de Goede
With streams the endpoint context dequeue pointer should point to the dequeue value for the currently active stream. At least Linux guests expect it to point to value set by an set_ep_dequeue upon completion of the set_ep_dequeue (before kicking the ep). Otherwise the Linux kernel will complain (

Re: [Qemu-devel] ChrEMU - Virtualization in the Browser

2013-09-23 Thread Anthony Liguori
On Sep 23, 2013 8:46 AM, "Stefan Hajnoczi" wrote: > > On Tue, Sep 10, 2013 at 08:08:22PM -0400, Joey Carlini wrote: > > I managed to get QEMU running on a Crouton install, virtual box not being > > possible with the Chrome OS kermel with the KVM mods required, and even a > > couple distros running

Re: [Qemu-devel] [PATCH] hw/pci: completed master-abort emulation

2013-09-23 Thread Michael S. Tsirkin
On Mon, Sep 23, 2013 at 08:49:53PM +0300, Marcel Apfelbaum wrote: > On Mon, 2013-09-23 at 18:10 +0300, Michael S. Tsirkin wrote: > > On Mon, Sep 23, 2013 at 05:43:38PM +0300, Marcel Apfelbaum wrote: > > > On Mon, 2013-09-23 at 16:45 +0300, Michael S. Tsirkin wrote: > > > > On Mon, Sep 23, 2013 at 0

[Qemu-devel] [PATCH 1/7] usb-host-libusb: Fix reset handling

2013-09-23 Thread Hans de Goede
The guest will issue an initial device reset when the device is attached, but since the current usb-host-libusb code only actually does the reset when udev->configuration != 0, and on attach the device is not yet configured, the reset gets ignored. This means that the device gets passed to the gues

[Qemu-devel] [PATCH 0/7] usb: host-libusb and xhci fixes

2013-09-23 Thread Hans de Goede
Hi Gerd, Here is a set of fixes for host-libusb and xhci, mostly the result of me working on adding support for streams to qemu's host redirection code (and libusb and usbfs in the kernel). I've this almost all working now. The 2 xhci fixes fixup error handling when the real uasp device I have er

Re: [Qemu-devel] [PATCH v3 11/18] axis_dev88: Don't enforce use of kernel for qtest

2013-09-23 Thread Edgar E. Iglesias
On Mon, Sep 23, 2013 at 03:35:45PM +0200, Andreas Färber wrote: > Signed-off-by: Andreas Färber Reviewed-by: Edgar E. Iglesias > --- > hw/cris/axis_dev88.c | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/hw/cris/axis_dev88.c b/hw/cris/axis_dev88.c > index

Re: [Qemu-devel] [PATCH v4 15/23] i386: add bios linker/loader

2013-09-23 Thread Michael S. Tsirkin
On Mon, Sep 23, 2013 at 03:52:21PM +0200, Paolo Bonzini wrote: > Il 23/09/2013 15:47, Michael S. Tsirkin ha scritto: > > > It doesn't, the names were already prefixed with alloc_/pointer_/cksum_. > > > All it does is change underscores to periods. > > > > You are right, that's cleaner. I'll do th

Re: [Qemu-devel] [PATCH] seccomp: adding times() to the whitelist

2013-09-23 Thread Eduardo Otubo
On 09/13/2013 11:45 AM, Paul Moore wrote: On Wednesday, September 04, 2013 10:11:10 AM Paul Moore wrote: On Wednesday, September 04, 2013 09:25:08 AM Eduardo Otubo wrote: This was causing Qemu process to hang when using -sandbox on. Related RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1

Re: [Qemu-devel] [PATCH] seccomp: adding times() to the whitelist

2013-09-23 Thread Paul Moore
On Wednesday, September 04, 2013 10:11:10 AM Paul Moore wrote: > On Wednesday, September 04, 2013 09:25:08 AM Eduardo Otubo wrote: > > This was causing Qemu process to hang when using -sandbox on. > > > > Related RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1004175 > > > > Signed-off-by: Edu

Re: [Qemu-devel] [PATCH] seccomp: adding times() to the whitelist

2013-09-23 Thread Anthony Liguori
On Mon, Sep 23, 2013 at 2:49 PM, Eduardo Otubo wrote: > > > On 09/13/2013 11:45 AM, Paul Moore wrote: > >> On Wednesday, September 04, 2013 10:11:10 AM Paul Moore wrote: >> >>> On Wednesday, September 04, 2013 09:25:08 AM Eduardo Otubo wrote: >>> This was causing Qemu process to hang when usi

Re: [Qemu-devel] [PATCH] seccomp: adding times() to the whitelist

2013-09-23 Thread Eduardo Otubo
On 09/23/2013 04:53 PM, Paul Moore wrote: On Wednesday, September 04, 2013 10:11:10 AM Paul Moore wrote: On Wednesday, September 04, 2013 09:25:08 AM Eduardo Otubo wrote: This was causing Qemu process to hang when using -sandbox on. Related RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1

[Qemu-devel] [Bug 1212051] Re: Windows XP guest lose connectivity with bridged network

2013-09-23 Thread Serge Hallyn
*** This bug is a duplicate of bug 1180777 *** https://bugs.launchpad.net/bugs/1180777 ** This bug has been marked a duplicate of bug 1180777 Windows 7 VM freeze on Ubuntu 12.04 KVM -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QE

[Qemu-devel] [Bug 1180777] Re: RDP traffic freeze on quiet network

2013-09-23 Thread Serge Hallyn
** Summary changed: - Windows 7 VM freeze on Ubuntu 12.04 KVM + RDP traffic freeze on quiet network ** Description changed: + To summarize what I think has been found so far, + + 1. The main symptom is that RDP connections hang after some time + 2. This bug affects qemu 1.0 .. 1.6.5 + 3.

Re: [Qemu-devel] [PATCH v3 02/18] arm/boot: Turn arm_load_kernel() into no-op for qtest without -kernel

2013-09-23 Thread Peter Maydell
On 23 September 2013 23:51, Andreas Färber wrote: > Am 23.09.2013 15:35, schrieb Andreas Färber: >> Signed-off-by: Andreas Färber >> --- >> hw/arm/boot.c | 4 >> 1 file changed, 4 insertions(+) > > Sorry, I forgot that Grant Likely had an alternative patch [1] not > restricted to qtest. Las

[Qemu-devel] [PATCH 0/2] make -kernel optional for all ARM boards

2013-09-23 Thread Peter Maydell
Make -kernel optional for all ARM boards, by allowing arm_load_kernel() to return without doing anything if no kernel filename was provided. In this case we will start execution at address zero (as the hardware does). This allows the user to provide a flash image or similar on some boards; in parti

[Qemu-devel] [PATCH 2/2] hw/arm: Tidy up conditional calls to arm_load_kernel

2013-09-23 Thread Peter Maydell
Now that arm_load_kernel doesn't insist on a kernel filename being present, we can remove some unnecessary conditionals in board models. Signed-off-by: Peter Maydell --- hw/arm/omap_sx1.c | 10 -- hw/arm/palm.c | 10 -- hw/arm/z2.c | 12 +--- 3 files changed, 13

[Qemu-devel] [PATCH 1/2] hw/arm/boot: Make user not specifying a kernel not an error

2013-09-23 Thread Peter Maydell
Typically ARM boards will have some kind of flash which might contain a boot ROM; it's therefore a valid use case to provide only an image for the boot ROM and not require QEMU's internal boot loader at all. Remove the fatal error if -kernel isn't specified. Signed-off-by: Peter Maydell --- hw/a

[Qemu-devel] [Bug 1180777] Re: RDP traffic freeze on quiet network

2013-09-23 Thread Hector Perez
Hi f3a97, did you tried to connect via VNC when the freeze situation occurs? This method works as a a workaround to defreeze my windows VM. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1180777 Tit

[Qemu-devel] [Bug 1180777] Re: RDP traffic freeze on quiet network

2013-09-23 Thread Hector Perez
Since a couple of weeks ago, we started to reboot the VM diary. With this way, the problem occurs very less. We have counted only twice in this period. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1

Re: [Qemu-devel] [RFC PATCH 3/8] qapi: move MonitorEvent define

2013-09-23 Thread Wenchao Xia
于 2013/9/23 11:55, Eric Blake 写道: On 09/12/2013 03:15 AM, Wenchao Xia wrote: Signed-off-by: Wenchao Xia --- new file mode 100644 index 000..aef71d9 --- /dev/null +++ b/include/qapi/qmp/qevent.h @@ -0,0 +1,41 @@ +#ifndef QEVENT_H No copyright notice? Fix that. Will add one in next versio

[Qemu-devel] [PATCH 0/2] Fix and add test into 059.

2013-09-23 Thread Fam Zheng
The first fixes 059 to follow latest error message change in block layer. The second adds a test for monolithiFlat vmdk. Fam Zheng (2): qemu-iotests: fix test case 059 qemu-iotests: add monolithicFlat creation test to 059 tests/qemu-iotests/059 | 5 + tests/qemu-iotests/059.out | 1

[Qemu-devel] [PATCH v2 0/2] Fix and add test into 059.

2013-09-23 Thread Fam Zheng
The first fixes 059 to follow latest error message change in block layer. The second adds a test for monolithiFlat vmdk. Fam Zheng (2): qemu-iotests: fix test case 059 qemu-iotests: add monolithicFlat creation test to 059 tests/qemu-iotests/059 | 5 + tests/qemu-iotests/059.out | 1

[Qemu-devel] [PATCH 1/2] qemu-iotests: fix test case 059

2013-09-23 Thread Fam Zheng
Since commit "block: Error parameter for open functions", error output is more verbose. Update test case output file to follow the change. Signed-off-by: Fam Zheng --- tests/qemu-iotests/059.out | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/qemu-iotests/0

[Qemu-devel] [PATCH 2/2] qemu-iotests: add monolithicFlat creation test to 059

2013-09-23 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/qemu-iotests/059 | 5 + tests/qemu-iotests/059.out | 7 +++ 2 files changed, 12 insertions(+) diff --git a/tests/qemu-iotests/059 b/tests/qemu-iotests/059 index b03429d..4bab098 100755 --- a/tests/qemu-iotests/059 +++ b/tests/qemu-iotests/059 @@ -66

Re: [Qemu-devel] [PATCH V2 2/4] qemu-nbd: support internal snapshot export

2013-09-23 Thread Wenchao Xia
于 2013/9/23 18:25, Paolo Bonzini 写道: Il 22/09/2013 11:39, Wenchao Xia ha scritto: Now it is possible to directly export an internal snapshot, which can be used to probe the snapshot's contents without qemu-img convert. Signed-off-by: Wenchao Xia --- qemu-nbd.c | 54 +

Re: [Qemu-devel] [PATCH 1/2] tests: build the helper program in main build process

2013-09-23 Thread Wenchao Xia
于 2013/9/23 7:22, Wenchao Xia 写道: On 09/23/2013 04:36 AM, Michael Tokarev wrote: 22.09.2013 12:30, Wenchao Xia пишет: This is a quick way to update helper program when qemu main code is changed or built, instead of adding new Makefile under test/qemu-iotest. Why? [] I think it is a bit o

Re: [Qemu-devel] [PATCH V3 0/7] qcow2: rollback the modification on fail in snapshot creation

2013-09-23 Thread Wenchao Xia
于 2013/9/9 10:57, Wenchao Xia 写道: > V2: > 1: all fail case will goto fail section. > 2: add the goto code. > v3: > Address Stefan's comments: > 2: don't goto fail after allocation failure. > 3: use sn->l1size correctly in qcow2_free_cluster(). > 4-7: add test case to verify the error pa

Re: [Qemu-devel] [RFC v3 0/2] use sizes.h macros for power-of-two sizes

2013-09-23 Thread Antony Pavlov
On Fri, 13 Sep 2013 11:33:24 +0400 Antony Pavlov wrote: ping > Changes since v2: > * commit messages: drop ALL 'Reviewed-by' tags. > Drop Aurelien Jarno's tag because the patchseries > was completely reworked, so it need additional review. > > Changes since v1: > > * include/sizes.h -> inc

Re: [Qemu-devel] [PATCH 04/17] blockdev: 'blockdev-add' QMP command

2013-09-23 Thread Fam Zheng
On Fri, 09/20 13:54, Kevin Wolf wrote: > For examples see the changes to qmp-commands.hx. > > Signed-off-by: Kevin Wolf > --- > blockdev.c | 57 > qapi-schema.json | 270 > +++ > qmp-commands.hx | 59 > 3 fil

Re: [Qemu-devel] [PATCH v4 1/4] seqlock: introduce read-write seqlock

2013-09-23 Thread liu ping fan
On Mon, Sep 23, 2013 at 2:21 PM, Jan Kiszka wrote: > On 2013-09-22 10:11, Liu Ping Fan wrote: >> This lets the read-side access run outside the BQL. > > In fact, not only BQL. Didn't the original commit provide a changlog > about the content of this patch? Otherwise, briefly describe use cases > a

Re: [Qemu-devel] [PATCH v4 4/4] timer: make qemu_clock_enable sync between disable and timer's cb

2013-09-23 Thread liu ping fan
On Mon, Sep 23, 2013 at 2:26 PM, Jan Kiszka wrote: > On 2013-09-22 10:11, Liu Ping Fan wrote: >> After disabling the QemuClock, we should make sure that no QemuTimers >> are still in flight. To implement that with light overhead, we resort >> to QemuEvent. The caller of disabling will wait on Qemu

Re: [Qemu-devel] [PATCH] migration: add version supporting macros for struct pointer

2013-09-23 Thread Alexey Kardashevskiy
On 09/04/2013 02:35 PM, Alexey Kardashevskiy wrote: > This adds version supporting macros VMSTATE_STRUCT_POINTER_TEST_V > and VMSTATE_STRUCT_POINTER_V in addition to the already existing > VMSTATE_STRUCT_POINTER and VMSTATE_STRUCT_POINTER_TEST macros. Ping? > > Cc: Andreas Färber > Signed-off-

[Qemu-devel] [PATCH] spapr: increase temporary fdt buffer size

2013-09-23 Thread Alexey Kardashevskiy
At the moment the size of the buffer is set to 64K which is enough for approximately 150 VCPUs which is not the limit. This increases the buffer up to 256K which allows having a tree for approximately 600 VCPUs which is way beyond the real number we need. As only the real size of the tree is copi

Re: [Qemu-devel] [PATCH v2 0/7] smbios cleanup & nicer defaults for type 1

2013-09-23 Thread Michael S. Tsirkin
On Wed, Sep 18, 2013 at 01:42:28PM +0200, Markus Armbruster wrote: > [Note cc: Andreas] > > "Michael S. Tsirkin" writes: > > > On Fri, Aug 16, 2013 at 03:18:27PM +0200, arm...@redhat.com wrote: > >> From: Markus Armbruster > >> > >> This gets rid of one of the last get_param_value() users, mak

Re: [Qemu-devel] [PATCH v4 2/4] timer: protect timers_state's clock with seqlock

2013-09-23 Thread liu ping fan
On Mon, Sep 23, 2013 at 2:21 PM, Jan Kiszka wrote: > On 2013-09-22 10:11, Liu Ping Fan wrote: >> QEMU_CLOCK_VIRTUAL may be read outside BQL. This will make its >> foundation, i.e. timers_state exposed to race condition. >> Using private lock to protect it. >> >> After this patch, reading QEMU_CLOC

<    1   2