On 09/23/2013 05:52 AM, Benoît Canet wrote: > Some drivers will have driver specifics options but no filename. > This new bool allow the block layer to treat them correctly. > > The .bdrv_needs_filename is set in drivers not having .bdrv_parse_filename and > not having .bdrv_open. > > The first exception to this rule will be the quorum driver. > > Signed-off-by: Benoit Canet <ben...@irqsave.net> > ---
> +++ b/include/block/block_int.h
> @@ -73,6 +73,7 @@ struct BlockDriver {
> /* Any driver implementing this callback is expected to be able to handle
> * NULL file names in its .bdrv_open() implementation */
> void (*bdrv_parse_filename)(const char *filename, QDict *options, Error
> **errp);
> + bool bdrv_needs_filename;
Please use inline comments documenting this field's use.
>
> /* For handling image reopen for split or non-split files */
> int (*bdrv_reopen_prepare)(BDRVReopenState *reopen_state,
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
