-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Il 13/09/2013 00:48, NeilBrown ha scritto:
>> I'm not sure why O_EXCL would be correct on generic block
>> devices when it's wrong on CD-ROMs. I think it's in fact more
>> likely that other devices are shared, as backing files.
>
> O_EXCL make sense i
On 06.09.2013 17:39, Stefan Hajnoczi wrote:
From: Paolo Bonzini
If the sectors are unallocated and we are past the end of the
backing file, they will read as zero.
Signed-off-by: Paolo Bonzini
Signed-off-by: Stefan Hajnoczi
---
block.c | 12 ++--
1 file changed, 10 insertions(+),
The header file sizes.h is used in linux kernel,
barebox bootloader and u-boot bootloader. It provides
the short and easy-to-read names for power-of-two
numbers. The numbers like this are othen used
for memory range sizes.
Signed-off-by: Antony Pavlov
---
include/qemu/sizes.h | 61 ++
Changes since v2:
* commit messages: drop ALL 'Reviewed-by' tags.
Drop Aurelien Jarno's tag because the patchseries
was completely reworked, so it need additional review.
Changes since v1:
* include/sizes.h -> include/qemu/sizes.h
* fix copyright header;
* fix formatting: drop tabs;
* use
Dear all,
I am using CIL [1] to compile QEMU. CIL is a wrapper around gcc which can be
used to analyse C code. As explained recently on this list, the ultimate goal is
to check coroutine_fn annotations statically [2]. When CIL compiles C code, it
performs a number of simplifications, which are sup
Signed-off-by: Antony Pavlov
---
hw/mips/mips_malta.c | 25 +
include/hw/mips/bios.h | 3 ++-
2 files changed, 15 insertions(+), 13 deletions(-)
diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c
index 05c8771..604832f 100644
--- a/hw/mips/mips_malta.c
+++ b/hw/m
On 06.09.2013 17:39, Stefan Hajnoczi wrote:
From: Paolo Bonzini
Reviewed-by: Eric Blake
Signed-off-by: Paolo Bonzini
Signed-off-by: Stefan Hajnoczi
---
block.c | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/block.c b/block.c
index 3c39769..a325efc 100
On 06.09.2013 17:39, Stefan Hajnoczi wrote:
From: Paolo Bonzini
Define the return value of get_block_status. Bits 0, 1, 2 and 9-62
are valid; bit 63 (the sign bit) is reserved for errors. Bits 3-8
are left for future extensions.
The return code is compatible with the old is_allocated API: if
Il 13/09/2013 09:33, Peter Lieven ha scritto:
> On 06.09.2013 17:39, Stefan Hajnoczi wrote:
>> From: Paolo Bonzini
>>
>> If the sectors are unallocated and we are past the end of the
>> backing file, they will read as zero.
>>
>> Signed-off-by: Paolo Bonzini
>> Signed-off-by: Stefan Hajnoczi
>>
Il 13/09/2013 10:04, Peter Lieven ha scritto:
> On 06.09.2013 17:39, Stefan Hajnoczi wrote:
>> From: Paolo Bonzini
>>
>> Define the return value of get_block_status. Bits 0, 1, 2 and 9-62
>> are valid; bit 63 (the sign bit) is reserved for errors. Bits 3-8
>> are left for future extensions.
>>
>
Test 038 uses asynchronous I/O, resulting (potentially) in a different
output for every run (regarding the order of the I/O accesses). This can
be fixed by simply sorting the I/O access messages, since their order is
irrelevant anyway (for this asynchonous I/O).
Signed-off-by: Max Reitz
---
test
This series implements feature of shared object building as described in:
http://wiki.qemu.org/Features/Modules
The main idea behind modules is to isolate dependencies on third party
libraries from qemu executables, such as libglusterfs or librbd, so that the
end users can install core qemu packa
From: Peter Maydell
Delete an unnecessary dependency for cocoa.o; we already have
a general rule that tells Make that we can build a .o file
from a .m source using an ObjC compiler, so this specific
rule is unnecessary. Further, it is using the dubious construct
"$(SRC_PATH)/$(obj)" to get at the
Adds extract-libs in LINK to expand any "per object libs", the syntax to define
such a libs options is like:
foo.o-libs := $(CURL_LIBS)
in block/Makefile.objs.
Similarly,
foo.o-cflags := $(FOO_CFLAGS)
is also supported.
"foo.o" must be listed a nested var (e.g. common-obj-y) t
Makefile.target includes rule.mak and unnested common-obj-y, then prefix
them with '../', this will ignore object specific QEMU_CFLAGS in subdir
Makefile.objs:
$(obj)/curl.o: QEMU_CFLAGS += $(CURL_CFLAGS)
Because $(obj) here is './block', instead of '../block'. This doesn't
hurt compiling bec
Install all the subdirs for modules under configure option "moddir".
Signed-off-by: Fam Zheng
---
Makefile | 6 ++
1 file changed, 6 insertions(+)
diff --git a/Makefile b/Makefile
index ef76967..044f4ce 100644
--- a/Makefile
+++ b/Makefile
@@ -360,6 +360,12 @@ install-datadir install-locals
Add necessary rules and flags for shared object generation.
$(common-obj-m) will include $(block-obj-m), like $(common-obj-y) does
for $(block-obj-y). The new rules introduced here are:
0) For all %.so compiling:
QEMU_CFLAGS += -fPIC
1) %.o in $(common-obj-m) is compiled to %.o, then linked
Added three types of modules:
typedef enum {
MODULE_LOAD_BLOCK = 0,
MODULE_LOAD_UI,
MODULE_LOAD_NET,
MODULE_LOAD_MAX,
} module_load_type;
and their loading function:
void module_load(module_load_type).
which loads all ".so" files in a subdir under con
Accept configure option "--enable-modules=L", to restrict qemu to only
load whitelisted modules.
Signed-off-by: Fam Zheng
---
configure | 12 +++-
rules.mak | 7 ++-
scripts/create_config | 7 +++
util/module.c | 16
4 files chan
Signed-off-by: Fam Zheng
---
.gitignore | 3 +++
1 file changed, 3 insertions(+)
diff --git a/.gitignore b/.gitignore
index d2c5c2f..4d0ac09 100644
--- a/.gitignore
+++ b/.gitignore
@@ -63,6 +63,9 @@ fsdev/virtfs-proxy-helper.pod
*.cp
*.dvi
*.exe
+*.dll
+*.so
+*.mo
*.fn
*.ky
*.log
--
1.8.
The converted block drivers are:
curl
iscsi
rbd
ssh
glusterfs
no longer adds flags and libs for them to global variables, instead
create config-host.mak variables like FOO_CFLAGS and FOO_LIBS, which is
used as per object cflags and libs.
Signed-off-by: Fam Zheng
---
block/M
From: Markus Armbruster
Event qxl_render_blit_guest_primary_initialized is unused since commit
c58c7b9, drop it.
Commit 42e5b4c moved hw/ppc/xics.c to hw/intc/xics.c without updating
the comment in trace-events.
"scripts/cleanup-trace-events.pl trace-events | diff trace-events" is
now clean aga
On 13.09.2013 10:26, Paolo Bonzini wrote:
Il 13/09/2013 10:04, Peter Lieven ha scritto:
On 06.09.2013 17:39, Stefan Hajnoczi wrote:
From: Paolo Bonzini
Define the return value of get_block_status. Bits 0, 1, 2 and 9-62
are valid; bit 63 (the sign bit) is reserved for errors. Bits 3-8
are le
On Fri, Sep 13, 2013 at 04:38:51PM +0800, Fam Zheng wrote:
> Accept configure option "--enable-modules=L", to restrict qemu to only
> load whitelisted modules.
>
> Signed-off-by: Fam Zheng
> ---
> configure | 12 +++-
> rules.mak | 7 ++-
> scripts/create_con
On 13.09.2013 10:00, Peter Lieven wrote:
On 06.09.2013 17:39, Stefan Hajnoczi wrote:
From: Paolo Bonzini
Reviewed-by: Eric Blake
Signed-off-by: Paolo Bonzini
Signed-off-by: Stefan Hajnoczi
---
block.c | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/bl
Il 13/09/2013 11:08, Peter Lieven ha scritto:
> On 13.09.2013 10:00, Peter Lieven wrote:
>> On 06.09.2013 17:39, Stefan Hajnoczi wrote:
>>> From: Paolo Bonzini
>>>
>>> Reviewed-by: Eric Blake
>>> Signed-off-by: Paolo Bonzini
>>> Signed-off-by: Stefan Hajnoczi
>>> ---
>>> block.c | 16
On 13.09.2013 11:10, Paolo Bonzini wrote:
Il 13/09/2013 11:08, Peter Lieven ha scritto:
On 13.09.2013 10:00, Peter Lieven wrote:
On 06.09.2013 17:39, Stefan Hajnoczi wrote:
From: Paolo Bonzini
Reviewed-by: Eric Blake
Signed-off-by: Paolo Bonzini
Signed-off-by: Stefan Hajnoczi
---
block
Il 13/09/2013 11:14, Peter Lieven ha scritto:
> On 13.09.2013 11:10, Paolo Bonzini wrote:
>> Il 13/09/2013 11:08, Peter Lieven ha scritto:
>>> On 13.09.2013 10:00, Peter Lieven wrote:
On 06.09.2013 17:39, Stefan Hajnoczi wrote:
> From: Paolo Bonzini
>
> Reviewed-by: Eric Blake
>>
On 13.09.2013 11:17, Paolo Bonzini wrote:
Il 13/09/2013 11:14, Peter Lieven ha scritto:
On 13.09.2013 11:10, Paolo Bonzini wrote:
Il 13/09/2013 11:08, Peter Lieven ha scritto:
On 13.09.2013 10:00, Peter Lieven wrote:
On 06.09.2013 17:39, Stefan Hajnoczi wrote:
From: Paolo Bonzini
Reviewed-
[Will suggested I add arm-linux-kernel to this discussion
since it's moved into what the right fix is for "mach-virt
doesn't initialize clocks from the device tree".]
On 12 September 2013 17:29, Christoffer Dall
wrote:
> On Thu, Sep 12, 2013 at 11:17:50AM +0100, Peter Maydell wrote:
>> This [QEMU
On 13 Sep 2013, at 09:38, Fam Zheng wrote:
> Added three types of modules:
>
>typedef enum {
>MODULE_LOAD_BLOCK = 0,
>MODULE_LOAD_UI,
>MODULE_LOAD_NET,
>MODULE_LOAD_MAX,
>} module_load_type;
>
> and their loading function:
What is the advantage of this e
Am 12.09.2013 um 17:24 hat Max Reitz geschrieben:
> On 2013-09-12 16:57, Eric Blake wrote:
> >Also, is there a way to tune the set of checks used at runtime, or are
> >we stuck with the compiled-in default? That is, can a user opt in to
> >more expensive tests for robustness, or opt out of default
On Fri, 09/13 10:03, Daniel P. Berrange wrote:
> On Fri, Sep 13, 2013 at 04:38:51PM +0800, Fam Zheng wrote:
> > Accept configure option "--enable-modules=L", to restrict qemu to only
> > load whitelisted modules.
> >
> > Signed-off-by: Fam Zheng
> > ---
> > configure | 12 +++
This series implements feature of shared object building as described in:
http://wiki.qemu.org/Features/Modules
The main idea behind modules is to isolate dependencies on third party
libraries from qemu executables, such as libglusterfs or librbd, so that the
end users can install core qemu packa
From: Peter Maydell
Delete an unnecessary dependency for cocoa.o; we already have
a general rule that tells Make that we can build a .o file
from a .m source using an ObjC compiler, so this specific
rule is unnecessary. Further, it is using the dubious construct
"$(SRC_PATH)/$(obj)" to get at the
Adds extract-libs in LINK to expand any "per object libs", the syntax to define
such a libs options is like:
foo.o-libs := $(CURL_LIBS)
in block/Makefile.objs.
Similarly,
foo.o-cflags := $(FOO_CFLAGS)
is also supported.
"foo.o" must be listed a nested var (e.g. common-obj-y) t
Makefile.target includes rule.mak and unnested common-obj-y, then prefix
them with '../', this will ignore object specific QEMU_CFLAGS in subdir
Makefile.objs:
$(obj)/curl.o: QEMU_CFLAGS += $(CURL_CFLAGS)
Because $(obj) here is './block', instead of '../block'. This doesn't
hurt compiling bec
Add necessary rules and flags for shared object generation.
$(common-obj-m) will include $(block-obj-m), like $(common-obj-y) does
for $(block-obj-y). The new rules introduced here are:
0) For all %.so compiling:
QEMU_CFLAGS += -fPIC
1) %.o in $(common-obj-m) is compiled to %.o, then linked
Il 13/09/2013 11:56, Alex Bligh ha scritto:
>
> On 13 Sep 2013, at 09:38, Fam Zheng wrote:
>
>> Added three types of modules:
>>
>>typedef enum {
>>MODULE_LOAD_BLOCK = 0,
>>MODULE_LOAD_UI,
>>MODULE_LOAD_NET,
>>MODULE_LOAD_MAX,
>>} module_load_type;
>>
>> an
Install all the subdirs for modules under configure option "moddir".
Signed-off-by: Fam Zheng
---
Makefile | 6 ++
1 file changed, 6 insertions(+)
diff --git a/Makefile b/Makefile
index 766b309..72addda 100644
--- a/Makefile
+++ b/Makefile
@@ -363,6 +363,12 @@ install-datadir install-locals
On Fri, 09/13 10:56, Alex Bligh wrote:
>
> On 13 Sep 2013, at 09:38, Fam Zheng wrote:
>
> > Added three types of modules:
> >
> >typedef enum {
> >MODULE_LOAD_BLOCK = 0,
> >MODULE_LOAD_UI,
> >MODULE_LOAD_NET,
> >MODULE_LOAD_MAX,
> >} module_load_type;
> >
Am 13.09.2013 um 10:37 hat Max Reitz geschrieben:
> Test 038 uses asynchronous I/O, resulting (potentially) in a different
> output for every run (regarding the order of the I/O accesses). This can
> be fixed by simply sorting the I/O access messages, since their order is
> irrelevant anyway (for t
On 09/11/2013 08:11 AM, Alex Williamson wrote:
> On Tue, 2013-09-10 at 18:36 +1000, Alexey Kardashevskiy wrote:
>> On 09/06/2013 05:01 AM, Alex Williamson wrote:
>>> On Fri, 2013-08-30 at 20:15 +1000, Alexey Kardashevskiy wrote:
As sPAPR platform supports DMA windows on a PCI bus, the informat
On 2013-09-13 11:57, Kevin Wolf wrote:
[…]
Am 12.09.2013 um 17:24 hat Max Reitz geschrieben:
On the other hand, we could replace QCOW2_OL_DEFAULT manually
everywhere by s->default_overlap_check; or, we change the macro to
take s as a parameter.
Either way, I see three answers to your question:
Signed-off-by: Peter Lieven
---
block.c |5 -
include/block/block.h |5 +
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/block.c b/block.c
index a325efc..878f365 100644
--- a/block.c
+++ b/block.c
@@ -51,11 +51,6 @@
#define NOT_DONE 0x7fff /* u
this patch adds the ability for targets to stay sparse during
block migration (if the zero_blocks capability is set) and qemu-img convert
even if the target does not have has_zero_init = 1.
the series was especially developed for iSCSI, but it should also work
with other drivers with little or no
Signed-off-by: Peter Lieven
---
block-migration.c |2 +-
block.c | 20 +++-
block/backup.c|3 ++-
block/qcow2.c |2 +-
block/qed.c |3 ++-
block/raw_bsd.c |5 +++--
block/vmdk.c
the BDRV_REQ_MAY_UNMAP flag is used to indicate that block driver
is allowed to optimze a write zeroes request by unmapping (discarding)
blocks if it is guaranteed that the result will read back as
zeroes.
the flag is only passed to the driver if the block device is
opened with BDRV_O_UNMAP.
Sign
this patch adds a call to completely zero out a block device.
the operation is speed up by checking the block status and
only writing zeroes to the device if they currently do not
return zeroes. optionally the zero writing can be speed up
by setting the flag BDRV_REQ_MAY_UNMAP to emulate the zero
w
Signed-off-by: Peter Lieven
---
block/iscsi.c | 78 +
1 file changed, 78 insertions(+)
diff --git a/block/iscsi.c b/block/iscsi.c
index 68f99d3..3d7961d 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -56,6 +56,7 @@ typedef struct Iscsi
Signed-off-by: Peter Lieven
---
include/block/block.h |9 +
1 file changed, 9 insertions(+)
diff --git a/include/block/block.h b/include/block/block.h
index 599de7d..ee17048 100644
--- a/include/block/block.h
+++ b/include/block/block.h
@@ -18,6 +18,15 @@ typedef struct BlockDriverIn
Signed-off-by: Peter Lieven
---
block/iscsi.c | 24
1 file changed, 24 insertions(+)
diff --git a/block/iscsi.c b/block/iscsi.c
index 3d7961d..438d45e 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -1577,6 +1577,29 @@ out:
return ret;
}
+static int iscsi_get
if the target has_zero_init = 0, but supports efficiently
writing zeroes by unmapping we call bdrv_zeroize to
avoid fully allocating the target. this currently
is designed especially for iscsi.
Signed-off-by: Peter Lieven
---
qemu-img.c | 22 --
1 file changed, 16 insertion
if a raw device like an iscsi target or host device is used
the current implementation makes a second call out to get
the block status of bs->file. however, the raw driver already
has called bdrv_get_block_status on bs->file.
Signed-off-by: Peter Lieven
---
block.c |3 ++-
1 file changed, 2
if the call is invoked through bdrv_is_allocated the caller might
expect *pnum = 0 on error. however, a new implementation of
bdrv_get_block_status might only return a negative exit value on
error while keeping *pnum untouched.
Signed-off-by: Peter Lieven
---
block.c |1 +
1 file changed, 1
Signed-off-by: Peter Lieven
---
block.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block.c b/block.c
index 4922fb9..cf9db62 100644
--- a/block.c
+++ b/block.c
@@ -3156,7 +3156,7 @@ static int64_t coroutine_fn
bdrv_co_get_block_status(BlockDriverState *bs,
if (!(r
this patch does 2 things:
a) only do additional call outs if BDRV_BLOCK_ZERO is not already set.
b) use bdi.discard_zeroes to return the zero state of an unallocated block.
the callout to bdrv_has_zero_init() is only valid right after bdrv_create.
Signed-off-by: Peter Lieven
---
block.c |
Il 13/09/2013 12:25, Peter Lieven ha scritto:
> +/* maximum number of sectors that can be discarded at once */
> +int max_discard;
> +/* maximum number of sectors that can zeroized at once */
> +int max_write_zeroes;
These should not be needed outside the driver.
If you want to ma
Il 13/09/2013 12:25, Peter Lieven ha scritto:
> if the target has_zero_init = 0, but supports efficiently
> writing zeroes by unmapping we call bdrv_zeroize to
> avoid fully allocating the target. this currently
> is designed especially for iscsi.
>
> Signed-off-by: Peter Lieven
> ---
> qemu-img
On 13 Sep 2013, at 11:02, Paolo Bonzini wrote:
>>
>> Seems like an overcomplication.
>
> At least block have to be separate, since qemu-img and friends do not
> have the symbols needed by ui, network and hardware modules.
But don't we know what the available modules are at load time? So
qemu-i
Added three types of modules:
typedef enum {
MODULE_LOAD_BLOCK = 0,
MODULE_LOAD_UI,
MODULE_LOAD_NET,
MODULE_LOAD_MAX,
} module_load_type;
and their loading function:
void module_load(module_load_type).
which loads whitelisted ".so" files in a subdir u
Signed-off-by: Fam Zheng
---
.gitignore | 3 +++
1 file changed, 3 insertions(+)
diff --git a/.gitignore b/.gitignore
index d2c5c2f..4d0ac09 100644
--- a/.gitignore
+++ b/.gitignore
@@ -63,6 +63,9 @@ fsdev/virtfs-proxy-helper.pod
*.cp
*.dvi
*.exe
+*.dll
+*.so
+*.mo
*.fn
*.ky
*.log
--
1.8.
On 13.09.2013 12:34, Paolo Bonzini wrote:
Il 13/09/2013 12:25, Peter Lieven ha scritto:
+/* maximum number of sectors that can be discarded at once */
+int max_discard;
+/* maximum number of sectors that can zeroized at once */
+int max_write_zeroes;
These should not be needed o
On 13.09.2013 12:36, Paolo Bonzini wrote:
Il 13/09/2013 12:25, Peter Lieven ha scritto:
if the target has_zero_init = 0, but supports efficiently
writing zeroes by unmapping we call bdrv_zeroize to
avoid fully allocating the target. this currently
is designed especially for iscsi.
Signed-off-by
On 13.09.2013 12:25, Peter Lieven wrote:
this patch adds a call to completely zero out a block device.
the operation is speed up by checking the block status and
only writing zeroes to the device if they currently do not
return zeroes. optionally the zero writing can be speed up
by setting the fl
Cc: Markus Armbruster
Signed-off-by: Gerd Hoffmann
---
qemu-char.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/qemu-char.c b/qemu-char.c
index f7f5464..2ca34cd 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -3271,7 +3271,12 @@ CharDriverState *qemu_chr_new_from_opts(
The converted block drivers are:
curl
iscsi
rbd
ssh
glusterfs
no longer adds flags and libs for them to global variables, instead
create config-host.mak variables like FOO_CFLAGS and FOO_LIBS, which is
used as per object cflags and libs.
Signed-off-by: Fam Zheng
---
block/M
Gerd Hoffmann writes:
> Cc: Markus Armbruster
> Signed-off-by: Gerd Hoffmann
Reviewed-by: Markus Armbruster
On 13 September 2013 10:59, Fam Zheng wrote:
> This series implements feature of shared object building as described in:
>
> http://wiki.qemu.org/Features/Modules
This doesn't seem to apply to master:
cam-vm-266:precise:qemu$ patches apply
id:1379066356-14986-1-git-send-email-f...@redhat.com
App
On 09/11/2013 08:13 AM, Alex Williamson wrote:
> On Tue, 2013-09-10 at 19:00 +1000, Alexey Kardashevskiy wrote:
>> On 09/06/2013 05:05 AM, Alex Williamson wrote:
>>> On Fri, 2013-08-30 at 20:15 +1000, Alexey Kardashevskiy wrote:
This turns the sPAPR support on and enables VFIO container use
>>
Il 13/09/2013 12:46, Peter Lieven ha scritto:
>>>
>>> -flags = BDRV_O_RDWR;
>>> +flags = BDRV_O_RDWR | BDRV_O_UNMAP;
>> I think this should be a new command-line flag.
> In an earlier version there where no objections. I think it would
> make the usage of qemu-img convert more complicated
On Fri, Sep 13, 2013 at 08:38:58AM +0100, Gabriel Kerneis wrote:
> So CIL introduces a bug in TCG which prevents >= 3.2 kernels from booting with
> the above error message, but I have absolutely no clue which files of QEMU's
> code
> might be involved.
Some more bisections later, it's somewhere i
Il 13/09/2013 12:44, Peter Lieven ha scritto:
> On 13.09.2013 12:34, Paolo Bonzini wrote:
>> Il 13/09/2013 12:25, Peter Lieven ha scritto:
>>> +/* maximum number of sectors that can be discarded at once */
>>> +int max_discard;
>>> +/* maximum number of sectors that can zeroized at once
From: Max Reitz
Implement bdrv_amend_options for compat, size, backing_file, backing_fmt
and lazy_refcounts.
Downgrading images from compat=1.1 to compat=0.10 is achieved through
handling all incompatible flags accordingly, clearing all compatible and
autoclear flags and expanding all zero clust
The following changes since commit 2d1fe1873a984d1c2c89ffa3d12949cafc718551:
Merge remote-tracking branch 'pmaydell/tags/pull-target-arm-20130910' into
staging (2013-09-11 14:46:52 -0500)
are available in the git repository at:
git://repo.or.cz/qemu/kevin.git for-anthony
for you to fetch
From: Max Reitz
Add a function for emptying a cache, i.e., flushing it and marking all
elements invalid.
Signed-off-by: Max Reitz
Signed-off-by: Kevin Wolf
---
block/qcow2-cache.c | 18 ++
block/qcow2.h | 2 ++
2 files changed, 20 insertions(+)
diff --git a/block/qcow2
From: Tal Kain
It is a valid case that the read data's size is smaller than the
requested size since there could be files that are smaller than
the minimum block size (For ex. when a VMDK disk descriptor file)
Signed-off-by: Tal Kain
Signed-off-by: Kevin Wolf
---
block/raw-win32.c | 1 +
1 fi
From: Max Reitz
This patch adds the "amend" option to qemu-img which allows changing
image options on existing image files. It also adds the generic bdrv
implementation which is basically just a wrapper for the image format
specific function.
Signed-off-by: Max Reitz
Signed-off-by: Kevin Wolf
The function will be used internally instead of only being called for
guest discard requests.
Signed-off-by: Kevin Wolf
Reviewed-by: Max Reitz
---
block/qcow2-cluster.c | 8
block/qcow2.c | 2 +-
block/qcow2.h | 2 +-
3 files changed, 6 insertions(+), 6 deletions(-)
di
From: Max Reitz
Add one test case for zero cluster expansion on qcow2 version downgrade
in shared L2 tables (i.e., L2 tables with a refcount > 1) and one for
zero expansion on backed clusters in shared L2 tables.
Signed-off-by: Max Reitz
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/061
From: Wenchao Xia
This interface use id and name as optional parameters, to handle the
case that one image contain multiple snapshots with same name which
may be '', but with different id.
Adding parameter id is for historical compatiability reason, and
that case is not possible in qemu's new in
From: Max Reitz
Save the image refcount order in BDRVQcowState. This will be relevant
for future code supporting different refcount orders than four and also
for code that needs to verify a certain refcount order for an opened
image.
Signed-off-by: Max Reitz
Signed-off-by: Kevin Wolf
---
bloc
From: Wenchao Xia
To make it clear about id and name in searching, add this API
to distinguish them. Caller can choose to search by id or name,
*errp will be set only for exception.
Some code are modified based on Pavel's patch.
Signed-off-by: Wenchao Xia
Signed-off-by: Pavel Hrdina
Reviewed-
From: Wenchao Xia
This patch make use of the compiled scm helper program to transfer
fd via unix socket at runtime.
Signed-off-by: Wenchao Xia
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Kevin Wolf
---
QMP/qmp.py| 6 ++
tests/qemu-iotests/check | 1 +
tests/qem
From: Wenchao Xia
Snapshot ID can't be specified in this interface.
Signed-off-by: Wenchao Xia
Signed-off-by: Kevin Wolf
---
blockdev.c | 13 +
qapi-schema.json | 20
qmp-commands.hx | 29 +
3 files changed, 62 insertions(+)
From: Max Reitz
Add tests for qemu-img amend on qcow2 image files.
Signed-off-by: Max Reitz
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/061 | 178 +++
tests/qemu-iotests/061.out | 349 +
tests/qemu-iotests/group | 1
From: Wenchao Xia
This program can do a sendmsg call to transfer fd with unix
socket, which is not supported in python2.
The built binary will not be deleted in clean, but it is a
existing issue in ./tests, which should be solved in another
patch.
Signed-off-by: Wenchao Xia
Reviewed-by: Stefan
From: Wenchao Xia
This case will test whether the monitor can receive fd at runtime.
To verify better, additional monitor is created to see if qemu
can handler two monitor instances correctly.
Signed-off-by: Wenchao Xia
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Kevin Wolf
---
tests/qemu-io
From: Max Reitz
Add an Error ** parameter to BlockDriver.bdrv_open and
BlockDriver.bdrv_file_open to allow more specific error messages.
Signed-off-by: Max Reitz
---
block.c | 4 ++--
block/blkdebug.c | 3 ++-
block/blkverify.c | 3 ++-
block/bochs.c
From: Max Reitz
Add an Error ** parameter to BlockDriver.bdrv_create to allow more
specific error messages.
Signed-off-by: Max Reitz
---
block.c | 2 +-
block/cow.c | 3 ++-
block/gluster.c | 2 +-
block/iscsi.c | 3 ++-
block/qcow.c
From: Wenchao Xia
Snapshot creation actually already distinguish id and name since it take
a structured parameter *sn, but delete can't. Later an accurate delete
is needed in qmp_transaction abort and blockdev-snapshot-delete-sync,
so change its prototype. Also *errp is added to tip error, but re
On Mon, 2013-07-15 at 11:11 +0200, Fabio Fantoni wrote:
Stefano or Anthony -- your input as qemu-xen types would be appreciated
here on this patch.
> > +case 2:
> > +flexarray_vappend(dm_args,
> > "-device","ich9-usb-ehci1,id=usb,"
> > +"bus=pci.0,
From: Stefan Hajnoczi
The 'gthread' coroutine backend was written before the freelist (aka
pool) existed in qemu-coroutine.c.
This means that every thread is expected to exit when its coroutine
terminates. It is not possible to reuse threads from a pool.
This patch automatically disables the p
From: Max Reitz
bdrv_img_create generally does not emit the target filename, although
this is pretty important information. Therefore, prepend its error
message with the output filename (if an error occurs).
Signed-off-by: Max Reitz
---
qemu-img.c | 2 +-
1 file changed, 1 insertion(+), 1 dele
From: Wenchao Xia
Unlike savevm, the qmp_transaction interface will not generate
snapshot name automatically, saving trouble to return information
of the new created snapshot.
Although qcow2 support storing multiple snapshots with same name
but different ID, here it will fail when an snapshot wi
From: Wenchao Xia
Signed-off-by: Wenchao Xia
Signed-off-by: Kevin Wolf
---
hmp-commands.hx | 19 +--
hmp.c | 10 ++
hmp.h | 1 +
3 files changed, 28 insertions(+), 2 deletions(-)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index 65b7f60..f19a914
From: Max Reitz
In qmp_transaction, assert that the BdrvActionOps to be used is actually
valid.
This assertion failing is very improbable, however, it might happen, if
a new TransactionActionKind is introduced "out of order" and the
actions[] array is not updated.
Signed-off-by: Max Reitz
Revi
From: Max Reitz
Add an Error ** parameter to bdrv_open, bdrv_file_open and associated
functions to allow more specific error messages.
Signed-off-by: Max Reitz
---
block.c | 100 --
block/blkdebug.c | 4 +-
block/blkverify.c
From: Wenchao Xia
Create in transaction and deletion in single command will be tested.
Signed-off-by: Wenchao Xia
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/057 | 259 +
tests/qemu-iotests/057.out | 5 +
tests/qemu-iotests/group | 1
From: Max Reitz
Add an Error ** parameter to bdrv_create and its associated functions to
allow more specific error messages.
Signed-off-by: Max Reitz
---
block.c | 80 +++
block/cow.c | 4 ++-
block/qcow.c | 4 +
1 - 100 of 213 matches
Mail list logo
