Re: [Qemu-devel] [PATCH 2/9] char: introduce tcp_chr_detach()

Hi, > +static void tcp_chr_detach(CharDriverState *chr) > +{ > +TCPCharDriver *s = chr->opaque; > + > +if (s->tag) { > +io_remove_watch_poll(s->tag); > +s->tag = 0; > +} > +} Lots of simliar functions in the other patches. Doesn't it make sense to move the tag field

Re: [Qemu-devel] [PATCH v2] pseries: Update SLOF firmware image

On 08/27/2013 06:33 PM, Alexander Graf wrote: > > On 27.08.2013, at 05:42, Alexey Kardashevskiy wrote: > >> This has reworked USB OHCI and adds support of USB EHCI, >> VIRTIO-SCSI and various fixes (IBM VSCSI, VGA and more). >> >> The full list of fixes is: >> * usb-ohci: Convert td-phys every t

Re: [Qemu-devel] [libvirt] [PATCH v2] kvm: warn if num cpus is greater than num recommended

- Original Message - > On 08/23/2013 07:24 AM, Andrew Jones wrote: > > The comment in kvm_max_vcpus() states that it's using the recommended > > procedure from the kernel API documentation to get the max number > > of vcpus that kvm supports. It is, but by always returning the > > maximum

Re: [Qemu-devel] Boot Problems Windows XP guest

On Tue, Aug 27, 2013 at 11:31:28PM +0200, Paolo Bonzini wrote: > Il 27/08/2013 22:26, Erik Rull ha scritto: > > It's more a guess, there must be a > > change between 1.2.0 and 1.6.0 that prevents a simple Windows XP from > > booting completely, if the guest HDD image is placed on a SSD. On a > > ro

Re: [Qemu-devel] [PATCH] block: Remove redundant assertion

Am 27.08.2013 um 18:07 hat Stefan Weil geschrieben: > Am 27.08.2013 17:56, schrieb Kevin Wolf: > > The failing condition is checked immediately before the assertion, so > > keeping the assertion is kind of redundant. > > Are you sure that it is not the check which is redundant? > Is file == NULL a

Re: [Qemu-devel] questions about the bdrv_co_do_readv()

On Tue, Aug 27, 2013 at 05:55:26PM -0500, Yaodong Yang wrote: > Step 3: > file block.c > function： > static BlockDriverAIOCB *bdrv_co_aio_rw_vector(BlockDriverState *bs, >int64_t sector_num, >QEMUIOVecto

[Qemu-devel] Fwd: trigger a gpio interrupt inside qemu

-- Forwarded message -- From: she roy Date: 2013/8/28 Subject: Re: [Qemu-devel] trigger a gpio interrupt inside qemu To: Max Filippov I tested qemu_irq_pulse(gPl061->irq); the guest did not generate an interrupt. so I changed to qemu_set_irq(gPl061->irq, 1); sleep(1); qemu_se

Re: [Qemu-devel] [PATCH 1/2] hda-codec: refactor common definitions into a header file

Bandan Das writes: > Move common defines and structs to a header file. > We will then include these twice in hda-codec.c - > a version with mixer enabled and another with not enabled. Suggest: The next commit will include it twice, once for a device with a mixer, and once for device wi

Re: [Qemu-devel] [PATCH v2 2/2] qemu-timer: make qemu_timer_mod_ns() and qemu_timer_del() thread-safe

On Tue, Aug 27, 2013 at 09:55:22AM +0100, Alex Bligh wrote: > On 27 Aug 2013, at 09:23, Stefan Hajnoczi wrote: > > diff --git a/include/qemu/timer.h b/include/qemu/timer.h > > index e4934dd..b58903b 100644 > > --- a/include/qemu/timer.h > > +++ b/include/qemu/timer.h > > @@ -115,6 +115,10 @@ static

Re: [Qemu-devel] Boot Problems Windows XP guest

> On August 27, 2013 at 11:37 PM Anthony Liguori wrote: > > > On Aug 27, 2013 4:32 PM, "Paolo Bonzini" wrote: > > > > Il 27/08/2013 22:26, Erik Rull ha scritto: > > > Hi Stefan, > > > > > > which BIOS is selected by default? > > > > QEMU only ships with SeaBIOS. > > > > > It's more a guess, there

Re: [Qemu-devel] Would virtio support 64 bit address for vring virtqueue?

On Wed, Aug 28, 2013 at 03:18:39AM +, Xie, Huawei wrote: > I am developing virtio user space poll mode network driver. We allocate vring > physical memory from huge page. On VMs with less than 4GB memory, it works > well. But on VMs with like 8GB memory, huge page are all allocated from hig

[Qemu-devel] [PATCH 2/3] qcow2: Implement bdrv_amend_options

Implement bdrv_amend_options for compat, size, backing_file, backing_fmt and lazy_refcounts. Downgrading images from compat=1.1 to compat=0.10 is achieved through handling all incompatible flags accordingly, clearing all compatible and autoclear flags and expanding all zero clusters. Signed-off-b

[Qemu-devel] [PATCH 0/3] block/qcow2: Image file option amendment

This series adds support to qemu-img, block and qcow2 for amending image options on existing image files. Max Reitz (3): block: Image file option amendment qcow2: Implement bdrv_amend_options qemu-iotest: qcow2 image option amendment block.c| 8 ++ block/qcow2-cluster

[Qemu-devel] [PATCH 3/3] qemu-iotest: qcow2 image option amendment

Add tests for qemu-img amend on qcow2 image files. Signed-off-by: Max Reitz --- This test is numbered 061 for not interfering with my "metadata overlap checks" series (although I will have to adapt my code to those new checks anyway when/if they are included in master). --- tests/qemu-iotests/06

Re: [Qemu-devel] [PATCH 2/9] char: introduce tcp_chr_detach()

On (Wed) 28 Aug 2013 [09:09:47], Gerd Hoffmann wrote: > Hi, > > > +static void tcp_chr_detach(CharDriverState *chr) > > +{ > > +TCPCharDriver *s = chr->opaque; > > + > > +if (s->tag) { > > +io_remove_watch_poll(s->tag); > > +s->tag = 0; > > +} > > +} > > Lots of siml

Re: [Qemu-devel] [PATCH ] qemu-help: add category headlines

On Thu, 2013-08-22 at 15:48 +0300, Marcel Apfelbaum wrote: > This patch follows Markus Armbruster suggestion: > > A possibly better way to group help by category: instead of adding > categories to each line, add category headlines, like this: > > Controller/Bridge/Hub devices: > name "NAM

[Qemu-devel] [PATCH 1/3] block: Image file option amendment

This patch adds the "amend" option to qemu-img which allows changing image options on existing image files. It also adds the generic bdrv implementation which is basically just a wrapper for the image format specific function. Signed-off-by: Max Reitz --- block.c | 8 + in

Re: [Qemu-devel] Problems with QEMU sdcard while using glib 2.33.8

On Wed, Aug 28, 2013 at 10:14:04AM +0500, Taimoor Mirza wrote: > I am building QEMU on Windows using MinGW + Msys. If I build QEMU with > Glib 2.28, qemu binary works fine for sdcard. I noticed that QEMU > binary has dependency on libgthread-2.0-0.dll in this case. > But when I build QEMU with Glib

Re: [Qemu-devel] [PATCH v4] usb/dev-hid: Modified usb-tablet category from Misc to Input

On Sun, 2013-08-25 at 13:23 +0300, Michael S. Tsirkin wrote: > On Thu, Aug 22, 2013 at 08:11:36PM +0300, Marcel Apfelbaum wrote: > > usb-tablet device was wrongly assigned to Misc category > > > > Reported-by: Markus Armbruster > > Cc: qemu-sta...@nongnu.org > > Signed-off-by: Marcel Apfelbaum >

Re: [Qemu-devel] [PATCH] target-arm: Report unimplemented opcodes (LOG_UNIMP)

On 28 August 2013 05:39, Stefan Weil wrote: > These unimplemented opcodes are handled like illegal opcodes, but > they are used in existing code. We should at least report when they > are executed. Yeah, seems reasonable. (There might be other unimplemented bits lurking too but we can add logging

Re: [Qemu-devel] Fwd: trigger a gpio interrupt inside qemu

On Wed, Aug 28, 2013 at 12:01 PM, she roy wrote: > I tested qemu_irq_pulse(gPl061->irq); the guest did not generate an > interrupt. so I changed to > > qemu_set_irq(gPl061->irq, 1); > sleep(1); > qemu_set_irq(gPl061->irq, 0); > > A lot of interrupts generated. Is it possible to generate just one

Re: [Qemu-devel] Fwd: trigger a gpio interrupt inside qemu

PL061 has a register GPIOIS to control if the interrupt is lever-triggered or edge-triggered, I will try this. Thanks. 2013/8/28 Max Filippov > On Wed, Aug 28, 2013 at 12:01 PM, she roy wrote: > > I tested qemu_irq_pulse(gPl061->irq); the guest did not generate an > > interrupt. so I changed

Re: [Qemu-devel] [PATCH] configure: detect endian via compile test

On 1 July 2013 04:30, Mike Frysinger wrote: > This avoids needing to execute a program and keeping an (incomplete) > list when cross-compiling. > > Signed-off-by: Mike Frysinger This fixes mipsel cross compiling. I also checked it detected a mips (be) compiler as big endian. Tested-by: James Ho

Re: [Qemu-devel] Fwd: trigger a gpio interrupt inside qemu

On 28 August 2013 09:01, she roy wrote: > qemu_set_irq(gPl061->irq, 1); > sleep(1); > qemu_set_irq(gPl061->irq, 0); Never call sleep() inside a qemu device implementation: this will just make the whole of QEMU (including the guest) stop running. -- PMM

Re: [Qemu-devel] [PATCH] qemu: Fix cross compilation for mipsel

On 27/08/13 19:39, Richard Henderson wrote: > On 08/27/2013 09:02 AM, James Hogan wrote: >> The configure script was setting HOST_WORDS_BIGENDIAN for all $cpu = >> mips|mips64 when cross compiling, since endianness cannot be detected by >> running a test program. This includes little endian MIPS th

Re: [Qemu-devel] Fwd: trigger a gpio interrupt inside qemu

Thanks! 2013/8/28 Peter Maydell > On 28 August 2013 09:01, she roy wrote: > > qemu_set_irq(gPl061->irq, 1); > > sleep(1); > > qemu_set_irq(gPl061->irq, 0); > > Never call sleep() inside a qemu device implementation: > this will just make the whole of QEMU (including the guest) > stop running.

Re: [Qemu-devel] Fwd: trigger a gpio interrupt inside qemu

On Wed, Aug 28, 2013 at 12:19 PM, she roy wrote: > PL061 has a register GPIOIS to control if the interrupt is lever-triggered > or edge-triggered, I will try this. Thanks. This register defines which event on the GPIO side causes PL061 to generate IRQ. The IRQ it generates is always signalled by

Re: [Qemu-devel] [PATCH] target-mips: fix get_physical_address() #if 0 build error

On 27/08/13 20:48, Richard Henderson wrote: > On 08/27/2013 09:48 AM, Yongbok Kim wrote: >> #if 0 >> -qemu_log(TARGET_FMT_lx " %d %d => " TARGET_FMT_lx " %d (%d)\n", >> +qemu_log(TARGET_FMT_lx " %d %d => %" HWADDR_PRIx " %d (%d)\n", >> address, rw, access_type, *physical, *pro

Re: [Qemu-devel] Fwd: trigger a gpio interrupt inside qemu

On Wed, Aug 28, 2013 at 12:27 PM, Max Filippov wrote: > On Wed, Aug 28, 2013 at 12:19 PM, she roy wrote: >> PL061 has a register GPIOIS to control if the interrupt is lever-triggered >> or edge-triggered, I will try this. Thanks. > > This register defines which event on the GPIO side causes PL061

Re: [Qemu-devel] [RFC] aio: add aio_context_acquire() and aio_context_release()

On Wed, Aug 28, 2013 at 11:25:33AM +0800, Wenchao Xia wrote: > > +void aio_context_release(AioContext *ctx) > > +{ > > +qemu_mutex_lock(&ctx->acquire_lock); > > +assert(ctx->owner && qemu_thread_is_self(ctx->owner)); > > +ctx->owner = NULL; > > +qemu_cond_signal(&ctx->acquire_cond);

Re: [Qemu-devel] [PATCH V18 01/25] qemu-option: add def_value_str in QemuOptDesc struct and rewrite qemu_opts_print

On 2013/8/27 21:49, Kevin Wolf wrote: Am 13.08.2013 um 06:31 hat Dong Xu Wang geschrieben: qemu_opts_print has no user now, so can re-write the function safely. qemu_opts_print is used while using "qemu-img create", it produces the same output as previous code. The behavior of this function ha

Re: [Qemu-devel] [PATCH V18 24/25] qapi: query-command-line-options outputs def_value_str

On 2013/8/28 7:13, Eric Blake wrote: On 08/27/2013 08:12 AM, Kevin Wolf wrote: Am 13.08.2013 um 06:32 hat Dong Xu Wang geschrieben: QMP command query-command-line-options shows details information of parameters, since added def_value_str, also output it in the QMP command. v16->v17: 1) add "Si

Re: [Qemu-devel] Boot Problems Windows XP guest

> On August 28, 2013 at 9:50 AM Stefan Hajnoczi wrote: > > > On Tue, Aug 27, 2013 at 11:31:28PM +0200, Paolo Bonzini wrote: > > Il 27/08/2013 22:26, Erik Rull ha scritto: > > > It's more a guess, there must be a > > > change between 1.2.0 and 1.6.0 that prevents a simple Windows XP from > > > boot

Re: [Qemu-devel] [PATCH 0/2] Make mixer emulation configurable at runtime

Bandan Das writes: > Currently, hda-codec mixer emulation can only be enabled by using the > "--enable-mixemu" option to configure at compile time. These patches add > the option to make it configurable at runtime as well. > > An example usage could be a qemu cmdline : > "-device hda-duplex,m

Re: [Qemu-devel] [PATCH] block/qcow2.h: Avoid "1LL << 63" (shifts into sign bit)

Am 23.08.2013 um 18:35 hat Peter Maydell geschrieben: > The expression "1LL << 63" tries to shift the 1 into the sign bit of a > 'long long', which provokes a clang sanitizer warning: > > runtime error: left shift of 1 by 63 places cannot be represented in type > 'long long' > > Use "1ULL << 63"

Re: [Qemu-devel] Would virtio support 64 bit address for vring virtqueue?

Hi Stefan: I think you mention the descriptor address? I mean the vring PFN register. /* A 32-bit r/w PFN for the currently selected queue */ #define VIRTIO_PCI_QUEUE_PFN8 And the linux driver sample code: iowrite32(virt_to_phys(info->queue) >> VIRTIO_PCI_QUEUE_ADDR_SHIFT,

Re: [Qemu-devel] [PULL 14/14] virtio: virtqueue_get_avail_bytes: fix desc_pa when loop over the indirect descriptor table

On Mon, Aug 26, 2013 at 07:43:41PM +0300, Michael S. Tsirkin wrote: > From: yinyin > > virtqueue_get_avail_bytes: when found a indirect desc, we need loop over it. >/* loop over the indirect descriptor table */ >indirect = 1; >max = vring_desc_len(desc_pa, i) /

[Qemu-devel] [PATCH v2] spapr: add "stop-self" RTAS call required to support hot CPU unplug

PAPR+ requires two RTAS calls to be supported by the hypervisor in order to allow hotplugging VCPUs from the guest. The "start-cpu" RTAS call was already there but "stop-self" was not. This adds the "stop-self" RTAS call. Signed-off-by: Alexey Kardashevskiy --- Changes: v2: * exit_request flag c

Re: [Qemu-devel] Fwd: trigger a gpio interrupt inside qemu

I tried to set GPIOIC in the ISR, but the result was the same, a lot of interrupts generated. I guess it is because I call >> > qemu_set_irq(gPl061->irq, 1); >> > sleep(1); >> > qemu_set_irq(gPl061->irq, 0); in a thread I created. And I don't know how to call these functions in a qemu thread. 2

Re: [Qemu-devel] [PATCH v3 0/3] vfio: fixes for better support for 128 bit memory section sizes

On 08/22/2013 09:29 PM, Alexey Kardashevskiy wrote: > I made a couple of small patches while debugging VFIO on SPAPR > which uses IOMMU MemoryRegion 2^64 bytes long. > > Changes: > v3: > * "int128: add int128_exts64()" updated > > v2: > * added int128_exts64() function as a separate patch and use

Re: [Qemu-devel] [PATCH 1/3] block: Image file option amendment

Am 28.08.2013 um 10:08 hat Max Reitz geschrieben: > This patch adds the "amend" option to qemu-img which allows changing > image options on existing image files. It also adds the generic bdrv > implementation which is basically just a wrapper for the image format > specific function. > > Signed-of

Re: [Qemu-devel] Would virtio support 64 bit address for vring virtqueue?

If this is the case, one possible fix would be: Write two continuous 32bit DWORD to combine a 64bit address Use the upper 12 bits of PFN val to indicate if it is combined write In this way, we wouldn't break other virtio driver, register layout and only need a few lines of modifica

Re: [Qemu-devel] [RFC PATCH v4] powerpc: add PVR mask support

On 08/27/2013 12:32 AM, Andreas Färber wrote: > Am 26.08.2013 15:04, schrieb Alexander Graf: >> >> On 19.08.2013, at 06:06, Alexey Kardashevskiy wrote: >> >>> IBM POWERPC processors encode PVR as a CPU family in higher 16 bits and >>> a CPU version in lower 16 bits. Since there is no significant ch

Re: [Qemu-devel] [RFC PATCH v4] powerpc: add PVR mask support

Am 28.08.2013 12:31, schrieb Alexey Kardashevskiy: > On 08/27/2013 12:32 AM, Andreas Färber wrote: >> Am 26.08.2013 15:04, schrieb Alexander Graf: >>> >>> On 19.08.2013, at 06:06, Alexey Kardashevskiy wrote: >>> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c index

[Qemu-devel] [PATCH v5] powerpc: add PVR mask support

IBM POWERPC processors encode PVR as a CPU family in higher 16 bits and a CPU version in lower 16 bits. Since there is no significant change in behavior between versions, there is no point to add every single CPU version in QEMU's CPU list. Also, new CPU versions of already supported CPU won't brea

Re: [Qemu-devel] [PATCH v2 0/2] tests: Fixes for in-tree build

On 08/20/13 13:43, arm...@redhat.com wrote: > From: Markus Armbruster > > v2: Nominate for qemu-stable (Andreas) > > Markus Armbruster (2): > tests: Fix schema parser test for in-tree build > tests: Update .gitignore for test-int128 and test-bitops > > tests/.gitignore | 3 +++ > tests/Mak

Re: [Qemu-devel] [PATCH v2 0/7] introduce BSD-licensed block driver for "raw"

On 08/21/13 12:41, Laszlo Ersek wrote: > v1->v2: > - added comment to raw_probe() [Kevin] > - fixed raw_reopen_prepare() [Paolo & Kevin] > - keeping BSDL: according to the v1 discussion, LGPLv2+ could work too, > but "but most of the block layer is BSD" [Paolo] and I haven't been > clearly inst

Re: [Qemu-devel] [PATCH v5] powerpc: add PVR mask support

Am 28.08.2013 12:37, schrieb Alexey Kardashevskiy: > IBM POWERPC processors encode PVR as a CPU family in higher 16 bits and > a CPU version in lower 16 bits. Since there is no significant change > in behavior between versions, there is no point to add every single CPU > version in QEMU's CPU list.

Re: [Qemu-devel] Fwd: trigger a gpio interrupt inside qemu

On 28 August 2013 10:33, she roy wrote: > I tried to set GPIOIC in the ISR, but the result was the same, a lot of > interrupts generated. I guess it is because I call >>> > qemu_set_irq(gPl061->irq, 1); >>> > sleep(1); >>> > qemu_set_irq(gPl061->irq, 0); > in a thread I created. And I don't know

Re: [Qemu-devel] [PATCH v5] powerpc: add PVR mask support

On 08/28/2013 08:49 PM, Andreas Färber wrote: > Am 28.08.2013 12:37, schrieb Alexey Kardashevskiy: >> IBM POWERPC processors encode PVR as a CPU family in higher 16 bits and >> a CPU version in lower 16 bits. Since there is no significant change >> in behavior between versions, there is no point to

Re: [Qemu-devel] [PATCH 08/28] mips_malta: do not use isa_mmio

On Mon, Jul 22, 2013 at 03:54:18PM +0200, Paolo Bonzini wrote: > This fixes endianness bugs in I/O port access. It looks like it actually did the reverse, ie introducing endianness bugs. With this patch, the pcnet-pci NIC (default NIC card) doesn't work any more on big endian Malta, while it still

Re: [Qemu-devel] [PATCH 2/3] qcow2: Implement bdrv_amend_options

Am 28.08.2013 um 10:08 hat Max Reitz geschrieben: > Implement bdrv_amend_options for compat, size, backing_file, backing_fmt > and lazy_refcounts. > > Downgrading images from compat=1.1 to compat=0.10 is achieved through > handling all incompatible flags accordingly, clearing all compatible and >

Re: [Qemu-devel] Boot Problems Windows XP guest

Il 27/08/2013 23:37, Anthony Liguori ha scritto: > On Aug 27, 2013 4:32 PM, "Paolo Bonzini" > wrote: >> >> Il 27/08/2013 22:26, Erik Rull ha scritto: >> > Hi Stefan, >> > >> > which BIOS is selected by default? >> >> QEMU only ships with SeaBIOS. >> >> > It's more a gue

Re: [Qemu-devel] [PATCH 0/2] Make mixer emulation configurable at runtime

Il 28/08/2013 11:13, Markus Armbruster ha scritto: > 1. Why is CONFIG_MIXEMU off by default? > >We generally default optional code to "on", to avoid bit-rot. We >make exceptions only when the optional code is truly unwanted by a >clear majority of our users. Why would anyone want hda

Re: [Qemu-devel] [PATCH v3 0/3] vfio: fixes for better support for 128 bit memory section sizes

Il 28/08/2013 11:46, Alexey Kardashevskiy ha scritto: > On 08/22/2013 09:29 PM, Alexey Kardashevskiy wrote: >> I made a couple of small patches while debugging VFIO on SPAPR >> which uses IOMMU MemoryRegion 2^64 bytes long. >> >> Changes: >> v3: >> * "int128: add int128_exts64()" updated >> >> v2:

Re: [Qemu-devel] [PATCH v4] usb/dev-hid: Modified usb-tablet category from Misc to Input

On Do, 2013-08-22 at 20:11 +0300, Marcel Apfelbaum wrote: > usb-tablet device was wrongly assigned to Misc category Added to usb patch queue. thanks, Gerd

Re: [Qemu-devel] [PATCH 08/28] mips_malta: do not use isa_mmio

On Wed, Aug 28, 2013 at 01:03:01PM +0200, Aurelien Jarno wrote: > On Mon, Jul 22, 2013 at 03:54:18PM +0200, Paolo Bonzini wrote: > > This fixes endianness bugs in I/O port access. > > It looks like it actually did the reverse, ie introducing endianness > bugs. With this patch, the pcnet-pci NIC (d

Re: [Qemu-devel] Problems with QEMU sdcard while using glib 2.33.8

Hi Stefan, Thanks for your reply. Below are answers $ grep CONFIG_COROUTINE_BACKEND config-host.mak CONFIG_COROUTINE_BACKEND=win32 (gdb) r Starting program: C:\tools\qemu\qemu-system-arm.exe -M realview-eb -m 256 -kernel DebugKD2.out -sd fat:16:rw:C:\\testCard [New Thread 3836.0x404] [New Th

Re: [Qemu-devel] [PATCH 08/28] mips_malta: do not use isa_mmio

Il 28/08/2013 13:13, Aurelien Jarno ha scritto: > On Wed, Aug 28, 2013 at 01:03:01PM +0200, Aurelien Jarno wrote: >> On Mon, Jul 22, 2013 at 03:54:18PM +0200, Paolo Bonzini wrote: >>> This fixes endianness bugs in I/O port access. >> >> It looks like it actually did the reverse, ie introducing endi

Re: [Qemu-devel] [PATCH 0/2] Make mixer emulation configurable at runtime

Hi, > Only pulse and the spice audio backends set VOICE_VOLUME_CAP. > > Impact on users isn't obvious to me. It offloads volume control to the audio backend, i.e. it will be done by pulseaudio/spice-client instead of mixemu. > Questions (not just for you, Bandan): > > 1. Why is CONFIG_MI

Re: [Qemu-devel] [PATCH 2/9] char: introduce tcp_chr_detach()

> We don't need to worry about the listening socket for this patchset, > should we then just keep that in the tcp struct, and use the tag as > the generic one in CharDriverState for all of the backends? Yes, I think that will simplify the series. And maybe name the one one in CharDriverState 'fd

Re: [Qemu-devel] [PATCH 2/3] qcow2: Implement bdrv_amend_options

Hi, Am 28.08.2013 13:06, schrieb Kevin Wolf: Am 28.08.2013 um 10:08 hat Max Reitz geschrieben: Implement bdrv_amend_options for compat, size, backing_file, backing_fmt and lazy_refcounts. Downgrading images from compat=1.1 to compat=0.10 is achieved through handling all incompatible flags acco

Re: [Qemu-devel] [PATCH 3/3] qemu-iotest: qcow2 image option amendment

Am 28.08.2013 um 10:08 hat Max Reitz geschrieben: > Add tests for qemu-img amend on qcow2 image files. > > Signed-off-by: Max Reitz > --- > This test is numbered 061 for not interfering with my "metadata overlap > checks" series (although I will have to adapt my code to those new checks > anyway

Re: [Qemu-devel] Would virtio support 64 bit address for vring virtqueue?

On 08/28/13 11:22, Xie, Huawei wrote: > Hi Stefan: > I think you mention the descriptor address? I mean the vring PFN register. > /* A 32-bit r/w PFN for the currently selected queue */ > #define VIRTIO_PCI_QUEUE_PFN 8 > > And the linux driver sample code: > iowrite32(virt_to_phys(info->q

Re: [Qemu-devel] [edk2] OVMF hung on qemu 1.6.0 with KVM

(qemu-devel CC'd) On 08/28/13 12:35, Gary Ching-Pang Lin wrote: > Hi, > > I recently updated qemu to 1.6.0 and found OVMF just showed a blank > screen when kvm was enabled. I tried to dump OVMF log with the > following commond but nothing was stored in debug.log. > > qemu-system-x86_64 -s -enabl

Re: [Qemu-devel] [PATCH 0/2] Make mixer emulation configurable at runtime

Gerd Hoffmann writes: > Hi, > >> Only pulse and the spice audio backends set VOICE_VOLUME_CAP. >> >> Impact on users isn't obvious to me. > > It offloads volume control to the audio backend, i.e. it will be done by > pulseaudio/spice-client instead of mixemu. > >> Questions (not just for y

Re: [Qemu-devel] [PATCH 3/3] qemu-iotest: qcow2 image option amendment

Am 28.08.2013 13:40, schrieb Kevin Wolf: Am 28.08.2013 um 10:08 hat Max Reitz geschrieben: Add tests for qemu-img amend on qcow2 image files. Signed-off-by: Max Reitz --- This test is numbered 061 for not interfering with my "metadata overlap checks" series (although I will have to adapt my co

Re: [Qemu-devel] [PATCH 2/3] qcow2: Implement bdrv_amend_options

Am 28.08.2013 um 13:39 hat Max Reitz geschrieben: > >>+/* clear incompatible features */ > >>+if (s->incompatible_features & QCOW2_INCOMPAT_DIRTY) { > >>+BdrvCheckResult result; > >>+ret = qcow2_check(bs, &result, BDRV_FIX_ERRORS); > >>+if (ret < 0) { > >>+

Re: [Qemu-devel] [edk2] OVMF hung on qemu 1.6.0 with KVM

Am 28.08.2013 13:45, schrieb Laszlo Ersek: > (qemu-devel CC'd) > > On 08/28/13 12:35, Gary Ching-Pang Lin wrote: >> Hi, >> >> I recently updated qemu to 1.6.0 and found OVMF just showed a blank >> screen when kvm was enabled. I tried to dump OVMF log with the >> following commond but nothing was s

Re: [Qemu-devel] [PATCH 0/2] Make mixer emulation configurable at runtime

Hi, > >> 2. Why do we bother providing these devices when CONFIG_MIXEMU off? > >> > >>Why would anyone want hda audio devices without a mixer? Why > >>wouldn't anyone who wants hda audio devices also want CONFIG_MIXEMU > >>enabled? > > > > It'll actually work just fine with HDA. T

Re: [Qemu-devel] [PATCH 3/3] qemu-iotest: qcow2 image option amendment

Am 28.08.2013 um 13:47 hat Max Reitz geschrieben: > Am 28.08.2013 13:40, schrieb Kevin Wolf: > >Am 28.08.2013 um 10:08 hat Max Reitz geschrieben: > >>Add tests for qemu-img amend on qcow2 image files. > >> > >>Signed-off-by: Max Reitz > >>--- > >>This test is numbered 061 for not interfering with

[Qemu-devel] [PATCH] pflash_cfi02.c: fix debug macro

If PFLASH_DEBUG is enabled then we have some build errors: hw/block/pflash_cfi02.c: In function ‘pflash_timer’: hw/block/pflash_cfi02.c:128:5: error: expected ‘)’ before string constant hw/block/pflash_cfi02.c:128:5: error: too few arguments to function ‘fprintf’ This patch fixes the problem. Si

Re: [Qemu-devel] [PATCH 2/3] qcow2: Implement bdrv_amend_options

Hi, Am 28.08.2013 13:48, schrieb Kevin Wolf: Am 28.08.2013 um 13:39 hat Max Reitz geschrieben: +/* clear incompatible features */ +if (s->incompatible_features & QCOW2_INCOMPAT_DIRTY) { +BdrvCheckResult result; +ret = qcow2_check(bs, &result, BDRV_FIX_ERRORS); +i

Re: [Qemu-devel] [PATCH 3/3] qemu-iotest: qcow2 image option amendment

Hi, Am 28.08.2013 13:54, schrieb Kevin Wolf: Am 28.08.2013 um 13:47 hat Max Reitz geschrieben: Am 28.08.2013 13:40, schrieb Kevin Wolf: Am 28.08.2013 um 10:08 hat Max Reitz geschrieben: Add tests for qemu-img amend on qcow2 image files. Signed-off-by: Max Reitz --- This test is numbered 061

Re: [Qemu-devel] [edk2] OVMF hung on qemu 1.6.0 with KVM

On 08/28/13 13:49, Andreas Färber wrote: > Am 28.08.2013 13:45, schrieb Laszlo Ersek: >> (qemu-devel CC'd) >> >> On 08/28/13 12:35, Gary Ching-Pang Lin wrote: >>> Hi, >>> >>> I recently updated qemu to 1.6.0 and found OVMF just showed a blank >>> screen when kvm was enabled. I tried to dump OVMF lo

Re: [Qemu-devel] [PATCH 2/3] qcow2: Implement bdrv_amend_options

Am 28.08.2013 um 14:05 hat Max Reitz geschrieben: > Hi, > > Am 28.08.2013 13:48, schrieb Kevin Wolf: > >Am 28.08.2013 um 13:39 hat Max Reitz geschrieben: > +/* clear incompatible features */ > +if (s->incompatible_features & QCOW2_INCOMPAT_DIRTY) { > +BdrvCheckResult re

[Qemu-devel] [PATCH] pcnet-pci: mark I/O and MMIO as LITTLE_ENDIAN

Now that the memory subsystem is propagating the endianness correctly, the pcnet-pci device should have its I/O ports and MMIO memory marked as LITTLE_ENDIAN, as PCI devices are little endian. This makes the pcnet-pci NIC to work again on big endian MIPS Malta (default NIC). Cc: qemu-sta...@nongn

Re: [Qemu-devel] Would virtio support 64 bit address for vring virtqueue?

On 28/08/13 13:45, Laszlo Ersek wrote: > On 08/28/13 11:22, Xie, Huawei wrote: >> Hi Stefan: >> I think you mention the descriptor address? I mean the vring PFN register. >> /* A 32-bit r/w PFN for the currently selected queue */ >> #define VIRTIO_PCI_QUEUE_PFN 8 >> >> And the linux driver

Re: [Qemu-devel] [PATCH 1/3] block: Image file option amendment

On 08/28/2013 02:08 AM, Max Reitz wrote: > This patch adds the "amend" option to qemu-img which allows changing > image options on existing image files. It also adds the generic bdrv > implementation which is basically just a wrapper for the image format > specific function. > > + > +@item amend

Re: [Qemu-devel] [PATCH 1/3] block: Image file option amendment

Am 28.08.2013 um 14:22 hat Eric Blake geschrieben: > On 08/28/2013 02:08 AM, Max Reitz wrote: > > This patch adds the "amend" option to qemu-img which allows changing > > image options on existing image files. It also adds the generic bdrv > > implementation which is basically just a wrapper for th

[Qemu-devel] [PATCH v2 1/3] char: move backends' io watch tag to CharDriverState

All the backends implement an io watcher tag for callbacks. Move it to CharDriverState from each backend's struct to make accessing the tag from backend-neutral functions easier. This will be used later to cancel a callback on chardev detach from a frontend. CC: Signed-off-by: Amit Shah --- i

[Qemu-devel] [PATCH v2 2/3] char: use common function to disable callbacks on chardev close

This deduplicates code used a lot of times. CC: Signed-off-by: Amit Shah --- qemu-char.c | 62 +++-- 1 file changed, 19 insertions(+), 43 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index cb4a311..44d993a 100644 --- a/qemu-char.c

[Qemu-devel] [PATCH v2 0/3] char: fix segfault on chardev detach

This series fixes a segfault when a frontend is detached from a chardev while the chardev had a pending callback registered. Further details in patch 3. Please review. v2: * Move tag property to CharDriverState to simplify everything (Gerd) Amit Shah (3): char: move backends' io watch tag to

[Qemu-devel] [PATCH v2 3/3] char: remove watch callback on chardev detach from frontend

If a frontend device releases the chardev (via unplug), the chr handlers are set to NULL via qdev's exit callbacks invoking qemu_chr_add_handlers(). If the chardev had a pending operation, a callback will be invoked, which will try to access data in the just-released frontend, causing a segfault.

Re: [Qemu-devel] [PATCH v2 0/3] char: fix segfault on chardev detach

On Mi, 2013-08-28 at 17:59 +0530, Amit Shah wrote: > This series fixes a segfault when a frontend is detached from a > chardev while the chardev had a pending callback registered. Further > details in patch 3. Nice. Reviewed-by: Gerd Hoffmann cheers, Gerd

Re: [Qemu-devel] [libvirt] [PATCH v2] kvm: warn if num cpus is greater than num recommended

On 08/28/2013 01:45 AM, Andrew Jones wrote: >> What I'm more worried about is what number is libvirt supposed to show >> to the end user, and should libvirt enforce the lower recommended max, >> or the larger kernel absolute max? Which of the two values does the QMP >> 'MachineInfo' type return in

[Qemu-devel] [PATCH v3 1/3] char: move backends' io watch tag to CharDriverState

All the backends implement an io watcher tag for callbacks. Move it to CharDriverState from each backend's struct to make accessing the tag from backend-neutral functions easier. This will be used later to cancel a callback on chardev detach from a frontend. CC: Signed-off-by: Amit Shah --- i

[Qemu-devel] [PATCH v3 0/3] char: fix segfault on chardev detach

This series fixes a segfault when a frontend is detached from a chardev while the chardev had a pending callback registered. Further details in patch 3. Please review. v3: * fix whitespace issues in patch 1 v2: * Move tag property to CharDriverState to simplify everything (Gerd) Amit Shah (3)

[Qemu-devel] [PATCH v3 3/3] char: remove watch callback on chardev detach from frontend

If a frontend device releases the chardev (via unplug), the chr handlers are set to NULL via qdev's exit callbacks invoking qemu_chr_add_handlers(). If the chardev had a pending operation, a callback will be invoked, which will try to access data in the just-released frontend, causing a segfault.

Re: [Qemu-devel] [PATCH v2 0/3] char: fix segfault on chardev detach

On (Wed) 28 Aug 2013 [14:33:13], Gerd Hoffmann wrote: > On Mi, 2013-08-28 at 17:59 +0530, Amit Shah wrote: > > This series fixes a segfault when a frontend is detached from a > > chardev while the chardev had a pending callback registered. Further > > details in patch 3. > > Nice. > > Reviewed-b

[Qemu-devel] [PATCH v3 2/3] char: use common function to disable callbacks on chardev close

This deduplicates code used a lot of times. CC: Signed-off-by: Amit Shah --- qemu-char.c | 62 +++-- 1 file changed, 19 insertions(+), 43 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 306d2e1..3dcf322 100644 --- a/qemu-char.c

[Qemu-devel] [PATCH v2] mips/malta: allow volatile writes to reset flash

From: James Hogan Commit a427338 (mips_malta: correct reading MIPS revision at 0x1fc00010) altered the behaviour of the monitor flash mapping at the reset address by making it read only. However this causes data bus error exceptions when it is written to since it is effectively unassigned memory

[Qemu-devel] [PATCH 00/10] usb: a bunch of bugfixes.

Hi, Result of the most recent usb debugging session. Some tracing improvements and bugfixes for xhci, uas and the usb hub. please review, Gerd Gerd Hoffmann (10): xhci: remove leftover debug printf xhci: add tracepoint for endpoint state changes xhci: add port to slot_address tracepoi

[Qemu-devel] [PATCH 03/10] xhci: add port to slot_address tracepoint

Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 2 +- trace-events | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 83161b9..4d693bc 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -2135,7 +2135,6 @@ static TRBC

[Qemu-devel] [PATCH 07/10] uas: add property for request logging

Signed-off-by: Gerd Hoffmann --- hw/usb/dev-uas.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/hw/usb/dev-uas.c b/hw/usb/dev-uas.c index 63ad12e..8701292 100644 --- a/hw/usb/dev-uas.c +++ b/hw/usb/dev-uas.c @@ -113,6 +113,9 @@ struct UASDevice { QTAILQ

[Qemu-devel] [PATCH 04/10] xhci: fix endpoint interval calculation

Cc: qemu-sta...@nongnu.org Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 4d693bc..3826979 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -1274,7 +1274,7 @@ static void x

[Qemu-devel] [PATCH 01/10] xhci: remove leftover debug printf

Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index be6b86e..57c06e7 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -1164,8 +1164,6 @@ static XHCIStreamContext *xhci_find_stream(XHCIEPContex

[Qemu-devel] [PATCH 06/10] xhci: reset port when disabling slot

Cc: qemu-sta...@nongnu.org Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 2e2eb55..10c938a 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -2123,6 +2123,7 @@ static TRBCCode xhci_disable_

[Qemu-devel] [PATCH 02/10] xhci: add tracepoint for endpoint state changes

Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 19 +++ trace-events | 1 + 2 files changed, 20 insertions(+) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 57c06e7..83161b9 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -586,6 +586,14 @@ static co

[Qemu-devel] [PATCH 05/10] xhci: emulate intr endpoint intervals correctly

Respect the interval for interrupt endpoints, so we don't finish transfers as fast as possible but at the rate configured by the guest. Fixes guest deadlocks triggered by interrupt storms. Cc: Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 44 +---

  1   2   3   >