[Qemu-devel] [PATCH 00/18] tcg: decouple tcg_target_long from pointer size

2013-08-22 Thread Richard Henderson
There are several targets for which we have 64-bit registers, even when compiling for a 32-bit address space. Of course, compiling qemu for a 64-bit address space is better, considering the large amount of virtual memory that we generally want to allocate. That said, it's not always an option. T

[Qemu-devel] [PATCH 02/18] tcg: Change flush_icache_range arguments to uintptr_t

2013-08-22 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.h | 3 +-- tcg/arm/tcg-target.h | 9 - tcg/hppa/tcg-target.h| 3 +-- tcg/i386/tcg-target.h| 3 +-- tcg/ia64/tcg-target.h| 3 +-- tcg/mips/tcg-target.h| 3 +-- tcg/s390/tcg-target.h| 3 +-- tcg/sparc

[Qemu-devel] [PATCH 04/18] tcg: Fix next_tb type in cpu_exec

2013-08-22 Thread Richard Henderson
Signed-off-by: Richard Henderson --- cpu-exec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpu-exec.c b/cpu-exec.c index 14af2ed..5a43995 100644 --- a/cpu-exec.c +++ b/cpu-exec.c @@ -209,7 +209,7 @@ int cpu_exec(CPUArchState *env) int ret, interrupt_request; Tra

[Qemu-devel] [PATCH 08/18] tcg: Change memory offsets to intptr_t

2013-08-22 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/tcg.c | 16 +--- tcg/tcg.h | 8 +++- 2 files changed, 8 insertions(+), 16 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index c23b23c..04f1727 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -380,7 +380,7 @@ TCGv_i64 tcg_global_reg_new_i64(in

[Qemu-devel] [PATCH 03/18] tcg: Change tcg_qemu_tb_exec return to uintptr_t

2013-08-22 Thread Richard Henderson
Signed-off-by: Richard Henderson --- cpu-exec.c | 2 +- tcg/ppc/tcg-target.h | 2 +- tcg/tcg.h| 3 +-- tcg/tci/tcg-target.h | 2 +- tci.c| 4 ++-- 5 files changed, 6 insertions(+), 7 deletions(-) diff --git a/cpu-exec.c b/cpu-exec.c index 301be28..14af2ed 10

[Qemu-devel] [PATCH 05/18] tcg: Define TCG_TYPE_PTR properly

2013-08-22 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/tcg.h | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tcg/tcg.h b/tcg/tcg.h index bfe420a..b71dcf4 100644 --- a/tcg/tcg.h +++ b/tcg/tcg.h @@ -173,9 +173,12 @@ typedef enum TCGType { TCG_TYPE_REG = TCG_TYPE_I64, #endif -

[Qemu-devel] [PATCH 12/18] tcg: Change tcg_out_ld/st offset to intptr_t

2013-08-22 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.c | 4 ++-- tcg/arm/tcg-target.c | 4 ++-- tcg/hppa/tcg-target.c| 4 ++-- tcg/i386/tcg-target.c| 4 ++-- tcg/ia64/tcg-target.c| 4 ++-- tcg/mips/tcg-target.c| 4 ++-- tcg/ppc/tcg-target.c | 8 tcg/ppc64/t

[Qemu-devel] [PATCH 06/18] tcg: Define TCG_ptr properly

2013-08-22 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/tcg.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tcg/tcg.h b/tcg/tcg.h index b71dcf4..8353ba1 100644 --- a/tcg/tcg.h +++ b/tcg/tcg.h @@ -640,11 +640,11 @@ do {\ void tcg_add_target_add_op_defs(const TCGTargetOpDef *tdefs);

[Qemu-devel] [PATCH 13/18] tcg: Use appropriate types in tcg_reg_alloc_call

2013-08-22 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/tcg.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index 1d7cdaf..72c064c 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -2037,7 +2037,9 @@ static int tcg_reg_alloc_call(TCGContext *s, const TCGOpDef *def, i

[Qemu-devel] [PATCH 09/18] tcg: Change relocation offsets to intptr_t

2013-08-22 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.c | 2 +- tcg/arm/tcg-target.c | 8 tcg/hppa/tcg-target.c| 6 +++--- tcg/i386/tcg-target.c| 2 +- tcg/ia64/tcg-target.c| 14 +++--- tcg/mips/tcg-target.c| 16 tcg/ppc/tcg-target.c

[Qemu-devel] [PATCH 07/18] tcg: Change frame pointer offsets to intptr_t

2013-08-22 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/tcg.c | 5 ++--- tcg/tcg.h | 9 - 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index a0d0e9e..c23b23c 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -297,8 +297,7 @@ void tcg_prologue_init(TCGContext *s) #endif

[Qemu-devel] [PATCH 10/18] tcg: Use uintptr_t in TCGHelperInfo

2013-08-22 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/tcg.c | 6 +++--- tcg/tcg.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index c6ab07f..c80aa3c 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -625,7 +625,7 @@ void tcg_register_helper(void *func, const char *name

[Qemu-devel] [PATCH 14/18] tcg: Fix jit debug for pointer size != register size

2013-08-22 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/tcg.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index 72c064c..3c89e3b 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -49,10 +49,10 @@ #include "tcg-op.h" -#if TCG_TARGET_REG_BITS == 64 -# define E

[Qemu-devel] [PATCH 17/18] tcg-i386: Adjust tcg_out_tlb_load for x32

2013-08-22 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c | 35 +-- 1 file changed, 21 insertions(+), 14 deletions(-) diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c index f3083b8..dfda76e 100644 --- a/tcg/i386/tcg-target.c +++ b/tcg/i386/tcg-target.c

[Qemu-devel] [PATCH 11/18] tcg: Change tcg_gen_exit_tb argument to uintptr_t

2013-08-22 Thread Richard Henderson
And update all users. Signed-off-by: Richard Henderson --- include/exec/gen-icount.h | 4 ++-- target-alpha/translate.c | 8 target-arm/translate.c| 2 +- target-cris/translate.c | 2 +- target-i386/translate.c | 2 +- target-lm32/translate.c | 2 +- t

[Qemu-devel] [PATCH 18/18] configure: Allow x32 as a host

2013-08-22 Thread Richard Henderson
Signed-off-by: Richard Henderson --- configure | 27 ++- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/configure b/configure index 18fa608..c0aee9d 100755 --- a/configure +++ b/configure @@ -362,7 +362,11 @@ if test ! -z "$cpu" ; then elif check_define __

[Qemu-devel] [PATCH 15/18] tcg: Allow TCG_TARGET_REG_BITS to be specified independantly

2013-08-22 Thread Richard Henderson
There are several hosts for which it would be useful to use the available 64-bit registers in a 32-bit pointer environment. Signed-off-by: Richard Henderson --- tcg/hppa/tcg-target.c | 4 tcg/hppa/tcg-target.h | 4 tcg/i386/tcg-target.h | 10 ++ tcg/sparc/tcg-target.h | 8

[Qemu-devel] [PATCH 16/18] tcg-i386: Use intptr_t appropriately

2013-08-22 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c | 38 ++ 1 file changed, 18 insertions(+), 20 deletions(-) diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c index b1e4e5b..f3083b8 100644 --- a/tcg/i386/tcg-target.c +++ b/tcg/i386/tcg-target

Re: [Qemu-devel] [PATCH 01/18] qtest: Fix FMT_timeval vs time_t

2013-08-22 Thread Andreas Färber
Am 22.08.2013 18:58, schrieb Richard Henderson: > Since FMT_timeval unconditionally uses %ld, cast tv_sec to long. > > Signed-off-by: Richard Henderson > --- > qtest.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/qtest.c b/qtest.c > index 74f1842..4f6963b 100

Re: [Qemu-devel] pvpanic plans?

2013-08-22 Thread Laszlo Ersek
On 08/22/13 18:10, Paolo Bonzini wrote: > The thread from yesterday has died off (perhaps also because of > my inappropriate answer to Michael, for which I apologize to him > and everyone). I took some time to discuss the libvirt requirements > further with Daniel Berrange and Eric Blake on IRC.

[Qemu-devel] [PATCH v4] usb/dev-hid: Modified usb-tablet category from Misc to Input

2013-08-22 Thread Marcel Apfelbaum
usb-tablet device was wrongly assigned to Misc category Reported-by: Markus Armbruster Cc: qemu-sta...@nongnu.org Signed-off-by: Marcel Apfelbaum Reviewed-by: Andreas Färber --- Changes from v3: - Added "Cc: qemu-sta...@nongnu.org" this time in the sign-off area ... Changes from v2: - Correct

Re: [Qemu-devel] [PATCH ] qemu-help: add category headlines

2013-08-22 Thread Marcel Apfelbaum
On Thu, 2013-08-22 at 09:34 -0600, Eric Blake wrote: > On 08/22/2013 08:13 AM, Markus Armbruster wrote: > > >>> +++ b/qdev-monitor.c > >>> @@ -156,6 +156,8 @@ static void > >>> qdev_print_category_devices(DeviceCategory category) > >>> DeviceClass *dc; > >>> GSList *list, *curr; > >>>

Re: [Qemu-devel] [PATCH v4] spapr-pci: fix config space access to support bridges

2013-08-22 Thread Alexander Graf
On 21.08.2013, at 07:02, Alexey Kardashevskiy wrote: > spapr-pci config space accessors use find_dev() to find a PCI device. > However find_dev() only searched on a primary bus and did not do > recursive search through secondary buses so config space access was not > possible for devices other th

[Qemu-devel] [PULL 1/1] MAINTAINERS: Take over 0.15 maintenance

2013-08-22 Thread Andreas Färber
SUSE is shipping qemu-kvm 0.15.1 with SLES 11 SP2 so we will be actively tracking all KVM-related issues. Therefore upgrade to Supported. Signed-off-by: Andreas Färber --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 70a3370..d

[Qemu-devel] [PULL 0/1] MAINTAINERS update for 0.15

2013-08-22 Thread Andreas Färber
Hello Anthony, Here's a pull for the patch that was sent to document me as 0.15 maintainer back in 2012 [1], which I had been doing until late 2012 when things started to stall upstream. Doing this as a pull preserves the patch date rather than using the resend date; cherry-pick -s would also work

Re: [Qemu-devel] [PATCH -V2 2/4] target-ppc: Use #define instead of opencoding SLB valid bit

2013-08-22 Thread Alexander Graf
On 20.08.2013, at 11:49, Aneesh Kumar K.V wrote: > From: "Aneesh Kumar K.V" Please fix your patch generation ;) > > Use SLB_ESID_V instead of (1 << 27) in the code > > Reviewed-by: Andreas Färber > Signed-off-by: Aneesh Kumar K.V Thanks, applied to ppc-next. Alex > --- > target-ppc/mmu

Re: [Qemu-devel] [PATCH ] qemu-help: add category headlines

2013-08-22 Thread Markus Armbruster
Marcel Apfelbaum writes: > On Thu, 2013-08-22 at 09:34 -0600, Eric Blake wrote: >> On 08/22/2013 08:13 AM, Markus Armbruster wrote: >> >> >>> +++ b/qdev-monitor.c >> >>> @@ -156,6 +156,8 @@ static void >> >>> qdev_print_category_devices(DeviceCategory category) >> >>> DeviceClass *dc; >> >>

Re: [Qemu-devel] pvpanic plans?

2013-08-22 Thread Laszlo Ersek
On 08/22/13 18:44, Anthony Liguori wrote: > pvpanic has been a failure. It's a poorly designed device with even > worse semantics. I disagree somewhat. Requiring a separate ioport is not ideal, I admit. Configuration over ACPI is good OTOH (it seems to put standards to good use anyway). Noone

Re: [Qemu-devel] [PATCH 01/18] qtest: Fix FMT_timeval vs time_t

2013-08-22 Thread Richard Henderson
On 08/22/2013 10:09 AM, Andreas Färber wrote: > FMT_timeval is a file-local #define, so why not change that instead of > all its users? To what? Unlike size_t, there's no time_t printf format. Recall that checking size(time_t) doesn't suppress the warning when sizeof(int) == sizeof(long)... Sin

Re: [Qemu-devel] [PATCH -V2 1/4] target-ppc: Update slb array with correct index values.

2013-08-22 Thread Andreas Färber
Am 20.08.2013 12:49, schrieb Aneesh Kumar K.V: > From: "Aneesh Kumar K.V" > > Without this, a value of rb=0 and rs=0 results in replacing the 0th > index. This can be observed when using gdb remote debugging support. > > (gdb) x/10i do_fork >0xc0085330 :Cannot access memory a

Re: [Qemu-devel] [PATCH 2/2] osdep: warn if open(O_DIRECT) on fails with EINVAL

2013-08-22 Thread Eric Blake
On 08/22/2013 03:29 AM, Stefan Hajnoczi wrote: > Print a warning when opening a file O_DIRECT fails with EINVAL. This > saves users a lot of time trying to figure out the EINVAL error, which > is typical when attempting to open a file O_DIRECT on Linux tmpfs. > > Reported-by: Deepak C Shetty > S

Re: [Qemu-devel] [PATCH 01/18] qtest: Fix FMT_timeval vs time_t

2013-08-22 Thread Andreas Färber
Am 22.08.2013 19:53, schrieb Richard Henderson: > On 08/22/2013 10:09 AM, Andreas Färber wrote: >> FMT_timeval is a file-local #define, so why not change that instead of >> all its users? > > To what? Unlike size_t, there's no time_t printf format. > > Recall that checking size(time_t) doesn't s

Re: [Qemu-devel] [PATCHv4] add qemu-img convert -C option (skip target volume creation)

2013-08-22 Thread Alex Bligh
Paolo, On 22 Aug 2013, at 13:35, Paolo Bonzini wrote: > Also, this is the same as some HMP commands' "-n" option (live > snapshots, mirroring, backup) so I suggest to use that name. You mean -n instead of -C? Sure I can do that, but is that something you feel strongly about? I am aware there are

Re: [Qemu-devel] [PATCH 01/18] qtest: Fix FMT_timeval vs time_t

2013-08-22 Thread Richard Henderson
On 08/22/2013 11:01 AM, Andreas Färber wrote: > Am 22.08.2013 19:53, schrieb Richard Henderson: >> On 08/22/2013 10:09 AM, Andreas Färber wrote: >>> FMT_timeval is a file-local #define, so why not change that instead of >>> all its users? >> >> To what? Unlike size_t, there's no time_t printf form

Re: [Qemu-devel] pvpanic plans?

2013-08-22 Thread Anthony Liguori
Laszlo Ersek writes: > On 08/22/13 18:44, Anthony Liguori wrote: > >> pvpanic has been a failure. It's a poorly designed device with even >> worse semantics. > > I disagree somewhat. > > Requiring a separate ioport is not ideal, I admit. Configuration over > ACPI is good OTOH (it seems to put st

[Qemu-devel] [RFC 0/2] Implement versatile PCI IMAP registers

2013-08-22 Thread Peter Maydell
This RFC patchset implements the versatile PCI controller's IMAP registers correctly. These registers deal with the mapping of the system address space into PCI space, ie they control what bits of RAM are written to by bus-mastering PCI devices. (At the moment we just use the system memory space as

[Qemu-devel] [RFC 1/2] hw/pci: Add PCI capability to allow BARs at 0

2013-08-22 Thread Peter Maydell
The PCI specification says that 0 isn't a valid address for an MMIO bar. However some devices won't object if you program a BAR at address 0 and will then respond to bus accesses at that address. (In particular the host PCI controller for the Versatile/Realview boards behaves like this, and Linux r

[Qemu-devel] [RFC 2/2] hw/pci-host/versatile: Implement IMAP registers

2013-08-22 Thread Peter Maydell
Rather than assuming that PCI bus master devices can DMA directly into system memory, correctly model the way the hardware does it: * the host controller has three BARs (one I/O and two memory) which can be mapped into PCI memory space in the usual way * each of these BARs is an alias of an ar

Re: [Qemu-devel] pvpanic plans?

2013-08-22 Thread Anthony Liguori
Laszlo Ersek writes: > On 08/22/13 18:10, Paolo Bonzini wrote: >> The thread from yesterday has died off (perhaps also because of >> my inappropriate answer to Michael, for which I apologize to him >> and everyone). I took some time to discuss the libvirt requirements >> further with Daniel Berr

[Qemu-devel] [PATCH] aio / timers: remove dummy_io_handler_flush from tests/test-aio.c

2013-08-22 Thread Alex Bligh
Remove dummy_io_handler_flush from tests/test-aio.c as it does nothing now. Signed-off-by: Alex Bligh --- tests/test-aio.c |9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/tests/test-aio.c b/tests/test-aio.c index 3ad2294..07a1f61 100644 --- a/tests/test-aio.c +++

Re: [Qemu-devel] pvpanic plans?

2013-08-22 Thread Paolo Bonzini
Il 22/08/2013 19:53, Laszlo Ersek ha scritto: >> > We should just introduce a simple watchdog device based on virtio and >> > call it a day. Then it's cross platform, solves the guest enumeration >> > problem, and libvirt can detect the presence of the new device. > If the guest doesn't initialize

Re: [Qemu-devel] pvpanic plans?

2013-08-22 Thread Paolo Bonzini
Il 22/08/2013 19:15, Laszlo Ersek ha scritto: >> 2) On all versions, will only work if the element is there. > > I like this, because, if on_crash doesn't work without panic_notifier > *at all*, then we can just drop panic_notifier, and make on_crash mean > (on_crash && panic_notifier) in the ori

Re: [Qemu-devel] [PATCH] kvm: shoten the parameter list for get_real_device()

2013-08-22 Thread Paolo Bonzini
Il 22/08/2013 16:39, Alex Williamson ha scritto: > On Mon, 2013-08-19 at 09:19 +0800, Wei Yang wrote: >> get_real_device() has 5 parameters with the last 4 is contained in the first >> structure. >> >> This patch removes the last 4 parameters and directly use them from the first >> parameter. >> >>

Re: [Qemu-devel] [PATCH V8 01/11] NUMA: add NumaOptions, NumaNodeOptions and NumaMemOptions

2013-08-22 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 22/08/2013 04:29, Eric Blake ha scritto: > If everything is optional, then what defaults are used if > I specify nothing? Should nodeid be mandatory (here, and > in NumaNodeOptions)? >>> >>> The defaults are all consistent with origina

Re: [Qemu-devel] [PATCHv4] add qemu-img convert -C option (skip target volume creation)

2013-08-22 Thread Alex Bligh
On 22 Aug 2013, at 12:45, Stefan Hajnoczi wrote: > Looks good but please include a new qemu-iotest test case that checks: > > 1. Error if the target volume does not exist. Can do > 2. Success if a correctly sized target volume exists. > > 3. ?? if an incorrectly sized target volume exists. G

Re: [Qemu-devel] [PATCH 2/2] osdep: warn if open(O_DIRECT) on fails with EINVAL

2013-08-22 Thread Alex Bligh
--On 22 August 2013 11:57:56 -0600 Eric Blake wrote: # define O_DIRECT 0 so that the rest of the code can just blindly use open(...,|O_DIRECT) (provided, of course, that not having O_DIRECT semantics is not fatal...). If that is done, then this #ifdef will always be true... I think this i

Re: [Qemu-devel] [PATCHv4] add qemu-img convert -C option (skip target volume creation)

2013-08-22 Thread Paolo Bonzini
Il 22/08/2013 20:03, Alex Bligh ha scritto: > Paolo, > > On 22 Aug 2013, at 13:35, Paolo Bonzini wrote: > >> Also, this is the same as some HMP commands' "-n" option (live >> snapshots, mirroring, backup) so I suggest to use that name. > > You mean -n instead of -C? Sure I can do that, but is th

Re: [Qemu-devel] pvpanic plans?

2013-08-22 Thread Laszlo Ersek
On 08/22/13 21:19, Paolo Bonzini wrote: > Il 22/08/2013 19:15, Laszlo Ersek ha scritto: >>> 2) On all versions, will only work if the element is there. >> >> I like this, because, if on_crash doesn't work without panic_notifier >> *at all*, then we can just drop panic_notifier, and make on_crash m

Re: [Qemu-devel] [PATCH 2/2] osdep: warn if open(O_DIRECT) on fails with EINVAL

2013-08-22 Thread Eric Blake
On 08/22/2013 01:31 PM, Alex Bligh wrote: > > > --On 22 August 2013 11:57:56 -0600 Eric Blake wrote: > >> # define O_DIRECT 0 >> >> so that the rest of the code can just blindly use open(...,|O_DIRECT) >> (provided, of course, that not having O_DIRECT semantics is not >> fatal...). If that is

[Qemu-devel] [PATCH] monitor: Add missing attributes to local function

2013-08-22 Thread Stefan Weil
Function expr_error gets a format string and variable arguments like printf. It also never returns. Add the necessary attributes. Signed-off-by: Stefan Weil --- monitor.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/monitor.c b/monitor.c index da9c9a2..6413d44 100644

Re: [Qemu-devel] [PATCHv4] add qemu-img convert -C option (skip target volume creation)

2013-08-22 Thread Eric Blake
On 08/22/2013 12:03 PM, Alex Bligh wrote: > Paolo, > > On 22 Aug 2013, at 13:35, Paolo Bonzini wrote: > >> Also, this is the same as some HMP commands' "-n" option (live >> snapshots, mirroring, backup) so I suggest to use that name. > > You mean -n instead of -C? Sure I can do that, but is that

Re: [Qemu-devel] pvpanic plans?

2013-08-22 Thread Christian Borntraeger
On 22/08/13 20:33, Anthony Liguori wrote: > Laszlo Ersek writes: > >> On 08/22/13 18:10, Paolo Bonzini wrote: >>> The thread from yesterday has died off (perhaps also because of >>> my inappropriate answer to Michael, for which I apologize to him >>> and everyone). I took some time to discuss th

Re: [Qemu-devel] [PATCHv4] add qemu-img convert -C option (skip target volume creation)

2013-08-22 Thread Alex Bligh
--On 22 August 2013 21:30:41 +0200 Paolo Bonzini wrote: Also, this is the same as some HMP commands' "-n" option (live snapshots, mirroring, backup) so I suggest to use that name. You mean -n instead of -C? Sure I can do that, but is that something you feel strongly about? I am aware ther

Re: [Qemu-devel] [libvirt] pvpanic plans?

2013-08-22 Thread Eric Blake
On 08/22/2013 01:41 PM, Laszlo Ersek wrote: > On 08/22/13 21:19, Paolo Bonzini wrote: >> Il 22/08/2013 19:15, Laszlo Ersek ha scritto: 2) On all versions, will only work if the element is there. >>> >>> I like this, because, if on_crash doesn't work without panic_notifier >>> *at all*, then w

Re: [Qemu-devel] [PATCH] aio / timers: remove dummy_io_handler_flush from tests/test-aio.c

2013-08-22 Thread Stefan Hajnoczi
On Thu, Aug 22, 2013 at 07:59:16PM +0100, Alex Bligh wrote: > Remove dummy_io_handler_flush from tests/test-aio.c as it does > nothing now. > > Signed-off-by: Alex Bligh > --- > tests/test-aio.c |9 ++--- > 1 file changed, 2 insertions(+), 7 deletions(-) Thanks, applied to my block tree

Re: [Qemu-devel] [PATCH 0/2] win32: build fixes due to io_flush removal

2013-08-22 Thread Stefan Hajnoczi
On Thu, Aug 22, 2013 at 03:28:34PM +0200, Stefan Hajnoczi wrote: > Stefan Weil noticed that the win32 build is broken with my io_flush changes > applied. The issues are simple build failures that should have been avoided > by > test building Windows, which I didn't. > > To make amends I've set u

Re: [Qemu-devel] pvpanic plans?

2013-08-22 Thread Anthony Liguori
Paolo Bonzini writes: > Il 22/08/2013 19:53, Laszlo Ersek ha scritto: >>> > We should just introduce a simple watchdog device based on virtio and >>> > call it a day. Then it's cross platform, solves the guest enumeration >>> > problem, and libvirt can detect the presence of the new device. >> I

[Qemu-devel] [PULL 09/42] aio / timers: Rename qemu_timer_* functions

2013-08-22 Thread Stefan Hajnoczi
From: Alex Bligh Rename four functions in preparation for new API. Rename qemu_timer_expired to timer_expired Rename qemu_timer_expire_time_ns to timer_expire_time_ns Rename qemu_timer_pending to timer_pending Rename qemu_timer_expired_ns to timer_expired_ns Signed-off-by: Alex Bligh Signed-of

[Qemu-devel] [PULL 02/42] block: Introduce bs->zero_beyond_eof

2013-08-22 Thread Stefan Hajnoczi
From: Asias He In 4146b46c42e0989cb5842e04d88ab6ccb1713a48 (block: Produce zeros when protocols reading beyond end of file), we break qemu-iotests ./check -qcow2 022. This happens because qcow2 temporarily sets ->growable = 1 for vmstate accesses (which are stored beyond the end of regular image

[Qemu-devel] [PULL 03/42] block: Produce zeros when protocols reading beyond end of file

2013-08-22 Thread Stefan Hajnoczi
From: MORITA Kazutaka While Asias is debugging an issue creating qcow2 images on top of non-file protocols. It boils down to this example using NBD: $ qemu-io -c 'open -g nbd+unix:///?socket=/tmp/nbd.sock' -c 'read -v 0 512' Notice the open -g option to set bs->growable. This means you can re

[Qemu-devel] [PULL 08/42] vmdk: support vmfs files

2013-08-22 Thread Stefan Hajnoczi
From: Paolo Bonzini VMware ESX hosts also use different create and extent types for flat files, respectively "vmfs" and "VMFS". This is not documented, but it can be found at http://kb.vmware.com/kb/10002511 (Recreating a missing virtual machine disk (VMDK) descriptor file). Signed-off-by: Paol

[Qemu-devel] [PULL 11/42] aio / timers: add qemu-timer.c utility functions

2013-08-22 Thread Stefan Hajnoczi
From: Alex Bligh Add utility functions to qemu-timer.c for nanosecond timing. Add qemu_clock_deadline_ns to calculate deadlines to nanosecond accuracy. Add utility function qemu_soonest_timeout to calculate soonest deadline. Add qemu_timeout_ns_to_ms to convert a timeout in nanoseconds back to

[Qemu-devel] [PULL 13/42] aio / timers: add ppoll support with qemu_poll_ns

2013-08-22 Thread Stefan Hajnoczi
From: Alex Bligh Add qemu_poll_ns which works like g_poll but takes a nanosecond timeout. Signed-off-by: Alex Bligh Signed-off-by: Stefan Hajnoczi --- configure| 19 +++ include/qemu/timer.h | 12 qemu-timer.c | 24 3 f

[Qemu-devel] [PULL 06/42] vmdk: fix L1 and L2 table size in vmdk3 open

2013-08-22 Thread Stefan Hajnoczi
From: Fam Zheng VMDK3 header has the field l1dir_size, but vmdk_open_vmdk3 hardcoded the value. This patch honors the header field. And the L2 table size is 4096 according to VMDK spec[1], instead of 1 << 9 (512). [1]: http://www.vmware.com/support/developer/vddk/vmdk_50_technote.pdf?src=vmdk

[Qemu-devel] [PULL 04/42] block: better error message for read only format name

2013-08-22 Thread Stefan Hajnoczi
From: Fam Zheng When user tries to use read-only whitelist format in the command line option, failure message was "'foo' invalid format". It might be invalid only for writable, but valid for read-only, so it is confusing. Give the user easier to understand information. Signed-off-by: Fam Zheng

[Qemu-devel] [PULL 16/42] aio / timers: Split QEMUClock into QEMUClock and QEMUTimerList

2013-08-22 Thread Stefan Hajnoczi
From: Alex Bligh Split QEMUClock into QEMUClock and QEMUTimerList so that we can have more than one QEMUTimerList associated with the same clock. Introduce a main_loop_timerlist concept and make existing qemu_clock_* calls that actually should operate on a QEMUTimerList call the relevant QEMUTim

[Qemu-devel] [PULL 21/42] aio / timers: aio_ctx_prepare sets timeout from AioContext timers

2013-08-22 Thread Stefan Hajnoczi
From: Alex Bligh Calculate the timeout in aio_ctx_prepare taking into account the timers attached to the AioContext. Alter aio_ctx_check similarly. Signed-off-by: Alex Bligh Signed-off-by: Stefan Hajnoczi --- async.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff -

[Qemu-devel] [PULL 10/42] aio / timers: Rename qemu_new_clock and expose clock types

2013-08-22 Thread Stefan Hajnoczi
From: Alex Bligh Rename qemu_new_clock to qemu_clock_new. Expose clock types. Signed-off-by: Alex Bligh Signed-off-by: Stefan Hajnoczi --- include/qemu/timer.h | 4 qemu-timer.c | 12 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/include/qemu/timer

[Qemu-devel] [PULL 18/42] aio / timers: Add QEMUTimerListGroup and helper functions

2013-08-22 Thread Stefan Hajnoczi
From: Alex Bligh Add QEMUTimerListGroup and helper functions, to represent a QEMUTimerList associated with each clock. Add a default QEMUTimerListGroup representing the default timer lists which are not associated with any other object (e.g. an AioContext as added by future patches). Signed-off-

[Qemu-devel] [PULL 14/42] aio / timers: Add prctl(PR_SET_TIMERSLACK, 1, ...) to reduce timer slack

2013-08-22 Thread Stefan Hajnoczi
From: Alex Bligh Where supported, called prctl(PR_SET_TIMERSLACK, 1, ...) to set one nanosecond timer slack to increase precision of timer calls. Signed-off-by: Alex Bligh Signed-off-by: Stefan Hajnoczi --- configure| 18 ++ qemu-timer.c | 7 +++ 2 files changed, 25 i

[Qemu-devel] [PULL 19/42] aio / timers: Add QEMUTimerListGroup to AioContext

2013-08-22 Thread Stefan Hajnoczi
From: Alex Bligh Add a QEMUTimerListGroup each AioContext (meaning a QEMUTimerList associated with each clock is added) and delete it when the AioContext is freed. Signed-off-by: Alex Bligh Signed-off-by: Stefan Hajnoczi --- async.c | 2 ++ include/block/aio.h | 4

[Qemu-devel] [PULL 22/42] aio / timers: Add aio_timer_init & aio_timer_new wrappers

2013-08-22 Thread Stefan Hajnoczi
From: Alex Bligh Add aio_timer_init and aio_timer_new wrapper functions. Signed-off-by: Alex Bligh Signed-off-by: Stefan Hajnoczi --- include/block/aio.h | 43 +++ 1 file changed, 43 insertions(+) diff --git a/include/block/aio.h b/include/block/aio.h

[Qemu-devel] [PULL 17/42] aio / timers: Untangle include files

2013-08-22 Thread Stefan Hajnoczi
From: Alex Bligh include/qemu/timer.h has no need to include main-loop.h and doing so causes an issue for the next patch. Unfortunately various files assume including timers.h will pull in main-loop.h. Untangle this mess. Signed-off-by: Alex Bligh Signed-off-by: Stefan Hajnoczi --- dma-helper

[Qemu-devel] [PULL 20/42] aio / timers: Add a notify callback to QEMUTimerList

2013-08-22 Thread Stefan Hajnoczi
From: Alex Bligh Add a notify pointer to QEMUTimerList so it knows what to notify on a timer change. Signed-off-by: Alex Bligh Signed-off-by: Stefan Hajnoczi --- async.c | 7 ++- include/qemu/timer.h | 27 +++ qemu-timer.c | 31 +++

[Qemu-devel] [PULL 24/42] aio / timers: Convert mainloop to use timeout

2013-08-22 Thread Stefan Hajnoczi
From: Alex Bligh Convert mainloop to use timeout from default timerlist group (i.e. the current 3 static timers) main-loop.c produces a (possibly spurious) warning about multiple iterations. Adapt the way this works for a signed timeout and make the warning a bit safer. Signed-off-by: Alex Blig

[Qemu-devel] [PULL 23/42] aio / timers: Convert aio_poll to use AioContext timers' deadline

2013-08-22 Thread Stefan Hajnoczi
From: Alex Bligh Convert aio_poll to use deadline based on AioContext's timers. aio_poll has been changed to return accurately whether progress has occurred. Prior to this commit, aio_poll always returned true if g_poll was entered, whether or not any progress was made. This required a change to

[Qemu-devel] [PULL 25/42] aio / timers: On timer modification, qemu_notify or aio_notify

2013-08-22 Thread Stefan Hajnoczi
From: Alex Bligh On qemu_mod_timer_ns, ensure qemu_notify or aio_notify is called to end the appropriate poll(), irrespective of use_icount value. On qemu_clock_enable, ensure qemu_notify or aio_notify is called for all QEMUTimerLists attached to the QEMUClock. Signed-off-by: Alex Bligh Signed

[Qemu-devel] [PULL 26/42] aio / timers: Introduce new API timer_new and friends

2013-08-22 Thread Stefan Hajnoczi
From: Alex Bligh Introduce new API for creating timers - timer_new and _ns, _ms, _us derivatives. Signed-off-by: Alex Bligh Signed-off-by: Stefan Hajnoczi --- include/qemu/timer.h | 69 1 file changed, 69 insertions(+) diff --git a/include

[Qemu-devel] [PULL 34/42] aio / timers: Convert rtc_clock to be a QEMUClockType

2013-08-22 Thread Stefan Hajnoczi
From: Alex Bligh Convert rtc_clock to be a QEMUClockType Move rtc_clock users to use the new API Signed-off-by: Alex Bligh Signed-off-by: Stefan Hajnoczi --- hw/arm/omap1.c| 4 ++-- hw/arm/pxa2xx.c | 35 +++ hw/arm/strongarm.c| 1

[Qemu-devel] [PULL 36/42] aio / timers: Add test harness for AioContext timers

2013-08-22 Thread Stefan Hajnoczi
From: Alex Bligh Add a test harness for AioContext timers. The g_source equivalent is unsatisfactory as it suffers from false wakeups. Signed-off-by: Alex Bligh Signed-off-by: Stefan Hajnoczi --- tests/test-aio.c | 134 +++ 1 file changed, 1

[Qemu-devel] [PULL 42/42] win32-aio: drop win32_aio_flush_cb()

2013-08-22 Thread Stefan Hajnoczi
The io_flush argument to qemu_aio_set_event_notifier() has been removed since the block layer learnt to drain requests by itself. Fix the Windows build for win32-aio.o by updating the qemu_aio_set_event_notifier() call and dropping win32_aio_flush_cb(). Reviewed-by: Stefan Weil Signed-off-by: St

[Qemu-devel] [PULL 35/42] aio / timers: convert block_job_sleep_ns and co_sleep_ns to new API

2013-08-22 Thread Stefan Hajnoczi
From: Alex Bligh Convert block_job_sleep_ns and co_sleep_ns to use the new timer API. Signed-off-by: Alex Bligh Signed-off-by: Stefan Hajnoczi --- block/backup.c| 4 ++-- block/commit.c| 2 +- block/mirror.c| 4 ++-- block/stream.c| 2 +- bl

[Qemu-devel] [PULL 37/42] aio / timers: Add scripts/switch-timer-api

2013-08-22 Thread Stefan Hajnoczi
From: Alex Bligh Add scripts/switch-timer-api to programatically rewrite source files to use the new timer system. Signed-off-by: Alex Bligh Signed-off-by: Stefan Hajnoczi --- scripts/switch-timer-api | 178 +++ 1 file changed, 178 insertions(+) cr

[Qemu-devel] [PULL 32/42] aio / timers: Rearrange timer.h & make legacy functions call non-legacy

2013-08-22 Thread Stefan Hajnoczi
From: Alex Bligh Rearrange timer.h so it is in order by function type. Make legacy functions call non-legacy functions rather than vice-versa. Convert cpus.c to use new API. Signed-off-by: Alex Bligh Signed-off-by: Stefan Hajnoczi --- cpus.c | 112 +- hw/acpi/piix4.c

[Qemu-devel] [PULL 41/42] aio-win32: replace incorrect AioHandler->opaque usage with ->e

2013-08-22 Thread Stefan Hajnoczi
The AioHandler->opaque field does not exist in aio-win32.c. The code that uses it was incorrectly copied from aio-posix.c. For Windows we can use AioHandler->e to match against AioContext->notifier. This patch fixes the Windows build for aio-win32.o. Reviewed-by: Stefan Weil Signed-off-by: Ste

[Qemu-devel] [PULL 40/42] aio / timers: remove dummy_io_handler_flush from tests/test-aio.c

2013-08-22 Thread Stefan Hajnoczi
From: Alex Bligh Remove dummy_io_handler_flush from tests/test-aio.c as it does nothing now. Signed-off-by: Alex Bligh Signed-off-by: Stefan Hajnoczi --- tests/test-aio.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/tests/test-aio.c b/tests/test-aio.c index 3ad

[Qemu-devel] [PULL 33/42] aio / timers: Remove main_loop_timerlist

2013-08-22 Thread Stefan Hajnoczi
From: Alex Bligh Now we have timerlistgroups implemented and main_loop_tlg, we no longer need the concept of a default timer list associated with each clock. Remove it and simplify initialisation of clocks and timer lists. Signed-off-by: Alex Bligh Signed-off-by: Stefan Hajnoczi --- include/q

Re: [Qemu-devel] [PATCH 07/18] arch_init: export RAM_SAVE_xxx flags

2013-08-22 Thread Michael R. Hines
On 08/21/2013 06:49 AM, Paolo Bonzini wrote: Il 21/08/2013 09:18, Lei Li ha scritto: Export RAM_SAVE_xxx flags for localhost migration. Signed-off-by: Lei Li --- arch_init.c | 12 include/migration/migration.h | 14 ++ 2 files changed, 14 inse

Re: [Qemu-devel] pvpanic plans?

2013-08-22 Thread Laszlo Ersek
On 08/22/13 22:09, Anthony Liguori wrote: > The difference is that ACPI or platform devices in general are > unexpected to be added. By definition it means that the motherboard has > most likely been changed. You could encounter a new ACPI artifact after simply re-flashing your MB with an update

[Qemu-devel] [PULL 01/42] qcow2: Change default for new images to compat=1.1

2013-08-22 Thread Stefan Hajnoczi
From: Kevin Wolf By the time that qemu 1.7 will be released, enough time will have passed since qemu 1.1, which is the first version to understand version 3 images, that changing the default shouldn't hurt many people any more and the benefits of using the new format outweigh the pain. qemu-iote

Re: [Qemu-devel] pvpanic plans?

2013-08-22 Thread Anthony Liguori
On Thu, Aug 22, 2013 at 3:36 PM, Laszlo Ersek wrote: > On 08/22/13 22:09, Anthony Liguori wrote: > >> The difference is that ACPI or platform devices in general are >> unexpected to be added. By definition it means that the motherboard has >> most likely been changed. > > You could encounter a ne

[Qemu-devel] [PULL 15/42] aio / timers: Make qemu_run_timers and qemu_run_all_timers return progress

2013-08-22 Thread Stefan Hajnoczi
From: Alex Bligh Make qemu_run_timers and qemu_run_all_timers return progress so that aio_poll etc. can determine whether a timer has been run. Signed-off-by: Alex Bligh Signed-off-by: Stefan Hajnoczi --- include/qemu/timer.h | 21 +++-- qemu-timer.c | 18 -

Re: [Qemu-devel] [PATCH 08/18] migration-local: introduce qemu_fopen_local()

2013-08-22 Thread Michael R. Hines
On 08/21/2013 03:18 AM, Lei Li wrote: Introduce read/write backend of QEMUFileLocal used by localhost migration. The unix domain socket will be replaced by PIPE with vmsplice mechanism. Signed-off-by: Lei Li --- Makefile.objs |1 + migration-local.c | 211 +++

[Qemu-devel] [PULL 07/42] vmdk: support vmfsSparse files

2013-08-22 Thread Stefan Hajnoczi
From: Fam Zheng VMware ESX hosts use a variant of the VMDK3 format, identified by the vmfsSparse create type ad the VMFSSPARSE extent type. It has 16 KB grain tables (L2) and a variable-size grain directory (L1). In addition, the grain size is always 512, but that is not a problem because it is

Re: [Qemu-devel] [PATCH 10/18] migration-local: implementation of outgoing part

2013-08-22 Thread Michael R. Hines
On 08/21/2013 03:18 AM, Lei Li wrote: Implementation of outgoing part for localhost migration. The integration of migration thread and corresponding adjustment will be in coming patches. Signed-off-by: Lei Li --- include/migration/migration.h |2 + migration-local.c | 85 ++

Re: [Qemu-devel] [PATCH 11/18] migration: introduce capability localhost

2013-08-22 Thread Michael R. Hines
On 08/21/2013 11:18 AM, Paolo Bonzini wrote: Il 21/08/2013 09:18, Lei Li ha scritto: } else if (strstart(uri, "unix:", &p)) { +if (s->enabled_capabilities[MIGRATION_CAPABILITY_LOCALHOST]) { +local_start_outgoing_migration(s, p, &local_err); +} unix_sta

[Qemu-devel] [PULL 29/42] aio / timers: Remove alarm timers

2013-08-22 Thread Stefan Hajnoczi
From: Alex Bligh Remove alarm timers from qemu-timers.c now we use g_poll / ppoll instead. Signed-off-by: Alex Bligh Signed-off-by: Stefan Hajnoczi --- include/qemu/timer.h | 3 - main-loop.c | 4 - qemu-timer.c | 500 +-- v

Re: [Qemu-devel] pvpanic plans?

2013-08-22 Thread Peter Maydell
On 22 August 2013 21:09, Anthony Liguori wrote: > Paolo Bonzini writes: >> Not just that. Panic notifiers are called in a substantially unknown >> environment, with locks taken or interrupts already set up. > > If you make the panic notify a config space write, then on virtio-pci, > it's an outb

[Qemu-devel] [PULL 28/42] aio / timers: Add documentation and new format calls

2013-08-22 Thread Stefan Hajnoczi
From: Alex Bligh Add documentation for existing qemu timer calls. Add new format calls of the format timer_XXX rather than qemu_XXX_timer for consistency. Signed-off-by: Alex Bligh Signed-off-by: Stefan Hajnoczi --- include/qemu/timer.h | 206 +-

[Qemu-devel] [PULL 39/42] aio / timers: Remove legacy interface

2013-08-22 Thread Stefan Hajnoczi
From: Alex Bligh Remove the legacy interface from include/qemu/timers.h. Ensure struct QEMUClock is not exposed at all. Signed-off-by: Alex Bligh Signed-off-by: Stefan Hajnoczi --- include/qemu/timer.h | 214 +-- qemu-timer.c | 35 +---

<    1   2   3   >