Re: [Qemu-devel] [PATCH RESEND] RCU implementation for Qemu. Fixup some dynamic casts in the Qemu device tree to correspond to the QOM type-checking system.

2013-08-20 Thread Markus Armbruster
Eric's advice in Message-ID: <5212712c.1080...@redhat.com> applies: Your subject line is atrociously long. Please put a blank line between the summary (ca. 60 characters or less) and the rest of your commit message. 'git shortlog -30' will give you a hint on typical summary naming.

Re: [Qemu-devel] vmdk stream-optimised format

2013-08-20 Thread Fam Zheng
On Tue, 08/20 07:51, Alex Bligh wrote: > > On 20 Aug 2013, at 02:42, Fam Zheng wrote: > > > OK, thanks for explaination. That sounds a valid use case for > > streamOptimized. However I am afraid QEMU and its users benefit not much > > from this feature anyway, because it's moving a VM away to VMw

Re: [Qemu-devel] [PATCH v2] monitor: print the invalid char in error message

2013-08-20 Thread Markus Armbruster
Fam Zheng writes: > It's more friendly to print which char is invalid to user, especially > when user tries to input a float value and expect the monitor to round > it to int. Since we don't round float number when we look for a integer, > telling which char is invalid is less confusing. > > Sign

Re: [Qemu-devel] [PATCHv11 13/31] aio / timers: aio_ctx_prepare sets timeout from AioContext timers

2013-08-20 Thread Wenchao Xia
于 2013-8-20 14:48, Alex Bligh 写道: for (bh = ctx->first_bh; bh; bh = bh->next) { if (!bh->deleted && bh->scheduled) { if (bh->idle) { /* idle bottom halves will be polled at least * every 10ms */ -*timeout = 10; +

Re: [Qemu-devel] [Bug?] qemu-1.6.0 python traceback in GEN qmp-commands.h

2013-08-20 Thread Erik Rull
> On August 19, 2013 at 6:15 PM Erik Rull wrote: > > > Luiz Capitulino wrote: > > On Fri, 16 Aug 2013 14:21:50 +0100 > > Peter Maydell wrote: > > > >> On 16 August 2013 08:59, Erik Rull wrote: > >>> Hi all, > >>> > >>> when using the released qemu-1.6.0.tar.bz2, I get the following error > >>> m

[Qemu-devel] [PATCH 1/2] tests: Fix schema parser test for in-tree build

2013-08-20 Thread armbru
From: Markus Armbruster Commit 4f193e3 added the test, but screwed up in-tree builds (SRCDIR=.): the tests's output overwrites the expected output, and is thus compared to itself. Reported-by: Laszlo Ersek Signed-off-by: Markus Armbruster --- tests/.gitignore | 1 + tests/Makefile | 8 -

[Qemu-devel] [PATCH 0/2] tests: Fixes for in-tree build

2013-08-20 Thread armbru
From: Markus Armbruster Markus Armbruster (2): tests: Fix schema parser test for in-tree build tests: Update .gitignore for test-int128 and test-bitops tests/.gitignore | 3 +++ tests/Makefile | 8 2 files changed, 7 insertions(+), 4 deletions(-) -- 1.8.1.4

[Qemu-devel] [PATCH 2/2] tests: Update .gitignore for test-int128 and test-bitops

2013-08-20 Thread armbru
From: Markus Armbruster Forgotten in commit 6046c62 and 3464700. Signed-off-by: Markus Armbruster --- tests/.gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/.gitignore b/tests/.gitignore index d9c2ef4..9ac044d 100644 --- a/tests/.gitignore +++ b/tests/.gitignore @@ -5,8 +

Re: [Qemu-devel] [PATCH 7/7] switch raw block driver from "raw.o" to "raw_bsd.o"

2013-08-20 Thread Kevin Wolf
Am 18.08.2013 um 16:29 hat Paolo Bonzini geschrieben: > Il 16/08/2013 16:15, Laszlo Ersek ha scritto: > > +static int raw_reopen_prepare(BDRVReopenState *reopen_state, > > + BlockReopenQueue *queue, Error **errp) > > { > > -return bdrv_reopen_prepare(bs->file); > >

Re: [Qemu-devel] [PATCH 4/7] raw_bsd: introduce "special members"

2013-08-20 Thread Kevin Wolf
Am 16.08.2013 um 16:15 hat Laszlo Ersek geschrieben: > On 08/05/13 15:03, Paolo Bonzini wrote: > > > > [...] > > > > 3) These members are special > > > > .format_name is the string "raw" > > .bdrv_open raw_open should set bs->sg to bs->file->sg and return 0 > > .bdrv_closeraw_

Re: [Qemu-devel] [PATCH 0/3] target-ppc: Add support for dumping guest memory using qemu gdb server

2013-08-20 Thread Aneesh Kumar K.V
Andreas Färber writes: > Hi Aneesh, > > Am 19.08.2013 14:29, schrieb Aneesh Kumar K.V: >> This patch series implement support for dumping guest memory using qemu gdb >> server. > > I had a quick look through but will leave in-depth review to Alex or > Anthony. > > Do you plan to implement dumpin

Re: [Qemu-devel] [PATCH 0/7] introduce BSD-licensed block driver for "raw"

2013-08-20 Thread Kevin Wolf
Am 16.08.2013 um 16:15 hat Laszlo Ersek geschrieben: > Paolo asked me to write such a driver based on his textual specification > alone. The first patch captures his email in full, the rest re-quotes > parts that are being implemented. > > The tree compiles at each patch. The series passes "make c

Re: [Qemu-devel] [PATCH] powerpc iommu: enable multiple TCE requests

2013-08-20 Thread Paolo Bonzini
Il 20/08/2013 03:36, Alexey Kardashevskiy ha scritto: > Hm. Here we might have a problem like this is we decide to migrate from > QEMU with this patch running on modern kernel to QEMU without this patch > running on old kernel - for this we might want to be able to disable > "multi-tce" via machine

Re: [Qemu-devel] [PATCH] powerpc iommu: enable multiple TCE requests

2013-08-20 Thread Alexey Kardashevskiy
On 08/20/2013 06:39 PM, Paolo Bonzini wrote: > Il 20/08/2013 03:36, Alexey Kardashevskiy ha scritto: >> Hm. Here we might have a problem like this is we decide to migrate from >> QEMU with this patch running on modern kernel to QEMU without this patch >> running on old kernel - for this we might wa

Re: [Qemu-devel] [PATCH v2 6/7] vl: Set current_machine early

2013-08-20 Thread Markus Armbruster
Andreas Färber writes: > Am 19.08.2013 11:35, schrieb Markus Armbruster: >> Andreas Färber writes: >> >>> Am 16.08.2013 15:18, schrieb arm...@redhat.com: From: Markus Armbruster I'd like to access QEMUMachine from a QEMUMachine init() method, which is currently not possible

Re: [Qemu-devel] [PATCH] powerpc iommu: enable multiple TCE requests

2013-08-20 Thread Paolo Bonzini
Il 20/08/2013 10:49, Alexey Kardashevskiy ha scritto: > On 08/20/2013 06:39 PM, Paolo Bonzini wrote: >> Il 20/08/2013 03:36, Alexey Kardashevskiy ha scritto: >>> Hm. Here we might have a problem like this is we decide to migrate from >>> QEMU with this patch running on modern kernel to QEMU without

Re: [Qemu-devel] [Xen-devel] [PATCH] Qemu-xen: HVM S3 bugfix

2013-08-20 Thread George Dunlap
On Mon, Aug 19, 2013 at 3:47 PM, Liu, Jinsong wrote: > Ping? I know Ian and Stefano are doing something at ARM this week -- Anthony might be able to give a review, at least... -George

Re: [Qemu-devel] [PATCH] powerpc iommu: enable multiple TCE requests

2013-08-20 Thread Benjamin Herrenschmidt
On Tue, 2013-08-20 at 11:09 +0200, Paolo Bonzini wrote: > > Sorry if I miss anything, but is not it what the patch already > does? :) > > No, you need to expose multitce unconditionally in the device tree. If I'm not mistaken the multitce kernel side patches are still not upstream so I disagree.

Re: [Qemu-devel] [PATCH] powerpc iommu: enable multiple TCE requests

2013-08-20 Thread Paolo Bonzini
Il 20/08/2013 11:13, Benjamin Herrenschmidt ha scritto: > On Tue, 2013-08-20 at 11:09 +0200, Paolo Bonzini wrote: >>> Sorry if I miss anything, but is not it what the patch already >> does? :) >> >> No, you need to expose multitce unconditionally in the device tree. > > If I'm not mistaken the mul

Re: [Qemu-devel] [PATCH] powerpc iommu: enable multiple TCE requests

2013-08-20 Thread Benjamin Herrenschmidt
On Tue, 2013-08-20 at 11:15 +0200, Paolo Bonzini wrote: > > - provide the infrastructure to enable/disable it from the command > line > (which will be enough design effort alone); ... why do things simply when we can come up with a cathedral instead ? > - add pseries-1.6 as a synonym of pseries

Re: [Qemu-devel] [PATCH] powerpc iommu: enable multiple TCE requests

2013-08-20 Thread Paolo Bonzini
Il 20/08/2013 11:20, Benjamin Herrenschmidt ha scritto: > On Tue, 2013-08-20 at 11:15 +0200, Paolo Bonzini wrote: >> >> - provide the infrastructure to enable/disable it from the command >> line >> (which will be enough design effort alone); > > ... why do things simply when we can come up with a

Re: [Qemu-devel] [PATCH] powerpc iommu: enable multiple TCE requests

2013-08-20 Thread Benjamin Herrenschmidt
On Tue, 2013-08-20 at 11:22 +0200, Paolo Bonzini wrote: > > Uhm... I thought Alex and I were the one who proposed the simple things. > You _will_ need to do the complicated stuff sooner or later, but it's > probably early enough now to ignore it. > > And I'm not saying this out of love for big c

Re: [Qemu-devel] [PATCHv11 13/31] aio / timers: aio_ctx_prepare sets timeout from AioContext timers

2013-08-20 Thread Alex Bligh
On 20 Aug 2013, at 08:19, Wenchao Xia wrote: > Thanks for the explanation. It seems *timeout is always set > to -1 before calling GSource's prepare(), so > "*timeout = qemu_soonest_timeout(*timeout, 10);" > will always get *timeout = 10, so this call can be saved. I believe that's incorrect too

Re: [Qemu-devel] [RFC] Convert AioContext to Gsource sub classes

2013-08-20 Thread Wenchao Xia
于 2013-8-16 16:12, Wenchao Xia 写道: 于 2013-8-16 15:15, Wenchao Xia 写道: 于 2013-8-16 0:32, Michael Roth 写道: Quoting Michael Roth (2013-08-15 10:23:20) Quoting Wenchao Xia (2013-08-13 03:44:39) 于 2013-8-13 1:01, Michael Roth 写道: Quoting Paolo Bonzini (2013-08-12 02:30:28) 1) rename AioContext t

Re: [Qemu-devel] [PATCH] powerpc iommu: enable multiple TCE requests

2013-08-20 Thread Paolo Bonzini
Il 20/08/2013 11:26, Benjamin Herrenschmidt ha scritto: > On Tue, 2013-08-20 at 11:22 +0200, Paolo Bonzini wrote: >> >> Uhm... I thought Alex and I were the one who proposed the simple things. >> You _will_ need to do the complicated stuff sooner or later, but it's >> probably early enough now to

Re: [Qemu-devel] minimal linux distribution for qemu

2013-08-20 Thread Rob Landley
On 08/18/2013 08:57:08 AM, Herbei Dacian wrote: good to know. I was working back in 2005-2006 with a company that had a 4MB kernel. At that time I was too inexperienced to work at that level but I thought now I could reproduce their work with some help. Anyhow for the moment I'll go for 256 MB

Re: [Qemu-devel] [PATCH v2] Fix query-migrate documentation in qmp-commands.hx

2013-08-20 Thread Orit Wasserman
On 08/19/2013 09:41 PM, Luiz Capitulino wrote: > On Mon, 12 Aug 2013 10:19:52 -0400 > Luiz Capitulino wrote: > >> On Thu, 8 Aug 2013 20:05:48 +0300 >> Orit Wasserman wrote: >> >>> "ram" is present also when migration completes. >>> expected-downtime, total-time and downtime are no longer part o

Re: [Qemu-devel] [PATCH 0/2] tests: Fixes for in-tree build

2013-08-20 Thread Andreas Färber
Am 20.08.2013 09:47, schrieb arm...@redhat.com: > From: Markus Armbruster > > Markus Armbruster (2): > tests: Fix schema parser test for in-tree build > tests: Update .gitignore for test-int128 and test-bitops Series Reviewed-by: Andreas Färber but you should probably add Cc: qemu-sta...@

[Qemu-devel] [PATCH -V2 3/4] target-ppc: Fix page table lookup with kvm enabled

2013-08-20 Thread Aneesh Kumar K.V
From: "Aneesh Kumar K.V" With kvm enabled, we store the hash page table information in the hypervisor. Use ioctl to read the htab contents. Without this we get the below error when trying to read the guest address (gdb) x/10 do_fork 0xc0098660 : Cannot access memory at address 0xc00

[Qemu-devel] [PATCH -V2 2/4] target-ppc: Use #define instead of opencoding SLB valid bit

2013-08-20 Thread Aneesh Kumar K.V
From: "Aneesh Kumar K.V" Use SLB_ESID_V instead of (1 << 27) in the code Reviewed-by: Andreas Färber Signed-off-by: Aneesh Kumar K.V --- target-ppc/mmu_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-ppc/mmu_helper.c b/target-ppc/mmu_helper.c index 5dd4e05.

[Qemu-devel] [PATCH -V2 0/4] target-ppc: Add support for dumping guest memory using qemu gdb server

2013-08-20 Thread Aneesh Kumar K.V
This patch series implement support for dumping guest memory using qemu gdb server. With this patch series we can now do (gdb) x/4i htab_call_hpte_insert1 0xc00470d8 <.htab_call_hpte_insert1>:bl 0xc00470d8 <.htab_call_hpte_insert1> 0xc00470dc <.htab_c

[Qemu-devel] [PATCH -V2 1/4] target-ppc: Update slb array with correct index values.

2013-08-20 Thread Aneesh Kumar K.V
From: "Aneesh Kumar K.V" Without this, a value of rb=0 and rs=0 results in replacing the 0th index. This can be observed when using gdb remote debugging support. (gdb) x/10i do_fork 0xc0085330 :Cannot access memory at address 0xc0085330 (gdb) This is because when we

[Qemu-devel] [PATCH -V2 4/4] target-ppc: Check for error on address translation in memsave command

2013-08-20 Thread Aneesh Kumar K.V
From: "Aneesh Kumar K.V" When we translate the virtual address to physical check for error. Signed-off-by: Aneesh Kumar K.V --- cpus.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/cpus.c b/cpus.c index 0f65e76..658366d 100644 --- a/cpus.c +++ b/cpus.c @@ -1309,7 +130

Re: [Qemu-devel] vmdk stream-optimised format

2013-08-20 Thread Paolo Bonzini
Il 20/08/2013 09:08, Fam Zheng ha scritto: > On Tue, 08/20 07:51, Alex Bligh wrote: >> >> On 20 Aug 2013, at 02:42, Fam Zheng wrote: >> >>> OK, thanks for explaination. That sounds a valid use case for >>> streamOptimized. However I am afraid QEMU and its users benefit not much >>> from this featur

Re: [Qemu-devel] [RFC] Hardware acceleration for Windows and OS X?

2013-08-20 Thread Paolo Bonzini
Il 19/08/2013 22:17, Stefan Weil ha scritto: > Hello, > > is anybody working on KVM or something equivalent for Windows and Mac OS X? > > I recently noticed that the QEMU based Android emulator uses KVM for Linux > and HAXM, an Intel hypervisor, for Windows and Mac OS X. > > Would it be a good p

Re: [Qemu-devel] [RFC] Hardware acceleration for Windows and OS X?

2013-08-20 Thread Peter Maydell
On 20 August 2013 11:56, Paolo Bonzini wrote: > I guess "patches are welcome"---if they are of good quality, why not. Well, sort of. Given the fairly minimal level of support we currently have for OSX (ie Andreas and I test it a bit and fix egregious breakage), I'd prefer it if patches for signif

Re: [Qemu-devel] [PATCHv11 13/31] aio / timers: aio_ctx_prepare sets timeout from AioContext timers

2013-08-20 Thread Wenchao Xia
于 2013-8-20 17:29, Alex Bligh 写道: On 20 Aug 2013, at 08:19, Wenchao Xia wrote: Thanks for the explanation. It seems *timeout is always set to -1 before calling GSource's prepare(), so "*timeout = qemu_soonest_timeout(*timeout, 10);" will always get *timeout = 10, so this call can be saved.

Re: [Qemu-devel] [PATCH] powerpc iommu: enable multiple TCE requests

2013-08-20 Thread Benjamin Herrenschmidt
On Tue, 2013-08-20 at 12:14 +0200, Paolo Bonzini wrote: > > I suppose if RH is going to deploy 3.10 and we aren't going to backport > > the multitce patches then there *might* be a case for supporting that > > combo specifically... but it's going to be that bad every time we add > > a new feature w

[Qemu-devel] [PATCH v2 1/2] tests: Fix schema parser test for in-tree build

2013-08-20 Thread armbru
From: Markus Armbruster Commit 4f193e3 added the test, but screwed up in-tree builds (SRCDIR=.): the tests's output overwrites the expected output, and is thus compared to itself. Cc: qemu-sta...@nongnu.org Reported-by: Laszlo Ersek Reviewed-by: Andreas Färber Signed-off-by: Markus Armbruster

[Qemu-devel] [PATCH v2 2/2] tests: Update .gitignore for test-int128 and test-bitops

2013-08-20 Thread armbru
From: Markus Armbruster Forgotten in commit 6046c62 and 3464700. Cc: qemu-sta...@nongnu.org Reviewed-by: Andreas Färber Signed-off-by: Markus Armbruster --- tests/.gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/.gitignore b/tests/.gitignore index d9c2ef4..9ac044d 100644

Re: [Qemu-devel] [PATCH 0/2] tests: Fixes for in-tree build

2013-08-20 Thread Markus Armbruster
Andreas Färber writes: > Am 20.08.2013 09:47, schrieb arm...@redhat.com: >> From: Markus Armbruster >> >> Markus Armbruster (2): >> tests: Fix schema parser test for in-tree build >> tests: Update .gitignore for test-int128 and test-bitops > > Series > > Reviewed-by: Andreas Färber > > but

[Qemu-devel] [PATCH v2 0/2] tests: Fixes for in-tree build

2013-08-20 Thread armbru
From: Markus Armbruster v2: Nominate for qemu-stable (Andreas) Markus Armbruster (2): tests: Fix schema parser test for in-tree build tests: Update .gitignore for test-int128 and test-bitops tests/.gitignore | 3 +++ tests/Makefile | 8 2 files changed, 7 insertions(+), 4 deleti

Re: [Qemu-devel] [PATCH 0/3] target-ppc: Add support for dumping guest memory using qemu gdb server

2013-08-20 Thread Andreas Färber
Am 20.08.2013 10:19, schrieb Aneesh Kumar K.V: > Andreas Färber writes: > >> Hi Aneesh, >> >> Am 19.08.2013 14:29, schrieb Aneesh Kumar K.V: >>> This patch series implement support for dumping guest memory using qemu gdb >>> server. >> >> I had a quick look through but will leave in-depth review

Re: [Qemu-devel] [PATCH] target-i386: Only provide CMOV and friends if feature bit set

2013-08-20 Thread Peter Maydell
Ping^2! This has been reviewed and I've checked that the patch still applies to master. thanks -- PMM On 25 July 2013 17:54, Peter Maydell wrote: > Ping! > > (patchwork url: http://patchwork.ozlabs.org/patch/259148/) > > thanks > -- PMM > > On 15 July 2013 18:21, Peter Maydell wrote: >> The ins

Re: [Qemu-devel] [PATCH] hw/openrisc/openrisc_sim: Avoid using uninitialised variable 'entry'

2013-08-20 Thread Peter Maydell
Ping for qemu-trivial now 1.7 is open. thanks -- PMM On 5 August 2013 19:24, Peter Maydell wrote: > clang warns that cpu_openrisc_load_kernel() can use 'entry' uninitialized: > > hw/openrisc/openrisc_sim.c:69:9: error: variable 'entry' is used > uninitialized whenever '&&' condition is fal

Re: [Qemu-devel] [PATCH] configure: disable clang -Wstring-plus-int warning

2013-08-20 Thread Peter Maydell
Ping for qemu-trivial now 1.7 is open. thanks -- PMM On 5 August 2013 20:16, Peter Maydell wrote: > Some versions of clang will warn about adding integers to strings: > > disas/i386.c:4753:23: error: adding 'char' to a string does not append > to the string [-Werror,-Wstring-plus-int] >

Re: [Qemu-devel] [PATCH 00/14] ARM: make IRQ/FIQ gpio lines on CPU object

2013-08-20 Thread Peter Maydell
On 8 August 2013 17:04, Peter Maydell wrote: > This patch series makes IRQ and FIQ be inbound gpio lines on the > ARMCPU object (which we can do now that it is a subclass of > DeviceState). This allows us to drop the odd 'arm_pic' shim, > which doesn't correspond to real hardware and existed purel

Re: [Qemu-devel] [PATCH v2 0/4] target-arm: Implement support for generic timers

2013-08-20 Thread Peter Maydell
On 9 August 2013 17:17, Peter Maydell wrote: > This patch series implements support for the 'generic timers', > which are a set of timers defined in the ARM Architecture Reference > Manual and implemented by the Cortex-A15. We've got away without > these up til now because Linux will generally fal

Re: [Qemu-devel] [PATCH] default-configs: Fix A9MP and A15MP config names

2013-08-20 Thread Peter Maydell
On 9 August 2013 14:50, Peter Maydell wrote: > When individual CONFIG_ switches for the A9MPcore and A15MPcore > devices were created, they were inadvertently given incorrect names > (CONFIG_ARM9MPCORE and CONFIG_ARM15MPCORE). These CPUs are > "Cortex-A9MP" and "Cortex-A15MP", and in particular th

Re: [Qemu-devel] [PATCH] hw/openrisc/openrisc_sim: Avoid using uninitialised variable 'entry'

2013-08-20 Thread Jia Liu
Hi Peter, On Tue, Aug 20, 2013 at 9:00 PM, Peter Maydell wrote: > Ping for qemu-trivial now 1.7 is open. Thank you, I'll send a PULL very soon. > > thanks > -- PMM > > On 5 August 2013 19:24, Peter Maydell wrote: >> clang warns that cpu_openrisc_load_kernel() can use 'entry' uninitialized: >>

Re: [Qemu-devel] vm performance degradation after kvm live migration or save-restore with EPT enabled

2013-08-20 Thread Zhanghaoyu (A)
>>> >>> The QEMU command line (/var/log/libvirt/qemu/[domain name].log), >>> >>> LC_ALL=C PATH=/bin:/sbin:/usr/bin:/usr/sbin HOME=/ >>> >>> QEMU_AUDIO_DRV=none >>> >>> /usr/local/bin/qemu-system-x86_64 -name ATS1 -S -M pc-0.12 -cpu >>> >>> qemu32 -enable-kvm -m 12288 -smp 4,sockets=4,cores=1,thre

Re: [Qemu-devel] [PATCHv11 13/31] aio / timers: aio_ctx_prepare sets timeout from AioContext timers

2013-08-20 Thread Alex Bligh
On 20 Aug 2013, at 12:19, Wenchao Xia wrote: > So it is an undefined value, should avoid use it? It's not an undefined value. It's the value that the poll should wait for subject to modification by the prepare call. -- Alex Bligh

Re: [Qemu-devel] vmdk stream-optimised format

2013-08-20 Thread Alex Bligh
On 20 Aug 2013, at 11:53, Paolo Bonzini wrote: > It doesn't look too different from what "qemu-img convert -c" does, > except that you need to use the right "-o" incantation to specify the > format type. Extensive incanting did not produce a result that works. Possibly inadequate haruspication o

Re: [Qemu-devel] vmdk stream-optimised format

2013-08-20 Thread Paolo Bonzini
Il 20/08/2013 15:37, Alex Bligh ha scritto: > > On 20 Aug 2013, at 11:53, Paolo Bonzini wrote: > >> It doesn't look too different from what "qemu-img convert -c" does, >> except that you need to use the right "-o" incantation to specify the >> format type. > > Extensive incanting did not produce

Re: [Qemu-devel] [PATCH v2] monitor: print the invalid char in error message

2013-08-20 Thread Eric Blake
On 08/19/2013 08:58 PM, Fam Zheng wrote: > It's more friendly to print which char is invalid to user, especially > when user tries to input a float value and expect the monitor to round > it to int. Since we don't round float number when we look for a integer, > telling which char is invalid is les

Re: [Qemu-devel] Call for agenda for 2013-08-20

2013-08-20 Thread Juan Quintela
Juan Quintela wrote: > Hi > > Please, send any topic that you are interested in covering. > Call cancelled. As this was the only topic, and neither Frederik or Konrad are able to attend today, topic got moved to next call in two weeks. > Thanks, Juan. > > Agenda so far: > - Talk about qemu r

Re: [Qemu-devel] [PATCH V8 07/11] NUMA: set guest numa nodes memory policy

2013-08-20 Thread Andrew Jones
- Original Message - > Set the guest numa nodes memory policies using the mbind(2) > system call node by node. > After this patch, we are able to set guest nodes memory policies > through the QEMU options, this arms to solve the guest cross > nodes memory access performance issue. > And a

[Qemu-devel] [PATCH] Make cow_co_is_allocated and cow_update_bitmap more efficient

2013-08-20 Thread Charlie Shepherd
cow_co_is_allocated and cow_update_bitmap set bits by reading the relevant word, setting the specific bit in it and writing it back. These functions set a number of contiguous bits however, so this is an extremely inefficient way of doing this. This patch converts them to read the whole bitmap they

Re: [Qemu-devel] [PATCH V8 00/11] Add support for binding guest numa nodes to host numa nodes

2013-08-20 Thread Paolo Bonzini
Il 20/08/2013 03:07, Wanlong Gao ha scritto: > -numa node,nodeid=0,cpus=0, \ > -numa mem,size=1024M,policy=membind,host-nodes=0-1 \ > -numa node,nodeid=1,cpus=1 \ > -numa mem,size=1024M,policy=interleave,host-nodes=1 What nodes would the memory be in, for this command line? Does it just compu

Re: [Qemu-devel] [PATCH] Make cow_co_is_allocated and cow_update_bitmap more efficient

2013-08-20 Thread Paolo Bonzini
Il 20/08/2013 15:42, Charlie Shepherd ha scritto: > cow_co_is_allocated and cow_update_bitmap set bits by reading the relevant > word, setting the specific bit in it and writing it back. These functions set > a number of contiguous bits however, so this is an extremely inefficient way > of doing th

Re: [Qemu-devel] [Patch] ARM: Simplify and fix imx_epit implementation.

2013-08-20 Thread Peter Maydell
On 5 August 2013 02:27, Peter Chubb wrote: > > When imx_epit.c was last refactored, a common usecase (comparison > register zero) broke. This patch fixes that, and simplifies the code > yet more. It also fixes a major thinko in the reset path --- the > wrong bits in the control register were bei

Re: [Qemu-devel] [PATCH] Make cow_co_is_allocated and cow_update_bitmap more efficient

2013-08-20 Thread Charlie Shepherd
On 20/08/2013 14:45, Paolo Bonzini wrote: I had very similar patches in my series to add get_block_status... Ah, sorry if I've duplicated something you've already done. Stefan encouraged me to contribute to an area of QEMU I found interesting and seeing the XXX I thought I'd take a shot at im

Re: [Qemu-devel] [Patch] ARM: Simplify and fix imx_epit implementation.

2013-08-20 Thread Andreas Färber
Am 20.08.2013 15:46, schrieb Peter Maydell: > On 5 August 2013 02:27, Peter Chubb wrote: >> >> When imx_epit.c was last refactored, a common usecase (comparison >> register zero) broke. This patch fixes that, and simplifies the code >> yet more. It also fixes a major thinko in the reset path ---

Re: [Qemu-devel] vmdk stream-optimised format

2013-08-20 Thread Alex Bligh
On 20 Aug 2013, at 14:37, Paolo Bonzini wrote: > Yes, because vmdk does not implement bdrv_write_compressed. Sorry for > leaving out the small "detail". :( Would that be easy for me to fix? -- Alex Bligh

Re: [Qemu-devel] [Patch] ARM: Simplify and fix imx_epit implementation.

2013-08-20 Thread Peter Maydell
On 20 August 2013 15:01, Andreas Färber wrote: > Peter Ch., please call such a patch "imx_epit: " rather than "ARM: " > since it affects only your device. (PMM, can you fix?) Yes, I fixed it to say "hw/timer/imx_epit: ..." -- PMM

Re: [Qemu-devel] [PATCH V8 00/13] monitor: support sub command group in auto completion and help

2013-08-20 Thread Luiz Capitulino
On Tue, 30 Jul 2013 12:03:11 -0400 Luiz Capitulino wrote: > On Fri, 26 Jul 2013 11:20:29 +0800 > Wenchao Xia wrote: > > > This series make auto completion and help functions works normal for sub > > command, by using reentrant functions. In order to do that, global variables > > are not directl

Re: [Qemu-devel] [PATCH] Make cow_co_is_allocated and cow_update_bitmap more efficient

2013-08-20 Thread Paolo Bonzini
Il 20/08/2013 15:50, Charlie Shepherd ha scritto: > On 20/08/2013 14:45, Paolo Bonzini wrote: >> I had very similar patches in my series to add get_block_status... > > Ah, sorry if I've duplicated something you've already done. Stefan > encouraged me to contribute to an area of QEMU I found intere

[Qemu-devel] [PULL 08/21] hw/arm/musicpal: Don't use arm_pic_init_cpu()

2013-08-20 Thread Peter Maydell
Drop the now-deprecated arm_pic_init_cpu() in favour of directly getting the IRQ line from the ARMCPU object. Signed-off-by: Peter Maydell Message-id: 1375977856-25046-8-git-send-email-peter.mayd...@linaro.org --- hw/arm/musicpal.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) dif

[Qemu-devel] [PULL 07/21] hw/arm/kzm: Don't use arm_pic_init_cpu()

2013-08-20 Thread Peter Maydell
Drop the now-deprecated arm_pic_init_cpu() in favour of directly getting the IRQ line from the ARMCPU object. Signed-off-by: Peter Maydell Message-id: 1375977856-25046-7-git-send-email-peter.mayd...@linaro.org --- hw/arm/kzm.c |8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) dif

[Qemu-devel] [PULL 16/21] target-arm: Allow raw_read() and raw_write() to handle 64 bit regs

2013-08-20 Thread Peter Maydell
Extend the raw_read() and raw_write() helper accessors so that they can be used for 64 bit registers as well as 32 bit registers. Signed-off-by: Peter Maydell Tested-by: Laurent Desnogues Reviewed-by: Edgar E. Iglesias Message-id: 1376065080-26661-2-git-send-email-peter.mayd...@linaro.org ---

[Qemu-devel] [PULL 11/21] hw/arm/strongarm: Don't use arm_pic_init_cpu()

2013-08-20 Thread Peter Maydell
Drop the now-deprecated arm_pic_init_cpu() in favour of directly getting the IRQ line from the ARMCPU object. Signed-off-by: Peter Maydell Message-id: 1375977856-25046-11-git-send-email-peter.mayd...@linaro.org --- hw/arm/strongarm.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[Qemu-devel] [PULL 17/21] target-arm: Support coprocessor registers which do I/O

2013-08-20 Thread Peter Maydell
Add an ARM_CP_IO flag which an ARMCPRegInfo definition can use to indicate that the register's implementation does I/O and thus its accesses need to be surrounded by gen_io_start()/gen_io_end() in order for icount to work. Most notably, cp registers which implement clocks or timers need this. Sign

[Qemu-devel] [PULL 13/21] hw/arm/vexpress: Don't use arm_pic_init_cpu()

2013-08-20 Thread Peter Maydell
Drop the now-deprecated arm_pic_init_cpu() in favour of directly getting the IRQ line from the ARMCPU object. Signed-off-by: Peter Maydell Message-id: 1375977856-25046-13-git-send-email-peter.mayd...@linaro.org --- hw/arm/vexpress.c |8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-

[Qemu-devel] [PULL 20/21] default-configs: Fix A9MP and A15MP config names

2013-08-20 Thread Peter Maydell
When individual CONFIG_ switches for the A9MPcore and A15MPcore devices were created, they were inadvertently given incorrect names (CONFIG_ARM9MPCORE and CONFIG_ARM15MPCORE). These CPUs are "Cortex-A9MP" and "Cortex-A15MP", and in particular the ARM9 is a different (rather older) CPU than the Cort

[Qemu-devel] [PULL 05/21] hw/arm/highbank: Don't use arm_pic_init_cpu()

2013-08-20 Thread Peter Maydell
Drop the now-deprecated arm_pic_init_cpu() in favour of directly getting the IRQ line from the ARMCPU object. Signed-off-by: Peter Maydell Message-id: 1375977856-25046-5-git-send-email-peter.mayd...@linaro.org --- hw/arm/highbank.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) dif

[Qemu-devel] [PULL 21/21] hw/timer/imx_epit: Simplify and fix imx_epit implementation

2013-08-20 Thread Peter Maydell
From: Peter Chubb When imx_epit.c was last refactored, a common usecase (comparison register zero) broke. This patch fixes that, and simplifies the code yet more. It also fixes a major thinko in the reset path --- the wrong bits in the control register were being cleared. Signed-off-by: Peter

[Qemu-devel] [PULL 01/21] target-arm: Implement 'int' loglevel

2013-08-20 Thread Peter Maydell
The 'int' loglevel for recording interrupts and exceptions requires support in the target-specific code. Implement it for ARM. This improves debug logging in some situations that were otherwise pretty opaque, such as when we fault trying to execute at an exception vector address, which would otherw

[Qemu-devel] [PULL 14/21] hw/arm/xilinx_zynq: Don't use arm_pic_init_cpu()

2013-08-20 Thread Peter Maydell
Drop the now-deprecated arm_pic_init_cpu() in favour of directly getting the IRQ line from the ARMCPU object. Signed-off-by: Peter Maydell Message-id: 1375977856-25046-14-git-send-email-peter.mayd...@linaro.org --- hw/arm/xilinx_zynq.c |7 ++- 1 file changed, 2 insertions(+), 5 deletions

[Qemu-devel] [PULL 15/21] hw/arm/pic_cpu: Remove the now-unneeded arm_pic_init_cpu()

2013-08-20 Thread Peter Maydell
Now all the boards have been converted arm_pic_init_cpu() is unused and can just be deleted. Signed-off-by: Peter Maydell Message-id: 1375977856-25046-15-git-send-email-peter.mayd...@linaro.org --- hw/arm/Makefile.objs |2 +- hw/arm/pic_cpu.c | 25 - include/hw/

[Qemu-devel] [PULL 19/21] hw/cpu/a15mpcore: Wire generic timer outputs to GIC inputs

2013-08-20 Thread Peter Maydell
Now our A15 CPU implements the generic timers, we can wire them up to the appropriate inputs on the GIC. Signed-off-by: Peter Maydell Tested-by: Laurent Desnogues Message-id: 1376065080-26661-5-git-send-email-peter.mayd...@linaro.org --- hw/cpu/a15mpcore.c | 18 ++ 1 file chan

[Qemu-devel] [PULL 09/21] hw/arm/omap*: Don't use arm_pic_init_cpu()

2013-08-20 Thread Peter Maydell
Drop the now-deprecated arm_pic_init_cpu() in favour of directly getting the IRQ line from the ARMCPU object. Signed-off-by: Peter Maydell Message-id: 1375977856-25046-9-git-send-email-peter.mayd...@linaro.org --- hw/arm/omap1.c |8 hw/arm/omap2.c |8 2 files changed, 8

[Qemu-devel] [PULL 18/21] target-arm: Implement the generic timer

2013-08-20 Thread Peter Maydell
The ARMv7 architecture specifies a 'generic timer' which is implemented via cp15 registers. Newer kernels will prefer to use this rather than a devboard-level timer. Implement the generic timer for TCG; for KVM we will already use the hardware's virtualized timer for this. Signed-off-by: Peter May

[Qemu-devel] [PULL 03/21] hw/arm/armv7m: Don't use arm_pic_init_cpu()

2013-08-20 Thread Peter Maydell
Drop the now-deprecated arm_pic_init_cpu() in favour of directly getting the IRQ line from the ARMCPU object. Signed-off-by: Peter Maydell Message-id: 1375977856-25046-3-git-send-email-peter.mayd...@linaro.org --- hw/arm/armv7m.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) dif

[Qemu-devel] [PULL 02/21] target-arm: Make IRQ and FIQ gpio lines on the CPU object

2013-08-20 Thread Peter Maydell
Now that ARMCPU is a subclass of DeviceState, we can make the CPU's inbound IRQ and FIQ lines be simply gpio lines, which means we can remove the odd arm_pic shim. We retain the arm_pic_init_cpu() function as a backwards compatibility shim layer so we can convert the board models to get the IRQ an

[Qemu-devel] [PULL 10/21] hw/arm/realview: Don't use arm_pic_init_cpu()

2013-08-20 Thread Peter Maydell
Drop the now-deprecated arm_pic_init_cpu() in favour of directly getting the IRQ line from the ARMCPU object. Signed-off-by: Peter Maydell Message-id: 1375977856-25046-10-git-send-email-peter.mayd...@linaro.org --- hw/arm/realview.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) di

[Qemu-devel] [PULL 04/21] hw/arm/exynos4210: Don't use arm_pic_init_cpu()

2013-08-20 Thread Peter Maydell
Drop the now-deprecated arm_pic_init_cpu() in favour of directly getting the IRQ line from the ARMCPU object. Signed-off-by: Peter Maydell Message-id: 1375977856-25046-4-git-send-email-peter.mayd...@linaro.org --- hw/arm/exynos4210.c | 16 +++- 1 file changed, 3 insertions(+), 13 d

[Qemu-devel] [PULL 06/21] hw/arm/integratorcp: Don't use arm_pic_init_cpu()

2013-08-20 Thread Peter Maydell
Drop the now-deprecated arm_pic_init_cpu() in favour of directly getting the IRQ line from the ARMCPU object. Signed-off-by: Peter Maydell Message-id: 1375977856-25046-6-git-send-email-peter.mayd...@linaro.org --- hw/arm/integratorcp.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions

Re: [Qemu-devel] [PATCH v2] monitor: print the invalid char in error message

2013-08-20 Thread Luiz Capitulino
On Tue, 20 Aug 2013 10:58:21 +0800 Fam Zheng wrote: > It's more friendly to print which char is invalid to user, especially > when user tries to input a float value and expect the monitor to round > it to int. Since we don't round float number when we look for a integer, > telling which char is i

[Qemu-devel] [PULL 00/21] target-arm queue

2013-08-20 Thread Peter Maydell
l/qemu-arm.git tags/pull-target-arm-20130820 for you to fetch changes up to 230058106ab26de9b876158dbe27d60719f01f51: hw/timer/imx_epit: Simplify and fix imx_epit implementation (2013-08-20 14:54:32 +0100)

Re: [Qemu-devel] [PATCH v4 00/13] VHDX log replay and write support, .bdrv_create()

2013-08-20 Thread Kevin Wolf
Am 20.08.2013 um 08:01 hat Jeff Cody geschrieben: > This patch series contains the initial VHDX log parsing, replay, > and write support. (New with v4: VHDX image file creation) Not sure if it helps a lot, but patches 1 to 4 are: Reviewed-by: Kevin Wolf I'll continue next week (unless someone

Re: [Qemu-devel] [Bug?] qemu-1.6.0 python traceback in GEN qmp-commands.h

2013-08-20 Thread Stefan Hajnoczi
On Mon, Aug 19, 2013 at 03:50:45PM +0200, Andreas Färber wrote: > Am 16.08.2013 15:21, schrieb Peter Maydell: > > On 16 August 2013 08:59, Erik Rull wrote: > >> Hi all, > >> > >> when using the released qemu-1.6.0.tar.bz2, I get the following error > >> message: > >> File "/home/erik/qemu-1.6.0

Re: [Qemu-devel] Fwd: [libvirt] virDomainAttachDevice error during disk hotplug

2013-08-20 Thread Stefan Hajnoczi
On Fri, Aug 16, 2013 at 06:52:32PM +0530, Deepak C Shetty wrote: > 2) qemu-img info /var/run/vdsm/017d-1278-4bfb-8129-62bded257399 > image: /var/run/vdsm/017d-1278-4bfb-8129-62bded257399 > file format: qcow2 > virtual size: 3.8G (409600 bytes) > disk size: 196K > cluster_size: 65536 > b

[Qemu-devel] [PATCH] scripts/qapi.py: Avoid syntax not supported by Python 2.4

2013-08-20 Thread Peter Maydell
The Python "except Foo as x" syntax was only introduced in Python 2.6, but we aim to support Python 2.4 and later. Use the old-style "except Foo, x" syntax instead, thus fixing configure/compile on systems with older Python. Signed-off-by: Peter Maydell --- I don't have an old python to test this

Re: [Qemu-devel] vmdk stream-optimised format

2013-08-20 Thread Stefan Hajnoczi
On Tue, Aug 20, 2013 at 07:51:40AM +0100, Alex Bligh wrote: > What I'm not sure of is whether the streaming format has to be written > sequentially from as opposed to random writes. I believe the way > qemu-img convert works, one can't guarantee the writes are > sequential. It should be possible t

Re: [Qemu-devel] [RFC] Hardware acceleration for Windows and OS X?

2013-08-20 Thread Stefan Hajnoczi
On Mon, Aug 19, 2013 at 10:17:15PM +0200, Stefan Weil wrote: > Would it be a good plan to merge HAXM support in latest QEMU > (the Android QEMU is based on a rather old version)? It only > supports Intel based hosts, is restricted to 32 bit guests (?) > and free, but not open source. I think the a

Re: [Qemu-devel] Fwd: [libvirt] virDomainAttachDevice error during disk hotplug

2013-08-20 Thread Daniel P. Berrange
On Tue, Aug 20, 2013 at 04:43:48PM +0200, Stefan Hajnoczi wrote: > On Fri, Aug 16, 2013 at 06:52:32PM +0530, Deepak C Shetty wrote: > > 2) qemu-img info /var/run/vdsm/017d-1278-4bfb-8129-62bded257399 > > image: /var/run/vdsm/017d-1278-4bfb-8129-62bded257399 > > file format: qcow2 > > virtua

[Qemu-devel] [PULL 12/21] hw/arm/versatilepb: Don't use arm_pic_init_cpu()

2013-08-20 Thread Peter Maydell
Drop the now-deprecated arm_pic_init_cpu() in favour of directly getting the IRQ line from the ARMCPU object. Signed-off-by: Peter Maydell Message-id: 1375977856-25046-12-git-send-email-peter.mayd...@linaro.org --- hw/arm/versatilepb.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions

Re: [Qemu-devel] [PATCH] target-i386: Only provide CMOV and friends if feature bit set

2013-08-20 Thread Richard Henderson
On 08/20/2013 05:59 AM, Peter Maydell wrote: > Ping^2! This has been reviewed and I've checked that the > patch still applies to master. Reviewed-by: Richard Henderson > > thanks > -- PMM > > On 25 July 2013 17:54, Peter Maydell wrote: >> Ping! >> >> (patchwork url: http://patchwork.ozlabs.or

[Qemu-devel] [PATCH v3 00/24] arm: ARM11MPCore+A9MPCore+A15MPCore QOM'ification

2013-08-20 Thread Andreas Färber
From: Andreas Färber Hello Peter, This series fully QOM'ifies A9MPCore so that it can be embedded for Tegra2. It goes on to do the same for A15MPCore, which had previously been taken as template for Cortex-A57 by John Rigby, and in v3 ARM11MPCore. Separate headers are introduced to only expose

[Qemu-devel] [PATCH v3 02/24] intc/arm_gic: Extract headers hw/intc/arm_gic{, _common}.h

2013-08-20 Thread Andreas Färber
Rename NCPU to GIC_NCPU and move GICState away from gic_internal.h. Signed-off-by: Andreas Färber --- hw/intc/arm_gic_common.c | 18 hw/intc/gic_internal.h | 80 +- include/hw/intc/arm_gic.h| 42 ++ include/hw/int

  1   2   >