Re: [Qemu-devel] [PATCH for-1.6 V2 0/2] pvpanic: Separate pvpanic from machine type

2013-08-12 Thread Marcel Apfelbaum
On Mon, 2013-08-12 at 09:53 -0600, Eric Blake wrote: > On 08/11/2013 09:10 AM, Marcel Apfelbaum wrote: > > Creating the pvpanic device as part of the machine type has the > > potential to trigger guest OS, guest firmware and driver bugs. > > The potential of such was originally viewed as minimal. >

Re: [Qemu-devel] [RFC] [PATCHv10 08/31] aio / timers: Split QEMUClock into QEMUClock and QEMUTimerList

2013-08-12 Thread Jan Kiszka
On 2013-08-12 18:25, Alex Bligh wrote: > > On 12 Aug 2013, at 17:14, Jan Kiszka wrote: > >> The typedef part is a duplication of what we already have in >> qemu/typedefs.h and breaks the build for me. Just declare the struct here. > > You mean one can't do > > typedef struct foo foo; > ... > ty

[Qemu-devel] [QEMU-1.6 PATCH] vl.c: Output error on invalid machine type provided

2013-08-12 Thread Michal Novotny
Output error message using qemu's error_report() function when user provides the invalid machine type on the command line. This also saves time to find what issue is when you downgrade from one version of qemu to another that doesn't support required machine type yet (the version user downgraded to

Re: [Qemu-devel] [RFC] [PATCHv10 09/31] aio / timers: Untangle include files

2013-08-12 Thread Jan Kiszka
On 2013-08-11 18:43, Alex Bligh wrote: > include/qemu/timer.h has no need to include main-loop.h and > doing so causes an issue for the next patch. Unfortunately > various files assume including timers.h will pull in main-loop.h. > Untangle this mess. > Hmm, this triggers a double typedef of AioC

[Qemu-devel] [PATCH v2 for 1.6 1/2] memory: Provide separate handling of unassigned io ports accesses

2013-08-12 Thread Jan Kiszka
Accesses to unassigned io ports shall return -1 on read and be ignored on write. Ensure these properties via dedicated ops, decoupling us from the memory core's handling of unassigned accesses. Signed-off-by: Jan Kiszka --- Please fix your scripting to support in-thread patch updates. exec.c

Re: [Qemu-devel] [QEMU-1.6 PATCH] vl.c: Output error on invalid machine type provided

2013-08-12 Thread Eric Blake
On 08/12/2013 10:28 AM, Michal Novotny wrote: > Output error message using qemu's error_report() function when user > provides the invalid machine type on the command line. This also saves > time to find what issue is when you downgrade from one version of qemu > to another that doesn't support req

Re: [Qemu-devel] [QEMU-1.6 PATCH] vl.c: Output error on invalid machine type provided

2013-08-12 Thread Michal Novotny
On 08/12/2013 06:47 PM, Eric Blake wrote: > On 08/12/2013 10:28 AM, Michal Novotny wrote: >> Output error message using qemu's error_report() function when user >> provides the invalid machine type on the command line. This also saves >> time to find what issue is when you downgrade from one versi

[Qemu-devel] [PATCH V5 0/5] Continuous Leaky Bucket Throttling

2013-08-12 Thread Benoît Canet
This patchset implement continous leaky bucket throttling. It use two requests queue to enable to do silly unbalanced throttling like block_set_io_throttle 0 0 0 0 6000 1 It use two timer to get the timer callbacks and the throttle.c code simple It add unit tests. The throttling core is pretty

[Qemu-devel] [PATCH V5 2/5] throttle: Add units tests

2013-08-12 Thread Benoît Canet
Signed-off-by: Benoit Canet --- tests/Makefile|2 + tests/test-throttle.c | 494 + 2 files changed, 496 insertions(+) create mode 100644 tests/test-throttle.c diff --git a/tests/Makefile b/tests/Makefile index d044908..fb1e06a 100644

[Qemu-devel] [PATCH V5 1/5] throttle: Add a new throttling API implementing continuous leaky bucket.

2013-08-12 Thread Benoît Canet
Implement the continuous leaky bucket algorithm devised on IRC as a separate module. Signed-off-by: Benoit Canet --- include/qemu/throttle.h | 105 + util/Makefile.objs |1 + util/throttle.c | 391 +++ 3 files changed, 49

[Qemu-devel] [PATCH V5 3/5] block: Enable the new throttling code in the block layer.

2013-08-12 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block.c | 349 ++--- block/qapi.c | 21 ++- blockdev.c| 100 +++-- include/block/block.h |1 - include/block/block_int.h | 32 + 5 files changed, 173 in

[Qemu-devel] [PATCH V5 4/5] block: Add support for throttling burst max in QMP and the command line.

2013-08-12 Thread Benoît Canet
The max parameter of the leaky bycket throttling algoritm can be used to allow the guest to do bursts. The max value is a pool of I/O that the guest can use without being throttled at all. Throttling is triggered once this pool is empty. Signed-off-by: Benoit Canet --- block/qapi.c | 26 ++

[Qemu-devel] [PATCH V5 5/5] block: Add iops_sector_count to do the iops accounting for a given io size.

2013-08-12 Thread Benoît Canet
This feature can be used in case where users are avoiding the iops limit by doing jumbo I/Os hammering the storage backend. Signed-off-by: Benoit Canet --- block/qapi.c |3 +++ blockdev.c | 22 +++--- hmp.c|8 ++-- qapi-schema.json | 10 +

Re: [Qemu-devel] [RFC] Convert AioContext to Gsource sub classes

2013-08-12 Thread Michael Roth
Quoting Paolo Bonzini (2013-08-12 02:30:28) > > 1) rename AioContext to AioSource. > > This is my major purpose, which declare it is not a "context" concept, > > and GMainContext is the entity represent the thread's activity. > > Note that the nested event loops in QEMU are _very_ different from

Re: [Qemu-devel] [RFC] [PATCHv10 08/31] aio / timers: Split QEMUClock into QEMUClock and QEMUTimerList

2013-08-12 Thread Richard Henderson
On 08/12/2013 09:25 AM, Alex Bligh wrote: > You mean one can't do > > typedef struct foo foo; > ... > typedef struct foo { > ... > } foo; > > ? No, but you can do typedef struct foo foo; ... struct foo { }; It's the double typedef that's the problem. r~

Re: [Qemu-devel] [RFC] [PATCHv10 09/31] aio / timers: Untangle include files

2013-08-12 Thread Alex Bligh
Jan, On 12 Aug 2013, at 17:40, Jan Kiszka wrote: > On 2013-08-11 18:43, Alex Bligh wrote: >> include/qemu/timer.h has no need to include main-loop.h and >> doing so causes an issue for the next patch. Unfortunately >> various files assume including timers.h will pull in main-loop.h. >> Untangle t

Re: [Qemu-devel] [QEMU-1.6 PATCH] vl.c: Output error on invalid machine type provided

2013-08-12 Thread Marcel Apfelbaum
On Mon, 2013-08-12 at 18:28 +0200, Michal Novotny wrote: > Output error message using qemu's error_report() function when user > provides the invalid machine type on the command line. This also saves > time to find what issue is when you downgrade from one version of qemu > to another that doesn't

Re: [Qemu-devel] [RFC] [PATCHv10 09/31] aio / timers: Untangle include files

2013-08-12 Thread Jan Kiszka
On 2013-08-12 19:04, Alex Bligh wrote: > Jan, > > On 12 Aug 2013, at 17:40, Jan Kiszka wrote: > >> On 2013-08-11 18:43, Alex Bligh wrote: >>> include/qemu/timer.h has no need to include main-loop.h and >>> doing so causes an issue for the next patch. Unfortunately >>> various files assume includi

[Qemu-devel] [PATCH RFT qom-cpu for-next] gdbstub: Fix gdb_register_coprocessor() register counting

2013-08-12 Thread Andreas Färber
Commit a0e372f0c49ac01faeaeb73a6e8f50e8ac615f34 reorganized the register counting for GDB. While it seems correct not to let the total number of registers skyrocket in an SMP scenario through a static variable, the distinction between total register count and 'g' packet register count (last_reg vs.

Re: [Qemu-devel] [RFC] [PATCHv10 08/31] aio / timers: Split QEMUClock into QEMUClock and QEMUTimerList

2013-08-12 Thread Alex Bligh
On 12 Aug 2013, at 18:04, Richard Henderson wrote: > On 08/12/2013 09:25 AM, Alex Bligh wrote: >> You mean one can't do >> >> typedef struct foo foo; >> ... >> typedef struct foo { >> ... >> } foo; >> >> ? > > No, but you can do > > typedef struct foo foo; > ... > struct foo { > }; > > It's

[Qemu-devel] Merging latest qemu and Marss' qemu

2013-08-12 Thread Songchun Fan
Hello everyone, I am wondering if there is a way to merge the latest official qemu with Marss' qemu. I already switched to the qemu branch in Marss in order to get a newer version of qemu (v1.1), yet it still differs a lot from the latest version v1.6. The reason I need to merge these two is that

Re: [Qemu-devel] [RFC] [PATCHv8 09/30] aio / timers: Add QEMUTimerListGroup and helper functions

2013-08-12 Thread Paolo Bonzini
Il 11/08/2013 10:29, Alex Bligh ha scritto: > Paolo, > > --On 11 August 2013 09:53:38 +0200 Paolo Bonzini > wrote: > >> There is actually a disadvantage of moving TimerListGroup to AioContext. >> The disadvantage is that GSources can only work with millisecond >> resolution. Thus you would nee

Re: [Qemu-devel] [RFC] [PATCHv8 09/30] aio / timers: Add QEMUTimerListGroup and helper functions

2013-08-12 Thread Alex Bligh
On 12 Aug 2013, at 18:27, Paolo Bonzini wrote: >>> >>> So let's keep the TimerListGroup for now. >> >> OK - do you want me to wrap it in a struct? Other than that I think I've >> done all the comments in v8. Happy to do that with v10 if there are >> other comments on v9. > > No, it's okay. Un

Re: [Qemu-devel] SCSI bus failures with qemu-arm in kernel 3.8+

2013-08-12 Thread Peter Maydell
On 12 August 2013 17:45, Russell King - ARM Linux wrote: > On Mon, Aug 12, 2013 at 05:24:50PM +0100, Peter Maydell wrote: >> On 12 August 2013 01:40, Guenter Roeck wrote: >> > On 08/11/2013 03:04 PM, Russell King - ARM Linux wrote: >> >> It could be that it's qemu's PCI routing is wrong - it's no

Re: [Qemu-devel] [PATCH] gdb: Fix gdb error

2013-08-12 Thread Andreas Färber
Am 12.08.2013 11:17, schrieb Aneesh Kumar K.V: > Andreas Färber writes: >> Am 11.08.2013 20:14, schrieb Aneesh Kumar K.V: >>> From: "Aneesh Kumar K.V" >>> >>> Don't update the global register count if not requested. >>> Without this patch a remote gdb session gives >>> >>> (gdb) target remote loc

Re: [Qemu-devel] SCSI bus failures with qemu-arm in kernel 3.8+

2013-08-12 Thread Peter Maydell
On 12 August 2013 17:45, Russell King - ARM Linux wrote: > In other words, if you have the circuit diagrams or other documentation > which definitively identifies the wiring, then please send it to me. I've just checked and the schematics are provided on the CDROM "Versatile Family Product Suppor

[Qemu-devel] [PATCH v2 for-1.6 0/2] future proof rom loading for cross versiom migration

2013-08-12 Thread Michael S. Tsirkin
Changes from v1: address comments by Peter Maydell - drop useless data=data line - rename target_page_size to migration_page_size to make use clear Peter, you also suggested somehow hiding this within memory core. I don't see a clean way to do this without lots of code changes,

[Qemu-devel] [PATCH v2 for-1.6 v2 1/2] memory: export migration page size

2013-08-12 Thread Michael S. Tsirkin
Migration code assumes that each RAM block is a multiple of target page size. We can fix this in a variety of ways, for 1.6 the simplest way is possibly exporting the required page size so callers can make regions large enough. Signed-off-by: Michael S. Tsirkin --- arch_init.c | 3 +++

Re: [Qemu-devel] [PATCH v2] pc: drop external DSDT loading

2013-08-12 Thread Michael S. Tsirkin
On Mon, Aug 12, 2013 at 10:20:41AM -0500, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > > > On Mon, Aug 12, 2013 at 09:01:44AM -0500, Anthony Liguori wrote: > >> This breaks migration and is unneeded with modern SeaBIOS. > >> > >> Signed-off-by: Anthony Liguori > > > > Hmm don't we wa

[Qemu-devel] [PATCH v2 for-1.6 v2 2/2] loader: put FW CFG ROM files into RAM

2013-08-12 Thread Michael S. Tsirkin
ROM files that are put in FW CFG are copied to guest ram, by BIOS, but they are not backed by RAM so they don't get migrated. Each time we change two bytes in such a ROM this breaks cross-version migration: since we can migrate after BIOS has read the first byte but before it has read the second o

Re: [Qemu-devel] [PATCH v2 for-1.6 0/2] future proof rom loading for cross versiom migration

2013-08-12 Thread Michael S. Tsirkin
On Mon, Aug 12, 2013 at 09:15:55PM +0300, Michael S. Tsirkin wrote: > Changes from v1: address comments by Peter Maydell > - drop useless data=data line > - rename target_page_size to migration_page_size to make use clear > Peter, you also suggested somehow hiding this within memory cor

Re: [Qemu-devel] SCSI bus failures with qemu-arm in kernel 3.8+

2013-08-12 Thread Russell King - ARM Linux
On Mon, Aug 12, 2013 at 05:24:50PM +0100, Peter Maydell wrote: > On 12 August 2013 01:40, Guenter Roeck wrote: > > On 08/11/2013 03:04 PM, Russell King - ARM Linux wrote: > >> It could be that it's qemu's PCI routing is wrong - it's not the first > >> time that qemu has got something wrong. > > Q

Re: [Qemu-devel] [PATCH v2 for-1.6 v2 2/2] loader: put FW CFG ROM files into RAM

2013-08-12 Thread Peter Maydell
On 12 August 2013 19:16, Michael S. Tsirkin wrote: > +static void *rom_set_mr(Rom *rom, Object *owner, const char *name) > +{ > +/* > + * Migration code expects that all RAM blocks are full pages. > + * Round MR size up to satisfy this condition. > + */ > +unsigned size = ROUND

[Qemu-devel] [RFC 00/14] tcg aarch64 improvements

2013-08-12 Thread Richard Henderson
Several of these patches need cleaning up, but brings the state of the port in line with the other targets. The last patch is dependant on another patch set I've got in the queue for 1.7 (http://patchwork.ozlabs.org/patch/264736/), but is otherwise independant. The patch set is at git://github.co

[Qemu-devel] [RFC 01/14] tcg-aarch64: Allow immediate operands to add and sub

2013-08-12 Thread Richard Henderson
Use signed 25-bit operands, because two 12-bit operations is smaller than movz+movk+add. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.c | 107 +++ 1 file changed, 61 insertions(+), 46 deletions(-) diff --git a/tcg/aarch64/tcg-target.c b

[Qemu-devel] [RFC 03/14] tcg-aarch64: Allow immediate operands to compare

2013-08-12 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.c | 74 +--- 1 file changed, 51 insertions(+), 23 deletions(-) diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c index e8370a9..76595b4 100644 --- a/tcg/aarch64/tcg-target.c +++

[Qemu-devel] [RFC 04/14] tcg-aarch64: Convert from opcode enums to insn enums

2013-08-12 Thread Richard Henderson
The difference being that INSN_* has been pre-shifted into place. This should result in less runtime shifting of constants. The patch could be split into smaller pieces for clarity... Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.c | 518 ---

[Qemu-devel] [RFC 09/14] tcg-aarch64: Support add2, sub2

2013-08-12 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.c | 110 --- tcg/aarch64/tcg-target.h | 8 ++-- 2 files changed, 90 insertions(+), 28 deletions(-) diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c index 3474ca4..967526b 100

[Qemu-devel] [RFC 07/14] tcg-aarch64: Support movcond

2013-08-12 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.c | 19 ++- tcg/aarch64/tcg-target.h | 4 ++-- 2 files changed, 20 insertions(+), 3 deletions(-) diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c index 88bbfd2..f0febc9 100644 --- a/tcg/aarch64/tcg-targe

[Qemu-devel] [RFC 08/14] tcg-aarch64: Support deposit

2013-08-12 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.c | 25 + tcg/aarch64/tcg-target.h | 4 ++-- 2 files changed, 27 insertions(+), 2 deletions(-) diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c index f0febc9..3474ca4 100644 --- a/tcg/aarch64/tcg

[Qemu-devel] [RFC 10/14] tcg-aarch64: Support div, mulu2

2013-08-12 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.c | 42 ++ tcg/aarch64/tcg-target.h | 6 +++--- 2 files changed, 45 insertions(+), 3 deletions(-) diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c index 967526b..920c63c 100644 --

[Qemu-devel] [RFC 11/14] tcg-aarch64: Improve tcg_out_movi

2013-08-12 Thread Richard Henderson
Handle small positive and negative numbers early. Check for logical immediates. Check if using MOVN for the first set helps. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.c | 85 +--- 1 file changed, 66 insertions(+), 19 deletions(-) d

[Qemu-devel] [RFC 12/14] tcg-aarch64: Avoid add with zero in tlb load

2013-08-12 Thread Richard Henderson
Some guest env are small enough to reach the tlb with only a 12-bit addition. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c index 02a

[Qemu-devel] [RFC 13/14] tcg-aarch64: Use adrp in tcg_out_movi

2013-08-12 Thread Richard Henderson
Loading an qemu pointer as an immediate happens often: - exit_tb $0x7fa8140013 + exit_tb $0x7f81ee0013 ... - : d2800260mov x0, #0x13 - : f2b50280movkx0, #0xa814, lsl #16 - : f2c00fe0movkx0, #0x7f, lsl #32 + : 90ff1000adrpx0, 0x7f81ee + : 910

[Qemu-devel] [RFC 14/14] tcg-aarch64: Pass return address to load/store helpers directly.

2013-08-12 Thread Richard Henderson
Signed-off-by: Richard Henderson --- include/exec/exec-all.h | 16 +-- tcg/aarch64/tcg-target.c | 69 ++-- 2 files changed, 39 insertions(+), 46 deletions(-) diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h index b3402a1..10e680d

Re: [Qemu-devel] [PATCH v2 for-1.6 v2 2/2] loader: put FW CFG ROM files into RAM

2013-08-12 Thread Michael S. Tsirkin
On Mon, Aug 12, 2013 at 07:37:21PM +0100, Peter Maydell wrote: > On 12 August 2013 19:16, Michael S. Tsirkin wrote: > > +static void *rom_set_mr(Rom *rom, Object *owner, const char *name) > > +{ > > +/* > > + * Migration code expects that all RAM blocks are full pages. > > + * Round MR

[Qemu-devel] [RFC 06/14] tcg-aarch64: Handle zero as first argument to sub

2013-08-12 Thread Richard Henderson
In order to properly handle neg, as generated by TCG generic code. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c index 7aeb3cd..88bbfd2 1

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] [v3] target-ppc: Enhance CPU nodes of device tree to be PAPR compliant.

2013-08-12 Thread Thomas Huth
Am Mon, 12 Aug 2013 16:03:24 +1000 schrieb Benjamin Herrenschmidt : > On Mon, 2013-08-12 at 10:07 +0530, Prerna Saxena wrote: > > .../... > > > I dont know what context lead to this observation. > > However, PAPR mentions the following nomenclature guideline: > > > > "The value of this propert

[Qemu-devel] [RFC 05/14] tcg-aarch64: Support andc, orc, eqv, not

2013-08-12 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.c | 44 tcg/aarch64/tcg-target.h | 16 2 files changed, 52 insertions(+), 8 deletions(-) diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c index 3640486..7aeb3

[Qemu-devel] [PATCH for-1.6] mips_malta: do not raise exceptions when accessing invalid memory

2013-08-12 Thread Aurelien Jarno
Since commit c658b94f6e8c206c59d02aa6fbac285b86b53d2c, MIPS raises exceptions when accessing invalid memory. This is not the correct behaviour for MIPS Malta Core LV, as the GT-64120A system controller just ignore undecoded access. This feature is used by the Linux kernel to probe for some devices.

Re: [Qemu-devel] [PATCH v2] pc: drop external DSDT loading

2013-08-12 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > On Mon, Aug 12, 2013 at 10:20:41AM -0500, Anthony Liguori wrote: >> "Michael S. Tsirkin" writes: >> >> > On Mon, Aug 12, 2013 at 09:01:44AM -0500, Anthony Liguori wrote: >> >> This breaks migration and is unneeded with modern SeaBIOS. >> >> >> >> Signed-off-by: A

Re: [Qemu-devel] SCSI bus failures with qemu-arm in kernel 3.8+

2013-08-12 Thread Russell King - ARM Linux
On Mon, Aug 12, 2013 at 06:33:28PM +0100, Peter Maydell wrote: > /* Slot to IRQ mapping for RealView EB and PB1176 backplane > * nameslotIntAIntBIntCIntD > * A 31 IRQ50 IRQ51 IRQ48 IRQ49 > * B 30 IRQ49 IRQ50 IRQ51

Re: [Qemu-devel] SCSI bus failures with qemu-arm in kernel 3.8+

2013-08-12 Thread Paul Gortmaker
On 13-08-11 08:40 PM, Guenter Roeck wrote: > On 08/11/2013 03:04 PM, Russell King - ARM Linux wrote: >> On Sun, Aug 11, 2013 at 08:54:43AM -0700, Guenter Roeck wrote: >>> Hi, >>> >>> trying to boot arm versatile images with qemu results in the following error >>> if I try to boot with a disk image.

Re: [Qemu-devel] [PATCH v2] pc: drop external DSDT loading

2013-08-12 Thread Michael S. Tsirkin
On Mon, Aug 12, 2013 at 02:59:24PM -0500, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > > > On Mon, Aug 12, 2013 at 10:20:41AM -0500, Anthony Liguori wrote: > >> "Michael S. Tsirkin" writes: > >> > >> > On Mon, Aug 12, 2013 at 09:01:44AM -0500, Anthony Liguori wrote: > >> >> This brea

Re: [Qemu-devel] [PATCH 0/2] qemu-timer: make qemu_timer_mod_ns() and qemu_timer_del() thread-safe

2013-08-12 Thread Benoît Canet
Hi Stefan, Is there a git tree on which I could rebase my throttling series on top of the new timers ? Best Regards Benoît > Le Monday 12 Aug 2013 à 14:49:27 (+0200), Stefan Hajnoczi a écrit : > These patches are based on Alex Bligh's v10 AioContext timers series. > > The purpose of these pat

Re: [Qemu-devel] [PATCH for-1.6] mips_malta: do not raise exceptions when accessing invalid memory

2013-08-12 Thread Stefan Weil
Am 12.08.2013 21:44, schrieb Aurelien Jarno: > Since commit c658b94f6e8c206c59d02aa6fbac285b86b53d2c, MIPS raises > exceptions when accessing invalid memory. This is not the correct > behaviour for MIPS Malta Core LV, as the GT-64120A system controller > just ignore undecoded access. This feature i

Re: [Qemu-devel] [Qemu-stable] Possible bug in qemu-1.4.2: boot=off not honoured for -drive instances of virtio-scsi devices?

2013-08-12 Thread Michael Roth
Quoting George Diamantopoulos (2013-06-26 12:48:20) > Hello, > >I've been testing out qemu-kvm 1.4.2 with virtio-scsi drives and I think I >might have encountered a bug. The VM is configured with: 1) a virtio-blk >drive, which is the one I want to boot, 2) another virtio-blk cdrom driv

Re: [Qemu-devel] SCSI bus failures with qemu-arm in kernel 3.8+

2013-08-12 Thread Peter Maydell
On 12 August 2013 21:06, Russell King - ARM Linux wrote: > On Mon, Aug 12, 2013 at 06:33:28PM +0100, Peter Maydell wrote: >> /* Slot to IRQ mapping for RealView EB and PB1176 backplane >> * nameslotIntAIntBIntCIntD >> * A 31 IRQ50 IRQ51 IR

[Qemu-devel] [ANNOUNCE] QEMU 1.6.0-rc3 is now available

2013-08-12 Thread Anthony Liguori
Hi, On behalf of the QEMU Team, I'd like to announce the availability of the fourth release candidate for the QEMU 1.6 release. This release is meant for testing purposes and should not be used in a production environment. http://wiki.qemu.org/download/qemu-1.6.0-rc3.tar.bz2 You can help improv

Re: [Qemu-devel] SCSI bus failures with qemu-arm in kernel 3.8+

2013-08-12 Thread Peter Maydell
On 12 August 2013 20:02, Paul Gortmaker wrote: > > If I recall correctly, I'd showed the patch to Russell at the time (via > IRC, I believe) and he'd told me essentially the same thing as the above > paragraph, which is why I didn't put it in the patch system, and why the > commit log of the yocto

Re: [Qemu-devel] [PATCH for-1.6] mips_malta: do not raise exceptions when accessing invalid memory

2013-08-12 Thread Aurelien Jarno
On Mon, Aug 12, 2013 at 10:38:54PM +0200, Stefan Weil wrote: > Am 12.08.2013 21:44, schrieb Aurelien Jarno: > > Since commit c658b94f6e8c206c59d02aa6fbac285b86b53d2c, MIPS raises > > exceptions when accessing invalid memory. This is not the correct > > behaviour for MIPS Malta Core LV, as the GT-64

Re: [Qemu-devel] [PATCH 0/2] qemu-timer: make qemu_timer_mod_ns() and qemu_timer_del() thread-safe

2013-08-12 Thread Alex Bligh
Benoit, --On 12 August 2013 22:31:34 +0200 Benoît Canet wrote: Is there a git tree on which I could rebase my throttling series on top of the new timers ? API wise, mine should do, at: https://github.com/abligh/qemu/tree/aio-timers10 That won't have Stefan's thread-safe stuff in but that

[Qemu-devel] [PATCH for-1.6] rdma: silly ipv6 bugfix

2013-08-12 Thread mrhines
From: "Michael R. Hines" My bad - but it's very important for us to warn the user that IPv6 is broken on RoCE in linux right now, until linux releases a fixed version. Signed-off-by: Michael R. Hines --- migration-rdma.c |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] [v3] target-ppc: Enhance CPU nodes of device tree to be PAPR compliant.

2013-08-12 Thread Benjamin Herrenschmidt
On Mon, 2013-08-12 at 21:17 +0200, Thomas Huth wrote: > Am Mon, 12 Aug 2013 16:03:24 +1000 > schrieb Benjamin Herrenschmidt : > > > On Mon, 2013-08-12 at 10:07 +0530, Prerna Saxena wrote: > > > > .../... > > > > > I dont know what context lead to this observation. > > > However, PAPR mentions t

Re: [Qemu-devel] SCSI bus failures with qemu-arm in kernel 3.8+

2013-08-12 Thread Russell King - ARM Linux
On Mon, Aug 12, 2013 at 09:49:54PM +0100, Peter Maydell wrote: > On 12 August 2013 21:06, Russell King - ARM Linux > wrote: > > On Mon, Aug 12, 2013 at 06:33:28PM +0100, Peter Maydell wrote: > >> /* Slot to IRQ mapping for RealView EB and PB1176 backplane > >> * nameslotIntA

Re: [Qemu-devel] SCSI bus failures with qemu-arm in kernel 3.8+

2013-08-12 Thread Peter Maydell
On 12 August 2013 22:21, Russell King - ARM Linux wrote: > On Mon, Aug 12, 2013 at 09:49:54PM +0100, Peter Maydell wrote: >> On 12 August 2013 21:06, Russell King - ARM Linux >> wrote: >> > On Mon, Aug 12, 2013 at 06:33:28PM +0100, Peter Maydell wrote: >> >> /* Slot to IRQ mapping for RealVie

[Qemu-devel] [PATCH for-1.6] isapc: disable kvmvapic

2013-08-12 Thread Paolo Bonzini
vapic requires the VAPIC ROM to be mapped into RAM. This is not possible without PAM hardware. This fixes a segmentation fault running with -M isapc. Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini --- diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index a19e172..3aa244a 100644 ---

Re: [Qemu-devel] [PATCH v2 for-1.6 v2 2/2] loader: put FW CFG ROM files into RAM

2013-08-12 Thread Paolo Bonzini
Il 12/08/2013 20:37, Peter Maydell ha scritto: > > I seem to recall having a conversation with Paolo along these > lines a few months back (we fixed the exynos devices which > were incorrectly using the _ram_ptr function); he can correct > me if I'm off-base here. Yeah, I think you're right. Pao

Re: [Qemu-devel] [PATCH 5/8] vfio: Add guest side IOMMU support

2013-08-12 Thread Alex Williamson
On Wed, 2013-08-07 at 18:21 +1000, Alexey Kardashevskiy wrote: > This patch uses the new IOMMU notifiers to allow VFIO pass through devices > to work with guest side IOMMUs, as long as the host-side VFIO iommu has > sufficient capability and granularity to match the guest side. This works > by trac

Re: [Qemu-devel] [PATCH 6/8] spapr vfio: add vfio_container_spapr_get_info()

2013-08-12 Thread Alex Williamson
On Wed, 2013-08-07 at 18:21 +1000, Alexey Kardashevskiy wrote: > As sPAPR platform supports DMA windows on a PCI bus, the information > about their location and size should be passed into the guest via > the device tree. > > The patch adds a helper to read this info from the container fd. > > Sig

Re: [Qemu-devel] [PATCH 3/8] vfio: Introduce VFIO address spaces

2013-08-12 Thread Alex Williamson
On Wed, 2013-08-07 at 18:21 +1000, Alexey Kardashevskiy wrote: > From: David Gibson > > The only model so far supported for VFIO passthrough devices is the model > usually used on x86, where all of the guest's RAM is mapped into the > (host) IOMMU and there is no IOMMU visible in the guest. > >

Re: [Qemu-devel] SCSI bus failures with qemu-arm in kernel 3.8+

2013-08-12 Thread Russell King - ARM Linux
On Mon, Aug 12, 2013 at 10:36:17PM +0100, Peter Maydell wrote: > On this point, yes. Equivalent bit from the PB926 TRM: > http://infocenter.arm.com/help/topic/com.arm.doc.dui0224i/Cacdijji.html > > (There are differences between the PCI controllers on > the different boards. Differences I know of

[Qemu-devel] [PATCH v3 0/2] future proof rom loading for cross versiom migration

2013-08-12 Thread Michael S. Tsirkin
Changes from v2: address comments on v2 by Peter Maydell - switch from global constant to function - use memory_region_init_ram instead of _ram_ptr - disable for 1.6 Changes from v1: address comments by Peter Maydell - drop useless data=data line - rename target_page_size to mi

[Qemu-devel] [PATCH v3 2/2] loader: put FW CFG ROM files into RAM

2013-08-12 Thread Michael S. Tsirkin
ROM files that are put in FW CFG are copied to guest ram, by BIOS, but they are not backed by RAM so they don't get migrated. Each time we change two bytes in such a ROM this breaks cross-version migration: since we can migrate after BIOS has read the first byte but before it has read the second o

Re: [Qemu-devel] [SeaBIOS] [PATCH] acpi: hide 64-bit PCI hole for Windows XP

2013-08-12 Thread Kevin O'Connor
On Mon, Aug 12, 2013 at 08:05:08AM +0200, Gerd Hoffmann wrote: > We'll need some way to make sure the pmbase (also mmconf xbar) set by > the firmware matches the pmbase address filled into the acpi tables by > qemu ... > > So the options we have are: > > (1) Hardcode the address everywhere. Th

[Qemu-devel] [PATCH v3 1/2] memory: export migration page size

2013-08-12 Thread Michael S. Tsirkin
Migration code assumes that each RAM block is a multiple of target page size. We can fix this in a variety of ways, the simplest way is exporting the required page size so callers can make regions large enough. Signed-off-by: Michael S. Tsirkin --- arch_init.c | 6 ++ include/exec/

Re: [Qemu-devel] [PATCH 09/26] ide: Set BSY bit during FLUSH

2013-08-12 Thread Michael Roth
Quoting Alex Williamson (2013-07-03 16:51:56) > On Wed, 2013-07-03 at 15:16 -0500, Michael Roth wrote: > > On Wed, Jul 3, 2013 at 3:10 PM, Alex Williamson > > wrote: > > > On Wed, 2013-06-12 at 16:41 -0500, Michael Roth wrote: > > >> From: Andreas Färber > > >> > > >> The implementation of the AT

Re: [Qemu-devel] SCSI bus failures with qemu-arm in kernel 3.8+

2013-08-12 Thread Guenter Roeck
On Mon, Aug 12, 2013 at 11:12:50PM +0100, Russell King - ARM Linux wrote: > On Mon, Aug 12, 2013 at 10:36:17PM +0100, Peter Maydell wrote: > > On this point, yes. Equivalent bit from the PB926 TRM: > > http://infocenter.arm.com/help/topic/com.arm.doc.dui0224i/Cacdijji.html > > > > (There are diffe

Re: [Qemu-devel] SCSI bus failures with qemu-arm in kernel 3.8+

2013-08-12 Thread Guenter Roeck
On Mon, Aug 12, 2013 at 11:12:50PM +0100, Russell King - ARM Linux wrote: > On Mon, Aug 12, 2013 at 10:36:17PM +0100, Peter Maydell wrote: > > On this point, yes. Equivalent bit from the PB926 TRM: > > http://infocenter.arm.com/help/topic/com.arm.doc.dui0224i/Cacdijji.html > > > > (There are diffe

Re: [Qemu-devel] [PATCH 09/26] ide: Set BSY bit during FLUSH

2013-08-12 Thread Michael Roth
Quoting Michael Roth (2013-08-12 17:43:00) > Quoting Alex Williamson (2013-07-03 16:51:56) > > On Wed, 2013-07-03 at 15:16 -0500, Michael Roth wrote: > > > On Wed, Jul 3, 2013 at 3:10 PM, Alex Williamson > > > wrote: > > > > On Wed, 2013-06-12 at 16:41 -0500, Michael Roth wrote: > > > >> From: And

Re: [Qemu-devel] [Bug 1205156] [NEW] Errors while compiling version 1.5.2

2013-08-12 Thread Michael Roth
Quoting Stefan Weil (2013-07-26 00:12:59) > Am 26.07.2013 04:03, schrieb jean-christophe manciot: > > Public bug reported: > > > > Environment: Ubuntu 13.04 > > > > "hw/ide/macio.c: In function ‘pmac_ide_atapi_transfer_cb’: > > hw/ide/macio.c:134:9: error: format ‘%lx’ expects argument of type ‘lon

Re: [Qemu-devel] [Bug 1205156] [NEW] Errors while compiling version 1.5.2

2013-08-12 Thread Michael Roth
Quoting Michael Roth (2013-08-12 20:05:32) > Quoting Stefan Weil (2013-07-26 00:12:59) > > Am 26.07.2013 04:03, schrieb jean-christophe manciot: > > > Public bug reported: > > > > > > Environment: Ubuntu 13.04 > > > > > > "hw/ide/macio.c: In function ‘pmac_ide_atapi_transfer_cb’: > > > hw/ide/macio

[Qemu-devel] [PATCH v2 1/4] vmdk: fix L1 and L2 table size in vmdk3 open

2013-08-12 Thread Fam Zheng
VMDK3 header has the field l1dir_size, but vmdk_open_vmdk3 hardcoded the value. This patch honors the header field. And the L2 table size is 4096 according to VMDK spec[1], instead of 1 << 9 (512). [1]: http://www.vmware.com/support/developer/vddk/vmdk_50_technote.pdf?src=vmdk Signed-off-by: Fam

[Qemu-devel] [PATCH v2 0/4] vmdk: Support ESX files

2013-08-12 Thread Fam Zheng
This series add support for VMFS and VMFSSPARSE extents, these types are found in description file from ESX hosts. - VMFS is in monolithiFlat format (raw), but hosted in ESX. - VMFSSPARSE is the format we call "vmdk3" with magic bytes "COWD". There's no reason to open a image of the same typ

[Qemu-devel] [PATCH v2 2/4] vmdk: support vmfsSparse files

2013-08-12 Thread Fam Zheng
VMware ESX hosts use a variant of the VMDK3 format, identified by the vmfsSparse create type ad the VMFSSPARSE extent type. It has 16 KB grain tables (L2) and a variable-size grain directory (L1). In addition, the grain size is always 512, but that is not a problem because it is included in the he

[Qemu-devel] [PATCH v2 4/4] vmdk: Move l1_size check into vmdk_add_extent()

2013-08-12 Thread Fam Zheng
This header check is common to VMDK3 and VMDK4, so move it into vmdk_add_extent(). Signed-off-by: Fam Zheng --- block/vmdk.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index b653e2e..63b489d 100644 --- a/block/vmdk.c +++ b/blo

[Qemu-devel] [PATCH v2 3/4] vmdk: support vmfs files

2013-08-12 Thread Fam Zheng
From: Paolo Bonzini VMware ESX hosts also use different create and extent types for flat files, respectively "vmfs" and "VMFS". This is not documented, but it can be found at http://kb.vmware.com/kb/10002511 (Recreating a missing virtual machine disk (VMDK) descriptor file). Signed-off-by: Paol

Re: [Qemu-devel] [PATCH] qemu-char: fix infinite recursion connecting to monitor pty

2013-08-12 Thread Michael Roth
Quoting James Hogan (2013-08-08 06:09:38) > Since commit bd5c51e (qemu-char: don't issue CHR_EVENT_OPEN in a BH), an > infinite recursion occurs when putting the monitor on a pty (-monitor > pty) and connecting a terminal to the slave port. > > This is because of the qemu_chr_be_event(s, CHR_EVENT

[Qemu-devel] [PATCH] rdma: clean up of qemu_rdma_cleanup()

2013-08-12 Thread Isaku Yamahata
- It can't be determined by RDMAContext::cm_id != NULL if the connection is established or not. - RDMAContext::cm_id is leaked and not destroyed because it is set to NULL too early. - RDMAContext::qp is created by rdma_create_qp() so that it should be destroyed by rdma_destroy_qp(). not ibv_d

Re: [Qemu-devel] Are there plans to achieve ram live Snapshot feature?

2013-08-12 Thread Wenchao Xia
于 2013-8-12 19:33, Stefan Hajnoczi 写道: On Mon, Aug 12, 2013 at 12:26 PM, Alex Bligh wrote: --On 12 August 2013 11:59:03 +0200 Stefan Hajnoczi wrote: The idea that was discussed on qemu-devel@nongnu.org uses fork(2) to capture the state of guest RAM and then send it back to the parent process

[Qemu-devel] [PATCH 0/3] slirp: fill mainloop with more precise timeout value

2013-08-12 Thread Liu Ping Fan
These patches is separated from "[PATCH v1 0/5] make slirp subsystem self-contained", as Paolo suggested. lists.nongnu.org/archive/html/qemu-devel/2013-08/msg00980.html With them, we can fill the timeout of mainloop more precise, when slirp has to emulate tcp timeout problem. Liu Ping Fan (

[Qemu-devel] [PATCH 1/3] slirp: make timeout local

2013-08-12 Thread Liu Ping Fan
Each slirp has its own time to caculate timeout. Signed-off-by: Liu Ping Fan --- slirp/slirp.c | 22 ++ slirp/slirp.h | 3 +++ 2 files changed, 13 insertions(+), 12 deletions(-) diff --git a/slirp/slirp.c b/slirp/slirp.c index 80b28ea..55654d5 100644 --- a/slirp/slirp.c +++

[Qemu-devel] [PATCH 2/3] slirp: define timeout as macro

2013-08-12 Thread Liu Ping Fan
Signed-off-by: Liu Ping Fan --- slirp/slirp.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/slirp/slirp.c b/slirp/slirp.c index 55654d5..1deaad9 100644 --- a/slirp/slirp.c +++ b/slirp/slirp.c @@ -47,6 +47,9 @@ static QTAILQ_HEAD(slirp_instances, Slirp) slirp_instances

[Qemu-devel] [PATCH 3/3] slirp: fill mainloop timeout with more precise value

2013-08-12 Thread Liu Ping Fan
If slirp needs to emulate tcp timeout, then the timeout value for mainloop should be more precise, which is determined by slirp's fasttimo or slowtimo. Signed-off-by: Liu Ping Fan --- main-loop.c | 2 +- slirp/slirp.c | 18 ++ 2 files changed, 19 insertions(+), 1 deletion(-)

Re: [Qemu-devel] SCSI bus failures with qemu-arm in kernel 3.8+

2013-08-12 Thread Guenter Roeck
On Mon, Aug 12, 2013 at 05:24:50PM +0100, Peter Maydell wrote: [ ... ] > If somebody would like to fix the kernel I am happy to > locate the PCI backplane and test everything (again). > I would suggest that producing some patches which work > with QEMU 1.5 or later would be a good start; then we

Re: [Qemu-devel] [Bug 1205156] [NEW] Errors while compiling version 1.5.2

2013-08-12 Thread Alexander Graf
Am 13.08.2013 um 03:07 schrieb Michael Roth : > Quoting Michael Roth (2013-08-12 20:05:32) >> Quoting Stefan Weil (2013-07-26 00:12:59) >>> Am 26.07.2013 04:03, schrieb jean-christophe manciot: Public bug reported: Environment: Ubuntu 13.04 "hw/ide/macio.c: In function

[Qemu-devel] [PATCH] pseries: Fix stalls on hypervisor virtual console

2013-08-12 Thread Anton Blanchard
A number of users are reporting stalls when using the pseries hypervisor virtual console. A simple test case is to paste 15 or 17 characters at a time into the console. Pasting 15 characters at a time works fine but pasting 17 characters hangs for a random amount of time. Other activity (network,

Re: [Qemu-devel] [PATCH 1/8] virtio_get_byteswap: function for endian-ambivalent targets using virtio.

2013-08-12 Thread Rusty Russell
Anthony Liguori writes: > Benjamin Herrenschmidt writes: > >> On Mon, 2013-08-12 at 17:29 +0930, Rusty Russell wrote: >>> virtio data structures are defined as "target endian", which assumes >>> that's a fixed value. In fact, that actually means it's >>> platform-specific. >>> >>> Hopefully the

[Qemu-devel] [PATCH V18 00/25] replace QEMUOptionParameter with QemuOpts parser

2013-08-12 Thread Dong Xu Wang
v17->v18: 1) split into small patches, by each image format. 2) opt->str store digit, without suffixes in QemuOpt Dong Xu Wang (25): qemu-option: add def_value_str in QemuOptDesc struct and rewrite qemu_opts_print qemu-option: avoid duplication of default value in QemuOpts qemu-option: c

[Qemu-devel] [PATCH V18 03/25] qemu-option: create four QemuOptsList related functions

2013-08-12 Thread Dong Xu Wang
This patch creates 4 functions, count_opts_list, qemu_opts_append, qemu_opts_free and qemu_opts_print_help, they are used in following commits. v16->v17: 1) fix indentation. 2) fix typo. v15->v16: 1) discard double-initialization. 2) use pointer directly, not g_strdup. v12->v13: 1) simply assert

<    1   2   3   >