Re: [Qemu-devel] RFC: [PATCH 0/5] Explicitly annotating coroutine_fn functions

2013-08-06 Thread Gabriel Kerneis
On Mon, Aug 05, 2013 at 08:44:02PM +0200, Charlie Shepherd wrote: > This patch series is a follow up to a previous RFC about converting functions > that dynamically yield execution depending on whether they are in executing in > a coroutine context or not to be explicitly statically annotated. Ano

Re: [Qemu-devel] [PATCH 10/16] dimm: add busy slot check and slot auto-allocation

2013-08-06 Thread Markus Armbruster
Paolo Bonzini writes: > Il 26/07/2013 14:51, Igor Mammedov ha scritto: >> On Fri, 26 Jul 2013 11:26:16 +0200 >> Paolo Bonzini wrote: >> >>> Il 26/07/2013 09:38, Igor Mammedov ha scritto: Perhaps denying memory add and suggesting node migration to a node with more memory would be right

Re: [Qemu-devel] [PATCH] configure: disable clang -Wstring-plus-int warning

2013-08-06 Thread Markus Armbruster
Peter Maydell writes: > Some versions of clang will warn about adding integers to strings: > > disas/i386.c:4753:23: error: adding 'char' to a string does not append > to the string [-Werror,-Wstring-plus-int] > oappend ("%es:" + intel_syntax); >~~~^~ >

Re: [Qemu-devel] [PATCH qom-next for-next 0/5] QOM PCMCIA, MicroDrive and IDE cleanups

2013-08-06 Thread Markus Armbruster
Andreas Färber writes: > Hello, > > Based on an initial draft from Othmar Pasteka, this series QOM'ifies > MicroDrive. > As a prerequisite, PCMCIA must be QOM'ified as pointed out by Peter. We can > then > finally drop ide_init2_with_non_qdev_drives(), as desired by Markus for his > IDE refacto

Re: [Qemu-devel] [PATCH 2/4] timer: protect timers_state's clock with seqlock

2013-08-06 Thread Paolo Bonzini
On 08/06/2013 07:58 AM, liu ping fan wrote: On Mon, Aug 5, 2013 at 9:29 PM, Paolo Bonzini wrote: In kvm mode, vm_clock may be read outside BQL. Not just in KVM mode (we will be able to use dataplane with TCG sooner or later), actually. Oh. But this patch does not fix cpu_get_icount()'s th

Re: [Qemu-devel] [SeaBIOS] [PATCH] don't expose pvpanic device in the UI

2013-08-06 Thread Gleb Natapov
On Mon, Aug 05, 2013 at 09:32:18PM +0300, Michael S. Tsirkin wrote: > > > As you see we do let people change many parameters > > > that do affect activation. > > By editing XML user can shoot himself in the foot, we should not prevent > > that. > > So that's what I'm saying basically. > At the mom

Re: [Qemu-devel] [sheepdog] [PATCH] sheepdog: add missing .bdrv_has_zero_init

2013-08-06 Thread MORITA Kazutaka
At Tue, 6 Aug 2013 14:44:37 +0800, Liu Yuan wrote: > > Cc: Kevin Wolf > Cc: Stefan Hajnoczi > Signed-off-by: Liu Yuan > --- > block/sheepdog.c |2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: MORITA Kazutaka

[Qemu-devel] [PATCH v4 00/10] vmdk: Input validation fixes

2013-08-06 Thread Fam Zheng
Fixes for VMDK sparse file opening and other bugs. Header fields are checked before used for memory allocation. v4: 01: Added, fix variable scope bug of ret code. 02: Squashed two QEMU_PACKED patches. 03: Make BDRVVmdkState.desc_offset uint64_t as well. 10: Comment num_gtes_per_gte

[Qemu-devel] [PATCH v4 01/10] vmdk: remove ret from inner scope.

2013-08-06 Thread Fam Zheng
A inner scope "ret" variable hides the real return code, it will always return VMDK_OK for bs->backing_hd. Fix this by removing the declaration. Signed-off-by: Fam Zheng --- block/vmdk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 375

[Qemu-devel] [PATCH v4 02/10] vmdk: Make VMDK3Header and VmdkGrainMarker QEMU_PACKED

2013-08-06 Thread Fam Zheng
It's best to make it consistent that all on disk structures are QEMU_PACKED. Signed-off-by: Fam Zheng --- block/vmdk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index f42657b..8b86fe9 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -62,7

[Qemu-devel] [PATCH v4 03/10] vmdk: use unsigned values for on disk header fields

2013-08-06 Thread Fam Zheng
The size and offset fields are all non-negative values, use uint64_t for them to avoid getting negative in memory value by int overflow. Signed-off-by: Fam Zheng --- block/vmdk.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/block/vmdk.c b/block/v

[Qemu-devel] [PATCH v4 10/10] vmdk: rename num_gtes_per_gte to num_gtes_per_gt

2013-08-06 Thread Fam Zheng
num_gtes_per_gte is a historical typo, rename it to a more sensible name. It means "number of GrainTableEntries per GrainTable". Signed-off-by: Fam Zheng --- block/vmdk.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 39f5a

[Qemu-devel] [PATCH v4 05/10] qemu-iotests: add empty test case for vmdk

2013-08-06 Thread Fam Zheng
Will add vmdk specific tests later here. Signed-off-by: Fam Zheng --- tests/qemu-iotests/059 | 51 ++ tests/qemu-iotests/059.out | 2 ++ tests/qemu-iotests/group | 1 + 3 files changed, 54 insertions(+) create mode 100755 tests/qemu-iotests/05

[Qemu-devel] [PATCH v4 07/10] vmdk: check l2 table size when opening

2013-08-06 Thread Fam Zheng
header.num_gtes_per_gte determines size for L2 table. Check for too big value before using it. Limit to 512M entries (2GB per one L2 table). Signed-off-by: Fam Zheng --- block/vmdk.c | 5 + tests/qemu-iotests/059 | 7 +++ tests/qemu-iotests/059.out | 6 ++ 3 files c

[Qemu-devel] [PATCH v4 09/10] vmdk: use heap allocation for whole_grain

2013-08-06 Thread Fam Zheng
We should never grow the stack beyond 1 MB, otherwise we'll fall off the end. Thread stacks and coroutine stacks (1 MB) do not grow. get_cluster_offset() allocates a big stack offset, it will fail for big cluster images, change to heap allocated buffer. Signed-off-by: Fam Zheng --- block/vmdk.c

[Qemu-devel] [PATCH v4 08/10] vmdk: check l1 size before opening image

2013-08-06 Thread Fam Zheng
L1 table size is calculated from capacity, granularity and l2 table size. If capacity is too big or later two are too small, the L1 table will be too big to allocate in memory. Limit it to a reasonable range. Signed-off-by: Fam Zheng --- block/vmdk.c | 8 tests/qemu-iotest

[Qemu-devel] [PATCH v4 06/10] vmdk: check granularity field in opening

2013-08-06 Thread Fam Zheng
Granularity is used to calculate the cluster size and allocate r/w buffer. Check the value from image before using it, so we don't abort() for unbounded memory allocation. Signed-off-by: Fam Zheng --- block/vmdk.c | 40 +++- tests/qemu-iotests/05

Re: [Qemu-devel] [PATCH v3 00/10] vmdk: Input validation fixes

2013-08-06 Thread Stefan Hajnoczi
On Tue, Aug 06, 2013 at 09:40:33AM +0800, Fam Zheng wrote: > Fixes for VMDK sparse file opening. Header fields are checked before used for > memory allocation. > > v3: > 00: Rebase to master. > 04: Drop unused line in test script. > 05: change vmdk_add_extent signature (uint64_t cluste

[Qemu-devel] [PATCH v4 04/10] qemu-iotests: add poke_file utility function

2013-08-06 Thread Fam Zheng
From: Stefan Hajnoczi The new poke_file function sets bytes at an offset in a file given a printf-style format string. It can be used to corrupt an image file for test coverage of error paths. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- tests/qemu-iotests/common.rc | 6 +

Re: [Qemu-devel] [PATCH for-1.6? v2 19/21] shix: Don't require firmware presence for qtest

2013-08-06 Thread Stefan Hajnoczi
On Mon, Aug 05, 2013 at 03:27:25PM +0200, Andreas Färber wrote: > Adopt error_report() while at it. > > Signed-off-by: Andreas Färber > --- > hw/block/tc58128.c | 10 ++ > hw/sh4/shix.c | 9 + > 2 files changed, 11 insertions(+), 8 deletions(-) Reviewed-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH for-1.6] qemu-img: Error out for excess arguments

2013-08-06 Thread Stefan Hajnoczi
On Mon, Aug 05, 2013 at 10:57:40AM +0200, Kevin Wolf wrote: > Don't silently ignore excess arguments at the end of the command line, > but error out instead. This can catch typos like 'resize test.img + 1G', > which doesn't increase the image size by 1G as intended, but truncates > the image to 1G.

Re: [Qemu-devel] [SeaBIOS] [PATCH] don't expose pvpanic device in the UI

2013-08-06 Thread Vadim Rozenfeld
- Original Message - From: "Gleb Natapov" To: "Vadim Rozenfeld" Cc: "Michael S. Tsirkin" , "Daniel P. Berrange" , "Marcel Apfelbaum" , seab...@seabios.org, qemu-devel@nongnu.org, "Gerd Hoffmann" , "Paolo Bonzini" , "Eric Blake" , "Andreas Färber" Sent: Tuesday, August 6, 2013 6:05:

Re: [Qemu-devel] [PATCH v6] e1000: add interrupt mitigation support

2013-08-06 Thread Stefan Hajnoczi
On Fri, Aug 02, 2013 at 06:30:52PM +0200, Vincenzo Maffione wrote: > This patch partially implements the e1000 interrupt mitigation mechanisms. > Using a single QEMUTimer, it emulates the ITR register (which is the newer > mitigation register, recommended by Intel) and approximately emulates > RADV

Re: [Qemu-devel] [PATCH v2] target-mips: fix decoding of microMIPS POOL32Axf instructions

2013-08-06 Thread Aurelien Jarno
On Mon, Aug 05, 2013 at 05:35:26PM +0100, Leon Alrae wrote: > Fix incorrect assumption that DSP and non-DSP versions of the following > instructions have the same encoding: > MULT, MULTU, MADD, MADDU, MSUB, MSUBU, MFHI, MFLO, MTHI, MTLO. > Correct the existing (non-DSP) instructions and add DSP equ

Re: [Qemu-devel] [sheepdog] [PATCH] sheepdog: add missing .bdrv_has_zero_init

2013-08-06 Thread Kevin Wolf
Am 06.08.2013 um 09:37 hat MORITA Kazutaka geschrieben: > At Tue, 6 Aug 2013 14:44:37 +0800, > Liu Yuan wrote: > > > > Cc: Kevin Wolf > > Cc: Stefan Hajnoczi > > Signed-off-by: Liu Yuan > > --- > > block/sheepdog.c |2 ++ > > 1 file changed, 2 insertions(+) > > Reviewed-by: MORITA Kazuta

Re: [Qemu-devel] [Patch] ARM: Add an L2 cache controller to KZM

2013-08-06 Thread Andreas Färber
Am 06.08.2013 02:00, schrieb pe...@chubb.wattle.id.au: >> "Andreas" == Andreas Färber writes: > > Andreas> Am 05.08.2013 11:18, schrieb Peter Maydell: >>> On 5 August 2013 02:21, Peter Chubb >>> wrote: Reads to unassigned memory now return non-zero (since patch 9b8c69243585). This

Re: [Qemu-devel] [PATCH for-1.6] qemu-iotests: filter QEMU version in monitor banner

2013-08-06 Thread Stefan Hajnoczi
On Mon, Aug 05, 2013 at 09:48:00AM -0600, Eric Blake wrote: > On 08/05/2013 07:00 AM, Stefan Hajnoczi wrote: > > Filter out the QEMU monitor version banner so that tests do not break > > when the QEMU version number is changed. > > > > Signed-off-by: Stefan Hajnoczi > > --- > > > +++ b/tests/qem

[Qemu-devel] [PATCH 0/6 v2] xics: reworks and in-kernel support

2013-08-06 Thread Alexey Kardashevskiy
Another try with XICS-KVM. The main change is this adds "xics-common" parent for emulated XICS and XICS-KVM. And many, many small changes, mostly to address Andreas comments. Migration from XICS to XICS-KVM and vice versa still works. Alexey Kardashevskiy (4): xics: add pre_save/post_load/cp

[Qemu-devel] [PATCH 6/6] xics-kvm: Support for in-kernel XICS interrupt controller

2013-08-06 Thread Alexey Kardashevskiy
From: David Gibson Recent (host) kernels support emulating the PAPR defined "XICS" interrupt controller system within KVM. This patch allows qemu to initialize and configure the in-kernel XICS, and keep its state in sync with qemu's XICS state as necessary. This should give considerable perform

[Qemu-devel] [PATCH 2/6] xics: add pre_save/post_load/cpu_setup dispatchers

2013-08-06 Thread Alexey Kardashevskiy
The upcoming support of in-kernel XICS will redefine migration callbacks for both ICS and ICP so classes and callback pointers are added. This adds a cpu_setup callback to the XICS device class (as XICS-KVM will do it different) and xics_dispatch_cpu_setup(). This also moves the place where xics_d

[Qemu-devel] [PATCH 1/6] target-ppc: Add helper for KVM_PPC_RTAS_DEFINE_TOKEN

2013-08-06 Thread Alexey Kardashevskiy
From: David Gibson Recent PowerKVM allows the kernel to intercept some RTAS calls from the guest directly. This is used to implement the more efficient in-kernel XICS for example. qemu is still responsible for assigning the RTAS token numbers however, and needs to tell the kernel which RTAS fun

[Qemu-devel] [PATCH 5/6] xics: split to xics and xics-common

2013-08-06 Thread Alexey Kardashevskiy
The upcoming XICS-KVM support will use bits of emulated XICS code. So this introduces new level of hierarchy - "xics-common" class. Both emulated XICS and XICS-KVM will inherit from it and override class callbacks when required. The new "xics-common" class implements: 1. replaces static "nr_irqs"

[Qemu-devel] [PATCH 4/6] xics: minor changes and cleanups

2013-08-06 Thread Alexey Kardashevskiy
Before XICS-KVM comes, it makes sense to clean up the emulated XICS a bit. This does: 1. add assert in ics_realize() 2. change variable names from "k" to more informative ones 3. add "const" to every TypeInfo 4. replace fprintf(stderr, ..."\n") with error_report 5. replace old style qdev_init_nofa

[Qemu-devel] [PATCH 3/6] xics: move registration of global state to realize()

2013-08-06 Thread Alexey Kardashevskiy
Registration of global state belongs into realize so move it there. Signed-off-by: Alexey Kardashevskiy --- hw/intc/xics.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/hw/intc/xics.c b/hw/intc/xics.c index c5dad2f..436c788 100644 --- a/hw/intc/xics.

Re: [Qemu-devel] [SeaBIOS] [PATCH] don't expose pvpanic device in the UI

2013-08-06 Thread Michael S. Tsirkin
On Tue, Aug 06, 2013 at 10:21:52AM +0300, Gleb Natapov wrote: > > If you see a mouse in a room, how likely is it that there's > > a single mouse there? > > > > This is a PV technology which to me looks like it was > > rushed through and not only set on by default, but > > without a way to disable

Re: [Qemu-devel] [PATCH for-next v2 01/22] object: Add OBJECT_GET_PARENT_CLASS() macro

2013-08-06 Thread Andreas Färber
Am 06.08.2013 07:54, schrieb Alexey Kardashevskiy: > On 08/01/2013 12:17 PM, Andreas Färber wrote: >> The object argument is currently unused and may be used to optimize the >> class lookup when needed. >> >> Inspired-by: Peter Crosthwaite >> Signed-off-by: Andreas Färber >> --- >> include/qom/o

Re: [Qemu-devel] [SeaBIOS] [PATCH] don't expose pvpanic device in the UI

2013-08-06 Thread Gleb Natapov
On Tue, Aug 06, 2013 at 04:03:17AM -0400, Vadim Rozenfeld wrote: > > > - Original Message - > From: "Gleb Natapov" > To: "Michael S. Tsirkin" > Cc: "Daniel P. Berrange" , "Marcel Apfelbaum" > , seab...@seabios.org, qemu-devel@nongnu.org, "Gerd > Hoffmann" , "Paolo Bonzini" , "Eric >

Re: [Qemu-devel] [PATCH v2 2/9] block: vhdx - add header update capability.

2013-08-06 Thread Kevin Wolf
Am 05.08.2013 um 17:09 hat Jeff Cody geschrieben: > On Mon, Aug 05, 2013 at 05:05:36PM +0200, Kevin Wolf wrote: > > Am 01.08.2013 um 05:23 hat Jeff Cody geschrieben: > > > This adds the ability to update the headers in a VHDX image, including > > > generating a new MS-compatible GUID. > > > > > >

Re: [Qemu-devel] [SeaBIOS] [PATCH] don't expose pvpanic device in the UI

2013-08-06 Thread Gleb Natapov
On Tue, Aug 06, 2013 at 11:33:10AM +0300, Michael S. Tsirkin wrote: > On Tue, Aug 06, 2013 at 10:21:52AM +0300, Gleb Natapov wrote: > > > If you see a mouse in a room, how likely is it that there's > > > a single mouse there? > > > > > > This is a PV technology which to me looks like it was > > >

Re: [Qemu-devel] [sheepdog] [PATCH] sheepdog: add missing .bdrv_has_zero_init

2013-08-06 Thread Liu Yuan
On Tue, Aug 06, 2013 at 10:24:42AM +0200, Kevin Wolf wrote: > Am 06.08.2013 um 09:37 hat MORITA Kazutaka geschrieben: > > At Tue, 6 Aug 2013 14:44:37 +0800, > > Liu Yuan wrote: > > > > > > Cc: Kevin Wolf > > > Cc: Stefan Hajnoczi > > > Signed-off-by: Liu Yuan > > > --- > > > block/sheepdog.c

Re: [Qemu-devel] [SeaBIOS] [PATCH] don't expose pvpanic device in the UI

2013-08-06 Thread Gleb Natapov
On Tue, Aug 06, 2013 at 04:14:36AM -0400, Vadim Rozenfeld wrote: > > > - Original Message - > From: "Gleb Natapov" > To: "Vadim Rozenfeld" > Cc: "Michael S. Tsirkin" , "Daniel P. Berrange" > , "Marcel Apfelbaum" , > seab...@seabios.org, qemu-devel@nongnu.org, "Gerd Hoffmann" > , "Pao

Re: [Qemu-devel] [PATCH 1/5] Add an explanation of when a function should be marked coroutine_fn

2013-08-06 Thread Stefan Hajnoczi
On Mon, Aug 05, 2013 at 08:44:03PM +0200, Charlie Shepherd wrote: > From: Charlie Shepherd > > Coroutine functions that can yield directly or indirectly should be annotated > with a coroutine_fn annotation. Add an explanation to that effect in > include/block/coroutine.h. > --- > include/block/c

Re: [Qemu-devel] [PATCH for-1.6? v2 00/21] qtest: Test all targets

2013-08-06 Thread Markus Armbruster
Andreas Färber writes: > Hello Anthony/Aurélien, > > This series extends test coverage to all 16 targets. > For now it tests that QOM type changes do not lead to QOM cast assertions. > > v2 extends it to cover virtually all machines (except Xen and pc*-x.y). > Where an fprintf() is touched, use e

Re: [Qemu-devel] [SeaBIOS] [PATCH] don't expose pvpanic device in the UI

2013-08-06 Thread Andreas Färber
Am 06.08.2013 10:36, schrieb Gleb Natapov: > On Tue, Aug 06, 2013 at 11:33:10AM +0300, Michael S. Tsirkin wrote: >> On Tue, Aug 06, 2013 at 10:21:52AM +0300, Gleb Natapov wrote: If you see a mouse in a room, how likely is it that there's a single mouse there? This is a PV techno

[Qemu-devel] [Bug 739785] Re: qemu-i386 user mode can't fork (bash: fork: Invalid argument)

2013-08-06 Thread Peter Maydell
Commits aa004f5f9 to 24cb36a61c (13 in total) are the patchset that fix this. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/739785 Title: qemu-i386 user mode can't fork (bash: fork: Invalid argumen

Re: [Qemu-devel] [PATCH] Test coroutine execution order

2013-08-06 Thread Kevin Wolf
Am 05.08.2013 um 21:11 hat Charlie Shepherd geschrieben: > This patch adds a test for coroutine execution order in test-coroutine - this > catches a bug in the CPC coroutine implementation. > > --- > tests/test-coroutine.c | 54 > ++ > 1 file chang

Re: [Qemu-devel] [PATCH qom-next for-next 0/6] QOM realize for IndustryPack

2013-08-06 Thread Alberto Garcia
On Fri, Aug 02, 2013 at 11:16:55PM +0200, Andreas Färber wrote: > This series converts IndustryPack devices to QOM realize/unrealize. > > It goes on to clean up file placement, promoting IndustryPack to use > its own subdirectory like PCI, ISA, virtio, etc. > Andreas Färber (6): > ipack: Conve

[Qemu-devel] [Bug 1204697] Re: guest disk accesses lead to ATA errors + host vcpu0 unhandled wrmsr/rdmsr

2013-08-06 Thread Michael Tokarev
The fix is in a62eaa26c1d6d48fbdc3ac1d32bd1314f5fdc8c9 "ahci: Fix FLUSH command", should be in 1.6 and 1.5.3. ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launch

Re: [Qemu-devel] [PATCH 3/5] Convert BlockDriver to explicit coroutine annotations

2013-08-06 Thread Kevin Wolf
Am 05.08.2013 um 22:05 hat Gabriel Kerneis geschrieben: > On Mon, Aug 05, 2013 at 08:33:10PM +0100, Charlie Shepherd wrote: > > Yes that does merit some explanation. > > Thanks for the details. > > > qemu_co_queue_run_restart is a bit different. It is only called from > > coroutine_swap in qemu-c

Re: [Qemu-devel] [PATCH for-1.6? v2 00/21] qtest: Test all targets

2013-08-06 Thread Andreas Färber
Am 06.08.2013 10:39, schrieb Markus Armbruster: > Andreas Färber writes: > >> Hello Anthony/Aurélien, >> >> This series extends test coverage to all 16 targets. >> For now it tests that QOM type changes do not lead to QOM cast assertions. >> >> v2 extends it to cover virtually all machines (excep

Re: [Qemu-devel] [PATCH 3/6] xics: move registration of global state to realize()

2013-08-06 Thread Andreas Färber
Am 06.08.2013 10:27, schrieb Alexey Kardashevskiy: > Registration of global state belongs into realize so move it there. > > Signed-off-by: Alexey Kardashevskiy Reviewed-by: Andreas Färber Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Gui

Re: [Qemu-devel] [PATCH 1/6] target-ppc: Add helper for KVM_PPC_RTAS_DEFINE_TOKEN

2013-08-06 Thread Andreas Färber
Am 06.08.2013 10:27, schrieb Alexey Kardashevskiy: > From: David Gibson > > Recent PowerKVM allows the kernel to intercept some RTAS calls from the > guest directly. This is used to implement the more efficient in-kernel > XICS for example. qemu is still responsible for assigning the RTAS token

Re: [Qemu-devel] [SeaBIOS] [PATCH] don't expose pvpanic device in the UI

2013-08-06 Thread Michael S. Tsirkin
On Tue, Aug 06, 2013 at 10:45:01AM +0200, Andreas Färber wrote: > Am 06.08.2013 10:36, schrieb Gleb Natapov: > > On Tue, Aug 06, 2013 at 11:33:10AM +0300, Michael S. Tsirkin wrote: > >> On Tue, Aug 06, 2013 at 10:21:52AM +0300, Gleb Natapov wrote: > If you see a mouse in a room, how likely is

[Qemu-devel] [RFC] [PATCHv6 08/16] aio / timers: Add QEMUTimerListGroup to AioContext

2013-08-06 Thread Alex Bligh
Add a QEMUTimerListGroup each AioContext (meaning a QEMUTimerList associated with each clock is added) and delete it when the AioContext is freed. Signed-off-by: Alex Bligh --- async.c |2 ++ include/block/aio.h |4 tests/test-aio.c |3 +++ tests/te

[Qemu-devel] [RFC] [PATCHv6 00/16] aio / timers: Add AioContext timers and use ppoll

2013-08-06 Thread Alex Bligh
This patch series adds support for timers attached to an AioContext clock which get called within aio_poll. In doing so it removes alarm timers and moves to use ppoll where possible. This patch set 'sort of' passes make check (see below for caveat) including a new test harness for the aio timers,

[Qemu-devel] [RFC] [PATCHv6 03/16] aio / timers: Add prctl(PR_SET_TIMERSLACK, 1, ...) to reduce timer slack

2013-08-06 Thread Alex Bligh
Where supported, called prctl(PR_SET_TIMERSLACK, 1, ...) to set one nanosecond timer slack to increase precision of timer calls. Signed-off-by: Alex Bligh --- configure| 18 ++ qemu-timer.c |7 +++ 2 files changed, 25 insertions(+) diff --git a/configure b/configur

[Qemu-devel] [RFC] [PATCHv6 04/16] aio / timers: Make qemu_run_timers and qemu_run_all_timers return progress

2013-08-06 Thread Alex Bligh
Make qemu_run_timers and qemu_run_all_timers return progress so that aio_poll etc. can determine whether a timer has been run. Signed-off-by: Alex Bligh --- include/qemu/timer.h |4 ++-- qemu-timer.c | 18 -- 2 files changed, 14 insertions(+), 8 deletions(-) diff -

[Qemu-devel] [RFC] [PATCHv6 09/16] aio / timers: Add a notify callback to QEMUTimerList

2013-08-06 Thread Alex Bligh
Add a notify pointer to QEMUTimerList so it knows what to notify on a timer change. Signed-off-by: Alex Bligh --- async.c |7 ++- include/qemu/timer.h |7 ++- qemu-timer.c | 24 ++-- 3 files changed, 34 insertions(+), 4 deletions(-) dif

[Qemu-devel] [RFC] [PATCHv6 05/16] aio / timers: Split QEMUClock into QEMUClock and QEMUTimerList

2013-08-06 Thread Alex Bligh
Split QEMUClock into QEMUClock and QEMUTimerList so that we can have more than one QEMUTimerList associated with the same clock. Introduce a default_timerlist concept and make existing qemu_clock_* calls that actually should operate on a QEMUTimerList call the relevant QEMUTimerList implementation

[Qemu-devel] [RFC] [PATCHv6 11/16] aio / timers: Convert aio_poll to use AioContext timers' deadline

2013-08-06 Thread Alex Bligh
Convert aio_poll to use deadline based on AioContext's timers. aio_poll has been changed to return accurately whether progress has occurred. Prior to this commit, aio_poll always returned true if g_poll was entered, whether or not any progress was made. This required a change to tests/test-aio.c w

[Qemu-devel] [RFC] [PATCHv6 06/16] aio / timers: Untangle include files

2013-08-06 Thread Alex Bligh
include/qemu/timer.h has no need to include main-loop.h and doing so causes an issue for the next patch. Unfortunately various files assume including timers.h will pull in main-loop.h. Untangle this mess. Signed-off-by: Alex Bligh --- dma-helpers.c |1 + hw/dma/xilinx_axidma.c

[Qemu-devel] [RFC] [PATCHv6 10/16] aio / timers: aio_ctx_prepare sets timeout from AioContext timers

2013-08-06 Thread Alex Bligh
Calculate the timeout in aio_ctx_prepare taking into account the timers attached to the AioContext. Alter aio_ctx_check similarly. Signed-off-by: Alex Bligh --- async.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/async.c b/async.c index 8daa232..0a8a85b

[Qemu-devel] [RFC] [PATCHv6 02/16] aio / timers: add ppoll support with qemu_poll_ns

2013-08-06 Thread Alex Bligh
Add qemu_poll_ns which works like g_poll but takes a nanosecond timeout. Signed-off-by: Alex Bligh --- configure| 19 +++ include/qemu/timer.h |1 + qemu-timer.c | 24 3 files changed, 44 insertions(+) diff --git a/configure b

[Qemu-devel] [RFC] [PATCHv6 13/16] aio / timers: On timer modification, qemu_notify or aio_notify

2013-08-06 Thread Alex Bligh
On qemu_mod_timer_ns, ensure qemu_notify or aio_notify is called to end the appropriate poll(), irrespective of use_icount value. On qemu_clock_enable, ensure qemu_notify or aio_notify is called for all QEMUTimerLists attached to the QEMUClock. Signed-off-by: Alex Bligh --- include/qemu/timer.h

[Qemu-devel] [RFC] [PATCHv6 12/16] aio / timers: Convert mainloop to use timeout

2013-08-06 Thread Alex Bligh
Convert mainloop to use timeout from default timerlist group (i.e. the current 3 static timers) Signed-off-by: Alex Bligh --- main-loop.c | 45 ++--- 1 file changed, 34 insertions(+), 11 deletions(-) diff --git a/main-loop.c b/main-loop.c index a44fff6.

Re: [Qemu-devel] [PATCH 2/6] xics: add pre_save/post_load/cpu_setup dispatchers

2013-08-06 Thread Andreas Färber
Am 06.08.2013 10:27, schrieb Alexey Kardashevskiy: > The upcoming support of in-kernel XICS will redefine migration callbacks > for both ICS and ICP so classes and callback pointers are added. > > This adds a cpu_setup callback to the XICS device class (as XICS-KVM > will do it different) and xics

[Qemu-devel] [RFC] [PATCHv6 01/16] aio / timers: add qemu-timer.c utility functions

2013-08-06 Thread Alex Bligh
Add qemu_free_clock and expose qemu_new_clock and clock types. Add utility functions to qemu-timer.c for nanosecond timing. Add qemu_clock_deadline_ns to calculate deadlines to nanosecond accuracy. Add utility function qemu_soonest_timeout to calculate soonest deadline. Add qemu_timeout_ns_to_m

[Qemu-devel] [RFC] [PATCHv6 14/16] aio / timers: Use all timerlists in icount warp calculations

2013-08-06 Thread Alex Bligh
Notify all timerlists derived from vm_clock in icount warp calculations. When calculating timer delay based on vm_clock deadline, use all timerlists. For compatibility, maintain an apparent bug where when using icount, if no vm_clock timer was set, qemu_clock_deadline would return INT32_MAX and a

Re: [Qemu-devel] [RFC V3 0/2] continuous leaky bucket throttling

2013-08-06 Thread Fam Zheng
On Fri, 08/02 17:53, Benoît Canet wrote: > This patchset implement continous leaky bucket throttling. > > It works mostly on the general case. > The exception is where the load is composed of both reads and writes and two > limits iops_rd and iops_wr are set. > The resulting iops are a little abov

Re: [Qemu-devel] [SeaBIOS] [PATCH] don't expose pvpanic device in the UI

2013-08-06 Thread Michael S. Tsirkin
On Tue, Aug 06, 2013 at 11:36:25AM +0300, Gleb Natapov wrote: > On Tue, Aug 06, 2013 at 11:33:10AM +0300, Michael S. Tsirkin wrote: > > On Tue, Aug 06, 2013 at 10:21:52AM +0300, Gleb Natapov wrote: > > > > If you see a mouse in a room, how likely is it that there's > > > > a single mouse there? > >

Re: [Qemu-devel] [PATCH 3/5] Convert BlockDriver to explicit coroutine annotations

2013-08-06 Thread Kevin Wolf
Am 05.08.2013 um 20:44 hat Charlie Shepherd geschrieben: > This patch converts the .bdrv_open, .bdrv_file_open and .bdrv_create members > of struct BlockDriver > to be explicitly annotated as coroutine_fn, rather than yielding dynamically > depending on whether > they are executed in a coroutine

[Qemu-devel] [RFC] [PATCHv6 16/16] aio / timers: Add test harness for AioContext timers

2013-08-06 Thread Alex Bligh
Add a test harness for AioContext timers. The g_source equivalent is unsatisfactory as it suffers from false wakeups. Signed-off-by: Alex Bligh --- tests/test-aio.c | 134 ++ 1 file changed, 134 insertions(+) diff --git a/tests/test-aio.c b/t

[Qemu-devel] [RFC] [PATCHv6 15/16] aio / timers: Remove alarm timers

2013-08-06 Thread Alex Bligh
Remove alarm timers from qemu-timers.c now we use g_poll / ppoll instead. Signed-off-by: Alex Bligh --- include/qemu/timer.h |2 - main-loop.c |4 - qemu-timer.c | 500 +- vl.c |4 +- 4 files changed, 4

Re: [Qemu-devel] [SeaBIOS] [PATCH] don't expose pvpanic device in the UI

2013-08-06 Thread Gleb Natapov
On Tue, Aug 06, 2013 at 10:45:01AM +0200, Andreas Färber wrote: > Am 06.08.2013 10:36, schrieb Gleb Natapov: > > On Tue, Aug 06, 2013 at 11:33:10AM +0300, Michael S. Tsirkin wrote: > >> On Tue, Aug 06, 2013 at 10:21:52AM +0300, Gleb Natapov wrote: > If you see a mouse in a room, how likely is

Re: [Qemu-devel] [PATCH 4/6] xics: minor changes and cleanups

2013-08-06 Thread Andreas Färber
Am 06.08.2013 10:27, schrieb Alexey Kardashevskiy: > Before XICS-KVM comes, it makes sense to clean up the emulated XICS a bit. > > This does: > 1. add assert in ics_realize() > 2. change variable names from "k" to more informative ones > 3. add "const" to every TypeInfo > 4. replace fprintf(stder

Re: [Qemu-devel] [SeaBIOS] [PATCH] don't expose pvpanic device in the UI

2013-08-06 Thread Hu Tao
On Tue, Aug 06, 2013 at 11:33:10AM +0300, Michael S. Tsirkin wrote: > On Tue, Aug 06, 2013 at 10:21:52AM +0300, Gleb Natapov wrote: > > > If you see a mouse in a room, how likely is it that there's > > > a single mouse there? > > > > > > This is a PV technology which to me looks like it was > > >

[Qemu-devel] [RFC] [PATCHv6 07/16] aio / timers: Add QEMUTimerListGroup and helper functions

2013-08-06 Thread Alex Bligh
Add QEMUTimerListGroup and helper functions, to represent a QEMUTimerList associated with each clock. Add a default QEMUTimerListGroup representing the default timer lists which are not associated with any other object (e.g. an AioContext as added by future patches). Signed-off-by: Alex Bligh ---

[Qemu-devel] [RFC] [PATCHv6 00/16] aio / timers: Add AioContext timers and use ppoll

2013-08-06 Thread Alex Bligh
[ I managed to screw up the cover letter by including 2 diffstats; here's the fixed one] This patch series adds support for timers attached to an AioContext clock which get called within aio_poll. In doing so it removes alarm timers and moves to use ppoll where possible. This patch set 'sort o

Re: [Qemu-devel] [SeaBIOS] [PATCH] don't expose pvpanic device in the UI

2013-08-06 Thread Gleb Natapov
On Tue, Aug 06, 2013 at 05:26:46PM +0800, Hu Tao wrote: > On Tue, Aug 06, 2013 at 11:33:10AM +0300, Michael S. Tsirkin wrote: > > On Tue, Aug 06, 2013 at 10:21:52AM +0300, Gleb Natapov wrote: > > > > If you see a mouse in a room, how likely is it that there's > > > > a single mouse there? > > > >

Re: [Qemu-devel] [PATCH 2/4] timer: protect timers_state's clock with seqlock

2013-08-06 Thread Stefan Hajnoczi
On Mon, Aug 05, 2013 at 03:33:24PM +0800, Liu Ping Fan wrote: > diff --git a/cpus.c b/cpus.c > index 85e743d..ab92db9 100644 > --- a/cpus.c > +++ b/cpus.c > @@ -107,12 +107,17 @@ static int64_t qemu_icount; > typedef struct TimersState { > int64_t cpu_ticks_prev; > int64_t cpu_ticks_offs

Re: [Qemu-devel] [SeaBIOS] [PATCH] don't expose pvpanic device in the UI

2013-08-06 Thread Gleb Natapov
On Tue, Aug 06, 2013 at 12:21:48PM +0300, Michael S. Tsirkin wrote: > On Tue, Aug 06, 2013 at 11:36:25AM +0300, Gleb Natapov wrote: > > On Tue, Aug 06, 2013 at 11:33:10AM +0300, Michael S. Tsirkin wrote: > > > On Tue, Aug 06, 2013 at 10:21:52AM +0300, Gleb Natapov wrote: > > > > > If you see a mous

Re: [Qemu-devel] [PATCH 4/5] Convert block functions to coroutine versions

2013-08-06 Thread Kevin Wolf
Am 05.08.2013 um 20:44 hat Charlie Shepherd geschrieben: > This patch follows on from the previous one and converts some block layer > functions to be > explicitly annotated with coroutine_fn instead of yielding depending upon > calling context. > --- > block.c | 235 > +++

Re: [Qemu-devel] RFC: [PATCH 0/5] Explicitly annotating coroutine_fn functions

2013-08-06 Thread Kevin Wolf
Am 05.08.2013 um 20:44 hat Charlie Shepherd geschrieben: > This patch series is a follow up to a previous RFC about converting functions > that dynamically yield execution depending on whether they are in executing in > a coroutine context or not to be explicitly statically annotated. This change >

Re: [Qemu-devel] [Xen-devel] FW: Cirrus VGA slow screen update, show blank screen last 13s or so for windows XP guest

2013-08-06 Thread George Dunlap
On Mon, Aug 5, 2013 at 4:06 PM, Gonglei (Arei) wrote: >> -Original Message- >> From: dunl...@gmail.com [mailto:dunl...@gmail.com] On Behalf Of George >> Dunlap >> Sent: Monday, August 05, 2013 10:28 PM >> To: Gonglei (Arei) >> Cc: xen-de...@lists.xen.org; qemu-devel@nongnu.org; Anthony PER

Re: [Qemu-devel] [PATCH for-1.6? v2 00/21] qtest: Test all targets

2013-08-06 Thread Markus Armbruster
Andreas Färber writes: > Am 06.08.2013 10:39, schrieb Markus Armbruster: >> Andreas Färber writes: >> >>> Hello Anthony/Aurélien, >>> >>> This series extends test coverage to all 16 targets. >>> For now it tests that QOM type changes do not lead to QOM cast assertions. >>> >>> v2 extends it to

Re: [Qemu-devel] [PATCH 5/6] xics: split to xics and xics-common

2013-08-06 Thread Andreas Färber
Am 06.08.2013 10:27, schrieb Alexey Kardashevskiy: > The upcoming XICS-KVM support will use bits of emulated XICS code. > So this introduces new level of hierarchy - "xics-common" class. Both > emulated XICS and XICS-KVM will inherit from it and override class > callbacks when required. > > The ne

Re: [Qemu-devel] [SeaBIOS] [PATCH] don't expose pvpanic device in the UI

2013-08-06 Thread Markus Armbruster
Andreas Färber writes: > Am 06.08.2013 10:36, schrieb Gleb Natapov: >> On Tue, Aug 06, 2013 at 11:33:10AM +0300, Michael S. Tsirkin wrote: >>> On Tue, Aug 06, 2013 at 10:21:52AM +0300, Gleb Natapov wrote: > If you see a mouse in a room, how likely is it that there's > a single mouse there

Re: [Qemu-devel] [SeaBIOS] [PATCH] don't expose pvpanic device in the UI

2013-08-06 Thread Michael S. Tsirkin
On Tue, Aug 06, 2013 at 12:20:27PM +0300, Gleb Natapov wrote: > On Tue, Aug 06, 2013 at 10:45:01AM +0200, Andreas Färber wrote: > > Am 06.08.2013 10:36, schrieb Gleb Natapov: > > > On Tue, Aug 06, 2013 at 11:33:10AM +0300, Michael S. Tsirkin wrote: > > >> On Tue, Aug 06, 2013 at 10:21:52AM +0300, G

Re: [Qemu-devel] KVM call agenda for 2013-08-06

2013-08-06 Thread Michael S. Tsirkin
On Tue, Jul 23, 2013 at 06:31:45PM +0200, Juan Quintela wrote: > > Hi > > Please, send any topic that you are interested in covering. > > Thanks, Juan. > > PD. If you want to attend and you don't have the call details, > contact me. > > PD2. Remember that conference code has changed, c

Re: [Qemu-devel] [SeaBIOS] [PATCH] don't expose pvpanic device in the UI

2013-08-06 Thread Michael S. Tsirkin
On Tue, Aug 06, 2013 at 11:56:11AM +0200, Markus Armbruster wrote: > Andreas Färber writes: > > > Am 06.08.2013 10:36, schrieb Gleb Natapov: > >> On Tue, Aug 06, 2013 at 11:33:10AM +0300, Michael S. Tsirkin wrote: > >>> On Tue, Aug 06, 2013 at 10:21:52AM +0300, Gleb Natapov wrote: > > If you

Re: [Qemu-devel] [RFC] [PATCHv5 06/16] aio / timers: Untangle include files

2013-08-06 Thread Stefan Hajnoczi
On Sun, Aug 04, 2013 at 07:09:55PM +0100, Alex Bligh wrote: > include/qemu/timer.h has no need to include main-loop.h and > doing so causes an issue for the next patch. Unfortunately > various files assume including timers.h will pull in main-loop.h. > Untangle this mess. > > Signed-off-by: Alex B

Re: [Qemu-devel] [PATCH 6/6] xics-kvm: Support for in-kernel XICS interrupt controller

2013-08-06 Thread Andreas Färber
Am 06.08.2013 10:27, schrieb Alexey Kardashevskiy: > From: David Gibson > > Recent (host) kernels support emulating the PAPR defined "XICS" interrupt > controller system within KVM. This patch allows qemu to initialize and > configure the in-kernel XICS, and keep its state in sync with qemu's XI

Re: [Qemu-devel] [SeaBIOS] [PATCH] don't expose pvpanic device in the UI

2013-08-06 Thread Michael S. Tsirkin
On Tue, Aug 06, 2013 at 12:29:27PM +0300, Gleb Natapov wrote: > On Tue, Aug 06, 2013 at 05:26:46PM +0800, Hu Tao wrote: > > On Tue, Aug 06, 2013 at 11:33:10AM +0300, Michael S. Tsirkin wrote: > > > On Tue, Aug 06, 2013 at 10:21:52AM +0300, Gleb Natapov wrote: > > > > > If you see a mouse in a room,

Re: [Qemu-devel] [PATCH v6] e1000: add interrupt mitigation support

2013-08-06 Thread Vincenzo Maffione
Thank you guys for your support! Best regards, Vincenzo 2013/8/6 Stefan Hajnoczi : > On Fri, Aug 02, 2013 at 06:30:52PM +0200, Vincenzo Maffione wrote: >> This patch partially implements the e1000 interrupt mitigation mechanisms. >> Using a single QEMUTimer, it emulates the ITR register (which

Re: [Qemu-devel] [SeaBIOS] [PATCH] don't expose pvpanic device in the UI

2013-08-06 Thread Gleb Natapov
On Tue, Aug 06, 2013 at 01:13:17PM +0300, Michael S. Tsirkin wrote: > On Tue, Aug 06, 2013 at 12:29:27PM +0300, Gleb Natapov wrote: > > On Tue, Aug 06, 2013 at 05:26:46PM +0800, Hu Tao wrote: > > > On Tue, Aug 06, 2013 at 11:33:10AM +0300, Michael S. Tsirkin wrote: > > > > On Tue, Aug 06, 2013 at 1

Re: [Qemu-devel] [SeaBIOS] [PATCH] don't expose pvpanic device in the UI

2013-08-06 Thread Michael S. Tsirkin
On Tue, Aug 06, 2013 at 12:32:47PM +0300, Gleb Natapov wrote: > On Tue, Aug 06, 2013 at 12:21:48PM +0300, Michael S. Tsirkin wrote: > > On Tue, Aug 06, 2013 at 11:36:25AM +0300, Gleb Natapov wrote: > > > On Tue, Aug 06, 2013 at 11:33:10AM +0300, Michael S. Tsirkin wrote: > > > > On Tue, Aug 06, 201

Re: [Qemu-devel] [SeaBIOS] [PATCH] don't expose pvpanic device in the UI

2013-08-06 Thread Michael S. Tsirkin
On Tue, Aug 06, 2013 at 01:14:14PM +0300, Gleb Natapov wrote: > On Tue, Aug 06, 2013 at 01:13:17PM +0300, Michael S. Tsirkin wrote: > > On Tue, Aug 06, 2013 at 12:29:27PM +0300, Gleb Natapov wrote: > > > On Tue, Aug 06, 2013 at 05:26:46PM +0800, Hu Tao wrote: > > > > On Tue, Aug 06, 2013 at 11:33:1

Re: [Qemu-devel] KVM call agenda for 2013-08-06

2013-08-06 Thread Michael S. Tsirkin
On Tue, Aug 06, 2013 at 12:22:29PM +0200, Mauro Sanna wrote: > I want to subscribe from this list, where are istructions? https://lists.nongnu.org/mailman/listinfo/qemu-devel

Re: [Qemu-devel] [SeaBIOS] [PATCH] don't expose pvpanic device in the UI

2013-08-06 Thread Gleb Natapov
On Tue, Aug 06, 2013 at 01:23:26PM +0300, Michael S. Tsirkin wrote: > On Tue, Aug 06, 2013 at 01:14:14PM +0300, Gleb Natapov wrote: > > On Tue, Aug 06, 2013 at 01:13:17PM +0300, Michael S. Tsirkin wrote: > > > On Tue, Aug 06, 2013 at 12:29:27PM +0300, Gleb Natapov wrote: > > > > On Tue, Aug 06, 201

[Qemu-devel] [PATCH v3 for-qmp-1.6 2/4] dump: introduce GuestPhysBlockList

2013-08-06 Thread Laszlo Ersek
The vmcore must use physical addresses that are visible to the guest, not addresses that point into linear RAMBlocks. As first step, introduce the list type into which we'll collect the physical mappings in effect at the time of the dump. Related RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=9

  1   2   3   >