Re: [Qemu-devel] [PATCH V7 1/2] Implement sync modes for drive-backup.

2013-07-26 Thread Paolo Bonzini
Il 26/07/2013 03:09, Ian Main ha scritto: > +/* See if we have a backing HD we can use to create our new image > + * on top of. */ > +source = bs->backing_hd; > +if (!source && sync == MIRROR_SYNC_MODE_TOP) { > +sync = MIRROR_SYNC_MODE_FULL; > +} > + I understand why yo

Re: [Qemu-devel] [PATCH v2 2/2] full introspection support for QMP

2013-07-26 Thread Amos Kong
On Tue, Jul 16, 2013 at 02:18:37PM +0200, Paolo Bonzini wrote: > Il 16/07/2013 14:04, Amos Kong ha scritto: > >> > Thanks. I see this is unique, but it is also not too intuitive. > >> > > >> > So, could you add a "kind" field to DataObject that is an enum > >> > (list/dict/scalar, or something li

Re: [Qemu-devel] [PATCH v2 2/2] full introspection support for QMP

2013-07-26 Thread Amos Kong
On Wed, Jul 17, 2013 at 04:36:06PM -0400, Luiz Capitulino wrote: > On Tue, 16 Jul 2013 18:37:42 +0800 > Amos Kong wrote: > > > Introduces new monitor command to query QMP schema information, > > the return data is a dynamical and nested dict/list, it contains > > the useful metadata to help manag

Re: [Qemu-devel] [PATCH 10/16] dimm: add busy slot check and slot auto-allocation

2013-07-26 Thread Igor Mammedov
On Wed, 24 Jul 2013 14:41:36 +0200 Paolo Bonzini wrote: > Il 24/07/2013 13:34, Igor Mammedov ha scritto: > > On Wed, 24 Jul 2013 11:41:04 +0200 > > Paolo Bonzini wrote: > > > >> Il 24/07/2013 10:36, Igor Mammedov ha scritto: > >>> On Tue, 23 Jul 2013 19:09:26 +0200 > >>> Paolo Bonzini wrote: >

Re: [Qemu-devel] [PATCH v2 2/2] full introspection support for QMP

2013-07-26 Thread Amos Kong
On Fri, Jul 19, 2013 at 04:05:16PM -0600, Eric Blake wrote: > On 07/16/2013 04:37 AM, Amos Kong wrote: > > Introduces new monitor command to query QMP schema information, > > the return data is a dynamical and nested dict/list, it contains > > s/dynamical/dynamic/ > > > the useful metadata to hel

Re: [Qemu-devel] [PATCH 1/2] hw/virtio/virtio: Don't allow guests to add/remove queues

2013-07-26 Thread Peter Maydell
On 26 July 2013 00:27, Michael S. Tsirkin wrote: > On Thu, Jul 25, 2013 at 11:37:22PM +0100, Peter Maydell wrote: >> On 25 July 2013 23:33, Michael S. Tsirkin wrote: >> > On Thu, Jul 25, 2013 at 02:37:42PM +0100, Peter Maydell wrote: >> >> A queue size of 0 is used to indicate a nonexistent queue

Re: [Qemu-devel] [Xen-devel] Cirrus VGA slow screen update, show blank screen last 13s or so for windows XP guest

2013-07-26 Thread Fabio Fantoni
Il 26/07/2013 03:57, Gonglei (Arei) ha scritto: Il 25/07/2013 15:13, Gonglei (Arei) ha scritto: Hi, I found a problem: For windows XP guest booting by qemu upstream, using the RDP(Remote Desktop Protocol) and VNC protocol to connect the windows XP guest which booting by Qemu upstream r

Re: [Qemu-devel] [PATCH 3/4] qemu-nbd: add doc for internal snapshot export

2013-07-26 Thread Stefan Hajnoczi
On Wed, Jul 17, 2013 at 10:03:54PM +0800, Wenchao Xia wrote: > Signed-off-by: Wenchao Xia > --- > qemu-nbd.c|2 ++ > qemu-nbd.texi |3 +++ > 2 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/qemu-nbd.c b/qemu-nbd.c > index 46be2b2..833 100644 > --- a/qemu-nbd.c >

Re: [Qemu-devel] Cirrus VGA slow screen update, show blank screen last 13s or so for windows XP guest

2013-07-26 Thread Gonglei (Arei)
I got VMEXIT counts by xentrace When using the VNC protocol grab the RDP to connect Windows XP guest. the time-interval of running xentrace is five seconds.The number of VMEXIT (EXIT_REASON_EPT_VIOLATION) in unstream qemu far greater than qemu-dm. the command likes: xentrace -D -T 5 -c 0x03

Re: [Qemu-devel] [PATCH 0/4] export internal snapshot by qemu-nbd

2013-07-26 Thread Stefan Hajnoczi
On Fri, Jul 26, 2013 at 10:23:24AM +0800, Wenchao Xia wrote: > 于 2013-7-25 16:06, Stefan Hajnoczi 写道: > >On Thu, Jul 25, 2013 at 10:30:49AM +0800, Wenchao Xia wrote: > >> Besides the argument, I think it helps to probe snapshot without > >>qemu-img convert, hope to get comments for the code. > >

Re: [Qemu-devel] [PATCHv2] [RFC 2/7] aio / timers: qemu-timer.c utility functions and add list of clocks

2013-07-26 Thread Stefan Hajnoczi
On Thu, Jul 25, 2013 at 10:46:18AM +0100, Alex Bligh wrote: > >>@@ -61,6 +71,15 @@ int64_t cpu_get_ticks(void); > >> void cpu_enable_ticks(void); > >> void cpu_disable_ticks(void); > >> > >>+static inline int64_t qemu_soonest_timeout(int64_t timeout1, int64_t > >>timeout2) +{ > >>+/* we can abu

Re: [Qemu-devel] [PATCHv2] [RFC 6/7] aio / timers: Switch to ppoll, run AioContext timers in aio_poll/aio_dispatch

2013-07-26 Thread Stefan Hajnoczi
On Thu, Jul 25, 2013 at 03:53:55PM +0100, Alex Bligh wrote: > Stefan, > > --On 25 July 2013 11:33:43 +0200 Stefan Hajnoczi wrote: > > >> assert(progress || busy); > >>-return true; > >>+return progress; > > > >Now aio_poll() can return false when it used to return true? > > I don't

Re: [Qemu-devel] [RFC 0/8] arm AioContext with its own timer stuff

2013-07-26 Thread Stefan Hajnoczi
On Thu, Jul 25, 2013 at 07:53:33PM +0100, Alex Bligh wrote: > > > --On 25 July 2013 14:32:59 +0200 Jan Kiszka wrote: > > >>I would happily at a QEMUClock of each type to AioContext. They are after > >>all pretty lightweight. > > > >What's the point of adding tones of QEMUClock instances? Consid

[Qemu-devel] [PATCH] cpus: use cpu_is_stopped efficiently

2013-07-26 Thread Tiejun Chen
It makes more sense and simple later. Signed-off-by: Tiejun Chen --- cpus.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/cpus.c b/cpus.c index c232265..a997632 100644 --- a/cpus.c +++ b/cpus.c @@ -62,6 +62,11 @@ static CPUArchState *next_cpu; +bool cp

Re: [Qemu-devel] [PATCH qom-next for-1.6 1/4] cs4231: QOM'ify

2013-07-26 Thread Hu Tao
On Wed, Jul 24, 2013 at 10:35:51AM +0200, Andreas Färber wrote: > Signed-off-by: Andreas Färber > --- > hw/audio/cs4231.c | 15 ++- > 1 file changed, 10 insertions(+), 5 deletions(-) Reviewed-by: Hu Tao

Re: [Qemu-devel] [PATCH qom-next for-1.6 4/4] pl041: QOM'ify

2013-07-26 Thread Hu Tao
On Wed, Jul 24, 2013 at 10:35:54AM +0200, Andreas Färber wrote: > Signed-off-by: Andreas Färber > --- > hw/audio/pl041.c | 45 + > 1 file changed, 25 insertions(+), 20 deletions(-) Reviewed-by: Hu Tao

Re: [Qemu-devel] [PATCH qom-next for-1.6 2/4] audio/marvell_88w8618: QOM'ify

2013-07-26 Thread Hu Tao
On Wed, Jul 24, 2013 at 10:35:52AM +0200, Andreas Färber wrote: > Signed-off-by: Andreas Färber > --- > hw/audio/marvell_88w8618.c | 14 +- > 1 file changed, 9 insertions(+), 5 deletions(-) Reviewed-by: Hu Tao

Re: [Qemu-devel] [PATCH qom-next for-1.6 3/4] milkymist-ac97: QOM'ify

2013-07-26 Thread Hu Tao
On Wed, Jul 24, 2013 at 10:35:53AM +0200, Andreas Färber wrote: > Signed-off-by: Andreas Färber > --- > hw/audio/milkymist-ac97.c | 13 + > 1 file changed, 9 insertions(+), 4 deletions(-) Reviewed-by: Hu Tao

Re: [Qemu-devel] [PATCH qom-next for-1.6] onenand: QOM'ify

2013-07-26 Thread Hu Tao
On Wed, Jul 24, 2013 at 10:46:31AM +0200, Andreas Färber wrote: > Signed-off-by: Andreas Färber > --- > hw/block/onenand.c | 30 -- > 1 file changed, 20 insertions(+), 10 deletions(-) Reviewed-by: Hu Tao

Re: [Qemu-devel] [PATCH v3 14/14] i386: ACPI table generation code from seabios

2013-07-26 Thread Gerd Hoffmann
Hi, >> You can look at the tables without doing a full linker pass first, so >> the firmware can easily initialize the hardware according to what it >> finds in specific acpi tables. Check FADT for pm_base. Check MCFG for >> mmconf xbar location. >> >> cheers, >> Gerd > > That's something I

Re: [Qemu-devel] [RFC 0/8] arm AioContext with its own timer stuff

2013-07-26 Thread Alex Bligh
--On 26 July 2013 10:43:45 +0200 Stefan Hajnoczi wrote: block.c and block/qed.c use vm_clock because block drivers should not do guest I/O while the vm is stopped. This is especially true during live migration where it's important to hand off the image file from the source host to the destin

[Qemu-devel] [PATCH v3] hcd-ohci: add dma error handling

2013-07-26 Thread Alexey Kardashevskiy
Current hcd-ohci does not handle DMA errors. However they may happen so here we introduce simple error handling. On such errors, a typical OHCI will stop operating, signal the guest about the error by sending "UnrecoverableError Event", set itself into error state and set "Detected Parity Error" i

Re: [Qemu-devel] [RFC 0/8] arm AioContext with its own timer stuff

2013-07-26 Thread Paolo Bonzini
Il 26/07/2013 11:08, Alex Bligh ha scritto: > > > --On 26 July 2013 10:43:45 +0200 Stefan Hajnoczi > wrote: > >> block.c and block/qed.c use vm_clock because block drivers should not do >> guest I/O while the vm is stopped. This is especially true during live >> migration where it's important

[Qemu-devel] [PATCH v4] spapr-vscsi: add task management

2013-07-26 Thread Alexey Kardashevskiy
At the moment the guest kernel issues two types of task management requests to the hypervisor - task about and lun reset. This adds handling for these tasks. As spapr-vscsi starts calling scsi_req_cancel(), free_request callback was implemented. As virtio-vscsi, spapr-vscsi does not handle CLEAR_A

Re: [Qemu-devel] vhost acceleration broken?

2013-07-26 Thread Stefan Hajnoczi
On Thu, Jul 25, 2013 at 05:53:06PM +0300, Michael S. Tsirkin wrote: > On Thu, Jul 25, 2013 at 03:12:31PM +0100, Peter Maydell wrote: > > On 25 July 2013 03:08, Anthony Liguori wrote: > > > We really ought to strongly deprecate -net because it's misleading. > > > > ...we still need to figure out h

Re: [Qemu-devel] [PATCH 10/16] dimm: add busy slot check and slot auto-allocation

2013-07-26 Thread Paolo Bonzini
Il 26/07/2013 09:38, Igor Mammedov ha scritto: > Perhaps denying memory add and suggesting node migration to a node with > more memory would be right approach, otherwise user is bound to be hit by > cross node penalty. Or better, the user can first change the policy from "bind" to "preferred", and

Re: [Qemu-devel] [PATCH v4] spapr-vscsi: add task management

2013-07-26 Thread Paolo Bonzini
Il 26/07/2013 11:20, Alexey Kardashevskiy ha scritto: > -return !fn; > + > +vscsi_send_rsp(s, req, resp, 0, 0); We're not there yet, but getting closer... These response codes are _not_ SCSI status codes that go in the SRP_RSP's status field. They go (in the error case) in the "response

Re: [Qemu-devel] [PATCH 0/12 RFC v2] Localhost migration

2013-07-26 Thread Paolo Bonzini
Il 25/07/2013 22:18, Lei Li ha scritto: > Hi, > > This patch series tries to add localhost migration support to > Qemu. > > When doing localhost migration, the host memory will balloon > up during the period, might consume double memories for some time. > So we want to add a new live migration

Re: [Qemu-devel] [PATCH v3 06/14] i386: add bios linker/loader

2013-07-26 Thread Gerd Hoffmann
Hi, Hacked up coreboot support to verify the interface. > +/* > + * COMMAND_ALLOCATE - allocate a table from @alloc_file > + * subject to @alloc_align alignment (must be power of 2) > + * and @alloc_zone (can be HIGH or FSEG) requirements. > + * > +

Re: [Qemu-devel] vhost acceleration broken?

2013-07-26 Thread Peter Maydell
On 26 July 2013 10:25, Stefan Hajnoczi wrote: > On Thu, Jul 25, 2013 at 05:53:06PM +0300, Michael S. Tsirkin wrote: >> On Thu, Jul 25, 2013 at 03:12:31PM +0100, Peter Maydell wrote: >> > On 25 July 2013 03:08, Anthony Liguori wrote: >> > > We really ought to strongly deprecate -net because it's m

Re: [Qemu-devel] [PATCH V3 for-1.6 2/5] block: Modify the throttling code to implement the leaky bucket algorithm.

2013-07-26 Thread Benoît Canet
> I think it is easier to understand written like this: > >int64_t total_leak = ((bs->io_limits.iops[BLOCK_IO_LIMIT_TOTAL] * > delta) / > NANOSECONDS_PER_SECOND); >if (ios[BLOCK_IO_LIMIT_READ] <= total_leak / 2) { > read_leak = ios[B

Re: [Qemu-devel] [PATCH V3 for-1.6 5/5] block: Add throttling percentage metrics.

2013-07-26 Thread Benoît Canet
> If I understand it, the percentage is recalculated every leak check. So > it only reflects the instant io flow, instead of historical statistics? > But I think for system admin purpose, it's good to know a longer range > io activity character. Or do you think management tool should sample it? Ye

Re: [Qemu-devel] [PATCH] Citrix PV Bus device

2013-07-26 Thread Paul Durrant
> -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: 24 July 2013 11:20 > To: Paul Durrant > Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org > Subject: Re: [Qemu-devel] [PATCH] Citrix PV Bus device > > On 07/02/13 16:03, Paul Durrant wrote: > > This patch introd

[Qemu-devel] [PATCH] uhci: egsm fix

2013-07-26 Thread Gerd Hoffmann
When the guest goes suspend the uhci controller while there are pending resume requests on the ports go signal global resume instantly. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-uhci.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/usb/hcd-uhci.c b/hw/usb/hcd-uhci.c index 066

Re: [Qemu-devel] [PATCH v3] hcd-ohci: add dma error handling

2013-07-26 Thread Gerd Hoffmann
On 07/26/13 11:10, Alexey Kardashevskiy wrote: > Current hcd-ohci does not handle DMA errors. However they may happen > so here we introduce simple error handling. > > On such errors, a typical OHCI will stop operating, signal the guest > about the error by sending "UnrecoverableError Event", set

Re: [Qemu-devel] Cirrus VGA slow screen update, show blank screen last 13s or so for windows XP guest

2013-07-26 Thread Andreas Färber
Am 26.07.2013 08:41, schrieb Gonglei (Arei): >> -Original Message- >> From: Anthony Liguori [mailto:anth...@codemonkey.ws] >> Sent: Friday, July 26, 2013 11:21 AM >> To: Gonglei (Arei) >> Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org; Hanweidong; >> Luonengjun; Huangweidong (Hardware)

Re: [Qemu-devel] [RFC 0/8] arm AioContext with its own timer stuff

2013-07-26 Thread Jan Kiszka
On 2013-07-25 20:53, Alex Bligh wrote: > > > --On 25 July 2013 14:32:59 +0200 Jan Kiszka wrote: > >>> I would happily at a QEMUClock of each type to AioContext. They are >>> after >>> all pretty lightweight. >> >> What's the point of adding tones of QEMUClock instances? Considering >> proper ab

Re: [Qemu-devel] [ANNOUNCE] QEMU 1.5.2 Stable released

2013-07-26 Thread Daniel P. Berrange
On Thu, Jul 25, 2013 at 04:44:43PM -0500, Michael Roth wrote: > The QEMU v1.5.2 stable release is now available at: > > http://wiki.qemu.org/download/qemu-1.5.2.tar.bz2 > > This is release is solely to address a security issue (CVE-2013-2231) found > in the QEMU Guest Agent on Windows. More det

Re: [Qemu-devel] [PATCH v3] hcd-ohci: add dma error handling

2013-07-26 Thread Benjamin Herrenschmidt
On Fri, 2013-07-26 at 11:58 +0200, Gerd Hoffmann wrote: > On 07/26/13 11:10, Alexey Kardashevskiy wrote: > > Current hcd-ohci does not handle DMA errors. However they may happen > > so here we introduce simple error handling. > > > > On such errors, a typical OHCI will stop operating, signal the g

[Qemu-devel] [PATCH v2] e1000: add interrupt mitigation support

2013-07-26 Thread Vincenzo Maffione
Hello, I tried to support cross-version migration using version_id and VMState subsections. I also disable MIT if the machine is "pc-i440fx-1.5": Is that the correct way to do it? Thanks, Vincenzo Maffione >From 4e692113753db8dea6cbcc7a729cfa81469a76ca Mon Sep 17 00:00:00 2001 From: Vincenzo

Re: [Qemu-devel] Cirrus VGA slow screen update, show blank screen last 13s or so for windows XP guest

2013-07-26 Thread Gerd Hoffmann
On 07/26/13 12:02, Andreas Färber wrote: > Am 26.07.2013 08:41, schrieb Gonglei (Arei): >>> -Original Message- >>> From: Anthony Liguori [mailto:anth...@codemonkey.ws] >>> Sent: Friday, July 26, 2013 11:21 AM >>> To: Gonglei (Arei) >>> Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org; Han

Re: [Qemu-devel] [PATCH v3] hcd-ohci: add dma error handling

2013-07-26 Thread Gerd Hoffmann
On 07/26/13 12:10, Benjamin Herrenschmidt wrote: > On Fri, 2013-07-26 at 11:58 +0200, Gerd Hoffmann wrote: >> On 07/26/13 11:10, Alexey Kardashevskiy wrote: >>> Current hcd-ohci does not handle DMA errors. However they may happen >>> so here we introduce simple error handling. >>> >>> On such error

Re: [Qemu-devel] [PATCH v4] spapr-vscsi: add task management

2013-07-26 Thread Alexey Kardashevskiy
On 07/26/2013 07:34 PM, Paolo Bonzini wrote: > Il 26/07/2013 11:20, Alexey Kardashevskiy ha scritto: >> -return !fn; >> + >> +vscsi_send_rsp(s, req, resp, 0, 0); > > We're not there yet, but getting closer... Oh. Right. Sorry and thanks (ohci + ehci + vscsi at the same time and my mind me

Re: [Qemu-devel] Cirrus VGA slow screen update, show blank screen last 13s or so for windows XP guest

2013-07-26 Thread Andreas Färber
Am 26.07.2013 12:19, schrieb Gerd Hoffmann: > On 07/26/13 12:02, Andreas Färber wrote: >> Am 26.07.2013 08:41, schrieb Gonglei (Arei): -Original Message- From: Anthony Liguori [mailto:anth...@codemonkey.ws] Sent: Friday, July 26, 2013 11:21 AM To: Gonglei (Arei) Cc:

[Qemu-devel] [PATCH v4] hcd-ohci: add dma error handling

2013-07-26 Thread Alexey Kardashevskiy
Current hcd-ohci does not handle DMA errors. However they may happen so here we introduce simple error handling. On such errors, a typical OHCI will stop operating, signal the guest about the error by sending "UnrecoverableError Event", set itself into error state and set "Detected Parity Error" i

Re: [Qemu-devel] [PATCH v4] hcd-ohci: add dma error handling

2013-07-26 Thread Gerd Hoffmann
Hi, > This also adds ohci_stop() call to ohci_bus_start() to handle possible > failure of qemu_new_timer_ns(). > * ohci_stop renamed to ohci_die to describe the action better Except in the commit message ... Also scripts/checkpatch.pl complains: ERROR: return is not a function, parentheses a

[Qemu-devel] [PATCH v5] hcd-ohci: add dma error handling

2013-07-26 Thread Alexey Kardashevskiy
Current hcd-ohci does not handle DMA errors. However they may happen so here we introduce simple error handling. On such errors, a typical OHCI will stop operating, signal the guest about the error by sending "UnrecoverableError Event", set itself into error state and set "Detected Parity Error" i

Re: [Qemu-devel] [PATCH v4] spapr-vscsi: add task management

2013-07-26 Thread Paolo Bonzini
Il 26/07/2013 12:25, Alexey Kardashevskiy ha scritto: > On 07/26/2013 07:34 PM, Paolo Bonzini wrote: >> Il 26/07/2013 11:20, Alexey Kardashevskiy ha scritto: >>> -return !fn; >>> + >>> +vscsi_send_rsp(s, req, resp, 0, 0); >> >> We're not there yet, but getting closer... > > Oh. Right. Sorr

Re: [Qemu-devel] [PATCH v5] hcd-ohci: add dma error handling

2013-07-26 Thread Gerd Hoffmann
On 07/26/13 12:52, Alexey Kardashevskiy wrote: > Current hcd-ohci does not handle DMA errors. However they may happen > so here we introduce simple error handling. > > On such errors, a typical OHCI will stop operating, signal the guest > about the error by sending "UnrecoverableError Event", set

Re: [Qemu-devel] [PATCH 2/9] block: vhdx - add header update capability.

2013-07-26 Thread Jeff Cody
On Fri, Jul 26, 2013 at 02:49:04PM +0800, Fam Zheng wrote: > On Wed, 07/24 13:54, Jeff Cody wrote: > > This adds the ability to update the headers in a VHDX image, including > > generating a new MS-compatible GUID. > > > > As VHDX depends on uuid.h, VHDX is now a configurable build option. If > >

Re: [Qemu-devel] [PATCH v2 2/2] full introspection support for QMP

2013-07-26 Thread Eric Blake
On 07/26/2013 01:51 AM, Amos Kong wrote: >>> +# Query QMP schema information >>> +# >>> +# Returns: list of @SchemaEntry. Returns an error if json string is >>> invalid. >> >> If you don't take any arguments, then the "returns an error" statement >> is impossible. > > When we execute the full in

Re: [Qemu-devel] [PATCH v2] e1000: add interrupt mitigation support

2013-07-26 Thread Andreas Färber
Hi, Am 26.07.2013 12:14, schrieb Vincenzo Maffione: > I tried to support cross-version migration using version_id and > VMState subsections. The point of using a subsection is to avoid incrementing version_id AFAIU. > I also disable MIT if the machine is "pc-i440fx-1.5": Is that the > correct

Re: [Qemu-devel] [PATCH v3 00/14] qemu: generate acpi tables for the guest

2013-07-26 Thread Andreas Färber
Am 25.07.2013 18:19, schrieb Michael S. Tsirkin: > On Thu, Jul 25, 2013 at 05:50:55PM +0200, Andreas Färber wrote: >> Am 24.07.2013 18:01, schrieb Michael S. Tsirkin: >>> This code can also be found here: >>> git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git acpi >>> >>> Please review, and conside

Re: [Qemu-devel] [PATCH v3 00/14] qemu: generate acpi tables for the guest

2013-07-26 Thread Andreas Färber
Am 25.07.2013 19:18, schrieb Michael S. Tsirkin: > On Thu, Jul 25, 2013 at 05:50:55PM +0200, Andreas Färber wrote: >> Am 24.07.2013 18:01, schrieb Michael S. Tsirkin: >>> This code can also be found here: >>> git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git acpi >>> >>> Please review, and conside

Re: [Qemu-devel] [Xen-devel] Cirrus VGA slow screen update, show blank screen last 13s or so for windows XP guest

2013-07-26 Thread Fabio Fantoni
Il 26/07/2013 08:41, Gonglei (Arei) ha scritto: -Original Message- From: Anthony Liguori [mailto:anth...@codemonkey.ws] Sent: Friday, July 26, 2013 11:21 AM To: Gonglei (Arei) Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org; Hanweidong; Luonengjun; Huangweidong (Hardware) Subject: Re

Re: [Qemu-devel] [libvirt] [PATCH 4/7] qemu: Add monitor APIs to fetch CPUID data from QEMU

2013-07-26 Thread Andreas Färber
Am 25.07.2013 20:02, schrieb Eduardo Habkost: > On Thu, Jul 25, 2013 at 04:09:18PM +0200, Andreas Färber wrote: >> Am 25.07.2013 16:00, schrieb Eduardo Habkost: >>> libvirt >>> needs a way to find out how exactly "-machine foo-1.0 -cpu bar" looks >>> different from "-machine foo-1.1 -cpu bar", >> >

Re: [Qemu-devel] [PATCH] kvm: Change prototype of kvm_update_guest_debug

2013-07-26 Thread Andreas Färber
Am 25.07.2013 20:50, schrieb Stefan Weil: > Passing a CPUState pointer instead of a CPUArchState pointer eliminates > the last target dependent data type in sysemu/kvm.h. > > It also simplifies the code. > > Signed-off-by: Stefan Weil > --- > > With this patch (and a previous one which is alrea

[Qemu-devel] [Bug 1079080] Re: ARM instruction "srs" wrong behaviour

2013-07-26 Thread Peter Maydell
** Changed in: qemu Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1079080 Title: ARM instruction "srs" wrong behaviour Status in QEMU: Fix Committed Bu

[Qemu-devel] [PATCH 4/9] qapi.py: Decent syntax error reporting

2013-07-26 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- scripts/qapi.py | 29 +++-- tests/qapi-schema/test-qapi.py| 2 ++ tests/qapi-schema/unclosed-string.err | 2 +- 3 files changed, 30 insertions(+), 3 deletions(-) diff --git a/scripts/qapi.py b/scripts/q

[Qemu-devel] [PATCH 0/9] Our QAPI parser is a hack, replace it

2013-07-26 Thread Markus Armbruster
If you think I'm exaggerating, check out the list of issues in PATCH 3/9. Markus Armbruster (9): tests: QAPI schema parser tests tests: Use qapi-schema-test.json as schema parser test qapi.py: Restructure lexer and parser qapi.py: Decent syntax error reporting qapi.py: Reject invalid cha

[Qemu-devel] [PATCH 1/9] tests: QAPI schema parser tests

2013-07-26 Thread Markus Armbruster
The parser handles erroneous input badly. To be improved shortly. Signed-off-by: Markus Armbruster --- configure | 2 +- tests/Makefile | 22 -- tests/qapi-schema/empty.exit | 1 + tests

[Qemu-devel] [PATCH 7/9] qapi.py: Fix diagnosing non-objects at a schema's top-level

2013-07-26 Thread Markus Armbruster
Report syntax error instead of crashing. Signed-off-by: Markus Armbruster --- scripts/qapi.py | 10 ++ tests/qapi-schema/non-objects.err | 2 +- tests/qapi-schema/quoted-structural-chars.err | 2 +- 3 files changed, 8 insertions(+), 6 deletions

[Qemu-devel] [PATCH 6/9] qapi.py: Fix schema parser to check syntax systematically

2013-07-26 Thread Markus Armbruster
Fixes at least the following parser bugs: * accepts any token in place of a colon * treats comma as optional * crashes when closing braces or brackets are missing Signed-off-by: Markus Armbruster --- scripts/qapi.py | 40 ++- tests/qapi-sc

[Qemu-devel] [PATCH 5/9] qapi.py: Reject invalid characters in schema file

2013-07-26 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- scripts/qapi.py | 2 ++ tests/qapi-schema/funny-char.err | 1 + tests/qapi-schema/funny-char.exit | 2 +- tests/qapi-schema/funny-char.out | 3 --- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/scripts/qapi.py b/scripts/qa

[Qemu-devel] [PATCH 8/9] qapi.py: Rename expr_eval to expr in parse_schema()

2013-07-26 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- scripts/qapi.py | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/scripts/qapi.py b/scripts/qapi.py index 5677daa..1d856c9 100644 --- a/scripts/qapi.py +++ b/scripts/qapi.py @@ -153,14 +153,14 @@ def parse_schema(fp):

[Qemu-devel] [Bug 739785] Re: qemu-i386 user mode can't fork (bash: fork: Invalid argument)

2013-07-26 Thread Peter Maydell
This is a long and confusing bug report, but recent commits to make NPTL non-optional (and in particular enable it for x86-64 and i386) which will be in QEMU 1.6 should mean that the originally reported problem (of bash failing with "fork: Invalid argument") is fixed, and at least basic single-thre

[Qemu-devel] [PATCH 9/9] qapi.py: Permit comments starting anywhere on the line

2013-07-26 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- scripts/qapi.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/scripts/qapi.py b/scripts/qapi.py index 1d856c9..da46fb9 100644 --- a/scripts/qapi.py +++ b/scripts/qapi.py @@ -53,13 +53,12 @@ class QAPISchema: def accept(self):

[Qemu-devel] [PATCH 2/9] tests: Use qapi-schema-test.json as schema parser test

2013-07-26 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- qapi-schema-test.json | 53 - tests/Makefile | 8 ++--- tests/qapi-schema/qapi-schema-test.exit | 1 + tests/qapi-schema/qapi-schema-test.json | 53 +

[Qemu-devel] [PATCH 3/9] qapi.py: Restructure lexer and parser

2013-07-26 Thread Markus Armbruster
The parser has a rather unorthodox structure: Until EOF: Read a section: Generator function get_expr() yields one section after the other, as a string. An unindented, non-empty line that isn't a comment starts a new section. Lexing:

Re: [Qemu-devel] [PATCH qom-next for-1.6 7/8] pl110: QOM'ify pl110, pl110_versatile and pl111

2013-07-26 Thread Andreas Färber
Am 26.07.2013 04:58, schrieb Hu Tao: > On Thu, Jul 25, 2013 at 01:16:51AM +0200, Andreas Färber wrote: >> Let pl110_versatile and pl111 inherit from pl110 and use PL110() cast; >> set their version index in an instance_init. >> >> Signed-off-by: Andreas Färber >> --- >> hw/display/pl110.c | 71 >

Re: [Qemu-devel] [PATCH] kvm: Change prototype of kvm_update_guest_debug

2013-07-26 Thread Paolo Bonzini
Il 26/07/2013 14:33, Andreas Färber ha scritto: > Am 25.07.2013 20:50, schrieb Stefan Weil: >> Passing a CPUState pointer instead of a CPUArchState pointer eliminates >> the last target dependent data type in sysemu/kvm.h. >> >> It also simplifies the code. >> >> Signed-off-by: Stefan Weil >> ---

Re: [Qemu-devel] [PATCH 1/9] tests: QAPI schema parser tests

2013-07-26 Thread Eric Blake
On 07/26/2013 06:39 AM, Markus Armbruster wrote: > The parser handles erroneous input badly. To be improved shortly. > > Signed-off-by: Markus Armbruster > --- Lots of proof on how bad it is! I'd also like to see a couple tests on trailing commas: { 'enum': 'Foo', [ 'bar' ], } { 'enum': 'Gur'

[Qemu-devel] [Bug 788701] Re: qemu-user fails to run rpcgen (i386, x86_64)

2013-07-26 Thread Peter Maydell
This should be fixed in QEMU 1.6. ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/788701 Title: qemu-user fails to run rpcgen (i386, x86_64)

[Qemu-devel] [Bug 840686] Re: No such list qemu-users

2013-07-26 Thread Peter Maydell
The list for users is qemu-discuss now: http://lists.nongnu.org/archive/html/qemu-discuss/ ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/840686

Re: [Qemu-devel] [PATCH 10/16] dimm: add busy slot check and slot auto-allocation

2013-07-26 Thread Igor Mammedov
On Fri, 26 Jul 2013 11:26:16 +0200 Paolo Bonzini wrote: > Il 26/07/2013 09:38, Igor Mammedov ha scritto: > > Perhaps denying memory add and suggesting node migration to a node with > > more memory would be right approach, otherwise user is bound to be hit by > > cross node penalty. > > Or better

[Qemu-devel] Application PID on i386

2013-07-26 Thread Anderson Sartor
Hi all, I've been modyfing the QEMU source from Android SDK in order to trace a larger amount of data, I know this Android QEMU is already a modified version and it has additional code just for Android. However, if anyone have any idea how I can get the application PID for i386 architecture, I woul

[Qemu-devel] [Bug 501141] Re: qemu powerpc target crashes on "hello world"

2013-07-26 Thread Peter Maydell
qemu-ppc works OK for me, so it seems likely that this bug has been fixed at some point in the preceding three years. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs

[Qemu-devel] [Bug 1075272] Re: socket type mapping wrong for mips app-level emulation

2013-07-26 Thread Peter Maydell
This should be fixed in QEMU 1.6. ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1075272 Title: socket type mapping wrong for mips app-level

[Qemu-devel] [Bug 824716] Re: linux-user broken for targets with TARGET_ABI32 (i.e. qemu-sparc32plus)

2013-07-26 Thread Peter Maydell
The fix for this was actually committed way back in 2011... ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/824716 Title: linux-user broken fo

[Qemu-devel] [Bug 720787] Re: Fails to compile on MacOS

2013-07-26 Thread Peter Maydell
These compile errors have all been fixed some time ago. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/720787 Title: Fails to compile on MacO

[Qemu-devel] [Bug 726962] Re: darwin user i386 no such directory

2013-07-26 Thread Peter Maydell
This is fixed, in that darwin-user was removed some time ago... ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/726962 Title: darwin user i386

Re: [Qemu-devel] [PATCH 05/18] docs: Document QAPI union types

2013-07-26 Thread Eric Blake
On 07/23/2013 07:03 AM, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > docs/qapi-code-gen.txt | 58 > +- > 1 file changed, 53 insertions(+), 5 deletions(-) > +=== Complex types === > > A complex type is a dictionary containing a single k

Re: [Qemu-devel] [PATCH v2] e1000: add interrupt mitigation support

2013-07-26 Thread Vincenzo Maffione
2013/7/26 Andreas Färber : > Hi, > > Am 26.07.2013 12:14, schrieb Vincenzo Maffione: >> I tried to support cross-version migration using version_id and >> VMState subsections. > > The point of using a subsection is to avoid incrementing version_id AFAIU. > Consider a migration from an older QEMU

[Qemu-devel] [Bug 769986] Re: Binaries installed via ppa:serge-hallyn/spice still are affected by bug 723871

2013-07-26 Thread Peter Maydell
I'm guessing this bug report is obsolete -- in any case the main upstream QEMU project is the wrong place to file bugs against packages from random PPAs. ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is

Re: [Qemu-devel] [PATCH 06/18] qapi: Add visitor for implicit structs

2013-07-26 Thread Eric Blake
On 07/23/2013 07:03 AM, Kevin Wolf wrote: > These can be used when an embedded struct is parsed and members not > belonging to the struct may be present in the input (e.g. parsing a > flat namespace QMP union, where fields from both the base and one > of the alternative types are mixed in the JSON

Re: [Qemu-devel] [PATCH 2/9] tests: Use qapi-schema-test.json as schema parser test

2013-07-26 Thread Eric Blake
On 07/26/2013 06:39 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > qapi-schema-test.json | 53 > - > tests/Makefile | 8 ++--- > tests/qapi-schema/qapi-schema-test.exit | 1 + > tests/qapi-schem

[Qemu-devel] [Bug 834978] Re: configure file assumes glib is required under MinGW

2013-07-26 Thread Peter Maydell
glib is required even when compiling under MinGW. ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/834978 Title: configure file assumes glib is requ

[Qemu-devel] [Bug 902306] Re: qemu-user -static variants require shared libraries

2013-07-26 Thread Peter Maydell
The prctl patches I mention in comment #4 went into upstream last year, so we can close this bug now. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/

[Qemu-devel] [Bug 986241] Re: Misspelling of env parameter in deregister_dtl() [hw/spapr_hcall.c]

2013-07-26 Thread Peter Maydell
** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/986241 Title: Misspelling of env parameter in deregister_dtl() [hw/spapr_hcall.c] Status in QEM

Re: [Qemu-devel] [PATCH 07/18] qapi: Flat unions with arbitrary discriminator

2013-07-26 Thread Eric Blake
On 07/23/2013 07:03 AM, Kevin Wolf wrote: > Instead of the rather verbose syntax that distinguishes base and > subclass fields... > > { "type": "file", > "read-only": true, > "data": { > "filename": "test" > } } > > ...we can now have both in the same namespace, allowing a m

[Qemu-devel] [Bug 996303] Re: does not work with clang

2013-07-26 Thread Peter Maydell
This was released in QEMU 1.3. ** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/996303 Title: does not work with clang Status in QEM

[Qemu-devel] [Bug 1014823] Re: qemu-kvm-1.0.1 compilation error on Ubuntu 12.04

2013-07-26 Thread Peter Maydell
The patch Serge mentions was committed upstream and released last year. ** Changed in: qemu Status: Confirmed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1014823 Title: q

[Qemu-devel] [Bug 1017139] Re: qemu-system-i386 fails to link on linklevel

2013-07-26 Thread Peter Maydell
The logging code was all reworked some time ago so this compilation failure bug report is out of date now. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad

Re: [Qemu-devel] [PATCH 3/9] qapi.py: Restructure lexer and parser

2013-07-26 Thread Eric Blake
On 07/26/2013 06:39 AM, Markus Armbruster wrote: > The parser has a rather unorthodox structure: > > > Replace this piece of original art by a thoroughly unoriginal design. I sense a bit of tongue-in-cheek urge to use more colorful language at this point, describing the horrors of the old imple

Re: [Qemu-devel] [libvirt] [PATCH 4/7] qemu: Add monitor APIs to fetch CPUID data from QEMU

2013-07-26 Thread Eduardo Habkost
On Fri, Jul 26, 2013 at 02:31:24PM +0200, Andreas Färber wrote: > Am 25.07.2013 20:02, schrieb Eduardo Habkost: > > On Thu, Jul 25, 2013 at 04:09:18PM +0200, Andreas Färber wrote: > >> Am 25.07.2013 16:00, schrieb Eduardo Habkost: > >>> libvirt > >>> needs a way to find out how exactly "-machine fo

Re: [Qemu-devel] [PATCH v2] e1000: add interrupt mitigation support

2013-07-26 Thread Andreas Färber
Am 26.07.2013 15:09, schrieb Vincenzo Maffione: > 2013/7/26 Andreas Färber : >> Am 26.07.2013 12:14, schrieb Vincenzo Maffione: >>> I tried to support cross-version migration using version_id and >>> VMState subsections. >> >> The point of using a subsection is to avoid incrementing version_id AF

Re: [Qemu-devel] [PATCH 1/9] tests: QAPI schema parser tests

2013-07-26 Thread Markus Armbruster
Eric Blake writes: > On 07/26/2013 06:39 AM, Markus Armbruster wrote: >> The parser handles erroneous input badly. To be improved shortly. >> >> Signed-off-by: Markus Armbruster >> --- > > Lots of proof on how bad it is! I'd also like to see a couple tests on > trailing commas: > > { 'enum':

Re: [Qemu-devel] [PATCH v2] e1000: add interrupt mitigation support

2013-07-26 Thread Vincenzo Maffione
That's very clear! Thanks, Vincenzo 2013/7/26 Andreas Färber : > Am 26.07.2013 15:09, schrieb Vincenzo Maffione: >> 2013/7/26 Andreas Färber : >>> Am 26.07.2013 12:14, schrieb Vincenzo Maffione: I tried to support cross-version migration using version_id and VMState subsections. >>>

Re: [Qemu-devel] [PATCH 10/16] dimm: add busy slot check and slot auto-allocation

2013-07-26 Thread Paolo Bonzini
Il 26/07/2013 14:51, Igor Mammedov ha scritto: > On Fri, 26 Jul 2013 11:26:16 +0200 > Paolo Bonzini wrote: > >> Il 26/07/2013 09:38, Igor Mammedov ha scritto: >>> Perhaps denying memory add and suggesting node migration to a node with >>> more memory would be right approach, otherwise user is bou

Re: [Qemu-devel] [PATCH 0/9] Our QAPI parser is a hack, replace it

2013-07-26 Thread Anthony Liguori
Markus Armbruster writes: > If you think I'm exaggerating, check out the list of issues in PATCH > 3/9. You are not. However, I think we can drop the whole thing and just use the JSON module in Python. The bit below seems to work: import json.decoder, re from ordereddict import OrderedDic

  1   2   3   4   >