On Fri, Jul 26, 2013 at 10:23:24AM +0800, Wenchao Xia wrote: > δΊ 2013-7-25 16:06, Stefan Hajnoczi ει: > >On Thu, Jul 25, 2013 at 10:30:49AM +0800, Wenchao Xia wrote: > >> Besides the argument, I think it helps to probe snapshot without > >>qemu-img convert, hope to get comments for the code. > > > >Hi Wenchao, > >Which patch are you referring to? > > > >Stefan > > > This series, which enable qemu-nbd load a snapshot. It is quite > simple, look forward to your opinion, especially the parameter of > qemu-nbd part in patch 2.
I understand now. Adding bdrv_snapshot_load_tmp() support to qemu-nbd is useful, it's a shame that the --snapshot/-s option is already taken and likely to cause confusion. The documentation needs to be very clear that --snapshot and --snapshot-load refer to different snapshot concepts. Stefan