Re: [Qemu-devel] [PATCH RFC qom-next 4/4] pcie_port: Turn PCIEPort and PCIESlot into abstract QOM types

2013-07-23 Thread Michael S. Tsirkin
On Mon, Jul 22, 2013 at 03:29:46PM -0500, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > > > On Sun, Jul 21, 2013 at 04:09:04PM +0200, Andreas Färber wrote: > >> Signed-off-by: Andreas Färber > >> --- > >> hw/pci-bridge/ioh3420.c| 23 ++- > >> hw/pci-bri

Re: [Qemu-devel] [PATCH RFC qom-next 4/4] pcie_port: Turn PCIEPort and PCIESlot into abstract QOM types

2013-07-23 Thread Michael S. Tsirkin
On Mon, Jul 22, 2013 at 11:04:49PM +0200, Andreas Färber wrote: > Am 22.07.2013 22:29, schrieb Anthony Liguori: > > "Michael S. Tsirkin" writes: > > > >> On Sun, Jul 21, 2013 at 04:09:04PM +0200, Andreas Färber wrote: > >>> Signed-off-by: Andreas Färber > >>> --- > >>> hw/pci-bridge/ioh3420.c

Re: [Qemu-devel] [PATCH 4/9] linux-user: Clean up sendrecvmsg message parsing

2013-07-23 Thread Riku Voipio
On 6 July 2013 15:17, Alexander Graf wrote: > The cmsg handling in the linux-user code is very hard to read as it tries > to follow glibc's unreadable code closely. Let's clean it up, converting > all helpers into static inline functions, so that QEMU developers have a > chance to understand what'

Re: [Qemu-devel] [PATCHv3 0/2] seccomp: remove unused syscalls - for 1.6

2013-07-23 Thread Paolo Bonzini
Il 22/07/2013 20:33, Eduardo Otubo ha scritto: > In this small patch series I basically: > > v3 update: > - reincluded getrlimit(), it's used by Xen. > > v2 update: > - set libseccomp 2.1.0 as requirement on configure script. > - reincluded setrlimit() (used by Xen) and removed sendfile

Re: [Qemu-devel] KVM call agenda for 2013-07-30

2013-07-23 Thread Christian Borntraeger
On 23/07/13 08:33, Juan Quintela wrote: > > Hi > > Please, send any topic that you are interested in covering. - soft reset and other reset variants. What is the right way to go? (e.g. on s390 there are several reset variants that reset a defined subset of the system. This can be triggered by o

[Qemu-devel] [PATCH 09/11] sheepdog: try to reconnect to sheepdog after network error

2013-07-23 Thread MORITA Kazutaka
This introduces a failed request queue and links all the inflight requests to the list after network error happens. After QEMU reconnects to the sheepdog server successfully, the sheepdog block driver will retry all the requests in the failed queue. Signed-off-by: MORITA Kazutaka --- block/shee

[Qemu-devel] [PATCH 03/11] qemu-sockets: make wait_for_connect be invoked in qemu_aio_wait

2013-07-23 Thread MORITA Kazutaka
This allows us to use inet_nonblocking_connect() and unix_nonblocking_connect() in block drivers. qemu-ga needs to link block-obj to resolve dependencies of qemu_aio_set_fd_handler(). Signed-off-by: MORITA Kazutaka --- Makefile| 4 ++-- util/qemu-sockets.c | 15 ++- 2 f

[Qemu-devel] [PATCH 06/11] sheepdog: handle vdi objects in resend_aio_req

2013-07-23 Thread MORITA Kazutaka
The current resend_aio_req() doesn't work when the request is against vdi objects. This fixes the problem. Signed-off-by: MORITA Kazutaka --- block/sheepdog.c | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index 567

[Qemu-devel] [PATCH 11/11] sheepdog: cancel aio requests if possible

2013-07-23 Thread MORITA Kazutaka
This patch tries to cancel aio requests in pending queue and failed queue. When the sheepdog driver cannot cancel the requests, it waits for them to be completed. Signed-off-by: MORITA Kazutaka --- block/sheepdog.c | 70 +++- 1 file changed, 5

[Qemu-devel] [PATCH 08/11] coroutine: add co_aio_sleep_ns() to allow sleep in block drivers

2013-07-23 Thread MORITA Kazutaka
This helper function behaves similarly to co_sleep_ns(), but the sleeping coroutine will be resumed when using qemu_aio_wait(). Signed-off-by: MORITA Kazutaka --- include/block/coroutine.h | 8 qemu-coroutine-sleep.c| 47 +++ 2 files chan

[Qemu-devel] [PATCH 07/11] sheepdog: reload inode outside of resend_aioreq

2013-07-23 Thread MORITA Kazutaka
This prepares for using resend_aioreq() after reconnecting to the sheepdog server. Signed-off-by: MORITA Kazutaka --- block/sheepdog.c | 33 +++-- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index 018eab2..117360

[Qemu-devel] [PATCH 04/11] sheepdog: make connect nonblocking

2013-07-23 Thread MORITA Kazutaka
This uses nonblocking connect functions to connect to the sheepdog server. The connect operation is done in a coroutine function and it will be yielded until the created socked is ready for IO. Signed-off-by: MORITA Kazutaka --- block/sheepdog.c | 70

[Qemu-devel] [PATCH 10/11] sheepdog: make add_aio_request and send_aioreq void functions

2013-07-23 Thread MORITA Kazutaka
These functions no longer return errors. We can make them void functions and simplify the codes. Signed-off-by: MORITA Kazutaka --- block/sheepdog.c | 66 +++- 1 file changed, 17 insertions(+), 49 deletions(-) diff --git a/block/sheepdog.c b/

[Qemu-devel] [PATCH 02/11] iov: handle EOF in iov_send_recv

2013-07-23 Thread MORITA Kazutaka
Without this patch, iov_send_recv() never returns when do_send_recv() returns zero. Signed-off-by: MORITA Kazutaka --- util/iov.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/util/iov.c b/util/iov.c index cc6e837..f705586 100644 --- a/util/iov.c +++ b/util/iov.c @@ -202,6 +202,12 @@

[Qemu-devel] [PATCH 05/11] sheepdog: check return values of qemu_co_recv/send correctly

2013-07-23 Thread MORITA Kazutaka
qemu_co_recv/send return shorter length on error. Signed-off-by: MORITA Kazutaka --- block/sheepdog.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index 6f5ede4..567f52e 100644 --- a/block/sheepdog.c +++ b/block/sheepdog.c @@ -72

[Qemu-devel] [PATCH 01/11] ignore SIGPIPE in qemu-img and qemu-io

2013-07-23 Thread MORITA Kazutaka
This prevents the tools from being stopped when they write data to a closed connection in the other side. Signed-off-by: MORITA Kazutaka --- qemu-img.c | 4 qemu-io.c | 4 2 files changed, 8 insertions(+) diff --git a/qemu-img.c b/qemu-img.c index c55ca5c..919d464 100644 --- a/qemu-i

[Qemu-devel] [PATCH 00/11] sheepdog: reconnect server after connection failure

2013-07-23 Thread MORITA Kazutaka
Currently, if a sheepdog server exits, all the connecting VMs need to be restarted. This series implements a feature to reconnect the server, and enables us to do online sheepdog upgrade and avoid restarting VMs when sheepdog servers crash unexpectedly. MORITA Kazutaka (11): ignore SIGPIPE in q

Re: [Qemu-devel] [PATCH 0/3] dataplane: virtio-blk live migration with x-data-plane=on

2013-07-23 Thread Stefan Hajnoczi
On Fri, Jul 19, 2013 at 01:33:12PM +0800, yinyin wrote: > I use systemtap to test this patch,the migration will success. But I > found the dataplane will start again after migration start. the > virtio_blk_handle_output will start dataplane. Hi Yin Yin, Thank you for testing the patch. It

Re: [Qemu-devel] Emulating mips

2013-07-23 Thread Andreas Färber
Hello, Am 23.07.2013 07:16, schrieb Renich Bon Ciric: > I'm trying to run some rom file I got from a client. It's a sc2005 > processor; supposedly compatible with 4k. > > Anyway, I do this: > > qemu-system-mips -M mips -pflash 301-3100\ -\ user\ specified\ -\ > Full.bin -serial stdio > > The pr

Re: [Qemu-devel] [PATCH] watchdog: Remove break after exit

2013-07-23 Thread Andreas Färber
Am 23.07.2013 06:46, schrieb Stefan Weil: > This was dead code. > > Signed-off-by: Stefan Weil Reviewed-by: Andreas Färber Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Re: [Qemu-devel] [PATCH RFC qom-next 4/4] pcie_port: Turn PCIEPort and PCIESlot into abstract QOM types

2013-07-23 Thread Andreas Färber
Am 23.07.2013 09:07, schrieb Michael S. Tsirkin: > On Mon, Jul 22, 2013 at 11:04:49PM +0200, Andreas Färber wrote: >> For VMState I believe the real follow-up fix would be mst defining a >> central macro VMSTATE_PCI_DEVICE_AER_LOG() operating on PCIDevice. >> Why is that separate from VMSTATE_PCI_D

Re: [Qemu-devel] [PATCH qom-cpu] HACKING: Document vaddr type usage

2013-07-23 Thread Andreas Färber
Am 23.07.2013 08:33, schrieb Paolo Bonzini: > Il 22/07/2013 19:27, Peter Maydell ha scritto: >> On 22 July 2013 17:36, Andreas Färber wrote: >>> Signed-off-by: Andreas Färber >>> --- >>> HACKING | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/HACKING b/HACKING >>> index e73ac79..d

Re: [Qemu-devel] [qom-cpu PATCH 2/2] i386: disable PMU passthrough mode by default

2013-07-23 Thread Paolo Bonzini
Il 22/07/2013 21:25, Eduardo Habkost ha scritto: > Bug description: QEMU currently gets all bits from GET_SUPPORTED_CPUID > for CPUID leaf 0xA and passes them directly to the guest. This makes > the guest ABI depend on host kernel and host CPU capabilities, and > breaks live migration if we migrate

Re: [Qemu-devel] [PATCH for-1.6 01/11] ignore SIGPIPE in qemu-img and qemu-io

2013-07-23 Thread Paolo Bonzini
Il 23/07/2013 10:30, MORITA Kazutaka ha scritto: > This prevents the tools from being stopped when they write data to a > closed connection in the other side. > > Signed-off-by: MORITA Kazutaka > --- > qemu-img.c | 4 > qemu-io.c | 4 > 2 files changed, 8 insertions(+) > > diff --git

Re: [Qemu-devel] [PATCH 0/3] dataplane: virtio-blk live migration with x-data-plane=on

2013-07-23 Thread yinyin
Hi, Stefan: during the migration, the source, not the destination, will start dataplane again I think the process of migration with dataplane as follows: 1. migration begin to start 2. the migration source stop the dataplane 3. do migration ... 4. migration completed, the desti

Re: [Qemu-devel] [RFC PATCH] vga: Start supporting resolution not multiple of 16 correctly.

2013-07-23 Thread Fabio Fantoni
Il 18/06/2013 12:17, Frediano Ziglio ha scritto: Modern notebook support 1366x768 resolution. The resolution width is not multiple of 16 causing some problems. QEMU VGA emulation requires width resolution to be multiple of 8. VNC implementation requires width resolution to be multiple of 16. S

Re: [Qemu-devel] [PATCH 00/28] Memory API for 1.6: fix I/O port endianness mess

2013-07-23 Thread Paolo Bonzini
Il 22/07/2013 22:16, Hervé Poussineau ha scritto: >> PReP is an exception, but >> I think it could be rewritten to use an IOMMU memory region. > > PReP PCI I/O area is located at 0x8000, up to 0xbf7f (in main > memory space region), while ISA I/O area is at 0x8000, up to > 0x8000 (

Re: [Qemu-devel] [PATCH 0/3] dataplane: virtio-blk live migration with x-data-plane=on

2013-07-23 Thread Andreas Färber
Hi, Am 23.07.2013 11:19, schrieb yinyin: > Hi, Stefan: > during the migration, the source, not the destination, will start > dataplane again > I think the process of migration with dataplane as follows: > 1. migration begin to start > 2. the migration source stop the dataplane > 3

[Qemu-devel] [PATCH v2 1/7] AARCH64: Add A57 CPU to default AArch64 configuration and enable KVM

2013-07-23 Thread Mian M. Hamayun
From: "Mian M. Hamayun" Introduce the A57 cpu to the default AArch64 configuration and enable KVM for 64-bit guests only. Signed-off-by: Mian M. Hamayun --- configure |2 +- default-configs/aarch64-softmmu.mak |3 ++- 2 files changed, 3 insertions(+), 2 deleti

[Qemu-devel] [PATCH v2 2/7] Add the additional parent parameter to memory region init calls

2013-07-23 Thread Mian M. Hamayun
From: "Mian M. Hamayun" The memory region init calls require an additional parent parameter, so introduce a null parent parameter to make it happy. Signed-off-by: Mian M. Hamayun --- hw/arm/virt.c |2 +- hw/cpu/a57mpcore.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) d

[Qemu-devel] [PATCH v2 0/7] AARCH64 support on machvirt machine model using KVM

2013-07-23 Thread Mian M. Hamayun
From: "Mian M. Hamayun" This is the v2 of patch series that implements KVM support in QEMU for the ARMv8 Cortex A57 CPU. It depends on the previously submitted AArch64 preparation patch series v5 and machvirt patches, and uses the already available KVM in-kernel GIC support. Current implementatio

[Qemu-devel] [PATCH v2 6/7] AARCH64: Add SMP support for aarch64 processors

2013-07-23 Thread Mian M. Hamayun
From: Alexander Spyridakis AArch64 uses a cpu-release-addr memory location (defined in the dts) as a way to inform secondary CPUs where to jump to and enter their holding pen. Inject a very simple bootloader that polls this memory location, until the primary CPU sets it to the right address. Sig

[Qemu-devel] [PATCH v2 4/7] AARCH64: Add boot support for aarch64 processor

2013-07-23 Thread Mian M. Hamayun
From: "Mian M. Hamayun" This version supports booting of a single Aarch64 CPU by setting appropriate registers. The bootloader includes placehoders for Board-ID that are used to implementing uniform indexing across different bootloaders. The same macro names are used with different values when co

Re: [Qemu-devel] [PATCH v2 01/11] block: replace in_use with refcnt_soft and refcnt_hard

2013-07-23 Thread Stefan Hajnoczi
On Wed, Jul 17, 2013 at 05:42:06PM +0800, Fam Zheng wrote: > Introduce refcnt_soft (soft reference) and refcnt_hard (hard reference) > to BlockDriverState, since in_use mechanism cannot provide proper > management of lifecycle when a BDS is referenced in multiple places > (e.g. pointed to by anothe

[Qemu-devel] [PATCH v2 5/7] AARCH64: Disable the non-aarch64 specific reset code

2013-07-23 Thread Mian M. Hamayun
From: "Mian M. Hamayun" This commit disables the co-processor registers reset code for KVM, when compiling for AArch64 cpus. Signed-off-by: Mian M. Hamayun --- target-arm/kvm.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/target-arm/kvm.c b/target-arm/kvm.c index c96b871..5909d75 1

[Qemu-devel] [PATCH v2 3/7] AARCH64: Add aarch64 CPU initialization, get and put registers support

2013-07-23 Thread Mian M. Hamayun
From: "Mian M. Hamayun" The cpu init function tries to initialize with all possible cpu types, as KVM does not provide a means to detect the real cpu type and simply refuses to initialize on cpu type mis-match. By using the loop based init function, we avoid the need to modify code if the underly

[Qemu-devel] [PATCH v2 7/7] AARCH64: Use the spin-table method for booting secondary processors in machvirt

2013-07-23 Thread Mian M. Hamayun
From: "Mian M. Hamayun" As the SMP bootloader uses a spin-table to wait for the cpu_release_addr, we disable the PSCI method for AArch64 in machvirt and use spin-table instead. The CPU_RELEASE_OFFSET is introduced in machvirt and is to calculate the cpu_release_addr by addition of this value to

Re: [Qemu-devel] [PATCH v2 2/7] Add the additional parent parameter to memory region init calls

2013-07-23 Thread Andreas Färber
Am 23.07.2013 11:33, schrieb Mian M. Hamayun: > From: "Mian M. Hamayun" > > The memory region init calls require an additional parent parameter, so > introduce a null parent parameter to make it happy. > > Signed-off-by: Mian M. Hamayun This is not OK for something labelled "PATCH". Patch seri

Re: [Qemu-devel] [PATCH 0/3] dataplane: virtio-blk live migration with x-data-plane=on

2013-07-23 Thread yinyin
Hi, 在 2013-7-23,下午5:30,Andreas Färber 写道: > Hi, > > Am 23.07.2013 11:19, schrieb yinyin: >> Hi, Stefan: >> during the migration, the source, not the destination, will start >> dataplane again >> I think the process of migration with dataplane as follows: >> 1. migration begin to s

Re: [Qemu-devel] [PATCH v2 04/11] block: use refcnt for device attach/detach

2013-07-23 Thread Stefan Hajnoczi
On Wed, Jul 17, 2013 at 05:42:09PM +0800, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > block.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/block.c b/block.c > index 7b46669..57a3876 100644 > --- a/block.c > +++ b/block.c > @@ -1622,6 +1622,7 @@ int bdrv_attach_dev(BlockDriv

Re: [Qemu-devel] [PATCH v2 05/11] migration: omit drive ref as we have bdrv_ref now

2013-07-23 Thread Stefan Hajnoczi
On Wed, Jul 17, 2013 at 05:42:10PM +0800, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > block-migration.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/block-migration.c b/block-migration.c > index d558410..d14f4eb 100644 > --- a/block-migration.c > +++ b/block-migration.c > @@

Re: [Qemu-devel] [PATCH v2 06/11] xen_disk: simplify blk_disconnect with refcnt

2013-07-23 Thread Stefan Hajnoczi
On Wed, Jul 17, 2013 at 05:42:11PM +0800, Fam Zheng wrote: > We call bdrv_attach_dev when initializing whether or not bs is created > locally, so call bdrv_detach_dev and let the refcnt handle the > lifecycle. > > Signed-off-by: Fam Zheng > --- > hw/block/xen_disk.c | 7 +-- > 1 file changed

Re: [Qemu-devel] [PATCH v2 07/11] block: hold hard reference for backup/mirror target

2013-07-23 Thread Stefan Hajnoczi
On Wed, Jul 17, 2013 at 05:42:12PM +0800, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > block/backup.c | 3 ++- > block/mirror.c | 4 ++-- > 2 files changed, 4 insertions(+), 3 deletions(-) Should we update the blockjob.c in_use code instead of adding refcounting to specific block jobs? T

Re: [Qemu-devel] [PATCH RFC qom-next 4/4] pcie_port: Turn PCIEPort and PCIESlot into abstract QOM types

2013-07-23 Thread Michael S. Tsirkin
On Tue, Jul 23, 2013 at 11:10:45AM +0200, Andreas Färber wrote: > Am 23.07.2013 09:07, schrieb Michael S. Tsirkin: > > On Mon, Jul 22, 2013 at 11:04:49PM +0200, Andreas Färber wrote: > >> For VMState I believe the real follow-up fix would be mst defining a > >> central macro VMSTATE_PCI_DEVICE_AER_

Re: [Qemu-devel] [PATCH 0/3] dataplane: virtio-blk live migration with x-data-plane=on

2013-07-23 Thread Andreas Färber
Am 23.07.2013 11:43, schrieb yinyin: > 在 2013-7-23,下午5:30,Andreas Färber 写道: >> Am 23.07.2013 11:19, schrieb yinyin: >>> during the migration, the source, not the destination, will start >>> dataplane again >>> I think the process of migration with dataplane as follows: >>> 1. migrati

Re: [Qemu-devel] [PATCH v2 2/7] Add the additional parent parameter to memory region init calls

2013-07-23 Thread Peter Maydell
On 23 July 2013 10:43, Andreas Färber wrote: > Am 23.07.2013 11:33, schrieb Mian M. Hamayun: >> From: "Mian M. Hamayun" >> >> The memory region init calls require an additional parent parameter, so >> introduce a null parent parameter to make it happy. >> >> Signed-off-by: Mian M. Hamayun > > Th

Re: [Qemu-devel] [PATCH v2 2/7] Add the additional parent parameter to memory region init calls

2013-07-23 Thread Andreas Färber
Am 23.07.2013 12:00, schrieb Peter Maydell: > On 23 July 2013 10:43, Andreas Färber wrote: >> Am 23.07.2013 11:33, schrieb Mian M. Hamayun: >>> From: "Mian M. Hamayun" >>> >>> The memory region init calls require an additional parent parameter, so >>> introduce a null parent parameter to make it

Re: [Qemu-devel] [PATCH v2 11/11] qmp: add command 'blockdev-backup'

2013-07-23 Thread Stefan Hajnoczi
On Fri, Jul 19, 2013 at 06:16:55PM +0800, Wenchao Xia wrote: > 于 2013-7-18 12:41, Fam Zheng 写道: > >On Wed, 07/17 06:44, Eric Blake wrote: > >>On 07/17/2013 03:42 AM, Fam Zheng wrote: > >>>Similar to drive-backup, but this command uses a device id as target > >>>instead of creating/opening an image

Re: [Qemu-devel] [PATCH RFC qom-next 4/4] pcie_port: Turn PCIEPort and PCIESlot into abstract QOM types

2013-07-23 Thread Andreas Färber
Am 23.07.2013 11:59, schrieb Michael S. Tsirkin: > On Tue, Jul 23, 2013 at 11:10:45AM +0200, Andreas Färber wrote: >> Am 23.07.2013 09:07, schrieb Michael S. Tsirkin: >>> On Mon, Jul 22, 2013 at 11:04:49PM +0200, Andreas Färber wrote: For VMState I believe the real follow-up fix would be mst d

Re: [Qemu-devel] [RFC 0/8] arm AioContext with its own timer stuff

2013-07-23 Thread Paolo Bonzini
Il 23/07/2013 04:53, liu ping fan ha scritto: > The scenior I can figure out is if adopting timeout of poll, then when > changing the deadline, we need to invoke poll, and set the new > timeout, right? Yes, you need to call aio_notify so that poll is reinvoked. Paolo

Re: [Qemu-devel] [PATCH qom-cpu v3 00/41] QOM CPUState, part 11: GDB stub

2013-07-23 Thread Max Filippov
On Wed, Jul 10, 2013 at 2:23 AM, Andreas Färber wrote: > Hello, > > This series cleans up gdbstub by changing all its internal CPU state to > CPUState > and by moving most target-specific code into the target directories. > > Support for m68k, moxie and unicore32 to set the PC via gdbstub is adde

[Qemu-devel] [PULL 0/3] OpenRISC patch queue

2013-07-23 Thread Jia Liu
Hi Anthony, This is my OpenRISC patch queue, and myfirst time to send a pull requests, please pull. It fix OpenRISC CPU and sim broad: * Free typename in openrisc_cpu_class_by_name * Use stderr output in openrisc_sim.c * fixed a indent typo. The following changes since commit 3464700f6aecb3e2aa

[Qemu-devel] [PULL 1/3] hw/openrisc: Indent typo

2013-07-23 Thread Jia Liu
Indent typo. Signed-off-by: Jia Liu Reviewed-by: Peter Maydell Reviewed-by: Andreas Färber --- hw/openrisc/openrisc_sim.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/openrisc/openrisc_sim.c b/hw/openrisc/openrisc_sim.c index 924438b..250f5b5 100644 --- a/hw/openrisc/

Re: [Qemu-devel] [PATCH v2 01/11] block: replace in_use with refcnt_soft and refcnt_hard

2013-07-23 Thread Fam Zheng
On Tue, 07/23 11:36, Stefan Hajnoczi wrote: > On Wed, Jul 17, 2013 at 05:42:06PM +0800, Fam Zheng wrote: > > Introduce refcnt_soft (soft reference) and refcnt_hard (hard reference) > > to BlockDriverState, since in_use mechanism cannot provide proper > > management of lifecycle when a BDS is refere

[Qemu-devel] [PULL 3/3] target-openrisc: Free typename in openrisc_cpu_class_by_name

2013-07-23 Thread Jia Liu
We should free typename here. Signed-off-by: Jia Liu Reviewed-by: Andreas Färber --- target-openrisc/cpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target-openrisc/cpu.c b/target-openrisc/cpu.c index 6d40f1b..e348df0 100644 --- a/target-openrisc/cpu.c +++ b/target-openrisc/cpu.c @@ -

[Qemu-devel] [PULL 2/3] hw/openrisc: Use stderr output instead of qemu_log

2013-07-23 Thread Jia Liu
We should use stderr output instead of qemu_log in order to output ErrMsg onto the screen. Signed-off-by: Jia Liu Reviewed-by: Peter Maydell Reviewed-by: Andreas Färber --- hw/openrisc/openrisc_sim.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/openrisc/openrisc_s

Re: [Qemu-devel] [PATCH 1/2] block: allow live commit of active image

2013-07-23 Thread Paolo Bonzini
Il 23/07/2013 04:03, Fam Zheng ha scritto: >> > stop >> > block-job-complete ide0-hd0 >> > cont >> > > I see, this way the job needs to stop vm in the point of all copying > drained, then report 'ready' and wait for manual complete before > swapping active, sounds not so good. Ideally

Re: [Qemu-devel] [PATCH RFC qom-next 4/4] pcie_port: Turn PCIEPort and PCIESlot into abstract QOM types

2013-07-23 Thread Gerd Hoffmann
Hi, > Okay, so if it's just PCIe, then XHCI is the oddball preventing moving > it into VMSTATE_PCIE_DEVICE(). XHCI has VMSTATE_MSIX() in its place, > also operating on PCIDevice. Given that live migration support for xhci was added post-1.5 so we don't have a release with it yet this shouldn't

Re: [Qemu-devel] [RFC PATCH] vga: Start supporting resolution not multiple of 16 correctly.

2013-07-23 Thread Gerd Hoffmann
Hi, > Tested-by: Fabio Fantoni > > I tested it for a long time with spice on xen (because qxl will be fully > working only after adding SSE support on hvm domUs). It works, I think > it is good to add this and the respective vgabios patch on upstream. >> case VBE_DISPI_INDEX_XRES: >>

Re: [Qemu-devel] [PATCH 02/11] iov: handle EOF in iov_send_recv

2013-07-23 Thread Paolo Bonzini
Il 23/07/2013 10:30, MORITA Kazutaka ha scritto: > Without this patch, iov_send_recv() never returns when do_send_recv() > returns zero. > > Signed-off-by: MORITA Kazutaka > --- > util/iov.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/util/iov.c b/util/iov.c > index cc6e837..

Re: [Qemu-devel] [PATCH 03/11] qemu-sockets: make wait_for_connect be invoked in qemu_aio_wait

2013-07-23 Thread Paolo Bonzini
Il 23/07/2013 10:30, MORITA Kazutaka ha scritto: > This allows us to use inet_nonblocking_connect() and > unix_nonblocking_connect() in block drivers. > > qemu-ga needs to link block-obj to resolve dependencies of > qemu_aio_set_fd_handler(). > > Signed-off-by: MORITA Kazutaka I'm not sure this

Re: [Qemu-devel] [Question] why x2apic's set by default without host support(on Nehalem CPU).

2013-07-23 Thread Jiri Denemark
On Tue, Jul 23, 2013 at 10:44:48 +0800, Peter Huang(Peng) wrote: > > libvirt's "host-passthrough" uses "-cpu host', and it "-cpu host" > > enables every feature that can be enabled on the host. > From my test results, I found that even when use host-passthrough mode, VM's > cpu features are very di

Re: [Qemu-devel] [PATCH 0/7] s390 fixes

2013-07-23 Thread Christian Borntraeger
On 15/07/13 21:57, Christian Borntraeger wrote: > Alex, > > here is a bunch of fixes/cleanups for s390. > > Heinz Graalfs (1): > s390/sclpconsole: handle char layer busy conditions > > Thomas Huth (6): > s390x/ioinst: Add missing alignment checks for IO instructions > s390x/ioinst: Throw a

Re: [Qemu-devel] [PATCH V6 0/3] Implement sync modes for drive-backup.

2013-07-23 Thread Stefan Hajnoczi
On Mon, Jul 22, 2013 at 03:09:17PM -0700, Ian Main wrote: > This patch adds sync modes on top of the work that Stefan Hajnoczi has done. > > These patches apply on kevin/block. > > Hopefully all is in order as this is my first QEMU patch. Many thanks to > Stephan and Fam Zheng for their help. >

[Qemu-devel] [PATCH v2] spice: fix display initialization

2013-07-23 Thread Gerd Hoffmann
Spice has two display interface implementations: One integrated into the qxl graphics card, and one generic which can operate with every qemu-emulated graphics card. The generic one is activated in case spice is used without qxl. The logic for that only caught the "-vga qxl" case, "-device qxl-v

Re: [Qemu-devel] [RFC PATCH v1 1/2] gluster: Use pkg-config to configure GlusterFS block driver

2013-07-23 Thread Daniel P. Berrange
On Fri, Jul 12, 2013 at 12:28:54PM +0530, Bharata B Rao wrote: > gluster: Use pkg-config to configure GlusterFS block driver > > Use pkg-config to determine the version and library dependency > for GlusterFS block driver. > > Signed-off-by: Bharata B Rao > --- > configure | 20 +++

Re: [Qemu-devel] [RFC PATCH v1 1/2] gluster: Use pkg-config to configure GlusterFS block driver

2013-07-23 Thread Anand Avati
On 7/23/13 4:57 AM, Daniel P. Berrange wrote: On Fri, Jul 12, 2013 at 12:28:54PM +0530, Bharata B Rao wrote: gluster: Use pkg-config to configure GlusterFS block driver Use pkg-config to determine the version and library dependency for GlusterFS block driver. Signed-off-by: Bharata B Rao ---

Re: [Qemu-devel] [RFC PATCH v1 1/2] gluster: Use pkg-config to configure GlusterFS block driver

2013-07-23 Thread Daniel P. Berrange
On Tue, Jul 23, 2013 at 05:02:20AM -0700, Anand Avati wrote: > On 7/23/13 4:57 AM, Daniel P. Berrange wrote: > >On Fri, Jul 12, 2013 at 12:28:54PM +0530, Bharata B Rao wrote: > >>gluster: Use pkg-config to configure GlusterFS block driver > >> > >>Use pkg-config to determine the version and library

Re: [Qemu-devel] RFC [PATCH] Make bdrv_flush synchronous only and update callers

2013-07-23 Thread Stefan Hajnoczi
On Fri, Jul 19, 2013 at 10:37:11AM +0200, Kevin Wolf wrote: > Am 19.07.2013 um 07:27 hat Stefan Hajnoczi geschrieben: > > On Thu, Jul 18, 2013 at 11:21:42PM +0200, Charlie Shepherd wrote: > > > This patch makes bdrv_flush a synchronous function and updates any > > > callers from > > > a coroutine

Re: [Qemu-devel] RFC [PATCH] Make bdrv_flush synchronous only and update callers

2013-07-23 Thread Gabriel Kerneis
On Tue, Jul 23, 2013 at 02:05:15PM +0200, Stefan Hajnoczi wrote: > A built-time check for coroutine_fn would be valuable if we ever hope to > get disciplined with this annotation. > > The check can detect when a coroutine_fn is invoked outside coroutine > context. I wonder if Coccinelle can detec

Re: [Qemu-devel] [RFC PATCH v1 1/2] gluster: Use pkg-config to configure GlusterFS block driver

2013-07-23 Thread Daniel P. Berrange
On Tue, Jul 23, 2013 at 05:37:54PM +0530, Kaleb KEITHLEY wrote: > On 07/23/2013 05:32 PM, Anand Avati wrote: > >On 7/23/13 4:57 AM, Daniel P. Berrange wrote: > >>On Fri, Jul 12, 2013 at 12:28:54PM +0530, Bharata B Rao wrote: > >>>gluster: Use pkg-config to configure GlusterFS block driver > >>> > >

[Qemu-devel] [PATCH V2 for-1.6 0/5] Leaky bucket throttling and features

2013-07-23 Thread Benoît Canet
The first patch fixes the throttling which was broken by a previous commit. The next patch replace the existing throttling algorithm by the well described leaky bucket algorithm. Third patch implement bursting by adding *_threshold parameters to qmp_block_set_io_throttle. The last one allow to d

[Qemu-devel] [PATCH V2 for-1.6 1/5] block: Repair the throttling code.

2013-07-23 Thread Benoît Canet
The throttling code was segfaulting since commit 02ffb504485f0920cfc75a0982a602f824a9a4f4 because some qemu_co_queue_next caller does not run in a coroutine. qemu_co_queue_do_restart assume that the caller is a coroutinne. As sugested by Stefan fix this by entering the coroutine directly. Signed-o

Re: [Qemu-devel] [PATCH 0/9] Add platform bus

2013-07-23 Thread Paolo Bonzini
Il 22/07/2013 20:21, Peter Maydell ha scritto: >> > Platforms without ISA and/or PCI have had a seriously hard time in the >> > dynamic >> > device creation world of QEMU. Devices on these were modeled as SysBus >> > devices >> > which can only be instantiated in machine files, not through -devic

[Qemu-devel] [PATCH V2 for-1.6 3/5] block: Add support for throttling burst threshold in QMP and the command line.

2013-07-23 Thread Benoît Canet
The thresholds of the leaky bucket algorithm can be used to allow some burstiness. Signed-off-by: Benoit Canet --- block/qapi.c | 24 + blockdev.c | 105 +++--- hmp.c| 32 +++-- qapi-schema.json |

[Qemu-devel] [PATCH V2 for-1.6 2/5] block: Modify the throttling code to implement the leaky bucket algorithm.

2013-07-23 Thread Benoît Canet
This patch replace the previous algorithm by the well described leaky bucket algorithm: A bucket is filled by the incoming IOs and a periodic timer decrement the counter to make the bucket leak. When a given threshold is reached the bucket is full and the IOs are hold. In this patch the threshold

[Qemu-devel] [PATCH V2 for-1.6 4/5] block: Add iops_sector_count to do the iops accounting for a given io size.

2013-07-23 Thread Benoît Canet
This feature can be used in case where users are avoiding the iops limit by doing jumbo I/Os hammering the storage backend. Signed-off-by: Benoit Canet --- block.c |8 +++- block/qapi.c |4 blockdev.c| 22 +- h

[Qemu-devel] [PATCH V2 for-1.6 5/5] block: Add throttling percentage metrics.

2013-07-23 Thread Benoît Canet
This metrics show how many percent of the time I/Os are put on hold by the throttling algorithm. This metric could be used by system administrators or cloud stack developpers to decide when the throttling settings must be changed. Signed-off-by: Benoit Canet --- block.c | 17

Re: [Qemu-devel] [PATCH 0/9] Add platform bus

2013-07-23 Thread Peter Maydell
On 23 July 2013 13:19, Paolo Bonzini wrote: > Il 22/07/2013 20:21, Peter Maydell ha scritto: >>> > Platforms without ISA and/or PCI have had a seriously hard time in the >>> > dynamic >>> > device creation world of QEMU. Devices on these were modeled as SysBus >>> > devices >>> > which can only

Re: [Qemu-devel] Question on aio_poll

2013-07-23 Thread Stefan Hajnoczi
On Sat, Jul 20, 2013 at 02:14:43PM +0100, Alex Bligh wrote: > As part of adding timer operations to aio_poll and a clock to AioContext, I > am trying to figure out a couple of points on how aio_poll works. This > primarily revolves around the flag busy. > > Firstly, at the end of aio_poll, it has

Re: [Qemu-devel] [PATCH] gluster: Add image resize support

2013-07-23 Thread Stefan Hajnoczi
On Fri, Jul 19, 2013 at 07:51:33PM +0530, Bharata B Rao wrote: > From: Paolo Bonzini > > Implement .bdrv_truncate in GlusterFS block driver so that GlusterFS backend > can support image resizing. > > Signed-off-by: Paolo Bonzini > Signed-off-by: Bharata B Rao > Tested-by: Bharata B Rao > ---

Re: [Qemu-devel] [PATCH 0/9] Add platform bus

2013-07-23 Thread François Revol
On 23/07/2013 14:19, Paolo Bonzini wrote: > Il 22/07/2013 20:21, Peter Maydell ha scritto: >> > Platforms without ISA and/or PCI have had a seriously hard time in >> > the dynamic >> > device creation world of QEMU. Devices on these were modeled as >> > SysBus devices >>

Re: [Qemu-devel] APM regression since v1.3.0-408-g9ee59f3

2013-07-23 Thread Gerd Hoffmann
On 07/03/13 22:25, Sebastian Herbszt wrote: > Commit 9ee59f3 ("pc: remove bochs bios debug ports") broke the APM > interface > between QEMU and Bochs BIOS/SeaBIOS. Without APM support older guests > are no longer able to power off the VM. This regression also affects > older machine > types like pc

Re: [Qemu-devel] [PATCH RFC qom-next 4/4] pcie_port: Turn PCIEPort and PCIESlot into abstract QOM types

2013-07-23 Thread Michael S. Tsirkin
On Tue, Jul 23, 2013 at 01:21:13PM +0200, Gerd Hoffmann wrote: > Hi, > > > Okay, so if it's just PCIe, then XHCI is the oddball preventing moving > > it into VMSTATE_PCIE_DEVICE(). XHCI has VMSTATE_MSIX() in its place, > > also operating on PCIDevice. > > Given that live migration support for x

Re: [Qemu-devel] [PATCH 0/9] Add platform bus

2013-07-23 Thread Paolo Bonzini
Il 23/07/2013 14:22, Peter Maydell ha scritto: > On 23 July 2013 13:19, Paolo Bonzini wrote: >> Il 22/07/2013 20:21, Peter Maydell ha scritto >>> you can't as a user of this sort of hardware >>> plug in an extra serial port to a SoC, because there's just nowhere >>> to plug it in. So why should it

Re: [Qemu-devel] [PATCH 0/9] Add platform bus

2013-07-23 Thread Peter Maydell
On 23 July 2013 13:34, Paolo Bonzini wrote: > Il 23/07/2013 14:22, Peter Maydell ha scritto: >> On 23 July 2013 13:19, Paolo Bonzini wrote: >>> Il 22/07/2013 20:21, Peter Maydell ha scritto you can't as a user of this sort of hardware plug in an extra serial port to a SoC, because there

Re: [Qemu-devel] [PATCH v2 1/2] ps2: add support of auto-repeat

2013-07-23 Thread Gerd Hoffmann
On 07/02/13 08:49, Amos Kong wrote: > Actually it's not a urgent/necessary request. Host provided > auto-repeat works, and we didn't have real application of holding > key by sendkey command now. So it's a solution for a non-existing problem ... Which guests do care about the hardware repeat rate

[Qemu-devel] QCOW2 cryptography and secure key handling

2013-07-23 Thread Benoît Canet
Hi, I have some budget to improve QCOW2's cryptography. My main concern is that the QCOW2 image crypto key is passed in clear text. Do you (the block maintainers) have an idea on how the code could be improved to securely pass the crypto key to the QCOW2 code ? Best regards Benoît

Re: [Qemu-devel] KVM call agenda for 2013-07-30

2013-07-23 Thread Peter Maydell
On 23 July 2013 08:55, Christian Borntraeger wrote: > - soft reset and other reset variants. What is the right way to go? > (e.g. on s390 there are several reset variants that reset a defined subset of > the > system. This can be triggered by operating systems, e.g. kdump uses a diagnose > instru

Re: [Qemu-devel] QCOW2 cryptography and secure key handling

2013-07-23 Thread Daniel P. Berrange
On Tue, Jul 23, 2013 at 02:47:06PM +0200, Benoît Canet wrote: > > Hi, > > I have some budget to improve QCOW2's cryptography. > > My main concern is that the QCOW2 image crypto key is passed in clear text. That is only a problem if someone can sniff the communications channel used by the monito

[Qemu-devel] [PATCH 01/18] qapi-types.py: Split off generate_struct_fields()

2013-07-23 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- scripts/qapi-types.py | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py index ddcfed9..e1239e1 100644 --- a/scripts/qapi-types.py +++ b/scripts/qapi-types.py @@ -57,12 +57,8 @@ typed

[Qemu-devel] [PATCH 09/18] qapi.py: Maintain a list of union types

2013-07-23 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- scripts/qapi.py | 13 + 1 file changed, 13 insertions(+) diff --git a/scripts/qapi.py b/scripts/qapi.py index baf1321..3a54c7f 100644 --- a/scripts/qapi.py +++ b/scripts/qapi.py @@ -105,6 +105,7 @@ def parse_schema(fp): if expr_eval.has_key('enu

[Qemu-devel] [PATCH 00/18] 'blockdev-add' QMP command

2013-07-23 Thread Kevin Wolf
Kevin Wolf (18): qapi-types.py: Split off generate_struct_fields() qapi-types.py: Implement 'base' for unions qapi-visit.py: Split off generate_visit_struct_fields() qapi-visit.py: Implement 'base' for unions docs: Document QAPI union types qapi: Add visitor for implicit structs qapi:

[Qemu-devel] [PATCH 04/18] qapi-visit.py: Implement 'base' for unions

2013-07-23 Thread Kevin Wolf
This implements the visitor part of base types for unions. Parsed into QMP, this example schema definiton... { 'type': 'BlockOptionsBase', 'data': { 'read-only': 'bool' } } { 'type': 'BlockOptionsQcow2, 'data': { 'lazy-refcounts': 'bool' } } { 'union': 'BlockOptions', 'base': 'B

[Qemu-devel] [PATCH 03/18] qapi-visit.py: Split off generate_visit_struct_fields()

2013-07-23 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- scripts/qapi-visit.py | 62 --- 1 file changed, 34 insertions(+), 28 deletions(-) diff --git a/scripts/qapi-visit.py b/scripts/qapi-visit.py index 6cac05a..a337d80 100644 --- a/scripts/qapi-visit.py +++ b/scripts/qapi-

[Qemu-devel] [PATCH 06/18] qapi: Add visitor for implicit structs

2013-07-23 Thread Kevin Wolf
These can be used when an embedded struct is parsed and members not belonging to the struct may be present in the input (e.g. parsing a flat namespace QMP union, where fields from both the base and one of the alternative types are mixed in the JSON object) Signed-off-by: Kevin Wolf --- include/q

[Qemu-devel] [PATCH 02/18] qapi-types.py: Implement 'base' for unions

2013-07-23 Thread Kevin Wolf
The new 'base' key in a union definition refers to a struct type, which is inlined into the union definition and can represent fields common to all kinds. For example the following schema definition... { 'type': 'BlockOptionsBase', 'data': { 'read-only': 'bool' } } { 'union': 'BlockOptio

[Qemu-devel] [PATCH 11/18] block: Allow "driver" option on the top level

2013-07-23 Thread Kevin Wolf
This is traditionally -drive format=..., which is now translated into the new driver option. This gives us a more consistent way to select the driver of BlockDriverStates that can be used in QMP context, too. Signed-off-by: Kevin Wolf --- block.c| 7 +++ blockdev.c | 20 ++--

[Qemu-devel] [PATCH 05/18] docs: Document QAPI union types

2013-07-23 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- docs/qapi-code-gen.txt | 58 +- 1 file changed, 53 insertions(+), 5 deletions(-) diff --git a/docs/qapi-code-gen.txt b/docs/qapi-code-gen.txt index cccb11e..555ca66 100644 --- a/docs/qapi-code-gen.txt +++ b/docs/qapi-c

[Qemu-devel] [PATCH 12/18] QemuOpts: Add qemu_opt_unset()

2013-07-23 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- include/qemu/option.h | 1 + util/qemu-option.c| 14 ++ 2 files changed, 15 insertions(+) diff --git a/include/qemu/option.h b/include/qemu/option.h index a83c700..13f5e72 100644 --- a/include/qemu/option.h +++ b/include/qemu/option.h @@ -120,6 +120

  1   2   3   >