Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-07-12 Thread Amos Kong
On Fri, Jul 12, 2013 at 08:32:29AM +0200, Markus Armbruster wrote: > Amos Kong writes: > > > On Thu, Jul 04, 2013 at 08:28:59AM +0200, Markus Armbruster wrote: > >> Amos Kong writes: > >> > >> > On Tue, Jul 02, 2013 at 03:27:12PM +0200, Markus Armbruster wrote: > >> >> Amos Kong writes: > >> >

[Qemu-devel] [PATCH 1/6] pseries: savevm support for VIO devices

2013-07-12 Thread Alexey Kardashevskiy
From: David Gibson This patch adds helpers to allow PAPR VIO devices to save state common to all VIO devices during savevm. Signed-off-by: David Gibson Reviewed-by: Anthony Liguori Signed-off-by: Alexey Kardashevskiy --- hw/ppc/spapr_vio.c | 20 include/hw/ppc/sp

[Qemu-devel] [PATCH 0/6] spapr: migration for vio, vio-lan, vio-tty, pseries, pci, ppc cpu

2013-07-12 Thread Alexey Kardashevskiy
Here are 5 patches "reviewed by Anthony" and one patch (the last one) where I fixed comments. Could be pulled into some tree I guess. Thanks. David Gibson (6): pseries: savevm support for VIO devices pseries: savevm support for PAPR VIO logical lan pseries: savevm support for PAPR VIO logica

[Qemu-devel] [PATCH 2/6] pseries: savevm support for PAPR VIO logical lan

2013-07-12 Thread Alexey Kardashevskiy
From: David Gibson This patch adds the necessary VMStateDescription information to support savevm/loadvm for the spapr_llan (PAPR logical lan) device. Signed-off-by: David Gibson Reviewed-by: Anthony Liguori Signed-off-by: Alexey Kardashevskiy --- hw/net/spapr_llan.c | 24 +++

[Qemu-devel] [PATCH 3/6] pseries: savevm support for PAPR VIO logical tty

2013-07-12 Thread Alexey Kardashevskiy
From: David Gibson This patch adds the necessary VMStateDescription information to support savevm/loadvm for the spapr_tty (PAPR logical serial) device. Signed-off-by: David Gibson Reviewed-by: Anthony Liguori Signed-off-by: Alexey Kardashevskiy --- hw/char/spapr_vty.c | 16

[Qemu-devel] [PATCH 4/6] pseries: savevm support for pseries machine

2013-07-12 Thread Alexey Kardashevskiy
From: David Gibson This adds the necessary pieces to implement savevm / migration for the pseries machine. The most complex part here is migrating the hash table - for the paravirtualized pseries machine the guest's hash page table is not stored within guest memory, but externally and the guest

[Qemu-devel] [PATCH 6/6] target-ppc: Convert ppc cpu savevm to VMStateDescription

2013-07-12 Thread Alexey Kardashevskiy
From: David Gibson The savevm code for the powerpc cpu emulation is currently based around the old register_savevm() rather than register_vmstate() method. It's also rather broken, missing some important state on some CPU models. This patch completely rewrites the savevm for target-ppc, using t

[Qemu-devel] [PATCH 5/6] pseries: savevm support for PCI host bridge

2013-07-12 Thread Alexey Kardashevskiy
From: David Gibson This adds the necessary support for saving the state of the PAPR virtual PCI host bridge (or host bridges). Signed-off-by: David Gibson Reviewed-by: Anthony Liguori Signed-off-by: Alexey Kardashevskiy --- hw/ppc/spapr_pci.c | 49 +++

[Qemu-devel] [PATCH] spapr-pci: change endianness for io ports space

2013-07-12 Thread Alexey Kardashevskiy
sPAPR PHB emulates IO ports on PCI via a special memory region which routes all reads/writes further via cpu_in*/cpu_out* which are eventually processed by MemoryRegionOps implemented by devices. As devices normally take care of endianness themselves by setting correct MemoryRegionOps::endianness

[Qemu-devel] [PATCH] spapr-pci: rework MSI/MSIX

2013-07-12 Thread Alexey Kardashevskiy
On the sPAPR platform a guest allocates MSI/MSIX vectors via RTAS hypercalls which return global IRQ numbers to a guest so it only operates with those and never touches MSIMessage. Therefore MSIMessage handling is completely hidden in QEMU. Previously every sPAPR PCI host bridge implemented its o

Re: [Qemu-devel] [Xen-devel] [PATCH v2] libxl: usb2 and usb3 controller support for upstream qemu

2013-07-12 Thread Fabio Fantoni
Il 11/07/2013 17:56, Dario Faggioli ha scritto: On gio, 2013-07-11 at 12:33 +0200, Fabio Fantoni wrote: Usage: usbversion=1|2|3 (default=2) Specifies the type of an emulated USB bus in the guest. 1 for usb1, 2 for usb2 and 3 for usb3, it is available only with upstream qemu. Default is 2. Signe

Re: [Qemu-devel] [RFC PATCH 08/11] qapi: Anonymous unions

2013-07-12 Thread Kevin Wolf
Am 11.07.2013 um 21:47 hat Eric Blake geschrieben: > On 07/09/2013 03:53 AM, Kevin Wolf wrote: > > The discriminator for anonymous unions is the data type. This allows to > > have a union type that allows both of these: > > > > { 'file': 'my_existing_block_device_id' } > > { 'file': { 'fil

[Qemu-devel] BUG report Re: [PATCH] spapr-pci: change endianness for io ports space

2013-07-12 Thread Alexey Kardashevskiy
Hi! Got a small lesson from Ben how to post stuff to the list and here are more details :) Every PCI device which uses IO ports (at least vga, e1000, virtio-pci, rtl8139) is broken in the master branch of QEMU for powerpc-kvm. The problem is exactly with endianness. For example, setup_vq() from d

Re: [Qemu-devel] [Xen-devel] [PATCH v2] libxl: usb2 and usb3 controller support for upstream qemu

2013-07-12 Thread Wei Liu
On Thu, Jul 11, 2013 at 12:33:57PM +0200, Fabio Fantoni wrote: > Usage: usbversion=1|2|3 (default=2) > Specifies the type of an emulated USB bus in the guest. 1 for usb1, > 2 for usb2 and 3 for usb3, it is available only with upstream qemu. > Default is 2. > > Signed-off-by: Fabio Fantoni > --- >

Re: [Qemu-devel] [Xen-devel] [PATCH v2] libxl: usb2 and usb3 controller support for upstream qemu

2013-07-12 Thread Ian Campbell
On Fri, 2013-07-12 at 10:08 +0100, Wei Liu wrote: > On Thu, Jul 11, 2013 at 12:33:57PM +0200, Fabio Fantoni wrote: > > diff --git a/tools/libxl/xl_sxp.c b/tools/libxl/xl_sxp.c > > index a16a025..2dc3a86 100644 > > --- a/tools/libxl/xl_sxp.c > > +++ b/tools/libxl/xl_sxp.c > > @@ -142,6 +142,7 @@ voi

Re: [Qemu-devel] [RFC] qapi: qapi-commands: fix possible leaks on visitor dealloc

2013-07-12 Thread Laszlo Ersek
On 07/11/13 21:14, Eric Blake wrote: > On 07/11/2013 12:50 PM, Luiz Capitulino wrote: >> I'm sending this as an RFC because this is untested, and also because >> I'm wondering if I'm seeing things after a long patch review session. > > I can't say that I tested it either, but... > >> >> The probl

Re: [Qemu-devel] [RFC PATCH 11/11] [WIP] block: Implement 'blockdev-add' QMP command

2013-07-12 Thread Kevin Wolf
Am 12.07.2013 um 00:45 hat Eric Blake geschrieben: > On 07/09/2013 03:53 AM, Kevin Wolf wrote: > > This is just a quick hack to test things > > The rest of the series is mostly good to go, but not worth pushing until > this is flushed out. But I love where it's headed! Glad to hear this! > > Si

Re: [Qemu-devel] [RFC PATCH 00/11] qapi changes in preparation for blockdev-add

2013-07-12 Thread Laszlo Ersek
On 07/09/13 11:53, Kevin Wolf wrote: > The goal of this series is to make QAPI ready to handle mostly unions in a > less > verbose way so that a future -blockdev command line option can be a > direct mapping of the structure used by a blockdev-add QMP command. This > series implements everything t

Re: [Qemu-devel] [PATCH 1/2] Add be16_to_cpupu function

2013-07-12 Thread Fabien Chouteau
On 07/10/2013 07:25 PM, Peter Maydell wrote: > On 10 July 2013 18:10, Fabien Chouteau wrote: >> --- a/include/qemu/bswap.h >> +++ b/include/qemu/bswap.h >> @@ -432,6 +432,11 @@ static inline uint32_t le32_to_cpupu(const uint32_t *p) >> return ldl_le_p(p); >> } >> >> +static inline uint16_t b

Re: [Qemu-devel] [PATCH v5 5/7] acpi: generate hotplug memory devices

2013-07-12 Thread Igor Mammedov
On Wed, 26 Jun 2013 17:15:03 +0800 Hu Tao wrote: > The memory device generation is guided by qemu paravirt info. Seabios > uses the info to setup SRAT entries for the hotplug-able memory slots, > and to generate appropriate memory device objects. One memory device > (and corresponding SRAT entry)

Re: [Qemu-devel] SPARC Leon3 Devices - Registers?

2013-07-12 Thread Fabien Chouteau
Hi Kaila, Sorry I missed your message. On 07/11/2013 02:23 PM, Artyom Tarasenko wrote: > Hi Kaila, > > On Mon, Jun 24, 2013 at 8:46 PM, Kaila Thornton > wrote: >> I'm currently working on trying to add more devices to the SPARC Leon3 >> machine, but I'm running into a few problems. >> What kin

[Qemu-devel] [PATCH v3] libxl: usb2 and usb3 controller support for upstream qemu

2013-07-12 Thread Fabio Fantoni
Usage: usbversion=1|2|3 (default=2) Specifies the type of an emulated USB bus in the guest. 1 for usb1, 2 for usb2 and 3 for usb3, it is available only with upstream qemu. Default is 2. Signed-off-by: Fabio Fantoni --- docs/man/xl.cfg.pod.5 |6 ++ tools/libxl/libxl_create.c |3

Re: [Qemu-devel] [RFC PATCH 00/11] qapi changes in preparation for blockdev-add

2013-07-12 Thread Kevin Wolf
Am 12.07.2013 um 11:55 hat Laszlo Ersek geschrieben: > On 07/09/13 11:53, Kevin Wolf wrote: > > The goal of this series is to make QAPI ready to handle mostly unions in a > > less > > verbose way so that a future -blockdev command line option can be a > > direct mapping of the structure used by a

Re: [Qemu-devel] [PATCH v3] libxl: usb2 and usb3 controller support for upstream qemu

2013-07-12 Thread George Dunlap
On 12/07/13 11:22, Fabio Fantoni wrote: Usage: usbversion=1|2|3 (default=2) Specifies the type of an emulated USB bus in the guest. 1 for usb1, 2 for usb2 and 3 for usb3, it is available only with upstream qemu. Default is 2. Signed-off-by: Fabio Fantoni --- docs/man/xl.cfg.pod.5 |6

Re: [Qemu-devel] [PATCH v3] libxl: usb2 and usb3 controller support for upstream qemu

2013-07-12 Thread Ian Campbell
On Fri, 2013-07-12 at 12:06 +0100, George Dunlap wrote: > On 12/07/13 11:22, Fabio Fantoni wrote: > > Usage: usbversion=1|2|3 (default=2) > > Specifies the type of an emulated USB bus in the guest. 1 for usb1, > > 2 for usb2 and 3 for usb3, it is available only with upstream qemu. > > Default is 2.

Re: [Qemu-devel] BUG report Re: [PATCH] spapr-pci: change endianness for io ports space

2013-07-12 Thread Alexander Graf
Am 12.07.2013 um 10:59 schrieb Alexey Kardashevskiy : > Hi! > > Got a small lesson from Ben how to post stuff to the list and here are more > details :) > > Every PCI device which uses IO ports (at least vga, e1000, virtio-pci, > rtl8139) is broken in the master branch of QEMU for powerpc-kvm.

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-07-12 Thread Benjamin Herrenschmidt
On Fri, 2013-07-12 at 05:18 +0200, Alexander Graf wrote: > We model a single system wide io space today and access to that one > happens through you pci host controller. I just messed up the > terminology here. Single system wide IO space is broken. We have separate IO space per PHB. That was work

Re: [Qemu-devel] [PATCH v8 1/3] Introduce async_run_on_cpu()

2013-07-12 Thread Juan Quintela
Chegu Vinod wrote: > Introduce an asynchronous version of run_on_cpu() i.e. the caller > doesn't have to block till the call back routine finishes execution > on the target vcpu. > > Signed-off-by: Chegu Vinod > Reviewed-by: Paolo Bonzini Reviewed-by: Juan Quintela

Re: [Qemu-devel] [PATCH v8 2/3] Add 'auto-converge' migration capability

2013-07-12 Thread Juan Quintela
Chegu Vinod wrote: > The auto-converge migration capability allows the user to specify if they > choose live migration seqeunce to automatically detect and force convergence. > > Signed-off-by: Chegu Vinod > Reviewed-by: Paolo Bonzini > Reviewed-by: Eric Blake Reviewed-by: Juan Quintela

Re: [Qemu-devel] [Xen-devel] [PATCH v2] libxl: usb2 and usb3 controller support for upstream qemu

2013-07-12 Thread Dario Faggioli
On ven, 2013-07-12 at 10:43 +0200, Fabio Fantoni wrote: > Il 11/07/2013 17:56, Dario Faggioli ha scritto: > >> Signed-off-by: Fabio Fantoni > >> > >> diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl > >> index d218a2d..b4c6921 100644 > >> --- a/tools/libxl/libxl_types.idl > >

Re: [Qemu-devel] [PATCH v8 3/3] Force auto-convegence of live migration

2013-07-12 Thread Juan Quintela
Chegu Vinod wrote: > If a user chooses to turn on the auto-converge migration capability > these changes detect the lack of convergence and throttle down the > guest. i.e. force the VCPUs out of the guest for some duration > and let the migration thread catchup and help converge. > > Verified the

Re: [Qemu-devel] [PATCH v3] libxl: usb2 and usb3 controller support for upstream qemu

2013-07-12 Thread Fabio Fantoni
Il 12/07/2013 13:06, George Dunlap ha scritto: On 12/07/13 11:22, Fabio Fantoni wrote: Usage: usbversion=1|2|3 (default=2) Specifies the type of an emulated USB bus in the guest. 1 for usb1, 2 for usb2 and 3 for usb3, it is available only with upstream qemu. Default is 2. Signed-off-by: Fabio F

Re: [Qemu-devel] [PULL 6/6] add timestamp to error_report()

2013-07-12 Thread Luiz Capitulino
On Fri, 12 Jul 2013 08:58:03 +0200 Paolo Bonzini wrote: > Il 10/07/2013 19:52, Luiz Capitulino ha scritto: > > From: Seiji Aguchi > > > > [Issue] > > When we offer a customer support service and a problem happens > > in a customer's system, we try to understand the problem by > > comparing what

Re: [Qemu-devel] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-07-12 Thread Anthony Liguori
Alexander Graf writes: > On 11.07.2013, at 14:29, Alexander Graf wrote: > >> This patch breaks VGA on PPC as it is in master today. > > If I don't mark portio as little endian it works as expected. There's > probably someone swapping things twice. This is the correct fix. Can you please send a

[Qemu-devel] [PATCH v4] libxl: usb2 and usb3 controller support for upstream qemu

2013-07-12 Thread Fabio Fantoni
Usage: usbversion=1|2|3 (default=2) Specifies the type of an emulated USB bus in the guest. 1 for usb1, 2 for usb2 and 3 for usb3, it is available only with upstream qemu. Default is 2. Signed-off-by: Fabio Fantoni --- docs/man/xl.cfg.pod.5 |6 ++ tools/libxl/libxl.h | 14

Re: [Qemu-devel] [PATCH v2 repost 5/9] i386: add bios linker/loader

2013-07-12 Thread Laszlo Ersek
On 07/10/13 15:51, Michael S. Tsirkin wrote: > This add a dynamic bios linker/loader. s/add/adds/ > This will be used by acpi table generation > code to: > - load each table in the appropriate memory egment s/egment/segment/ > diff --git a/hw/i386/bios-linker-loader.c b/hw/i386/bios-linker

Re: [Qemu-devel] [RFC PATCH 08/11] qapi: Anonymous unions

2013-07-12 Thread Eric Blake
On 07/12/2013 02:55 AM, Kevin Wolf wrote: > Am 11.07.2013 um 21:47 hat Eric Blake geschrieben: >> On 07/09/2013 03:53 AM, Kevin Wolf wrote: >>> The discriminator for anonymous unions is the data type. This allows to >>> have a union type that allows both of these: >>> >>> { 'file': 'my_existing

Re: [Qemu-devel] [PULL 6/6] add timestamp to error_report()

2013-07-12 Thread Seiji Aguchi
> -Original Message- > From: qemu-devel-bounces+seiji.aguchi=hds@nongnu.org > [mailto:qemu-devel-bounces+seiji.aguchi=hds@nongnu.org] > On Behalf Of Luiz Capitulino > Sent: Friday, July 12, 2013 8:47 AM > To: Paolo Bonzini > Cc: aligu...@us.ibm.com; qemu-devel@nongnu.org > Subjec

Re: [Qemu-devel] [RFC PATCH 11/11] [WIP] block: Implement 'blockdev-add' QMP command

2013-07-12 Thread Eric Blake
On 07/12/2013 03:40 AM, Kevin Wolf wrote: >>> + >>> +{ 'command': 'blockdev-add', 'data': { 'options': 'BlockOptions' } } >> >> Sounds nice - and seems like it should be easy enough to extend BlockRef >> and/or BlockOptions to have a way to pass an fd even for backing files, >> getting to (my) end

Re: [Qemu-devel] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-07-12 Thread Alexander Graf
Am 12.07.2013 um 14:56 schrieb Anthony Liguori : > Alexander Graf writes: > >> On 11.07.2013, at 14:29, Alexander Graf wrote: >> >>> This patch breaks VGA on PPC as it is in master today. >> >> If I don't mark portio as little endian it works as expected. There's >> probably someone swapping

[Qemu-devel] [PATCH v3 resend/cleanup 2/8] rdma: bugfix: ram_control_save_page()

2013-07-12 Thread mrhines
From: "Michael R. Hines" We were not checking for a valid 'bytes_sent' pointer before accessing it. Signed-off-by: Michael R. Hines --- savevm.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/savevm.c b/savevm.c index e0491e7..03fc4d9 100644 --- a/savevm.c +++ b/savevm.

[Qemu-devel] [PATCH v3 resend/cleanup 0/8] rdma: core logic

2013-07-12 Thread mrhines
From: "Michael R. Hines" Just a one-liner bug fix and checkpatch.pl, but this a resend. Waiting to be merged Changes since v2: - trivial bugfix - re-ran checkpatch Michael R. Hines (8): rdma: update documentation to reflect new unpin support rdma: bugfix: ram_control_save_page() rdma

[Qemu-devel] [PATCH v3 resend/cleanup 3/8] rdma: introduce ram_handle_compressed()

2013-07-12 Thread mrhines
From: "Michael R. Hines" This gives RDMA shared access to madvise() on the destination side when an entire chunk is found to be zero. Reviewed-by: Juan Quintela Reviewed-by: Paolo Bonzini Reviewed-by: Chegu Vinod Tested-by: Chegu Vinod Tested-by: Michael R. Hines Signed-off-by: Michael R. H

[Qemu-devel] [PATCH v3 resend/cleanup 6/8] rdma: allow state transitions between other states besides ACTIVE

2013-07-12 Thread mrhines
From: "Michael R. Hines" This patch is in preparation for the next ones: Until now the MIG_STATE_SETUP state was not really a 'formal' state. It has been used as a 'zero' state and QEMU has been unconditionally transitioning into this state when the QMP migrate command was called. In preparation

[Qemu-devel] [PATCH] qapi: qapi-commands: fix possible leaks on visitor dealloc

2013-07-12 Thread Luiz Capitulino
In qmp-marshal.c the dealloc visitor calls use the same errp pointer of the input visitor calls. This means that if any of the input visitor calls fails, then the dealloc visitor will return early, before freeing the object's memory. Here's an example, consider this code: int qmp_marshal_input_bl

Re: [Qemu-devel] [RFC 3/3 v2] qdev: set globals on post_init() function

2013-07-12 Thread Eduardo Habkost
On Thu, Jul 11, 2013 at 08:48:44AM +0200, Igor Mammedov wrote: [...] > > #define TYPE_STATIC_PROPS "static_prop_type" > > @@ -80,7 +82,7 @@ static void test_static_prop(void) > > static void test_static_globalprop(void) > > { > > MyType *mt; > > -GlobalProperty props[] = { > > +stat

[Qemu-devel] [PATCH v3 resend/cleanup 1/8] rdma: update documentation to reflect new unpin support

2013-07-12 Thread mrhines
From: "Michael R. Hines" As requested, the protocol now includes memory unpinning support. This has been implemented in a non-optimized manner, in such a way that one could devise an LRU or other workload-specific information on top of the basic mechanism to influence the way unpinning happens du

[Qemu-devel] [PATCH v3 resend/cleanup 8/8] rdma: account for the time spent in MIG_STATE_SETUP through QMP

2013-07-12 Thread mrhines
From: "Michael R. Hines" Using the previous patches, we're now able to timestamp the SETUP state. Once we have this time, let the user know about it in the schema. Reviewed-by: Juan Quintela Reviewed-by: Eric Blake Signed-off-by: Michael R. Hines --- hmp.c |4

Re: [Qemu-devel] [PATCH 0/2] Provide sextract32() and sextract64()

2013-07-12 Thread Peter Maydell
Ping! thanks -- PMM On 28 June 2013 12:40, Peter Maydell wrote: > A common operation in instruction decoding is to take a field > from an instruction that represents a signed integer in some > arbitrary number of bits, and sign extend it into a C signed > integer type for manipulation. Provide n

[Qemu-devel] [PATCH v3 resend/cleanup 7/8] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition

2013-07-12 Thread mrhines
From: "Michael R. Hines" As described in the previous patch, until now, the MIG_STATE_SETUP state was not really a 'formal' state. It has been used as a 'zero' state (what we're calling 'NONE' here) and QEMU has been unconditionally transitioning into this state when the QMP migration command was

[Qemu-devel] [PATCH v3 resend/cleanup 5/8] rdma: send pc.ram

2013-07-12 Thread mrhines
From: "Michael R. Hines" This takes advantages of the previous patches: 1. use the new QEMUFileOps hook 'save_page' 2. call out to the right accessor methods to invoke the iteration hooks defined in QEMUFileOps Reviewed-by: Paolo Bonzini Reviewed-by: Chegu Vinod Tested-by: Chegu Vinod Te

Re: [Qemu-devel] [PATCH v3] libxl: usb2 and usb3 controller support for upstream qemu

2013-07-12 Thread George Dunlap
On 12/07/13 13:36, Fabio Fantoni wrote: Il 12/07/2013 13:06, George Dunlap ha scritto: On 12/07/13 11:22, Fabio Fantoni wrote: Usage: usbversion=1|2|3 (default=2) Specifies the type of an emulated USB bus in the guest. 1 for usb1, 2 for usb2 and 3 for usb3, it is available only with upstream qe

Re: [Qemu-devel] [PATCH v4] libxl: usb2 and usb3 controller support for upstream qemu

2013-07-12 Thread George Dunlap
On 12/07/13 14:58, Fabio Fantoni wrote: Usage: usbversion=1|2|3 (default=2) Specifies the type of an emulated USB bus in the guest. 1 for usb1, 2 for usb2 and 3 for usb3, it is available only with upstream qemu. Default is 2. Signed-off-by: Fabio Fantoni Thank you for your enthusiastic respin

Re: [Qemu-devel] [PATCH] atomic: using memory_order_relaxed for refcnt inc/dec ops

2013-07-12 Thread Richard Henderson
On 07/11/2013 11:32 PM, Liu Ping Fan wrote: > Refcnt's atomic inc/dec ops are frequent and its idiom need no seq_cst > order. So to get better performance, it worth to adopt _relaxed > other than _seq_cst memory model on them. You'd need to update the documentation then. As it stands, what you've

[Qemu-devel] [PATCH] PPC: dbdma: macio: Fix format specifiers (build regression)

2013-07-12 Thread Stefan Weil
Fix a number of warnings for 32 bit builds (tested on MingW and Linux): CChw/ide/macio.o qemu/hw/ide/macio.c: In function 'pmac_ide_atapi_transfer_cb': qemu/hw/ide/macio.c:134:9: error: format '%lx' expects argument of type 'long unsigned int', but argument 3 has type 'hwaddr' [-Werror=form

Re: [Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp cmd

2013-07-12 Thread Eric Blake
On 06/18/2013 03:24 AM, Gerd Hoffmann wrote: >> > We have a job API in the block layer. Would it make sense to have a >> > QMP-level job interface? >> > I'd agree with this. > Something like the attached patch? Which is just the bare minimum I'll > need for screendump. Basically a one

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-07-12 Thread Hervé Poussineau
Benjamin Herrenschmidt a écrit : On Fri, 2013-07-12 at 05:18 +0200, Alexander Graf wrote: We model a single system wide io space today and access to that one happens through you pci host controller. I just messed up the terminology here. Single system wide IO space is broken. We have separate

Re: [Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp cmd

2013-07-12 Thread Eric Blake
On 06/17/2013 08:01 AM, Gerd Hoffmann wrote: > Adds a screendump-device qmp command, which has an additional 'device' > parameter. This way it is possible to specify the device you want a > screendump from. > > For the hmp monitor an optional device parameter has been added to the > esisting scre

Re: [Qemu-devel] [PATCH v3 resend/cleanup 1/8] rdma: update documentation to reflect new unpin support

2013-07-12 Thread Eric Blake
On 07/12/2013 08:40 AM, mrhi...@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" > > As requested, the protocol now includes memory unpinning support. > This has been implemented in a non-optimized manner, in such a way > that one could devise an LRU or other workload-specific information > o

Re: [Qemu-devel] [PATCH v3 resend/cleanup 2/8] rdma: bugfix: ram_control_save_page()

2013-07-12 Thread Eric Blake
On 07/12/2013 08:40 AM, mrhi...@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" > > We were not checking for a valid 'bytes_sent' pointer before accessing it. > > Signed-off-by: Michael R. Hines > --- > savevm.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric

Re: [Qemu-devel] [PATCH v3 resend/cleanup 1/8] rdma: update documentation to reflect new unpin support

2013-07-12 Thread Michael R. Hines
On 07/12/2013 01:09 PM, Eric Blake wrote: On 07/12/2013 08:40 AM, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" As requested, the protocol now includes memory unpinning support. This has been implemented in a non-optimized manner, in such a way that one could devise an LRU or othe

Re: [Qemu-devel] [PATCH v3 resend/cleanup 1/8] rdma: update documentation to reflect new unpin support

2013-07-12 Thread Eric Blake
On 07/12/2013 11:26 AM, Michael R. Hines wrote: > On 07/12/2013 01:09 PM, Eric Blake wrote: >> On 07/12/2013 08:40 AM, mrhi...@linux.vnet.ibm.com wrote: >>> From: "Michael R. Hines" >>> >>> As requested, the protocol now includes memory unpinning support. >>> This has been implemented in a non-opt

Re: [Qemu-devel] [PATCH v3 resend/cleanup 1/8] rdma: update documentation to reflect new unpin support

2013-07-12 Thread Michael R. Hines
On 07/12/2013 01:39 PM, Eric Blake wrote: On 07/12/2013 11:26 AM, Michael R. Hines wrote: On 07/12/2013 01:09 PM, Eric Blake wrote: On 07/12/2013 08:40 AM, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" As requested, the protocol now includes memory unpinning support. This has be

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-07-12 Thread Anthony Liguori
Benjamin Herrenschmidt writes: > On Fri, 2013-07-12 at 05:18 +0200, Alexander Graf wrote: >> We model a single system wide io space today and access to that one >> happens through you pci host controller. I just messed up the >> terminology here. > > Single system wide IO space is broken. We have

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-07-12 Thread Peter Maydell
On 12 July 2013 18:49, Anthony Liguori wrote: > Benjamin Herrenschmidt writes: >> On Fri, 2013-07-12 at 05:18 +0200, Alexander Graf wrote: >>> We model a single system wide io space today and access to that one >>> happens through you pci host controller. I just messed up the >>> terminology here

Re: [Qemu-devel] [APPLIED] Merge remote-tracking branch 'agraf/ppc-for-upstream' into staging

2013-07-12 Thread Anthony Liguori
Pulled, thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-07-12 Thread Anthony Liguori
Hervé Poussineau writes: > When only one of them is changed, this means some "interesting" things > can happen. For example, in [1]: > "When PowerPC little-endian is in effect but before system's > little-endian is in effect, the address munge becomes effective. If we > need to access system e

[Qemu-devel] Reminder: KVM Forum 2013 Call for Participation

2013-07-12 Thread KVM-Forum-2013-PC
Reminder, the KVM Forum CFP closes in less than 2 weeks. Also, thanks to generous support from our sponsors early registrants get an awesome discount! = KVM Forum 2013: Call For Participation October 21-23, 2013 - Edinburgh Internati

Re: [Qemu-devel] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-07-12 Thread Anthony Liguori
Hervé Poussineau writes: > Jan Kiszka a écrit : >> From: Jan Kiszka >> >> The current ioport dispatcher is a complex beast, mostly due to the >> need to deal with old portio interface users. But we can overcome it >> without converting all portio users by embedding the required base >> address

[Qemu-devel] [PATCH 4/8] configure: Enable threading for unicore32-linux-user

2013-07-12 Thread Peter Maydell
unicore32-linux-user provides cpu_set_tls(), so the failure to enable target_nptl was presumably an oversight. Enable it. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- configure |1 - 1 file changed, 1 deletion(-) diff --git a/configure b/configure index 84bcbdc..4a241e0

[Qemu-devel] [PATCH 2/8] configure: Don't say target_nptl="no" if there is no linux-user target

2013-07-12 Thread Peter Maydell
For architectures with no linux-user target, don't claim no NPTL support. This has no behavioural change, but it means that we won't accidentally add a new linux-user target without threading support in future (because attempting to do so would be a compile failure rather than a silent lack of supp

[Qemu-devel] [PATCH 3/8] configure: Enable threading on all ppc and mips linux-user targets

2013-07-12 Thread Peter Maydell
Though threading (target_nptl) was enabled on the base PPC and MIPS targets, it wasn't enabled for the variants mipsn32, mipsn32el, mips64, mips64el, ppc64 or ppc46abi32 (probably an oversight). Enable threading consistently on all these targets. Signed-off-by: Peter Maydell Reviewed-by: Richard

[Qemu-devel] [PATCH 7/8] linux-user: Enable NPTL for SPARC targets

2013-07-12 Thread Peter Maydell
Provide the missing cpu_set_tls(), and resolve the FIXME in cpu_clone_regs() by clearing the carry flag for the child. This allows us to turn on building with NPTL for SPARC. Signed-off-by: Peter Maydell --- configure |3 --- linux-user/sparc/target_cpu.h | 16 +

[Qemu-devel] [PATCH 0/8] linux-user: enable NPTL on everything but x86

2013-07-12 Thread Peter Maydell
This patchset enables NPTL on all linux-user targets except i386 and x86-64; this is a change for m68k, mipsn32, mipsn32el, mips64, mips64el, or32, ppc64, ppc46abi32, sparc, sparc32plus, sparc64, unicore32 (but not plain ppc or plain mips). The first four patches have been on list before and review

[Qemu-devel] [PATCH 5/8] linux-user: Move includes of target-specific headers to end of qemu.h

2013-07-12 Thread Peter Maydell
The target-specific headers (target_cpu.h and target_signal.h) might need to use the target-independent structure and function definitions of qemu.h; so include them only at the bottom of qemu.h, not the top. Signed-off-by: Peter Maydell --- linux-user/qemu.h |9 +++-- 1 file changed, 7

[Qemu-devel] [PATCH 1/8] configure: Flip default of target_nptl

2013-07-12 Thread Peter Maydell
Most targets either (a) support threading or (b) don't have a linux-user/bsd-user target, so make it default to 'yes', with those targets that don't support threading having to specifically say so. This is a mechanical no-behaviour-change commit; some of the "no" entries it adds will be taken out

[Qemu-devel] [PATCH 8/8] linux-user: Enable NPTL for m68k

2013-07-12 Thread Peter Maydell
For m68k, per-thread data is a purely kernel construct with no CPU level support. Implement it via a field in the TaskState structure, used by cpu_set_tls() and the set_thread_area/get_thread_area syscalls. This allows us to enable compilation with NPTL. Signed-off-by: Peter Maydell --- configur

[Qemu-devel] [PATCH 6/8] linux-user: Enable NPTL for OpenRISC

2013-07-12 Thread Peter Maydell
The OpenRISC kernel ignores CLONE_SETTLS in its copy_thread() implementation, so a cpu_set_tls() implementation is a no-op. cpu_clone_regs() was setting the syscall return value in the wrong register -- it is gpr[11], not gpr[2]. With these two things fixed, we can compile with NPTL enabled. Signe

[Qemu-devel] [PATCH] slirp: reorder include to fix FreeBSD build failure

2013-07-12 Thread Ed Maste
Signed-off-by: Ed Maste --- The issue comes from slirp/mbuf.h #defining m_flags, which conflicts with a header included via on FreeBSD. I'm not sure exactly when this broke; I assume that it used to work because something previously caused the conflicting header to be included earlier, and that

[Qemu-devel] [PATCH] ioport: remove LITTLE_ENDIAN mark for portio

2013-07-12 Thread Anthony Liguori
Setting it to LE forces a byte swap when host != guest endian but this makes no sense at all. Herve made the suggestion upon observing that word writes/reads were broken into byte writes/reads in such a way as to assume devices are interpret registers as LE. However, even if this were a problem,

Re: [Qemu-devel] [PATCH] ioport: remove LITTLE_ENDIAN mark for portio

2013-07-12 Thread Alexander Graf
On 12.07.2013, at 22:30, Anthony Liguori wrote: > Setting it to LE forces a byte swap when host != guest endian but > this makes no sense at all. > > Herve made the suggestion upon observing that word writes/reads > were broken into byte writes/reads in such a way as to assume > devices are inte

[Qemu-devel] [PATCH v2 6/8] arm/boot: Allow boards to modify the FDT blob

2013-07-12 Thread Peter Maydell
Add a callback hook in arm_boot_info to allow board models to modify the device tree blob if they need to. (The major expected use case is to add virtio-mmio nodes for virtio-mmio transports that exist in QEMU but not in the hardware.) Signed-off-by: Peter Maydell --- hw/arm/boot.c|5

[Qemu-devel] Call for Proposals: 2013 Linux Plumbers Virtualization Microconference

2013-07-12 Thread Alex Williamson
The Call for Proposals for the 2013 Linux Plumbers Virtualization Microconference is now open. This uconf is being held as part of Linux Plumbers Conference in New Orleans, Louisiana, USA September 18-20th and is co-located with LinuxCon North America. For more information see: http://www.linux

[Qemu-devel] [PATCH] Adds the ability to use the command key in the guest OS.

2013-07-12 Thread Programmingkid
This patch adds the ability to use the command key in the guest OS. This patch will allow you to send keyboard shortcuts to Macintosh applications running in QEMU. signed-off-by: John Arbuckle --- ui/cocoa.m | 123 +-- 1 files changed,

[Qemu-devel] [PATCH v2 4/8] virtio: Support transports which can specify the vring alignment

2013-07-12 Thread Peter Maydell
Support virtio transports which can specify the vring alignment (ie where the guest communicates this to the host) by providing a new virtio_queue_set_align() function. (The default alignment remains as before.) Transports which wish to make use of this must set the has_variable_vring_alignment fi

[Qemu-devel] [PATCH v2 0/8] Add virtio-mmio and use it in vexpress

2013-07-12 Thread Peter Maydell
This patch series adds an implementation of the virtio-mmio transport, and uses it in the vexpress-a9 and vexpress-a15 board models. The basic idea is that the board instantiates some transports, the user can create backends which automatically plug into them (via -device virtio-blk-backend and th

[Qemu-devel] [PATCH v2 8/8] vexpress: Add virtio-mmio transports

2013-07-12 Thread Peter Maydell
Add some virtio-mmio transports to the vexpress board model, together with a modify_dtb hook which adds them to the device tree so that the kernel will probe for them. We put them in a reserved area of the address map. Signed-off-by: Peter Maydell --- hw/arm/vexpress.c | 99 +++

[Qemu-devel] [PATCH v2 1/8] device_tree: Add qemu_devtree_setprop_sized_cells() utility functions

2013-07-12 Thread Peter Maydell
We already have a qemu_devtree_setprop_cells() which sets a dtb property to an array of cells whose values are specified by varargs. However for the fairly common case of setting a property to a list of addresses or of address,size pairs the number of cells used by each element in the list depends

[Qemu-devel] [PATCH v2 3/8] virtio: Add support for guest setting of queue size

2013-07-12 Thread Peter Maydell
The MMIO virtio transport spec allows the guest to tell the host how large the queue size is. Add virtio_queue_set_num() function which implements this in the QEMU common virtio support code. Signed-off-by: Peter Maydell --- hw/virtio/virtio.c |8 include/hw/virtio/virtio.h

[Qemu-devel] [PATCH v2 5/8] virtio: Implement MMIO based virtio transport

2013-07-12 Thread Peter Maydell
Add support for the generic MMIO based virtio transport. This patch includes some fixes for bugs spotted by Ying-Shiuan Pan . Signed-off-by: Peter Maydell [Fred changes: updated to new virtio-bus mechanisms] Signed-off-by: KONRAD Frederic [PMM changes: * fixed trivial makefile conflict * remo

[Qemu-devel] [PATCH v2 7/8] vexpress: Make VEDBoardInfo extend arm_boot_info

2013-07-12 Thread Peter Maydell
Make the VEDBoardInfo struct extend arm_boot_info; this will allow us to get at the VEDBoardInfo information inside callbacks from arm/boot code. Signed-off-by: Peter Maydell --- hw/arm/vexpress.c | 31 +++ 1 file changed, 15 insertions(+), 16 deletions(-) diff --g

[Qemu-devel] [PULL 0/3] migration queue

2013-07-12 Thread Juan Quintela
Hi Anthony please, pull. This has Vinod changes for auto-converge. I merged by hand the problems, and tested that it works and compiles for everything. Thanks, Juan. PD: there were a prototype missing and the event name on trace-events, fixed both. The following changes since commit 25ca6a1

[Qemu-devel] [PATCH v2 2/8] arm/boot: Use qemu_devtree_setprop_sized_cells()

2013-07-12 Thread Peter Maydell
Replace the opencoded assembly of the reg property array for the /memory node with a call to qemu_devtree_setprop_sized_cells(). Signed-off-by: Peter Maydell --- hw/arm/boot.c | 28 +++- 1 file changed, 7 insertions(+), 21 deletions(-) diff --git a/hw/arm/boot.c b/hw/a

Re: [Qemu-devel] [PATCH] qapi: qapi-commands: fix possible leaks on visitor dealloc

2013-07-12 Thread Michael Roth
Quoting Luiz Capitulino (2013-07-12 09:42:02) > In qmp-marshal.c the dealloc visitor calls use the same errp > pointer of the input visitor calls. This means that if any of > the input visitor calls fails, then the dealloc visitor will > return early, before freeing the object's memory. > > Here's

Re: [Qemu-devel] [Xen-devel] [PATCH v4] libxl: usb2 and usb3 controller support for upstream qemu

2013-07-12 Thread Dario Faggioli
On ven, 2013-07-12 at 15:58 +0200, Fabio Fantoni wrote: > Usage: usbversion=1|2|3 (default=2) > Specifies the type of an emulated USB bus in the guest. 1 for usb1, > 2 for usb2 and 3 for usb3, it is available only with upstream qemu. > Default is 2. > > Signed-off-by: Fabio Fantoni > FWIW, Acked-

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-07-12 Thread Benjamin Herrenschmidt
On Fri, 2013-07-12 at 19:04 +0200, Hervé Poussineau wrote: > "When PowerPC little-endian is in effect but before system's > little-endian is in effect, the address munge becomes effective. If we > need to access system endian port (byte) address, say 0x8092, the > program needs to issue 0x80

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-07-12 Thread Benjamin Herrenschmidt
On Fri, 2013-07-12 at 12:49 -0500, Anthony Liguori wrote: > > > Unless they are completely broken (and those exist, don't get me wrong, > > though mostly they are a thing of a past long gone), bridges and busses > > have no effect on endianness. > > That's simply not true. There are programmable

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-07-12 Thread Benjamin Herrenschmidt
On Fri, 2013-07-12 at 19:26 +0100, Peter Maydell wrote: > It's not wrong when the hardware actually does a byteswap at > some level in the memory hierarchy. You can see this for instance > on ARMv7M systems, where byteswapping for bigendian happens at > an intermediate level that not all accesses

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-07-12 Thread Benjamin Herrenschmidt
On Fri, 2013-07-12 at 14:06 -0500, Anthony Liguori wrote: > > In the light of this, I think there should only be one endianness > for > > all memory accesses (which could be changed at runtime), > > We already do this, it's "host native endian". The simple fact that you used the word "endian" ma

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-07-12 Thread Peter Maydell
On 12 July 2013 23:50, Benjamin Herrenschmidt wrote: > On Fri, 2013-07-12 at 19:26 +0100, Peter Maydell wrote: >> It's not wrong when the hardware actually does a byteswap at >> some level in the memory hierarchy. You can see this for instance >> on ARMv7M systems, where byteswapping for bigendian

  1   2   >