Thanks for the links Nikita.
I'll see if I can add the missing features (fpop, fpdp) to the patch.
Since I don't depend on those features, it will be relatively low
priority for me, and I will probably not get to it before late August.
// MOKI
--
You received this bug notification because you a
On Sun, Jun 30, 2013 at 08:49:28PM +0400, Michael Tokarev wrote:
> 30.06.2013 19:51, Peter Maydell wrote:
> > On 30 June 2013 16:36, Michael Tokarev wrote:
> >> I don't understand. I for one like to see a plugins system used in qemu,
> >> and except of the build system everything else is easy (an
On Fri, Jun 28, 2013 at 05:37:54PM +0200, Paolo Bonzini wrote:
> Il 28/06/2013 17:35, Ed Maste ha scritto:
> > On 28 June 2013 11:11, Paolo Bonzini wrote:
> >> And of course if bsd-user supported 1:1 mapping between guest and host
> >> threads on FreeBSD, cpu_single_env would have to be thread-loc
Amos Kong writes:
> On Fri, Jun 28, 2013 at 07:19:39PM +0200, Markus Armbruster wrote:
>> Eric Blake writes:
>>
>> > On 06/27/2013 08:22 AM, Markus Armbruster wrote:
>> >> Commit 1da48c6 called the new member "memory" after commit 3949e59
>> >> standardized "ringbuf". Rename for consistency.
>
Amos Kong writes:
> On Wed, Jun 26, 2013 at 12:07:53PM +0200, Markus Armbruster wrote:
>> Amos Kong writes:
>>
>> > On Mon, Jun 24, 2013 at 02:34:59PM +0800, Amos Kong wrote:
>> >> netclient 'name' entry in event is useful for management to know
>> >> which device is changed. n->netclient_name
On 06/30/13 03:21, Tomoki Sekiyama wrote:
> On 6/28/13 14:01 , "Laszlo Ersek" wrote:
>> On 06/06/13 17:06, Tomoki Sekiyama wrote:
>>> +static t_CreateVssBackupComponents _CreateVssBackupComponents;
>>> +static t_VssFreeSnapshotProperties _VssFreeSnapshotProperties;
>> Unless there's a pressing r
Am 28.06.2013 um 21:32 hat Eric Blake geschrieben:
> On 06/28/2013 08:32 AM, Federico Simoncelli wrote:
> > This patch adds the optional file entry to the query-block output.
> > The value is a json-object representing the information about the
> > underlying file or device (when present).
> >
> >
On 2013-06-28 18:58, Paolo Bonzini wrote:
> This series, split out of the previous attempt to set owners for memory
> regions, adds reference counting operations to memory regions and uses
> them. As requested by Peter, I'm adding an argument for the owner to
> all memory region creation functions
On Thu, Jun 27, 2013 at 10:40:23PM +0100, Alex Bligh wrote:
> --On 27 June 2013 16:53:40 +0200 Stefan Hajnoczi wrote:
>
> >I realized I should give a bit more info to help you get started.
> >
> >tests/qemu-iotests/check is the script to run tests. There are
> >currently around 55 tests which ex
On 2013-07-01 10:43, Jan Kiszka wrote:
> On 2013-06-28 18:58, Paolo Bonzini wrote:
>> This series, split out of the previous attempt to set owners for memory
>> regions, adds reference counting operations to memory regions and uses
>> them. As requested by Peter, I'm adding an argument for the own
On Mon, Jul 01, 2013 at 10:10:40AM +0200, Markus Armbruster wrote:
> Amos Kong writes:
>
> > On Fri, Jun 28, 2013 at 07:19:39PM +0200, Markus Armbruster wrote:
> >> Eric Blake writes:
> >>
> >> > On 06/27/2013 08:22 AM, Markus Armbruster wrote:
> >> >> Commit 1da48c6 called the new member "memo
The following changes since commit ffeec223b55ea696567ed544016824199cd7c7bc:
Merge remote-tracking branch 'mjt/trivial-patches' into staging (2013-06-28
15:48:35 -0500)
are available in the git repository at:
git://github.com/cohuck/qemu virtio-ccw-upstr
for you to fetch changes up to cc3
event_notifier_get_fd() is not available on windows hosts. Fix this by
moving the calls to event_notifier_get_fd() to the kvm code.
Reported-by: Stefan Weil
Reviewed-by: Paolo Bonzini
Signed-off-by: Cornelia Huck
---
hw/s390x/virtio-ccw.c |6 ++
target-s390x/cpu.h| 11 +++
On 06/29/13 19:51, Alex Bligh wrote:
> How is one meant to make the tests? make test fails with:
>
> make[1]: Entering directory `/home/amb/qemu/git/qemu/tests/tcg'
> cc -m32 -I/home/amb/qemu/git/qemu/tcg -I/home/amb/qemu/git/qemu/tcg/i386
> -I/home/amb/qemu/git/qemu/linux-headers
> -I/home/amb/qe
On Mon, Jul 1, 2013 at 7:00 AM, Andreas Färber wrote:
> From: Andreas Färber
>
> Introduce type constant and cast macro and enforce its use by
> renaming A9MPPrivState::busdev field to parent_obj.
>
> Signed-off-by: Andreas Färber
Reviewed-by: Peter Crosthwaite
> ---
> hw/cpu/a9mpcore.c | 15
On 29 June 2013 18:51, Alex Bligh wrote:
> How is one meant to make the tests? make test fails with:
"make check" is the target people actually run. It looks like
Paolo's file rearrangement broke the test_path test (since
it directly #includes other QEMU files) and nobody's noticed.
We should pr
On Mon, Jul 1, 2013 at 7:00 AM, Andreas Färber wrote:
> From: Andreas Färber
>
> Rename A9SCUState::busdev field to parent_obj and turn realizefn into an
> instance_init function to allow early MMIO mapping.
>
> Signed-off-by: Andreas Färber
Reviewed-by: Peter Crosthwaite
> ---
> hw/misc/a9s
Amos Kong writes:
> On Mon, Jul 01, 2013 at 10:10:40AM +0200, Markus Armbruster wrote:
>> Amos Kong writes:
>>
>> > On Fri, Jun 28, 2013 at 07:19:39PM +0200, Markus Armbruster wrote:
>> >> Eric Blake writes:
>> >>
>> >> > On 06/27/2013 08:22 AM, Markus Armbruster wrote:
>> >> >> Commit 1da48c
On Mon, Jul 1, 2013 at 7:00 AM, Andreas Färber wrote:
> From: Andreas Färber
>
> Introduce type constant and cast macro and rename
> ARMMPTimerState::busdev to enforce its use.
>
> Signed-off-by: Andreas Färber
> ---
> hw/timer/arm_mptimer.c | 18 +-
> 1 file changed, 13 inserti
Hi Andreas,
On Mon, Jul 1, 2013 at 7:00 AM, Andreas Färber wrote:
> From: Andreas Färber
>
> Split the SysBusDevice initfn into instance_init and realizefn.
>
> Signed-off-by: Andreas Färber
> ---
> hw/timer/arm_mptimer.c | 25 +++--
> 1 file changed, 15 insertions(+), 10 d
On Sun, Jun 30, 2013 at 04:36:13PM +0200, Andreas Färber wrote:
> Am 25.06.2013 19:45, schrieb Eduardo Habkost:
> > On Tue, Jun 25, 2013 at 10:20:08AM +0800, Hu Tao wrote:
> > [...]
> >>> Is TYPE_SYS_BUS_DEVICE guaranteed to never override ->realize() itself?
> >>>
> >>> From DeviceClass documentat
From: Paolo Bonzini
Fast TLS is not available on some platforms, but it is always nice to
use it. This wrapper implementation falls back to pthread_get/setspecific
on POSIX systems that lack __thread, but uses the dynamic linker's TLS
support on Linux and Windows.
The user shall call tls_alloc_
From: Paolo Bonzini
The next patch will change qemu/tls.h to support more platforms, but at
some performance cost. Declare cpu_single_env directly instead of using
the tls.h abstractions.
Signed-off-by: Paolo Bonzini
---
exec.c | 10 --
include/exec/cpu-all.h | 14
These patches by Paolo Bonzini add thread-local storage
support for POSIX and Windows platforms. Fast native TLS mechanisms are used
when available and pthread_get/setspecific() is used as a fallback.
My dataplane block layer RFC work relies on this and it has been discussed
separately by Ed and
On 2013-06-28 20:26, Paolo Bonzini wrote:
> This includes a (mangled) copy of the urcu-qsbr code from liburcu.
> The main changes are: 1) removing dependencies on many other header files
> in liburcu; 2) removing for simplicity the tentative busy waiting in
> synchronize_rcu, which has limited perf
On 1 July 2013 10:35, Stefan Hajnoczi wrote:
> From: Paolo Bonzini
>
> The next patch will change qemu/tls.h to support more platforms, but at
> some performance cost. Declare cpu_single_env directly instead of using
> the tls.h abstractions.
>
> Signed-off-by: Paolo Bonzini
> ---
> exec.c
On 06/29/13 12:22, Izumi Tsutsui wrote:
> Fix following bugs in "fallback implementation of counting semaphores
> with mutex+condvar" added in c166cb72f1676855816340666c3b618beef4b976:
> - waiting threads are not restarted properly if more than one threads
>are waiting unblock signals in qemu_
Am 01.07.2013 01:36, schrieb Alexander Graf:
>
> On 30.06.2013, at 10:21, Andreas Färber wrote:
>
>> Am 24.06.2013 08:55, schrieb peter.crosthwa...@xilinx.com:
>>> From: Peter Crosthwaite
>>>
>>> Define and use standard QOM cast macro. Remove usages of DO_UPCAST
>>> and direct -> style upcasting
Il 30/06/2013 17:23, Michael Tokarev ha scritto:
>> Perhaps we can instead use something like
>> >
>> > common.o: $(patsubst %,../%, $(common-obj-y))
>> >$(LD) -r -o $@ $^
>> >
>> > and then link common.o into the QEMU target. Libtool can also be used
>> > to abstract "ld -r". Making libtoo
01.07.2013 14:08, Paolo Bonzini wrote:
> Il 30/06/2013 17:23, Michael Tokarev ha scritto:
>>> Perhaps we can instead use something like
common.o: $(patsubst %,../%, $(common-obj-y))
$(LD) -r -o $@ $^
and then link common.o into the QEMU target. Libtool can also be used
On 01.07.2013, at 12:03, Andreas Färber wrote:
> Am 01.07.2013 01:36, schrieb Alexander Graf:
>>
>> On 30.06.2013, at 10:21, Andreas Färber wrote:
>>
>>> Am 24.06.2013 08:55, schrieb peter.crosthwa...@xilinx.com:
From: Peter Crosthwaite
Define and use standard QOM cast macro. R
On 1 July 2013 10:35, Stefan Hajnoczi wrote:
> From: Paolo Bonzini
>
> Fast TLS is not available on some platforms, but it is always nice to
> use it. This wrapper implementation falls back to pthread_get/setspecific
> on POSIX systems that lack __thread, but uses the dynamic linker's TLS
> supp
Il 01/07/2013 11:54, Peter Maydell ha scritto:
> On 1 July 2013 10:35, Stefan Hajnoczi wrote:
>> From: Paolo Bonzini
>>
>> Fast TLS is not available on some platforms, but it is always nice to
>> use it. This wrapper implementation falls back to pthread_get/setspecific
>> on POSIX systems that l
Il 01/07/2013 11:51, Peter Maydell ha scritto:
> On 1 July 2013 10:35, Stefan Hajnoczi wrote:
>> From: Paolo Bonzini
>>
>> The next patch will change qemu/tls.h to support more platforms, but at
>> some performance cost. Declare cpu_single_env directly instead of using
>> the tls.h abstractions.
Il 29/06/2013 01:53, Ed Maste ha scritto:
> On 28 June 2013 14:26, Paolo Bonzini wrote:
>>
>> +/* This is thread-local depending on __linux__ because:
>
> Is the comment perhaps unchanged from an earlier revision that used a
> different test? It seems odd to me to reference __linux__ here.
>
>>
Il 01/07/2013 12:10, Michael Tokarev ha scritto:
>>> Perhaps we can instead use something like
>
> common.o: $(patsubst %,../%, $(common-obj-y))
> $(LD) -r -o $@ $^
>
> and then link common.o into the QEMU target. Libtool can also be
> >>
Signed-off-by: Hu Tao
---
include/hw/sysbus.h | 10 ++
1 file changed, 10 insertions(+)
diff --git a/include/hw/sysbus.h b/include/hw/sysbus.h
index 7c2e316..9614758 100644
--- a/include/hw/sysbus.h
+++ b/include/hw/sysbus.h
@@ -23,6 +23,16 @@ typedef struct SysBusDevice SysBusDevice;
#
Signed-off-by: Hu Tao
---
hw/pci-host/piix.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
index 801341a..e2437df 100644
--- a/hw/pci-host/piix.c
+++ b/hw/pci-host/piix.c
@@ -121,22 +121,24 @@ static int pci_slot_get_pirq(P
Introduce type constant and avoid DO_UPCAST(), container_of(),
and use DEVICE() to avoid accessing parent qdev directly.
Signed-off-by: Hu Tao
---
hw/block/fdc.c | 37 -
1 file changed, 20 insertions(+), 17 deletions(-)
diff --git a/hw/block/fdc.c b/hw/block/
This series updates part of devices inheriting from SysbusDevice
to use DeviceState::realize, and QOM'ify them.
These devices are default to x86_64-softmmu. I'm planning to
make patches in the same manner, that is, each series is for
devices default to each target. After all devices are converted
Signed-off-by: Hu Tao
---
hw/usb/hcd-ohci.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c
index 912255d..ee824ee 100644
--- a/hw/usb/hcd-ohci.c
+++ b/hw/usb/hcd-ohci.c
@@ -1880,17 +1880,16 @@ typedef struct {
dma_addr
And remove variables if possible.
Signed-off-by: Hu Tao
---
hw/pci-host/q35.c | 35 ++-
1 file changed, 18 insertions(+), 17 deletions(-)
diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c
index 24df6b5..61b525f 100644
--- a/hw/pci-host/q35.c
+++ b/hw/pci-host/q3
Signed-off-by: Hu Tao
---
hw/block/pflash_cfi01.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/hw/block/pflash_cfi01.c b/hw/block/pflash_cfi01.c
index 7f7af06..06c045b 100644
--- a/hw/block/pflash_cfi01.c
+++ b/hw/block/pflash_cfi01.c
@@ -566,7 +566,7 @@ static
Introduce type constant and avoid DO_UPCAST().
Signed-off-by: Hu Tao
---
hw/usb/hcd-ohci.c | 20
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c
index 5513924..912255d 100644
--- a/hw/usb/hcd-ohci.c
+++ b/hw/usb/hcd-ohci.c
Signed-off-by: Hu Tao
---
hw/nvram/fw_cfg.c | 26 --
1 file changed, 16 insertions(+), 10 deletions(-)
diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c
index c8722c2..656ffcc 100644
--- a/hw/nvram/fw_cfg.c
+++ b/hw/nvram/fw_cfg.c
@@ -523,31 +523,37 @@ FWCfgState *fw_cfg
Signed-off-by: Hu Tao
---
hw/pci-host/piix.c | 25 +++--
1 file changed, 15 insertions(+), 10 deletions(-)
diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
index f9e68c3..801341a 100644
--- a/hw/pci-host/piix.c
+++ b/hw/pci-host/piix.c
@@ -197,21 +197,26 @@ static const V
Introduce type constant and replace FROM_SYSBUS().
Signed-off-by: Hu Tao
---
hw/block/pflash_cfi02.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/hw/block/pflash_cfi02.c b/hw/block/pflash_cfi02.c
index 5f25246..f1e76f0 100644
--- a/hw/block/pflash_cfi02.c
Introduce type constant and avoid DO_UPCAST().
Signed-off-by: Hu Tao
---
hw/ide/ahci.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index 3c86b3a..5dcd662 100644
--- a/hw/ide/ahci.c
+++ b/hw/ide/ahci.c
@@ -1275,6 +1275,9 @@ const V
Signed-off-by: Hu Tao
---
hw/block/fdc.c | 62 ++
1 file changed, 41 insertions(+), 21 deletions(-)
diff --git a/hw/block/fdc.c b/hw/block/fdc.c
index f8270cb..0fe0cf9 100644
--- a/hw/block/fdc.c
+++ b/hw/block/fdc.c
@@ -2145,38 +2145,58 @@
Signed-off-by: Hu Tao
---
hw/timer/hpet.c | 30 +-
1 file changed, 17 insertions(+), 13 deletions(-)
diff --git a/hw/timer/hpet.c b/hw/timer/hpet.c
index af80e63..731fb92 100644
--- a/hw/timer/hpet.c
+++ b/hw/timer/hpet.c
@@ -683,7 +683,16 @@ static void hpet_handle_l
Signed-off-by: Hu Tao
---
hw/block/pflash_cfi02.c | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/hw/block/pflash_cfi02.c b/hw/block/pflash_cfi02.c
index f1e76f0..a31fd25 100644
--- a/hw/block/pflash_cfi02.c
+++ b/hw/block/pflash_cfi02.c
@@ -589,7 +589,7 @@ sta
Signed-off-by: Hu Tao
---
hw/ide/ahci.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index 5dcd662..d92239b 100644
--- a/hw/ide/ahci.c
+++ b/hw/ide/ahci.c
@@ -1300,14 +1300,13 @@ static void sysbus_ahci_reset(DeviceState *dev)
Am 01.07.2013 11:31, schrieb Hu Tao:
> On Sun, Jun 30, 2013 at 04:36:13PM +0200, Andreas Färber wrote:
>> Am 25.06.2013 19:45, schrieb Eduardo Habkost:
>>> On Tue, Jun 25, 2013 at 10:20:08AM +0800, Hu Tao wrote:
>>> [...]
> Is TYPE_SYS_BUS_DEVICE guaranteed to never override ->realize() itself?
Signed-off-by: Hu Tao
---
hw/scsi/esp.c | 30 --
1 file changed, 20 insertions(+), 10 deletions(-)
diff --git a/hw/scsi/esp.c b/hw/scsi/esp.c
index f7d6389..714d2fd 100644
--- a/hw/scsi/esp.c
+++ b/hw/scsi/esp.c
@@ -668,23 +668,33 @@ static void sysbus_esp_gpio_demux(
Use type constant if possible and avoid DO_UPCAST().
Signed-off-by: Hu Tao
---
hw/nvram/fw_cfg.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c
index 3c255ce..c8722c2 100644
--- a/hw/nvram/fw_cfg.c
+++ b/hw/nvram/fw_cfg.c
@@
Signed-off-by: Hu Tao
---
hw/i386/kvm/clock.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/hw/i386/kvm/clock.c b/hw/i386/kvm/clock.c
index fcdcbca..4f6e6f9 100644
--- a/hw/i386/kvm/clock.c
+++ b/hw/i386/kvm/clock.c
@@ -90,12 +90,11 @@ static void kvmclock_vm_state_cha
Il 28/06/2013 22:41, Anthony Liguori ha scritto:
> Tiny copy/paste error here: s/qemu memory/memory/g".
>
> One thing I've been thinking about reviewing this code, what should we
> be doing in virtio.c?
>
> We have barriers but we're relying on st[u][wlb]_phys having atomic
> semantics. I think
Signed-off-by: Hu Tao
---
hw/i386/kvmvapic.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/hw/i386/kvmvapic.c b/hw/i386/kvmvapic.c
index f93629f..fa85096 100644
--- a/hw/i386/kvmvapic.c
+++ b/hw/i386/kvmvapic.c
@@ -698,19 +698,18 @@ static const MemoryRegionOps
Introduce type constant and avoid DO_UPCAST().
Signed-off-by: Hu Tao
---
hw/scsi/esp.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/hw/scsi/esp.c b/hw/scsi/esp.c
index 0c81a50..f7d6389 100644
--- a/hw/scsi/esp.c
+++ b/hw/scsi/esp.c
@@ -578,6 +578,9 @@ cons
Introduce type constant, avoid FROM_SYSBUS().
Signed-off-by: Hu Tao
---
hw/timer/hpet.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/hw/timer/hpet.c b/hw/timer/hpet.c
index 95dd01d..af80e63 100644
--- a/hw/timer/hpet.c
+++ b/hw/timer/hpet.c
@@ -42,6 +42,9 @@
Introduce type constant and avoid FROM_SYSBUS().
Signed-off-by: Hu Tao
---
hw/i386/kvm/clock.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/hw/i386/kvm/clock.c b/hw/i386/kvm/clock.c
index 87d4d0f..fcdcbca 100644
--- a/hw/i386/kvm/clock.c
+++ b/hw/i386/kvm/clock.c
Signed-off-by: Hu Tao
---
hw/isa/isa-bus.c | 8
1 file changed, 8 deletions(-)
diff --git a/hw/isa/isa-bus.c b/hw/isa/isa-bus.c
index 136d17e..6aea97b 100644
--- a/hw/isa/isa-bus.c
+++ b/hw/isa/isa-bus.c
@@ -192,18 +192,10 @@ static void isabus_dev_print(Monitor *mon, DeviceState
*dev,
Am 29.06.2013 um 20:02 hat Alex Bligh geschrieben:
> Add a delay option to blkdebug, allowing operations to be delayed by
> a specifiable number of microseconds. Example configuration:
>
> [inject-error]
> event = "read_aio"
> delay = "20"
>
> Signed-off-by: Alex Bligh
"inject-error" doesn'
Signed-off-by: Hu Tao
---
hw/intc/ioapic_common.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/hw/intc/ioapic_common.c b/hw/intc/ioapic_common.c
index 5c5bb3c..5dc1f1e 100644
--- a/hw/intc/ioapic_common.c
+++ b/hw/intc/ioapic_common.c
@@ -57,23 +57,22 @@ static
Il 29/06/2013 12:55, Peter Maydell ha scritto:
> On 28 June 2013 19:26, Paolo Bonzini wrote:
>> The next patch will change qemu/tls.h to support more platforms, but at
>> some performance cost. Declare cpu_single_env directly instead of using
>> the tls.h abstractions.
>>
>> Signed-off-by: Paolo
Am 01.07.2013 11:35, schrieb Stefan Hajnoczi:
> From: Paolo Bonzini
>
> The next patch will change qemu/tls.h to support more platforms, but at
> some performance cost. Declare cpu_single_env directly instead of using
> the tls.h abstractions.
>
> Signed-off-by: Paolo Bonzini
> ---
> exec.c
Il 29/06/2013 15:47, Stefan Weil ha scritto:
> i686-w64-mingw32-gcc (GCC) 4.6.3 from Debian wheezy reports these warnings:
>
> hw/ppc/spapr_hcall.c:188:1: warning:
> control reaches end of non-void function [-Wreturn-type]
>
> hw/ppc/spapr_pci.c:454:1: warning:
> control reaches end of non-void
and split off memory region initialization into instance_init.
Signed-off-by: Hu Tao
---
hw/pci-host/q35.c | 29 +++--
1 file changed, 15 insertions(+), 14 deletions(-)
diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c
index 61b525f..244e2f5 100644
--- a/hw/pci-host/q35
Introduce type constant and replace FROM_SYSBUS().
Signed-off-by: Hu Tao
---
hw/block/pflash_cfi01.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/hw/block/pflash_cfi01.c b/hw/block/pflash_cfi01.c
index 63d7c99..7f7af06 100644
--- a/hw/block/pflash_cfi01.c
On 1 July 2013 11:45, Paolo Bonzini wrote:
> Il 29/06/2013 12:55, Peter Maydell ha scritto:
>> We should just be consistent and always make this be
>> per-thread.
>
> If it's okay to make cpu_single_env accesses more expensive by a factor
> of 4 on TLS-deficient hosts (at least OpenBSD; do Darwin
On 28 June 2013 21:41, Anthony Liguori wrote:
> One thing I've been thinking about reviewing this code, what should we
> be doing in virtio.c?
>
> We have barriers but we're relying on st[u][wlb]_phys having atomic
> semantics. I think it's okay in practice but if we're taking a more
> diligent a
Kevin,
--On 1 July 2013 12:23:53 +0200 Kevin Wolf wrote:
"inject-error" doesn't really describe this well. Shouldn't we rather
introduce a new section "[delay]" or something like that?
That's how I started off. Then I realised you might want to make
the delay dependent on the sector or state
On Mon, Jul 01, 2013 at 11:28:58AM +0200, Markus Armbruster wrote:
> Amos Kong writes:
>
> > On Mon, Jul 01, 2013 at 10:10:40AM +0200, Markus Armbruster wrote:
> >> Amos Kong writes:
> >>
> >> > On Fri, Jun 28, 2013 at 07:19:39PM +0200, Markus Armbruster wrote:
> >> >> Eric Blake writes:
> >>
Am 01.07.2013 01:18, schrieb Andreas Färber:
> Am 01.07.2013 01:01, schrieb Alexander Graf:
>>
>> On 30.06.2013, at 08:13, Andreas Färber wrote:
>>
>>> Am 30.06.2013 03:44, schrieb Alexander Graf:
From: Scott Wood
Enables support for the in-kernel MPIC that thas been merged into the
Load the virtio.c state into vring.c when we start dataplane mode and
vice versa when stopping dataplane mode. This patch makes it possible
to start and stop dataplane any time while the guest is running.
This will eventually allow us to go back to QEMU main loop for
bdrv_drain_all() and live mig
Since 80ccf93b we flush the block device during close. The
bdrv_drain_all() call should come before bdrv_flush() to ensure guest
write requests have completed. Otherwise we may miss pending writes
when flushing.
However, there is still a slight change that cancelling a blockjob or
doing bdrv_flu
g_hash_table_get_keys() was only introduced in glib 2.14, and we're
still targeting a minimum version of 2.12. Rewrite the offending
code (introduced in commit 721fae1) to use g_hash_table_foreach()
to build the list of keys.
Signed-off-by: Peter Maydell
---
target-arm/helper.c | 12 +
Il 25/06/2013 14:18, Gleb Natapov ha scritto:
> On Tue, Jun 18, 2013 at 08:38:25PM -0300, Marcelo Tosatti wrote:
>> >
>> > v2: remove unnecessary runstate_is_running() usage (Paolo)
>> >
>> > --
>> >
>> > kvmclock should not count while vm is paused, because:
>> >
>> > 1) if the vm is paused fo
On Thu, Jun 20, 2013 at 09:58:41AM -0400, Ed Maste wrote:
> On 5 June 2013 10:04, Anthony Liguori wrote:
> >
> > Hi,
> >
> > Below is the coverage we currently have in buildbot. It's not terribly
> > complete but I suspect it does reflect what people are actually testing
> > and care about.
> >
>
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Il 28/06/2013 21:38, Jan Kiszka ha scritto:
> At this point, do we still have unowned memory regions?
Yes, for stuff that is registered by the boards or by non-qdevified
devices. In either case, they cannot disappear so it's fine that you
call addres
On Thu, Jun 20, 2013 at 05:14:56PM +0800, liu ping fan wrote:
> On Tue, Jun 18, 2013 at 8:41 PM, Stefan Hajnoczi wrote:
> > On Thu, Jun 13, 2013 at 05:03:03PM +0800, Liu Ping Fan wrote:
> >> @@ -1109,6 +1146,7 @@ void net_cleanup(void)
> >> qemu_del_net_client(nc);
> >> }
> >
On Mon, Jul 1, 2013 at 1:40 PM, Peter Maydell wrote:
> g_hash_table_get_keys() was only introduced in glib 2.14, and we're
> still targeting a minimum version of 2.12. Rewrite the offending
> code (introduced in commit 721fae1) to use g_hash_table_foreach()
> to build the list of keys.
>
> Signed
On Mon, Jul 01, 2013 at 01:44:42PM +0200, Paolo Bonzini wrote:
> Il 25/06/2013 14:18, Gleb Natapov ha scritto:
> > On Tue, Jun 18, 2013 at 08:38:25PM -0300, Marcelo Tosatti wrote:
> >> >
> >> > v2: remove unnecessary runstate_is_running() usage (Paolo)
> >> >
> >> > --
> >> >
> >> > kvmclock sho
Il 28/06/2013 21:59, mrhi...@linux.vnet.ibm.com ha scritto:
> +/*
> + * Perform a non-optimized memory unregistration after every transfer
> + * for demonsration purposes, only if pin-all is not requested.
> + *
> + * Potential optimizations:
> + * 1. Start a new thread to run this function continu
On 1 July 2013 07:47, Stefan Hajnoczi wrote:
> Yes, Christian Berendt admins the buildmaster. How much time has passed
> since you emailed?
June 7; perhaps the email was lost. I would like to start with a
FreeBSD 9.x x86_64 instance, potentially adding i386 and FreeBSD
10-CURRENT to the mix la
On Fri, Jun 28, 2013 at 10:57:28AM +0800, Qiao Nuohan wrote:
> On 06/27/2013 04:54 PM, Stefan Hajnoczi wrote:
> >
> >The interesting question is how effective this approach is. If it's
> >good enough then it would be a fairly simple modification to dump.c.
>
> I see, if excluding zero page in ELF
Il 28/06/2013 04:28, Ian Main ha scritto:
> This patch adds sync-modes to the drive-backup interface and
> implements the FULL, NONE and TOP modes of synchronization.
>
> FULL performs as before copying the entire contents of the drive
> while preserving the point-in-time using CoW.
> NONE only co
In bdrv_delete() make sure to call bdrv_make_anon() *after* bdrv_close()
so that the device is still seen by bdrv_drain_all() when iterating
bdrv_states.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Stefan Hajnoczi
---
block.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/
If a block driver has no file descriptors to monitor but there are still
active requests, it can return 1 from .io_flush(). This is used to spin
during synchronous I/O.
Stop relying on .io_flush() and instead check
QLIST_EMPTY(&bs->tracked_requests) to decide whether there are active
requests.
T
aio_poll(ctx, true) will soon block when fd handlers have been set.
Previously aio_poll() would return early if all .io_flush() returned
false. This means we need to check the equivalent of the .io_flush()
condition *before* calling aio_poll(ctx, true) to avoid deadlock.
Reviewed-by: Paolo Bonzin
v5:
* Split out bdrv_delete() drain fix [bonzini]
* Fix commit message [bonzini]
v4:
* Ensure pending BHs are processed in bdrv_drain_all() [bonzini]
v3:
* I forgot about this series, time to push it again!
* Rebase onto qemu.git/master
* Drop now-unused AioFlushHandler typedef [bonzini]
aio_poll(ctx, true) will soon block if any fd handlers have been set.
Previously it would only block when .io_flush() returned true.
This means that callers must check their wait condition *before*
aio_poll() to avoid deadlock.
Reviewed-by: Paolo Bonzini
Signed-off-by: Stefan Hajnoczi
---
test
Check exit conditions before entering blocking aio_poll(). This is
mainly for consistency since it's unlikely that we are stopping in the
first event loop iteration.
Signed-off-by: Stefan Hajnoczi
---
hw/block/dataplane/virtio-blk.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
dif
Drop the io_flush argument to aio_set_event_notifier().
Reviewed-by: Paolo Bonzini
Signed-off-by: Stefan Hajnoczi
---
tests/test-aio.c | 22 --
1 file changed, 8 insertions(+), 14 deletions(-)
diff --git a/tests/test-aio.c b/tests/test-aio.c
index 1251952..7b2892a 100644
--
.io_flush() is no longer called so drop flush_true() and flush_io().
Signed-off-by: Stefan Hajnoczi
---
hw/block/dataplane/virtio-blk.c | 17 ++---
1 file changed, 2 insertions(+), 15 deletions(-)
diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c
index 0
Now that aio_poll() users check their termination condition themselves,
it is no longer necessary to call .io_flush() handlers.
The behavior of aio_poll() changes as follows:
1. .io_flush() is no longer invoked and file descriptors are *always*
monitored. Previously returning 0 from .io_flush()
.io_flush() is no longer called so drop iscsi_process_flush().
Signed-off-by: Stefan Hajnoczi
---
block/iscsi.c | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/block/iscsi.c b/block/iscsi.c
index 0bbf0b1..23c46ed 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -147,
.io_flush() is no longer called so drop thread_pool_active(). The block
layer is the only thread-pool.c user and it already tracks in-flight
requests, therefore we do not need thread_pool_active().
Signed-off-by: Stefan Hajnoczi
---
thread-pool.c | 8 +---
1 file changed, 1 insertion(+), 7
.io_flush() is no longer called so drop curl_aio_flush(). The acb[]
array that the function checks is still used in other parts of
block/curl.c. Therefore we cannot remove acb[], it is needed.
Signed-off-by: Stefan Hajnoczi
---
block/curl.c | 22 +++---
1 file changed, 3 insert
.io_flush() is no longer called so drop nbd_have_request(). We cannot
drop in_flight since it is still used by other block/nbd.c code.
Signed-off-by: Stefan Hajnoczi
---
block/nbd.c | 13 +++--
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/block/nbd.c b/block/nbd.c
inde
1 - 100 of 284 matches
Mail list logo
