[Qemu-devel] [PATCH v2 04/30] usb/hcd-xhci: QOM Upcast Sweep

2013-06-24 Thread peter . crosthwaite
From: Peter Crosthwaite Define and use standard QOM cast macro. Remove usages of DO_UPCAST and direct -> style upcasting. Signed-off-by: Peter Crosthwaite --- hw/usb/hcd-xhci.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/

[Qemu-devel] [PATCH v2 05/30] scsi/lsi53c895a: QOM Upcast Sweep

2013-06-24 Thread peter . crosthwaite
From: Peter Crosthwaite Define and use standard QOM cast macro. Remove usages of DO_UPCAST and direct -> style upcasting. Signed-off-by: Peter Crosthwaite --- hw/scsi/lsi53c895a.c | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/hw/scsi/lsi53c89

[Qemu-devel] [PATCH v2 06/30] scsi/megasas: QOM Upcast Sweep

2013-06-24 Thread peter . crosthwaite
From: Peter Crosthwaite Define and use standard QOM cast macro. Remove usages of DO_UPCAST and direct -> style upcasting. Signed-off-by: Peter Crosthwaite --- hw/scsi/megasas.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/hw/scsi/megasas.c b/hw/scsi/meg

[Qemu-devel] [PATCH v2 07/30] scsi/esp-pci: QOM Upcast Sweep

2013-06-24 Thread peter . crosthwaite
From: Peter Crosthwaite Define and use standard QOM cast macro. Remove usages of DO_UPCAST and direct -> style upcasting. Signed-off-by: Peter Crosthwaite --- hw/scsi/esp-pci.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/hw/scsi/esp-pci.c b/hw/scsi/esp-p

[Qemu-devel] [PATCH v2 08/30] ide/ich: QOM Upcast Sweep

2013-06-24 Thread peter . crosthwaite
From: Peter Crosthwaite Define and use standard QOM cast macro. Remove usages of DO_UPCAST and direct -> style upcasting. Signed-off-by: Peter Crosthwaite --- hw/ide/ahci.h | 5 + hw/ide/ich.c | 10 +- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/hw/ide/ahci.h

[Qemu-devel] [PATCH v2 09/30] ide/piix: QOM casting sweep

2013-06-24 Thread peter . crosthwaite
From: Peter Crosthwaite Use standard QOM cast macro. Remove usage of DO_UPCAST and direct -> style upcasting. Signed-off-by: Peter Crosthwaite --- hw/ide/piix.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/ide/piix.c b/hw/ide/piix.c index bf2856f..d0fdea3 100

[Qemu-devel] [PATCH v2 10/30] acpi/piix4: QOM Upcast Sweep

2013-06-24 Thread peter . crosthwaite
From: Peter Crosthwaite Use standard QOM cast macro. Remove usages of DO_UPCAST and direct -> style upcasting. Signed-off-by: Peter Crosthwaite --- hw/acpi/piix4.c | 31 +-- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/hw/acpi/piix4.c b/hw/acpi/p

[Qemu-devel] [PATCH v2 11/30] misc/pci-testdev: QOM Upcast Sweep

2013-06-24 Thread peter . crosthwaite
From: Peter Crosthwaite Define and use standard QOM cast macro. Remove usages of DO_UPCAST and direct -> style upcasting. Signed-off-by: Peter Crosthwaite --- hw/misc/pci-testdev.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/hw/misc/pci-testdev.c b/hw/misc/

[Qemu-devel] [PATCH v2 12/30] virtio/vmware_vga: QOM casting sweep

2013-06-24 Thread peter . crosthwaite
From: Peter Crosthwaite Define and use standard QOM cast macro. Remove usages of DO_UPCAST and direct -> style casting. Signed-off-by: Peter Crosthwaite --- hw/display/vmware_vga.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/hw/display/vmware_vga.c b/hw/d

[Qemu-devel] [PATCH v2 13/30] misc/ivshmem: QOM Upcast Sweep

2013-06-24 Thread peter . crosthwaite
From: Peter Crosthwaite Define and use standard QOM cast macro. Remove usages of DO_UPCAST and direct -> style upcasting. Signed-off-by: Peter Crosthwaite --- hw/misc/ivshmem.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/

[Qemu-devel] [PATCH v2 14/30] xen/xen_platform: QOM casting sweep

2013-06-24 Thread peter . crosthwaite
From: Peter Crosthwaite Define and use standard QOM cast macro. Remove usages of DO_UPCAST and direct -> style upcasting. Signed-off-by: Peter Crosthwaite --- hw/xen/xen_platform.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/hw/xen/xen_pl

[Qemu-devel] [PATCH v2 15/30] isa/*: QOM casting sweep

2013-06-24 Thread peter . crosthwaite
From: Peter Crosthwaite Use standard QOM cast macros. Remove usage of DO_UPCAST and direct -> style upcasting. Signed-off-by: Peter Crosthwaite --- hw/isa/i82378.c | 8 hw/isa/lpc_ich9.c | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/isa/i82378.c b/hw

[Qemu-devel] [PATCH v2 17/30] pci-bridge/pci_bridge_dev: Don't use DO_UPCAST

2013-06-24 Thread peter . crosthwaite
From: Peter Crosthwaite Just use the defined PCI_DEVICE cast macro. Signed-off-by: Peter Crosthwaite --- hw/pci-bridge/pci_bridge_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci-bridge/pci_bridge_dev.c b/hw/pci-bridge/pci_bridge_dev.c index 971b432..c845f38 10

[Qemu-devel] [PATCH v2 16/30] pci/*: QOM casting sweep

2013-06-24 Thread peter . crosthwaite
From: Peter Crosthwaite Use standard QOM cast macro. Remove usages of DO_UPCAST, container_of() and direct -> style upcasting. Signed-off-by: Peter Crosthwaite --- hw/pci/pci-hotplug.c | 18 ++ hw/pci/pci.c | 17 + hw/pci/pcie.c| 4 ++-- hw/pci

[Qemu-devel] [PATCH v2 18/30] pci-bridge/*: substitute ->qdev casts with DEVICE()

2013-06-24 Thread peter . crosthwaite
From: Peter Crosthwaite Signed-off-by: Peter Crosthwaite --- hw/pci-bridge/i82801b11.c | 2 +- hw/pci-bridge/ioh3420.c| 2 +- hw/pci-bridge/xio3130_downstream.c | 2 +- hw/pci-bridge/xio3130_upstream.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git

[Qemu-devel] [PATCH v2 19/30] pci/pci_bridge: substitute ->qdev casts with DEVICE()

2013-06-24 Thread peter . crosthwaite
From: Peter Crosthwaite Signed-off-by: Peter Crosthwaite --- hw/pci/pci_bridge.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/pci/pci_bridge.c b/hw/pci/pci_bridge.c index 24be6c5..f6657e8 100644 --- a/hw/pci/pci_bridge.c +++ b/hw/pci/pci_bridge.c @@ -330,6 +330

[Qemu-devel] [PATCH v2 20/30] misc/vfio: substitute ->qdev casts with DEVICE()

2013-06-24 Thread peter . crosthwaite
From: Peter Crosthwaite Signed-off-by: Peter Crosthwaite --- hw/misc/vfio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/misc/vfio.c b/hw/misc/vfio.c index 52fb036..8e3524f 100644 --- a/hw/misc/vfio.c +++ b/hw/misc/vfio.c @@ -3074,7 +3074,7 @@ static int vfio_init

[Qemu-devel] [PATCH v2 21/30] net/eepro100: substitute ->qdev casts with DEVICE()

2013-06-24 Thread peter . crosthwaite
From: Peter Crosthwaite Signed-off-by: Peter Crosthwaite --- hw/net/eepro100.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/hw/net/eepro100.c b/hw/net/eepro100.c index dc99ea6..f34b5dc 100644 --- a/hw/net/eepro100.c +++ b/hw/net/eepro100.c @@ -1842,13 +184

[Qemu-devel] [PATCH v2 22/30] net/ne2000: substitute ->qdev casts with DEVICE()

2013-06-24 Thread peter . crosthwaite
From: Peter Crosthwaite Signed-off-by: Peter Crosthwaite --- hw/net/ne2000.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/net/ne2000.c b/hw/net/ne2000.c index 33ee03e..70a7991 100644 --- a/hw/net/ne2000.c +++ b/hw/net/ne2000.c @@ -722,6 +722,8 @@ static NetClien

[Qemu-devel] [PATCH v2 23/30] usb/*: substitute ->qdev casts with DEVICE()

2013-06-24 Thread peter . crosthwaite
From: Peter Crosthwaite Signed-off-by: Peter Crosthwaite --- hw/usb/hcd-ehci-pci.c | 13 - hw/usb/hcd-ohci.c | 2 +- hw/usb/hcd-uhci.c | 2 +- 3 files changed, 10 insertions(+), 7 deletions(-) diff --git a/hw/usb/hcd-ehci-pci.c b/hw/usb/hcd-ehci-pci.c index f1b5f5d..998a

[Qemu-devel] [PATCH v2 24/30] watchdog/wdt_i6300esb: substitute ->qdev casts with DEVICE()

2013-06-24 Thread peter . crosthwaite
From: Peter Crosthwaite Signed-off-by: Peter Crosthwaite --- hw/watchdog/wdt_i6300esb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/watchdog/wdt_i6300esb.c b/hw/watchdog/wdt_i6300esb.c index 05af0b1..93077bb 100644 --- a/hw/watchdog/wdt_i6300esb.c +++ b/hw/watchdog/w

[Qemu-devel] [PATCH v2 25/30] scsi/vmw_pvscsi: substitute ->qdev casts with DEVICE()

2013-06-24 Thread peter . crosthwaite
From: Peter Crosthwaite Signed-off-by: Peter Crosthwaite --- hw/scsi/vmw_pvscsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/scsi/vmw_pvscsi.c b/hw/scsi/vmw_pvscsi.c index 7cf4044..35b971d 100644 --- a/hw/scsi/vmw_pvscsi.c +++ b/hw/scsi/vmw_pvscsi.c @@ -1088,7 +1088

[Qemu-devel] [PATCH V3 02/10] NUMA: Add numa_info structure to contain numa nodes info

2013-06-24 Thread Wanlong Gao
Add the numa_info structure to contain the numa nodes memory, VCPUs information and the future added numa nodes host memory policies. Signed-off-by: Andre Przywara Signed-off-by: Wanlong Gao --- cpus.c | 2 +- hw/i386/pc.c| 4 ++-- hw/net/eepro100.c | 1 -

[Qemu-devel] [PATCH V3 05/10] NUMA: handle Error in cpus, mpol and hostnode parser

2013-06-24 Thread Wanlong Gao
As Paolo pointed out that, handle Error in mpol and hostnode parser will make it easier to be used for example in mem-hotplug in the future. And this will be used later in set-mpol QMP command. Also handle Error in cpus parser to be consistent with others. Signed-off-by: Wanlong Gao --- include/

Re: [Qemu-devel] [PATCH] RFC kvm irqfd: add directly mapped MSI IRQ support

2013-06-24 Thread Gleb Natapov
On Sun, Jun 23, 2013 at 10:06:05AM -0500, Anthony Liguori wrote: > On Thu, Jun 20, 2013 at 11:46 PM, Alex Williamson > wrote: > > On Fri, 2013-06-21 at 12:49 +1000, Alexey Kardashevskiy wrote: > >> On 06/21/2013 12:34 PM, Alex Williamson wrote: > >> > >> > >> Do not follow you, sorry. For x86, is

[Qemu-devel] [PATCH V3 03/10] NUMA: Add Linux libnuma detection

2013-06-24 Thread Wanlong Gao
Add detection of libnuma (mostly contained in the numactl package) to the configure script. Can be enabled or disabled on the command line, default is use if available. Signed-off-by: Andre Przywara Signed-off-by: Wanlong Gao --- configure | 32 1 file changed,

[Qemu-devel] [PATCH V3 08/10] NUMA: add qmp command set-mpol to set memory policy for NUMA node

2013-06-24 Thread Wanlong Gao
The QMP command let it be able to set node's memory policy through the QMP protocol. The qmp-shell command is like: set-mpol nodeid=0 mem-policy=membind mem-hostnode=0-1 Signed-off-by: Wanlong Gao --- cpus.c | 54 ++ qapi-schema.j

[Qemu-devel] [PATCH V3 10/10] NUMA: show host memory policy info in info numa command

2013-06-24 Thread Wanlong Gao
Show host memory policy of nodes in the info numa monitor command. After this patch, the monitor command "info numa" will show the information like following if the host numa support is enabled: (qemu) info numa 2 nodes node 0 cpus: 0 node 0 size: 1024 MB node 0 mempolicy: memb

[Qemu-devel] [PATCH V3 00/10] Add support for binding guest numa nodes to host numa nodes

2013-06-24 Thread Wanlong Gao
As you know, QEMU can't direct it's memory allocation now, this may cause guest cross node access performance regression. And, the worse thing is that if PCI-passthrough is used, direct-attached-device uses DMA transfer between device and qemu process. All pages of the guest will be pinned by get_u

[Qemu-devel] [PATCH v2 26/30] i2c/smbus_ich9: substitute ->qdev casts with DEVICE()

2013-06-24 Thread peter . crosthwaite
From: Peter Crosthwaite Signed-off-by: Peter Crosthwaite --- hw/i2c/smbus_ich9.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i2c/smbus_ich9.c b/hw/i2c/smbus_ich9.c index ca22978..f87343f 100644 --- a/hw/i2c/smbus_ich9.c +++ b/hw/i2c/smbus_ich9.c @@ -82,7 +82,7 @@ sta

[Qemu-devel] [PATCH V3 09/10] NUMA: add hmp command set-mpol

2013-06-24 Thread Wanlong Gao
Add hmp command set-mpol to set host memory policy for a guest NUMA node. Then we can also set node's memory policy using the monitor command like: (qemu) set-mpol 0 mem-policy=membind,mem-hostnode=0-1 Signed-off-by: Wanlong Gao --- hmp-commands.hx | 16 hmp.c | 35

[Qemu-devel] [PATCH V3 07/10] NUMA: set guest numa nodes memory policy

2013-06-24 Thread Wanlong Gao
Set the guest numa nodes memory policies using the mbind(2) system call node by node. After this patch, we are able to set guest nodes memory policies through the QEMU options, this arms to solve the guest cross nodes memory access performance issue. And as you all know, if PCI-passthrough is used,

[Qemu-devel] [PATCH v2 30/30] i386/*: substitute ->qdev casts with DEVICE()

2013-06-24 Thread peter . crosthwaite
From: Peter Crosthwaite Signed-off-by: Peter Crosthwaite --- hw/i386/kvm/pci-assign.c | 21 - hw/i386/pc.c | 3 ++- hw/i386/pc_piix.c| 4 ++-- hw/i386/pc_q35.c | 4 ++-- 4 files changed, 18 insertions(+), 14 deletions(-) diff --git a/hw/i386/

[Qemu-devel] [PATCH V3 01/10] NUMA: Support multiple CPU ranges on -numa option

2013-06-24 Thread Wanlong Gao
From: Bandan Das This allows us to use the "cpus" property multiple times to specify multiple cpu (ranges) to the -numa option : -numa node,cpus=1,cpus=2,cpus=4 or -numa node,cpus=1-3,cpus=5 Note that after this patch, the defalut suffix of "-numa node,mem=N" will no longer be "M". So we must a

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 00/13] A bunch of little socket + chardev fixes

2013-06-24 Thread Michael Tokarev
24.06.2013 10:39, Gerd Hoffmann wrote: > Hi, > > Here is v2 of the series, addressing Michaels review comments. Thank you Gerd, applied all series to the trivial-patches queue, with two edits: > qemu-char: use ChardevBackendKind in in CharDriver > qemu-char: report udb backend errors fxed

[Qemu-devel] [PATCH v2 27/30] ide/cmd646: substitute ->qdev casts with DEVICE()

2013-06-24 Thread peter . crosthwaite
From: Peter Crosthwaite Signed-off-by: Peter Crosthwaite --- hw/ide/cmd646.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/ide/cmd646.c b/hw/ide/cmd646.c index a73eb9a..9544c1f 100644 --- a/hw/ide/cmd646.c +++ b/hw/ide/cmd646.c @@ -281,7 +281,7 @@ static int pc

[Qemu-devel] [PATCH V3 06/10] NUMA: split out the common range parser

2013-06-24 Thread Wanlong Gao
Since cpus parser and hostnode parser have the common range parser part, split it out to the common range parser to avoid the duplicate code. Signed-off-by: Wanlong Gao --- vl.c | 89 1 file changed, 37 insertions(+), 52 deleti

[Qemu-devel] [PATCH V3 04/10] NUMA: parse guest numa nodes memory policy

2013-06-24 Thread Wanlong Gao
The memory policy setting format is like: mem-policy={membind|interleave|preferred},mem-hostnode=[+|!]{all|N-N} And we are adding this setting as a suboption of "-numa", the memory policy then can be set like following: -numa node,nodeid=0,mem=1024,cpus=0,mem-policy=membind,mem-hostnode=0-1 -numa

[Qemu-devel] [PATCH v2 29/30] pci-host/*: substitute ->qdev casts with DEVICE()

2013-06-24 Thread peter . crosthwaite
From: Peter Crosthwaite Signed-off-by: Peter Crosthwaite --- hw/pci-bridge/dec.c | 2 +- hw/pci-host/apb.c | 4 ++-- hw/pci-host/q35.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/pci-bridge/dec.c b/hw/pci-bridge/dec.c index cff458b..1e5611d 100644 --- a/hw/p

[Qemu-devel] [target-mips] How to use smp?

2013-06-24 Thread Dongxue Zhang
Hello everybody, i want to use mips target with smp support. When use command without smp, then the log stopped at "kernel panic", when -smp 2 added, it stoppted at "NR_IRQS:256". I use the git qemu at 576156ffed72ab4feb0b752979db86ff8759a2a1 qemu configed with "./configure --target-list=mips64el

[Qemu-devel] [PATCH 1/2] qxl: fix Coverity scan SIGN_EXTENSION error

2013-06-24 Thread Gerd Hoffmann
Cc: Markus Armbruster Signed-off-by: Gerd Hoffmann --- hw/display/qxl-render.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/display/qxl-render.c b/hw/display/qxl-render.c index f511a62..269b1a7 100644 --- a/hw/display/qxl-render.c +++ b/hw/display/qxl-render.c @@ -19

[Qemu-devel] [PULL 0/2] spice patch queue

2013-06-24 Thread Gerd Hoffmann
Hi, Tiny spice patch queue with only two patches, one adding a spice cmd line option and one bugfix. please pull, Gerd The following changes since commit 576156ffed72ab4feb0b752979db86ff8759a2a1: Merge remote-tracking branch 'bonzini/iommu-for-anthony' into staging (2013-06-20 16:53:39 -

[Qemu-devel] [PATCH 2/2] spice: Add -spice disable-agent-file-transfer cmdline option (rhbz#961850)

2013-06-24 Thread Gerd Hoffmann
From: Hans de Goede Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- qemu-options.hx |7 +-- ui/spice-core.c | 13 + 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 8355f9b..c1533a3 100644 --- a/qemu-opt

Re: [Qemu-devel] [PATCH v4] QEMUBH: make AioContext's bh re-entrant

2013-06-24 Thread Stefan Hajnoczi
On Mon, Jun 24, 2013 at 05:54:26PM +0800, Liu Ping Fan wrote: > BH will be used outside big lock, so introduce lock to protect > between the writers, ie, bh's adders and deleter. The lock only > affects the writers and bh's callback does not take this extra lock. > Note that for the same AioContext

Re: [Qemu-devel] [PATCH 0/3] multiboot: Fix memory information

2013-06-24 Thread Kevin Wolf
Am 23.06.2013 um 23:39 hat Anthony Liguori geschrieben: > Kevin Wolf writes: > > > Kevin Wolf (3): > > multiboot: Don't forget last mmap entry > > multiboot: Calculate upper_mem in the ROM > > multiboot: Updated ROM binary > > Reviewed-by: Anthony Liguori > > Do you have a test case that

Re: [Qemu-devel] [PATCH v2 07/13] qemu-char: fix documentation for telnet+wait socket flags

2013-06-24 Thread Markus Armbruster
Gerd Hoffmann writes: > Signed-off-by: Gerd Hoffmann > --- > qapi-schema.json |7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/qapi-schema.json b/qapi-schema.json > index a80ee40..a29ce57 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -3185,10 +3

[Qemu-devel] [PATCH v2 28/30] ide/via: substitute ->qdev casts with DEVICE()

2013-06-24 Thread peter . crosthwaite
From: Peter Crosthwaite Signed-off-by: Peter Crosthwaite --- hw/ide/via.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ide/via.c b/hw/ide/via.c index 5fe053c..b81e1fe 100644 --- a/hw/ide/via.c +++ b/hw/ide/via.c @@ -158,7 +158,7 @@ static void vt82c686b_init_ports

Re: [Qemu-devel] [PATCH 1/2] iscsi: add support for bdrv_co_is_allocated()

2013-06-24 Thread Stefan Hajnoczi
On Fri, Jun 21, 2013 at 11:18:42AM +0200, Kevin Wolf wrote: > Am 20.06.2013 um 20:20 hat Peter Lieven geschrieben: > > @@ -800,6 +801,60 @@ iscsi_getlength(BlockDriverState *bs) > > return len; > > } > > > > +static int coroutine_fn iscsi_co_is_allocated(BlockDriverState *bs, > > +

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 00/13] A bunch of little socket + chardev fixes

2013-06-24 Thread Markus Armbruster
Michael Tokarev writes: > 24.06.2013 10:39, Gerd Hoffmann wrote: >> Hi, >> >> Here is v2 of the series, addressing Michaels review comments. > > Thank you Gerd, applied all series to the trivial-patches queue, > with two edits: > >> qemu-char: use ChardevBackendKind in in CharDriver >> qem

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 00/13] A bunch of little socket + chardev fixes

2013-06-24 Thread Michael Tokarev
24.06.2013 12:14, Markus Armbruster wrote: > Michael Tokarev writes: [] >> Thank you Gerd, applied all series to the trivial-patches queue, >> with two edits: >> >>> qemu-char: use ChardevBackendKind in in CharDriver >>> qemu-char: report udb backend errors >> >> fxed these :) > > My commit m

Re: [Qemu-devel] [PATCH 2/2] PPC: Fix GDB read on code area for PPC6xx

2013-06-24 Thread Fabien Chouteau
On 06/22/2013 02:26 AM, Alexander Graf wrote: > Thanks, applied to ppc-next. Teaching gdb a new protocol is way out of scope > for these rare cases :). > Thanks guys, -- Fabien Chouteau

[Qemu-devel] [PATCH v4 11/14] ioport: Switch dispatching to memory core layer

2013-06-24 Thread Jan Kiszka
The current ioport dispatcher is a complex beast, mostly due to the need to deal with old portio interface users. But we can overcome it without converting all portio users by embedding the required base address of a MemoryRegionPortio access into that data structure. That removes the need to have

Re: [Qemu-devel] [PATCH v2 02/13] qemu-socket: drop pointless allocation

2013-06-24 Thread Markus Armbruster
Gerd Hoffmann writes: > Signed-off-by: Gerd Hoffmann > --- > util/qemu-sockets.c |1 - > 1 file changed, 1 deletion(-) > > diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c > index 86fb09c..35023a8 100644 > --- a/util/qemu-sockets.c > +++ b/util/qemu-sockets.c > @@ -871,7 +871,6 @@ Soc

Re: [Qemu-devel] [PATCH v2 00/13] A bunch of little socket + chardev fixes

2013-06-24 Thread Laszlo Ersek
On 06/24/13 08:39, Gerd Hoffmann wrote: > Hi, > > Here is v2 of the series, addressing Michaels review comments. > > cheers, > Gerd > > Gerd Hoffmann (13): > qemu-socket: zero-initialize SocketAddress > qemu-socket: drop pointless allocation > qemu-socket: catch monitor_get_fd failures

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 00/13] A bunch of little socket + chardev fixes

2013-06-24 Thread Markus Armbruster
Michael Tokarev writes: > 24.06.2013 12:14, Markus Armbruster wrote: >> Michael Tokarev writes: > [] >>> Thank you Gerd, applied all series to the trivial-patches queue, >>> with two edits: >>> qemu-char: use ChardevBackendKind in in CharDriver qemu-char: report udb backend errors

Re: [Qemu-devel] [PATCH v2 12/13] qemu-char: report udb backend errors

2013-06-24 Thread Markus Armbruster
Typo in subject: s/udb/UDP/ Gerd Hoffmann writes: > Signed-off-by: Gerd Hoffmann > --- > qemu-char.c |2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/qemu-char.c b/qemu-char.c > index 7d072a8..dcc91bb 100644 > --- a/qemu-char.c > +++ b/qemu-char.c > @@ -2255,6 +2255,8 @@ static Ch

[Qemu-devel] [PATCH 05/23] ide: Convert verify commands to ide_cmd_table handler

2013-06-24 Thread Stefan Hajnoczi
From: Kevin Wolf Signed-off-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- hw/ide/core.c | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index 057662d..bf2007a 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -

[Qemu-devel] [PATCH 02/23] ide: Convert WIN_DSM to ide_cmd_table handler

2013-06-24 Thread Stefan Hajnoczi
From: Kevin Wolf Signed-off-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- hw/ide/core.c | 29 - 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index cd9de14..567515e 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@

[Qemu-devel] [PULL 00/23] Block patches

2013-06-24 Thread Stefan Hajnoczi
The following changes since commit 576156ffed72ab4feb0b752979db86ff8759a2a1: Merge remote-tracking branch 'bonzini/iommu-for-anthony' into staging (2013-06-20 16:53:39 -0500) are available in the git repository at: git://github.com/stefanha/qemu.git block for you to fetch changes up to 96

[Qemu-devel] [PATCH 11/23] ide: Convert SET FEATURES to ide_cmd_table handler

2013-06-24 Thread Stefan Hajnoczi
From: Kevin Wolf Signed-off-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- hw/ide/core.c | 147 ++ 1 file changed, 75 insertions(+), 72 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index a7f8445..8789758 100644 --- a/hw/ide

[Qemu-devel] [PATCH 03/23] ide: Convert WIN_IDENTIFY to ide_cmd_table handler

2013-06-24 Thread Stefan Hajnoczi
From: Kevin Wolf Signed-off-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- hw/ide/core.c | 40 +++- 1 file changed, 23 insertions(+), 17 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index 567515e..2df078b 100644 --- a/hw/ide/core.c +++ b/hw/id

[Qemu-devel] [PATCH 01/23] ide: Add handler to ide_cmd_table

2013-06-24 Thread Stefan Hajnoczi
From: Kevin Wolf As a preparation for moving all IDE commands into their own function like in the ATAPI code, introduce a 'handler' callback to ide_cmd_table. Commands using this new infrastructure get some things handled automatically: * The BSY flag is set before calling the handler (in order

[Qemu-devel] [PATCH 23/23] vmdk: refuse to open higher version than supported

2013-06-24 Thread Stefan Hajnoczi
From: Fam Zheng Refuse to open higher version for safety. Although we try to be compatible with published VMDK spec, VMware has newer version from ESXi 5.1 exported OVF/OVA, which we have no knowledge what's changed in it. And it is very likely to have more new versions in the future, so it's no

[Qemu-devel] [PATCH 09/23] ide: Convert READ NATIVE MAX ADDRESS to ide_cmd_table handler

2013-06-24 Thread Stefan Hajnoczi
From: Kevin Wolf Signed-off-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- hw/ide/core.c | 35 ++- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index 2c8a0ff..3064e2e 100644 --- a/hw/ide/core.c +++ b/hw/ide/cor

[Qemu-devel] [PATCH 04/23] ide: Convert cmd_nop commands to ide_cmd_table handler

2013-06-24 Thread Stefan Hajnoczi
From: Kevin Wolf cmd_nop handles all commands that don't really do anything in our implementation except setting status register flags. Signed-off-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- hw/ide/core.c | 48 +--- 1 file changed, 17 insertio

[Qemu-devel] [PATCH 19/23] qcow2: Add refcount update reason to all callers

2013-06-24 Thread Stefan Hajnoczi
From: Kevin Wolf This adds a refcount update reason to all callers of update_refcounts(), so that a follow-up patch can use this information to decide whether clusters that reach a refcount of 0 should be discarded in the image file. Signed-off-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi ---

[Qemu-devel] [PATCH 12/23] ide: Convert FLUSH CACHE to ide_cmd_table handler

2013-06-24 Thread Stefan Hajnoczi
From: Kevin Wolf Signed-off-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- hw/ide/core.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index 8789758..83e86aa 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -1184,6 +1184,12

[Qemu-devel] [PATCH 06/23] ide: Convert read/write multiple commands to ide_cmd_table handler

2013-06-24 Thread Stefan Hajnoczi
From: Kevin Wolf Signed-off-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- hw/ide/core.c | 119 +- 1 file changed, 60 insertions(+), 59 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index bf2007a..e6cd7b8 100644 --- a/hw/ide

[Qemu-devel] [PATCH 16/23] ide: Convert SMART commands to ide_cmd_table handler

2013-06-24 Thread Stefan Hajnoczi
From: Kevin Wolf Signed-off-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- hw/ide/core.c | 325 +++--- 1 file changed, 174 insertions(+), 151 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index a563f6e..1c8f414 100644 --- a/hw/i

[Qemu-devel] [PATCH 10/23] ide: Convert CHECK POWER MDOE to ide_cmd_table handler

2013-06-24 Thread Stefan Hajnoczi
From: Kevin Wolf Signed-off-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- hw/ide/core.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index 3064e2e..a7f8445 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -1200,6 +1200

[Qemu-devel] [PATCH 08/23] ide: Convert DMA read/write commands to ide_cmd_table handler

2013-06-24 Thread Stefan Hajnoczi
From: Kevin Wolf Signed-off-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- hw/ide/core.c | 69 --- 1 file changed, 38 insertions(+), 31 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index 86af4b0..2c8a0ff 100644 --- a/hw/ide

[Qemu-devel] [PATCH 17/23] ide: Clean up ide_exec_cmd()

2013-06-24 Thread Stefan Hajnoczi
From: Kevin Wolf All commands are now converted to ide_cmd_table handlers, so it can be unconditional now and the old switch block can go. Signed-off-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- hw/ide/core.c | 36 1 file changed, 12 insertions(+), 24

Re: [Qemu-devel] [PATCH v2] vmdk: refuse to open higher version than supported

2013-06-24 Thread Stefan Hajnoczi
On Thu, Jun 13, 2013 at 11:21:29AM +0800, Fam Zheng wrote: > Refuse to open higher version for safety. > > Although we try to be compatible with published VMDK spec, VMware has > newer version from ESXi 5.1 exported OVF/OVA, which we have no knowledge > what's changed in it. And it is very likely

[Qemu-devel] [PATCH 20/23] qcow2: Options to enable discard for freed clusters

2013-06-24 Thread Stefan Hajnoczi
From: Kevin Wolf Deleted snapshots are discarded in the image file by default, discard requests take their default from the -drive discard=... option and other places that free clusters must always be enabled explicitly. Signed-off-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- block/qcow2

[Qemu-devel] [PATCH 07/23] ide: Convert PIO read/write commands to ide_cmd_table handler

2013-06-24 Thread Stefan Hajnoczi
From: Kevin Wolf Signed-off-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- hw/ide/core.c | 93 --- 1 file changed, 50 insertions(+), 43 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index e6cd7b8..86af4b0 100644 --- a/hw/ide

[Qemu-devel] [PATCH 22/23] block: Always enable discard on the protocol level

2013-06-24 Thread Stefan Hajnoczi
From: Kevin Wolf Turning on discard options in qcow2 doesn't help a lot when the discard requests that it issues are thrown away by the raw-posix layer. This patch always enables discard functionality on the protocol level so that it's the image format's responsibility to send (or not) discard re

[Qemu-devel] [PATCH 13/23] ide: Convert SEEK to ide_cmd_table handler

2013-06-24 Thread Stefan Hajnoczi
From: Kevin Wolf Signed-off-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- hw/ide/core.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index 83e86aa..76a3fdf 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -1190,6 +1190,12

[Qemu-devel] [PATCH 18/23] Revert "block: Disable driver-specific options for 1.5"

2013-06-24 Thread Stefan Hajnoczi
From: Kevin Wolf This reverts commit 8ec7d390b0d50b5e5b4b1d8dba7ba40d64a70875. Signed-off-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- blockdev.c | 118 ++- tests/qemu-iotests/group | 2 +- 2 files changed, 5 insertions(+), 115

[Qemu-devel] [PATCH 14/23] ide: Convert ATAPI commands to ide_cmd_table handler

2013-06-24 Thread Stefan Hajnoczi
From: Kevin Wolf Signed-off-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- hw/ide/core.c | 100 +++--- 1 file changed, 61 insertions(+), 39 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index 76a3fdf..eebd5d9 100644 --- a/hw/ide

[Qemu-devel] [PATCH 21/23] qcow2: Batch discards

2013-06-24 Thread Stefan Hajnoczi
From: Kevin Wolf This optimises the discard operation for freed clusters by batching discard requests (both snapshot deletion and bdrv_discard end up updating the refcounts cluster by cluster). Note that we don't discard asynchronously, but keep s->lock held. This is to avoid that a freed cluste

Re: [Qemu-devel] Adding a persistent writeback cache to qemu

2013-06-24 Thread Stefan Hajnoczi
On Fri, Jun 21, 2013 at 11:18:07PM +0800, Liu Yuan wrote: > On 06/20/2013 11:58 PM, Sage Weil wrote: > > On Thu, 20 Jun 2013, Stefan Hajnoczi wrote: > >>> The concrete problem here is that flashcache/dm-cache/bcache don't > >>> work with the rbd (librbd) driver, as flashcache/dm-cache/bcache > >>>

Re: [Qemu-devel] qemu bug

2013-06-24 Thread Stefan Hajnoczi
On Thu, Jun 20, 2013 at 09:44:16AM -0600, jacek burghardt wrote: > i had compiled latest qemu master git with xen now i am getting this error > $r/include/qemu/int128.h:18: int128_get64: Assertion `!a.hi' failed. i > wonder what could be causing this . If it worked before then git-bisect(1) will

Re: [Qemu-devel] [PATCH] [slirp] add nextserver support in slirp's dhcp-server

2013-06-24 Thread Stefan Hajnoczi
On Fri, Jun 21, 2013 at 03:20:09PM +0200, Bas van Sisseren wrote: > The slirp dhcp-server normally returns its own address as tftp > nextserver for netbooting. This patch makes that address > configurable, so it is possible to use an external tftp boot- > environment. > > Signed-off-by: Bas van Si

[Qemu-devel] [PATCH 15/23] ide: Convert CF-ATA commands to ide_cmd_table handler

2013-06-24 Thread Stefan Hajnoczi
From: Kevin Wolf Signed-off-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- hw/ide/core.c | 170 -- 1 file changed, 95 insertions(+), 75 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index eebd5d9..a563f6e 100644 --- a/hw/ide

Re: [Qemu-devel] qemu bug

2013-06-24 Thread Peter Maydell
On 24 June 2013 10:34, Stefan Hajnoczi wrote: > On Thu, Jun 20, 2013 at 09:44:16AM -0600, jacek burghardt wrote: >> i had compiled latest qemu master git with xen now i am getting this error >> $r/include/qemu/int128.h:18: int128_get64: Assertion `!a.hi' failed. i >> wonder what could be causing

Re: [Qemu-devel] [PATCH 21/26] kvmclock: use realize for kvmclock

2013-06-24 Thread Igor Mammedov
On Sat, 22 Jun 2013 16:50:33 +0800 Hu Tao wrote: > Cc: qemu-devel@nongnu.org > Cc: "Andreas Färber" > Cc: Paolo Bonzini > Cc: Anthony Liguori > Cc: Igor Mammedov > Cc: Eduardo Habkost > Signed-off-by: Hu Tao > --- > hw/i386/kvm/clock.c | 8 +++- > 1 file changed, 3 insertions(+), 5 del

[Qemu-devel] [PATCH 0/2] device_tree: add qemu_devtree_setprop_sized_cells()

2013-06-24 Thread Peter Maydell
These patches add a new function qemu_devtree_setprop_sized_cells() to device_tree.c and use it in arm/boot.c. We already have a qemu_devtree_setprop_cells() which sets a dtb property to an array of cells whose values are specified by varargs. However for the fairly common case of setting a proper

[Qemu-devel] [PATCH 2/2] arm/boot: Use qemu_devtree_setprop_sized_cells()

2013-06-24 Thread Peter Maydell
Replace the opencoded assembly of the reg property array for the /memory node with a call to qemu_devtree_setprop_sized_cells(). Signed-off-by: Peter Maydell --- hw/arm/boot.c | 28 +++- 1 file changed, 7 insertions(+), 21 deletions(-) diff --git a/hw/arm/boot.c b/hw/a

[Qemu-devel] [PATCH 1/2] device_tree: Add qemu_devtree_setprop_sized_cells() utility function

2013-06-24 Thread Peter Maydell
We already have a qemu_devtree_setprop_cells() which sets a dtb property to an array of cells whose values are specified by varargs. However for the fairly common case of setting a property to a list of addresses or of address,size pairs the number of cells used by each element in the list depends

Re: [Qemu-devel] Adding a persistent writeback cache to qemu

2013-06-24 Thread Alex Bligh
Stefan, --On 24 June 2013 11:31:35 +0200 Stefan Hajnoczi wrote: It sounds like the cache is in the sheep daemon and therefore has a global view of all volumes being accessed from this host. That way it can do things like share the cached snapshot data between volumes. Yes, that's potentiall

[Qemu-devel] [PATCH] MAINTAINERS: fix bad F: patterns

2013-06-24 Thread Peter Maydell
This patch fixes a number of incorrect F: patterns which didn't match any files in the source tree. This was caused by a mix of minor typos (- for _ and the like) and a few entries which hadn't been correctly updated following the rearrangement of hw/. Offending entries were located with the follo

Re: [Qemu-devel] [PATCH 1/2] device_tree: Add qemu_devtree_setprop_sized_cells() utility function

2013-06-24 Thread Alexander Graf
On 24.06.2013, at 12:22, Peter Maydell wrote: > We already have a qemu_devtree_setprop_cells() which sets a dtb > property to an array of cells whose values are specified by varargs. > However for the fairly common case of setting a property to a list > of addresses or of address,size pairs the n

[Qemu-devel] [PATCH 3/3] virtio-ccw: Wire up guest and host notifies.

2013-06-24 Thread Cornelia Huck
Guest and host notifiers are needed by vhost. We use ioeventfds for the guest notifiers, but need to fall back on qemu injecting interrupts for the host notifiers. Signed-off-by: Cornelia Huck --- hw/s390x/virtio-ccw.c | 88 + hw/s390x/virtio-ccw

[Qemu-devel] [PATCH 1/3] s390/virtio-ccw: Fix virtio reset

2013-06-24 Thread Cornelia Huck
From: Christian Borntraeger On virtio reset we must reset the indicator to avoid stale interrupts, e.g. after a reset. Signed-off-by: Christian Borntraeger Cc: qemu-sta...@nongnu.org Signed-off-by: Cornelia Huck --- hw/s390x/virtio-ccw.c |2 ++ 1 file changed, 2 insertions(+) diff --git

[Qemu-devel] [PATCH 0/3] virtio-ccw patches as of 2013/06/24

2013-06-24 Thread Cornelia Huck
Hi, the following patches are currently sitting in git://github.com/cohuck/qemu virtio-ccw-upstr First, a bugfix for rebooting. Second, the wiring up of ioeventfds and enablement of notifiers. Christian Borntraeger (1): s390/virtio-ccw: Fix virtio reset Cornelia Huck (2): virtio-ccw: Wire

[Qemu-devel] [PATCH 2/3] virtio-ccw: Wire up ioeventfd.

2013-06-24 Thread Cornelia Huck
On hosts that support ioeventfd, make use of it for host-to-guest notifications via diagnose 500. Signed-off-by: Cornelia Huck --- hw/s390x/css.c|2 +- hw/s390x/css.h|1 + hw/s390x/virtio-ccw.c | 117 + hw/s390x/virtio-ccw.

Re: [Qemu-devel] [PATCH 1/2] device_tree: Add qemu_devtree_setprop_sized_cells() utility function

2013-06-24 Thread Peter Maydell
On 24 June 2013 11:56, Alexander Graf wrote: > On 24.06.2013, at 12:22, Peter Maydell wrote: >> We already have a qemu_devtree_setprop_cells() which sets a dtb >> property to an array of cells whose values are specified by varargs. >> However for the fairly common case of setting a property to a l

[Qemu-devel] [PATCH] vl: convert -smp to qemu_opts_parse()

2013-06-24 Thread Michael Tokarev
This also introduces a new suboption, "cpus=", which is the default. So after this patch, -smp n,sockets=y is the same as -smp cpus=n,sockets=y (with "cpu" being some generic thing, referring to either cores, or threads, or sockets, as before). We still don't validate relations between dif

Re: [Qemu-devel] qemu bug

2013-06-24 Thread jacek burghardt
The latest qemu is working fine. On Mon, Jun 24, 2013 at 3:58 AM, Peter Maydell wrote: > On 24 June 2013 10:34, Stefan Hajnoczi wrote: > > On Thu, Jun 20, 2013 at 09:44:16AM -0600, jacek burghardt wrote: > >> i had compiled latest qemu master git with xen now i am getting this > error > >> $r/

Re: [Qemu-devel] [PATCH] RFC kvm irqfd: add directly mapped MSI IRQ support

2013-06-24 Thread Michael S. Tsirkin
On Mon, Jun 24, 2013 at 07:36:25AM +1000, Benjamin Herrenschmidt wrote: > On Sun, 2013-06-23 at 17:07 +0300, Michael S. Tsirkin wrote: > > Yes I think that's fine really. > > > > Basically devices all speak MSIMessage as they should - > > this is what the PCI spec says. > > On all normal s

  1   2   3   4   >