On 06/24/13 08:39, Gerd Hoffmann wrote: > Hi, > > Here is v2 of the series, addressing Michaels review comments. > > cheers, > Gerd > > Gerd Hoffmann (13): > qemu-socket: zero-initialize SocketAddress > qemu-socket: drop pointless allocation > qemu-socket: catch monitor_get_fd failures > qemu-char: check optional fields using has_* > qemu-char: use more specific error_setg_* variants > qemu-char: print notification to stderr > qemu-char: fix documentation for telnet+wait socket flags > qemu-char: don't leak opts on error > qemu-char: use ChardevBackendKind in in CharDriver > qemu-char: minor mux chardev fixes > qemu-char: add -chardev mux support > qemu-char: report udb backend errors > qemu-socket: don't leak opts on error > > include/sysemu/char.h | 2 +- > qapi-schema.json | 7 ++++--- > qemu-char.c | 45 ++++++++++++++++++++++++++++++++------------- > util/qemu-sockets.c | 9 ++++----- > 4 files changed, 41 insertions(+), 22 deletions(-) >
I think 11/13 doesn't qualify for qemu-trivial. In any case, it does seem correct, like the rest. With the commit message fixups from Michael: series Reviewed-by: Laszlo Ersek <ler...@redhat.com> Thanks Laszlo