[Qemu-devel] [PATCH 01/26] ohci: use realize for ohci

2013-06-22 Thread Hu Tao
Cc: Gerd Hoffmann Signed-off-by: Hu Tao --- hw/usb/hcd-ohci.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c index 51241cd..79ef41b 100644 --- a/hw/usb/hcd-ohci.c +++ b/hw/usb/hcd-ohci.c @@ -1876,17 +1876,16 @@ typedef s

[Qemu-devel] [PATCH 03/26] i440fx-pcihost: use realize for i440fx-pcihost

2013-06-22 Thread Hu Tao
Cc: Anthony Liguori Cc: "Andreas Färber" Cc: "Michael S. Tsirkin" Cc: Laszlo Ersek Cc: Paolo Bonzini Signed-off-by: Hu Tao --- hw/pci-host/piix.c | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c index f9e6

[Qemu-devel] [PATCH 00/26] use realizefn for SysBusDevice, part 1

2013-06-22 Thread Hu Tao
This series updates part of devices inheriting from SysbusDevice to use DeviceState::realize, and QOM'ify them. These devices are default to x86_64-softmmu. I'm planning to make patches in the same manner, that is, each series is for devices default to each target. After all devices are converted

[Qemu-devel] [PATCH 15/26] fwcfg: use realize for fwcfg

2013-06-22 Thread Hu Tao
Cc: Markus Armbruster Cc: Paolo Bonzini Cc: Blue Swirl Cc: Anthony Liguori Cc: "Andreas Färber" Signed-off-by: Hu Tao --- hw/nvram/fw_cfg.c | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c index 3c255ce..f5

[Qemu-devel] [PATCH 02/26] ohci: QOM'ify some more

2013-06-22 Thread Hu Tao
Introduce type constant and avoid DO_UPCAST(). Cc: Gerd Hoffmann Signed-off-by: Hu Tao --- hw/usb/hcd-ohci.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c index 79ef41b..2025593 100644 --- a/hw/usb/hcd-ohci.c +++ b/hw/

[Qemu-devel] [PATCH 17/26] scsi esp: use realize for scsi esp

2013-06-22 Thread Hu Tao
Cc: Paolo Bonzini Signed-off-by: Hu Tao --- hw/scsi/esp.c | 32 +--- 1 file changed, 21 insertions(+), 11 deletions(-) diff --git a/hw/scsi/esp.c b/hw/scsi/esp.c index 0c81a50..0207dba 100644 --- a/hw/scsi/esp.c +++ b/hw/scsi/esp.c @@ -666,23 +666,33 @@ static void s

[Qemu-devel] [PATCH 10/26] pflash-cfi01: QOM'ify some more

2013-06-22 Thread Hu Tao
Introduce type constant and avoid DO_UPCAST(). Cc: Kevin Wolf Cc: Stefan Hajnoczi Signed-off-by: Hu Tao --- hw/block/pflash_cfi01.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/block/pflash_cfi01.c b/hw/block/pflash_cfi01.c index aa04a2e..cc27f92 1006

[Qemu-devel] [PATCH 09/26] pflash_cfi01: use realize for pflash_cfi01

2013-06-22 Thread Hu Tao
Cc: Kevin Wolf Cc: Stefan Hajnoczi Signed-off-by: Hu Tao --- hw/block/pflash_cfi01.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/hw/block/pflash_cfi01.c b/hw/block/pflash_cfi01.c index 63d7c99..aa04a2e 100644 --- a/hw/block/pflash_cfi01.c +++ b/hw/block/pf

[Qemu-devel] [PATCH 13/26] ahci: use realize for ahci

2013-06-22 Thread Hu Tao
Cc: Kevin Wolf Cc: Paolo Bonzini Cc: Jason Baron Cc: Anthony Liguori Cc: David Gibson Signed-off-by: Hu Tao --- hw/ide/ahci.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index eab6096..c2e4b8c 100644 --- a/hw/ide/ahci.c +++

[Qemu-devel] [PATCH 04/26] i440fx: use type-safe cast instead of directly access of parent dev

2013-06-22 Thread Hu Tao
Cc: Anthony Liguori Cc: "Andreas Färber" Cc: "Michael S. Tsirkin" Cc: Laszlo Ersek Cc: Paolo Bonzini Signed-off-by: Hu Tao --- hw/pci-host/piix.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c index 801341a..e2437df 100

[Qemu-devel] [PATCH 06/26] q35: use type-safe cast instead of directly access of parent dev

2013-06-22 Thread Hu Tao
And remove variables if possible. Cc: "Michael S. Tsirkin" Cc: Paolo Bonzini Cc: Alex Williamson Cc: Anthony Liguori Cc: Jason Baron Signed-off-by: Hu Tao --- hw/pci-host/q35.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/hw/pci-host/q35.c b/hw/pci-

[Qemu-devel] [PATCH 05/26] q35: use realize for q35 host

2013-06-22 Thread Hu Tao
Cc: "Michael S. Tsirkin" Cc: Paolo Bonzini Cc: Alex Williamson Cc: Isaku Yamahata Cc: Jason Baron Signed-off-by: Hu Tao --- hw/pci-host/q35.c | 45 ++--- 1 file changed, 22 insertions(+), 23 deletions(-) diff --git a/hw/pci-host/q35.c b/hw/pci-host/q3

[Qemu-devel] [PATCH 21/26] kvmclock: use realize for kvmclock

2013-06-22 Thread Hu Tao
Cc: qemu-devel@nongnu.org Cc: "Andreas Färber" Cc: Paolo Bonzini Cc: Anthony Liguori Cc: Igor Mammedov Cc: Eduardo Habkost Signed-off-by: Hu Tao --- hw/i386/kvm/clock.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/hw/i386/kvm/clock.c b/hw/i386/kvm/clock.c index

[Qemu-devel] [PATCH 26/26] ehci: use realize for ehci

2013-06-22 Thread Hu Tao
Cc: Gerd Hoffmann Signed-off-by: Hu Tao --- hw/usb/hcd-ehci-sysbus.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/hw/usb/hcd-ehci-sysbus.c b/hw/usb/hcd-ehci-sysbus.c index b68a66a..8cb594d 100644 --- a/hw/usb/hcd-ehci-sysbus.c +++ b/hw/usb/hcd-ehci-sysbus.c @@

[Qemu-devel] [PATCH 16/26] fwcfg: QOM'ify some more

2013-06-22 Thread Hu Tao
Use type constant if possible and avoid DO_UPCAST(). Cc: Markus Armbruster Cc: Blue Swirl Cc: Paolo Bonzini Cc: Anthony Liguori Cc: "Andreas Färber" Signed-off-by: Hu Tao --- hw/nvram/fw_cfg.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/nvram/fw_cfg

[Qemu-devel] [PATCH 11/26] pflash_cfi02: use realize for pflash_cfi02

2013-06-22 Thread Hu Tao
Cc: Kevin Wolf Cc: Stefan Hajnoczi Signed-off-by: Hu Tao --- hw/block/pflash_cfi02.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/hw/block/pflash_cfi02.c b/hw/block/pflash_cfi02.c index 5f25246..45db415 100644 --- a/hw/block/pflash_cfi02.c +++ b/hw/block

[Qemu-devel] [PATCH 19/26] hpet: use realize for hpet

2013-06-22 Thread Hu Tao
Cc: Paolo Bonzini Cc: Anthony Liguori Cc: "Andreas Färber" Cc: Avi Kivity Signed-off-by: Hu Tao --- hw/timer/hpet.c | 29 + 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/hw/timer/hpet.c b/hw/timer/hpet.c index 95dd01d..95aad3a 100644 --- a/hw/time

[Qemu-devel] [PATCH 25/26] isa bus: use realize for isa bus

2013-06-22 Thread Hu Tao
Cc: "Andreas Färber" Cc: Paolo Bonzini Cc: Anthony Liguori Cc: Avi Kivity Cc: Jim Meyering Signed-off-by: Hu Tao --- hw/isa/isa-bus.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/hw/isa/isa-bus.c b/hw/isa/isa-bus.c index 136d17e..287f941 100644 --- a/hw/isa/isa-

[Qemu-devel] [PATCH 18/26] scsi esp: QOM'ify some more

2013-06-22 Thread Hu Tao
Introduce type constant and avoid DO_UPCAST(). Cc: Paolo Bonzini Signed-off-by: Hu Tao --- hw/scsi/esp.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/hw/scsi/esp.c b/hw/scsi/esp.c index 0207dba..aea2c94 100644 --- a/hw/scsi/esp.c +++ b/hw/scsi/esp.c @@

[Qemu-devel] [PATCH 08/26] fdc: QOM'ify some more

2013-06-22 Thread Hu Tao
Introduce type constant and avoid DO_UPCAST(). Cc: Kevin Wolf Cc: Stefan Hajnoczi Signed-off-by: Hu Tao --- hw/block/fdc.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/hw/block/fdc.c b/hw/block/fdc.c index 8b8f60e..4f5f8a8 100644 --- a/hw/b

[Qemu-devel] [PATCH 20/26] hpet: QOM'ify some more

2013-06-22 Thread Hu Tao
Introduce type constant, avoid DO_UPCAST() and FROM_SYSBUS(). Cc: Paolo Bonzini Cc: Anthony Liguori Cc: "Andreas Färber" Cc: Avi Kivity Signed-off-by: Hu Tao --- hw/timer/hpet.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/hw/timer/hpet.c b/hw/timer

[Qemu-devel] [PATCH 23/26] kvmvapic realize

2013-06-22 Thread Hu Tao
Cc: qemu-devel@nongnu.org Cc: "Andreas Färber" Cc: Paolo Bonzini Cc: Anthony Liguori Cc: Blue Swirl Cc: Jan Kiszka Signed-off-by: Hu Tao --- hw/i386/kvmvapic.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/hw/i386/kvmvapic.c b/hw/i386/kvmvapic.c index 65548

[Qemu-devel] [PATCH 14/26] ahci: QOM'ify some more

2013-06-22 Thread Hu Tao
Introduce type constant and avoid DO_UPCAST(). Cc: Kevin Wolf Cc: Paolo Bonzini Cc: Jason Baron Cc: Anthony Liguori Cc: "Andreas Färber" Signed-off-by: Hu Tao --- hw/ide/ahci.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c inde

[Qemu-devel] [PATCH 22/26] kvmclock: QOM'ify some more

2013-06-22 Thread Hu Tao
Introduce type constant and avoid DO_UPCAST(). Cc: qemu-devel@nongnu.org Cc: "Andreas Färber" Cc: Paolo Bonzini Cc: Eduardo Habkost Cc: Igor Mammedov Cc: Anthony Liguori Signed-off-by: Hu Tao --- hw/i386/kvm/clock.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --g

[Qemu-devel] [PATCH 24/26] ioapic: use realize for ioapic

2013-06-22 Thread Hu Tao
Cc: Paolo Bonzini Cc: "Andreas Färber" Cc: Anthony Liguori Cc: Igor Mammedov Signed-off-by: Hu Tao --- hw/intc/ioapic_common.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/hw/intc/ioapic_common.c b/hw/intc/ioapic_common.c index 5c5bb3c..6077024 100644 --- a/h

[Qemu-devel] [PATCH 12/26] pflash-cfi02: QOM'ify some more

2013-06-22 Thread Hu Tao
Introduce type constant and avoid DO_UPCAST(). Cc: Kevin Wolf Cc: Stefan Hajnoczi Signed-off-by: Hu Tao --- hw/block/pflash_cfi02.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/block/pflash_cfi02.c b/hw/block/pflash_cfi02.c index 45db415..412de7f 1006

[Qemu-devel] [PATCH 07/26] fdc: use realize for fdc.

2013-06-22 Thread Hu Tao
Cc: Kevin Wolf Cc: Stefan Hajnoczi Signed-off-by: Hu Tao --- hw/block/fdc.c | 60 ++ 1 file changed, 39 insertions(+), 21 deletions(-) diff --git a/hw/block/fdc.c b/hw/block/fdc.c index 930f191..8b8f60e 100644 --- a/hw/block/fdc.c +++ b/h

[Qemu-devel] [PULL 02/17] qemu-options: trivial fix for -mon args help

2013-06-22 Thread Michael Tokarev
It is the (implied sub)option name which is optional, not the value of that (sub)option, make it so in the help output. (Introduced by commit 22a0e04b9bb) Cc: Gerd Hoffmann Signed-off-by: Michael Tokarev --- qemu-options.hx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --gi

[Qemu-devel] [PULL 05/17] savevm: Fix potential memory leak

2013-06-22 Thread Michael Tokarev
From: Stefan Weil The leak was reported by cppcheck. Fix it by moving the g_malloc0 after the argument validity check. Signed-off-by: Stefan Weil Signed-off-by: Michael Tokarev --- savevm.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/savevm.c b/savevm.c index ff5e

[Qemu-devel] [PULL 03/17] qemu-img: Add missing GCC_FMT_ATTR

2013-06-22 Thread Michael Tokarev
From: Stefan Weil Signed-off-by: Stefan Weil Reviewed-by: Stefan Hajnoczi Signed-off-by: Michael Tokarev --- qemu-img.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-img.c b/qemu-img.c index 809b4f1..f8c97d3 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -128,7 +128

[Qemu-devel] [PULL 00/17] Trivial patches for 2013-06-22

2013-06-22 Thread Michael Tokarev
Hello. There are quite a few trivial patches this week again, now they're really trivial, nothing facy like previous week. I'm not including the chardev+socket fixes from Gerd for now, these are really nice but I had a few questions there. Hopefully next week. Please consider pulling. Thanks,

[Qemu-devel] [PULL 01/17] vl: reformat SDL ifdeffery a bit

2013-06-22 Thread Michael Tokarev
This reformats #ifdef..#endif and case statement a bit, to make it a bit shorter and matching other cases like that (no code changes). Signed-off-by: Michael Tokarev --- vl.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/vl.c b/vl.c index 767e020..0a8f056 100644 --- a/

[Qemu-devel] [PULL 04/17] kvm: Fix potential resource leak (missing fclose)

2013-06-22 Thread Michael Tokarev
From: Stefan Weil This leak was detected by cppcheck. Signed-off-by: Stefan Weil Signed-off-by: Michael Tokarev --- hw/i386/kvm/pci-assign.c |1 + 1 file changed, 1 insertion(+) diff --git a/hw/i386/kvm/pci-assign.c b/hw/i386/kvm/pci-assign.c index ff85590..1fb7ad4 100644 --- a/hw/i386/k

[Qemu-devel] [PULL 12/17] vnc: use booleans for vnc_connect, vnc_listen_read and vnc_display_add_client

2013-06-22 Thread Michael Tokarev
Some arguments to these functions are booleans - either by declaration, or by actual usage, but sometimes value of 0 or 1 is passed for a bool, and sometimes it is declared as int but a bool value, or true/false, is passed to it instead. Clean it up a bit. Cc: liguang Signed-off-by: Michael Toka

[Qemu-devel] [PULL 07/17] audio: Replace static functions in header file by macros, remove GCC_ATTR

2013-06-22 Thread Michael Tokarev
From: Stefan Weil Using macros instead of static functions for dolog and for ldebug simplifies the code and can also reduce the total code size. GCC_ATTR was only used in audio_int.h, so it is now unused and the definition can be removed from compiler.h. Signed-off-by: Stefan Weil Signed-off-b

[Qemu-devel] [PULL 17/17] configure: Add signed*signed check to [u]int128_t test

2013-06-22 Thread Michael Tokarev
From: Peter Maydell clang 3.3 with -fsanitize=undefined will fail to link code containing an int128_t * int128_t multiply (http://llvm.org/bugs/show_bug.cgi?id=16404) so add this to our configure test for whether [u]int128_t are usable. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderso

[Qemu-devel] [PULL 16/17] Makefile: pass include directives to dtc via CPPFLAGS, not CFLAGS

2013-06-22 Thread Michael Tokarev
From: Peter Maydell The dtc submodule's makefile expects -I include directives to be in CPPFLAGS, not CFLAGS. Getting this wrong meant that the include directive would not be applied when generating the dependency .d files. This in turn meant that we couldn't build libfdt when doing an out of tre

[Qemu-devel] [PULL 13/17] qemu-char: use bool in qemu_chr_open_socket and simplify code a bit

2013-06-22 Thread Michael Tokarev
From: liguang Local variables is_* should be bool by usage. While at it, simplify the logic/code a bit. Signed-off-by: liguang Signed-off-by: Michael Tokarev --- qemu-char.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/qemu-char.c b/qemu-char.c in

[Qemu-devel] [PULL 08/17] configure: Fix "ERROR: ERROR: " for missing/incompatible DTC

2013-06-22 Thread Michael Tokarev
From: Andreas Färber error_exit already prepends "ERROR: ", so no need to print it manually. Signed-off-by: Andreas Färber Reviewed-by: Peter Maydell Signed-off-by: Michael Tokarev --- configure |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure inde

[Qemu-devel] [PULL 06/17] libcacard: Fix cppcheck warning and remove unneeded code

2013-06-22 Thread Michael Tokarev
From: Stefan Weil The local function vcard_emul_alloc_arrays always returned PR_TRUE. Therefore cppcheck complained about code which handled the non-existent PR_FALSE case. Remove the function's return value and the dead code. Signed-off-by: Stefan Weil Signed-off-by: Michael Tokarev --- lib

[Qemu-devel] [PULL 10/17] qxl: Fix QXLRam initialisation.

2013-06-22 Thread Michael Tokarev
From: Anthony PERARD The qxl driver expect NULL for QXLRam.memory_configs, but this is never initialized. If memory is set to 0xc2c2.., it leads to a spice-critical error when trying to start qxl. Signed-off-by: Anthony PERARD Reviewed-by: Gerd Hoffmann Signed-off-by: Michael Tokarev --- hw

[Qemu-devel] [PULL 09/17] acl: acl_add can't insert before last list element, fix

2013-06-22 Thread Michael Tokarev
From: Markus Armbruster Watch this: $ upstream-qemu -nodefaults -S -vnc :0,acl,sasl -monitor stdio QEMU 1.5.50 monitor - type 'help' for more information (qemu) acl_add vnc.username drei allow acl: added rule at position 1 (qemu) acl_show vnc.username policy: deny 1:

[Qemu-devel] [PULL 14/17] sd: pass bool parameter for sd_init

2013-06-22 Thread Michael Tokarev
From: liguang Signed-off-by: liguang Signed-off-by: Michael Tokarev --- hw/sd/milkymist-memcard.c |2 +- hw/sd/omap_mmc.c |4 ++-- hw/sd/pl181.c |2 +- hw/sd/pxa2xx_mmci.c |2 +- hw/sd/sdhci.c |2 +- hw/sd/ssi-sd.c|2 +-

[Qemu-devel] [PULL 15/17] qapi: lack of two commas in dict

2013-06-22 Thread Michael Tokarev
From: Amos Kong Signed-off-by: Amos Kong Signed-off-by: Michael Tokarev --- qapi-schema.json |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index a80ee40..6cc07c2 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -391,7 +391

[Qemu-devel] [PULL 11/17] block/nand: Formatting sweep

2013-06-22 Thread Michael Tokarev
From: Peter Crosthwaite Make this code closer to passing checkpatch. Mostly missing braces, but a few rogue tabs in there as well. Cc: qemu-triv...@nongnu.org Signed-off-by: Peter Crosthwaite Signed-off-by: Michael Tokarev --- hw/block/nand.c | 33 ++--- 1 file

Re: [Qemu-devel] [PATCH V2] build: remove compile warning

2013-06-22 Thread Stefan Weil
Am 18.06.2013 12:13, schrieb Paolo Bonzini: > Il 07/06/2013 14:17, Markus Armbruster ha scritto: >>> diff --git a/util/iov.c b/util/iov.c >>> index cc6e837..b91cfb9 100644 >>> --- a/util/iov.c >>> +++ b/util/iov.c >>> @@ -146,7 +146,7 @@ ssize_t iov_send_recv(int sockfd, struct iovec *iov, >>> uns

Re: [Qemu-devel] [PATCH 26/26] ehci: use realize for ehci

2013-06-22 Thread Andreas Färber
Am 22.06.2013 10:50, schrieb Hu Tao: > Cc: Gerd Hoffmann > Signed-off-by: Hu Tao > --- > hw/usb/hcd-ehci-sysbus.c | 11 +-- > 1 file changed, 5 insertions(+), 6 deletions(-) I had already done this iirc, it should be in Gerd's USB queue, which I was waiting for to be merged to continue

Re: [Qemu-devel] Java volatile vs. C11 seq_cst (was Re: [PATCH v2 1/2] add a header file for atomic operations)

2013-06-22 Thread Torvald Riegel
On Thu, 2013-06-20 at 09:53 +0200, Paolo Bonzini wrote: > Il 19/06/2013 22:25, Torvald Riegel ha scritto: > > On Wed, 2013-06-19 at 17:14 +0200, Paolo Bonzini wrote: > >> (1) I don't care about relaxed RMW ops (loads/stores occur in hot paths, > >> but RMW shouldn't be that bad. I don't care if re

Re: [Qemu-devel] [PATCH v3] configure: Simplify alternate .text segment

2013-06-22 Thread Peter Maydell
On 22 June 2013 03:10, Richard Henderson wrote: > + ldflags="$ldflags $textseg_ldflags" > fi > > echo "LDFLAGS+=$ldflags" >> $config_target_mak Should we really be putting this in LDFLAGS? That seems likely to end up getting accidentally applied in places where we don't want it (helper binarie

[Qemu-devel] can we enable +x2apic by default ? is it safe ?

2013-06-22 Thread Alexandre DERUMIER
Hi, I would like to known if it's safe to enable +x2apic cpu flag by default, for any guest os (windows/linux/...), and for any cpu model ? (kvm32,kvm64,host,) Regards, Alexandre

[Qemu-devel] [Bug 1193564] [NEW] monitor: rename `screendump` command to `screenshot`

2013-06-22 Thread anatoly techtonik
Public bug reported: `screendump` is hard to memorize for occasional users. It is easier to remember `screenshot` name. ** Affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] Need to start with Qemu

2013-06-22 Thread Mohmaed Amer
Dear sir(s) My name is Mohamed Amer from Egypt, i am a computer engineer i am graduated from Cairo university, i am new to Qemu and need start give hands on it, can you support me with the source code structure and any guide (just guide) to any subject i need to read first before going on, i rea

[Qemu-devel] [Bug 1193564] Re: monitor: rename `screendump` command to `screenshot`

2013-06-22 Thread anatoly techtonik
It would also be nice if monitor appended extension automatically if not set. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1193564 Title: monitor: rename `screendump` command to `screenshot` Stat

[Qemu-devel] [Bug 1193555] [NEW] Add scale options to window menu

2013-06-22 Thread anatoly techtonik
Public bug reported: This is a workaround against bug #504368, which makes QEMU window text blurry if resized. This is a common and annoying problem: http://butnottoohard.blogspot.com/2010/01/qemukvm-windows-7-blurry-text.html http://unix.stackexchange.com/questions/60564/how-can-i-restore-defaul

Re: [Qemu-devel] QEMU Memory subsystem

2013-06-22 Thread Basim Baig
On Fri, Jun 21, 2013 at 12:16 PM, Lluís Vilanova wrote: > Basim Baig writes: > > > Hello, > > I am currently working on a project where I aim to log every memory > access made > > by a virtual machine running inside of QEMU (for analyzing kernel > behavior). My > > initial approach is to possibly

Re: [Qemu-devel] Need to start with Qemu

2013-06-22 Thread Basim Baig
These are some of the links that I found useful while reading about QEMU: Good overall source code analysis (as well as lots of links to look at - you can translate it to english in chrome): http://people.cs.nctu.edu.tw/~chenwj/dokuwiki/doku.php?id=qemu QEMU internals posts on Stefans Blog: http:/

[Qemu-devel] [PATCH 1/8] iscsi: add logical block provisioning information to iscsilun

2013-06-22 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block/iscsi.c | 47 +++ 1 file changed, 47 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index 0bbf0b1..a38a1bf 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -49,6 +49,11 @@ typedef struct IscsiLun {

[Qemu-devel] [PATCH 6/8] qemu-img: use bdrv_write_zeroes to write zeroes

2013-06-22 Thread Peter Lieven
Signed-off-by: Peter Lieven --- qemu-img.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 809b4f1..5aa53ab 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -1513,9 +1513,13 @@ static int img_convert(int argc, char **argv)

[Qemu-devel] [PATCH 0/8] iscsi/qemu-img/block-migration enhancements

2013-06-22 Thread Peter Lieven
this series adds logical block provisioning functions to the iscsi layer. it adds the ability to write sparse images to iscsi targets which support UNMAP and LBPRZ via qemu-img. additional block-migration is enhanced to support an encoding for zero blocks on the network and efficiently writing thos

[Qemu-devel] [PATCH 7/8] iscsi: assert that sectors are aligned to LUN blocksize

2013-06-22 Thread Peter Lieven
if the blocksize of an iSCSI LUN is bigger than the BDRV_SECTOR_SIZE it is possible that sector_num or nb_sectors are not correctly alligned. for now assert that there is no misalignment to avoid data corruption. Signed-off-by: Peter Lieven --- block/iscsi.c |7 +++ 1 file changed, 7 in

[Qemu-devel] [PATCH 3/8] iscsi: add bdrv_co_write_zeroes

2013-06-22 Thread Peter Lieven
write zeroes is emulated by unmap if the target supports unmapping an unmapped blocks read as zero. Signed-off-by: Peter Lieven --- block/iscsi.c | 63 + 1 file changed, 63 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index 9

[Qemu-devel] [PATCH 5/8] block/raw: add bdrv_co_write_zeroes

2013-06-22 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block/raw.c |8 1 file changed, 8 insertions(+) diff --git a/block/raw.c b/block/raw.c index ce10422..8c81de9 100644 --- a/block/raw.c +++ b/block/raw.c @@ -42,6 +42,13 @@ static int coroutine_fn raw_co_is_allocated(BlockDriverState *bs, return

[Qemu-devel] [PATCH 8/8] block-migration: efficiently encode zero blocks

2013-06-22 Thread Peter Lieven
this patch adds a efficient encoding for zero blocks by adding a new flag indiciating a block is completly zero. additionally bdrv_write_zeros() is used at the destination to efficiently write these zeroes. if the driver supports it this avoids blindly allocating all sectors consumed by zero block

[Qemu-devel] [PATCH 2/8] iscsi: add bdrv_co_is_allocated

2013-06-22 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block/iscsi.c | 103 + 1 file changed, 103 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index a38a1bf..98be71e 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -56,6 +56,15 @@ typedef struct Isc

[Qemu-devel] [PATCH 4/8] block: add bdrv_write_zeroes()

2013-06-22 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block.c | 27 +++ include/block/block.h |2 ++ 2 files changed, 21 insertions(+), 8 deletions(-) diff --git a/block.c b/block.c index b88ad2f..e32b8cf 100644 --- a/block.c +++ b/block.c @@ -2163,6 +2163,7 @@ typedef stru

[Qemu-devel] [Bug 1193628] [NEW] Undefined References

2013-06-22 Thread jean-christophe manciot
Public bug reported: I've been able to make qemu on ubuntu 13.04 for all last releases: 1.4.0 -> 1.5.0 Unfortunately, when I launch one of them with a Cisco ASA, it crashes inside GNS3 (latest release) for Ubuntu. The top GNS3 developer told me they experienced similar results and advised me to

[Qemu-devel] [PATCH] Switch the roles of jmp_next[0] and jmp_next[1].

2013-06-22 Thread Zhihui Zhang
This way, jmp_next[0] means "taken" for both conditional jumps AND unconditional jumps. Currently, it has opposite meanings for the two cases. Signed-off-by: Zhihui Zhang --- target-i386/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target-i386/translate.c

[Qemu-devel] [Bug 1193628] Re: Undefined References

2013-06-22 Thread Peter Maydell
As you note, 1.1 is now pretty old; you will be much better off in the long run investigating why your guest OS doesn't work under current QEMU. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1193628

[Qemu-devel] [PATCH] PPC: Add clock-frequency export for Mac machines

2013-06-22 Thread Alexander Graf
Support in fwcfg has been around for exposure of the clock-frequency CPU property. OpenBIOS reads it, we just never exposed it. Since Mac OS X is very picky about its clock frequency values, let's just take a known good value and always expose that. Reported-by: Mark Cave-Ayland Signed-off-by: A

Re: [Qemu-devel] [PATCH] Switch the roles of jmp_next[0] and jmp_next[1].

2013-06-22 Thread Peter Maydell
On 22 June 2013 17:10, Zhihui Zhang wrote: > This way, jmp_next[0] means "taken" for both conditional jumps AND > unconditional jumps. > Currently, it has opposite meanings for the two cases. This commit message is missing a rationale: do you want to do this because: * it fixes a bug? (if so, w

[Qemu-devel] [PATCH v2] PPC: Add clock-frequency export for Mac machines

2013-06-22 Thread Alexander Graf
Support in fwcfg has been around for exposure of the clock-frequency CPU property. OpenBIOS reads it, we just never exposed it. Since Mac OS X is very picky about its clock frequency values, let's just take a known good value and always expose that. Reported-by: Mark Cave-Ayland Signed-off-by: A

[Qemu-devel] [Bug 1193628] Re: Undefined References

2013-06-22 Thread Michael Tokarev
This is a change in glibc. Since version 2.17, clock_gettime() and friends were moved from -lrt to the main libc, so for linking with clock_gettime(), -lrt isn't needed anymore. However, (old) qemu configure only checked clock_gettime(), and used other functions like timer_create() &Co above. Th