Re: [Qemu-devel] copy&paste error in serial.c causes a crash when attempting to read from UART (if there is no data to be read)

2013-06-17 Thread Paolo Bonzini
Il 17/06/2013 02:57, Andreas Färber ha scritto: >> > From 032bdc94c6369aa7b578182cdad8038ebb2b8cd1 Mon Sep 17 00:00:00 2001 >> > From: Vladimir Senkov mailto:han...@gmail.com>> >> > Date: Sun, 16 Jun 2013 20:30:52 -0400 >> > Subject: [PATCH] fixed a copy&paste error in serial.c >> > >> > Signed-of

Re: [Qemu-devel] [PATCH v2 0/2] make AioContext's bh re-entrant

2013-06-17 Thread Paolo Bonzini
Il 16/06/2013 13:21, Liu Ping Fan ha scritto: > When trying out of QBL, we badly require more fine defined barrier and atomic > ops, so > I repost Paolo's atomic patch which fetched github.com/bonzini/qemu.git rcu CCing block maintainers. Almost Reviewed-by: Paolo Bonzini You're still not docu

[Qemu-devel] [PATCH 0/5] Initial Blackfin support (linux-user only)

2013-06-17 Thread Mike Frysinger
I've cleaned up the code and removed all the debugging bits. This passes a good number of tests (both the ones included here as well as the ones included with binutils/gcc/etc...), and as long as you stay away from the DSP related insns, your experience should be pretty good. If you do need DSP i

Re: [Qemu-devel] [PATCH RFC 1/8] ui/input: Clean up QEMUPutMouseEntry struct

2013-06-17 Thread Gerd Hoffmann
On 06/16/13 05:39, Andreas Färber wrote: > Shorten field names to not duplicate struct name. Nice. Reviewed-by: Gerd Hoffmann cheers, Gerd

[Qemu-devel] [PATCH 3/5] Blackfin: add linux-user support

2013-06-17 Thread Mike Frysinger
Signed-off-by: Mike Frysinger --- default-configs/bfin-linux-user.mak | 1 + linux-user/bfin/syscall.h | 59 ++ linux-user/bfin/syscall_nr.h| 389 linux-user/bfin/target_flat.h | 92 + linux-user/bfin/target_sigcontext.h

[Qemu-devel] [PATCH 5/5] linux-user: add support for Blackfin syscalls

2013-06-17 Thread Mike Frysinger
The Blackfin arch supports a simple sram allocator for userspace, as well as a DMA memcpy function to access the sram. Signed-off-by: Mike Frysinger --- linux-user/strace.list | 9 ++ linux-user/syscall.c | 74 ++ 2 files changed, 83 inserti

[Qemu-devel] [PATCH 4/5] Blackfin: add test suite

2013-06-17 Thread Mike Frysinger
To run it, simply add the bfin-elf compiler to your PATH and do: make -C tests/tcg/bfin Signed-off-by: Mike Frysinger --- Deleted test content due to size (~2 MiB). It's all just Blackfin assembly at any rate. Code can be found here: git://sources.blackfin.uclinux.org/git/users/vapier/q

Re: [Qemu-devel] [PATCH RFC 0/8] monitor: Fix mouse_button and improve mouse_move commands

2013-06-17 Thread Gerd Hoffmann
Hi, > My solution is to obtain position and buttons state from where the VMState is: > I clean up the mouse event handler registration code a bit and extend it: > * one mandatory callback to obtain mouse button state and > * one optional callback to obtain absolute position state from backends.

Re: [Qemu-devel] [RFC] sanitize memory on system reset

2013-06-17 Thread Peter Lieven
Am 14.06.2013 15:43, schrieb Paolo Bonzini: > Il 14/06/2013 05:44, Alexander Graf ha scritto: >> Legacy 286 protected mode to real mode switching also happens through >> the CPU reset PIN, so there certainly is a need to distinguish. > That's a separate thing because devices aren't reset at all---n

Re: [Qemu-devel] copy&paste error in serial.c causes a crash when attempting to read from UART (if there is no data to be read)

2013-06-17 Thread Andreas Färber
Am 17.06.2013 09:03, schrieb Paolo Bonzini: > Il 17/06/2013 02:57, Andreas Färber ha scritto: From 032bdc94c6369aa7b578182cdad8038ebb2b8cd1 Mon Sep 17 00:00:00 2001 From: Vladimir Senkov mailto:han...@gmail.com>> Date: Sun, 16 Jun 2013 20:30:52 -0400 Subject: [PATCH] fixed a cop

Re: [Qemu-devel] [PATCH RFC 2/8] ui/input: Simplify kbd_mouse_event()

2013-06-17 Thread Gerd Hoffmann
On 06/16/13 05:39, Andreas Färber wrote: > Now that the field names are bearable, there's no compelling reason to > use local variables for the fields. > > Unify the four callback invokations through variables for the rotated > coordinates instead. Reviewed-by: Gerd Hoffmann cheers, Gerd

Re: [Qemu-devel] [PATCH RFC 4/8] ui/input: Introduce MouseOps for qemu_add_mouse_event_handler()

2013-06-17 Thread Gerd Hoffmann
On 06/16/13 05:40, Andreas Färber wrote: > This allows to add callbacks to mouse event handlers without constantly > touching all callers of qemu_add_mouse_event_handler() or > qemu_add_mouse_event_handler() itself. I think you can stick other static information into the Ops too: name + absolute.

Re: [Qemu-devel] copy&paste error in serial.c causes a crash when attempting to read from UART (if there is no data to be read)

2013-06-17 Thread Peter Crosthwaite
Hi Andreas, On Mon, Jun 17, 2013 at 10:57 AM, Andreas Färber wrote: > Am 17.06.2013 02:43, schrieb Vladimir Senkov: >> From 032bdc94c6369aa7b578182cdad8038ebb2b8cd1 Mon Sep 17 00:00:00 2001 >> From: Vladimir Senkov mailto:han...@gmail.com>> >> Date: Sun, 16 Jun 2013 20:30:52 -0400 >> Subject: [PA

Re: [Qemu-devel] copy&paste error in serial.c causes a crash when attempting to read from UART (if there is no data to be read)

2013-06-17 Thread Peter Crosthwaite
On Mon, Jun 17, 2013 at 5:16 PM, Andreas Färber wrote: > Am 17.06.2013 09:03, schrieb Paolo Bonzini: >> Il 17/06/2013 02:57, Andreas Färber ha scritto: > From 032bdc94c6369aa7b578182cdad8038ebb2b8cd1 Mon Sep 17 00:00:00 2001 > From: Vladimir Senkov mailto:han...@gmail.com>> > Date: Sun

Re: [Qemu-devel] [PATCH v2 0/8] memory: remove old_portio usage

2013-06-17 Thread Paolo Bonzini
Il 16/06/2013 20:20, Hervé Poussineau ha scritto: > Hervé Poussineau a écrit : >> These proposed patches aim at removing the .old_portio member of >> MemoryRegionOps structure, and replacing their usage by .read/.write >> handlers. > > Ping. Jan has patches that do something similar, so I was hop

Re: [Qemu-devel] copy&paste error in serial.c causes a crash when attempting to read from UART (if there is no data to be read)

2013-06-17 Thread Peter Crosthwaite
Patch is good, I think the issue is just in the sending as flagged by Andreas. On Mon, Jun 17, 2013 at 10:43 AM, Vladimir Senkov wrote: > From 032bdc94c6369aa7b578182cdad8038ebb2b8cd1 Mon Sep 17 00:00:00 2001 > From: Vladimir Senkov > Date: Sun, 16 Jun 2013 20:30:52 -0400 > Subject: [PATCH] fixe

Re: [Qemu-devel] [SeaBIOS] solaris x86 in qemu? [bisected]

2013-06-17 Thread Laszlo Ersek
On 06/16/13 17:30, Kevin O'Connor wrote: > Unfortunately not. There was nothing special about the DSDT changes > in that commit. Likely the AML interpretter in Solaris is quirky and > one of the clauses in that commit (or some arrangement of clauses) is > confusing Solaris. This is one of the u

Re: [Qemu-devel] [PATCH v2 0/8] memory: remove old_portio usage

2013-06-17 Thread Jan Kiszka
On 2013-06-17 09:32, Paolo Bonzini wrote: > Il 16/06/2013 20:20, Hervé Poussineau ha scritto: >> Hervé Poussineau a écrit : >>> These proposed patches aim at removing the .old_portio member of >>> MemoryRegionOps structure, and replacing their usage by .read/.write >>> handlers. >> >> Ping. > > Ja

[Qemu-devel] [PULL trivial/urgent 1/2] vl: always define no_frame

2013-06-17 Thread Michael Tokarev
Commit 047d4e151dd46 "Unbreak -no-quit for GTK, validate SDL options" broke build of qemu without sdl, by referencing `no_frame' variable which is defined inside #if SDL block. Fix that by defining that variable unconditionally. This is a better fix for the build issue introduced by that patch th

[Qemu-devel] [PULL trivial/urgent 2/2] fixed a copy&paste error in serial.c

2013-06-17 Thread Michael Tokarev
From: Vladimir Senkov Copy&paste error in serial.c causes a crash when attempting to read from UART (if there is no data to be read) Signed-off-by: Vladimir Senkov Reviewed-by: Peter Crosthwaite Signed-off-by: Michael Tokarev --- hw/char/serial.c |2 +- 1 file changed, 1 insertion(+), 1

[Qemu-devel] [PULL trivial/urgent 0/2] trivial-patches out-of-order pull request for 2013-06-17

2013-06-17 Thread Michael Tokarev
There were two bugs introduced in last changes which went through trivial patches queue last week. I already sent you two versions of a fix for one issue (compile breakage with --disable-sdl), and there's another one, serial crash. Sending as a pull request too, these should be applied ASAP as pe

Re: [Qemu-devel] [PATCH 1/2] pvpanic: initialization cleanup

2013-06-17 Thread Laszlo Ersek
On 06/16/13 22:59, Michael S. Tsirkin wrote: > Avoid use of static variables: PC systems initialize pvpanic device > through pvpanic_init, so we can simply create the fw_cfg file at that > point. Others don't use fw_cfg at all. This also makes it possible to > assert if fw_cfg is not there rather

Re: [Qemu-devel] [PULL trivial/urgent 2/2] fixed a copy&paste error in serial.c

2013-06-17 Thread Andreas Färber
Am 17.06.2013 09:44, schrieb Michael Tokarev: > From: Vladimir Senkov > > Copy&paste error in serial.c causes a crash when attempting > to read from UART (if there is no data to be read) > > Signed-off-by: Vladimir Senkov > Reviewed-by: Peter Crosthwaite > Signed-off-by: Michael Tokarev Any

Re: [Qemu-devel] [PATCH 1/2] piix: use type-safe cast instead of directly access of parent dev

2013-06-17 Thread Peter Crosthwaite
Hi Hu, On Mon, Jun 17, 2013 at 1:27 PM, Hu Tao wrote: > Andreas, > > On Mon, Jun 17, 2013 at 09:56:47AM +0800, Hu Tao wrote: >> On Fri, Jun 14, 2013 at 11:20:55AM +0200, Andreas Färber wrote: >> > Hi, >> > >> > Am 14.06.2013 08:49, schrieb Hu Tao: >> > > Signed-off-by: Hu Tao >> > > --- >> > >

Re: [Qemu-devel] [PATCH 1/2] piix: use type-safe cast instead of directly access of parent dev

2013-06-17 Thread Hu Tao
On Mon, Jun 17, 2013 at 06:14:47PM +1000, Peter Crosthwaite wrote: > Hi Hu, > > On Mon, Jun 17, 2013 at 1:27 PM, Hu Tao wrote: > > Andreas, > > > > On Mon, Jun 17, 2013 at 09:56:47AM +0800, Hu Tao wrote: > >> On Fri, Jun 14, 2013 at 11:20:55AM +0200, Andreas Färber wrote: > >> > Hi, > >> > > >> >

Re: [Qemu-devel] [PATCH] vnc: lift modifier keys on client disconnect.

2013-06-17 Thread Gerd Hoffmann
On 06/17/13 10:10, Peter Lieven wrote: > Hi Gerd, > > just looking at your patch. It works fine so far, but I am curious how > to handle the lock keys? I have the problem that if I press caps lock > and then create a new vnc session with exclusive access (from another > terminal), the caps lock is

Re: [Qemu-devel] [Qemu-trivial] [PULL trivial/urgent 2/2] fixed a copy&paste error in serial.c

2013-06-17 Thread Michael Tokarev
17.06.2013 12:00, Andreas Färber wrote: > Any chance to get the subject improved before the pull is accepted? > E.g., "serial: Fix a copy&paste error" or "char/serial: ..." Fixed in the git tree -- http://git.corpit.ru/?p=qemu.git;a=shortlog;h=refs/heads/trivial-patches Thanks! /mjt

Re: [Qemu-devel] [PATCH 1/2] pvpanic: initialization cleanup

2013-06-17 Thread Michael S. Tsirkin
On Mon, Jun 17, 2013 at 09:56:56AM +0200, Laszlo Ersek wrote: > On 06/16/13 22:59, Michael S. Tsirkin wrote: > > Avoid use of static variables: PC systems initialize pvpanic device > > through pvpanic_init, so we can simply create the fw_cfg file at that > > point. Others don't use fw_cfg at all.

Re: [Qemu-devel] [PATCH] make screendump an async command

2013-06-17 Thread Alon Levy
On Mon, 2013-06-17 at 08:06 +0200, Gerd Hoffmann wrote: > Hi, > > > Why is QXL unable to do a synchronous screendump? > > Lazy rendering. By default spice-server doesn't render anything, it > just sends over all drawing ops to the client who does the actual > rendering for the user. > > qemu

Re: [Qemu-devel] [PATCH 1/2] pvpanic: initialization cleanup

2013-06-17 Thread Laszlo Ersek
On 06/17/13 11:19, Michael S. Tsirkin wrote: > On Mon, Jun 17, 2013 at 09:56:56AM +0200, Laszlo Ersek wrote: >> On 06/16/13 22:59, Michael S. Tsirkin wrote: >>> Avoid use of static variables: PC systems initialize pvpanic device >>> through pvpanic_init, so we can simply create the fw_cfg file at t

Re: [Qemu-devel] [PATCH v2 2/2] block: move the bdrv_dev_change_media_cb()

2013-06-17 Thread Pavel Hrdina
On 5.6.2013 15:23, Stefan Hajnoczi wrote: On Wed, May 29, 2013 at 06:18:19PM +0200, Pavel Hrdina wrote: @@ -1071,14 +1072,18 @@ static void qmp_bdrv_open_encrypted(BlockDriverState *bs, const char *filename, if (password) { if (bdrv_set_key(bs, password) < 0) {

Re: [Qemu-devel] [PATCH 1/2] pvpanic: initialization cleanup

2013-06-17 Thread Michael S. Tsirkin
On Mon, Jun 17, 2013 at 11:35:00AM +0200, Laszlo Ersek wrote: > On 06/17/13 11:19, Michael S. Tsirkin wrote: > > On Mon, Jun 17, 2013 at 09:56:56AM +0200, Laszlo Ersek wrote: > >> On 06/16/13 22:59, Michael S. Tsirkin wrote: > >>> Avoid use of static variables: PC systems initialize pvpanic device

Re: [Qemu-devel] [PATCH 1/2] pvpanic: initialization cleanup

2013-06-17 Thread Laszlo Ersek
On 06/17/13 11:57, Michael S. Tsirkin wrote: > On Mon, Jun 17, 2013 at 11:35:00AM +0200, Laszlo Ersek wrote: >> On 06/17/13 11:19, Michael S. Tsirkin wrote: >>> On Mon, Jun 17, 2013 at 09:56:56AM +0200, Laszlo Ersek wrote: On 06/16/13 22:59, Michael S. Tsirkin wrote: > Avoid use of static

[Qemu-devel] [PATCH v2] curl: refuse to open URL from HTTP server without range support

2013-06-17 Thread Fam Zheng
CURL driver requests partial data from server on guest IO req. For HTTP and HTTPS, it uses "Range: ***" in requests, and this will not work if server not accepting range. This patch does this check when open. * Removed curl_size_cb, which is not used: On one hand it's registered to libcurl as

Re: [Qemu-devel] [PATCH v2] curl: refuse to open URL from HTTP server without range support

2013-06-17 Thread Richard W.M. Jones
On Mon, Jun 17, 2013 at 06:09:23PM +0800, Fam Zheng wrote: > +if (real_size >= strlen(accept_len) What's accept_len? This patch gives me a couple of compile errors: block/curl.c: In function ‘curl_header_cb’: block/curl.c:120:9: error: ‘real_size’ undeclared (first use in this function) bloc

Re: [Qemu-devel] [PATCH v2] curl: refuse to open URL from HTTP server without range support

2013-06-17 Thread Fam Zheng
On Mon, 06/17 11:54, Richard W.M. Jones wrote: > On Mon, Jun 17, 2013 at 06:09:23PM +0800, Fam Zheng wrote: > > +if (real_size >= strlen(accept_len) > > What's accept_len? This patch gives me a couple of compile errors: > Oops, a copy&paste mistake. I meant this: +if (realsize >= strlen

Re: [Qemu-devel] [PATCH] vnc: lift modifier keys on client disconnect.

2013-06-17 Thread Peter Lieven
Am 17.06.2013 10:49, schrieb Gerd Hoffmann: > On 06/17/13 10:10, Peter Lieven wrote: >> Hi Gerd, >> >> just looking at your patch. It works fine so far, but I am curious how >> to handle the lock keys? I have the problem that if I press caps lock >> and then create a new vnc session with exclusive

Re: [Qemu-devel] [PATCH V3] build: remove compile warning

2013-06-17 Thread Stefan Hajnoczi
On Fri, Jun 14, 2013 at 07:53:00PM +0800, Wenchao Xia wrote: > This patch simply remove "variable may be used uninitialized" warning. > > Signed-off-by: Wenchao Xia > --- > V2: Address Stefan and Peter's comments, use 0 in send_msg() instead of > initialize mhHeader. > V3: Address Markus's commen

Re: [Qemu-devel] [PATCH v2 0/6] Some -smbios work

2013-06-17 Thread Markus Armbruster
Would this make sense for -stable? Impact is modest: fix a rather obscure feature of x86 targets on bigendian hosts, and improve error messages around it). On the other hand, the patches look pretty safe to me. Markus Armbruster writes: > Better error messages, a bit of code cleanup, and a big

Re: [Qemu-devel] [PATCH] [slirp] fix -net user checks by reordering checks

2013-06-17 Thread Bas van Sisseren
On 04/06/13 14:26, Stefan Hajnoczi wrote: > On Mon, Jun 03, 2013 at 03:11:49PM +0200, Bas van Sisseren wrote: >> reorder slirp config options. first check the dns-server-address, >> then check the first-dhcp-address. the original code was comparing >> the first-dhcp-address with the default dns-ser

Re: [Qemu-devel] [PATCH] vnc: lift modifier keys on client disconnect.

2013-06-17 Thread Gerd Hoffmann
On 06/17/13 13:05, Peter Lieven wrote: > Am 17.06.2013 10:49, schrieb Gerd Hoffmann: >> On 06/17/13 10:10, Peter Lieven wrote: >>> Hi Gerd, >>> >>> just looking at your patch. It works fine so far, but I am curious how >>> to handle the lock keys? I have the problem that if I press caps lock >>> an

Re: [Qemu-devel] [PATCH v2] curl: refuse to open URL from HTTP server without range support

2013-06-17 Thread Richard W.M. Jones
On Mon, Jun 17, 2013 at 07:02:00PM +0800, Fam Zheng wrote: > On Mon, 06/17 11:54, Richard W.M. Jones wrote: > > On Mon, Jun 17, 2013 at 06:09:23PM +0800, Fam Zheng wrote: > > > +if (real_size >= strlen(accept_len) > > > > What's accept_len? This patch gives me a couple of compile errors: > >

[Qemu-devel] [PATCH 0/2] ipl related fixes

2013-06-17 Thread Christian Borntraeger
Alex, here are two fixes for the ccw ipl. The first fix deals with a bug that creeped in when merging with the refactoring work, the other fix allows booting from a subchannel set > 0. I will let you do the binary of the bios code yourself. Christian Borntraeger (1): s390/ipl: Fix boot order D

[Qemu-devel] [PATCH 1/2] s390/ipl: Fix boot order

2013-06-17 Thread Christian Borntraeger
The latest ipl code adoptions collided with some of the virtio refactoring rework. This resulted in always booting the first disk. Lets fix booting from a given ID. The new code also checks for command lines without bootindex to avoid random behaviour when accessing dev_st (==0). Signed-off-by: Ch

[Qemu-devel] [PATCH 2/2] s390/IPL: Allow boot from other ssid than 0

2013-06-17 Thread Christian Borntraeger
From: Dominik Dingel We now take the subchannel set id also into account to find the boot device. If we want to use a subchannel set other than the default set 0, we first need to enable the mss facility. Signed-off-by: Dominik Dingel Signed-off-by: Christian Borntraeger --- pc-bios/s390-ccw/

Re: [Qemu-devel] [RFC 2/7] sd.c: introduce variable for trekking valid data

2013-06-17 Thread Stefan Hajnoczi
On Fri, Jun 14, 2013 at 12:49:52PM +0100, Peter Maydell wrote: > On 10 May 2013 17:10, Igor Mitsyanko wrote: > > Initialize it appropriately when various commands are processed. > > "tracking", but the commit message doesn't match the > patch contents anyway -- should this patch have more > conte

Re: [Qemu-devel] [PATCH v2 2/2] block: move the bdrv_dev_change_media_cb()

2013-06-17 Thread Stefan Hajnoczi
On Mon, Jun 17, 2013 at 11:46:19AM +0200, Pavel Hrdina wrote: > On 5.6.2013 15:23, Stefan Hajnoczi wrote: > >On Wed, May 29, 2013 at 06:18:19PM +0200, Pavel Hrdina wrote: > >>@@ -1071,14 +1072,18 @@ static void > >>qmp_bdrv_open_encrypted(BlockDriverState *bs, const char *filename, > >> i

Re: [Qemu-devel] [PATCH v5 03/11] block: add basic backup support to block driver

2013-06-17 Thread Stefan Hajnoczi
On Mon, Jun 17, 2013 at 11:43:24AM +0800, Fam Zheng wrote: > > +bdrv_iostatus_disable(target); > > +bdrv_delete(job->target); > > drive-mirror has bdrv_close before deleting target, why don't we need > one here? Use the source, Luke! :) void bdrv_delete(BlockDriverState *bs) { assert

[Qemu-devel] [PATCH 1/2] Allow use of pc machine type (accel=xen) for Xen HVM domains.

2013-06-17 Thread Paul Durrant
Xen HVM domains normally spawn QEMU with a dedicated xenfv machine type. The initialization code for this machine type can easily be pulled into the generic pc initialization code and guarded with a test for whether the xen accelerator options is specified, which is more consistent with the way oth

[Qemu-devel] [PATCH 0/2] Remove hardcoded xen-platform device initialization (v2)

2013-06-17 Thread Paul Durrant
Because of concerns over backwards compatibility and a suggestion that xenfv should be retired in favour of using the pc machine type I have re- worked my original patch into 2 patches: [PATCH 1/2] Allow use of pc machine type (accel=xen) for Xen HVM [PATCH 2/2] Move hardcoded initialization of xe

[Qemu-devel] [PATCH 2/2] Move hardcoded initialization of xen-platform device.

2013-06-17 Thread Paul Durrant
Creation of the xen-platform device is currently hardcoded into machine type pc's initialization code, guarded by a test for the whether the xen accelerator is enabled. This patch moves the creation of xen-platform into the initialization code of the xenfv machine type. This maintains backwards com

Re: [Qemu-devel] [PATCH] [slirp] fix -net user checks by reordering checks

2013-06-17 Thread Stefan Hajnoczi
On Mon, Jun 17, 2013 at 01:41:40PM +0200, Bas van Sisseren wrote: > On 04/06/13 14:26, Stefan Hajnoczi wrote: > > On Mon, Jun 03, 2013 at 03:11:49PM +0200, Bas van Sisseren wrote: > >> reorder slirp config options. first check the dns-server-address, > >> then check the first-dhcp-address. the orig

Re: [Qemu-devel] [PULL 21/26] ide-test: Add FLUSH CACHE test case

2013-06-17 Thread Stefan Hajnoczi
On Fri, Jun 14, 2013 at 01:18:44PM -0500, Anthony Liguori wrote: > Peter Maydell writes: > > > On 14 June 2013 18:54, Peter Maydell wrote: > >> On 7 June 2013 12:58, Stefan Hajnoczi wrote: > >>> From: Kevin Wolf > >>> > >>> This checks in particular that BSY is set while the flush request is i

Re: [Qemu-devel] [PATCH] qemu-img: Add missing GCC_FMT_ATTR

2013-06-17 Thread Stefan Hajnoczi
On Sun, Jun 16, 2013 at 05:01:05PM +0200, Stefan Weil wrote: > Signed-off-by: Stefan Weil > --- > qemu-img.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH 0/7 RFC] Localhost live migration

2013-06-17 Thread Stefan Hajnoczi
On Sun, Jun 16, 2013 at 11:37:26PM +0800, Lei Li wrote: > 2) Use different mechanism than current live migration. > >The very basic work flow like: > >qemu on the source (the source and destination are both on localhost) > | > V >Stop VM >

[Qemu-devel] [PATCH] target-arm: decode TBB/TBH more thoroughly

2013-06-17 Thread Mans Rullgard
This avoids other opcodes being incorrectly decoded as TBB/TBH. The LDA/STL instructions new in ARMv8 use this space. Signed-off-by: Mans Rullgard --- This was previously sent as part of the LDA/STL patch. Separating it seems clearer. --- target-arm/translate.c | 2 +- 1 file changed, 1 inserti

Re: [Qemu-devel] [PATCH v2 1/2] ps2: add support of auto-repeat

2013-06-17 Thread Luiz Capitulino
On Fri, 14 Jun 2013 13:46:41 +0800 Amos Kong wrote: > On Fri, May 31, 2013 at 08:31:17PM +0800, Amos Kong wrote: > > On Thu, May 30, 2013 at 11:48:46AM -0500, Anthony Liguori wrote: > > > Amos Kong writes: > > > > > > diff --git a/hw/input/ps2.c b/hw/input/ps2.c > > > > index 3412079..8adbb4a

Re: [Qemu-devel] [Bug 1191606] [NEW] qemu crashes with iscsi initiator (libiscsi) when using virtio

2013-06-17 Thread Stefan Hajnoczi
On Sun, Jun 16, 2013 at 11:48:27PM -, Klaus Hochlehnert wrote: > Public bug reported: > > I just tested qemu (with kvm) with an iscsi disk using libiscsi. > > I tried to install Ubuntu 12.04 as guest and when it comes to the disk > configuration during the installation qemu crashes without an

Re: [Qemu-devel] [PATCH v6] net: add support of mac-programming over macvtap in QEMU side

2013-06-17 Thread Luiz Capitulino
On Fri, 14 Jun 2013 15:45:52 +0800 Amos Kong wrote: > Currently macvtap based macvlan device is working in promiscuous > mode, we want to implement mac-programming over macvtap through > Libvirt for better performance. > > Design: > QEMU notifies Libvirt when rx-filter config is changed in gues

Re: [Qemu-devel] [PATCH] vnc: lift modifier keys on client disconnect.

2013-06-17 Thread Peter Lieven
Am 17.06.2013 14:09, schrieb Gerd Hoffmann: > On 06/17/13 13:05, Peter Lieven wrote: >> Am 17.06.2013 10:49, schrieb Gerd Hoffmann: >>> On 06/17/13 10:10, Peter Lieven wrote: Hi Gerd, just looking at your patch. It works fine so far, but I am curious how to handle the lock keys?

Re: [Qemu-devel] [PATCH v6] net: add support of mac-programming over macvtap in QEMU side

2013-06-17 Thread Michael S. Tsirkin
On Mon, Jun 17, 2013 at 09:11:27AM -0400, Luiz Capitulino wrote: > On Fri, 14 Jun 2013 15:45:52 +0800 > Amos Kong wrote: > > > Currently macvtap based macvlan device is working in promiscuous > > mode, we want to implement mac-programming over macvtap through > > Libvirt for better performance. >

[Qemu-devel] [PATCH v3 0/2] block: fix spurious DEVICE_TRAY_MOVED events on shutdown

2013-06-17 Thread Pavel Hrdina
This fixes a regression introduced by commit 9ca111544. The first commit is done by Luiz and I've just use it as it is. The second commit moves the bdrv_dev_change_media_cb() into eject_device(), called by QMP and HMP eject command, and into qmp_bdrv_open_encrypted(), called by QMP and HMP change

[Qemu-devel] [PATCH v3 1/2] block: make bdrv_dev_change_media_cb() public

2013-06-17 Thread Pavel Hrdina
From: Luiz Capitulino Next commit wants to use it. Signed-off-by: Luiz Capitulino Signed-off-by: Pavel Hrdina --- block.c | 3 +-- include/block/block.h | 1 + 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c index 79ad33d..9fbaf1a 100644 --- a/bl

Re: [Qemu-devel] [PATCH v2 2/2] block: move the bdrv_dev_change_media_cb()

2013-06-17 Thread Luiz Capitulino
On Mon, 17 Jun 2013 14:33:10 +0200 Stefan Hajnoczi wrote: > On Mon, Jun 17, 2013 at 11:46:19AM +0200, Pavel Hrdina wrote: > > On 5.6.2013 15:23, Stefan Hajnoczi wrote: > > >On Wed, May 29, 2013 at 06:18:19PM +0200, Pavel Hrdina wrote: > > >>@@ -1071,14 +1072,18 @@ static void > > >>qmp_bdrv_open

[Qemu-devel] [PATCH v3 2/2] block: move the bdrv_dev_change_media_cb()

2013-06-17 Thread Pavel Hrdina
The bdrv_dev_change_media_cb() should be called only for eject and change commands. We should call that function only if that command is successful. What this function does is that it calls the change_media_cb() and also emit the QEVENT_DEVICE_TRAY_MOVED event. If a password is not required, but

Re: [Qemu-devel] [PATCH v2 2/2] block: move the bdrv_dev_change_media_cb()

2013-06-17 Thread Pavel Hrdina
On 17.6.2013 15:22, Luiz Capitulino wrote: On Mon, 17 Jun 2013 14:33:10 +0200 Stefan Hajnoczi wrote: On Mon, Jun 17, 2013 at 11:46:19AM +0200, Pavel Hrdina wrote: On 5.6.2013 15:23, Stefan Hajnoczi wrote: On Wed, May 29, 2013 at 06:18:19PM +0200, Pavel Hrdina wrote: @@ -1071,14 +1072,18 @@

Re: [Qemu-devel] [PATCH v6] net: add support of mac-programming over macvtap in QEMU side

2013-06-17 Thread Luiz Capitulino
On Mon, 17 Jun 2013 16:21:31 +0300 "Michael S. Tsirkin" wrote: > On Mon, Jun 17, 2013 at 09:11:27AM -0400, Luiz Capitulino wrote: > > On Fri, 14 Jun 2013 15:45:52 +0800 > > Amos Kong wrote: > > > > > Currently macvtap based macvlan device is working in promiscuous > > > mode, we want to impleme

Re: [Qemu-devel] [PATCH v2 2/2] block: move the bdrv_dev_change_media_cb()

2013-06-17 Thread Luiz Capitulino
On Mon, 17 Jun 2013 15:25:24 +0200 Pavel Hrdina wrote: > On 17.6.2013 15:22, Luiz Capitulino wrote: > > On Mon, 17 Jun 2013 14:33:10 +0200 > > Stefan Hajnoczi wrote: > > > >> On Mon, Jun 17, 2013 at 11:46:19AM +0200, Pavel Hrdina wrote: > >>> On 5.6.2013 15:23, Stefan Hajnoczi wrote: > On W

[Qemu-devel] [PATCH 2/2] extend the macaddr space to 0xffffffff

2013-06-17 Thread Amos Kong
Currently we only support to allocate 0xff mac-addresses, if we start guest by pci-bridge/multiple-func, the macaddr are not enough. This patch extends the mac-address space to 0x 52:54:00:00:00:00 ~ 52:54:ff:ff:ff:ff Signed-off-by: Amos Kong --- net/net.c | 10 ++ 1 file chang

[Qemu-devel] [PATCH 1/2] avoid to allcate used macaddr to to new nic

2013-06-17 Thread Amos Kong
QEMU allocates macaddr to nic if user doesn't assigne macaddr. But we didn't check if the allocated macaddr is used, it might cause macaddr repeated. # qemu -device e1000,netdev=h1,mac=52:54:00:12:34:56 (qemu) device_add e1000 (qemu) info network e1000.0: index=0,type=nic,model=e1000,macadd

[Qemu-devel] [PATCH 0/2] fix macaddr allocation

2013-06-17 Thread Amos Kong
This patchset adds a check in allocating mac to new nic, it will avoid to use repeated mac. The second extends the address space. Amos Kong (2): avoid to allcate used macaddr to to new nic extend the macaddr space to 0x net/net.c | 38 ++ 1 file ch

Re: [Qemu-devel] [PATCH v2 2/2] block: move the bdrv_dev_change_media_cb()

2013-06-17 Thread Pavel Hrdina
On 17.6.2013 15:32, Luiz Capitulino wrote: On Mon, 17 Jun 2013 15:25:24 +0200 Pavel Hrdina wrote: On 17.6.2013 15:22, Luiz Capitulino wrote: On Mon, 17 Jun 2013 14:33:10 +0200 Stefan Hajnoczi wrote: On Mon, Jun 17, 2013 at 11:46:19AM +0200, Pavel Hrdina wrote: On 5.6.2013 15:23, Stefan Ha

Re: [Qemu-devel] [PATCH] make screendump an async command

2013-06-17 Thread Luiz Capitulino
On Fri, 14 Jun 2013 19:55:21 -0400 Alon Levy wrote: > On Fri, 2013-06-14 at 13:21 -0500, Anthony Liguori wrote: > > Alon Levy writes: > > > > > This fixes the broken screendump behavior for qxl devices in native mode > > > since 81fb6f1504fb9ef71f2382f44af34756668296e8. > > > > > > Note: due to

Re: [Qemu-devel] [PATCH v2 2/2] block: move the bdrv_dev_change_media_cb()

2013-06-17 Thread Luiz Capitulino
On Mon, 17 Jun 2013 15:38:23 +0200 Pavel Hrdina wrote: > On 17.6.2013 15:32, Luiz Capitulino wrote: > > On Mon, 17 Jun 2013 15:25:24 +0200 > > Pavel Hrdina wrote: > > > >> On 17.6.2013 15:22, Luiz Capitulino wrote: > >>> On Mon, 17 Jun 2013 14:33:10 +0200 > >>> Stefan Hajnoczi wrote: > >>> > >>

Re: [Qemu-devel] [PATCH v2 2/2] block: move the bdrv_dev_change_media_cb()

2013-06-17 Thread Kevin Wolf
Am 17.06.2013 um 15:38 hat Pavel Hrdina geschrieben: > >It's just a warning, that you used a password for a block device that > >doesn't require it. The device is opened successfully and should be > >handled correctly (call the bdrv_dev_change_media_cb() ). > > Yep, IMO it's wo

Re: [Qemu-devel] [PATCH v2 2/2] block: move the bdrv_dev_change_media_cb()

2013-06-17 Thread Luiz Capitulino
On Mon, 17 Jun 2013 15:46:52 +0200 Kevin Wolf wrote: > Am 17.06.2013 um 15:38 hat Pavel Hrdina geschrieben: > > >It's just a warning, that you used a password for a block device that > > >doesn't require it. The device is opened successfully and should be > > >handled correctly (call

Re: [Qemu-devel] [PATCH v6] net: add support of mac-programming over macvtap in QEMU side

2013-06-17 Thread Michael S. Tsirkin
On Fri, Jun 14, 2013 at 03:45:52PM +0800, Amos Kong wrote: > Currently macvtap based macvlan device is working in promiscuous > mode, we want to implement mac-programming over macvtap through > Libvirt for better performance. > > Design: > QEMU notifies Libvirt when rx-filter config is changed in

Re: [Qemu-devel] [PATCH] make screendump an async command

2013-06-17 Thread Luiz Capitulino
On Mon, 17 Jun 2013 08:06:58 +0200 Gerd Hoffmann wrote: > Hmm, while thinking about it: There is another screendump change in the > pipeline: allow screen dumps from *any* device. So, I think this is > actually a very good reason to implement a new screendump command as I > think we can kill tw

Re: [Qemu-devel] [PATCH 1/2] avoid to allcate used macaddr to to new nic

2013-06-17 Thread Michael S. Tsirkin
On Mon, Jun 17, 2013 at 09:35:10PM +0800, Amos Kong wrote: > QEMU allocates macaddr to nic if user doesn't assigne macaddr. > But we didn't check if the allocated macaddr is used, it might > cause macaddr repeated. > > # qemu -device e1000,netdev=h1,mac=52:54:00:12:34:56 > (qemu) device_add e10

Re: [Qemu-devel] [PATCH] vnc: lift modifier keys on client disconnect.

2013-06-17 Thread Gerd Hoffmann
Hi, >> I guess reset_keys() should skip capslock+numlock to not disturb the >> sync logic, can you try that? > > mhh, i might be wrong, but where could the vs->modifiers_state be not zero > on a new connection. I only find a g_malloc0 initializing the VNCState. Ah, right, it is in the per-conn

Re: [Qemu-devel] [PATCH] make screendump an async command

2013-06-17 Thread Gerd Hoffmann
On 06/17/13 11:30, Alon Levy wrote: > But on the other hand if this is something that would be acceptable now > and having proper Async error handling is not forthcoming (why btw? is > anyone working on it) . But it would become baggage later on.. Don't think it is too bad, RfC patches will go out

[Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp cmd

2013-06-17 Thread Gerd Hoffmann
Adds a screendump-device qmp command, which has an additional 'device' parameter. This way it is possible to specify the device you want a screendump from. For the hmp monitor an optional device parameter has been added to the esisting screendump command. https://bugzilla.redhat.com/show_bug.cgi

[Qemu-devel] [RfC PATCH 0/2] new screendump qmp command

2013-06-17 Thread Gerd Hoffmann
Hi, Just a rough + incomplete draft for now, to show the idea. Series adds a new screendump qmp command. This does (a) allow to specify the device we want dump from, (b) does the actual image writing in a bottom half and (c) sends a qmp event when (not done yet, just a comment for now). It al

[Qemu-devel] [RfC PATCH 1/2] display update with notification

2013-06-17 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/ui/console.h |2 ++ ui/console.c | 15 +++ 2 files changed, 17 insertions(+) diff --git a/include/ui/console.h b/include/ui/console.h index 092b9be..4860687 100644 --- a/include/ui/console.h +++ b/include/ui/console.h @@ -273,6 +

Re: [Qemu-devel] [PATCH 2/2] extend the macaddr space to 0xffffffff

2013-06-17 Thread Michael S. Tsirkin
On Mon, Jun 17, 2013 at 09:35:11PM +0800, Amos Kong wrote: > Currently we only support to allocate 0xff mac-addresses, > if we start guest by pci-bridge/multiple-func, the macaddr > are not enough. > > This patch extends the mac-address space to 0x > > 52:54:00:00:00:00 ~ 52:54:ff:ff:ff:f

Re: [Qemu-devel] [RFC 2/7] sd.c: introduce variable for trekking valid data

2013-06-17 Thread Paolo Bonzini
Il 17/06/2013 14:30, Stefan Hajnoczi ha scritto: >>> > > @@ -116,6 +116,7 @@ struct SDState { >>> > > QEMUIOVector qiov; >>> > > struct iovec iov; >>> > > BlockDriverAIOCB *aiocb; >>> > > +uint32_t transf_cnt; >> > >> > How does this work for migration -- are we guaranteed that

Re: [Qemu-devel] [PATCH] target-arm: decode TBB/TBH more thoroughly

2013-06-17 Thread Peter Maydell
On 17 June 2013 14:00, Mans Rullgard wrote: > This avoids other opcodes being incorrectly decoded as TBB/TBH. > The LDA/STL instructions new in ARMv8 use this space. > > Signed-off-by: Mans Rullgard > --- > This was previously sent as part of the LDA/STL patch. Separating it > seems clearer. > -

Re: [Qemu-devel] [PATCH] target-arm: decode TBB/TBH more thoroughly

2013-06-17 Thread Måns Rullgård
Peter Maydell writes: > On 17 June 2013 14:00, Mans Rullgard wrote: >> This avoids other opcodes being incorrectly decoded as TBB/TBH. >> The LDA/STL instructions new in ARMv8 use this space. >> >> Signed-off-by: Mans Rullgard >> --- >> This was previously sent as part of the LDA/STL patch. Se

Re: [Qemu-devel] [PATCH v6] net: add support of mac-programming over macvtap in QEMU side

2013-06-17 Thread Michael S. Tsirkin
On Mon, Jun 17, 2013 at 09:30:42AM -0400, Luiz Capitulino wrote: > On Mon, 17 Jun 2013 16:21:31 +0300 > "Michael S. Tsirkin" wrote: > > > On Mon, Jun 17, 2013 at 09:11:27AM -0400, Luiz Capitulino wrote: > > > On Fri, 14 Jun 2013 15:45:52 +0800 > > > Amos Kong wrote: > > > > > > > Currently macv

Re: [Qemu-devel] [PATCH v6] net: add support of mac-programming over macvtap in QEMU side

2013-06-17 Thread Luiz Capitulino
On Mon, 17 Jun 2013 17:20:13 +0300 "Michael S. Tsirkin" wrote: > On Mon, Jun 17, 2013 at 09:30:42AM -0400, Luiz Capitulino wrote: > > On Mon, 17 Jun 2013 16:21:31 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Mon, Jun 17, 2013 at 09:11:27AM -0400, Luiz Capitulino wrote: > > > > On Fri, 14

Re: [Qemu-devel] [RfC PATCH 1/2] display update with notification

2013-06-17 Thread Anthony Liguori
Little more context please. Regards, Anthony Liguori Gerd Hoffmann writes: > Signed-off-by: Gerd Hoffmann > --- > include/ui/console.h |2 ++ > ui/console.c | 15 +++ > 2 files changed, 17 insertions(+) > > diff --git a/include/ui/console.h b/include/ui/console.h >

Re: [Qemu-devel] [PATCH v6] net: add support of mac-programming over macvtap in QEMU side

2013-06-17 Thread Michael S. Tsirkin
On Mon, Jun 17, 2013 at 10:34:28AM -0400, Luiz Capitulino wrote: > On Mon, 17 Jun 2013 17:20:13 +0300 > "Michael S. Tsirkin" wrote: > > > On Mon, Jun 17, 2013 at 09:30:42AM -0400, Luiz Capitulino wrote: > > > On Mon, 17 Jun 2013 16:21:31 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > > On

Re: [Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp cmd

2013-06-17 Thread Anthony Liguori
Gerd Hoffmann writes: > Adds a screendump-device qmp command, which has an additional 'device' > parameter. This way it is possible to specify the device you want a > screendump from. > > For the hmp monitor an optional device parameter has been added to the > esisting screendump command. > > ht

Re: [Qemu-devel] [PATCH v2 2/2] block: move the bdrv_dev_change_media_cb()

2013-06-17 Thread Kevin Wolf
Am 17.06.2013 um 15:51 hat Luiz Capitulino geschrieben: > On Mon, 17 Jun 2013 15:46:52 +0200 > Kevin Wolf wrote: > > > Am 17.06.2013 um 15:38 hat Pavel Hrdina geschrieben: > > > >It's just a warning, that you used a password for a block device that > > > >doesn't require it. The device is

Re: [Qemu-devel] [PATCH v6] net: add support of mac-programming over macvtap in QEMU side

2013-06-17 Thread Amos Kong
On Mon, Jun 17, 2013 at 09:11:27AM -0400, Luiz Capitulino wrote: > On Fri, 14 Jun 2013 15:45:52 +0800 > Amos Kong wrote: > > > Currently macvtap based macvlan device is working in promiscuous > > mode, we want to implement mac-programming over macvtap through > > Libvirt for better performance. >

Re: [Qemu-devel] [PATCH v6] net: add support of mac-programming over macvtap in QEMU side

2013-06-17 Thread Luiz Capitulino
On Mon, 17 Jun 2013 17:42:50 +0300 "Michael S. Tsirkin" wrote: > > The 1000ms I talked about is *not* what the guest will see. If there are > > events pending, the throttle API just queues the event and returns right > > away. I'd even _guess_ that this is faster then emitting the event. > > If

Re: [Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp cmd

2013-06-17 Thread Luiz Capitulino
On Mon, 17 Jun 2013 09:43:07 -0500 Anthony Liguori wrote: > Gerd Hoffmann writes: > > > Adds a screendump-device qmp command, which has an additional 'device' > > parameter. This way it is possible to specify the device you want a > > screendump from. > > > > For the hmp monitor an optional de

Re: [Qemu-devel] [RFC 08/13] block: drop bdrv_get_aio_context()

2013-06-17 Thread Stefan Hajnoczi
On Fri, Jun 14, 2013 at 10:12:00AM -0400, Paolo Bonzini wrote: > Il 14/06/2013 05:48, Stefan Hajnoczi ha scritto: > > Associating a BlockDriverState with a single AioContext is not flexible > > enough. Once we make BlockDriverState thread-safe, it will be possible > > to call bdrv_*() functions fr

Re: [Qemu-devel] [PATCH v6] net: add support of mac-programming over macvtap in QEMU side

2013-06-17 Thread Amos Kong
On Mon, Jun 17, 2013 at 10:54:39AM -0400, Luiz Capitulino wrote: > On Mon, 17 Jun 2013 17:42:50 +0300 > "Michael S. Tsirkin" wrote: > > > > The 1000ms I talked about is *not* what the guest will see. If there are > > > events pending, the throttle API just queues the event and returns right > > >

Re: [Qemu-devel] [RFC 08/13] block: drop bdrv_get_aio_context()

2013-06-17 Thread Paolo Bonzini
Il 17/06/2013 16:57, Stefan Hajnoczi ha scritto: > On Fri, Jun 14, 2013 at 10:12:00AM -0400, Paolo Bonzini wrote: >> Il 14/06/2013 05:48, Stefan Hajnoczi ha scritto: >>> Associating a BlockDriverState with a single AioContext is not flexible >>> enough. Once we make BlockDriverState thread-safe, i

  1   2   3   >