Patch is good, I think the issue is just in the sending as flagged by Andreas.
On Mon, Jun 17, 2013 at 10:43 AM, Vladimir Senkov <han...@gmail.com> wrote: > From 032bdc94c6369aa7b578182cdad8038ebb2b8cd1 Mon Sep 17 00:00:00 2001 > From: Vladimir Senkov <han...@gmail.com> > Date: Sun, 16 Jun 2013 20:30:52 -0400 > Subject: [PATCH] fixed a copy&paste error in serial.c > > Signed-off-by: Vladimir Senkov <han...@gmail.com> Reviewed-by: Peter Crosthwaite <peter.crosthwa...@xilinx.com> > > --- > hw/char/serial.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/char/serial.c b/hw/char/serial.c > index b537e42..6382f98 100644 > --- a/hw/char/serial.c > +++ b/hw/char/serial.c > @@ -424,7 +424,7 @@ static uint64_t serial_ioport_read(void *opaque, hwaddr > addr, unsigned size) > ret = s->divider & 0xff; > } else { > if(s->fcr & UART_FCR_FE) { > - ret = fifo8_is_full(&s->recv_fifo) ? > + ret = fifo8_is_empty(&s->recv_fifo) ? > 0 : fifo8_pop(&s->recv_fifo); > if (s->recv_fifo.num == 0) { > s->lsr &= ~(UART_LSR_DR | UART_LSR_BI); > -- > 1.8.1.2 >