[Qemu-devel] [PATCH V2 00/12] add internal snapshot support at block device level

2013-06-14 Thread Wenchao Xia
This series brings internal snapshot support at block devices level, now we have two main methods to do snapshot: 1) backing chain and 2) internal one, and 3) Stefan's unmerged backing up approach. Compared with 1), internal snapshot is faster in R/W/Delete. Compared with 3), it complete faster,

[Qemu-devel] [PATCH V2 01/12] blockdev: drop redundant proto_drv check

2013-06-14 Thread Wenchao Xia
From: Stefan Hajnoczi It is not necessary to check that we can find a protocol block driver since we create or open the image file. This produces the error that we need anyway. Besides, the QERR_INVALID_BLOCK_FORMAT is inappropriate since the protocol is incorrect rather than the format. Also

[Qemu-devel] [PATCH 2/6] pc: Don't explode QEMUMachineInitArgs into local variables needlessly

2013-06-14 Thread Markus Armbruster
Don't explode when the variable is used just a few times, and never changed. Signed-off-by: Markus Armbruster --- hw/i386/pc_q35.c | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c index 7888dfe..eda65f4 100644 --- a/h

[Qemu-devel] [PATCH V2 08/12] qmp: add interface blockdev-snapshot-internal-sync

2013-06-14 Thread Wenchao Xia
This interface can generate snapshot name automatically if it is not specified, since it is a single opertion. Snapshot ID can't be specified in this interface. Signed-off-by: Wenchao Xia --- blockdev.c | 25 + qapi-schema.json | 23 +++ qmp

[Qemu-devel] [PATCH V2 03/12] blockdev: allow BdrvActionOps->commit() to be NULL

2013-06-14 Thread Wenchao Xia
From: Stefan Hajnoczi Some QMP 'transaction' types don't need to do anything on .commit(). Make .commit() optional just like .abort(). The "drive-backup" action will take advantage of this, it only needs to cancel the block job on .abort(). Other block job actions will probably follow the same

[Qemu-devel] [PATCH v4 07/17] block/gluster: drop qemu_gluster_aio_flush_cb()

2013-06-14 Thread Stefan Hajnoczi
Since .io_flush() is no longer called we do not need qemu_gluster_aio_flush_cb() anymore. It turns out that qemu_aio_count is unused now and can be dropped. Signed-off-by: Stefan Hajnoczi --- block/gluster.c | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/bl

[Qemu-devel] [PATCH V2 12/12] qemu-iotests: add 055 internal snapshot for block device test case

2013-06-14 Thread Wenchao Xia
Signed-off-by: Wenchao Xia --- tests/qemu-iotests/055 | 157 tests/qemu-iotests/055.out |5 ++ tests/qemu-iotests/group |1 + 3 files changed, 163 insertions(+), 0 deletions(-) create mode 100755 tests/qemu-iotests/055 create mode 1006

[Qemu-devel] [PATCH V2 05/12] snapshot: add paired functions for internal snapshot id and name

2013-06-14 Thread Wenchao Xia
Internal snapshot's ID and name concept are both visible in general block level, they are observed by user in "info snapshots", so it is possible to mess them up. Although we can separate the two concept in programming, but if they can be distinguished in string itself, things will be simple and cl

[Qemu-devel] [PATCH v4 10/17] block/nbd: drop nbd_have_request()

2013-06-14 Thread Stefan Hajnoczi
.io_flush() is no longer called so drop nbd_have_request(). We cannot drop in_flight since it is still used by other block/nbd.c code. Signed-off-by: Stefan Hajnoczi --- block/nbd.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/block/nbd.c b/block/nbd.c inde

[Qemu-devel] [PATCH 1/6] pc: Don't prematurely explode QEMUMachineInitArgs

2013-06-14 Thread Markus Armbruster
Don't explode QEMUMachineInitArgs before passing it to pc_init1(). Signed-off-by: Markus Armbruster --- hw/i386/pc_piix.c | 59 --- 1 file changed, 13 insertions(+), 46 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index d618

[Qemu-devel] [PATCH v4 00/17] aio: drop io_flush()

2013-06-14 Thread Stefan Hajnoczi
v4: * Ensure pending BHs are processed in bdrv_drain_all() [bonzini] v3: * I forgot about this series, time to push it again! * Rebase onto qemu.git/master * Drop now-unused AioFlushHandler typedef [bonzini] This series gets rid of aio's .io_flush() callback. It's based on Paolo's insight th

[Qemu-devel] [PATCH 6/6] hw: Clean up bogus default boot order

2013-06-14 Thread Markus Armbruster
We set default boot order "cad" in every single machine definition except "pseries" and "moxiesim", even though very few boards actually care for boot order, and "cad" makes sense for even fewer. Machines that care: * pc and its variants Accept up to three letters 'a', 'b' (undocumented alias

[Qemu-devel] [PATCH V2 06/12] snapshot: distinguish id and name in snapshot delete

2013-06-14 Thread Wenchao Xia
Snapshot creation actually already distinguish id and name since it take a structured parameter *sn, but delete can't. Later an accurate delete is needed in qmp_transaction abort and blockdev-snapshot-delete-sync, so change its prototype. Also *errp is added to tip error, but return value is kepted

[Qemu-devel] [PATCH v4 11/17] block/rbd: drop qemu_rbd_aio_flush_cb()

2013-06-14 Thread Stefan Hajnoczi
.io_flush() is no longer called so drop qemu_rbd_aio_flush_cb(). qemu_aio_count is unused now so drop it too. Signed-off-by: Stefan Hajnoczi --- block/rbd.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/block/rbd.c b/block/rbd.c index 0f2608b..40e5d55 100644

[Qemu-devel] [PATCH v4 06/17] block/curl: drop curl_aio_flush()

2013-06-14 Thread Stefan Hajnoczi
.io_flush() is no longer called so drop curl_aio_flush(). The acb[] array that the function checks is still used in other parts of block/curl.c. Therefore we cannot remove acb[], it is needed. Signed-off-by: Stefan Hajnoczi --- block/curl.c | 22 +++--- 1 file changed, 3 insert

[Qemu-devel] [PATCH v4 08/17] block/iscsi: drop iscsi_process_flush()

2013-06-14 Thread Stefan Hajnoczi
.io_flush() is no longer called so drop iscsi_process_flush(). Signed-off-by: Stefan Hajnoczi --- block/iscsi.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index f7199c1..e2041ca 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -147,

[Qemu-devel] [PATCH v4 16/17] tests: drop event_active_cb()

2013-06-14 Thread Stefan Hajnoczi
The .io_flush() handler no longer exists and has no users. Drop the io_flush argument to aio_set_fd_handler() and related functions. Signed-off-by: Stefan Hajnoczi --- tests/test-aio.c | 22 -- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/tests/test-aio.c b

[Qemu-devel] [PATCH v4 01/17] block: stop relying on io_flush() in bdrv_drain_all()

2013-06-14 Thread Stefan Hajnoczi
If a block driver has no file descriptors to monitor but there are still active requests, it can return 1 from .io_flush(). This is used to spin during synchronous I/O. Stop relying on .io_flush() and instead check QLIST_EMPTY(&bs->tracked_requests) to decide whether there are active requests. T

[Qemu-devel] [PATCH V2 07/12] qmp: add internal snapshot support in qmp_transaction

2013-06-14 Thread Wenchao Xia
Unlike savevm, the qmp_transaction interface will not generate snapshot name automatically, saving trouble to return information of the new created snapshot. The snapshot name should not mess up with snapshot ID, there is a check for it. Although qcow2 support storing multiple snapshots with same

[Qemu-devel] [PATCH v4 12/17] block/sheepdog: drop have_co_req() and aio_flush_request()

2013-06-14 Thread Stefan Hajnoczi
.io_flush() is no longer called so drop have_co_req() and aio_flush_request(). Signed-off-by: Stefan Hajnoczi --- block/sheepdog.c | 25 + 1 file changed, 5 insertions(+), 20 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index 21a4edf..66918c6 100644 ---

[Qemu-devel] [PATCH v4 04/17] tests: adjust test-thread-pool to new aio_poll() semantics

2013-06-14 Thread Stefan Hajnoczi
aio_poll(ctx, true) will soon block when fd handlers have been set. Previously aio_poll() would return early if all .io_flush() returned false. This means we need to check the equivalent of the .io_flush() condition *before* calling aio_poll(ctx, true) to avoid deadlock. Signed-off-by: Stefan Haj

[Qemu-devel] [PATCH v4 03/17] tests: adjust test-aio to new aio_poll() semantics

2013-06-14 Thread Stefan Hajnoczi
aio_poll(ctx, true) will soon block if any fd handlers have been set. Previously it would only block when .io_flush() returned true. This means that callers must check their wait condition *before* aio_poll() to avoid deadlock. Signed-off-by: Stefan Hajnoczi --- tests/test-aio.c | 26 ++

[Qemu-devel] [PATCH v4 17/17] aio: drop io_flush argument

2013-06-14 Thread Stefan Hajnoczi
The .io_flush() handler no longer exists and has no users. Drop the io_flush argument to aio_set_fd_handler() and related functions. The AioFlushEventNotifierHandler and AioFlushHandler typedefs are no longer used and are dropped too. Signed-off-by: Stefan Hajnoczi --- aio-posix.c

[Qemu-devel] [PATCH v4 09/17] block/linux-aio: drop qemu_laio_completion_cb()

2013-06-14 Thread Stefan Hajnoczi
.io_flush() is no longer called so drop qemu_laio_completion_cb(). It turns out that count is now unused so drop that too. Signed-off-by: Stefan Hajnoczi --- block/linux-aio.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/block/linux-aio.c b/block/linux-

[Qemu-devel] [PATCH 5/6] ppc: Don't duplicate QEMUMachineInitArgs in PPCE500Params

2013-06-14 Thread Markus Armbruster
Pass on the generic arguments unadulterated, and the machine-specific ones as separate argument. Signed-off-by: Markus Armbruster --- hw/ppc/e500.c | 35 ++- hw/ppc/e500.h | 13 +++-- hw/ppc/e500plat.c | 8 +--- hw/ppc/mpc8544ds.c | 8 +---

[Qemu-devel] [PATCH v4 05/17] aio: stop using .io_flush()

2013-06-14 Thread Stefan Hajnoczi
Now that aio_poll() users check their termination condition themselves, it is no longer necessary to call .io_flush() handlers. The behavior of aio_poll() changes as follows: 1. .io_flush() is no longer invoked and file descriptors are *always* monitored. Previously returning 0 from .io_flush()

Re: [Qemu-devel] [RFC 2/7] sd.c: introduce variable for trekking valid data

2013-06-14 Thread Peter Maydell
On 10 May 2013 17:10, Igor Mitsyanko wrote: > Initialize it appropriately when various commands are processed. "tracking", but the commit message doesn't match the patch contents anyway -- should this patch have more content from later patches, or be squashed into one of them? > > Signed-off-by:

[Qemu-devel] [PATCH v4 13/17] block/ssh: drop return_true()

2013-06-14 Thread Stefan Hajnoczi
.io_flush() is no longer called so drop return_true(). Signed-off-by: Stefan Hajnoczi --- block/ssh.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/block/ssh.c b/block/ssh.c index 246a70d..ed525cc 100644 --- a/block/ssh.c +++ b/block/ssh.c @@ -725,14 +725,6 @@ sta

[Qemu-devel] [PATCH v4 15/17] thread-pool: drop thread_pool_active()

2013-06-14 Thread Stefan Hajnoczi
.io_flush() is no longer called so drop thread_pool_active(). The block layer is the only thread-pool.c user and it already tracks in-flight requests, therefore we do not need thread_pool_active(). Signed-off-by: Stefan Hajnoczi --- thread-pool.c | 8 +--- 1 file changed, 1 insertion(+), 7

Re: [Qemu-devel] [RFC 3/7] sd.c: introduce "start bit" and "busy deasserted" callbacks

2013-06-14 Thread Peter Maydell
On 10 May 2013 17:10, Igor Mitsyanko wrote: > Start bit callback models arrival of first bit of data on card's DAT line. > > Busy deasserted callback models releasing of DAT0 line by card when it > transitions from a programming state to a writing data state. > > Both of them will be used for asyn

[Qemu-devel] [PATCH V2 11/12] hmp: add interface hmp_snapshot_delete_blkdev_internal

2013-06-14 Thread Wenchao Xia
Signed-off-by: Wenchao Xia --- hmp-commands.hx | 19 +++ hmp.c | 10 ++ hmp.h |1 + 3 files changed, 30 insertions(+), 0 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 312a0c7..5a66515 100644 --- a/hmp-commands.hx +++ b/hmp-c

[Qemu-devel] [PATCH V3] build: remove compile warning

2013-06-14 Thread Wenchao Xia
This patch simply remove "variable may be used uninitialized" warning. Signed-off-by: Wenchao Xia --- V2: Address Stefan and Peter's comments, use 0 in send_msg() instead of initialize mhHeader. V3: Address Markus's comments, adjust the code section in iov.c. libcacard/vscclient.c |3 +-- u

Re: [Qemu-devel] [PATCH 0/6] Clean up bogus default boot order

2013-06-14 Thread Alexander Graf
On 14.06.2013, at 13:40, Markus Armbruster wrote: > This is on top of "[PATCH v3 00/16] -boot and -no-fd-bootchk fixes", > so it's protected by the tests there. > > The first five patches are admittedly related to the stated purpose of > this series pretty much only by "I can't stand perpetuatin

[Qemu-devel] [PATCH V2 09/12] qmp: add interface blockdev-snapshot-delete-internal-sync

2013-06-14 Thread Wenchao Xia
Snapshot ID can't be specified in this interface. Signed-off-by: Wenchao Xia --- blockdev.c | 12 qapi-schema.json | 19 +++ qmp-commands.hx | 30 ++ 3 files changed, 61 insertions(+), 0 deletions(-) diff --git a/blockdev.c b

Re: [Qemu-devel] [RFC 6/7] sd.c: introduce async write interface

2013-06-14 Thread Peter Maydell
On 10 May 2013 17:10, Igor Mitsyanko wrote: > Signed-off-by: Igor Mitsyanko > --- > hw/sd/sd.c | 145 > - > 1 file changed, 133 insertions(+), 12 deletions(-) > > diff --git a/hw/sd/sd.c b/hw/sd/sd.c > index 659ec56..615ab61 100644 > -

Re: [Qemu-devel] [RFC 7/7] pl181.c: convert to async IO SD card interface

2013-06-14 Thread Peter Maydell
On 10 May 2013 17:10, Igor Mitsyanko wrote: > Signed-off-by: Igor Mitsyanko (not a complete review, just a couple of things I noticed on a first pass.) > --- > hw/sd/pl181.c | 302 > +- > 1 file changed, 192 insertions(+), 110 deletions(

Re: [Qemu-devel] [PATCH 0/6] Clean up bogus default boot order

2013-06-14 Thread Markus Armbruster
Alexander Graf writes: > On 14.06.2013, at 13:40, Markus Armbruster wrote: > >> This is on top of "[PATCH v3 00/16] -boot and -no-fd-bootchk fixes", >> so it's protected by the tests there. >> >> The first five patches are admittedly related to the stated purpose of >> this series pretty much on

[Qemu-devel] [PATCH V2 10/12] hmp: add interface hmp_snapshot_blkdev_internal

2013-06-14 Thread Wenchao Xia
Signed-off-by: Wenchao Xia --- hmp-commands.hx | 24 ++-- hmp.c | 10 ++ hmp.h |1 + 3 files changed, 33 insertions(+), 2 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 396691a..312a0c7 100644 --- a/hmp-commands.hx +++ b/

[Qemu-devel] [PATCH V2 02/12] blockdev: rename BlkTransactionStates to singular

2013-06-14 Thread Wenchao Xia
From: Stefan Hajnoczi The QMP 'transaction' command keeps a list of in-flight transactions. The transaction state structure is called BlkTransactionStates even though it only deals with a single transaction. The only plural thing is the linked list of transaction states. I find it confusing to

[Qemu-devel] [PATCH v4 14/17] dataplane/virtio-blk: drop flush_true() and flush_io()

2013-06-14 Thread Stefan Hajnoczi
.io_flush() is no longer called so drop flush_true() and flush_io(). Signed-off-by: Stefan Hajnoczi --- hw/block/dataplane/virtio-blk.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c index 0

[Qemu-devel] [PATCH v4 02/17] dataplane/virtio-blk: check exit conditions before aio_poll()

2013-06-14 Thread Stefan Hajnoczi
Check exit conditions before entering blocking aio_poll(). This is mainly for consistency since it's unlikely that we are stopping in the first event loop iteration. Signed-off-by: Stefan Hajnoczi --- hw/block/dataplane/virtio-blk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) dif

[Qemu-devel] [PATCH V2 04/12] snapshot: new function bdrv_snapshot_find_by_id_and_name()

2013-06-14 Thread Wenchao Xia
To make it clear about id and name in searching, add this API to distinguish them. Caller can choose to search by id or name, *errp will be set only for exception. Some code are modified based on Pavel's patch. Signed-off-by: Wenchao Xia Signed-off-by: Pavel Hrdina --- block/snapshot.c

Re: [Qemu-devel] [SeaBIOS] solaris x86 in qemu? [bisected]

2013-06-14 Thread Gerd Hoffmann
Hi, > Hmm. Speaking of the splitting. Does the current bios include the > the tables which were split into separate files? Yes, they are in out/ too after building seabios. Use "qemu -L /path/to/seabios/out" to make sure qemu picks up matching bios.bin and dsdt. cheers, Gerd

Re: [Qemu-devel] hw/ssi/xilinx_spips.c:52:1: warning: "CS" redefined

2013-06-14 Thread Peter Crosthwaite
Hi Michael, On Fri, Jun 14, 2013 at 5:11 PM, Michael Tokarev wrote: > This warning is produced when compiling qemu on solaris > (openindiana). > > /usr/include/sys/regset.h:98:1: warning: this is the location > of the previous definition > > (I don't know how regset.h is included) > > The c

Re: [Qemu-devel] [PATCH] remove call to type_initialize in object_new_with_type

2013-06-14 Thread Peter Crosthwaite
Hi Hu, On Thu, Jun 13, 2013 at 8:51 PM, Hu Tao wrote: > Since it's called in object_initialize_with_type later. > > Signed-off-by: Hu Tao > --- > qom/object.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/qom/object.c b/qom/object.c > index 803b94b..38dc45e 100644 > --- a/qom/objec

Re: [Qemu-devel] [PATCH] remove call to type_initialize in object_new_with_type

2013-06-14 Thread Peter Crosthwaite
On Fri, Jun 14, 2013 at 5:09 PM, Hu Tao wrote: > On Thu, Jun 13, 2013 at 06:51:49PM +0800, Hu Tao wrote: >> Since it's called in object_initialize_with_type later. >> >> Signed-off-by: Hu Tao >> --- >> qom/object.c | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/qom/object.c b/qom/

Re: [Qemu-devel] [PATCH v3 02/16] qemu-option: check_params() is now unused, drop it

2013-06-14 Thread Anthony Liguori
Markus Armbruster writes: > Signed-off-by: Markus Armbruster Reviewed-by: Anthony Liguori Regards, Anthony Liguori > --- > include/qemu/option.h | 2 -- > util/qemu-option.c| 30 -- > 2 files changed, 32 deletions(-) > > diff --git a/include/qemu/option.h b

Re: [Qemu-devel] [PATCH v3 04/16] vl: Rename *boot_devices to *boot_order, for consistency

2013-06-14 Thread Anthony Liguori
Markus Armbruster writes: > Signed-off-by: Markus Armbruster Reviewed-by: Anthony Liguori Regards, Anthony Liguori > --- > include/hw/hw.h | 4 ++-- > vl.c| 16 > 2 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/include/hw/hw.h b/include/hw/

Re: [Qemu-devel] [PATCH v3 03/16] vl: Fix -boot order and once regressions, and related bugs

2013-06-14 Thread Anthony Liguori
Markus Armbruster writes: > Option "once" sets up a different boot order just for the initial > boot. Boot order reverts back to normal on reset. Option "order" > changes the normal boot order. > > The reversal is implemented by reset handler restore_boot_devices(), > which takes the boot order

Re: [Qemu-devel] [PATCH v3 01/16] vl: Clean up parsing of -boot option argument

2013-06-14 Thread Anthony Liguori
Markus Armbruster writes: > Commit 3d3b8303 threw in some QemuOpts parsing without replacing the > existing ad hoc parser, resulting in a confusing mess. Clean it up. > > Two user-visible changes: > > 1. Invalid options are reported more nicely. Before: > > qemu: unknown boot parameter

Re: [Qemu-devel] [PATCH v3 05/16] pc: Make -no-fd-bootchk stick across boot order changes

2013-06-14 Thread Anthony Liguori
Markus Armbruster writes: > Option -no-fd-bootchk asks the BIOS to attempt booting from a floppy > even when the boot sector signature isn't there, by setting a bit in > RTC CMOS. It was added back in 2006 (commit 52ca8d6a). > > Two years later, commit 0ecdffbb added monitor command boot_set. >

Re: [Qemu-devel] [PATCH v3 06/16] doc: Drop ref to Bochs from -no-fd-bootchk documentation

2013-06-14 Thread Anthony Liguori
Markus Armbruster writes: > Manual page and qemu-doc on talk about "Bochs BIOS". We use SeaBIOS, > and it implements the feature. Replace by just "BIOS", and drop the > TODO line wondering about the Bochs reference. > > Signed-off-by: Markus Armbruster Reviewed-by: Anthony Liguori Regards,

Re: [Qemu-devel] [RFC] sanitize memory on system reset

2013-06-14 Thread Paolo Bonzini
Il 14/06/2013 05:44, Alexander Graf ha scritto: > Legacy 286 protected mode to real mode switching also happens through > the CPU reset PIN, so there certainly is a need to distinguish. That's a separate thing because devices aren't reset at all---not just memory. I have pending patches for that,

Re: [Qemu-devel] [PATCH v3 07/16] qtest: Don't reset on qtest chardev connect

2013-06-14 Thread Anthony Liguori
Markus Armbruster writes: > libqtest's qtest_init() connecting to the qtest socket triggers reset. > This was coded in the hope we could use the same QEMU process for > multiple tests that way. Never used. Injects an extra reset even > when it's not used, and that can mess up tests such as the

Re: [Qemu-devel] [PATCH v3 08/16] boot-order-test: New; covering just PC for now

2013-06-14 Thread Anthony Liguori
Markus Armbruster writes: > Signed-off-by: Markus Armbruster > --- > tests/Makefile | 2 ++ > tests/boot-order-test.c | 68 > + > 2 files changed, 70 insertions(+) > create mode 100644 tests/boot-order-test.c > > diff --git a/tests/Mak

Re: [Qemu-devel] [PATCH v3 09/16] boot-order-test: Add tests for PowerMacs

2013-06-14 Thread Anthony Liguori
Markus Armbruster writes: > From: Andreas Färber > > They set the boot device via fw_cfg, which is then translated to a boot > path of "hd" or "cd" in OpenBIOS. > > Signed-off-by: Andreas Färber > Cc: Alexander Graf > Cc: qemu-...@nongnu.org > Signed-off-by: Markus Armbruster > --- > tests/M

Re: [Qemu-devel] [PATCH v3 10/16] boot-order-test: Cover -boot once in ppc tests

2013-06-14 Thread Anthony Liguori
Markus Armbruster writes: > Cc: Andreas Färber > Cc: Alexander Graf > Cc: qemu-...@nongnu.org > Signed-off-by: Markus Armbruster Reviewed-by: Anthony Liguori Regards, Anthony Liguori > --- > tests/boot-order-test.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/boot-order

Re: [Qemu-devel] [Xen-devel] [PATCH] Remove hardcoded xen-platform device initialization

2013-06-14 Thread Paolo Bonzini
Il 14/06/2013 06:38, Paul Durrant ha scritto: I think the right solution for this is to move towards using the normal "-M pc" machine. libxl can simply use "-M pc -machine accel=xen -device xen-platform-pv"; older versions that use the xenfv machine will still work.

Re: [Qemu-devel] [PATCH] Remove hardcoded xen-platform device initialization

2013-06-14 Thread Paolo Bonzini
Il 14/06/2013 04:50, Paul Durrant ha scritto: >> > This patch is problematic because we can't know for sure the version of >> > upstream QEMU that is going to be used with Xen. >> > If we apply this patch and QEMU 1.5 is going to be used with Xen 4.2, >> > guests won't be able to use PV drivers. >>

Re: [Qemu-devel] [PATCH v3 11/16] boot-order-test: Better separate target-specific and generic parts

2013-06-14 Thread Anthony Liguori
Markus Armbruster writes: > The initial version did just PC. I didn't bother to separate out > generic parts, because I don't like to abstract from a single case. > > Now we have two cases, PC and PowerMac, and I'm about to add two more. > Time to do it right. > > To ease review, this commit cha

Re: [Qemu-devel] [PATCH v3 15/16] boot-order-test: Support fw_cfg in I/O space

2013-06-14 Thread Anthony Liguori
Markus Armbruster writes: > Next commit needs it. > > Cc: Blue Swirl > Signed-off-by: Markus Armbruster > --- > tests/boot-order-test.c | 24 > 1 file changed, 16 insertions(+), 8 deletions(-) > > diff --git a/tests/boot-order-test.c b/tests/boot-order-test.c > index 7

Re: [Qemu-devel] [PATCH v2 03/17] memory: add ref/unref calls

2013-06-14 Thread Paolo Bonzini
Il 14/06/2013 06:09, Alexey Kardashevskiy ha scritto: > And - crash: > > > #0 object_unref (obj=0xa7a7a7a7a7a7a7a7) at > /home/alexey/pcipassthru/qemu-impreza/qom/object.c:691 Dangling pointer. One ref, two unrefs probably. I'm redoing the series according to Peter's request, it could fix it

Re: [Qemu-devel] [PATCH 2/2] Add monitor command mem-nodes

2013-06-14 Thread Eduardo Habkost
On Thu, Jun 13, 2013 at 08:04:00PM -0500, Anthony Liguori wrote: > Eduardo Habkost writes: > > > On Wed, Jun 05, 2013 at 07:57:42AM -0500, Anthony Liguori wrote: > >> Wanlong Gao writes: > >> > >> > Add monitor command mem-nodes to show the huge mapped > >> > memory nodes locations. > >> > > >>

Re: [Qemu-devel] [PATCH] Remove hardcoded xen-platform device initialization

2013-06-14 Thread Paul Durrant
> -Original Message- > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: 14 June 2013 14:53 > To: Paul Durrant > Cc: Stefano Stabellini; qemu-devel@nongnu.org; xen-de...@lists.xen.org > Subject: Re: [PATCH] Remove hardcoded xen-platform device initial

[Qemu-devel] [RFC PATCH v6 1/3] Introduce async_run_on_cpu()

2013-06-14 Thread Chegu Vinod
Introduce an asynchronous version of run_on_cpu() i.e. the caller doesn't have to block till the call back routine finishes execution on the target vcpu. Signed-off-by: Chegu Vinod Reviewed-by: Paolo Bonzini --- cpus.c| 29 + include/qemu-common.h |

[Qemu-devel] [RFC PATCH v6 3/3] Force auto-convegence of live migration

2013-06-14 Thread Chegu Vinod
If a user chooses to turn on the auto-converge migration capability these changes detect the lack of convergence and throttle down the guest. i.e. force the VCPUs out of the guest for some duration and let the migration thread catchup and help converge. Verified the convergence using the following

[Qemu-devel] [RFC PATCH v6 0/3] Throttle-down guest to help with live migration convergence

2013-06-14 Thread Chegu Vinod
Busy enterprise workloads hosted on large sized VM's tend to dirty memory faster than the transfer rate achieved via live guest migration. Despite some good recent improvements (& using dedicated 10Gig NICs between hosts) the live migration does NOT converge. If a user chooses to force convergence

[Qemu-devel] [RFC PATCH v6 2/3] Add 'auto-converge' migration capability

2013-06-14 Thread Chegu Vinod
The auto-converge migration capability allows the user to specify if they choose live migration seqeunce to automatically detect and force convergence. Signed-off-by: Chegu Vinod Reviewed-by: Paolo Bonzini Reviewed-by: Eric Blake --- include/migration/migration.h |2 ++ migration.c

Re: [Qemu-devel] [PATCH v3 0/3] TPM NVRAM persistent storage

2013-06-14 Thread Anthony Liguori
Corey Bryant writes: > This patch series provides persistent storage support that a TPM > can use to store NVRAM data. It uses QEMU's block driver to store > data on a drive image. The libtpms TPM 1.2 backend will be the > initial user of this functionality to store data that must persist > thr

Re: [Qemu-devel] [PATCH v3 15/16] boot-order-test: Support fw_cfg in I/O space

2013-06-14 Thread Andreas Färber
Am 14.06.2013 15:53, schrieb Anthony Liguori: > Markus Armbruster writes: > >> Next commit needs it. >> >> Cc: Blue Swirl >> Signed-off-by: Markus Armbruster >> --- >> tests/boot-order-test.c | 24 >> 1 file changed, 16 insertions(+), 8 deletions(-) >> >> diff --git a/

Re: [Qemu-devel] [Qemu-trivial] [PATCH] cputlb: fix debug logs

2013-06-14 Thread Andreas Färber
Am 05.06.2013 21:51, schrieb Michael Tokarev: > 05.06.2013 16:16, Hervé Poussineau wrote: >> 'pd' variable has been removed in 06ef3525e1f271b6a842781a05eace5cf63b95c2. > > It's been removed indeed, but the value has been replaced by using > a MemoryRegionSection instead. I understand current cod

Re: [Qemu-devel] [RFC 08/13] block: drop bdrv_get_aio_context()

2013-06-14 Thread Paolo Bonzini
Il 14/06/2013 05:48, Stefan Hajnoczi ha scritto: > Associating a BlockDriverState with a single AioContext is not flexible > enough. Once we make BlockDriverState thread-safe, it will be possible > to call bdrv_*() functions from multiple event loops. I'm afraid that this is trading some pain now

Re: [Qemu-devel] [Xen-devel] [PATCH] Remove hardcoded xen-platform device initialization

2013-06-14 Thread Paul Durrant
> -Original Message- > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: 14 June 2013 14:51 > To: Paul Durrant > Cc: Ian Campbell; Stefano Stabellini; qemu-devel@nongnu.org; xen- > de...@lists.xen.org > Subject: Re: [Xen-devel] [PATCH] Remove hardcode

Re: [Qemu-devel] [SeaBIOS] solaris x86 in qemu? [bisected]

2013-06-14 Thread Michael Tokarev
14.06.2013 16:36, Gerd Hoffmann wrote: > Hi, > >> Hmm. Speaking of the splitting. Does the current bios include the >> the tables which were split into separate files? > > Yes, they are in out/ too after building seabios. Use "qemu -L > /path/to/seabios/out" to make sure qemu picks up matchi

Re: [Qemu-devel] [Xen-devel] [BUG 1747]Guest could't find bootable device with memory more than 3600M

2013-06-14 Thread George Dunlap
On 14/06/13 12:34, Ian Campbell wrote: On Fri, 2013-06-14 at 11:53 +0100, George Dunlap wrote: On Thu, Jun 13, 2013 at 6:22 PM, Ian Campbell wrote: On Thu, 2013-06-13 at 17:55 +0100, Stefano Stabellini wrote: We could have a xenstore flag somewhere that enables the old behaviour so that peop

Re: [Qemu-devel] [PATCH 3/5] qcow2: Options to enable discard for freed clusters

2013-06-14 Thread Paolo Bonzini
Il 14/06/2013 04:31, Kevin Wolf ha scritto: >>> > > +s->discard_passthrough[QCOW2_DISCARD_NEVER] = false, >>> > > +s->discard_passthrough[QCOW2_DISCARD_ALWAYS] = true, >>> > > +s->discard_passthrough[QCOW2_DISCARD_REQUEST] = >>> > > +qemu_opt_get_bool(opts, QCOW2_OPT_DISCARD_REQ

Re: [Qemu-devel] [RFC 04/13] virtio-blk: implement BlockDevOps->drain_threads_cb()

2013-06-14 Thread Paolo Bonzini
Il 14/06/2013 05:48, Stefan Hajnoczi ha scritto: > Drain and stop the dataplane thread when bdrv_drain_all() is called. > Note that the thread will be restarted in virtio_blk_handle_output() the > next time the guest kicks the virtqueue. Long term I still think we want to move towards aio_loc

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target-ppc: Change default machine for 64-bit

2013-06-14 Thread Andreas Färber
Am 13.06.2013 15:49, schrieb Alexander Graf: > On 17.05.2013, at 09:42, Andreas Färber wrote: >> Am 17.05.2013 06:25, schrieb David Gibson: >>> Currently, for qemu-system-ppc64, the default machine type is 'mac99'. >>> Since the mac99 machine is not being actively maintained, and shows quite >>> a

Re: [Qemu-devel] [PATCH 3/5] qcow2: Options to enable discard for freed clusters

2013-06-14 Thread Kevin Wolf
Am 14.06.2013 um 16:16 hat Paolo Bonzini geschrieben: > Il 14/06/2013 04:31, Kevin Wolf ha scritto: > >>> > > +s->discard_passthrough[QCOW2_DISCARD_NEVER] = false, > >>> > > +s->discard_passthrough[QCOW2_DISCARD_ALWAYS] = true, > >>> > > +s->discard_passthrough[QCOW2_DISCARD_REQUEST] =

Re: [Qemu-devel] [Xen-devel] [BUG 1747]Guest could't find bootable device with memory more than 3600M

2013-06-14 Thread George Dunlap
On 14/06/13 15:14, George Dunlap wrote: On 14/06/13 12:34, Ian Campbell wrote: On Fri, 2013-06-14 at 11:53 +0100, George Dunlap wrote: On Thu, Jun 13, 2013 at 6:22 PM, Ian Campbell wrote: On Thu, 2013-06-13 at 17:55 +0100, Stefano Stabellini wrote: We could have a xenstore flag somewhere tha

[Qemu-devel] [PULL 10/10] ppc: Remove CONFIG_FDT conditionals

2013-06-14 Thread Peter Maydell
Now that we know we're compiling with libfdt we can remove the CONFIG_FDT conditionals. Signed-off-by: Peter Maydell Reviewed-by: Edgar E. Iglesias Reviewed-by: Peter Crosthwaite Tested-by: Edgar E. Iglesias Message-id: 1369409217-7553-5-git-send-email-peter.mayd...@linaro.org --- default-con

[Qemu-devel] [PULL 09/10] microblaze: Remove CONFIG_FDT conditionals

2013-06-14 Thread Peter Maydell
Now that we know we're compiling with libfdt we can remove the CONFIG_FDT conditionals. Signed-off-by: Peter Maydell Reviewed-by: Edgar E. Iglesias Reviewed-by: Peter Crosthwaite Tested-by: Edgar E. Iglesias Message-id: 1369409217-7553-4-git-send-email-peter.mayd...@linaro.org --- hw/microbla

[Qemu-devel] [PULL 07/10] configure: Require libfdt for arm, ppc, microblaze softmmu targets

2013-06-14 Thread Peter Maydell
A number of our softmmu targets (PPC, ARM, Microblaze) now more or less require flattened device tree support for various board models to work correctly. Make libfdt mandatory if the target list includes these, rather than building unhelpful half-functional binaries. Signed-off-by: Peter Maydell

[Qemu-devel] [PULL 02/10] build: rename TARGET_ARCH2 to TARGET_NAME

2013-06-14 Thread Peter Maydell
From: Paolo Bonzini Do not introduce any new use yet. Signed-off-by: Paolo Bonzini Message-id: 1370349928-20419-3-git-send-email-pbonz...@redhat.com Signed-off-by: Peter Maydell --- Makefile.target |6 +++--- configure | 38 +++--- scrip

[Qemu-devel] [PULL 01/10] Add a stp file for usage from build directory

2013-06-14 Thread Peter Maydell
From: Alon Levy For systemtap the location of the process being tapped is crucial, as a result the existing stp file requires installation for use. There are now two files: $(TARGET_DIR)/$(QEMU_PROG).stp-installed: copied to $(tapdir)/$(QEMU_PROG).stp $(TARGET_DIR)/$(QEMU_PROG).stp: pointing to

[Qemu-devel] [PULL 00/10] configury queue

2013-06-14 Thread Peter Maydell
Hi; this is a pullrequest for a set of patches to the configure machinery: * Paolo's cleanups of TARGET_ARCH/TARGET_NAME * Peter C's fix for the configure fdt probe against new libfdt * my series making libfdt mandatory on arm/ppc/microblaze The patches have all been on the list and reviewed; t

[Qemu-devel] [PULL 08/10] arm: Remove CONFIG_FDT conditionals

2013-06-14 Thread Peter Maydell
Now that we know we're compiling with libfdt, we can remove the CONFIG_FDT conditionals. Signed-off-by: Peter Maydell Reviewed-by: Edgar E. Iglesias Reviewed-by: Peter Crosthwaite Tested-by: Edgar E. Iglesias Message-id: 1369409217-7553-3-git-send-email-peter.mayd...@linaro.org --- hw/arm/boo

[Qemu-devel] [PULL 03/10] build: do not use TARGET_ARCH

2013-06-14 Thread Peter Maydell
From: Paolo Bonzini TARGET_ARCH is generally wrong to use, there are better variables provided in config-target.mak. The right one is usually TARGET_NAME (previously TARGET_ARCH2), but for bsd-user we can also use TARGET_ABI_DIR for consistency with linux-user. Signed-off-by: Paolo Bonzini Mes

Re: [Qemu-devel] [Xen-devel] [PATCH] Remove hardcoded xen-platform device initialization

2013-06-14 Thread Paolo Bonzini
Il 14/06/2013 10:11, Paul Durrant ha scritto: > I think we're still going to need -M xenpv, I think; it's quite > distinct from pc. Of course! Even more: "-M xenpv" should be reused on ARM. > I guess we could use -M pc for HVM and gate the > accel code as you suggest but, if that's the way we're

Re: [Qemu-devel] [PATCH v2] kvm/openpic: in-kernel mpic support

2013-06-14 Thread Andreas Färber
Am 13.06.2013 19:32, schrieb Scott Wood: > On 06/13/2013 06:01:49 AM, Andreas Färber wrote: >> Am 12.06.2013 22:32, schrieb Scott Wood: >> > +typedef struct KVMOpenPICState { >> > +SysBusDevice busdev; >> >> SysBusDevice parent_obj; please! >> >> http://wiki.qemu.org/QOMConventions > > The wor

Re: [Qemu-devel] [PATCH 3/5] qcow2: Options to enable discard for freed clusters

2013-06-14 Thread Paolo Bonzini
Il 14/06/2013 10:31, Kevin Wolf ha scritto: >> It looks like QCOW2_OPT_DISCARD_OTHER is a rare case, so I don't mind >> leaving it as default to false. It won't waste more than a few clusters. > > Yes, it's generally relatively rare, like growing L1 or refcount table. > There is one case where it

Re: [Qemu-devel] [PULL 00/10] configury queue

2013-06-14 Thread Paolo Bonzini
Il 14/06/2013 10:53, Peter Maydell ha scritto: > [NB: I don't know if we get enough build-machinery patches to make > it worth having a permanent subtree/submaintainer for them; it's > merely that at the moment there are enough patches I personally > care about that I felt like curating them ;-)]

[Qemu-devel] [PULL 05/10] build: drop TARGET_TYPE

2013-06-14 Thread Peter Maydell
From: Paolo Bonzini Just use the TARGET_NAME free string. Signed-off-by: Paolo Bonzini Reviewed-by: Eric Blake Message-id: 1370349928-20419-6-git-send-email-pbonz...@redhat.com Signed-off-by: Peter Maydell --- arch_init.c |2 +- configure|1 - qapi-schema.json | 18 +--

Re: [Qemu-devel] [PATCH v2 03/17] memory: add ref/unref calls

2013-06-14 Thread Alexey Kardashevskiy
On 06/14/2013 11:56 PM, Paolo Bonzini wrote: > Il 14/06/2013 06:09, Alexey Kardashevskiy ha scritto: >> And - crash: >> >> >> #0 object_unref (obj=0xa7a7a7a7a7a7a7a7) at >> /home/alexey/pcipassthru/qemu-impreza/qom/object.c:691 > > Dangling pointer. One ref, two unrefs probably. No, subpages (a

Re: [Qemu-devel] [PATCH v3 0/3] TPM NVRAM persistent storage

2013-06-14 Thread Corey Bryant
On 06/14/2013 10:01 AM, Anthony Liguori wrote: Corey Bryant writes: This patch series provides persistent storage support that a TPM can use to store NVRAM data. It uses QEMU's block driver to store data on a drive image. The libtpms TPM 1.2 backend will be the initial user of this functio

Re: [Qemu-devel] [Xen-devel] [PATCH] Remove hardcoded xen-platform device initialization

2013-06-14 Thread Paul Durrant
> -Original Message- > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: 14 June 2013 15:58 > To: Paul Durrant > Cc: Ian Campbell; Stefano Stabellini; qemu-devel@nongnu.org; xen- > de...@lists.xen.org > Subject: Re: [Xen-devel] [PATCH] Remove hardcode

[Qemu-devel] [PULL 04/10] main: use TARGET_ARCH only for the target-specific #define

2013-06-14 Thread Peter Maydell
From: Paolo Bonzini Everything else needs to match the executable name, which is TARGET_NAME. Before: $ sh4eb-linux-user/qemu-sh4eb --help usage: qemu-sh4 [options] program [arguments...] Linux CPU emulator (compiled for sh4 emulation) After: $ sh4eb-linux-user/qemu-sh4eb --help

[Qemu-devel] [PULL 06/10] configure: dtc: Probe for libfdt_env.h

2013-06-14 Thread Peter Maydell
From: Peter Crosthwaite Currently QEMU provides a local clone of the file libfdt_env.h in /include. This file is supposed to come with the libfdt package and is only needed for broken installs of libfdt. Now that we have submodule dtc, just ignore these broken installs and prompt for the dtc subm

[Qemu-devel] [Bug 829455] Re: user mode network stack - hostfwd not working with restrict=y

2013-06-14 Thread Axel Hübl
Did you guys merge back the fix in: http://lists.gnu.org/archive/html/qemu-devel/2011-11/msg01519.html ? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/829455 Title: user mode network stack - hostf

Re: [Qemu-devel] [PATCH v3 0/3] TPM NVRAM persistent storage

2013-06-14 Thread Anthony Liguori
Corey Bryant writes: > On 06/14/2013 10:01 AM, Anthony Liguori wrote: >> Corey Bryant writes: >> >>> This patch series provides persistent storage support that a TPM >>> can use to store NVRAM data. It uses QEMU's block driver to store >>> data on a drive image. The libtpms TPM 1.2 backend wil

<    1   2   3   >