Re: [Qemu-devel] [PATCH 0/9 v3] Make monitor command 'dump-guest-memory' dump in kdump-compressed format

2013-05-22 Thread Qiao Nuohan
Hi eric and luiz, Does you have some comments on this version? -- Regards Qiao Nuohan

Re: [Qemu-devel] [PATCHv2 RFC] makefile: detect corrupted elf files

2013-05-22 Thread Michael S. Tsirkin
On Wed, May 22, 2013 at 08:32:52AM +0200, Stefan Weil wrote: > Am 22.05.2013 00:07, schrieb Michael S. Tsirkin: > > Once in a while make gets killed and doesn't > > clean up partial object files after it. > > Result is nasty errors from link. > > This hack checks object is well formed before linkin

Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files

2013-05-22 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Tue, May 21, 2013 at 11:01:05PM +0100, Peter Maydell wrote: >> On 21 May 2013 22:46, Michael S. Tsirkin wrote: >> > Once in a while make gets killed and doesn't >> > clean up partial object files after it. >> > Result is nasty errors from link. >> > This hack ch

Re: [Qemu-devel] [PATCH v1 1/1] configure: Probe for libfdt_env.h

2013-05-22 Thread Edgar E. Iglesias
On Wed, May 22, 2013 at 11:50:22AM +1000, peter.crosthwa...@xilinx.com wrote: > From: Peter Crosthwaite > > Currently QEMU provides a local clone of the file libfdt_env.h in > /include. This file is supposed to come with the libfdt package and is > only needed for broken installs of libfdt. Unfor

[Qemu-devel] [PATCH v3] tests: set MALLOC_PERTURB_ to expose memory bugs

2013-05-22 Thread Stefan Hajnoczi
glibc wipes malloc(3) memory when the MALLOC_PERTURB_ environment variable is set. The value of the environment variable determines the bit pattern used to wipe memory. For more information, see http://udrepper.livejournal.com/11429.html. Set MALLOC_PERTURB_ for gtester and qemu-iotests. Note w

Re: [Qemu-devel] [PATCH] wdt_i6300esb: fix vmstate versioning

2013-05-22 Thread Laszlo Ersek
On 05/22/13 00:32, Michael Roth wrote: > When this VMSD was introduced it's version fields were set to > sizeof(I6300State), making them essentially random from build to build, > version to version. > > To fix this, we lock in a high version id and low minimum version id to > support old->new migr

Re: [Qemu-devel] [PATCH v1 1/1] configure: Probe for libfdt_env.h

2013-05-22 Thread Peter Maydell
On 22 May 2013 08:47, Edgar E. Iglesias wrote: > On Wed, May 22, 2013 at 11:50:22AM +1000, peter.crosthwa...@xilinx.com wrote: >> From: Peter Crosthwaite >> Currently QEMU provides a local clone of the file libfdt_env.h in >> /include. This file is supposed to come with the libfdt package and is

[Qemu-devel] [Bug 1182344] Re: ARM: invalid code execution after subs instruction

2013-05-22 Thread Sebastian Huber
If I replace the idle thread with this code void *_CPU_Thread_Idle_body( uintptr_t ignored ) { while ( true ) { __asm__ volatile ("wfi"); } } void foobarblub(void) { __asm__ volatile ("nop; nop; nop; nop; nop"); bsp_reset(); } then I get also an invalid execution sequence: 0x0001

Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files

2013-05-22 Thread Michael S. Tsirkin
On Wed, May 22, 2013 at 09:44:04AM +0200, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Tue, May 21, 2013 at 11:01:05PM +0100, Peter Maydell wrote: > >> On 21 May 2013 22:46, Michael S. Tsirkin wrote: > >> > Once in a while make gets killed and doesn't > >> > clean up partial

Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files

2013-05-22 Thread Peter Maydell
On 22 May 2013 09:37, Michael S. Tsirkin wrote: > It's my fault for running -rc kernels all the time I guess, I get > crashes kind of often, and losing more time on make clean > on top of reboot annoys me. > But we actually could make it robust, even against OS crash. Output to a > temporary file

Re: [Qemu-devel] segfault in aio_bh_poll async.c:80 WAS: Re: kvm process disappears

2013-05-22 Thread Paolo Bonzini
Il 22/05/2013 08:26, Stefan Priebe - Profihost AG ha scritto: >> Hi, >> >> as i can't reproduce no ;-( i just saw the kernel segfault message and >> used addr2line and a qemu dbg package to get the code line. > > I've now seen this again for two or three times. It always happens > when we do an fs

Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files

2013-05-22 Thread Paolo Bonzini
Il 22/05/2013 10:38, Peter Maydell ha scritto: > On 22 May 2013 09:37, Michael S. Tsirkin wrote: >> It's my fault for running -rc kernels all the time I guess, I get >> crashes kind of often, and losing more time on make clean >> on top of reboot annoys me. >> But we actually could make it robust,

Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files

2013-05-22 Thread Michael S. Tsirkin
On Wed, May 22, 2013 at 09:38:39AM +0100, Peter Maydell wrote: > On 22 May 2013 09:37, Michael S. Tsirkin wrote: > > It's my fault for running -rc kernels all the time I guess, I get > > crashes kind of often, and losing more time on make clean > > on top of reboot annoys me. > > But we actually c

Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files

2013-05-22 Thread Michael S. Tsirkin
On Wed, May 22, 2013 at 10:43:45AM +0200, Paolo Bonzini wrote: > Il 22/05/2013 10:38, Peter Maydell ha scritto: > > On 22 May 2013 09:37, Michael S. Tsirkin wrote: > >> It's my fault for running -rc kernels all the time I guess, I get > >> crashes kind of often, and losing more time on make clean

[Qemu-devel] [Bug 1182344] Re: ARM: invalid code execution after subs instruction

2013-05-22 Thread Sebastian Huber
If I use this idle thread volatile int sdlkfj = 0; void *_CPU_Thread_Idle_body( uintptr_t ignored ) { while ( true ) { while ( sdlkfj == 0 ) { __asm__ volatile ("wfi; nop; nop; nop"); } __asm__ volatile ("wfi; nop; nop; nop"); } } then the test program seems to run forev

Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files

2013-05-22 Thread Paolo Bonzini
Il 22/05/2013 10:52, Michael S. Tsirkin ha scritto: > The fix is simple here: don't use ccache. I don't. > > In fact, from what I saw people use ccache to work around makefile bugs, > so they can do make clean; make and have it finish quickly. > > Any other examples? Testing configure patches s

Re: [Qemu-devel] [PATCH 00/30] Introduction of IOMMUs into the memory API

2013-05-22 Thread Paolo Bonzini
Il 22/05/2013 04:30, Alexey Kardashevskiy ha scritto: > On 05/21/2013 08:57 PM, Paolo Bonzini wrote: >> This is part 1 of the memory API updates for 1.6. (Part 2 is the >> introduction of get/set_owner, part 3 is the introduction of the >> RCU-style flatview). >> >> Compared to the first submissio

[Qemu-devel] Fwd: [Qemu-stable] connectivity problem with Windows 7 + heavy network-traffic

2013-05-22 Thread Oliver Francke
Hi Stefan, thanks for your attention. See all infos below including complete command-line. Thnx, Oliver. Original Message Subject: [Qemu-stable] connectivity problem with Windows 7 + heavy network-traffic Date: Wed, 08 May 2013 10:04:19 +0200 From: Oliver Francke T

Re: [Qemu-devel] [PATCH v4 00/10] curl: fix curl read

2013-05-22 Thread Fam Zheng
Rich, Please try this version with libguestfs. Thanks. (missing CC due to improper git send-email config) On Wed, 05/22 11:16, Fam Zheng wrote: > CURL library API has changed, the current curl driver is not working. > This patch rewrites the use of API as well as the structure of internal > sta

Re: [Qemu-devel] [PATCH v4 2/8] block: add basic backup support to block driver

2013-05-22 Thread Kevin Wolf
Am 16.05.2013 um 10:36 hat Stefan Hajnoczi geschrieben: > From: Dietmar Maurer > > backup_start() creates a block job that copies a point-in-time snapshot > of a block device to a target block device. > > We call backup_do_cow() for each write during backup. That function > reads the original da

Re: [Qemu-devel] [PATCH] kvm: add detail error message when fail to add ioeventfd

2013-05-22 Thread Stefan Hajnoczi
On Wed, May 22, 2013 at 12:57:35PM +0800, Amos Kong wrote: > I try to hotplug 28 * 8 multiple-function devices to guest with > old host kernel, ioeventfds in host kernel will be exhausted, then > qemu fails to allocate ioeventfds for blk/nic devices. > > It's better to add detail error here. > >

Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files

2013-05-22 Thread Michael S. Tsirkin
On Wed, May 22, 2013 at 11:22:52AM +0200, Paolo Bonzini wrote: > Il 22/05/2013 10:52, Michael S. Tsirkin ha scritto: > > The fix is simple here: don't use ccache. I don't. > > > > In fact, from what I saw people use ccache to work around makefile bugs, > > so they can do make clean; make and have

Re: [Qemu-devel] [PATCH v4 00/10] curl: fix curl read

2013-05-22 Thread Richard W.M. Jones
On Wed, May 22, 2013 at 11:16:40AM +0800, Fam Zheng wrote: > Changes from v3: > 01, 06, 07: Add QLIST_INIT in qemu_open to initialize each list. > 07: Move clean up for s->acbs from later patch to here. Use qemu_aio_relase > instead of g_free on acb. > Fix use-after-free bug. [Rich] Thi

Re: [Qemu-devel] 'qemu-nbd' explicit flush

2013-05-22 Thread Stefan Hajnoczi
On Tue, May 21, 2013 at 08:01:10PM +, Mark Trumpold wrote: > Linux kernel 3.3.1 with Qemu patch to enable kernel flushing: > http://thread.gmane.org/gmane.linux.drivers.nbd.general/1108 Did you check that the kernel is sending NBD_FLUSH commands? You can use tcpdump and then check

Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files

2013-05-22 Thread Stefan Hajnoczi
On Wed, May 22, 2013 at 12:46:45AM +0300, Michael S. Tsirkin wrote: > Once in a while make gets killed and doesn't > clean up partial object files after it. > Result is nasty errors from link. > This hack checks object is well formed before linking, > and rebuilds it if not. > > Signed-off-by: Mic

Re: [Qemu-devel] [PATCH v4 3/8] block: add drive-backup QMP command

2013-05-22 Thread Kevin Wolf
Am 16.05.2013 um 10:36 hat Stefan Hajnoczi geschrieben: > @drive-backup > > Start a point-in-time copy of a block device to a new destination. The > status of ongoing drive-backup operations can be checked with > query-block-jobs where the BlockJobInfo.type field has the value 'backup'. > The ope

Re: [Qemu-devel] [PATCH v4 2/8] block: add basic backup support to block driver

2013-05-22 Thread Paolo Bonzini
Il 22/05/2013 11:38, Kevin Wolf ha scritto: >> + >> +DPRINTF("brdv_co_backup_cow done C%" PRId64 "\n", start); >> +} >> + >> +out: >> +if (bounce_buffer) { >> +qemu_vfree(bounce_buffer); >> +} >> + >> +cow_request_end(&cow_request); >> + >> +qemu_co_rwlock_unlock

Re: [Qemu-devel] [PATCH v4 2/8] block: add basic backup support to block driver

2013-05-22 Thread Kevin Wolf
Am 22.05.2013 um 11:54 hat Paolo Bonzini geschrieben: > Il 22/05/2013 11:38, Kevin Wolf ha scritto: > >> + > >> +DPRINTF("brdv_co_backup_cow done C%" PRId64 "\n", start); > >> +} > >> + > >> +out: > >> +if (bounce_buffer) { > >> +qemu_vfree(bounce_buffer); > >> +} > >> +

Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files

2013-05-22 Thread Michael S. Tsirkin
On Wed, May 22, 2013 at 11:48:54AM +0200, Stefan Hajnoczi wrote: > On Wed, May 22, 2013 at 12:46:45AM +0300, Michael S. Tsirkin wrote: > > Once in a while make gets killed and doesn't > > clean up partial object files after it. > > Result is nasty errors from link. > > This hack checks object is we

[Qemu-devel] [RFC 0/2] Break the debug session on sw errors

2013-05-22 Thread edgar . iglesias
From: "Edgar E. Iglesias" Hi, I've been using variations of this scheme to aid with debugging guest errors that QEMU can detect. I'm posting this RFC to see if there is interest to get something like this upstreamed. Patch 1 adds the mechanism to break the debugger session from within emulation

[Qemu-devel] [RFC 1/2] gdbstub: Add gdbserver_break()

2013-05-22 Thread edgar . iglesias
From: "Edgar E. Iglesias" Makes it possible to request interruption of the GDB debug session. Signed-off-by: Edgar E. Iglesias --- gdbstub.c | 68 ++-- include/exec/gdbstub.h |2 ++ 2 files changed, 56 insertions(+), 14 deletions(-

[Qemu-devel] [RFC 2/2] qemu-log: Interrupt the GDB session on guest-errors

2013-05-22 Thread edgar . iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- qemu-log.c | 20 1 file changed, 20 insertions(+) diff --git a/qemu-log.c b/qemu-log.c index 797f2af..693bc94 100644 --- a/qemu-log.c +++ b/qemu-log.c @@ -19,6 +19,7 @@ #include "qemu-common.h" #include "

Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files

2013-05-22 Thread Paolo Bonzini
Il 22/05/2013 11:42, Michael S. Tsirkin ha scritto: > On Wed, May 22, 2013 at 11:22:52AM +0200, Paolo Bonzini wrote: >> Il 22/05/2013 10:52, Michael S. Tsirkin ha scritto: >>> The fix is simple here: don't use ccache. I don't. >>> >>> In fact, from what I saw people use ccache to work around makef

Re: [Qemu-devel] [RFC 2/2] qemu-log: Interrupt the GDB session on guest-errors

2013-05-22 Thread Peter Maydell
On 22 May 2013 11:38, wrote: > From: "Edgar E. Iglesias" > @@ -45,6 +46,25 @@ void qemu_log_mask(int mask, const char *fmt, ...) > vfprintf(qemu_logfile, fmt, ap); > } > va_end(ap); > + > +/* > + * Break the GDB session (if connected) so that the user can inspect the >

Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files

2013-05-22 Thread Michael S. Tsirkin
On Wed, May 22, 2013 at 12:40:23PM +0200, Paolo Bonzini wrote: > Il 22/05/2013 11:42, Michael S. Tsirkin ha scritto: > > On Wed, May 22, 2013 at 11:22:52AM +0200, Paolo Bonzini wrote: > >> Il 22/05/2013 10:52, Michael S. Tsirkin ha scritto: > >>> The fix is simple here: don't use ccache. I don't.

Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files

2013-05-22 Thread Paolo Bonzini
Il 22/05/2013 12:50, Michael S. Tsirkin ha scritto: > On Wed, May 22, 2013 at 12:40:23PM +0200, Paolo Bonzini wrote: >> Il 22/05/2013 11:42, Michael S. Tsirkin ha scritto: >>> On Wed, May 22, 2013 at 11:22:52AM +0200, Paolo Bonzini wrote: Il 22/05/2013 10:52, Michael S. Tsirkin ha scritto: >>>

Re: [Qemu-devel] [PATCH v4 00/10] curl: fix curl read

2013-05-22 Thread Paolo Bonzini
Il 22/05/2013 11:44, Richard W.M. Jones ha scritto: > On Wed, May 22, 2013 at 11:16:40AM +0800, Fam Zheng wrote: >> Changes from v3: >> 01, 06, 07: Add QLIST_INIT in qemu_open to initialize each list. >> 07: Move clean up for s->acbs from later patch to here. Use >> qemu_aio_relase instead of

Re: [Qemu-devel] 'qemu-nbd' explicit flush

2013-05-22 Thread Paolo Bonzini
Il 22/05/2013 11:47, Stefan Hajnoczi ha scritto: > On Tue, May 21, 2013 at 08:01:10PM +, Mark Trumpold wrote: >> Linux kernel 3.3.1 with Qemu patch to enable kernel flushing: >> http://thread.gmane.org/gmane.linux.drivers.nbd.general/1108 > > Did you check that the kernel is sendin

Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files

2013-05-22 Thread Michael S. Tsirkin
On Wed, May 22, 2013 at 12:51:42PM +0200, Paolo Bonzini wrote: > Il 22/05/2013 12:50, Michael S. Tsirkin ha scritto: > > On Wed, May 22, 2013 at 12:40:23PM +0200, Paolo Bonzini wrote: > >> Il 22/05/2013 11:42, Michael S. Tsirkin ha scritto: > >>> On Wed, May 22, 2013 at 11:22:52AM +0200, Paolo Bonz

Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files

2013-05-22 Thread Paolo Bonzini
Il 22/05/2013 13:09, Michael S. Tsirkin ha scritto: > > Usually I do the same---I just do slightly more thorough testing for > > configure patches. > > I've no idea what happens with ccache on a crash by the way. > It's possible that it's careful to do renames in order to not leave > corrupted out

Re: [Qemu-devel] [PATCH v4 00/10] curl: fix curl read

2013-05-22 Thread Richard W.M. Jones
On Wed, May 22, 2013 at 01:04:51PM +0200, Paolo Bonzini wrote: > Something is trying to write, but there's no write operation defined for > CURL. > > I guess curl (and other backends too) should reject being opened for > write. Alternatively, block.c could do that for them. Yes, I'd just got to

[Qemu-devel] [PATCH] hw/9pfs: Use O_NOFOLLOW when opening files on server

2013-05-22 Thread Aneesh Kumar K.V
From: "Aneesh Kumar K.V" 9p server should never follow a symlink. So use O_NOFOLLOW with all open syscall Tested-by: "M. Mohan Kumar" Signed-off-by: Aneesh Kumar K.V --- hw/9pfs/virtio-9p-handle.c | 2 +- hw/9pfs/virtio-9p-local.c | 48 +++--- 2 files

Re: [Qemu-devel] [PATCH v4 0/8] block: drive-backup live backup command

2013-05-22 Thread Kevin Wolf
Am 16.05.2013 um 10:36 hat Stefan Hajnoczi geschrieben: > Note: These patches apply to my block-next tree. You can also grab the code > from git here: > git://github.com/stefanha/qemu.git block-backup-core > > This series adds a new QMP command, drive-backup, which takes a point-in-time > snapsho

Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files

2013-05-22 Thread Michael S. Tsirkin
On Wed, May 22, 2013 at 01:12:15PM +0200, Paolo Bonzini wrote: > Il 22/05/2013 13:09, Michael S. Tsirkin ha scritto: > > > Usually I do the same---I just do slightly more thorough testing for > > > configure patches. > > > > I've no idea what happens with ccache on a crash by the way. > > It's pos

[Qemu-devel] [Bug 1182344] Re: ARM: invalid code execution after subs instruction

2013-05-22 Thread Peter Maydell
I did a bit of digging, and the reason that QEMU is not taking the branch is that when control returns from the exception handler the CPSR ITSTATE fields are non-zero. This means that the branch instruction is UNPREDICTABLE (and therefore falling through is architecturally valid behaviour for QEMU

Re: [Qemu-devel] [PATCH v4 4/8] qemu-iotests: add 055 drive-backup test case

2013-05-22 Thread Kevin Wolf
Am 16.05.2013 um 10:36 hat Stefan Hajnoczi geschrieben: > Testing drive-backup is similar to image streaming and drive mirroring. > This test case is based on 041. > > Signed-off-by: Stefan Hajnoczi > --- > tests/qemu-iotests/055 | 230 > + > test

Re: [Qemu-devel] [PATCH v3] tests: set MALLOC_PERTURB_ to expose memory bugs

2013-05-22 Thread Lucas Meneghel Rodrigues
On 22/05/13 05:16 AM, Stefan Hajnoczi wrote: glibc wipes malloc(3) memory when the MALLOC_PERTURB_ environment variable is set. The value of the environment variable determines the bit pattern used to wipe memory. For more information, see http://udrepper.livejournal.com/11429.html. Set MALLOC

Re: [Qemu-devel] [PATCH 7/7] block: dump to monitor for bdrv_snapshot_dump() and bdrv_image_info_dump()

2013-05-22 Thread Luiz Capitulino
On Wed, 22 May 2013 10:09:19 +0800 Wenchao Xia wrote: > 于 2013-5-20 10:39, Wenchao Xia 写道: > > 于 2013-5-17 20:30, Luiz Capitulino 写道: > >> On Fri, 17 May 2013 11:30:31 +0800 > >> Wenchao Xia wrote: > >> > >>> 于 2013-5-16 20:17, Luiz Capitulino 写道: > On Thu, 16 May 2013 10:22:09 +0800 >

Re: [Qemu-devel] segfault in aio_bh_poll async.c:80 WAS: Re: kvm process disappears

2013-05-22 Thread Stefan Priebe - Profihost AG
Am 22.05.2013 um 10:41 schrieb Paolo Bonzini : > Il 22/05/2013 08:26, Stefan Priebe - Profihost AG ha scritto: >>> Hi, >>> >>> as i can't reproduce no ;-( i just saw the kernel segfault message and >>> used addr2line and a qemu dbg package to get the code line. >> >> I've now seen this again for

Re: [Qemu-devel] [PATCH 0/9 v3] Make monitor command 'dump-guest-memory' dump in kdump-compressed format

2013-05-22 Thread Luiz Capitulino
On Wed, 22 May 2013 14:37:37 +0800 Qiao Nuohan wrote: > Hi eric and luiz, > > Does you have some comments on this version? I haven't reviewed it yet, but we need introspection support before merging this.

Re: [Qemu-devel] [PATCH] Fix mask of pte index

2013-05-22 Thread Andreas Färber
Am 22.05.2013 03:25, schrieb Qiao Nuohan: > On 05/22/2013 09:21 AM, Qiao Nuohan wrote: >> Function walk_pte needs pte index to calculate virtual address. However, >> pte >> index of PAE paging or IA-32e paging is 9 bit, so the mask should be >> 0x1ff. >> >> Signed-off-by: Qiao Nuohan > > Reviewed

[Qemu-devel] [PATCH] rtl8139: flush queued packets when RxBufPtr is written

2013-05-22 Thread Stefan Hajnoczi
Net queues support efficient "receive disable". For example, tap's file descriptor will not be polled while its peer has receive disabled. This saves CPU cycles for needlessly copying and then dropping packets which the peer cannot receive. rtl8139 is missing the qemu_flush_queued_packets() call

Re: [Qemu-devel] Fwd: [Qemu-stable] connectivity problem with Windows 7 + heavy network-traffic

2013-05-22 Thread Stefan Hajnoczi
On Wed, May 22, 2013 at 11:27 AM, Oliver Francke wrote: > Hi Stefan, > > thanks for your attention. See all infos below including complete > command-line. > Hi Oliver, I just sent a fix for qemu.git/master. If you need to backport it, replace qemu_get_queue(s->nic) with &s->nic->nc. Please let

Re: [Qemu-devel] [PATCH] rtl8139: flush queued packets when RxBufPtr is written

2013-05-22 Thread Andreas Färber
Am 22.05.2013 14:50, schrieb Stefan Hajnoczi: > Net queues support efficient "receive disable". For example, tap's file > descriptor will not be polled while its peer has receive disabled. This > saves CPU cycles for needlessly copying and then dropping packets which > the peer cannot receive. >

[Qemu-devel] [PATCH qom-cpu 1/4] memory_mapping: Use hwaddr type for MemoryMapping virt_addr field

2013-05-22 Thread Andreas Färber
The memory mapping API uses hwaddr, so use it in the struct, too. This avoids a header dependency on target_ulong type. Cc: Wen Congyang Signed-off-by: Andreas Färber --- include/sysemu/memory_mapping.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/sysemu/memory_ma

[Qemu-devel] [PATCH qom-cpu 0/4] memory_mapping: Clean up stubs

2013-05-22 Thread Andreas Färber
Hello, This mini-series cleans up the remaining guest-memory-dump related -stub.c file in making it compile-once. The next step would then be to turn some of the per-target functions into CPUState hooks. Regards, Andreas Cc: Wen Congyang Cc: Qiao Nuohan Cc: Jens Freimann Cc: Vincent Rabin C

[Qemu-devel] [PATCH qom-cpu 3/4] memory_mapping: Change cpu_paging_enabled() argument to CPUState

2013-05-22 Thread Andreas Färber
Removes the last occurrence of CPUArchState from sysemu/memory_mapping.h. Signed-off-by: Andreas Färber --- include/sysemu/memory_mapping.h | 2 +- memory_mapping.c | 2 +- target-i386/arch_memory_mapping.c | 7 +-- 3 files changed, 7 insertions(+), 4 deletions(-) diff --

[Qemu-devel] [PATCH qom-cpu 2/4] memory_mapping: Change cpu_get_memory_mapping() argument to CPUState

2013-05-22 Thread Andreas Färber
Eliminates an occurrence of CPUArchState from sysemu/memory_mapping.h. Signed-off-by: Andreas Färber --- include/sysemu/memory_mapping.h | 2 +- memory_mapping.c | 2 +- target-i386/arch_memory_mapping.c | 5 - 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a

[Qemu-devel] [PATCH qom-cpu 4/4] memory_mapping: Move stubs to libqemustub.a

2013-05-22 Thread Andreas Färber
Allows us to drop CONFIG_NO_GET_MEMORY_MAPPING with its indirect dependency on CONFIG_HAVE_GET_MEMORY_MAPPING in Makefile.target. Signed-off-by: Andreas Färber --- Makefile.target | 2 -- stubs/Makefile.objs | 1 + memory_mapping-stub.c

Re: [Qemu-devel] [PATCH] qapi-schema.json: Reformat TargetType enum to one-per-line

2013-05-22 Thread Anthony Liguori
Peter Maydell writes: > Reformat the qapi-schema TargetType enumeration so that it has just > one target architecture name per line. This allows patches for > adding new targets to just add a single line, rather than having > to reformat most of the list (resulting in a hard-to-check diff). > > S

Re: [Qemu-devel] [PATCH] qapi-schema.json: Reformat TargetType enum to one-per-line

2013-05-22 Thread Anthony Liguori
Paolo Bonzini writes: > Il 20/05/2013 18:21, Peter Maydell ha scritto: >> Reformat the qapi-schema TargetType enumeration so that it has just >> one target architecture name per line. This allows patches for >> adding new targets to just add a single line, rather than having >> to reformat most o

[Qemu-devel] [PATCH] configure: remove confusing file manipulation

2013-05-22 Thread Ed Maste
The configure script had some code to manipulate config-host.ld~ (i.e., a common backup filename), comparing it with the newly-generated file. I believe the sense of the comparison was backwards. Since it seemed to serve little purpose anyway, remove it to avoid any confusion. Signed-off-by: Ed M

Re: [Qemu-devel] [PATCH] rtl8139: flush queued packets when RxBufPtr is written

2013-05-22 Thread Stefan Hajnoczi
On Wed, May 22, 2013 at 2:53 PM, Andreas Färber wrote: > Am 22.05.2013 14:50, schrieb Stefan Hajnoczi: >> Net queues support efficient "receive disable". For example, tap's file >> descriptor will not be polled while its peer has receive disabled. This >> saves CPU cycles for needlessly copying

Re: [Qemu-devel] [PATCH v3 2/8] block: add basic backup support to block driver

2013-05-22 Thread Stefan Hajnoczi
On Tue, May 21, 2013 at 06:46:39PM +0200, Paolo Bonzini wrote: > Il 21/05/2013 18:26, Dietmar Maurer ha scritto: > >> Hmm, right. But do we need the bitmap at all? We can just use > >> > bdrv_is_allocated like bdrv_co_do_readv does. > > Does that works with a nbd driver? > > Ah, right. That's t

Re: [Qemu-devel] [PATCH arm-devs v1 2/5] sd/sdhci.c: Only reset data_count on new commands

2013-05-22 Thread Igor Mitsyanko
On 05/21/2013 10:50 AM, peter.crosthwa...@xilinx.com wrote: From: Peter Crosthwaite The data_count variable was being reset on every transfer, including DMA transfer resumptions. This is incorrect, it should only be set on a new command. Manifests as a bug when using ADMA and there is a timer

Re: [Qemu-devel] [PATCH arm-devs v1 3/5] sd/sdhci: Fix Buffer Write Ready interrupt

2013-05-22 Thread Igor Mitsyanko
On 05/21/2013 10:51 AM, peter.crosthwa...@xilinx.com wrote: From: Peter Crosthwaite This interrupt is not risen after the last block is written to sd. It is mutually exclusive with the end of transfer conditions. Fix. Signed-off-by: Peter Crosthwaite --- hw/sd/sdhci.c | 5 ++--- 1 file cha

Re: [Qemu-devel] [PATCH] qapi-schema.json: Reformat TargetType enum to one-per-line

2013-05-22 Thread Peter Maydell
On 22 May 2013 14:12, Anthony Liguori wrote: > Peter Maydell writes: >> I would much prefer it if we autogenerated this list so you didn't >> need to change this file at all to add a new target, but Anthony >> is against that; so this is at least an improvement. > > I don't object to autogenerati

Re: [Qemu-devel] [PATCH arm-devs v1 1/5] sd/sd.c: Fix "inquiry" ACMD41

2013-05-22 Thread Igor Mitsyanko
On 05/21/2013 10:50 AM, peter.crosthwa...@xilinx.com wrote: From: Peter Crosthwaite the SD command ACMD41 can be used in a read only mode to query device state without doing the SD card initialisation. This is valid even which the device is already initialised. Fix the command to be responsive

Re: [Qemu-devel] [PATCH arm-devs v1 4/5] sd/sdhci.c: Fix bdata_read DPRINT message

2013-05-22 Thread Igor Mitsyanko
On 05/21/2013 10:52 AM, peter.crosthwa...@xilinx.com wrote: From: Peter Crosthwaite This message was printing out the data in decimal only, which is not very friendly to the debugging developer. Add hex variant in parenthesis to make it consistent with other similar messages in this module. Si

Re: [Qemu-devel] [PATCH arm-devs v1 5/5] sd/sdhci:ADMA: fix interrupt

2013-05-22 Thread Igor Mitsyanko
On 05/21/2013 10:53 AM, peter.crosthwa...@xilinx.com wrote: From: Peter Crosthwaite The end of transfer check was occurring and potentially returning before the interrupt flag was checked. This means the interrupt will be missed if it occurs on the last packet. Fix by checking for the interrupt

[Qemu-devel] RFC: Full introspection support for QMP

2013-05-22 Thread Amos Kong
Hi all, We already have query-command-line-options to query details of command-line options. As we discussed in the list, we also need full introspection of QMP (command). The qmp-events also need to be dumped, we can define events in qai-schema.json. We can also dump QMP errors in future if it's

[Qemu-devel] [PATCH] target-mips: fix mipsdsp_trunc16_sat16_round

2013-05-22 Thread Petar Jovanovic
From: Petar Jovanovic This change corrects rounding and saturation of Q31 fractional value in mipsdsp_trunc16_sat16_round(). Overflow detection was incorrect for the corner case for PRECRQ_RS.PH, and this test case is also part of the change. Signed-off-by: Petar Jovanovic --- target-mips/dsp_

Re: [Qemu-devel] [PATCH v2] linux-user: improve target_to_host_sock_type conversion

2013-05-22 Thread Petar Jovanovic
ping From: Petar Jovanovic Sent: Wednesday, May 08, 2013 1:16 AM To: riku.voi...@linaro.org; qemu-devel@nongnu.org Cc: Aurelien Jarno; Petar Jovanovic; blauwir...@gmail.com; r...@twiddle.net; Alexander Graf; Andreas Färber Subject: RE: [Qemu-devel] [PATCH v

Re: [Qemu-devel] [PATCH v3 0/8] block: drive-backup live backup command

2013-05-22 Thread Stefan Hajnoczi
On Tue, May 21, 2013 at 10:58:47AM +, Dietmar Maurer wrote: > > >> True, but that would happen only in case the host crashes. Even for > > >> a QEMU crash the changes would be safe, I think. They would be > > >> written back when the persistent dirty bitmap's mmap() area is > > >> unmapped, d

Re: [Qemu-devel] [PATCH] kvm: add detail error message when fail to add ioeventfd

2013-05-22 Thread Amos Kong
On Wed, May 22, 2013 at 11:32:27AM +0200, Stefan Hajnoczi wrote: > On Wed, May 22, 2013 at 12:57:35PM +0800, Amos Kong wrote: > > I try to hotplug 28 * 8 multiple-function devices to guest with > > old host kernel, ioeventfds in host kernel will be exhausted, then > > qemu fails to allocate ioevent

Re: [Qemu-devel] [PATCH] qapi-schema.json: Reformat TargetType enum to one-per-line

2013-05-22 Thread Andreas Färber
Am 22.05.2013 15:15, schrieb Anthony Liguori: > Paolo Bonzini writes: > >> Il 20/05/2013 18:21, Peter Maydell ha scritto: >>> Reformat the qapi-schema TargetType enumeration so that it has just >>> one target architecture name per line. This allows patches for >>> adding new targets to just add a

Re: [Qemu-devel] [PATCH] qapi-schema.json: Reformat TargetType enum to one-per-line

2013-05-22 Thread Peter Maydell
On 22 May 2013 14:15, Anthony Liguori wrote: > Paolo Bonzini writes: >> You >> don't need to know what targets were supported in the version that you >> compiled from. Only one target is supported in this executable >> anyway. > > It seems useful to me. One day we may support multiple targets p

Re: [Qemu-devel] QMP interface for drive-add (or even blockdev-add)

2013-05-22 Thread Kevin Wolf
Am 16.05.2013 um 21:05 hat Eric Blake geschrieben: > On 05/16/2013 02:24 AM, Kevin Wolf wrote: > > Okay, let's take a step back here. The idea was more or less that you > > can specify each BlockDriverState by itself in the end, like this: > > > > { "execute": "blockdev-add", "data": { > > "id

Re: [Qemu-devel] [PATCH v4 2/8] block: add basic backup support to block driver

2013-05-22 Thread Stefan Hajnoczi
On Wed, May 22, 2013 at 11:56:45AM +0200, Kevin Wolf wrote: > Am 22.05.2013 um 11:54 hat Paolo Bonzini geschrieben: > > Il 22/05/2013 11:38, Kevin Wolf ha scritto: > > >> + > > >> +DPRINTF("brdv_co_backup_cow done C%" PRId64 "\n", start); > > >> +} > > >> + > > >> +out: > > >> +if (

Re: [Qemu-devel] [RFC 2/2] qemu-log: Interrupt the GDB session on guest-errors

2013-05-22 Thread Edgar E. Iglesias
On Wed, May 22, 2013 at 11:45:46AM +0100, Peter Maydell wrote: > On 22 May 2013 11:38, wrote: > > From: "Edgar E. Iglesias" > > @@ -45,6 +46,25 @@ void qemu_log_mask(int mask, const char *fmt, ...) > > vfprintf(qemu_logfile, fmt, ap); > > } > > va_end(ap); > > + > > +/* >

Re: [Qemu-devel] [PATCH v4 2/8] block: add basic backup support to block driver

2013-05-22 Thread Kevin Wolf
Am 22.05.2013 um 15:58 hat Stefan Hajnoczi geschrieben: > On Wed, May 22, 2013 at 11:56:45AM +0200, Kevin Wolf wrote: > > Am 22.05.2013 um 11:54 hat Paolo Bonzini geschrieben: > > > Il 22/05/2013 11:38, Kevin Wolf ha scritto: > > > >> + > > > >> +DPRINTF("brdv_co_backup_cow done C%" PRId64

Re: [Qemu-devel] [PATCH 3/9 v3] Move includes and struct definition to dump.h

2013-05-22 Thread Andreas Färber
Am 17.05.2013 05:24, schrieb Qiao Nuohan: > Move includes and definition of struct DumpState into include/sysemu/dump.h. > > Signed-off-by: Qiao Nuohan > Reviewed-by: Zhang Xiaohe > --- > dump.c| 29 - > include/sysemu/dump.h | 30

Re: [Qemu-devel] [PATCH v3] tests: set MALLOC_PERTURB_ to expose memory bugs

2013-05-22 Thread Eric Blake
On 05/22/2013 02:16 AM, Stefan Hajnoczi wrote: > glibc wipes malloc(3) memory when the MALLOC_PERTURB_ environment > variable is set. The value of the environment variable determines the > bit pattern used to wipe memory. For more information, see > http://udrepper.livejournal.com/11429.html. >

Re: [Qemu-devel] [PATCH] qapi-schema.json: Reformat TargetType enum to one-per-line

2013-05-22 Thread Anthony Liguori
Andreas Färber writes: > Am 22.05.2013 15:15, schrieb Anthony Liguori: >> Paolo Bonzini writes: >> >>> Il 20/05/2013 18:21, Peter Maydell ha scritto: Reformat the qapi-schema TargetType enumeration so that it has just one target architecture name per line. This allows patches for

Re: [Qemu-devel] [PATCH] qapi-schema.json: Reformat TargetType enum to one-per-line

2013-05-22 Thread Anthony Liguori
Peter Maydell writes: > On 22 May 2013 14:15, Anthony Liguori wrote: >> Paolo Bonzini writes: >>> You >>> don't need to know what targets were supported in the version that you >>> compiled from. Only one target is supported in this executable >>> anyway. >> >> It seems useful to me. One day

Re: [Qemu-devel] New targets (was: [PATCH] qapi-schema.json: Reformat TargetType enum to one-per-line)

2013-05-22 Thread Andreas Färber
Am 22.05.2013 16:28, schrieb Anthony Liguori: > Andreas Färber writes: >> More common is however that people start writing a new target and don't >> submit it yet (ahem!) while another target gets added, and the current >> form of rebreaking this block of enum values causes more conflicts > > Sou

Re: [Qemu-devel] [PATCH v4 4/8] qemu-iotests: add 055 drive-backup test case

2013-05-22 Thread Stefan Hajnoczi
On Wed, May 22, 2013 at 01:19:58PM +0200, Kevin Wolf wrote: > Am 16.05.2013 um 10:36 hat Stefan Hajnoczi geschrieben: > > Testing drive-backup is similar to image streaming and drive mirroring. > > This test case is based on 041. > > > > Signed-off-by: Stefan Hajnoczi > > --- > > tests/qemu-iote

Re: [Qemu-devel] [PATCH] qapi-schema.json: Reformat TargetType enum to one-per-line

2013-05-22 Thread Paolo Bonzini
Il 22/05/2013 16:29, Anthony Liguori ha scritto: > Peter Maydell writes: > >> On 22 May 2013 14:15, Anthony Liguori wrote: >>> Paolo Bonzini writes: You don't need to know what targets were supported in the version that you compiled from. Only one target is supported in this exe

Re: [Qemu-devel] [PATCH v4 3/8] block: add drive-backup QMP command

2013-05-22 Thread Stefan Hajnoczi
On Wed, May 22, 2013 at 11:53:44AM +0200, Kevin Wolf wrote: > Am 16.05.2013 um 10:36 hat Stefan Hajnoczi geschrieben: > > +proto_drv = bdrv_find_protocol(target); > > +if (!proto_drv) { > > +error_set(errp, QERR_INVALID_BLOCK_FORMAT, format); > > +return; > > +} > > I s

Re: [Qemu-devel] [PATCH v4 00/10] curl: fix curl read

2013-05-22 Thread Stefan Hajnoczi
On Wed, May 22, 2013 at 12:12:24PM +0100, Richard W.M. Jones wrote: > On Wed, May 22, 2013 at 01:04:51PM +0200, Paolo Bonzini wrote: > > Something is trying to write, but there's no write operation defined for > > CURL. > > > > I guess curl (and other backends too) should reject being opened for >

Re: [Qemu-devel] [PATCH 0/9 v3] Make monitor command 'dump-guest-memory' dump in kdump-compressed format

2013-05-22 Thread Andreas Färber
Am 17.05.2013 05:24, schrieb Qiao Nuohan: > Qiao Nuohan (9): > Add API to manipulate dump_bitmap > Add API to manipulate cache_data > Move includes and struct definition to dump.h > Add API to create header of vmcore > Add API to create data of dump bitmap > Add API to create page > A

Re: [Qemu-devel] RFC: Full introspection support for QMP

2013-05-22 Thread Kevin Wolf
Am 22.05.2013 um 15:40 hat Amos Kong geschrieben: > Hi all, > > We already have query-command-line-options to query details of command-line > options. As we discussed in the list, we also need full introspection of QMP > (command). The qmp-events also need to be dumped, we can define events in > q

Re: [Qemu-devel] New targets (was: [PATCH] qapi-schema.json: Reformat TargetType enum to one-per-line)

2013-05-22 Thread Anthony Liguori
Andreas Färber writes: > Am 22.05.2013 16:28, schrieb Anthony Liguori: >> Andreas Färber writes: >>> More common is however that people start writing a new target and don't >>> submit it yet (ahem!) while another target gets added, and the current >>> form of rebreaking this block of enum values

Re: [Qemu-devel] [PATCH] hw/9pfs: Use O_NOFOLLOW when opening files on server

2013-05-22 Thread Stefan Hajnoczi
On Wed, May 22, 2013 at 04:52:54PM +0530, Aneesh Kumar K.V wrote: > diff --git a/hw/9pfs/virtio-9p-handle.c b/hw/9pfs/virtio-9p-handle.c > index fe8e0ed..e2a89e3 100644 > --- a/hw/9pfs/virtio-9p-handle.c > +++ b/hw/9pfs/virtio-9p-handle.c > @@ -608,7 +608,7 @@ static int handle_init(FsContext *ctx)

[Qemu-devel] [PATCH] block/curl.c: Refuse to open the handle for writes.

2013-05-22 Thread Richard W.M. Jones
From: "Richard W.M. Jones" --- block/curl.c | 4 1 file changed, 4 insertions(+) diff --git a/block/curl.c b/block/curl.c index b8935fd..f1e302b 100644 --- a/block/curl.c +++ b/block/curl.c @@ -406,6 +406,10 @@ static int curl_open(BlockDriverState *bs, QDict *options, int flags) s

Re: [Qemu-devel] [PATCH v3 0/8] block: drive-backup live backup command

2013-05-22 Thread Dietmar Maurer
> > That way you can also implement async replication to a remote site (like MS > do). > > Sounds like rsync. yes, but we need 'snapshots' and something more optimized (rsync compared the whole files). I think this can be implemented using the backup job with a specialized backup driver.

[Qemu-devel] [PATCH] monitor: allow to disable the default monitor

2013-05-22 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- qemu-options.hx | 1 + vl.c| 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx index fb3961d..bf94862 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -2528,6 +2528,7 @@ Redirect the monitor

Re: [Qemu-devel] [libvirt] [qemu-devel] Default machine type setting for ppc64

2013-05-22 Thread Li Zhang
On 2013年05月22日 04:01, Anthony Liguori wrote: "Daniel P. Berrange" writes: On Tue, May 21, 2013 at 11:12:26AM -0600, Eric Blake wrote: I have also argued in the past that it would be useful for libvirt to support the idea of a template, where you can specify a domain XML that inherits defaults

Re: [Qemu-devel] New targets (was: [PATCH] qapi-schema.json: Reformat TargetType enum to one-per-line)

2013-05-22 Thread Peter Maydell
On 22 May 2013 15:48, Anthony Liguori wrote: > Andreas Färber writes: >> Am 22.05.2013 16:28, schrieb Anthony Liguori: >> So are incompletely implemented targets (wrt instruction set) eligible >> for upstream these days? > > Aren't most of our target incomplete by some standard? > > I thought the

Re: [Qemu-devel] [PATCH v3 0/8] block: drive-backup live backup command

2013-05-22 Thread Dietmar Maurer
> That sounds like more work than a persistent dirty bitmap. The advantage is > that > while dirty bitmaps are consumed by a single user, the Merkle tree can be used > to sync up any number of replicas. I also consider it safer, because you make sure the data exists (using hash keys like SHA1).

  1   2   >