Peter Maydell <peter.mayd...@linaro.org> writes:
> Reformat the qapi-schema TargetType enumeration so that it has just
> one target architecture name per line. This allows patches for
> adding new targets to just add a single line, rather than having
> to reformat most of the list (resulting in a hard-to-check diff).
>
> Signed-off-by: Peter Maydell <peter.mayd...@linaro.org>
> ---
> d15a9c23 is an example of what you get otherwise.
>
> I would much prefer it if we autogenerated this list so you didn't
> need to change this file at all to add a new target, but Anthony
> is against that; so this is at least an improvement.
I don't object to autogenerating it. I object to autogenerating based
on the selected targets.
The enum should be fixed regardless of what the configure line is.
Regards,
Anthony Liguori
>
> qapi-schema.json | 30 ++++++++++++++++++++++++++----
> 1 file changed, 26 insertions(+), 4 deletions(-)
>
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 199744a..a8d361e 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -3018,10 +3018,32 @@
> # Since: 1.2.0
> ##
> { 'enum': 'TargetType',
> - 'data': [ 'alpha', 'arm', 'cris', 'i386', 'lm32', 'm68k', 'microblazeel',
> - 'microblaze', 'mips64el', 'mips64', 'mipsel', 'mips', 'moxie',
> - 'or32', 'ppc64', 'ppcemb', 'ppc', 's390x', 'sh4eb', 'sh4',
> - 'sparc64', 'sparc', 'unicore32', 'x86_64', 'xtensaeb', 'xtensa'
> ] }
> + 'data': [ 'alpha',
> + 'arm',
> + 'cris',
> + 'i386',
> + 'lm32',
> + 'm68k',
> + 'microblazeel',
> + 'microblaze',
> + 'mips64el',
> + 'mips64',
> + 'mipsel',
> + 'mips',
> + 'moxie',
> + 'or32',
> + 'ppc64',
> + 'ppcemb',
> + 'ppc',
> + 's390x',
> + 'sh4eb',
> + 'sh4',
> + 'sparc64',
> + 'sparc',
> + 'unicore32',
> + 'x86_64',
> + 'xtensaeb',
> + 'xtensa' ] }
>
> ##
> # @TargetInfo:
> --
> 1.7.9.5
