Re: [Qemu-devel] [PATCH v17 1/6] add a new runstate: RUN_STATE_GUEST_PANICKED

2013-05-17 Thread Christian Borntraeger
On 05/04/13 08:36, Hu Tao wrote: > The guest will be in this state when it is panicked. > > Signed-off-by: Wen Congyang > Signed-off-by: Hu Tao This actually broken virsh dump without --memory-only: ERROR: invalid runstate transition: 'guest-panicked' -> 'finish-migrate' (virsh dump without

Re: [Qemu-devel] [PATCH v3 0/8] block: drive-backup live backup command

2013-05-17 Thread Wenchao Xia
于 2013-5-16 15:47, Stefan Hajnoczi 写道: On Thu, May 16, 2013 at 02:16:20PM +0800, Wenchao Xia wrote: After checking the code, I found it possible to add delta data backup support also, If an additional dirty bitmap was added. I've been thinking about this. Incremental backups need to know w

Re: [Qemu-devel] [PATCH v4 6/8] blockdev: add DriveBackup transaction

2013-05-17 Thread Stefan Hajnoczi
On Thu, May 16, 2013 at 01:21:19PM -0600, Eric Blake wrote: > On 05/16/2013 02:36 AM, Stefan Hajnoczi wrote: > > This patch adds a transactional version of the drive-backup QMP command. > > It allows atomic snapshots of multiple drives along with automatic > > cleanup if there is a failure to start

Re: [Qemu-devel] [PATCH 03/12] rcu: add rcu library

2013-05-17 Thread liu ping fan
[...] >> + >> +void synchronize_rcu(void) >> +{ >> +unsigned long was_online; >> + >> +was_online = get_rcu_reader()->ctr; >> + >> +/* Mark the writer thread offline to make sure we don't wait for >> + * our own quiescent state. This allows using synchronize_rcu() >> + * in thre

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target-ppc: Change default machine for 64-bit

2013-05-17 Thread Alexander Graf
Am 17.05.2013 um 10:47 schrieb David Gibson : > On Fri, May 17, 2013 at 02:36:26PM +1000, Benjamin Herrenschmidt wrote: >> On Fri, 2013-05-17 at 14:25 +1000, David Gibson wrote: >>> Because the pseries machine type is optional (it is only built when libfdt >>> is available), this can result in a

Re: [Qemu-devel] [PATCH 03/12] rcu: add rcu library

2013-05-17 Thread Paolo Bonzini
Il 17/05/2013 06:36, liu ping fan ha scritto: >> > +/* Mark the writer thread offline to make sure we don't wait for >> > + * our own quiescent state. This allows using synchronize_rcu() >> > + * in threads registered as readers. >> > + * >> > + * rcu_thread_offline() and rcu_th

Re: [Qemu-devel] [PATCH v2 2/2] net: introduce command to query mac-table information

2013-05-17 Thread Stefan Hajnoczi
On Thu, May 16, 2013 at 07:07:25PM +0800, Amos Kong wrote: > @@ -961,6 +961,44 @@ void print_net_client(Monitor *mon, NetClientState *nc) > nc->info_str); > } > > +MacTableInfoList *qmp_query_mac_table(bool has_name, const char *name, > +

Re: [Qemu-devel] [PATCH] target-ppc: Change default machine for 64-bit

2013-05-17 Thread Andreas Färber
Am 17.05.2013 06:25, schrieb David Gibson: > Currently, for qemu-system-ppc64, the default machine type is 'mac99'. > Since the mac99 machine is not being actively maintained, and shows quite > a few signs of bitrot, Please be more specific than making such general claims in a commit message! As t

[Qemu-devel] [PATCH] vl: new runstate transition: RUN_STATE_GUEST_PANICKED -> RUN_STATE_FINISH_MIGRATE

2013-05-17 Thread Hu Tao
On Fri, May 17, 2013 at 08:59:15AM +0200, Christian Borntraeger wrote: > On 05/04/13 08:36, Hu Tao wrote: > > The guest will be in this state when it is panicked. > > > > Signed-off-by: Wen Congyang > > Signed-off-by: Hu Tao > > This actually broken virsh dump without --memory-only: > > ERROR:

Re: [Qemu-devel] [Bug 1180923] [NEW] unused memory filled with 0x00 instead of 0xFF

2013-05-17 Thread Paolo Bonzini
Il 16/05/2013 22:00, Peter Maydell ha scritto: >> > Sounds like (risky) memory probing. On a PC the memory regions that >> > are unpopulated produce 0xff. > Presumably you could fix the PC model to do that by putting a big > background (overlappable) MemoryRegion across the whole of the > system a

Re: [Qemu-devel] [Bug 1180924] [NEW] fails to handle a usb serial port with a specific vendorid

2013-05-17 Thread Markus Armbruster
Rostislav Devyatov writes: > Public bug reported: > > If I run qemu-system-i386 with arguments > -usb -usbdevice serial:vendorid=1221:pty > (this is what the documentation says about how I shoud add a usb device which > has a serial port interface and which has a specific vendor id, I used the

Re: [Qemu-devel] QEMU NUMA and memory allocation problem

2013-05-17 Thread Wanlong Gao
On 05/16/2013 08:02 PM, Paolo Bonzini wrote: > Il 16/05/2013 11:50, Wanlong Gao ha scritto: >> To see that this 300M memory is allocated from host node0 again, but not >> host node1 as >> I expected. >> >> We think that QEMU can't handled this numa memory allocation well, and it >> will cause the

Re: [Qemu-devel] [PATCH v17 1/6] add a new runstate: RUN_STATE_GUEST_PANICKED

2013-05-17 Thread Markus Armbruster
Christian Borntraeger writes: > On 05/04/13 08:36, Hu Tao wrote: >> The guest will be in this state when it is panicked. >> >> Signed-off-by: Wen Congyang >> Signed-off-by: Hu Tao > > This actually broken virsh dump without --memory-only: > > ERROR: invalid runstate transition: 'guest-panicked

[Qemu-devel] [PATCH V2 0/2] qcow2: try cancel the modification on fail in snapshot creation

2013-05-17 Thread Wenchao Xia
V2: 1/2: all fail case will goto fail section. 2/2: add the goto code. Wenchao Xia (2): 1 qcow2: free allocated cluster on fail in qcow2_write_snapshots() 2 qcow2: cancel the modification on fail in qcow2_snapshot_create() block/qcow2-snapshot.c | 27 --- 1 file

[Qemu-devel] [PATCH V2 1/2] qcow2: free allocated cluster on fail in qcow2_write_snapshots()

2013-05-17 Thread Wenchao Xia
Signed-off-by: Wenchao Xia --- block/qcow2-snapshot.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/block/qcow2-snapshot.c b/block/qcow2-snapshot.c index 992a5c8..45da32d 100644 --- a/block/qcow2-snapshot.c +++ b/block/qcow2-snapshot.c @@ -180,13 +180,13 @@ sta

[Qemu-devel] [PATCH V2 2/2] qcow2: cancel the modification on fail in qcow2_snapshot_create()

2013-05-17 Thread Wenchao Xia
Signed-off-by: Wenchao Xia --- block/qcow2-snapshot.c | 17 ++--- 1 files changed, 14 insertions(+), 3 deletions(-) diff --git a/block/qcow2-snapshot.c b/block/qcow2-snapshot.c index 45da32d..033f705 100644 --- a/block/qcow2-snapshot.c +++ b/block/qcow2-snapshot.c @@ -367,7 +367,7

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target-ppc: Change default machine for 64-bit

2013-05-17 Thread Benjamin Herrenschmidt
On Fri, 2013-05-17 at 09:42 +0200, Andreas Färber wrote: > Am 17.05.2013 06:25, schrieb David Gibson: > > Currently, for qemu-system-ppc64, the default machine type is 'mac99'. > > Since the mac99 machine is not being actively maintained, and shows quite > > a few signs of bitrot, > > Please be mo

Re: [Qemu-devel] 2013 Linux Plumbers Virtualization Microconference proposal call for participation

2013-05-17 Thread Stefan Hajnoczi
On Thu, May 16, 2013 at 02:32:30PM -0600, Alex Williamson wrote: > We'd like to hold another virtualization microconference as part of this > year's Linux Plumbers Conference. To do so, we need to show that > there's enough interest, materials, and people willing to attend. Convenience info: Se

Re: [Qemu-devel] [PATCH for-1.5 0/2] main-loop: fix slirp on win32

2013-05-17 Thread Paolo Bonzini
Il 17/05/2013 03:25, TeLeMan ha scritto: > On Thu, May 16, 2013 at 11:35 PM, Stefan Hajnoczi wrote: >> User networking is broken on win32. These patches resolve the issues. >> >> TeLeMan and therock247uk: Please apply these patches and confirm that they >> fix >> the bug. >> >> Paolo: Please let

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target-ppc: Change default machine for 64-bit

2013-05-17 Thread Peter Maydell
On 17 May 2013 06:17, David Gibson wrote: > On Fri, May 17, 2013 at 02:36:26PM +1000, Benjamin Herrenschmidt wrote: >> On Fri, 2013-05-17 at 14:25 +1000, David Gibson wrote: >> > Because the pseries machine type is optional (it is only built when libfdt >> > is available), this can result in a bui

Re: [Qemu-devel] [PATCH for-1.5] vl: new runstate transition: RUN_STATE_GUEST_PANICKED -> RUN_STATE_FINISH_MIGRATE

2013-05-17 Thread Paolo Bonzini
Il 17/05/2013 09:43, Hu Tao ha scritto: > On Fri, May 17, 2013 at 08:59:15AM +0200, Christian Borntraeger wrote: >> On 05/04/13 08:36, Hu Tao wrote: >>> The guest will be in this state when it is panicked. >>> >>> Signed-off-by: Wen Congyang >>> Signed-off-by: Hu Tao >> >> This actually broken vi

Re: [Qemu-devel] [PATCH for-1.5 v2] Rename hexdump to avoid FreeBSD libutil conflict

2013-05-17 Thread Paolo Bonzini
Il 16/05/2013 17:32, Ed Maste ha scritto: > On FreeBSD libutil is used for openpty(), but it also provides a hexdump() > which conflicts with QEMU's. > > Signed-off-by: Ed Maste > --- > v1->v2: Add hexdump() use in iov.c > > If desired I can workaround this via #define hacks in qemu-common.h > i

Re: [Qemu-devel] [PATCH 1/9 v2] Add API to manipulate dump_bitmap

2013-05-17 Thread Andreas Färber
Am 15.05.2013 04:29, schrieb Qiao Nuohan: > Struct dump_bitmap is associated with a tmp file, and the tmp file can be used > to save data of bitmap in kdump-compressed format temporarily. > The following patch will use these functions to get the data of bitmap and > cache > them into tmp files. >

Re: [Qemu-devel] [PATCH] vl: new runstate transition: RUN_STATE_GUEST_PANICKED -> RUN_STATE_FINISH_MIGRATE

2013-05-17 Thread Christian Borntraeger
On 17/05/13 09:43, Hu Tao wrote: > ERROR: invalid runstate transition: 'guest-panicked' -> 'finish-migrate' > > Reported-by: Christian Borntraeger > Signed-off-by: Hu Tao Tested-by: Christian Borntraeger

Re: [Qemu-devel] [PATCH] target-moxie: replace target_phys_addr_t with hwaddr

2013-05-17 Thread Andreas Färber
Anthony G., Am 15.05.2013 10:23, schrieb Peter Maydell: > On 15 May 2013 07:04, Hu Tao wrote: >> target_phys_addr_t has been already replaced by hwaddr, but this >> one is introduced after. >> >> Signed-off-by: Hu Tao > > Reviewed-by: Peter Maydell > > This doesn't cause compile errors becaus

Re: [Qemu-devel] [PATCH] chardev: Get filename for new qapi backend

2013-05-17 Thread Lei Li
On 05/15/2013 03:26 PM, Lei Li wrote: On 05/15/2013 01:39 PM, Gerd Hoffmann wrote: On 05/15/13 05:52, Lei Li wrote: This patch add the filename when the new qapi backend init from opts. Commit 2c5f488293c7d0cd095635c74157c2526e2c4947 add support for qapi-based chardev initialization, but miss

[Qemu-devel] [PATCH] tests: set MALLOC_PERTURB_ to expose memory bugs

2013-05-17 Thread Stefan Hajnoczi
glibc wipes malloc(3) memory when the MALLOC_PERTURB_ environment variable is set. The value of the environment variable determines the bit pattern used to wipe memory. For more information, see http://udrepper.livejournal.com/11429.html. Set MALLOC_PERTURB_ for gtester and qemu-iotests. Note w

[Qemu-devel] [PATCH for-next] dump: Move stubs into libqemustub.a

2013-05-17 Thread Andreas Färber
This allows us to drop CONFIG_NO_CORE_DUMP with its indirect dependency on CONFIG_CORE_DUMP. Signed-off-by: Andreas Färber --- Makefile.target | 2 -- stubs/Makefile.objs | 1 + dump-stub.c => stubs/dump.c | 0 3 files changed, 1 insertion(+), 2 deletions(-) rename dump-stub

Re: [Qemu-devel] [PATCH 1/9 v2] Add API to manipulate dump_bitmap

2013-05-17 Thread Qiao Nuohan
On 05/17/2013 04:20 PM, Andreas Färber wrote: Jens and me have been working towards removing the dependency on CONFIG_HAVE_CORE_DUMP. Would there be any issue building this code unconditionally using obj-y += dump_bitmap.o ? No problems will be involved. -- Regards Qiao Nuohan

Re: [Qemu-devel] [PATCH v3 0/8] block: drive-backup live backup command

2013-05-17 Thread Stefan Hajnoczi
On Fri, May 17, 2013 at 02:58:57PM +0800, Wenchao Xia wrote: > 于 2013-5-16 15:47, Stefan Hajnoczi 写道: > >On Thu, May 16, 2013 at 02:16:20PM +0800, Wenchao Xia wrote: > >> After checking the code, I found it possible to add delta data backup > >>support also, If an additional dirty bitmap was adde

Re: [Qemu-devel] [PATCH V2 1/2] qcow2: free allocated cluster on fail in qcow2_write_snapshots()

2013-05-17 Thread Stefan Hajnoczi
On Fri, May 17, 2013 at 03:56:44PM +0800, Wenchao Xia wrote: > Signed-off-by: Wenchao Xia > --- > block/qcow2-snapshot.c | 10 ++ > 1 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/block/qcow2-snapshot.c b/block/qcow2-snapshot.c > index 992a5c8..45da32d 100644 > --- a/

Re: [Qemu-devel] [PATCH V2 2/2] qcow2: cancel the modification on fail in qcow2_snapshot_create()

2013-05-17 Thread Stefan Hajnoczi
On Fri, May 17, 2013 at 03:56:45PM +0800, Wenchao Xia wrote: > Signed-off-by: Wenchao Xia > --- > block/qcow2-snapshot.c | 17 ++--- > 1 files changed, 14 insertions(+), 3 deletions(-) > > diff --git a/block/qcow2-snapshot.c b/block/qcow2-snapshot.c > index 45da32d..033f705 100644

Re: [Qemu-devel] [PATCH] tests: set MALLOC_PERTURB_ to expose memory bugs

2013-05-17 Thread Markus Armbruster
Stefan Hajnoczi writes: > glibc wipes malloc(3) memory when the MALLOC_PERTURB_ environment > variable is set. The value of the environment variable determines the > bit pattern used to wipe memory. For more information, see > http://udrepper.livejournal.com/11429.html. > > Set MALLOC_PERTURB_

Re: [Qemu-devel] [PATCH] tests: set MALLOC_PERTURB_ to expose memory bugs

2013-05-17 Thread Daniel P. Berrange
On Fri, May 17, 2013 at 11:54:12AM +0200, Markus Armbruster wrote: > Stefan Hajnoczi writes: > > > glibc wipes malloc(3) memory when the MALLOC_PERTURB_ environment > > variable is set. The value of the environment variable determines the > > bit pattern used to wipe memory. For more informatio

Re: [Qemu-devel] [PATCH v3 0/8] block: drive-backup live backup command

2013-05-17 Thread Paolo Bonzini
Il 16/05/2013 09:47, Stefan Hajnoczi ha scritto: > On Thu, May 16, 2013 at 02:16:20PM +0800, Wenchao Xia wrote: >> After checking the code, I found it possible to add delta data backup >> support also, If an additional dirty bitmap was added. > > I've been thinking about this. Incremental backu

Re: [Qemu-devel] [PATCH 1/2] Split out dump-guest-memory memory mapping code

2013-05-17 Thread Andreas Färber
Am 23.04.2013 17:54, schrieb Jens Freimann: > On Tue, Apr 23, 2013 at 09:41:43AM -0600, Eric Blake wrote: >> On 04/23/2013 09:30 AM, Jens Freimann wrote: >>> Split out dump-guest-memory memory mapping code to allow dumping without >>> memory mapping >>> >>> The qemu dump.c code currently requires C

Re: [Qemu-devel] [Bug 1180970] [NEW] qemu: fatal: Trying to execute code outside RAM or ROM; worked in 1.4.0, fails in 1.4.92

2013-05-17 Thread Paolo Bonzini
Il 16/05/2013 23:46, Laszlo Ersek ha scritto: > On 05/16/13 21:58, Duane Voth wrote:> Public bug reported: >> >> I'm using qemu to run and debug the EDK2 uEFI environment. OVMF is >> being built out of the EDK2 tree I've checked out (r14367). >> (Reproducing all this could be tedious so I am availa

Re: [Qemu-devel] VFIO-VGA Issue

2013-05-17 Thread Paolo Bonzini
Il 16/05/2013 22:46, Maik Broemme ha scritto: > > Regarding 2) it results in 100 messages like the following on the console > which runs qemu: > > qemu-system-x86_64: vfio_vga_read(,0x3c3, 1) failed: Interrupted system call > qemu-system-x86_64: vfio_vga_read(,0x3c3, 1) failed: Interrupted system

[Qemu-devel] [RFC qom-cpu] dump: Unconditionally compile

2013-05-17 Thread Andreas Färber
qmp_dump_guest_memory() calls dump_init() and returns an Error when cpu_get_dump_info() returns an error, as done by the stub. So there is no need to have a stub for qmp_dump_guest_memory(). Enable the documentation of the always-present dump-guest-memory command. That way we can drop CONFIG_HAVE

Re: [Qemu-devel] [PATCH] tests: set MALLOC_PERTURB_ to expose memory bugs

2013-05-17 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Fri, May 17, 2013 at 11:54:12AM +0200, Markus Armbruster wrote: >> Stefan Hajnoczi writes: >> >> > glibc wipes malloc(3) memory when the MALLOC_PERTURB_ environment >> > variable is set. The value of the environment variable determines the >> > bit pattern use

Re: [Qemu-devel] [RFC qom-cpu] dump: Unconditionally compile

2013-05-17 Thread Paolo Bonzini
Il 17/05/2013 12:58, Andreas Färber ha scritto: > qmp_dump_guest_memory() calls dump_init() and returns an Error when > cpu_get_dump_info() returns an error, as done by the stub. > So there is no need to have a stub for qmp_dump_guest_memory(). > > Enable the documentation of the always-present du

Re: [Qemu-devel] [PATCH] tests: set MALLOC_PERTURB_ to expose memory bugs

2013-05-17 Thread Stefan Hajnoczi
On Fri, May 17, 2013 at 11:54 AM, Markus Armbruster wrote: > Stefan Hajnoczi writes: > >> glibc wipes malloc(3) memory when the MALLOC_PERTURB_ environment >> variable is set. The value of the environment variable determines the >> bit pattern used to wipe memory. For more information, see >> h

Re: [Qemu-devel] [PATCH] tests: set MALLOC_PERTURB_ to expose memory bugs

2013-05-17 Thread Stefan Hajnoczi
On Fri, May 17, 2013 at 12:07 PM, Daniel P. Berrange wrote: > Rather than setting MALLOC_PERTURB_=1 unconditionally in the Makefile > though, it ought to honour any existing MALLOC_PERTURB_ env variable > the user has set. That could let automated test harness run repeatedly > with random MALLOC_P

Re: [Qemu-devel] [PATCH for-1.5 0/3] hw/pci-host/versatile: Fix issues with newer kernels

2013-05-17 Thread Linus Walleij
On Thu, May 16, 2013 at 6:58 PM, Arnd Bergmann wrote: > FWIW, I plan to really get this done in the kernel for 3.11 properly > and rework the entire versatile and realview code base to work without > any platform specific code in arch/arm. Sweet! > The plan is to use the new > infrastructure f

Re: [Qemu-devel] [PATCH] scsi: reset cdrom tray statuses on scsi_disk_reset

2013-05-17 Thread Pavel Hrdina
On 16.5.2013 18:11, Paolo Bonzini wrote: Il 16/05/2013 17:48, Pavel Hrdina ha scritto: From what I just tested it is the OS-independent HW behavior. Tested on desktop: 1. Turn off the computer. 2. Turn on the computer and after few second open the CD-ROM tray before any OS system is loaded an

Re: [Qemu-devel] [PATCH] scsi: reset cdrom tray statuses on scsi_disk_reset

2013-05-17 Thread Paolo Bonzini
Il 17/05/2013 13:57, Pavel Hrdina ha scritto: >> >> What happens when you suspend the QEMU machine to RAM? I believe the >> tray should remain open or, if closed, should remain locked. Can you >> try the same test on bare-metal (hint: boot to emergency mode to bypass >> anything that udev can do

Re: [Qemu-devel] [PATCH for-1.5 0/3] hw/pci-host/versatile: Fix issues with newer kernels

2013-05-17 Thread Peter Maydell
On 17 May 2013 12:50, Linus Walleij wrote: > Do we have this on a topic branch in ARM SoC now? I > need a baseline to send a pull request for my cleanup of the > Integrator PCI The good news here is QEMU only models the Integrator/CP, which has no PCI, so all you need to test is real hardware :-)

Re: [Qemu-devel] [PATCH] scsi: reset cdrom tray statuses on scsi_disk_reset

2013-05-17 Thread Pavel Hrdina
On 17.5.2013 14:02, Paolo Bonzini wrote: Il 17/05/2013 13:57, Pavel Hrdina ha scritto: What happens when you suspend the QEMU machine to RAM? I believe the tray should remain open or, if closed, should remain locked. Can you try the same test on bare-metal (hint: boot to emergency mode to byp

Re: [Qemu-devel] [PATCH] scsi: reset cdrom tray statuses on scsi_disk_reset

2013-05-17 Thread Paolo Bonzini
Il 17/05/2013 14:11, Pavel Hrdina ha scritto: > On 17.5.2013 14:02, Paolo Bonzini wrote: >> Il 17/05/2013 13:57, Pavel Hrdina ha scritto: What happens when you suspend the QEMU machine to RAM? I believe the tray should remain open or, if closed, should remain locked. Can you t

Re: [Qemu-devel] [PATCH 7/7] block: dump to monitor for bdrv_snapshot_dump() and bdrv_image_info_dump()

2013-05-17 Thread Luiz Capitulino
On Fri, 17 May 2013 11:30:31 +0800 Wenchao Xia wrote: > 于 2013-5-16 20:17, Luiz Capitulino 写道: > > On Thu, 16 May 2013 10:22:09 +0800 > > Wenchao Xia wrote: > > > >> 于 2013-5-15 20:28, Luiz Capitulino 写道: > >>> On Wed, 15 May 2013 10:10:37 +0800 > >>> Wenchao Xia wrote: > >>> > 于 2013-5-6

Re: [Qemu-devel] [PATCH] scsi: reset cdrom tray statuses on scsi_disk_reset

2013-05-17 Thread Pavel Hrdina
On 17.5.2013 14:15, Paolo Bonzini wrote: Il 17/05/2013 14:11, Pavel Hrdina ha scritto: On 17.5.2013 14:02, Paolo Bonzini wrote: Il 17/05/2013 13:57, Pavel Hrdina ha scritto: What happens when you suspend the QEMU machine to RAM? I believe the tray should remain open or, if closed, should rem

Re: [Qemu-devel] Patch Round-up for stable 1.4.2, freeze on Monday

2013-05-17 Thread Luiz Capitulino
On Tue, 14 May 2013 16:52:57 -0500 Michael Roth wrote: > Hi everyone, > > The following new patches are queued for QEMU stable v1.4.2: > > https://github.com/mdroth/qemu/commits/stable-1.4-staging > > The release is planned for 05-24-2013: > > http://wiki.qemu.org/Planning/1.4 > > Please CC

Re: [Qemu-devel] [PATCH] tests: set MALLOC_PERTURB_ to expose memory bugs

2013-05-17 Thread Lucas Meneghel Rodrigues
On 17/05/13 07:07 AM, Daniel P. Berrange wrote: If you want punishment, why not go for extra punishment? MALLOC_PERTURB_=$(($RANDOM % 255 + 1)) That could lead to non-reproducable failures though. I think it is better to use a fixed value so that you're more likely to be able to reproduce the

Re: [Qemu-devel] [PATCH] tests: set MALLOC_PERTURB_ to expose memory bugs

2013-05-17 Thread Lucas Meneghel Rodrigues
On 17/05/13 08:15 AM, Stefan Hajnoczi wrote: On Fri, May 17, 2013 at 11:54 AM, Markus Armbruster wrote: Stefan Hajnoczi writes: glibc wipes malloc(3) memory when the MALLOC_PERTURB_ environment variable is set. The value of the environment variable determines the bit pattern used to wipe me

Re: [Qemu-devel] [PATCH] tests: set MALLOC_PERTURB_ to expose memory bugs

2013-05-17 Thread Lucas Meneghel Rodrigues
On 17/05/13 07:58 AM, Markus Armbruster wrote: "Daniel P. Berrange" writes: On Fri, May 17, 2013 at 11:54:12AM +0200, Markus Armbruster wrote: Stefan Hajnoczi writes: glibc wipes malloc(3) memory when the MALLOC_PERTURB_ environment variable is set. The value of the environment variable d

[Qemu-devel] [PATCH 7/7] target-arm: Use tuple list to sync cp regs with KVM

2013-05-17 Thread Peter Maydell
Use the tuple list of cp registers for syncing KVM state to QEMU, rather than only syncing a very minimal set by hand. Signed-off-by: Peter Maydell --- target-arm/kvm.c | 103 +- 1 file changed, 33 insertions(+), 70 deletions(-) diff --git a/

[Qemu-devel] [PATCH 6/7] target-arm: Reinitialize all KVM VCPU registers on reset

2013-05-17 Thread Peter Maydell
Since the ARM KVM API doesn't include a "reset this VCPU" ioctl, we have to capture the initial values of every register it knows about so that we can reset the VCPU by feeding those values back again. Signed-off-by: Peter Maydell --- target-arm/cpu-qom.h |6 +- target-arm/kvm.c |

[Qemu-devel] [PATCH 2/7] target-arm: Add raw_readfn and raw_writefn to ARMCPRegInfo

2013-05-17 Thread Peter Maydell
For reading and writing register values from the kernel for KVM, we need to provide accessor functions which are guaranteed to succeed and don't impose access checks, mask out unwritable bits, etc. Define new fields raw_readfn and raw_writefn for this purpose; these only need to be provided if ther

[Qemu-devel] [PATCH 0/7] target-arm: cpregs list for migration, kvm reset

2013-05-17 Thread Peter Maydell
This patch series overhauls how we handle ARM coprocessor registers, so that we use a consistent approach for migration, reset and QEMU<->KVM synchronisation, driven by the kernel's list of supported registers. The basic principle here is that we trust the kernel's list of what registers it knows

[Qemu-devel] [PATCH 3/7] target-arm: mark up cpregs for no-migrate or raw access

2013-05-17 Thread Peter Maydell
Mark up coprocessor register definitions to add raw access functions or mark the register as non-migratable where necessary. Signed-off-by: Peter Maydell --- target-arm/helper.c | 94 ++- 1 file changed, 63 insertions(+), 31 deletions(-) diff --

[Qemu-devel] [PATCH 4/7] target-arm: Convert TCG to using (index, value) list for cp migration

2013-05-17 Thread Peter Maydell
Convert the TCG ARM target to using an (index,value) list for migrating coprocessors. The primary benefit of the (index,value) list is for passing state between KVM and QEMU, but it works for TCG-to-TCG migration as well and is a useful self-contained first step. Signed-off-by: Peter Maydell ---

[Qemu-devel] [PATCH 1/7] target-arm: Allow special cpregs to have flags set

2013-05-17 Thread Peter Maydell
Relax the "is this a valid ARMCPRegInfo type value?" check to permit "special" cpregs to have flags other than ARM_CP_SPECIAL set. At the moment none of the other flags are relevant for special regs, but the migration related flag we're about to introduce can apply here too. Signed-off-by: Peter M

[Qemu-devel] [PATCH 5/7] target-arm: Initialize cpreg list from KVM when using KVM

2013-05-17 Thread Peter Maydell
When using KVM, use the kernel's initial state to set up the cpreg list, and sync to and from the kernel when doing migration. Signed-off-by: Peter Maydell --- target-arm/Makefile.objs |1 + target-arm/kvm.c | 164 +- target-arm/kvm_arm.h

Re: [Qemu-devel] QEMU NUMA and memory allocation problem

2013-05-17 Thread Eduardo Habkost
On Fri, May 17, 2013 at 03:47:52PM +0800, Wanlong Gao wrote: > On 05/16/2013 08:02 PM, Paolo Bonzini wrote: > > Il 16/05/2013 11:50, Wanlong Gao ha scritto: > >> To see that this 300M memory is allocated from host node0 again, but not > >> host node1 as > >> I expected. > >> > >> We think that QEM

[Qemu-devel] [PATCH 1/2] coroutine: protect global pool with a mutex

2013-05-17 Thread Stefan Hajnoczi
The coroutine freelist is a global pool of unused coroutines. It avoids the setup/teardown overhead associated with the coroutine lifecycle. Since the pool is global, we need to synchronize access so that coroutines can be used outside the BQL. Signed-off-by: Stefan Hajnoczi --- qemu-coroutine.

[Qemu-devel] [PATCH 0/2] coroutine: dataplane support

2013-05-17 Thread Stefan Hajnoczi
There is ongoing work to enable multiple event loop threads. This will allow QEMU itself to take advantage of SMP and reduce Big QEMU Lock (BQL) contention. This series is one step in that effort. These patches make coroutines safe in a multi-event loop/multi-threaded world. I have successfully t

[Qemu-devel] [PATCH 2/2] coroutine: stop using AioContext in CoQueue

2013-05-17 Thread Stefan Hajnoczi
qemu_co_queue_next(&queue) arranges that the next queued coroutine is run at a later point in time. This deferred restart is useful because the caller may not want to transfer control yet. This behavior was implemented using QEMUBH in the past, which meant that CoQueue (and hence CoMutex and CoRw

Re: [Qemu-devel] [PATCH 0/2] block: fix spurious DEVICE_TRAY_MOVED events on shutdown

2013-05-17 Thread Pavel Hrdina
On 25.4.2013 16:31, Luiz Capitulino wrote: On Thu, 25 Apr 2013 16:29:45 +0200 Stefan Hajnoczi wrote: On Thu, Apr 25, 2013 at 09:51:47AM -0400, Luiz Capitulino wrote: On Mon, 22 Apr 2013 15:53:43 +0200 Stefan Hajnoczi wrote: On Fri, Apr 19, 2013 at 01:47:17PM -0400, Luiz Capitulino wrote:

[Qemu-devel] [Bug 1180923] Re: unused memory filled with 0x00 instead of 0xFF

2013-05-17 Thread Battler
>>But you're supposed to use e820 or other mechanisms to retrieve the proper >>memory layout from the firmware. Well go back to the early 1990's and tell Microsoft and IBM that. :p DOS as it is, refuses to recognize memory not filled with 0xFF's as free. It instead thinks such memory is used by O

Re: [Qemu-devel] [PATCH for-next] dump: Move stubs into libqemustub.a

2013-05-17 Thread Andreas Färber
Am 17.05.2013 11:38, schrieb Paolo Bonzini: > Il 17/05/2013 10:52, Andreas Färber ha scritto: >> This allows us to drop CONFIG_NO_CORE_DUMP with its indirect dependency >> on CONFIG_CORE_DUMP. >> >> Signed-off-by: Andreas Färber >> --- >> Makefile.target | 2 -- >> stubs/Makefile.objs

[Qemu-devel] [Bug 1180923] Re: unused memory filled with 0x00 instead of 0xFF

2013-05-17 Thread Battler
Also, as for reproduction instruction: Start MS-DOS and make sure to bypass CONFIG.SYS and AUTOEXEC.BAT. Then run Microsoft Diagnostics (MSD) and press M for Memory. Look at the Memory Map: areas that are available, get marked as either "potentially available" (which means EMM386 will treat them

Re: [Qemu-devel] [PATCH 0/2] coroutine: dataplane support

2013-05-17 Thread Kevin Wolf
Am 17.05.2013 um 15:51 hat Stefan Hajnoczi geschrieben: > There is ongoing work to enable multiple event loop threads. This will allow > QEMU itself to take advantage of SMP and reduce Big QEMU Lock (BQL) > contention. > This series is one step in that effort. > > These patches make coroutines s

Re: [Qemu-devel] [PATCH 0/2] coroutine: dataplane support

2013-05-17 Thread Peter Maydell
On 17 May 2013 14:51, Stefan Hajnoczi wrote: > There is ongoing work to enable multiple event loop threads. This will allow > QEMU itself to take advantage of SMP and reduce Big QEMU Lock (BQL) > contention. > This series is one step in that effort. > > These patches make coroutines safe in a mu

Re: [Qemu-devel] Patch Round-up for stable 1.4.2, freeze on Monday

2013-05-17 Thread Doug Goldstein
On Tue, May 14, 2013 at 4:52 PM, Michael Roth wrote: > Hi everyone, > > The following new patches are queued for QEMU stable v1.4.2: > > https://github.com/mdroth/qemu/commits/stable-1.4-staging > > The release is planned for 05-24-2013: > > http://wiki.qemu.org/Planning/1.4 > > Please CC qemu-sta

Re: [Qemu-devel] [Bug 1180923] [NEW] unused memory filled with 0x00 instead of 0xFF

2013-05-17 Thread Anthony Liguori
Paolo Bonzini writes: > Il 16/05/2013 22:00, Peter Maydell ha scritto: >>> > Sounds like (risky) memory probing. On a PC the memory regions that >>> > are unpopulated produce 0xff. >> Presumably you could fix the PC model to do that by putting a big >> background (overlappable) MemoryRegion acro

[Qemu-devel] [Bug 1180923] Re: unused memory filled with 0x00 instead of 0xFF

2013-05-17 Thread Battler
Well about it being an EMM386 problem - no, it's DOS itself that maps the memory incorrectly if it's not filled the way it expects it. EMM386 just asks DOS for a memory map and tries to find the first free segment. But in this case, DOS hasn't mapped any segment as free, so EMM386 is unable to d

Re: [Qemu-devel] [RFC] reverse execution.

2013-05-17 Thread KONRAD Frédéric
On 09/05/2013 19:54, Blue Swirl wrote: On Tue, May 7, 2013 at 6:27 PM, KONRAD Frédéric wrote: Hi, We are trying to find a way to do reverse execution happen with QEMU. Actually, it is possible to debug the guest through the gdbstub, we want to make the reverse execution possible with GDB as w

Re: [Qemu-devel] [PATCH 1/2] target-mips: fix incorrect behaviour for EXTP

2013-05-17 Thread Aurelien Jarno
On Mon, May 13, 2013 at 03:20:26PM +0200, Petar Jovanovic wrote: > From: Petar Jovanovic > > The mask for EXTP instruction when size=31 has not been correctly > calculated. > > The test (mips32-dsp/extp.c) has been extended to include the case that > triggers the issue. > > Signed-off-by: Petar

Re: [Qemu-devel] Cross-Compiling Qemu for Aarch64?

2013-05-17 Thread Peter Maydell
On 17 May 2013 04:16, John Rigby wrote: > I tried > https://wiki.linaro.org/Platform/DevPlatform/CrossCompile/arm64bootstrap > and nothing works past the line where it recommends saving the > tarball. For folks who are reading this on qemu-devel, Wookey has updated the versions of packages in t

Re: [Qemu-devel] [PATCH 2/2] target-mips: fix EXTPDP and setting up pos field in the DSPControl reg

2013-05-17 Thread Aurelien Jarno
On Mon, May 13, 2013 at 03:20:27PM +0200, Petar Jovanovic wrote: > From: Petar Jovanovic > > This change makes sure that modifications of pos field in the DSPControl > register do not trash other bits in the register. This bug can be triggered > with the additional test case in mips32-dsp/extpdp.

Re: [Qemu-devel] [PATCH v2] target-mips: clean-up in BIT_INSV

2013-05-17 Thread Aurelien Jarno
On Mon, May 13, 2013 at 03:35:37AM +0200, Petar Jovanovic wrote: > From: Petar Jovanovic > > This is a small follow-up change to "fix incorrect behaviour for INSV". > > It includes two minor modifications: > > - sizefilter is constant so it can be moved inside of the block, > - several lines of

[Qemu-devel] [Bug 1180970] Re: qemu: fatal: Trying to execute code outside RAM or ROM; worked in 1.4.0, fails in 1.4.92

2013-05-17 Thread Launchpad Bug Tracker
** Branch linked: lp:~3v1n0/unity/gtk-wrapper-icon-info -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1180970 Title: qemu: fatal: Trying to execute code outside RAM or ROM; worked in 1.4.0, fails

[Qemu-devel] [Bug 1180970] Re: qemu: fatal: Trying to execute code outside RAM or ROM; worked in 1.4.0, fails in 1.4.92

2013-05-17 Thread Treviño
** Branch unlinked: lp:~3v1n0/unity/gtk-wrapper-icon-info -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1180970 Title: qemu: fatal: Trying to execute code outside RAM or ROM; worked in 1.4.0, fai

Re: [Qemu-devel] [RFC] reverse execution.

2013-05-17 Thread Peter Maydell
On 17 May 2013 18:23, KONRAD Frédéric wrote: > It appeared that the replay is not deterministic even with icount: > - the whole icount mechanism is not saved with save_vm (which can be > achieved by moving qemu_icount to TimerState according to Paolo) > - replaying two times the same thing

Re: [Qemu-devel] [PATCH 2/2] target-mips: fix EXTPDP and setting up pos field in the DSPControl reg

2013-05-17 Thread Petar Jovanovic
From: Aurelien Jarno [aurel...@aurel32.net] Sent: Friday, May 17, 2013 7:34 PM To: Petar Jovanovic Cc: qemu-devel@nongnu.org; Petar Jovanovic Subject: Re: [PATCH 2/2] target-mips: fix EXTPDP and setting up pos field in the DSPControl reg I am not sure it

[Qemu-devel] [Bug 1127369] Re: i386 emulation unreliable since commit b76f0d8c2e3eac94bc7fd90a510cb7426b2a2699

2013-05-17 Thread Andreas Gustafsson
My tests are now working again. The point in time when they started working is consistent with this having been fixed by commit 38ebb396c955ceb2ef7e246248ceb7f8bfe1b774, "target-i386: ROR r8/r16 imm instruction fix". Many thanks to everyone involved in fixing it. -- You received this bug notifi

Re: [Qemu-devel] [PATCH 2/2] target-mips: fix EXTPDP and setting up pos field in the DSPControl reg

2013-05-17 Thread Peter Maydell
On 13 May 2013 14:20, Petar Jovanovic wrote: > @@ -3439,10 +3439,9 @@ target_ulong helper_extpdp(target_ulong ac, > target_ulong size, > if (sub >= -1) { > acc = ((uint64_t)env->active_tc.HI[ac] << 32) | > ((uint64_t)env->active_tc.LO[ac] & MIPSDSP_LLO); > -

[Qemu-devel] [Bug 1154328] Re: qemu locks up on typing 41 characters at once into serial console

2013-05-17 Thread Andreas Gustafsson
** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1154328 Title: qemu locks up on typing 41 characters at once into serial console Status in QEM

[Qemu-devel] [PATCH v2] target-mips: fix EXTPDP and setting up pos field in the DSPControl reg

2013-05-17 Thread Petar Jovanovic
From: Petar Jovanovic This change makes sure that modifications of pos field in the DSPControl register do not trash other bits in the register. This bug can be triggered with the additional test case in mips32-dsp/extpdp.c in this commit. In addition to this, this change corrects incorrect calc

[Qemu-devel] [Bug 1089996] Re: Recent floppy boot regression in qemu-system-i386

2013-05-17 Thread Andreas Gustafsson
** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1089996 Title: Recent floppy boot regression in qemu-system-i386 Status in QEMU: Fix Commit

[Qemu-devel] [Bug 1181354] [NEW] assert failed in scsi-bus.c line 1539 in SCSI_XFER_NONE

2013-05-17 Thread TC1988
Public bug reported: Every time I format a SCSI hard disk (on ID 0) with Windows NT or DOS, QEMU crashes with an assertion failure on scsi-bus.c, any help? ** Affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- de

[Qemu-devel] [Bug 1181354] Re: assert failed in scsi-bus.c line 1539 in SCSI_XFER_NONE

2013-05-17 Thread TC1988
this happens from 1.3.0 to the latest git release. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1181354 Title: assert failed in scsi-bus.c line 1539 in SCSI_XFER_NONE Status in QEMU: New Bug d

Re: [Qemu-devel] Patch Round-up for stable 1.4.2, freeze on Monday

2013-05-17 Thread mdroth
On Fri, May 17, 2013 at 10:46:15AM -0500, Doug Goldstein wrote: > On Tue, May 14, 2013 at 4:52 PM, Michael Roth > wrote: > > > Hi everyone, > > > > The following new patches are queued for QEMU stable v1.4.2: > > > > https://github.com/mdroth/qemu/commits/stable-1.4-staging > > > > The release is

Re: [Qemu-devel] [PATCH v3 00/11] qapi: add support for lists of native types

2013-05-17 Thread mdroth
On Thu, May 16, 2013 at 12:38:30PM +0200, Laszlo Ersek wrote: > On 05/15/13 21:13, mdroth wrote: > > On Wed, May 15, 2013 at 02:05:58PM -0400, Luiz Capitulino wrote: > >> On Wed, 15 May 2013 12:42:24 -0500 > >> mdroth wrote: > > >>> The only way I've managed to reproduce this is by having a stale

[Qemu-devel] [PATCH v2] Split out dump-guest-memory memory mapping code

2013-05-17 Thread Jens Freimann
From: Ekaterina Tumanova Split out dump-guest-memory memory mapping code to allow dumping without memory mapping The qemu dump.c code currently requires CONFIG_HAVE_CORE_DUMP as well as CONFIG_HAVE_GET_MEMORY_MAPPING. This allows for dumping with and without paging. Some architectures will prov

Re: [Qemu-devel] [Bug 1181354] [NEW] assert failed in scsi-bus.c line 1539 in SCSI_XFER_NONE

2013-05-17 Thread Paolo Bonzini
Il 17/05/2013 20:37, TC1988 ha scritto: > Public bug reported: > > Every time I format a SCSI hard disk (on ID 0) with Windows NT or DOS, > QEMU crashes with an assertion failure on scsi-bus.c, any help? > > ** Affects: qemu > Importance: Undecided > Status: New > What SCSI adapte

Re: [Qemu-devel] [Bug 1180970] Re: qemu: fatal: Trying to execute code outside RAM or ROM; worked in 1.4.0, fails in 1.4.92

2013-05-17 Thread Duane Voth
Is there something special about this git repo? I can pull other git repos through my firewall with no problems, but this one fails (always at the same place) with: $ git clone http://git.qemu.org/git/qemu.git Cloning into 'qemu'... ### takes 1 or 2 mins - can see a lot of git objects succeed, th

Re: [Qemu-devel] [Qemu-stable] Patch Round-up for stable 1.4.2, freeze on Monday

2013-05-17 Thread Josh Durgin
On 05/17/2013 12:08 PM, mdroth wrote: On Fri, May 17, 2013 at 10:46:15AM -0500, Doug Goldstein wrote: On Tue, May 14, 2013 at 4:52 PM, Michael Roth wrote: Hi everyone, The following new patches are queued for QEMU stable v1.4.2: https://github.com/mdroth/qemu/commits/stable-1.4-staging The

[Qemu-devel] [ANNOUNCE] QEMU 1.5.0-rc3 is now available

2013-05-17 Thread Anthony Liguori
Hi, On behalf of the QEMU Team, I'd like to announce the availability of the fourth release candidate for the QEMU 1.5 release. This release is meant for testing purposes and should not be used in a production environment. http://wiki.qemu.org/download/qemu-1.5.0-rc3.tar.bz2 You can help improv

Re: [Qemu-devel] [Qemu-stable] Patch Round-up for stable 1.4.2, freeze on Monday

2013-05-17 Thread mdroth
On Fri, May 17, 2013 at 01:43:28PM -0700, Josh Durgin wrote: > On 05/17/2013 12:08 PM, mdroth wrote: > >On Fri, May 17, 2013 at 10:46:15AM -0500, Doug Goldstein wrote: > >>On Tue, May 14, 2013 at 4:52 PM, Michael Roth > >>wrote: > >> > >>>Hi everyone, > >>> > >>>The following new patches are queue

  1   2   >