Anthony G., Am 15.05.2013 10:23, schrieb Peter Maydell: > On 15 May 2013 07:04, Hu Tao <hu...@cn.fujitsu.com> wrote: >> target_phys_addr_t has been already replaced by hwaddr, but this >> one is introduced after. >> >> Signed-off-by: Hu Tao <hu...@cn.fujitsu.com> > > Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> > > This doesn't cause compile errors because it's in a bit > of code that can never get compiled (it's inside a > CONFIG_USER_ONLY block but there is no moxie-linux-user > target in configure).
A similar issue had come up before and I don't remember seeing a clear answer: Are you planning to actually implement moxie-linux-user and enable it by default, so that we can catch any errors? Or should we rather drop any such unused CONFIG_USER_ONLY code from target-moxie? Regards, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
