Re: [Qemu-devel] [PATCH] chardev: Get filename for new qapi backend

On 05/15/2013 01:39 PM, Gerd Hoffmann wrote: On 05/15/13 05:52, Lei Li wrote: This patch add the filename when the new qapi backend init from opts. Commit 2c5f488293c7d0cd095635c74157c2526e2c4947 add support for qapi-based chardev initialization, but miss the filename of the char device as belo

Re: [Qemu-devel] [RFC PATCH 1/2] mem: make phys_section and phys_map_nodes prepared for RCU

On Tue, May 14, 2013 at 5:27 PM, Paolo Bonzini wrote: > Il 14/05/2013 05:38, liu ping fan ha scritto: +struct PhysPageTable { +int ref; +PhysSection *phys_sections; +unsigned phys_sections_nb; +unsigned phys_sections_nb_alloc; +uint16_t phys_sectio

Re: [Qemu-devel] [PATCH 2/4] vnc: Support for LED state extension

On 05/15/2013 02:44 PM, Gerd Hoffmann wrote: On 05/15/13 08:05, Lei Li wrote: On 05/14/2013 07:35 PM, Gerd Hoffmann wrote: On 04/25/13 07:29, Lei Li wrote: +/* Sending the current led state message to the client */ +if (ledstate != current_led_state(vs)) { +vnc_led_state_change

Re: [Qemu-devel] [SeaBIOS] [PATCH v17] Add pvpanic device driver

On 04/05/13 09:17, Hu Tao wrote: > +Method(RDPT, 0, NotSerialized) { > +Store(PEPT, Local0) > +Return (Local0) > +} > + > +Method(WRPT, 1, NotSerialized) { > +Store(Arg0, PEPT) > +} Please excuse my as

Re: [Qemu-devel] [PATCH] chardev: Get filename for new qapi backend

On 05/15/2013 01:39 PM, Gerd Hoffmann wrote: On 05/15/13 05:52, Lei Li wrote: This patch add the filename when the new qapi backend init from opts. Commit 2c5f488293c7d0cd095635c74157c2526e2c4947 add support for qapi-based chardev initialization, but miss the filename of the char device as belo

Re: [Qemu-devel] [SeaBIOS] [PATCH v17] Add pvpanic device driver

On Wed, May 15, 2013 at 09:21:54AM +0200, Laszlo Ersek wrote: > On 04/05/13 09:17, Hu Tao wrote: > > > +Method(RDPT, 0, NotSerialized) { > > +Store(PEPT, Local0) > > +Return (Local0) > > +} > > + > > +Method(WRPT, 1, NotSerialized

Re: [Qemu-devel] [SeaBIOS] [PATCH v17] Add pvpanic device driver

On Wed, May 15, 2013 at 03:27:39PM +0800, Hu Tao wrote: > On Wed, May 15, 2013 at 09:21:54AM +0200, Laszlo Ersek wrote: > > On 04/05/13 09:17, Hu Tao wrote: > > > > > +Method(RDPT, 0, NotSerialized) { > > > +Store(PEPT, Local0) > > > +Return (Local0) > >

Re: [Qemu-devel] [PATCH v17] Add pvpanic device driver

On 05/04/13 09:17, Hu Tao wrote: > pvpanic device is used to notify host(qemu) when guest panic happens. > > Signed-off-by: Paolo Bonzini > Signed-off-by: Hu Tao Another question: are you planning to provide libvirt support? Currently I see the guest as paused after a crash. Since there is a cr

Re: [Qemu-devel] [SeaBIOS] [PATCH v17] Add pvpanic device driver

On 05/15/13 09:27, Hu Tao wrote: > On Wed, May 15, 2013 at 09:21:54AM +0200, Laszlo Ersek wrote: >> On 04/05/13 09:17, Hu Tao wrote: >> >>> +Method(RDPT, 0, NotSerialized) { >>> +Store(PEPT, Local0) >>> +Return (Local0) >>> +} >>> + >>> +

Re: [Qemu-devel] [PATCH v17] Add pvpanic device driver

On Wed, May 15, 2013 at 09:32:40AM +0200, Christian Borntraeger wrote: > On 05/04/13 09:17, Hu Tao wrote: > > pvpanic device is used to notify host(qemu) when guest panic happens. > > > > Signed-off-by: Paolo Bonzini > > Signed-off-by: Hu Tao > > Another question: are you planning to provide li

Re: [Qemu-devel] [PATCH] curl: fix curl read

On Wed, May 15, 2013 at 11:29:29AM +0800, Fam Zheng wrote: > On Thu, 05/09 17:16, Stefan Hajnoczi wrote: > > On Thu, May 09, 2013 at 02:56:50PM +0800, Fam Zheng wrote: > > > On Thu, 05/09 08:41, Stefan Hajnoczi wrote: > > > > On Fri, May 03, 2013 at 04:00:09PM +0800, Fam Zheng wrote: > > > > > +

Re: [Qemu-devel] [PATCH v2 00/11] curl: fix curl read

On Wed, May 15, 2013 at 11:46:36AM +0800, Fam Zheng wrote: > On Tue, 05/14 10:22, Stefan Hajnoczi wrote: > > On Tue, May 14, 2013 at 10:26:19AM +0800, Fam Zheng wrote: > > > - CURLDataCache holds the user data read from libcurl, it is in a list > > >ordered by access, the used cache is moved t

Re: [Qemu-devel] [RFC] block-trace Low Level Command Supporting Disk Introspection

Am 14.05.2013 um 18:45 hat Paolo Bonzini geschrieben: > Il 14/05/2013 17:48, Wolfgang Richter ha scritto: > > On Tue, May 14, 2013 at 6:04 AM, Paolo Bonzini > > wrote: > > > > Il 14/05/2013 10:50, Kevin Wolf ha scritto: > > > Or, to translate it into our existi

[Qemu-devel] [PATCH v6 1/4] isapc: Fix non-KVM qemu boot (read/write memory for isapc BIOS)

The isapc machine with seabios currently requires the BIOS region to be read/write memory rather than read-only memory. KVM currently cannot support the BIOS as a ROM region, but qemu in non-KVM mode can. Based on this, isapc machine currently only works with KVM. To work-around this isapc issue,

[Qemu-devel] [PATCH v6 2/4] kvm: add kvm_readonly_mem_enabled

Signed-off-by: Jordan Justen Reviewed-by: Paolo Bonzini --- include/sysemu/kvm.h | 10 ++ kvm-all.c|6 ++ kvm-stub.c |1 + 3 files changed, 17 insertions(+) diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h index 08284ef..8b19322 100644 --- a/i

[Qemu-devel] [PATCH v6 4/4] pc_sysfw: allow flash (-pflash) memory to be used with KVM

When pc-sysfw.rom_only == 0, flash memory will be usable with kvm. In order to enable flash memory mode, a pflash device must be created. (For example, by using the -pflash command line parameter.) Usage of a flash memory device with kvm requires KVM_CAP_READONLY_MEM, and kvm will abort if a flash

[Qemu-devel] [PATCH v6 3/4] kvm: support using KVM_MEM_READONLY flag for regions

For readonly memory regions and rom devices that are readable, we make use of the KVM_MEM_READONLY. A slot that uses KVM_MEM_READONLY can be read from and code can execute from the region, but writes will exit to qemu. For rom devices that are not readable, we force the slot to be removed so reads

[Qemu-devel] [PATCH v6 0/4] KVM flash memory support

git://github.com/jljusten/qemu.git kvm-flash-v6 Utilize KVM_CAP_READONLY_MEM to support PC system flash emulation with KVM. v6: * Rebase to master following 9e1c2ec8 * Make sure patch 1 "isapc: Fix non-KVM qemu boot" can be applied individually. (It is a candidate for 1.5.) v5: * Remove pa

Re: [Qemu-devel] [PATCH v1 00/14] port network layer onto glib

On Tue, May 07, 2013 at 01:46:48PM +0800, Liu Ping Fan wrote: > summary: > patch1: GSource event abstraction > patch2~6: port network backend to glib > patch7~10: make network core re-entrant > patch11~14: port the slirp backend onto glib > > The slirp->lock's deadlock problem has been el

Re: [Qemu-devel] [PATCH] monitor: intervally send down events to guest in hold time

On Tue, May 14, 2013 at 09:55:26AM -0500, Anthony Liguori wrote: > Laszlo Ersek writes: > > What's the status of this patch if I may ask? > > 1) It's unclear if this is the right solution. If key repeat is done in > the PS/2 controller, then that's where the logic here should be. It's best t

[Qemu-devel] [PATCH] vnc: Make ledstate comparison before modifiers updated

The ledstate should be compared before modifiers updated, otherwise the ledstate would be the same as current_led_state. Reported-by: Gerd Hoffmann Signed-off-by: Lei Li --- ui/vnc.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 89108de..df

Re: [Qemu-devel] [RFC PATCH 2/2] mem: prepare address_space listener rcu style

Il 15/05/2013 03:29, liu ping fan ha scritto: Pointers are quite expensive here. With RCU we can fetch a consistent root/table pair like this: rcu_read_lock(); do { pgtbl = d->cur_pgtbl; smp_rmb(); root = d->cur_root; >>>

Re: [Qemu-devel] [PATCH] target-moxie: replace target_phys_addr_t with hwaddr

On 15 May 2013 07:04, Hu Tao wrote: > target_phys_addr_t has been already replaced by hwaddr, but this > one is introduced after. > > Signed-off-by: Hu Tao Reviewed-by: Peter Maydell This doesn't cause compile errors because it's in a bit of code that can never get compiled (it's inside a CONF

Re: [Qemu-devel] [RFC] block-trace Low Level Command Supporting Disk Introspection

Il 15/05/2013 09:59, Kevin Wolf ha scritto: >>> Do you mean you'd model the 'active' mode after 'block-backup,' or actually >>> call functions provided by 'block-backup'? >> >> No, I'll just reuse the same hooks within block/mirror.c (almost... it >> looks like I need after_write too, not just befo

Re: [Qemu-devel] [PATCH] vnc: Make ledstate comparison before modifiers updated

On 05/15/13 10:20, Lei Li wrote: > The ledstate should be compared before modifiers updated, > otherwise the ledstate would be the same as current_led_state. > > Reported-by: Gerd Hoffmann > Signed-off-by: Lei Li > --- > ui/vnc.c |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) >

Re: [Qemu-devel] [PATCH v2 for-1.5 0/4] qcow2: Catch some L1 table index overflows

On Tue, May 14, 2013 at 04:14:32PM +0200, Kevin Wolf wrote: > Kevin Wolf (4): > qcow2: Catch some L1 table index overflows > block: Add hint to -EFBIG error message > qcow2.py: Subcommand for changing header fields > qemu-iotests: Try creating huge qcow2 image > > block.c

Re: [Qemu-devel] [Bug 1179731] [NEW] is networking broken on windows hosts?

Il 15/05/2013 03:38, TeLeMan ha scritto: > On Tue, May 14, 2013 at 7:55 PM, Paolo Bonzini wrote: >> Il 14/05/2013 13:48, Paolo Bonzini ha scritto: >>> Il 14/05/2013 13:39, TeLeMan ha scritto: On Tue, May 14, 2013 at 6:46 PM, Paolo Bonzini wrote: > Il 14/05/2013 12:24, TeLeMan ha scritto:

Re: [Qemu-devel] [PATCH 2/2] pc: reject do pc_acpi_init if acpi_enabled is false

Il 15/05/2013 06:01, liguang ha scritto: > Signed-off-by: liguang --verbose, please. What problem does this patch fix? Paolo > --- > hw/i386/pc.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/hw/i386/pc.c b/hw/i386/pc.c > index 197d218..77025a8 100644 > --- a

[Qemu-devel] [PATCH 2/2] qcow2: cancel the modification on fail in qcow2_snapshot_create()

Signed-off-by: Wenchao Xia --- block/qcow2-snapshot.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/block/qcow2-snapshot.c b/block/qcow2-snapshot.c index a6065a9..ad030f9 100644 --- a/block/qcow2-snapshot.c +++ b/block/qcow2-snapshot.c @@ -410,6 +410,17 @@ in

Re: [Qemu-devel] [Bug 1179219] Re: segfault in alloc_refcount_block

On Sun, May 12, 2013 at 11:43:31PM -, Brian J. Murrell wrote: > On 13-05-12 05:14 PM, Michael Tokarev wrote: > > First, having a single qcow2 file open for read-write access by more > > than one process in unsupported. > > But I don't, if I understand how qcow2 snapshots work. Let me apologiz

[Qemu-devel] [PATCH 1/2] qcow2: free allocated cluster on fail in qcow2_write_snapshots()

Signed-off-by: Wenchao Xia --- block/qcow2-snapshot.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/block/qcow2-snapshot.c b/block/qcow2-snapshot.c index 992a5c8..a6065a9 100644 --- a/block/qcow2-snapshot.c +++ b/block/qcow2-snapshot.c @@ -268,6 +268,8 @@ static int qc

Re: [Qemu-devel] [RFC] block-trace Low Level Command Supporting Disk Introspection

Am 15.05.2013 um 10:25 hat Paolo Bonzini geschrieben: > Il 15/05/2013 09:59, Kevin Wolf ha scritto: > >>> Do you mean you'd model the 'active' mode after 'block-backup,' or > >>> actually > >>> call functions provided by 'block-backup'? > >> > >> No, I'll just reuse the same hooks within block/mir

Re: [Qemu-devel] [PATCH 2/2] pc: reject do pc_acpi_init if acpi_enabled is false

在 2013-05-15三的 10:38 +0200，Paolo Bonzini写道： > Il 15/05/2013 06:01, liguang ha scritto: > > Signed-off-by: liguang > > --verbose, please. > > What problem does this patch fix? Oh, sorry to be lazy ... QEMU's option '-no-acpi' seems does not play a correct role, even started with this, ACPI tabl

Re: [Qemu-devel] [PATCH v1 00/14] port network layer onto glib

On Wed, May 15, 2013 at 4:10 PM, Stefan Hajnoczi wrote: > On Tue, May 07, 2013 at 01:46:48PM +0800, Liu Ping Fan wrote: >> summary: >> patch1: GSource event abstraction >> patch2~6: port network backend to glib >> patch7~10: make network core re-entrant >> patch11~14: port the slirp backe

Re: [Qemu-devel] [RFC PATCH 2/2] mem: prepare address_space listener rcu style

On Wed, May 15, 2013 at 4:22 PM, Paolo Bonzini wrote: > Il 15/05/2013 03:29, liu ping fan ha scritto: > Pointers are quite expensive here. With RCU we can fetch a consistent > root/table pair like this: > > rcu_read_lock(); > do { > pgtbl = d->cur_pgtbl; >>

Re: [Qemu-devel] [RFC] block-trace Low Level Command Supporting Disk Introspection

> > We don't need a way to pass data from before to after hooks, a simple > > scan of a linked list will do. > > So in this case the linked list is the way. Point taken. :) > > > Does the "if there was no room" part mean that the mirror is active only > > > sometimes? > > > > Yes, otherwise th

Re: [Qemu-devel] [RFC PATCH 2/2] mem: prepare address_space listener rcu style

> > > rcu_read_lock(); > > > map = rcu_dereference(d->cur_map) > > > if (unlikely(d->prev_map!=map) { > > > d->root = map->root; > > > d->pgtbl = map->pgtbl; > > > } > > > .. > > > rcu_read_unlock(); > > > > > > Then it can avoid ABA problem. > > > > I don't see the assignment of prev_m

[Qemu-devel] [RFC] save/restore with icount enabled.

Hi, We are trying to do a simple save/restore on the VM with icount enabled. We saw that qemu_icount_bias and qemu_icount in cpus.c are not saved/restored, and icount_extra, icount_decr in CPUState neither, so the vm_clock is just growing normally after restoring the VM is that normal? We thi

Re: [Qemu-devel] [RFC] block-trace Low Level Command Supporting Disk Introspection

Am 15.05.2013 um 11:16 hat Paolo Bonzini geschrieben: > > > > Does the "if there was no room" part mean that the mirror is active only > > > > sometimes? > > > > > > Yes, otherwise the guest can allocate arbitrary amounts of memory in the > > > host just by starting a few very large I/O operations

Re: [Qemu-devel] tap devices not receiving packets from a bridge

Hi again, On Tue, 2013-05-14 at 15:49 +0100, Nicholas Thomas wrote: > /sys/devices/virtual/net/t100/tun_flags is 0x5002 - so it looks like > IFF_ONE_QUEUE was indeed unset by qemu (which is lacking the patch). It > surprises me, but that's probably my fault, rather than qemu's. I've rebuilt 1.4.

Re: [Qemu-devel] [Bug 1179219] Re: segfault in alloc_refcount_block

On 13-05-15 04:45 AM, Stefan Hajnoczi wrote: > > $ qemu-img create -f qcow2 -b template.img vm001.qcow2 > $ qemu-img create -f qcow2 -b template.img vm002.qcow2 > $ qemu-img create -f qcow2 -b template.img vm003.qcow2 > $ ...launch vm001-vm002... > > This is safe. Yes. This is exactly what I di

[Qemu-devel] [PATCH] qemu-io: Fix 'map' output

The output of the 'map' command in qemu-io used to directly resemble bdrv_is_allocated() and could contain many lines for small chunks that all have the same allocation status. After this patch, they will be coalesced into a single output line for a large chunk. As a side effect, the command gains

Re: [Qemu-devel] [RFC] block-trace Low Level Command Supporting Disk Introspection

Il 15/05/2013 11:46, Kevin Wolf ha scritto: > Am 15.05.2013 um 11:16 hat Paolo Bonzini geschrieben: > Does the "if there was no room" part mean that the mirror is active only > sometimes? Yes, otherwise the guest can allocate arbitrary amounts of memory in the host just by st

Re: [Qemu-devel] [PATCH 9/9 v2] Make monitor command 'dump-guest-memory' dump in kdump-compressed format

On 05/14/2013 11:27 PM, Qiao Nuohan wrote: >>> +static int dump_init(DumpState *s, int fd, bool compress_format, >>> +DumpGuestMemoryFormat format, bool paging, >>> +bool has_filter, int64_t begin, int64_t length, >>> Error **errp) >>> { >> >> Why do you n

[Qemu-devel] [PATCH for-1.5 0/2] virtio-net: fix netclient id and type.

From: KONRAD Frederic This fixes this bug: https://bugs.launchpad.net/qemu/+bug/1179357 The name, and the type is replaced by virtio-net-x's id and virtio-net-x's type to restore the behaviour of "info network" command. Thanks, Fred KONRAD Frederic (2): virtio-net: add virtio_net_set_netclie

[Qemu-devel] [PATCH for-1.5 1/2] virtio-net: add virtio_net_set_netclient_name.

From: KONRAD Frederic This adds virtio_net_set_netclient_name, which is used to set the name and type shown in "info network" command. Signed-off-by: KONRAD Frederic --- hw/net/virtio-net.c| 45 -- include/hw/virtio/virtio-net.h | 4 2

[Qemu-devel] [PATCH for-1.5 2/2] virtio-net-x: forward the netclient name and type.

From: KONRAD Frederic This forwards the name and the type of virtio-net-x to fix the bad behaviour of "info network" command. Signed-off-by: KONRAD Frederic --- hw/s390x/s390-virtio-bus.c | 3 +++ hw/s390x/virtio-ccw.c | 3 +++ hw/virtio/virtio-pci.c | 3 +++ 3 files changed, 9 insert

Re: [Qemu-devel] [PATCH 7/7] block: dump to monitor for bdrv_snapshot_dump() and bdrv_image_info_dump()

On Wed, 15 May 2013 10:10:37 +0800 Wenchao Xia wrote: > 于 2013-5-6 21:22, Luiz Capitulino 写道: > > On Mon, 06 May 2013 10:09:43 +0800 > > Wenchao Xia wrote: > > > >> 于 2013-5-3 10:51, Wenchao Xia 写道: > >>> 于 2013-5-2 20:02, Luiz Capitulino 写道: > On Thu, 02 May 2013 10:05:08 +0800 > Wenc

[Qemu-devel] Actual Physical Memory in Qemu !

Hi ! I am emulating mips64 linux on Qemu running on X86 machine.I want to see that which function in the Qemu writes any register value at any address in the memory of x86 machine? Which functions should i see? Thanks Nouman

Re: [Qemu-devel] [RFC] save/restore with icount enabled.

Il 15/05/2013 11:31, KONRAD Frédéric ha scritto: > Hi, > > We are trying to do a simple save/restore on the VM with icount enabled. > > We saw that qemu_icount_bias and qemu_icount in cpus.c are not > saved/restored, > and icount_extra, icount_decr in CPUState neither, so the vm_clock is just > g

[Qemu-devel] [PATCH] ide-test: Fix endianness problems

The test case passes on big endian hosts now (tested on ppc64) Signed-off-by: Kevin Wolf --- tests/ide-test.c | 32 +++- 1 file changed, 27 insertions(+), 5 deletions(-) diff --git a/tests/ide-test.c b/tests/ide-test.c index bdc1da7..365e995 100644 --- a/tests/ide-te

Re: [Qemu-devel] [PATCH for-1.5?] ide-test: Fix endianness problems

Il 15/05/2013 15:00, Kevin Wolf ha scritto: > The test case passes on big endian hosts now (tested on ppc64) > > Signed-off-by: Kevin Wolf For 1.5? Do we need an extra -rc? Paolo

Re: [Qemu-devel] [PATCH for-1.5 1/2] virtio-net: add virtio_net_set_netclient_name.

On Wed, May 15, 2013 at 02:12:49PM +0200, fred.kon...@greensocs.com wrote: > @@ -1315,8 +1338,17 @@ static int virtio_net_device_init(VirtIODevice *vdev) > memcpy(&n->mac[0], &n->nic_conf.macaddr, sizeof(n->mac)); > n->status = VIRTIO_NET_S_LINK_UP; > > -n->nic = qemu_new_nic(&net_v

Re: [Qemu-devel] [PATCH for-1.5 0/2] virtio-net: fix netclient id and type.

On Wed, May 15, 2013 at 02:12:48PM +0200, fred.kon...@greensocs.com wrote: > From: KONRAD Frederic > > This fixes this bug: https://bugs.launchpad.net/qemu/+bug/1179357 > > The name, and the type is replaced by virtio-net-x's id and virtio-net-x's > type > to restore the behaviour of "info netw

Re: [Qemu-devel] [PATCH v3 00/11] qapi: add support for lists of native types

On Fri, 10 May 2013 17:45:59 -0500 Michael Roth wrote: > These patches apply on top of qemu.git master, and can also be obtained from: > git://github.com/mdroth/qemu.git qapi-native-lists > > Sending this now since a number of series have popped up in the past that > wanted this, and Amos has so

Re: [Qemu-devel] [PATCH for-1.5?] ide-test: Fix endianness problems

Am 15.05.2013 um 15:15 hat Paolo Bonzini geschrieben: > Il 15/05/2013 15:00, Kevin Wolf ha scritto: > > The test case passes on big endian hosts now (tested on ppc64) > > > > Signed-off-by: Kevin Wolf > > For 1.5? Do we need an extra -rc? An extra -rc for a test case fix on big endian hosts is

Re: [Qemu-devel] [PATCH for-1.5 1/2] virtio-net: add virtio_net_set_netclient_name.

On 15/05/2013 15:16, Stefan Hajnoczi wrote: On Wed, May 15, 2013 at 02:12:49PM +0200, fred.kon...@greensocs.com wrote: @@ -1315,8 +1338,17 @@ static int virtio_net_device_init(VirtIODevice *vdev) memcpy(&n->mac[0], &n->nic_conf.macaddr, sizeof(n->mac)); n->status = VIRTIO_NET_S_LINK_

[Qemu-devel] [PULL 2/2] qapi: fix leak in unit tests

From: Michael Roth qmp_output_get_qobject() increments the qobject's reference count. Since we currently pass this straight into qobject_to_json() so we can feed the data into a QMP input visitor, we never actually free the underlying qobject when qmp_output_visitor_cleanup() is called. This caus

[Qemu-devel] [PULL for-1.5 0/2] QMP queue

These two fixes are not hugely important, but they are pretty isolated anyway. The changes (since 110db9b48c0a6379fca122801c3ae48e349aa6d4) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp Michael Roth (1): qapi: fix leak in unit tests Zhangleiqi

[Qemu-devel] [PULL 1/2] qmp: fix handling of cmd with Equals in qmp-shell

From: Zhangleiqiang qmp: fix handling of cmd with equal mark in qmp-shell qmp-shell splits the argument and value of input command by equal mark("="). But there are commands whose values include equal mark themselves, and the json built by qmp-shell will not c

Re: [Qemu-devel] [RFC] save/restore with icount enabled.

On 15/05/2013 14:50, Paolo Bonzini wrote: Il 15/05/2013 11:31, KONRAD Frédéric ha scritto: Hi, We are trying to do a simple save/restore on the VM with icount enabled. We saw that qemu_icount_bias and qemu_icount in cpus.c are not saved/restored, and icount_extra, icount_decr in CPUState neith

Re: [Qemu-devel] [PATCH 2/2] pc: reject do pc_acpi_init if acpi_enabled is false

On 05/15/13 10:54, li guang wrote: > 在 2013-05-15三的 10:38 +0200，Paolo Bonzini写道： >> Il 15/05/2013 06:01, liguang ha scritto: >>> Signed-off-by: liguang >> >> --verbose, please. >> >> What problem does this patch fix? > > Oh, sorry to be lazy ... > QEMU's option '-no-acpi' seems does not play > a

Re: [Qemu-devel] [RFC] save/restore with icount enabled.

Il 15/05/2013 15:35, KONRAD Frédéric ha scritto: > On 15/05/2013 14:50, Paolo Bonzini wrote: >> Il 15/05/2013 11:31, KONRAD Frédéric ha scritto: >>> Hi, >>> >>> We are trying to do a simple save/restore on the VM with icount enabled. >>> >>> We saw that qemu_icount_bias and qemu_icount in cpus.c ar

Re: [Qemu-devel] [PATCH for-1.5?] ide-test: Fix endianness problems

Il 15/05/2013 15:24, Kevin Wolf ha scritto: > Am 15.05.2013 um 15:15 hat Paolo Bonzini geschrieben: >> Il 15/05/2013 15:00, Kevin Wolf ha scritto: >>> The test case passes on big endian hosts now (tested on ppc64) >>> >>> Signed-off-by: Kevin Wolf >> >> For 1.5? Do we need an extra -rc? > > An e

Re: [Qemu-devel] Patch Round-up for stable 1.4.2, freeze on Monday

On Tue, May 14, 2013 at 04:52:57PM -0500, Michael Roth wrote: > Hi everyone, > > The following new patches are queued for QEMU stable v1.4.2: > > https://github.com/mdroth/qemu/commits/stable-1.4-staging > > The release is planned for 05-24-2013: > > http://wiki.qemu.org/Planning/1.4 > > Pleas

Re: [Qemu-devel] [PATCH for-1.5] Revert "pc: Kill the "use flash device for BIOS unless KVM" misfeature"

Sorry for the delay, I was off for a few days. Anthony Liguori writes: > Paolo Bonzini writes: > >> This reverts commit 9953f8822cc316eec9962f0a2858c3439a80adec. >> While Markus's analysis is entirely correct, there are 1.6 patches >> that fix the bug for real and without requiring machine type

[Qemu-devel] [PATCH v3 8/8] qemu-iotests: test 'drive-backup' transaction in 055

Ensure that the 'drive-backup' transaction works and check that a transaction abort works properly. Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/055 | 118 + tests/qemu-iotests/055.out | 4 +- 2 files changed, 120 insertions(+), 2 deleti

[Qemu-devel] [PATCH v3 6/8] blockdev: add DriveBackup transaction

This patch adds a transactional version of the drive-backup QMP command. It allows atomic snapshots of multiple drives along with automatic cleanup if there is a failure to start one of the backup jobs. Note that QMP events are emitted for block job completion/cancellation and the block job will b

Re: [Qemu-devel] [PATCH for-1.5 2/2] osdep: introduce qemu_anon_ram_free to free qemu_anon_ram_alloc-ed memory

This patch would break the build for me, if I didn't configure --disable-werror. Using --enable-trace-backend=stderr in case it makes a difference. Troublemaker flagged inline. Paolo Bonzini writes: > We switched from qemu_memalign to mmap() but then we don't modify > qemu_vfree() to do a munm

[Qemu-devel] [PATCH v3 4/8] qemu-iotests: add 055 drive-backup test case

Testing drive-backup is similar to image streaming and drive mirroring. This test case is based on 041. Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/055 | 230 + tests/qemu-iotests/055.out | 5 + tests/qemu-iotests/group | 1 + 3 fil

[Qemu-devel] [PATCH v3 1/8] block: add bdrv_add_before_write_cb()

The bdrv_add_before_write_cb() function installs a callback that is invoked before a write request is processed. This will be used to implement copy-on-write point-in-time snapshots where we need to copy out old data before overwriting it. Signed-off-by: Stefan Hajnoczi --- block.c

[Qemu-devel] [PATCH v3 5/8] blockdev: rename BlkTransactionStates to singular

The QMP 'transaction' command keeps a list of in-flight transactions. The transaction state structure is called BlkTransactionStates even though it only deals with a single transaction. The only plural thing is the linked list of transaction states. I find it confusing to call the single structur

[Qemu-devel] [PATCH v3 0/8] block: drive-backup live backup command

Note: These patches apply to my block-next tree. You can also grab the code from git here: git://github.com/stefanha/qemu.git block-backup-core This series adds a new QMP command, drive-backup, which takes a point-in-time snapshot of a block device. The snapshot is copied out to a target block d

[Qemu-devel] [PATCH v3 3/8] block: add drive-backup QMP command

@drive-backup Start a point-in-time copy of a block device to a new destination. The status of ongoing drive-backup operations can be checked with query-block-jobs where the BlockJobInfo.type field has the value 'backup'. The operation can be stopped before it has completed using the block-job-ca

Re: [Qemu-devel] [PATCH v3 00/11] qapi: add support for lists of native types

On Wed, May 15, 2013 at 09:17:46AM -0400, Luiz Capitulino wrote: > On Fri, 10 May 2013 17:45:59 -0500 > Michael Roth wrote: > > > These patches apply on top of qemu.git master, and can also be obtained > > from: > > git://github.com/mdroth/qemu.git qapi-native-lists > > > > Sending this now sin

Re: [Qemu-devel] [PATCH for-1.5] Revert "pc: Kill the "use flash device for BIOS unless KVM" misfeature"

Il 15/05/2013 16:28, Markus Armbruster ha scritto: > Sorry for the delay, I was off for a few days. > > Anthony Liguori writes: > >> Paolo Bonzini writes: >> >>> This reverts commit 9953f8822cc316eec9962f0a2858c3439a80adec. >>> While Markus's analysis is entirely correct, there are 1.6 patches

[Qemu-devel] [PATCH v3 2/8] block: add basic backup support to block driver

From: Dietmar Maurer backup_start() creates a block job that copies a point-in-time snapshot of a block device to a target block device. We call backup_do_cow() for each write during backup. That function reads the original data from the block device before it gets overwritten. The data is then

Re: [Qemu-devel] [PATCH v3 1/8] block: add bdrv_add_before_write_cb()

Il 15/05/2013 16:34, Stefan Hajnoczi ha scritto: > The bdrv_add_before_write_cb() function installs a callback that is > invoked before a write request is processed. This will be used to > implement copy-on-write point-in-time snapshots where we need to copy > out old data before overwriting it.

Re: [Qemu-devel] [PATCH for-1.5 2/2] osdep: introduce qemu_anon_ram_free to free qemu_anon_ram_alloc-ed memory

Il 15/05/2013 16:36, Markus Armbruster ha scritto: > This patch would break the build for me, if I didn't configure > --disable-werror. Using --enable-trace-backend=stderr in case it makes > a difference. Troublemaker flagged inline. Yes, it does---and it makes it a bit less urgent. Will fix to

[Qemu-devel] [PATCH v3 7/8] blockdev: add Abort transaction

The Abort action can be used to test QMP 'transaction' failure. Add it as the last action to exercise the .abort() and .cleanup() code paths for all previous actions. Signed-off-by: Stefan Hajnoczi --- blockdev.c | 15 +++ qapi-schema.json | 11 ++- 2 files changed, 25

Re: [Qemu-devel] [PATCH v3 00/11] qapi: add support for lists of native types

On Wed, 15 May 2013 09:32:37 -0500 mdroth wrote: > On Wed, May 15, 2013 at 09:17:46AM -0400, Luiz Capitulino wrote: > > On Fri, 10 May 2013 17:45:59 -0500 > > Michael Roth wrote: > > > > > These patches apply on top of qemu.git master, and can also be obtained > > > from: > > > git://github.co

Re: [Qemu-devel] [PATCH for-1.5] Revert "pc: Kill the "use flash device for BIOS unless KVM" misfeature"

Paolo Bonzini writes: > Il 15/05/2013 16:28, Markus Armbruster ha scritto: >> Sorry for the delay, I was off for a few days. >> >> Anthony Liguori writes: >> >>> Paolo Bonzini writes: >>> This reverts commit 9953f8822cc316eec9962f0a2858c3439a80adec. While Markus's analysis is entire

Re: [Qemu-devel] [PATCH for-1.5?] ide-test: Fix endianness problems

Paolo Bonzini writes: > Il 15/05/2013 15:24, Kevin Wolf ha scritto: >> Am 15.05.2013 um 15:15 hat Paolo Bonzini geschrieben: >>> Il 15/05/2013 15:00, Kevin Wolf ha scritto: The test case passes on big endian hosts now (tested on ppc64) Signed-off-by: Kevin Wolf >>> >>> For 1.5? D

[Qemu-devel] [PATCH buildfix for-1.5] qemu-common: Resolve vector build breakes for AltiVec

From: Paolo Bonzini On Mac OS X ppc, altivec.h defines "vector", leading to build breakage when used as variable name, e.g. in tracing code. Fix this by undefining identifiers after altivec.h inclusion. Signed-off-by: Paolo Bonzini Signed-off-by: Andreas Färber --- include/qemu-common.h | 10

[Qemu-devel] [PATCH 02/12] qemu-thread: add QemuEvent

This emulates Win32 manual-reset events using futexes or conditional variables. Typical ways to use them are with multi-producer, single-consumer data structures, to test for a complex condition whose elements come from different threads: for (;;) { qemu_event_reset(ev); ... t

[Qemu-devel] [PATCH 11/12] block: report RCU quiescent states

The aio workers may spend a long time executing I/O operations; mark that time as an extended quiescent state. Signed-off-by: Paolo Bonzini --- block/raw-posix.c | 3 +++ block/raw-win32.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/block/raw-posix.c b/block/raw-posix.c index c0ccf27

[Qemu-devel] [PATCH 05/12] rcu: add call_rcu

Signed-off-by: Paolo Bonzini --- docs/rcu.txt | 108 +-- include/qemu/rcu.h | 22 ++ util/rcu.c | 120 + 3 files changed, 246 insertions(+), 4 deletions(-) diff --git a/docs/rcu

[Qemu-devel] [PATCH 03/12] rcu: add rcu library

This includes a (mangled) copy of the urcu-qsbr code from liburcu. The main changes are: 1) removing dependencies on many other header files in liburcu; 2) removing for simplicity the tentative busy waiting in synchronize_rcu, which has limited performance effects; 3) replacing futexes in synchroni

[Qemu-devel] [RFC PATCH 00/12] RCU implementation for QEMU

Here is an RCU implementation based on liburcu. I had posted something like this a couple years ago, but there have been many changes: - more portable code - adjusted for all the threads that we have now - updated atomic operations for GCC 4.8 - lots of documentation There is plenty of docume

[Qemu-devel] [PATCH 06/12] rcu: add rcutorture

A stress test program (works, too :)). Signed-off-by: Paolo Bonzini --- tests/Makefile | 5 +- tests/rcutorture.c | 387 + 2 files changed, 391 insertions(+), 1 deletion(-) create mode 100644 tests/rcutorture.c diff --git a/tests/Makefi

[Qemu-devel] [PATCH 04/12] qemu-thread: register threads with RCU

Signed-off-by: Paolo Bonzini --- docs/rcu.txt | 13 +++-- util/qemu-thread-posix.c | 28 +++- util/qemu-thread-win32.c | 2 ++ 3 files changed, 36 insertions(+), 7 deletions(-) diff --git a/docs/rcu.txt b/docs/rcu.txt index 19e4840..5736676 100644 ---

[Qemu-devel] [PATCH 08/12] qemu-thread: report RCU quiescent states

Most threads will use mutexes and other sleeping synchronization primitives (condition variables, semaphores, events) periodically. For these threads, the synchronization primitives are natural places to report a quiescent state (possibly an extended one). Signed-off-by: Paolo Bonzini --- docs/

Re: [Qemu-devel] [PATCH for-1.5] Revert "pc: Kill the "use flash device for BIOS unless KVM" misfeature"

Il 15/05/2013 17:09, Markus Armbruster ha scritto: > @@ -209,7 +209,7 @@ void pc_system_firmware_init(MemoryRegion *rom_memory) > * TODO This device exists only so that users can switch between > * use of flash and ROM for the BIOS. The ability to switch was > * c

[Qemu-devel] [PATCH 09/12] event loop: report RCU quiescent states

Threads that run event loops also have places that can sleep for an extended time. Place an extended quiescent state there. Signed-off-by: Paolo Bonzini --- aio-posix.c | 7 +++ aio-win32.c | 10 +- main-loop.c | 5 + 3 files changed, 21 insertions(+), 1 deletion(-) diff --gi

[Qemu-devel] [PATCH 10/12] cpus: report RCU quiescent states

CPU threads have extended quiescent states while relinquishing control to the accelerator (except TCG). Signed-off-by: Paolo Bonzini --- cpus.c| 3 +++ kvm-all.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/cpus.c b/cpus.c index c232265..66970d6 100644 --- a/cpus.c +++ b/cpus.c @@

[Qemu-devel] [PATCH 01/12] add a header file for atomic operations

We're already using them in several places, but __sync builtins are just too ugly to type, and do not provide seqcst load/store operations. Signed-off-by: Paolo Bonzini --- docs/atomics.txt | 322 +++ hw/display/qxl.c | 3 +- hw/virti

[Qemu-devel] [PATCH 12/12] migration: report RCU quiescent states

The migration thread polls s->state periodically, it does not use a mutex or condition variable, so it has to report quiescent states manually. Signed-off-by: Paolo Bonzini --- migration.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/migration.c b/migration.c index 866d68d..fb8b326 1006

[Qemu-devel] [PATCH 07/12] rcu: allow nested calls to rcu_thread_offline/rcu_thread_online

Signed-off-by: Paolo Bonzini --- docs/rcu.txt | 5 + include/qemu/rcu.h | 21 +++-- 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/docs/rcu.txt b/docs/rcu.txt index d7c4f0b..4e7cde3 100644 --- a/docs/rcu.txt +++ b/docs/rcu.txt @@ -187,6 +187,11 @@ Marki

Re: [Qemu-devel] [RFC PATCH 00/12] RCU implementation for QEMU

On 15 May 2013 16:48, Paolo Bonzini wrote: > Giving a shot to rcutorture on a weak memory-model machine (PPC) > would be nice. It's available on my github repo as branch rcu. > rcutorture works on Linux-x86. My WINE setup has some problem with glib > right now. Doesn't compile (ARM): root@local

Re: [Qemu-devel] [PATCH for-1.5?] ide-test: Fix endianness problems

On Wed, May 15, 2013 at 10:37:43AM -0500, Anthony Liguori wrote: > Paolo Bonzini writes: > > > Il 15/05/2013 15:24, Kevin Wolf ha scritto: > >> Am 15.05.2013 um 15:15 hat Paolo Bonzini geschrieben: > >>> Il 15/05/2013 15:00, Kevin Wolf ha scritto: > The test case passes on big endian hosts n

  1   2   >