Re: [Qemu-devel] [PATCH 5/5] target-i386: implement machine->hot_add_cpu hook

2013-05-02 Thread Igor Mammedov
On Wed, 01 May 2013 21:32:59 +0200 Andreas Färber wrote: > Am 30.04.2013 18:00, schrieb Igor Mammedov: > > Signed-off-by: Igor Mammedov > > --- > > v3: > > * use local static variable for saving cpu_model > > > > v2: > > * override .hot_add_cpu statically starting with 1.5 machine > > Than

Re: [Qemu-devel] [PATCH for 1.5] Revert "target-i386: Use movcond to implement rotate flags."

2013-05-02 Thread Richard Henderson
On 2013-05-01 14:51, Hervé Poussineau wrote: Richard Henderson a écrit : On 2013-05-01 07:06, Hervé Poussineau wrote: This commit breaks boot of MS-DOS 6.22, which stops at: MODE CON CODEPAGE PREPARE=((850) C:\DOS\EGA.CPI) This reverts part of commit 34d80a55ff8517fd37bcfea5063b9797e2bd9132.

Re: [Qemu-devel] [PATCH 09/17] memory: iommu support

2013-05-02 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 02/05/2013 08:28, David Gibson ha scritto: > Well, we're talking here about the *target* address space of the > iommu. So that's address_space_memory for us too. In fact I > don't know of any realistic cases where the target AS won't be > addres

Re: [Qemu-devel] [PATCH for-1.5 0/2] more tcg-arm cleanups

2013-05-02 Thread Richard Henderson
Quick ping since the freeze is coming soon... r~ On 2013-04-29 16:08, Richard Henderson wrote: The first patch really ought to get into 1.5. The second patch is a re-done version of the 19/19 patch from version 5 of the previous patch series. We had dropped that due to wanting to avoid 16MB a

Re: [Qemu-devel] Windows XP qemu 1.4.5 BSOD 0x7B

2013-05-02 Thread Peter Lieven
On 30.04.2013 17:35, Paolo Bonzini wrote: -M pc-1.2 that helped. thank you ;-) Peter

Re: [Qemu-devel] [PATCH] Fix PReP NIP reset value

2013-05-02 Thread Fabien Chouteau
On 04/30/2013 09:55 PM, Hervé Poussineau wrote: > Alexander Graf a écrit : >> On 04/30/2013 06:23 PM, Fabien Chouteau wrote: >>> On 04/30/2013 06:06 PM, Alexander Graf wrote: On 04/30/2013 06:00 PM, Fabien Chouteau wrote: > On 04/30/2013 05:24 PM, Alexander Graf wrote: Maybe OHW is al

Re: [Qemu-devel] Windows XP qemu 1.4.5 BSOD 0x7B

2013-05-02 Thread Paolo Bonzini
Il 02/05/2013 09:52, Peter Lieven ha scritto: > On 30.04.2013 17:35, Paolo Bonzini wrote: >> -M pc-1.2 > that helped. As the next step in "bisecting", can you now: - start the Windows XP installer (it is fine to stop it at to the beginning of the graphical installation) with no -M option - if it

Re: [Qemu-devel] pause_all_vcpus() TCG bug?

2013-05-02 Thread Jan Kiszka
On 2013-05-01 15:47, Peter Maydell wrote: > On 1 May 2013 14:33, Andreas Färber wrote: >> Hello, >> >> This is today's function, with annotations and question inline: >> >> void pause_all_vcpus(void) >> { >> CPUArchState *penv = first_cpu; >> >> qemu_clock_enable(vm_clock, false); >> w

Re: [Qemu-devel] [PATCH 3/3] gtk: add devices menu to allow changing removable block devices

2013-05-02 Thread Kevin Wolf
Am 26.04.2013 um 21:43 hat Anthony Liguori geschrieben: > To generate this menu, we first walk the composition tree to > find any device with a 'drive' property. We then record these > devices and the BlockDriverState that they are associated with. > > Then we use query-block to get the BDS state

Re: [Qemu-devel] [PATCH] virtio-net: count VIRTIO_NET_F_MAC when calculating config_len

2013-05-02 Thread Cornelia Huck
On Mon, 29 Apr 2013 23:09:52 +0300 "Michael S. Tsirkin" wrote: > On Mon, Apr 29, 2013 at 08:45:50PM +0200, KONRAD Frédéric wrote: > > Maybe we can move the two firsts line in the virtio_net_pci_init before the > > init if they are usefull in the > > config_size computing: > > > > > >

Re: [Qemu-devel] [PATCH] virtio-net: count VIRTIO_NET_F_MAC when calculating config_len

2013-05-02 Thread Cornelia Huck
On Tue, 30 Apr 2013 12:02:12 +0300 "Michael S. Tsirkin" wrote: > On Tue, Apr 30, 2013 at 10:47:34AM +0200, KONRAD Frédéric wrote: > > >>Then compute the last one directly in the init function which is the > > >>harder: > > >> > > >> virtio_net_get_features > > >The real f

[Qemu-devel] qemu/virtio issue due to non-atomic data access

2013-05-02 Thread Paul Guo
Hello, I'm developing the qemu io support for kvm on arch/tile. During virtio-net testing I always saw the following similar message: "Guest moved used index from 46573 to 46592" The guest os then exits immediately. The qemu version is 0.13.0. Here is the code that reports the error message:

[Qemu-devel] [PATCH 1.5 0/3] qdev: switch reset to post-order

2013-05-02 Thread Paolo Bonzini
I was going to keep these for 1.6, but since they have been tested by the user and myself, and they fix a regression, it can be worthwhile to include these in 1.5. qdev reset (qdev_reset_all/qbus_reset_all) is currently done in pre-order. This is not right, because it means the parent devices can

[Qemu-devel] [PATCH 1.5 1/3] pci: do not export pci_bus_reset

2013-05-02 Thread Paolo Bonzini
qbus_reset_all can be used instead. There is no semantic change because pcibus_reset returns 1 and takes care of the device tree traversal. This will be necessary once the traversal is done always in qbus_reset_all *before* invoking pcibus_reset itself. Tested-by: Claudio Bley Signed-off-by: Pa

[Qemu-devel] [PATCH 1.5 2/3] qdev: allow both pre- and post-order vists in qdev walking functions

2013-05-02 Thread Paolo Bonzini
Resetting should be done in post-order, not pre-order. However, qdev_walk_children and qbus_walk_children do not allow this. Fix it by adding two extra arguments to the functions. Tested-by: Claudio Bley Signed-off-by: Paolo Bonzini --- hw/core/qdev.c | 45

[Qemu-devel] [PATCH 1.5 3/3] qdev: switch reset to post-order

2013-05-02 Thread Paolo Bonzini
Post-order is the only sensible direction for the reset signals. For example, suppose pre-order is used and the parent has some data structures that cache children state (for example a list of active requests). When the reset method is invoked on the parent, these caches could be in any state. If

[Qemu-devel] network down lead vm been shutdown

2013-05-02 Thread yue-kvm
hi,all the connection between remote-viewer and guest is good, now unplug Network Cable, wait several minutes, then kill virt-viewer. now guest will be shutdwn. ---winxp.log of libvirt-- handle_dev_display_connect: connect handle_new_display_channel: add display channel client handle_new_

[Qemu-devel] [PATCH qom-cpu for-1.5] cpus: Fix pausing TCG CPUs while in vCPU thread

2013-05-02 Thread Andreas Färber
Due to a preceding while loop, no CPU would've been put into stopped state. Reinitialize the variable. This fixes commit d798e97456658ea7605303b7c69b04ec7df95c10 (Allow to use pause_all_vcpus from VCPU context) for non-KVM case. While at it, change a 0 to false, amending commit 4fdeee7cd4c8f90ef76

Re: [Qemu-devel] Windows XP qemu 1.4.5 BSOD 0x7B

2013-05-02 Thread Peter Lieven
On 02.05.2013 10:43, Paolo Bonzini wrote: Il 02/05/2013 09:52, Peter Lieven ha scritto: On 30.04.2013 17:35, Paolo Bonzini wrote: -M pc-1.2 that helped. As the next step in "bisecting", can you now: - start the Windows XP installer (it is fine to stop it at to the beginning of the graphical

Re: [Qemu-devel] Windows XP qemu 1.4.5 BSOD 0x7B

2013-05-02 Thread Paolo Bonzini
Il 02/05/2013 11:56, Peter Lieven ha scritto: > On 02.05.2013 10:43, Paolo Bonzini wrote: >> Il 02/05/2013 09:52, Peter Lieven ha scritto: >>> On 30.04.2013 17:35, Paolo Bonzini wrote: -M pc-1.2 >>> that helped. >> As the next step in "bisecting", can you now: >> >> - start the Windows XP inst

Re: [Qemu-devel] [PATCH 1/3] ide: add drive-id property

2013-05-02 Thread Andreas Färber
Am 26.04.2013 21:43, schrieb Anthony Liguori: > This returns a string similar to what the guest would display in > something like Linux's /dev/disk/by-id/ path. > > Signed-off-by: Anthony Liguori > --- > hw/ide/qdev.c | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/hw/

Re: [Qemu-devel] qemu/virtio issue due to non-atomic data access

2013-05-02 Thread Richard Henderson
On 2013-05-02 10:12, Paul Guo wrote: A proper fix for this issue seems to be: Judge whether the address is aligned, do direct loading for the aligned case in ldq_le_p(), etc? No, I would think the proper fix would be to change the bits of virtio that are known to access aligned memory to not

Re: [Qemu-devel] [PATCH qom-cpu for-1.5] cpus: Fix pausing TCG CPUs while in vCPU thread

2013-05-02 Thread Jan Kiszka
On 2013-05-02 11:52, Andreas Färber wrote: > Due to a preceding while loop, no CPU would've been put into stopped > state. Reinitialize the variable. > This fixes commit d798e97456658ea7605303b7c69b04ec7df95c10 (Allow to use > pause_all_vcpus from VCPU context) for non-KVM case. > > While at it, c

Re: [Qemu-devel] [PATCH v3 0/4] ui/cocoa.m: Fix compiler and runtime warnings on 10.8

2013-05-02 Thread Peter Maydell
Ping! -- PMM On 22 April 2013 21:29, Peter Maydell wrote: > These patches fix various compiler and runtime warnings QEMU provokes > on MacOSX 10.8. The first two fix a leak and some deprecated functions > which cause warnings in the system log when QEMU runs. The second > two avoid some function

Re: [Qemu-devel] [PATCH 1.5 0/3] qdev: switch reset to post-order

2013-05-02 Thread Michael S. Tsirkin
On Thu, May 02, 2013 at 11:38:36AM +0200, Paolo Bonzini wrote: > I was going to keep these for 1.6, but since they have been tested > by the user and myself, and they fix a regression, it can be worthwhile > to include these in 1.5. I remember there were some tricky issues last time we tried somet

Re: [Qemu-devel] Windows XP qemu 1.4.5 BSOD 0x7B

2013-05-02 Thread Peter Lieven
On 02.05.2013 12:04, Paolo Bonzini wrote: Il 02/05/2013 11:56, Peter Lieven ha scritto: On 02.05.2013 10:43, Paolo Bonzini wrote: Il 02/05/2013 09:52, Peter Lieven ha scritto: On 30.04.2013 17:35, Paolo Bonzini wrote: -M pc-1.2 that helped. As the next step in "bisecting", can you now: - s

Re: [Qemu-devel] [PATCH 1.5 0/3] qdev: switch reset to post-order

2013-05-02 Thread Paolo Bonzini
Il 02/05/2013 12:35, Michael S. Tsirkin ha scritto: > > I was going to keep these for 1.6, but since they have been tested > > by the user and myself, and they fix a regression, it can be worthwhile > > to include these in 1.5. > > I remember there were some tricky issues last time > we tried some

Re: [Qemu-devel] [PATCH] ppc/spapr: Fix cache related properties

2013-05-02 Thread Alexander Graf
On 26.04.2013, at 23:21, Benjamin Herrenschmidt wrote: > The properties in the CPU nodes for expressing the cache block size > are spelled {d,i}-cache... not {d,i}cache... > > Also add the "line" variants in addition to the "block" variants for > completeness (some OSes might require them). > >

Re: [Qemu-devel] [v2][Qemu-ppc][PATCH 1/1] PPC: e500: correct params->ram_size with ram_size

2013-05-02 Thread Alexander Graf
On 02.05.2013, at 03:22, Tiejun Chen wrote: > We should sync params->ram_size after we fixup memory size on > a alignment boundary. Otherwise Guest would exceed the actual > memory region. > > Signed-off-by: Tiejun Chen Thanks, applied to ppc-next. Alex > --- > v2: > > eliminate that origi

Re: [Qemu-devel] [PATCH] Drop redundant resume_all_vcpus from main

2013-05-02 Thread Jan Kiszka
On 2012-08-21 09:01, Paolo Bonzini wrote: > Il 20/08/2012 20:11, Jan Kiszka ha scritto: >> VCPUs are either resumed directly via vm_start, after the incoming >> migration is done, or when a continue command is issued. We don't need >> the explicit resume before entering main_loop. >> >> Signed-off-

Re: [Qemu-devel] [PATCH] ppc/spapr: Fix cache related properties

2013-05-02 Thread Benjamin Herrenschmidt
On Thu, 2013-05-02 at 13:10 +0200, Alexander Graf wrote: > This patch is (in a modified, extended form) already in the tree: Ah yes, it wasn't upstream when I started hacking on that stuff and so I missed it. Just drop mine. Cheers, Ben.

Re: [Qemu-devel] [PATCH 1.5 0/3] qdev: switch reset to post-order

2013-05-02 Thread Michael S. Tsirkin
On Thu, May 02, 2013 at 01:01:20PM +0200, Paolo Bonzini wrote: > Il 02/05/2013 12:35, Michael S. Tsirkin ha scritto: > > > I was going to keep these for 1.6, but since they have been tested > > > by the user and myself, and they fix a regression, it can be worthwhile > > > to include these in 1.5.

Re: [Qemu-devel] [PATCH v3 0/4] Initial VHDX support

2013-05-02 Thread Stefan Hajnoczi
On Wed, May 01, 2013 at 11:06:16AM -0400, Jeff Cody wrote: > On Wed, May 01, 2013 at 02:43:04PM +0200, Stefan Hajnoczi wrote: > > On Mon, Apr 29, 2013 at 02:48:15PM -0400, Jeff Cody wrote: > > > > > > Differences from v2: > > > > > > > > > Patch 2/4: changed 2 uint8_t[16] to MSGUID (Kevin) > >

Re: [Qemu-devel] [PATCH 5/5] target-i386: implement machine->hot_add_cpu hook

2013-05-02 Thread Andreas Färber
Am 02.05.2013 09:18, schrieb Igor Mammedov: > On Wed, 01 May 2013 21:32:59 +0200 > Andreas Färber wrote: > >> I verified it's working as expected in Windows 2012 Datacenter, but >> neither in openSUSE 12.3 nor in Fedora 18 Live DVD did I see any change >> in /proc/cpuinfo or GNOME System Monitor.

Re: [Qemu-devel] [PATCH qom-cpu for-1.5] cpus: Fix pausing TCG CPUs while in vCPU thread

2013-05-02 Thread Andreas Färber
Am 02.05.2013 12:14, schrieb Jan Kiszka: > On 2013-05-02 11:52, Andreas Färber wrote: >> Due to a preceding while loop, no CPU would've been put into stopped >> state. Reinitialize the variable. >> This fixes commit d798e97456658ea7605303b7c69b04ec7df95c10 (Allow to use >> pause_all_vcpus from VCPU

Re: [Qemu-devel] [PATCH] Drop redundant resume_all_vcpus from main

2013-05-02 Thread Andreas Färber
Am 02.05.2013 13:20, schrieb Jan Kiszka: > On 2012-08-21 09:01, Paolo Bonzini wrote: >> Il 20/08/2012 20:11, Jan Kiszka ha scritto: >>> VCPUs are either resumed directly via vm_start, after the incoming >>> migration is done, or when a continue command is issued. We don't need >>> the explicit resu

Re: [Qemu-devel] [PATCH 7/7] block: dump to monitor for bdrv_snapshot_dump() and bdrv_image_info_dump()

2013-05-02 Thread Luiz Capitulino
On Thu, 02 May 2013 10:05:08 +0800 Wenchao Xia wrote: > 于 2013-4-30 3:05, Luiz Capitulino 写道: > > On Fri, 26 Apr 2013 16:46:57 +0200 > > Stefan Hajnoczi wrote: > > > >> On Fri, Apr 26, 2013 at 05:31:15PM +0800, Wenchao Xia wrote: > >>> @@ -2586,10 +2585,12 @@ void do_info_snapshots(Monitor *mon,

Re: [Qemu-devel] [PATCH] Drop redundant resume_all_vcpus from main

2013-05-02 Thread Jan Kiszka
On 2013-05-02 13:55, Andreas Färber wrote: > Am 02.05.2013 13:20, schrieb Jan Kiszka: >> On 2012-08-21 09:01, Paolo Bonzini wrote: >>> Il 20/08/2012 20:11, Jan Kiszka ha scritto: VCPUs are either resumed directly via vm_start, after the incoming migration is done, or when a continue comma

Re: [Qemu-devel] [PATCH 1/2] Add i.MX I2C device emulator.

2013-05-02 Thread Peter Crosthwaite
Hi Jean-Christophe, Thanks for your contribution. Please run the patch through scripts/checkpatch.pl to check for formatting errors. On Thu, May 2, 2013 at 5:53 AM, Jean-Christophe DUBOIS wrote: > Signed-off-by: Jean-Christophe DUBOIS > --- > default-configs/arm-softmmu.mak | 2 + > hw/i2c/M

[Qemu-devel] [PATCH 0/2] nbd: support large NBD requests

2013-05-02 Thread Stefan Hajnoczi
These patches switch from fixed-size 1 MB data buffers to dynamically sized buffers in NBD. This is necessary because the Linux nbd driver now allows up to 32 MB request size. Patch 1 gets rid of the request freelist, which becomes pointless when data buffers are no longer reused. Patch 2 dynami

[Qemu-devel] [PATCH 1/2] nbd: use g_slice_new() instead of a freelist

2013-05-02 Thread Stefan Hajnoczi
Use GLib's efficient slice allocator instead of open-coding the request freelist. This patch simplifies the NBDRequest code. Now we qemu_blockalign() the req->data buffer each time but the next patch switches from a fixed size buffer to a dynamic size anyway. Signed-off-by: Stefan Hajnoczi ---

[Qemu-devel] [PATCH 2/2] nbd: support large NBD requests

2013-05-02 Thread Stefan Hajnoczi
The Linux nbd driver recently increased the maximum supported request size up to 32 MB: commit 078be02b80359a541928c899c2631f39628f56df Author: Michal Belczyk Date: Tue Apr 30 15:28:28 2013 -0700 nbd: increase default and max request sizes Raise the default max request size

Re: [Qemu-devel] [PATCH 1/2] Add i.MX I2C device emulator.

2013-05-02 Thread Andreas Färber
Hi, Am 01.05.2013 21:53, schrieb Jean-Christophe DUBOIS: > Signed-off-by: Jean-Christophe DUBOIS > --- > default-configs/arm-softmmu.mak | 2 + > hw/i2c/Makefile.objs| 1 + > hw/i2c/imx_i2c.c| 374 > > 3 files changed, 377

Re: [Qemu-devel] [PATCH] softfloat: rebase to version 2a

2013-05-02 Thread Paul Brook
> The license of SoftFloat-2b is claimed to be GPLv2 incompatible by > the FSF due to an indemnification clause. The previous release, > SoftFloat-2a, did not contain this clause. The only changes between > these two versions as far as QEMU is concerned is the license change > and a global modifi

Re: [Qemu-devel] [PATCH 1/3] ide: add drive-id property

2013-05-02 Thread Anthony Liguori
Andreas Färber writes: > Am 26.04.2013 21:43, schrieb Anthony Liguori: >> This returns a string similar to what the guest would display in >> something like Linux's /dev/disk/by-id/ path. >> >> Signed-off-by: Anthony Liguori >> --- >> hw/ide/qdev.c | 15 +++ >> 1 file changed, 15 i

[Qemu-devel] [PATCH] blockdev: Replace "undefined error" in qmp_block_resize

2013-05-02 Thread Kevin Wolf
We have an errno value that can be displayed, so we should just do that. An easy way to reproduce this case is to resize a raw image to a size that is too large for the host file system. Signed-off-by: Kevin Wolf --- blockdev.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --

[Qemu-devel] [PATCH 01/29] cpu: Make kvm-stub.o available outside softmmu

2013-05-02 Thread Andreas Färber
From: Igor Mammedov It will provide stubs for *-user targets once softmmu-specific calls are attempted from common CPU code. Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost Signed-off-by: Andreas Färber --- Makefile.target | 14 +++--- include/sysemu/kvm.h | 4 ++-- k

[Qemu-devel] [PATCH 02/29] cpu: Call cpu_synchronize_post_init() from DeviceClass::realize()

2013-05-02 Thread Andreas Färber
From: Igor Mammedov If hotplugged, synchronize CPU state to KVM. Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost Signed-off-by: Andreas Färber --- include/sysemu/kvm.h | 20 ++-- kvm-all.c| 1 + kvm-stub.c | 1 + qom/cpu.c| 6 +++

[Qemu-devel] [PULL for-1.5 00/29] QOM CPUState patch queue 2013-05-02

2013-05-02 Thread Andreas Färber
Hello, This is my current QOM CPU patch queue. Please pull. It includes: * x86 CPU hot-plug support, * x86 CPUID feature word array cleanups, * first round of cleanups for dump support, * pause_all_vcpus() fix for TCG, * main() cleanup. Regards, Andreas Cc: Anthony Liguori Cc: Blue Swirl Cc:

[Qemu-devel] [PATCH 12/29] target-i386: Introduce feat2prop() for CPU properties

2013-05-02 Thread Andreas Färber
From: Igor Mammedov This helper replaces '_' with '-' in a uniform way. As a side effect, even custom mappings must use '-' now. Signed-off-by: Igor Mammedov [AF: Split off; operate on NUL-terminated string rather than '=' delimiter] Signed-off-by: Andreas Färber --- target-i386/cpu.c | 19 ++

[Qemu-devel] [PATCH 22/29] QMP: Add cpu-add command

2013-05-02 Thread Andreas Färber
From: Igor Mammedov Adds "cpu-add id=xxx" QMP command. cpu-add's "id" argument is a CPU number in a range [0..max-cpus) Example QMP command: -> { "execute": "cpu-add", "arguments": { "id": 2 } } <- { "return": {} } Signed-off-by: Igor Mammedov Acked-by: Luiz Capitulino Reviewed-by: Eric Bl

[Qemu-devel] [PATCH 13/29] target-i386: Introduce apic-id CPU property

2013-05-02 Thread Andreas Färber
From: Igor Mammedov The property is used from board level to set APIC ID for CPUs it creates. Do so in a new pc_new_cpu() helper, to be reused for hot-plug. Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost Signed-off-by: Andreas Färber --- hw/i386/pc.c | 29

[Qemu-devel] [PATCH 10/29] cpu: Add helper cpu_exists(), to check if CPU with specified id exists

2013-05-02 Thread Andreas Färber
From: Igor Mammedov Signed-off-by: Igor Mammedov Signed-off-by: Andreas Färber --- include/qom/cpu.h | 10 ++ qom/cpu.c | 26 ++ 2 files changed, 36 insertions(+) diff --git a/include/qom/cpu.h b/include/qom/cpu.h index a28e5ff..e54579b 100644 --- a/inc

[Qemu-devel] [PATCH 21/29] Add hot_add_cpu hook to QEMUMachine

2013-05-02 Thread Andreas Färber
From: Igor Mammedov Hook should be set by machines that implement CPU hot-add via cpu-add QMP command. Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost Signed-off-by: Andreas Färber --- include/hw/boards.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/hw/boards.h b/

[Qemu-devel] [PATCH 04/29] cpu: Resume CPU from DeviceClass::realize() if hot-plugged

2013-05-02 Thread Andreas Färber
From: Igor Mammedov Signed-off-by: Igor Mammedov Signed-off-by: Andreas Färber --- qom/cpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/qom/cpu.c b/qom/cpu.c index 66f7c00..b91213e 100644 --- a/qom/cpu.c +++ b/qom/cpu.c @@ -62,6 +62,7 @@ static void cpu_common_realizefn(DeviceState *d

[Qemu-devel] [PATCH 23/29] pc: Implement QEMUMachine::hot_add_cpu hook

2013-05-02 Thread Andreas Färber
From: Igor Mammedov Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost Signed-off-by: Andreas Färber --- hw/i386/pc.c | 26 ++ hw/i386/pc_piix.c| 1 + hw/i386/pc_q35.c | 1 + include/hw/i386/pc.h | 1 + 4 files changed, 29 insertions(+) diff

[Qemu-devel] [PATCH 05/29] cpu: Introduce CPU hot-plug notifier

2013-05-02 Thread Andreas Färber
From: Igor Mammedov Hot-add CPU event will be distributed to acpi_piix4 and rtc_cmos. Signed-off-by: Igor Mammedov Signed-off-by: Andreas Färber --- include/sysemu/sysemu.h | 3 +++ qom/cpu.c | 12 2 files changed, 15 insertions(+) diff --git a/include/sysemu/syse

[Qemu-devel] [PATCH 25/29] target-i386/kvm.c: Code formatting changes

2013-05-02 Thread Andreas Färber
From: Eduardo Habkost Add appropriate spaces around operators, and break line where it needs to be broken to allow feature-words array to be introduced without having too-long lines. Signed-off-by: Eduardo Habkost Reviewed-by: Igor Mammedov Signed-off-by: Andreas Färber --- target-i386/kvm.c

[Qemu-devel] [PATCH 08/29] cpu: Add qemu_for_each_cpu()

2013-05-02 Thread Andreas Färber
From: "Michael S. Tsirkin" Wrapper to avoid open-coded loops and to make CPUState iteration independent of CPUArchState. Signed-off-by: Michael S. Tsirkin Signed-off-by: Igor Mammedov Signed-off-by: Andreas Färber --- exec.c| 10 ++ include/qom/cpu.h | 9 + 2 fil

[Qemu-devel] [PATCH 29/29] Drop redundant resume_all_vcpus() from main()

2013-05-02 Thread Andreas Färber
From: Jan Kiszka VCPUs are either resumed directly via vm_start(), after the incoming migration is done, or when a continue command is issued. We don't need the explicit resume before entering main_loop(). Signed-off-by: Jan Kiszka Signed-off-by: Andreas Färber --- vl.c | 1 - 1 file changed,

[Qemu-devel] [PATCH 14/29] target-i386: Do not allow to set apic-id once CPU is realized

2013-05-02 Thread Andreas Färber
From: Igor Mammedov Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost Signed-off-by: Andreas Färber --- target-i386/cpu.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index f1cecc0..0d9493d 100644 --- a/target-i386/cpu.c +++ b/target

[Qemu-devel] [PATCH 28/29] cpus: Fix pausing TCG CPUs while in vCPU thread

2013-05-02 Thread Andreas Färber
Due to a preceding while loop, no CPU would've been put into stopped state. Reinitialize the variable. This fixes commit d798e97456658ea7605303b7c69b04ec7df95c10 (Allow to use pause_all_vcpus from VCPU context) for non-KVM case. While at it, change a 0 to false, amending commit 4fdeee7cd4c8f90ef76

[Qemu-devel] [PATCH 11/29] acpi_piix4: Add infrastructure to send CPU hot-plug GPE to guest

2013-05-02 Thread Andreas Färber
From: Igor Mammedov * introduce processor status bitmask visible to guest at 0xaf00 addr, where ACPI asl code expects it * set bit corresponding to APIC ID in processor status bitmask on receiving CPU hot-plug notification * trigger CPU hot-plug SCI, to notify guest about CPU hot-plug event

Re: [Qemu-devel] [PATCH for-1.5 v2 0/5] virtio: fix bus command line compatibility.

2013-05-02 Thread Cornelia Huck
On Tue, 30 Apr 2013 16:08:46 +0200 fred.kon...@greensocs.com wrote: > From: KONRAD Frederic > > Cc: Libaiqing > Cc: Michal Privoznik > > This fixes the bus name for virtio-serial-device and virtio-scsi-device. > > The bus name for virtio-serial-device and virtio-scsi-device is not "id.0" as

[Qemu-devel] [PATCH 07/29] cpu: Introduce get_arch_id() method and override it for X86CPU

2013-05-02 Thread Andreas Färber
From: Igor Mammedov get_arch_id() adds possibility for generic code to get a guest-visible CPU ID without accessing CPUArchState. If derived classes don't override it, it will return cpu_index. Override it on target-i386 in X86CPU to return the APIC ID. Signed-off-by: Igor Mammedov Reviewed-by

[Qemu-devel] [PATCH 06/29] pc: Update rtc_cmos on CPU hot-plug

2013-05-02 Thread Andreas Färber
From: Igor Mammedov It provides updated currently available CPUs count to BIOS on reboot. Signed-off-by: Igor Mammedov Signed-off-by: Andreas Färber --- hw/i386/pc.c | 20 hw/timer/mc146818rtc.c | 7 +++ include/hw/timer/mc146818rtc.h | 1 +

[Qemu-devel] [PATCH] trace: inline control-internal.h into control.h

2013-05-02 Thread Stefan Hajnoczi
trace/control.h is the API for manipulating trace events in QEMU. Some of the implementation of this API lives in trace/control-internal.h. Older versions of gcc complain because a static prototype is used but the function is defined static inline later on: CCvl.o In file included from t

[Qemu-devel] [PATCH 24/29] target-i386: Group together level, xlevel, xlevel2 fields

2013-05-02 Thread Andreas Färber
From: Eduardo Habkost Consolidate level, xlevel, xlevel2 fields in x86_def_t and CPUX86State. Signed-off-by: Eduardo Habkost Reviewed-by: Igor Mammedov Signed-off-by: Andreas Färber --- target-i386/cpu.c | 4 ++-- target-i386/cpu.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)

[Qemu-devel] [PATCH 18/29] target-i386: Introduce ICC bus/device/bridge

2013-05-02 Thread Andreas Färber
From: Igor Mammedov Provides a hotpluggable bus for APIC and CPU. * icc-bridge will serve as a parent for icc-bus and provide mmio mapping services to child icc-devices. * icc-device will replace SysBusDevice as a parent of APIC and IOAPIC devices. Signed-off-by: Igor Mammedov Signed-off-b

[Qemu-devel] [PATCH 17/29] cpu: Move cpu_write_elfXX_note() functions to CPUState

2013-05-02 Thread Andreas Färber
From: Jens Freimann Convert cpu_write_elfXX_note() functions to CPUClass methods and pass CPUState as argument. Update target-i386 accordingly. Signed-off-by: Jens Freimann [AF: Retain stubs as CPUClass' default method implementation; style changes] Signed-off-by: Andreas Färber --- dump-stub

[Qemu-devel] [PATCH 16/29] kvmvapic: Make dependency on sysbus.h explicit

2013-05-02 Thread Andreas Färber
From: Igor Mammedov Allows kvmvapic to compile if sysbus.h is removed from apic_internal.h, from which it is indirectly included. sysbus.h will be removed from apic_internal.h after converting APICs to ICCDevice. Signed-off-by: Igor Mammedov Signed-off-by: Andreas Färber --- hw/i386/kvmvapic.

[Qemu-devel] [PATCH 20/29] target-i386: Move APIC to ICC bus

2013-05-02 Thread Andreas Färber
From: Igor Mammedov It allows APIC to be hotplugged. * map APIC's mmio at board level if it is present * do not register mmio region for each APIC, since only one is used/mapped Signed-off-by: Igor Mammedov Signed-off-by: Andreas Färber --- hw/cpu/icc_bus.c| 10 +

[Qemu-devel] [PATCH 15/29] target-i386: Replace MSI_SPACE_SIZE with APIC_SPACE_SIZE

2013-05-02 Thread Andreas Färber
From: Igor Mammedov Put APIC_SPACE_SIZE in a public header so that it can be reused elsewhere later. Signed-off-by: Igor Mammedov Signed-off-by: Andreas Färber --- hw/i386/kvm/apic.c | 2 +- hw/intc/apic.c | 2 +- hw/xen/xen_apic.c | 2 +- include/h

[Qemu-devel] [PATCH 27/29] target-i386: Replace cpuid_*features fields with a feature word array

2013-05-02 Thread Andreas Färber
From: Eduardo Habkost This replaces the feature-bit fields on both X86CPU and x86_def_t structs with an array. With this, we will be able to simplify code that simply does the same operation on all feature words (e.g. kvm_check_features_against_host(), filter_features_for_kvm(), add_flagname_to_

[Qemu-devel] [PATCH 26/29] target-i386: Break CPUID feature definition lines

2013-05-02 Thread Andreas Färber
From: Eduardo Habkost Break lines on kvm_check_features_against_host(), kvm_cpu_fill_host(), and builtin_x86_defs, so they don't get too long once the *_features fields are replaced by an array. Signed-off-by: Eduardo Habkost Reviewed-by: Igor Mammedov Signed-off-by: Andreas Färber --- targe

[Qemu-devel] posting patches in pull requests (was Re: [PATCH 08/29] cpu: Add qemu_for_each_cpu())

2013-05-02 Thread Michael S. Tsirkin
Anthony, can we please make it a rule that all patches in pull request are tagged specially? As it is, patchwork is full of patches that were already reviewed and merged, all my scripts that were filtering and sorting patches are also useless, and I get to wade through each patch for the second ti

Re: [Qemu-devel] [PATCH 3/3] gtk: add devices menu to allow changing removable block devices

2013-05-02 Thread Anthony Liguori
Kevin Wolf writes: > Am 26.04.2013 um 21:43 hat Anthony Liguori geschrieben: >> To generate this menu, we first walk the composition tree to >> find any device with a 'drive' property. We then record these >> devices and the BlockDriverState that they are associated with. >> >> Then we use quer

Re: [Qemu-devel] [PATCH 3/3] gtk: add devices menu to allow changing removable block devices

2013-05-02 Thread Luiz Capitulino
On Thu, 02 May 2013 08:41:50 -0500 Anthony Liguori wrote: > >> + > >> +if (strcmp(type, "ide-cd") == 0) { > >> +disk_type = DT_CDROM; > >> +} else if (strcmp(type, "isa-fdc") == 0) { > >> +disk_type = DT_FLOPPY; > >> +} else { > >> +disk

[Qemu-devel] [PATCH for-1.5] libqos: Relocate I2C files

2013-05-02 Thread Andreas Färber
Commit c4efe1cada311b9dc0df5beb71c4227ff3414aa1 (qtest: add libqos including PCI support) created a libqos/ subdirectory but left the existing I2C libqos files libi2c*.[hc] in tests/. Clean this up. Signed-off-by: Andreas Färber --- tests/Makefile | 5 +++-- tests/{li

Re: [Qemu-devel] [PATCH] blockdev: Replace "undefined error" in qmp_block_resize

2013-05-02 Thread Eric Blake
On 05/02/2013 07:32 AM, Kevin Wolf wrote: > We have an errno value that can be displayed, so we should just do that. > An easy way to reproduce this case is to resize a raw image to a size > that is too large for the host file system. > > Signed-off-by: Kevin Wolf > --- > blockdev.c | 6 -- >

[Qemu-devel] [PATCH 09/29] cpus: Use qemu_for_each_cpu() in TCG thread

2013-05-02 Thread Andreas Färber
From: Igor Mammedov Replaces an open-coded loop and hides unused CPUArchState. Signed-off-by: Igor Mammedov Signed-off-by: Andreas Färber --- cpus.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/cpus.c b/cpus.c index 1d88761..a2d92c7 100644 --- a/cpus.c +++

Re: [Qemu-devel] [PATCH for-1.5 v2 0/5] virtio: fix bus command line compatibility.

2013-05-02 Thread KONRAD Frédéric
On 02/05/2013 15:40, Cornelia Huck wrote: On Tue, 30 Apr 2013 16:08:46 +0200 fred.kon...@greensocs.com wrote: From: KONRAD Frederic Cc: Libaiqing Cc: Michal Privoznik This fixes the bus name for virtio-serial-device and virtio-scsi-device. The bus name for virtio-serial-device and virtio-

Re: [Qemu-devel] [PATCH 3/3] gtk: add devices menu to allow changing removable block devices

2013-05-02 Thread Kevin Wolf
Am 02.05.2013 um 15:41 hat Anthony Liguori geschrieben: > Kevin Wolf writes: > > > Am 26.04.2013 um 21:43 hat Anthony Liguori geschrieben: > >> +static void gd_block_device_menu_update(BlockDeviceMenu *bdm, BlockInfo > >> *info) > >> +{ > >> +bool value; > >> +const char *label = _("");

Re: [Qemu-devel] posting patches in pull requests (was Re: [PATCH 08/29] cpu: Add qemu_for_each_cpu())

2013-05-02 Thread Michael S. Tsirkin
On Thu, May 02, 2013 at 03:09:04PM +0100, Peter Maydell wrote: > On 2 May 2013 14:51, Michael S. Tsirkin wrote: > > As it is, patchwork is full of patches that were already reviewed and > > merged, all my scripts that were filtering and sorting patches are also > > useless, and I get to wade throu

Re: [Qemu-devel] posting patches in pull requests (was Re: [PATCH 08/29] cpu: Add qemu_for_each_cpu())

2013-05-02 Thread Peter Maydell
On 2 May 2013 14:51, Michael S. Tsirkin wrote: > As it is, patchwork is full of patches that were already reviewed and > merged, all my scripts that were filtering and sorting patches are also > useless, and I get to wade through each patch for the second time. You need to fix patchwork to have s

[Qemu-devel] [PATCH 19/29] target-i386: Attach ICC bus to CPU on its creation

2013-05-02 Thread Andreas Färber
From: Igor Mammedov X86CPU should have parent bus so it could provide bus for child APIC. Signed-off-by: Igor Mammedov Signed-off-by: Andreas Färber --- hw/i386/pc.c | 10 ++ hw/i386/pc_piix.c| 2 +- hw/i386/pc_q35.c | 2 +- include/hw/i386/pc.h | 2 +- target-i386/

Re: [Qemu-devel] posting patches in pull requests (was Re: [PATCH 08/29] cpu: Add qemu_for_each_cpu())

2013-05-02 Thread Peter Maydell
On 2 May 2013 15:17, Michael S. Tsirkin wrote: > On Thu, May 02, 2013 at 03:09:04PM +0100, Peter Maydell wrote: > Sometimes I'm Cc'd on 1 patch out of series. > I might not want to go dig out the series only > to check if it actually needs review. I think cc'ing somebody on half a pullrequest or

Re: [Qemu-devel] posting patches in pull requests (was Re: [PATCH 08/29] cpu: Add qemu_for_each_cpu())

2013-05-02 Thread Michael S. Tsirkin
On Thu, May 02, 2013 at 03:21:14PM +0100, Peter Maydell wrote: > On 2 May 2013 15:17, Michael S. Tsirkin wrote: > > On Thu, May 02, 2013 at 03:09:04PM +0100, Peter Maydell wrote: > > > Sometimes I'm Cc'd on 1 patch out of series. > > I might not want to go dig out the series only > > to check if

[Qemu-devel] [PATCH 03/29] cpu: Introduce cpu_resume(), for single CPU

2013-05-02 Thread Andreas Färber
From: Igor Mammedov Also add a stub for it, to make possible to use it in qom/cpu.c, which is shared with user emulators. Signed-off-by: Igor Mammedov Signed-off-by: Andreas Färber --- cpus.c | 11 --- include/qom/cpu.h | 7 +++ stubs/Makefile.objs | 1 + stubs/cp

Re: [Qemu-devel] [PATCH] trace: inline control-internal.h into control.h

2013-05-02 Thread Lluís Vilanova
Stefan Hajnoczi writes: > trace/control.h is the API for manipulating trace events in QEMU. Some > of the implementation of this API lives in trace/control-internal.h. > Older versions of gcc complain because a static prototype is used but > the function is defined static inline later on: > C

Re: [Qemu-devel] [PATCH 1/3] virtio-pci: properly validate address before accessing config

2013-05-02 Thread Andreas Färber
Am 28.04.2013 10:35, schrieb Michael S. Tsirkin: > On Sun, Apr 28, 2013 at 03:54:20PM +0800, Jason Wang wrote: >> On 04/28/2013 03:26 AM, Michael S. Tsirkin wrote: >>> On Fri, Apr 26, 2013 at 04:34:02PM +0800, Jason Wang wrote: There are several several issues in the current checking: >>>

Re: [Qemu-devel] [RFC 7/7] target-i386: Disable direct passthrough of PMU CPUID leaf by default

2013-05-02 Thread Eduardo Habkost
On Wed, May 01, 2013 at 01:14:48PM +0200, Andreas Färber wrote: > Am 30.04.2013 21:57, schrieb Eduardo Habkost: > > On Tue, Apr 30, 2013 at 07:04:23PM +0200, Igor Mammedov wrote: > >> It's impossible to implement "n270 movbe" fixup with compat props > >> currently, > >> so 5/7 + 1/7 looks ok. We

Re: [Qemu-devel] posting patches in pull requests (was Re: [PATCH 08/29] cpu: Add qemu_for_each_cpu())

2013-05-02 Thread Gerd Hoffmann
On 05/02/13 16:21, Peter Maydell wrote: > On 2 May 2013 15:17, Michael S. Tsirkin wrote: >> On Thu, May 02, 2013 at 03:09:04PM +0100, Peter Maydell wrote: > >> Sometimes I'm Cc'd on 1 patch out of series. >> I might not want to go dig out the series only >> to check if it actually needs review. >

Re: [Qemu-devel] [PATCH] trace: inline control-internal.h into control.h

2013-05-02 Thread Stefan Hajnoczi
On Thu, May 02, 2013 at 04:25:20PM +0200, Lluís Vilanova wrote: > Stefan Hajnoczi writes: > > > trace/control.h is the API for manipulating trace events in QEMU. Some > > of the implementation of this API lives in trace/control-internal.h. > > > Older versions of gcc complain because a static pr

Re: [Qemu-devel] [PATCH] blockdev: Replace "undefined error" in qmp_block_resize

2013-05-02 Thread Stefan Hajnoczi
On Thu, May 02, 2013 at 03:32:55PM +0200, Kevin Wolf wrote: > We have an errno value that can be displayed, so we should just do that. > An easy way to reproduce this case is to resize a raw image to a size > that is too large for the host file system. > > Signed-off-by: Kevin Wolf > --- > block

Re: [Qemu-devel] [RFC 7/7] target-i386: Disable direct passthrough of PMU CPUID leaf by default

2013-05-02 Thread Andreas Färber
Am 02.05.2013 16:43, schrieb Eduardo Habkost: > On Wed, May 01, 2013 at 01:14:48PM +0200, Andreas Färber wrote: >> Am 30.04.2013 21:57, schrieb Eduardo Habkost: >>> On Tue, Apr 30, 2013 at 07:04:23PM +0200, Igor Mammedov wrote: It's impossible to implement "n270 movbe" fixup with compat props

Re: [Qemu-devel] posting patches in pull requests (was Re: [PATCH 08/29] cpu: Add qemu_for_each_cpu())

2013-05-02 Thread Peter Maydell
On 2 May 2013 15:46, Gerd Hoffmann wrote: > On 05/02/13 16:21, Peter Maydell wrote: >> I think cc'ing somebody on half a pullrequest or series is >> a bit odd, personally. > > Not uncommon if you do this ... > > [sendemail] > to = qemu-devel@nongnu.org > cccmd = scripts/get_mai

Re: [Qemu-devel] posting patches in pull requests (was Re: [PATCH 08/29] cpu: Add qemu_for_each_cpu())

2013-05-02 Thread Stefan Hajnoczi
On Thu, May 02, 2013 at 04:51:43PM +0300, Michael S. Tsirkin wrote: > Anthony, can we please make it a rule that > all patches in pull request are tagged specially? > > As it is, patchwork is full of patches that were already reviewed and > merged, all my scripts that were filtering and sorting pa

Re: [Qemu-devel] [PATCH qom-cpu for-1.5 3/4] target-i386: Emulate X86CPU subclasses for global properties

2013-05-02 Thread Eduardo Habkost
On Wed, May 01, 2013 at 06:07:19PM +0200, Andreas Färber wrote: > After initializing the object from its x86_def_t and before setting any > additional -cpu arguments, set any global properties for the designated > subclass -{i386,x86_64}-cpu. > > Signed-off-by: Andreas Färber > --- > target-i386

Re: [Qemu-devel] [PATCH v5 0/6] vmdk: zeroed-grain GTE support

2013-05-02 Thread Stefan Hajnoczi
On Thu, May 02, 2013 at 10:25:21AM +0800, Fam Zheng wrote: > Added support for zeroed-grain GTE to VMDK according to VMDK Spec 5.0[1]. > > [1] Virtual Disk Format 5.0 - VMware, > http://www.vmware.com/support/developer/vddk/vmdk_50_technote.pdf?src=vmdk > > Changes since v4: > - 6/6: Correct

  1   2   >