Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-15 Thread Markus Armbruster
Alexey Kardashevskiy writes: > The assert.h header file from Fedora18 does not have #ifdef-#endif > brackets around __assert function so it cannot compile with > the -Wredundant-decls switch on. > > Some Linux distributions (such as Debian Wheezy) still do have those > brackets arounb __asser

Re: [Qemu-devel] [PATCH v2 2/5] register: Add Register API

2013-04-15 Thread Gerd Hoffmann
Hi, > - Add a "lite" flag that is (automatically) computed once that takes a > fast path through the read/write handlers. A reg is lite if it > requires no read-modify-write (no ro, nw, ge, ui, wtc). Only the > actual write and post_write handlers are executed. Sounds good to me. > - Remove th

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-15 Thread Alexey Kardashevskiy
On 04/15/2013 05:08 PM, Markus Armbruster wrote: Alexey Kardashevskiy writes: The assert.h header file from Fedora18 does not have #ifdef-#endif brackets around __assert function so it cannot compile with the -Wredundant-decls switch on. Some Linux distributions (such as Debian Wheezy) st

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-15 Thread Peter Maydell
On 15 April 2013 03:31, Alexey Kardashevskiy wrote: > The assert.h header file from Fedora18 does not have #ifdef-#endif > brackets around __assert function so it cannot compile with > the -Wredundant-decls switch on. > > Some Linux distributions (such as Debian Wheezy) still do have those > b

Re: [Qemu-devel] A crash problem about "loadvm"

2013-04-15 Thread Gerd Hoffmann
On 04/08/13 14:07, Stefan Hajnoczi wrote: > On Mon, Apr 01, 2013 at 07:56:33AM +, Liuji (Jeremy) wrote: >> I delete the "dev->sin = NULL;" in the last of "spice_char_device_reset" >> function. And the "loadvm" is OK. >> >> But I don't know whether this change will lead to other problems. Who c

Re: [Qemu-devel] [PATCH] target-arm: Reinsert SRS missing return statements.

2013-04-15 Thread Peter Maydell
On 15 April 2013 05:50, Peter Chubb wrote: > > > Since patch >81465888c5306cd94abb9847e560796fd13d3c2f >target-arm: factor out handling of SRS instruction > the SRS instruction has not worked in QEMU. > > The problem is a return directive that was removed in the > refactoring, so after dec

Re: [Qemu-devel] [PATCH] Update Makefile to actually install the new efi-enabled nic roms that are used by default.

2013-04-15 Thread Gerd Hoffmann
On 04/08/13 23:08, Sander Eikelenboom wrote: > Commit c45e5b5b30ac1f5505725a7b36e68cedfce4f01f made a switch use the > efi-enabled nic roms by default. > This patch updates the Makefile to install the roms so they can actually be > used. Reviewed-by: Gerd Hoffmann cheers, Gerd

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-15 Thread Alexey Kardashevskiy
On 04/15/2013 05:18 PM, Peter Maydell wrote: On 15 April 2013 03:31, Alexey Kardashevskiy wrote: The assert.h header file from Fedora18 does not have #ifdef-#endif brackets around __assert function so it cannot compile with the -Wredundant-decls switch on. Some Linux distributions (such as

Re: [Qemu-devel] [PATCH] target-arm: Reinsert SRS missing return statements.

2013-04-15 Thread Peter Chubb
> "Peter" == Peter Maydell writes: Peter> On 15 April 2013 05:50, Peter Chubb Peter> wrote: >> >> >> Since patch 81465888c5306cd94abb9847e560796fd13d3c2f target-arm: >> factor out handling of SRS instruction the SRS instruction has not >> worked in QEMU. >> >> The problem is a return dire

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-15 Thread Peter Maydell
On 15 April 2013 08:26, Alexey Kardashevskiy wrote: > On 04/15/2013 05:18 PM, Peter Maydell wrote: >> >> On 15 April 2013 03:31, Alexey Kardashevskiy wrote: >>> >>> The assert.h header file from Fedora18 does not have #ifdef-#endif >>> brackets around __assert function so it cannot compile wi

Re: [Qemu-devel] [PATCH] target-arm: Reinsert SRS missing return statements.

2013-04-15 Thread Peter Maydell
On 15 April 2013 08:29, Peter Chubb wrote: >> "Peter" == Peter Maydell writes: > Peter> On 15 April 2013 05:50, Peter Chubb > Peter> wrote: >>> The problem is a return directive that was removed in the >>> refactoring, so after decoding the instruction, qemu would fall >>> through to do stuf

Re: [Qemu-devel] [qemu-devel] Bug Report: VM crashed for some kinds of vCPU in nested virtualization

2013-04-15 Thread Jan Kiszka
On 2013-04-15 08:24, 李春奇 wrote: > Hi all, > In a nested virtualization environment of qemu+KVM, some emulated CPU (such > as core2duo) may cause L2 guest crash after booting for a while. Here's my > configuration: > > Host: > Linux 3.5.7 You should better use latest version from kvm.git [1], bra

Re: [Qemu-devel] [PATCH v4 11/33] tcg-ppc64: Improve constant add and sub ops.

2013-04-15 Thread Aurelien Jarno
On Thu, Apr 04, 2013 at 05:56:04PM -0500, Richard Henderson wrote: > Improve constant addition -- previously we'd emit useless addi with 0. > Use new constraints to force the driver to pull full 64-bit constants > into a register. > > Signed-off-by: Richard Henderson > --- > tcg/ppc64/tcg-target

Re: [Qemu-devel] [PATCH v4 08/33] tcg-ppc64: Fix setcond_i32

2013-04-15 Thread Aurelien Jarno
On Thu, Apr 04, 2013 at 05:56:01PM -0500, Richard Henderson wrote: > We weren't ignoring the high 32 bits during a NE comparison. > > Signed-off-by: Richard Henderson > --- > tcg/ppc64/tcg-target.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-15 Thread Alexey Kardashevskiy
On 04/15/2013 05:30 PM, Peter Maydell wrote: On 15 April 2013 08:26, Alexey Kardashevskiy wrote: On 04/15/2013 05:18 PM, Peter Maydell wrote: On 15 April 2013 03:31, Alexey Kardashevskiy wrote: The assert.h header file from Fedora18 does not have #ifdef-#endif brackets around __assert

Re: [Qemu-devel] [PATCH v4 25/33] tcg-ppc64: Cleanup i32 constants to tcg_out_cmp

2013-04-15 Thread Aurelien Jarno
On Thu, Apr 04, 2013 at 05:56:18PM -0500, Richard Henderson wrote: > Nothing else in the call chain ensures that these > constants don't have garbage in the high bits. > > Signed-off-by: Richard Henderson > --- > tcg/ppc64/tcg-target.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git

Re: [Qemu-devel] [PATCH v4 27/33] tcg-ppc64: Use MFOCRF instead of MFCR

2013-04-15 Thread Aurelien Jarno
On Thu, Apr 04, 2013 at 05:56:20PM -0500, Richard Henderson wrote: > It takes half the cycles to read one CR register instead of all 8. > This is a backward compatible addition to the ISA, so chips prior > to Power 2.00 spec will simply continue to read the entire CR register. > > Signed-off-by: R

Re: [Qemu-devel] [PATCH] ccid: Fix crash when backend isn't specified

2013-04-15 Thread Alon Levy
On Sun, 2013-04-14 at 16:06 -0400, Cole Robinson wrote: > Reproducer: > > ./x86_64-softmmu/qemu-system-x86_64 -device usb-ccid,id=ccid0 -usb -device > ccid-card-emulated -monitor stdio > ACK, thanks. Marc-Andre, could you review the fixed patches I sent previously, and then I can put this on t

Re: [Qemu-devel] [PATCH v4 19/33] tcg-ppc64: Implement bswap16 and bswap32

2013-04-15 Thread Aurelien Jarno
On Thu, Apr 04, 2013 at 05:56:12PM -0500, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/ppc64/tcg-target.c | 43 +++ > tcg/ppc64/tcg-target.h | 8 > 2 files changed, 47 insertions(+), 4 deletions(-) > > diff --git a/tcg/

Re: [Qemu-devel] [PATCH v4 12/33] tcg-ppc64: Allow constant first argument to sub

2013-04-15 Thread Aurelien Jarno
On Thu, Apr 04, 2013 at 05:56:05PM -0500, Richard Henderson wrote: > Using SUBFIC for 16-bit signed constants. > > Signed-off-by: Richard Henderson > --- > tcg/ppc64/tcg-target.c | 21 + > 1 file changed, 17 insertions(+), 4 deletions(-) > > diff --git a/tcg/ppc64/tcg-target

[Qemu-devel] [PATCH] acpi.h: make it self contained

2013-04-15 Thread Michael S. Tsirkin
Headers shouldn't assume another header is included, pull in everything necessary. Signed-off-by: Michael S. Tsirkin --- include/hw/acpi/acpi.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/hw/acpi/acpi.h b/include/hw/acpi/acpi.h index 35f7e09..88f7378 100644 --- a/include/hw

Re: [Qemu-devel] [PATCH v4 30/33] tcg-ppc64: Use getauxval for ISA detection

2013-04-15 Thread Aurelien Jarno
On Thu, Apr 04, 2013 at 05:56:23PM -0500, Richard Henderson wrote: > Glibc 2.16 includes an easy way to get feature bits previously > buried in /proc or the program startup auxiliary vector. Use it. > > Signed-off-by: Richard Henderson > --- > configure | 18 ++ > t

Re: [Qemu-devel] [PATCH v4 28/33] tcg-ppc64: Use ISEL for setcond

2013-04-15 Thread Aurelien Jarno
On Thu, Apr 04, 2013 at 05:56:21PM -0500, Richard Henderson wrote: > There are a few simple special cases that should be handled first. > Break these out to subroutines to avoid code duplication. > > Signed-off-by: Richard Henderson > --- > tcg/ppc64/tcg-target.c | 181 > +++

Re: [Qemu-devel] [PATCH v4 33/33] tcg-ppc64: Handle deposit of zero

2013-04-15 Thread Aurelien Jarno
On Thu, Apr 04, 2013 at 05:56:26PM -0500, Richard Henderson wrote: > The TCG optimizer does great work when inserting constants, being able > to fold the open-coded deposit expansion to just an AND or an OR. Avoid > a bit the regression caused by having the deposit opcode by expanding > deposit of

[Qemu-devel] [PATCH] qemu-iotests: filter QEMU_PROG in 051.out

2013-04-15 Thread Stefan Hajnoczi
Filter the name of the QEMU executable so the output can be diffed no matter what QEMU_PROG is (e.g. qemu-system-x86_64). Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/051 | 2 +- tests/qemu-iotests/051.out | 72 tests/qemu-iotest

Re: [Qemu-devel] [PATCH] acpi: move declarations from pc.h to acpi.h

2013-04-15 Thread Paolo Bonzini
Il 15/04/2013 08:19, Michael S. Tsirkin ha scritto: > Functions defined in acpi/ should be declared in > acpi.h > > Signed-off-by: Michael S. Tsirkin Thanks, I'll include it in the pull request. Paolo

[Qemu-devel] [PULL 00/11] Block patches

2013-04-15 Thread Stefan Hajnoczi
The following changes since commit e2ec3f976803b360c70d9ae2ba13852fa5d11665: qjson: to_json() case QTYPE_QSTRING is buggy, rewrite (2013-04-13 19:40:25 +) are available in the git repository at: git://github.com/stefanha/qemu.git block for you to fetch changes up to dc7588c1eb3008bda53

[Qemu-devel] [PATCH 01/11] block: Introduce bdrv_writev_vmstate

2013-04-15 Thread Stefan Hajnoczi
From: Kevin Wolf Signed-off-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- block.c | 25 - block/qcow2.c | 12 +--- block/sheepdog.c | 13 ++--- include/block/block.h | 1 + include/block/block_int.h | 4 ++

[Qemu-devel] [PATCH 06/11] qemu-iotests: filter QEMU_PROG in 051.out

2013-04-15 Thread Stefan Hajnoczi
Filter the name of the QEMU executable so the output can be diffed no matter what QEMU_PROG is (e.g. qemu-system-x86_64). Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/051 | 2 +- tests/qemu-iotests/051.out | 72 tests/qemu-iotest

[Qemu-devel] [PATCH 03/11] block: Introduce bdrv_pwritev() for qcow2_save_vmstate

2013-04-15 Thread Stefan Hajnoczi
From: Kevin Wolf Directly pass the QEMUIOVector on instead of linearising it. Signed-off-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- block.c | 80 +-- block/qcow2.c | 8 +- include/block/block.h | 2 ++ 3 files

[Qemu-devel] [PATCH 04/11] qemu-iotests: A few more bdrv_pread/pwrite tests

2013-04-15 Thread Stefan Hajnoczi
From: Kevin Wolf Signed-off-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/002 | 13 + tests/qemu-iotests/002.out | 26 ++ 2 files changed, 39 insertions(+) diff --git a/tests/qemu-iotests/002 b/tests/qemu-iotests/002 index bebed84

[Qemu-devel] [PATCH 10/11] iotests: Add 'check -ssh' option to test Secure Shell block device.

2013-04-15 Thread Stefan Hajnoczi
From: "Richard W.M. Jones" Note in order to run these tests on ssh, you must be running a local ssh daemon, and that daemon must accept loopback connections, and ssh-agent has to be set up to allow logins on the local daemon. In other words, the following command should just work without demandi

[Qemu-devel] [PATCH 11/11] rbd: add an asynchronous flush

2013-04-15 Thread Stefan Hajnoczi
From: Josh Durgin The existing bdrv_co_flush_to_disk implementation uses rbd_flush(), which is sychronous and causes the main qemu thread to block until it is complete. This results in unresponsiveness and extra latency for the guest. Fix this by using an asynchronous version of flush. This was

[Qemu-devel] [PATCH 07/11] ide: refuse WIN_READ_NATIVE_MAX on empty device

2013-04-15 Thread Stefan Hajnoczi
What is the highest addressable sector on an empty CD-ROM? Nothing is addressable so produce an error. This patch prevents a divide-by-zero in ide_set_sector() since s->sectors and s->heads would be 0. Not to mention that a sector=-1 argument would be nonsense. Note that WIN_READ_NATIVE_MAX can

Re: [Qemu-devel] [PATCH qom-cpu-next 1/2] target-i386/cpu.c: Coding style fixes

2013-04-15 Thread Igor Mammedov
On Thu, 11 Apr 2013 17:07:23 -0300 Eduardo Habkost wrote: > * Add braces to 'if' statements; > * Remove last TAB character from the source. > > Signed-off-by: Eduardo Habkost > --- > target-i386/cpu.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/target-i38

[Qemu-devel] [PATCH 09/11] block: ssh: Use libssh2_sftp_fsync (if supported by libssh2) to flush to disk.

2013-04-15 Thread Stefan Hajnoczi
From: "Richard W.M. Jones" libssh2_sftp_fsync is an extension to libssh2 to support fsync(2) over sftp, which is itself an extension of OpenSSH. If both libssh2 and the ssh daemon support it, this will allow bdrv_flush_to_disk to commit changes through to disk on the remote server. Signed-off-b

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-15 Thread Paolo Bonzini
Il 14/04/2013 21:06, Michael R. Hines ha scritto: > >> 3. Migration with RDMA support is experimental and unsupported. >> In particular, please do not expect it to work across qemu versions, >> and do not expect the management interface to be stable. >> > > The only correct statement

Re: [Qemu-devel] [PATCH V2 18/20] virtio-net: multiqueue support

2013-04-15 Thread Aurelien Jarno
On Mon, Apr 15, 2013 at 01:29:01PM +0800, Jason Wang wrote: > On 04/13/2013 09:17 PM, Aurelien Jarno wrote: > > On Fri, Jan 25, 2013 at 06:35:41PM +0800, Jason Wang wrote: > >> This patch implements both userspace and vhost support for multiple queue > >> virtio-net (VIRTIO_NET_F_MQ). This is done

[Qemu-devel] [PATCH 08/11] block: Add support for Secure Shell (ssh) block device.

2013-04-15 Thread Stefan Hajnoczi
From: "Richard W.M. Jones" qemu-system-x86_64 -drive file=ssh://hostname/some/image QEMU will ssh into 'hostname' and open '/some/image' which is made available as a standard block device. You can specify a username (ssh://user@host/...) and/or a port number (ssh://host:port/...). You can al

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-15 Thread Paolo Bonzini
Il 15/04/2013 03:06, Michael R. Hines ha scritto: > Next, decide if you want dynamic page registration on the server-side. > For example, if you have an 8GB RAM virtual machine, but only 1GB > is in active use, then disabling this feature will cause all 8GB to > be pinned and reside

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-15 Thread Paolo Bonzini
Il 15/04/2013 03:10, Michael R. Hines ha scritto: >>> >> And when someone writes them one day, we'll have to carry the old code >> around for interoperability as well. Not pretty. To avoid that, you >> need to explicitly say in the documenation that it's experimental and >> unsupported. >> > > Th

[Qemu-devel] [PATCH 02/11] savevm: Implement block_writev_buffer()

2013-04-15 Thread Stefan Hajnoczi
From: Kevin Wolf Instead of breaking up RAM state into many small chunks, pass the iovec to the block layer for better performance. Signed-off-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- include/migration/qemu-file.h | 2 +- savevm.c | 25 +

Re: [Qemu-devel] [PATCH qom-cpu-next 2/2] target-i386: Replace cpuid_*features fields with a feature word array

2013-04-15 Thread Igor Mammedov
On Thu, 11 Apr 2013 17:07:24 -0300 Eduardo Habkost wrote: > This replaces the feature-bit fields on both X86CPU and x86_def_t > structs with an array. > > With this, we will be able to simplify code that simply does the same > operation on all feature words (e.g. kvm_check_features_against_host(

[Qemu-devel] [PATCH 05/11] qemu-iotests: Add test for -drive options

2013-04-15 Thread Stefan Hajnoczi
From: Kevin Wolf Signed-off-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/051 | 148 + tests/qemu-iotests/051.out | 162 + tests/qemu-iotests/group | 1 + 3 files changed, 311 ins

[Qemu-devel] unable to boot systemrescuecd with tcg only?

2013-04-15 Thread Michael S. Tsirkin
Get system rescue CD version 2.8.0 here: http://www.sysresccd.org/Sysresccd-versions Verify md5 checksum: 450305b2c3ac12d5c97ff849ca178586 Try to boot: ./x86_64-softmmu/qemu-system-x86_64 -net user -net nic -snapshot -cdrom \ ~/images/systemrescuecd-x86-2.8.0.iso Select option: all files cache

Re: [Qemu-devel] [PATCH v3 0/7] virtio-net refactoring.

2013-04-15 Thread Cornelia Huck
On Thu, 11 Apr 2013 16:29:55 +0200 fred.kon...@greensocs.com wrote: > From: KONRAD Frederic > > This is the next part of virtio-refactoring. > > Basically it creates virtio-net-device which extends virtio-device. > Then a virtio-net-device can be connected on a virtio-bus. > virtio-net-pci, vir

Re: [Qemu-devel] [PATCH 01/15] block: Fail gracefully when using a format driver on protocol level

2013-04-15 Thread Kevin Wolf
Am 13.04.2013 um 00:50 hat Eric Blake geschrieben: > On 04/12/2013 02:47 PM, Kevin Wolf wrote: > > Specifying the wrong driver could fail an assertion: > > > > $ qemu-system-x86_64 -drive file.driver=qcow2,file=x > > qemu-system-x86_64: block.c:721: bdrv_open_common: Assertion `file != > > ((void

Re: [Qemu-devel] [PATCH 03/19] cpu: make kvm-stub.o a part of CPU library

2013-04-15 Thread Igor Mammedov
On Fri, 12 Apr 2013 16:25:11 -0300 Eduardo Habkost wrote: > On Fri, Apr 12, 2013 at 01:17:32PM +0200, Igor Mammedov wrote: > [...] > > > [...] > > > > diff --git a/include/hw/pci/msi.h b/include/hw/pci/msi.h > > index d4d0450..c159a15 100644 > > --- a/include/hw/pci/msi.h > > +++ b/include/hw/p

Re: [Qemu-devel] [PATCH] hw: Add lost ARM core again

2013-04-15 Thread Paolo Bonzini
Il 14/04/2013 22:52, Stefan Weil ha scritto: > Commit 0434e30afb6175212389811e0b28b948eb3c1e40 accidentally removed > the compilation of arm11mpcore.c. > > Signed-off-by: Stefan Weil > --- > default-configs/arm-softmmu.mak |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --gi

Re: [Qemu-devel] unable to boot systemrescuecd with tcg only?

2013-04-15 Thread Michael S. Tsirkin
On Mon, Apr 15, 2013 at 11:53:12AM +0300, Michael S. Tsirkin wrote: > Get system rescue CD version 2.8.0 here: > http://www.sysresccd.org/Sysresccd-versions > > Verify md5 checksum: 450305b2c3ac12d5c97ff849ca178586 Note: tried version 2.1.0, that boots fine. Tried version 3.5.0, that hangs on boo

[Qemu-devel] [PATCH 0/2 RFC] Support for LED state extension to Qemu VNC server

2013-04-15 Thread Lei Li
Hi guys, This patch series tries to add support for LED state extension to Qemu VNC server. The proposal has been sent few days ago as link below: http://lists.gnu.org/archive/html/qemu-devel/2013-04/msg01421.html This is just an initial implementation, and has not been completely tested. To cat

[Qemu-devel] [PATCH 2/2] vnc: Support for LED state extension

2013-04-15 Thread Lei Li
Signed-off-by: Lei Li --- ui/vnc.c | 50 ++ ui/vnc.h |3 ++- 2 files changed, 52 insertions(+), 1 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index fa7ab94..b9b3766 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -1529,6 +1529,33 @@ static void pre

[Qemu-devel] [PATCH 1/2] vnc: Add SCROLL lock key to kbd_leds

2013-04-15 Thread Lei Li
Signed-off-by: Lei Li --- ui/vnc.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 5ddb696..fa7ab94 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -1532,10 +1532,11 @@ static void press_key(VncState *vs, int keysym) static void kbd_leds(void *opaq

[Qemu-devel] [PATCH 0/3] acpi: more infrastructure cleanups

2013-04-15 Thread Michael S. Tsirkin
I wanted to help Laszlo completely move ACPI tables out of seabios in time for 1.5, but had to put out some fires so didn't manage to do this in time, and going offline for now. Meanwhile, here is some refactoring that I did complete. This does not do much by itself, but works fine for me and wil

[Qemu-devel] [PATCH 1/3] acpi: move declarations from pc.h to acpi.h

2013-04-15 Thread Michael S. Tsirkin
Functions defined in acpi/ should be declared in acpi.h Signed-off-by: Michael S. Tsirkin --- arch_init.c| 1 + hw/i386/pc.c | 1 + hw/i386/pc_piix.c | 1 + include/hw/acpi/acpi.h | 10 ++ include/hw/i386/pc.h | 8 5 files changed, 13 insertions(

[Qemu-devel] [PATCH 2/3] acpi: add acpi_table_add_hdr

2013-04-15 Thread Michael S. Tsirkin
Export a function for magling headers, without updating the global acpitables blob. Signed-off-by: Michael S. Tsirkin --- hw/acpi/core.c | 97 +++--- include/hw/acpi/acpi.h | 4 +++ 2 files changed, 72 insertions(+), 29 deletions(-) diff --gi

[Qemu-devel] [PATCH 3/3] acpi.h: make it self contained

2013-04-15 Thread Michael S. Tsirkin
Headers shouldn't assume another header is included, pull in everything necessary. Signed-off-by: Michael S. Tsirkin --- include/hw/acpi/acpi.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/hw/acpi/acpi.h b/include/hw/acpi/acpi.h index 35f7e09..88f7378 100644 --- a/include/hw

Re: [Qemu-devel] [PATCH 07/19] rtc: update rtc_cmos on CPU hot-plug

2013-04-15 Thread Igor Mammedov
On Fri, 12 Apr 2013 18:24:23 +0200 Igor Mammedov wrote: > On Fri, 12 Apr 2013 12:35:14 -0300 > Eduardo Habkost wrote: > > > On Fri, Apr 12, 2013 at 05:16:20PM +0200, Igor Mammedov wrote: > > > On Fri, 12 Apr 2013 10:35:53 -0300 > > > Eduardo Habkost wrote: > > > > > > > On Fri, Apr 12, 2013 a

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-15 Thread Markus Armbruster
Alexey Kardashevskiy writes: > On 04/15/2013 05:08 PM, Markus Armbruster wrote: >> Alexey Kardashevskiy writes: >> >>> The assert.h header file from Fedora18 does not have #ifdef-#endif >>> brackets around __assert function so it cannot compile with >>> the -Wredundant-decls switch on. >>> >

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-15 Thread Alexey Kardashevskiy
On 04/15/2013 06:23 PM, Markus Armbruster wrote: Alexey Kardashevskiy writes: On 04/15/2013 05:08 PM, Markus Armbruster wrote: Alexey Kardashevskiy writes: The assert.h header file from Fedora18 does not have #ifdef-#endif brackets around __assert function so it cannot compile with the

[Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

2013-04-15 Thread Janne Karhunen
LK: Ok, good catch, that might be more suitable option. Thanks, -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/955379 Title: cmake hangs with qemu-arm-static Status in QEMU: Confirmed Status in L

[Qemu-devel] [PATCH v2] target-arm: Reinsert SRS missing return statement.

2013-04-15 Thread Peter Chubb
Since patch 81465888c5306cd94abb9847e560796fd13d3c2f target-arm: factor out handling of SRS instruction the SRS instruction has not worked in QEMU. The problem is a missing return directive that was removed in the refactoring, so after decoding the instruction, qemu would do all the generic

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-15 Thread Peter Maydell
On 15 April 2013 10:50, Alexey Kardashevskiy wrote: > /home/alexey/pcipassthru/qemu-impreza/../lib4qemu/usr/include/assert.h:67:13: > error: redundant redeclaration of '__assert_fail' [-Werror=redundant-decls] > /home/alexey/pcipassthru/qemu-impreza/../lib4qemu/usr/include/assert.h:67:13: > note:

Re: [Qemu-devel] [PATCH v2] target-arm: Reinsert SRS missing return statement.

2013-04-15 Thread Peter Maydell
On 15 April 2013 10:53, Peter Chubb wrote: > > Since patch >81465888c5306cd94abb9847e560796fd13d3c2f >target-arm: factor out handling of SRS instruction > the SRS instruction has not worked in QEMU. > > The problem is a missing return directive that was removed in the > refactoring, so aft

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-15 Thread Peter Maydell
On 15 April 2013 11:01, Peter Maydell wrote: > This copy of assert.h seems to be broken. The declarations > should be guarded (by _ASSERT_H_DECLS in my system's copy). FWIW, the _ASSERT_H_DECLS fix appears to be a Debian specific patch (added in 2003; I can't find any record of it ever being subm

Re: [Qemu-devel] [PATCH 1/3] acpi: move declarations from pc.h to acpi.h

2013-04-15 Thread Paolo Bonzini
Il 15/04/2013 11:37, Michael S. Tsirkin ha scritto: > +/* acpi.c */ > +extern int acpi_enabled; > +extern char unsigned *acpi_tables; > +extern size_t acpi_tables_len; > + > +void acpi_table_install(const char unsigned *blob, size_t bloblen, > +bool has_header, const struct

[Qemu-devel] [PATCH v2] net: make network client name unique

2013-04-15 Thread Amos Kong
assign_name() creates a name MODEL.NUM, where MODEL is the client's model, and NUM is the number of MODELs that already exist. Markus added NIC naming for non-VLAN clients in commit 53e51d85. commit d33d93b2 incorrectly added a judgement of net-hub. It caused net clients created with -netdev get s

Re: [Qemu-devel] [PATCH 1/3] acpi: move declarations from pc.h to acpi.h

2013-04-15 Thread Laszlo Ersek
On 04/15/13 12:42, Paolo Bonzini wrote: > Il 15/04/2013 11:37, Michael S. Tsirkin ha scritto: >> +/* acpi.c */ >> +extern int acpi_enabled; >> +extern char unsigned *acpi_tables; >> +extern size_t acpi_tables_len; >> + >> +void acpi_table_install(const char unsigned *blob, size_t bloblen, >> +

Re: [Qemu-devel] qemu-img: error while compressing, Input/output error

2013-04-15 Thread Ilkka Tengvall
On 15.04.2013 09:52, Stefan Hajnoczi wrote: I discussed the bug with kwolf on Friday. Although I sent a patch to add an error message when the input image length is not a multiple of cluster_size, Kevin pointed out that we can allow the final cluster to be zero-padded beyond the end of the virtu

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-15 Thread Peter Maydell
On 15 April 2013 11:52, Alexey Kardashevskiy wrote: > I suspect I am getting these errors because I am the only person who is > trying to cross compile or/and when host and target endianness differ. Cross compilation or otherwise should have zero effect here. You may be hitting more issues becaus

Re: [Qemu-devel] [PATCH 1/3] acpi: move declarations from pc.h to acpi.h

2013-04-15 Thread Paolo Bonzini
Il 15/04/2013 13:00, Laszlo Ersek ha scritto: >> > >>> >> +void acpi_table_add(const QemuOpts *opts, Error **errp); > Doesn't this series conflict with my pending > ? Yeah, but the conflicts are trivial. Paolo

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-15 Thread Alexey Kardashevskiy
On 04/15/2013 08:01 PM, Peter Maydell wrote: On 15 April 2013 10:50, Alexey Kardashevskiy wrote: /home/alexey/pcipassthru/qemu-impreza/../lib4qemu/usr/include/assert.h:67:13: error: redundant redeclaration of '__assert_fail' [-Werror=redundant-decls] /home/alexey/pcipassthru/qemu-impreza/../lib

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-15 Thread Alexey Kardashevskiy
On 04/15/2013 09:00 PM, Peter Maydell wrote: On 15 April 2013 11:52, Alexey Kardashevskiy wrote: I suspect I am getting these errors because I am the only person who is trying to cross compile or/and when host and target endianness differ. Cross compilation or otherwise should have zero effec

Re: [Qemu-devel] qemu-img: error while compressing, Input/output error

2013-04-15 Thread Stefan Hajnoczi
On Mon, Apr 15, 2013 at 1:00 PM, Ilkka Tengvall wrote: > On 15.04.2013 09:52, Stefan Hajnoczi wrote: >> >> I discussed the bug with kwolf on Friday. Although I sent a patch to >> add an error message when the input image length is not a multiple of >> cluster_size, Kevin pointed out that we can a

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-15 Thread Peter Maydell
On 15 April 2013 12:08, Alexey Kardashevskiy wrote: > On 04/15/2013 09:00 PM, Peter Maydell wrote: >> You may be hitting more issues because your target libc happens to be >> one that not very many other people are targetting. > > > Is standard glibc not popular any more? Wow. Neither RHEL (5.0+)

Re: [Qemu-devel] [PATCH 0/3] acpi: more infrastructure cleanups

2013-04-15 Thread Michael S. Tsirkin
On Mon, Apr 15, 2013 at 12:37:37PM +0300, Michael S. Tsirkin wrote: > I wanted to help Laszlo completely move ACPI tables out of seabios in > time for 1.5, but had to put out some fires so didn't manage to do this > in time, and going offline for now. > > Meanwhile, here is some refactoring that I

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-15 Thread Alexey Kardashevskiy
On 04/15/2013 09:14 PM, Peter Maydell wrote: On 15 April 2013 12:08, Alexey Kardashevskiy wrote: On 04/15/2013 09:00 PM, Peter Maydell wrote: You may be hitting more issues because your target libc happens to be one that not very many other people are targetting. Is standard glibc not popul

[Qemu-devel] [PATCH] target-mips: fix mipsdsp_mul_q15_q15 and tests for MAQ_SA_Q_PHL/PHR

2013-04-15 Thread Petar Jovanovic
From: Petar Jovanovic The operands for MAQ_SA_W.PHL/MAQ_SA_W.PHR must in specified format. Otherwise, the results are unpredictable. Once the operands were corrected in the tests (part of this change), a bug in mipsdsp_mul_q15_q15 became visible. This change corrects the tests for MAQ_SA_W.PHL/M

Re: [Qemu-devel] [PATCH 01/15] block: Fail gracefully when using a format driver on protocol level

2013-04-15 Thread Markus Armbruster
Kevin Wolf writes: > Am 13.04.2013 um 00:50 hat Eric Blake geschrieben: >> On 04/12/2013 02:47 PM, Kevin Wolf wrote: >> > Specifying the wrong driver could fail an assertion: >> > >> > $ qemu-system-x86_64 -drive file.driver=qcow2,file=x >> > qemu-system-x86_64: block.c:721: bdrv_open_common: As

Re: [Qemu-devel] [PATCH] target-mips: fix mipsdsp_mul_q15_q15 and tests for MAQ_SA_Q_PHL/PHR

2013-04-15 Thread Petar Jovanovic
There is a typo in the subject, it should say: "target-mips: fix mipsdsp_mul_q15_q15 and tests for MAQ_SA_W_PHL/PHR" Petar From: Petar Jovanovic [petar.jovano...@rt-rk.com] Sent: Monday, April 15, 2013 1:54 PM To: qemu-devel@nongnu.org Cc: Petar Jovanovic;

[Qemu-devel] [PATCH uq/master v3 0/2] correctly reset the CPU on INIT interrupts

2013-04-15 Thread Paolo Bonzini
These patches finally implement INIT entirely in userspace. The problem here was that the CPU was being reset after kvm_arch_reset_vcpu is called. This made it harder to hook into the reset process and put APs into KVM_MP_STATE_INIT_RECEIVED state (instead of KVM_MP_STATE_UNINITIALIZED which is th

[Qemu-devel] [PATCH uq/master v3 1/2] kvm: reset state from the CPU's reset method

2013-04-15 Thread Paolo Bonzini
Now that we have a CPU object with a reset method, it is better to keep the KVM reset close to the CPU reset. Using qemu_register_reset as we do now keeps them far apart. Signed-off-by: Paolo Bonzini --- v2->v3: add stub kvm_arch_reset_vcpu for s390 include/sysemu/kvm.h | 2 -- kvm-

[Qemu-devel] [PATCH uq/master v3 2/2] kvm: forward INIT signals coming from the chipset

2013-04-15 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- target-i386/helper.c | 4 target-i386/kvm.c | 37 ++--- target-i386/kvm_i386.h | 1 + 3 files changed, 31 insertions(+), 11 deletions(-) diff --git a/target-i386/helper.c b/target-i386/helper.c index 282494f..c01d8eb

Re: [Qemu-devel] [PATCH] linux-user: change do_semop to return target errno when unsuccessful

2013-04-15 Thread Petar Jovanovic
+ qemu-triv...@nongnu.org ping From: Petar Jovanovic Sent: Monday, April 08, 2013 8:31 PM To: Peter Maydell; Petar Jovanovic Cc: qemu-devel@nongnu.org; riku.voi...@linaro.org Subject: RE: [Qemu-devel] [PATCH] linux-user: change do_semop to return target er

Re: [Qemu-devel] [PATCH v4 00/11] convert savevm to use qapi and introduce qmp command

2013-04-15 Thread Kevin Wolf
Am 11.04.2013 um 11:20 hat Markus Armbruster geschrieben: > [Cc: Wenchao Xia because of overlap with his work] > > Eric Blake writes: > > > On 04/10/2013 08:05 AM, Pavel Hrdina wrote: > >> Here is another proposal how to handle vm snapshots: > >> > >> QMP vm-snapshot-save: > >> - { 'command

Re: [Qemu-devel] [PATCH uq/master v3 1/2] kvm: reset state from the CPU's reset method

2013-04-15 Thread Andreas Färber
Am 15.04.2013 14:05, schrieb Paolo Bonzini: > Now that we have a CPU object with a reset method, it is better to > keep the KVM reset close to the CPU reset. Using qemu_register_reset > as we do now keeps them far apart. > > Signed-off-by: Paolo Bonzini > --- > v2->v3: add stub kvm_arch_re

Re: [Qemu-devel] Virtualbox svga card in KVM

2013-04-15 Thread Gerd Hoffmann
On 04/08/13 17:11, Peter Maydell wrote: > On 6 April 2013 00:52, Sriram Murthy wrote: >> (actually, the virtualbox SVGA card is based off of the KVM VGA card) > > Is it possible to implement it as an extension to the VGA > card device, or has it diverged incompatibly such that it > has to be its

Re: [Qemu-devel] [PULL] pci: add pci test device

2013-04-15 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > The following changes since commit e2ec3f976803b360c70d9ae2ba13852fa5d11665: > > qjson: to_json() case QTYPE_QSTRING is buggy, rewrite (2013-04-13 19:40:25 > +) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.g

Re: [Qemu-devel] Support for VNC LED state extension proposal

2013-04-15 Thread Gerd Hoffmann
Hi, > When access a guest by console through VNC, there might be > mismatch between the lock keys notification LED on the computer > running the VNC client session and the current status of the lock > keys on the guest machine. This happens because the VNC protocol > does not have any support to

[Qemu-devel] Curious about relaxation of bdrv_is_sg() for scsi-generic

2013-04-15 Thread Markus Armbruster
Commit 9839245 "ISCSI: Add SCSI passthrough via scsi-generic to libiscsi" contains this hunk: diff --git a/hw/scsi-generic.c b/hw/scsi-generic.c index d856d23..8d51060 100644 --- a/hw/scsi-generic.c +++ b/hw/scsi-generic.c @@ -400,12 +400,6 @@ static int scsi_generic_initfn(SCSIDevice *s)

Re: [Qemu-devel] [PATCH uq/master v3 1/2] kvm: reset state from the CPU's reset method

2013-04-15 Thread Paolo Bonzini
Il 15/04/2013 14:20, Andreas Färber ha scritto: > Fine with me. > > Have you tested whether i386 needs a similar stub on non-x86? If so then > > Reviewed-by: Andreas Färber It doesn't need it, because the prototype is declared always in kvm_i386.h. I didn't test non-x86, but I tested an altern

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-15 Thread Markus Armbruster
Alexey Kardashevskiy writes: > On 04/15/2013 08:01 PM, Peter Maydell wrote: >> On 15 April 2013 10:50, Alexey Kardashevskiy wrote: >>> /home/alexey/pcipassthru/qemu-impreza/../lib4qemu/usr/include/assert.h:67:13: >>> error: redundant redeclaration of '__assert_fail' [-Werror=redundant-decls] >>>

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-15 Thread Alexey Kardashevskiy
On 04/15/2013 10:57 PM, Markus Armbruster wrote: Alexey Kardashevskiy writes: On 04/15/2013 08:01 PM, Peter Maydell wrote: On 15 April 2013 10:50, Alexey Kardashevskiy wrote: /home/alexey/pcipassthru/qemu-impreza/../lib4qemu/usr/include/assert.h:67:13: error: redundant redeclaration of '__a

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-15 Thread Michael R. Hines
On 04/15/2013 04:28 AM, Paolo Bonzini wrote: Il 15/04/2013 03:06, Michael R. Hines ha scritto: Next, decide if you want dynamic page registration on the server-side. For example, if you have an 8GB RAM virtual machine, but only 1GB is in active use, then disabling this feature will cause all 8GB

Re: [Qemu-devel] Curious about relaxation of bdrv_is_sg() for scsi-generic

2013-04-15 Thread Paolo Bonzini
Il 15/04/2013 14:41, Markus Armbruster ha scritto: > Commit 9839245 "ISCSI: Add SCSI passthrough via scsi-generic to > libiscsi" contains this hunk: > > diff --git a/hw/scsi-generic.c b/hw/scsi-generic.c > index d856d23..8d51060 100644 > --- a/hw/scsi-generic.c > +++ b/hw/scsi-generic.c > @@ -400,

Re: [Qemu-devel] [PATCH] mainloop.c: Keep unlocking BQL during busy-wait spin-out

2013-04-15 Thread Anthony Liguori
Peter Crosthwaite writes: > Modify Anthony's starvation detection logic to keep the BQL unlocked > until the starvation condition goes away. Otherwise the counter has to > count up to 1000 for each needed iteration until the busy-wait is > lifted. > > Reset the counter back to zero once glib_poll

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-15 Thread Michael R. Hines
On 04/15/2013 02:00 AM, Michael S. Tsirkin wrote: On Sun, Apr 14, 2013 at 09:06:36PM -0400, Michael R. Hines wrote: On 04/14/2013 05:10 PM, Michael S. Tsirkin wrote: On Sun, Apr 14, 2013 at 03:06:11PM -0400, Michael R. Hines wrote: On 04/14/2013 02:30 PM, Michael S. Tsirkin wrote: On Sun, Apr

Re: [Qemu-devel] [PATCH v3 0/8] virtio-rng refactoring.

2013-04-15 Thread Cornelia Huck
On Sun, 14 Apr 2013 15:01:02 +0200 fred.kon...@greensocs.com wrote: > From: KONRAD Frederic > > This is the last backend of the refactoring. > > Basically it creates virtio-rng-device which extends virtio-device. > Then a virtio-rng-device can be connected on a virtio-bus. > virtio-rng-pci, vir

Re: [Qemu-devel] [PATCH] mainloop.c: Keep unlocking BQL during busy-wait spin-out

2013-04-15 Thread Paolo Bonzini
Il 15/04/2013 15:08, Anthony Liguori ha scritto: >> > Signed-off-by: Peter Crosthwaite > I'm going through patches for 1.5 candidates. > > I believe the paste performance issue has been resolved now and this > patch is no longer needed. I can't find a definitive statement on the > list for that

Re: [Qemu-devel] [PATCH] virtio-rng-s390: add properties.

2013-04-15 Thread Cornelia Huck
On Sun, 14 Apr 2013 15:14:49 +0200 fred.kon...@greensocs.com wrote: > From: KONRAD Frederic > > I don't see any reason why these properties are missing. Acked-by: Cornelia Huck > > Cc: Cornelia Huck > Cc: Alexander Graf > Signed-off-by: KONRAD Frederic > > Note: Need to apply virtio-rng-

  1   2   3   4   5   >