Re: [Qemu-devel] [PATCH v2] rbd: add an asynchronous flush

2013-04-12 Thread Stefan Hajnoczi
On Fri, Apr 12, 2013 at 08:50:35AM +0200, Kevin Wolf wrote: > Am 11.04.2013 um 19:19 hat Josh Durgin geschrieben: > > On 04/11/2013 01:48 AM, Kevin Wolf wrote: > > >Am 11.04.2013 um 10:02 hat Stefan Hajnoczi geschrieben: > > >>On Wed, Apr 10, 2013 at 07:03:39AM -0700, Josh Durgin wrote: > > >>>On 0

Re: [Qemu-devel] [RFC PATCH v3 0/5] port network layer onto glib

2013-04-12 Thread Stefan Hajnoczi
On Thu, Apr 11, 2013 at 08:05:05PM +0800, liu ping fan wrote: > On Thu, Apr 11, 2013 at 7:44 PM, Stefan Hajnoczi wrote: > > On Thu, Apr 11, 2013 at 11:13 AM, liu ping fan wrote: > >> On Wed, Apr 10, 2013 at 7:55 PM, Stefan Hajnoczi > >> wrote: > >>> On Wed, Apr 10, 2013 at 03:47:15PM +0800, liu

Re: [Qemu-devel] [RFC 00/13] aio: drop io_flush()

2013-04-12 Thread Kevin Wolf
Am 11.04.2013 um 17:44 hat Stefan Hajnoczi geschrieben: > Here's my entry to the "let's get rid of io_flush()" effort. It's based on > Paolo's insight about bdrv_drain_all() that the block layer already has a > tracked_requests list. io_flush() is redundant since the block layer already > knows i

Re: [Qemu-devel] [RFC][PATCH 00/22] instrument: Let the user wrap/override specific event tracing routines

2013-04-12 Thread Stefan Hajnoczi
On Thu, Apr 11, 2013 at 02:29:32PM +0200, Lluís Vilanova wrote: > Stefan Hajnoczi writes: > [...] > > Sorry Lluís, I'm slow with review here again. Will take a look for 1.4 > > soft-freeze though. > > Dont' worry, there's a couple things I have to redo in this series: > > * Properly handle qi_in

Re: [Qemu-devel] [PATCH 2/5] hostmem: make hostmem global and RAM hotunplg safe

2013-04-12 Thread Stefan Hajnoczi
On Fri, Apr 12, 2013 at 02:46:41PM +0800, liu ping fan wrote: > On Thu, Apr 11, 2013 at 6:09 PM, Paolo Bonzini wrote: > > Il 01/04/2013 10:20, Liu Ping Fan ha scritto: > > Finally, please split this patch and patch 3 differently: > > > > 1) add HostMemRegions > > > > 2) add ref/unref of memory reg

Re: [Qemu-devel] [PATCH] virtio-balloon: fix dynamic properties.

2013-04-12 Thread Peter Maydell
On 11 April 2013 23:38, wrote: > From: KONRAD Frederic > > To keep compatibility with the old virtio-balloon-x, add the dynamic > properties > to virtio-balloon-pci and virtio-balloon-ccw. Does the approach I suggested on IRC where virtio-balloon-pci's property set/get callbacks just set/get t

Re: [Qemu-devel] [PATCH] virtio-balloon: fix dynamic properties.

2013-04-12 Thread KONRAD Frédéric
On 12/04/2013 10:29, Peter Maydell wrote: On 11 April 2013 23:38, wrote: From: KONRAD Frederic To keep compatibility with the old virtio-balloon-x, add the dynamic properties to virtio-balloon-pci and virtio-balloon-ccw. Does the approach I suggested on IRC where virtio-balloon-pci's proper

Re: [Qemu-devel] [PATCH 2/5] hostmem: make hostmem global and RAM hotunplg safe

2013-04-12 Thread Stefan Hajnoczi
On Fri, Apr 12, 2013 at 11:55:39AM +0800, liu ping fan wrote: > On Thu, Apr 11, 2013 at 6:11 PM, Stefan Hajnoczi wrote: > > On Mon, Apr 01, 2013 at 04:20:31PM +0800, Liu Ping Fan wrote: > >> From: Liu Ping Fan > >> > >> The hostmem listener will translate gpa to hva quickly. Make it > >> global,

Re: [Qemu-devel] [PATCH 3/5] vring: use hostmem's RAM safe api

2013-04-12 Thread Stefan Hajnoczi
On Fri, Apr 12, 2013 at 12:49:45PM +0800, liu ping fan wrote: > On Thu, Apr 11, 2013 at 6:15 PM, Stefan Hajnoczi wrote: > > On Mon, Apr 01, 2013 at 04:20:32PM +0800, Liu Ping Fan wrote: > >> @@ -51,7 +50,7 @@ bool vring_setup(Vring *vring, VirtIODevice *vdev, int n) > >> > >> void vring_teardown(

Re: [Qemu-devel] [PATCH 4/5] virtio-blk: release reference to RAM's memoryRegion

2013-04-12 Thread Stefan Hajnoczi
On Fri, Apr 12, 2013 at 12:48:12PM +0800, liu ping fan wrote: > On Thu, Apr 11, 2013 at 6:20 PM, Stefan Hajnoczi wrote: > > On Mon, Apr 01, 2013 at 04:20:33PM +0800, Liu Ping Fan wrote: > >> From: Liu Ping Fan > >> > >> virtio-blk will reference to RAM's memoryRegion when the req has been > >> do

[Qemu-devel] weird behaviour of numlock key

2013-04-12 Thread Nikola Ciprich
Hi guys, I'm trying to figure out the reason of strange problem we're having. When I start some VM under qemu-kvm, and connect using VNC, numlock behaves in a funny way. First press of the numeric keyboard behaves like numlock is enabled (or disabled), another presses then behave the opposite way

[Qemu-devel] [PATCH] Initial TLS support for VNC Websockets

2013-04-12 Thread Tim Hardeck
Added TLS support to the VNC QEMU Websockets implementation. VNC-TLS needs to be enabled for this feature to be used. The required certificates are specified as in case of VNC-TLS with the VNC parameter "x509=". If the server certificate isn't signed by a rooth authority it needs to be manually i

Re: [Qemu-devel] VNC Websocket TLS support design decisions

2013-04-12 Thread Tim Hardeck
Hi, I have sent in my current implementation some minutes ago. On 04/11/2013 03:33 PM, Tim Hardeck wrote: Websockets over TLS need certificates. We already have the "x509" vnc parameter for VNC-TLS to provide the certificates but user might have one webserver certificate and one for VNC TLS au

Re: [Qemu-devel] [PATCH 4/5] virtio-blk: release reference to RAM's memoryRegion

2013-04-12 Thread liu ping fan
On Fri, Apr 12, 2013 at 4:45 PM, Stefan Hajnoczi wrote: > On Fri, Apr 12, 2013 at 12:48:12PM +0800, liu ping fan wrote: >> On Thu, Apr 11, 2013 at 6:20 PM, Stefan Hajnoczi wrote: >> > On Mon, Apr 01, 2013 at 04:20:33PM +0800, Liu Ping Fan wrote: >> >> From: Liu Ping Fan >> >> >> >> virtio-blk wi

Re: [Qemu-devel] [PATCH] net: make nic name unique

2013-04-12 Thread Stefan Hajnoczi
On Thu, Apr 11, 2013 at 07:58:39PM +0800, Amos Kong wrote: > If we don't assign 'id' for nic device, device's name will be $model.$idx. > The $idx is always 0 if we use new style of cmdline. This problem was > introduced by commit d33d93b2. > > eg: > # qemu-upstream -device virtio-net-pci,netdev=

Re: [Qemu-devel] [PATCH] bswap: fix compiler warning

2013-04-12 Thread Stefan Hajnoczi
On Fri, Apr 12, 2013 at 11:41:15AM +1000, Alexey Kardashevskiy wrote: > The bswap functions use memcpy but the bswap.h header itself does not seem to > include it in some configuration such as cross compiling for powerpc64 > on x86_64 machine (gcc 4.6.3 from ftp.kernel.org, headers/libs from > FC1

Re: [Qemu-devel] [PATCH] virtio-balloon: fix dynamic properties.

2013-04-12 Thread Peter Maydell
On 12 April 2013 09:36, KONRAD Frédéric wrote: > On 12/04/2013 10:29, Peter Maydell wrote: >> Does the approach I suggested on IRC where virtio-balloon-pci's >> property set/get callbacks just set/get the property on >> virtio-balloon via the public interface not work? Having to >> expose virtio-b

Re: [Qemu-devel] [PATCH] virtio-balloon: fix dynamic properties.

2013-04-12 Thread KONRAD Frédéric
On 12/04/2013 11:14, Peter Maydell wrote: On 12 April 2013 09:36, KONRAD Frédéric wrote: On 12/04/2013 10:29, Peter Maydell wrote: Does the approach I suggested on IRC where virtio-balloon-pci's property set/get callbacks just set/get the property on virtio-balloon via the public interface not

Re: [Qemu-devel] [PATCH] qemu-char: another io_add_watch_poll fix

2013-04-12 Thread Amit Shah
On (Thu) 11 Apr 2013 [10:58:30], Paolo Bonzini wrote: > Il 10/04/2013 19:59, Amit Shah ha scritto: > > On (Wed) 10 Apr 2013 [15:23:27], Paolo Bonzini wrote: > >> After attaching the source, we have to remove the reference we hold > >> to it, because we do not hold anymore a pointer to the source. >

Re: [Qemu-devel] [PATCH] virtio-balloon: fix dynamic properties.

2013-04-12 Thread KONRAD Frédéric
On 12/04/2013 11:14, Peter Maydell wrote: On 12 April 2013 09:36, KONRAD Frédéric wrote: On 12/04/2013 10:29, Peter Maydell wrote: Does the approach I suggested on IRC where virtio-balloon-pci's property set/get callbacks just set/get the property on virtio-balloon via the public interface not

Re: [Qemu-devel] weird behaviour of numlock key

2013-04-12 Thread Lei Li
On 04/12/2013 04:45 PM, Nikola Ciprich wrote: Hi guys, I'm trying to figure out the reason of strange problem we're having. When I start some VM under qemu-kvm, and connect using VNC, numlock behaves in a funny way. First press of the numeric keyboard behaves like numlock is enabled (or disabled

Re: [Qemu-devel] [PATCH V11 09/17] qmp: add interface query-snapshots

2013-04-12 Thread Wenchao Xia
于 2013-4-12 11:22, Eric Blake 写道: On 04/11/2013 09:17 PM, Wenchao Xia wrote: Hmm, as I typed that, I did another search of qemu-schema.json - we have the type 'ImageInfo' defined, but none of the existing 'command's ever call out the use of that type. Is it a type we are only using internall

Re: [Qemu-devel] [RFC 00/13] aio: drop io_flush()

2013-04-12 Thread Stefan Hajnoczi
On Fri, Apr 12, 2013 at 10:02:02AM +0200, Kevin Wolf wrote: > Am 11.04.2013 um 17:44 hat Stefan Hajnoczi geschrieben: > > Here's my entry to the "let's get rid of io_flush()" effort. It's based on > > Paolo's insight about bdrv_drain_all() that the block layer already has a > > tracked_requests li

Re: [Qemu-devel] [PATCH 18/19] target-i386: expose all possible CPUs as /machine/icc-bridge/cpu[0..N] links

2013-04-12 Thread Igor Mammedov
On Thu, 11 Apr 2013 14:19:37 -0300 Eduardo Habkost wrote: > On Thu, Apr 11, 2013 at 04:51:57PM +0200, Igor Mammedov wrote: > > ... and leave links for not present CPUs empty. > > > > It will allow users to query for possible APIC IDs and use them > > with cpu-add QMP command. > > > > Signed-off

Re: [Qemu-devel] [PATCH 2/5] hostmem: make hostmem global and RAM hotunplg safe

2013-04-12 Thread Paolo Bonzini
Il 12/04/2013 10:38, Stefan Hajnoczi ha scritto: >> > Yes, protect. Supposed we have HostMem A, and it will become B. Then >> > hostmem_lookup will either see A or B. If it see A, it should use A >> > refcnt agaist hostmem_listener_commit to drop A. This refcnt has no >> > relation with mr's obje

Re: [Qemu-devel] [RFC 00/13] aio: drop io_flush()

2013-04-12 Thread Kevin Wolf
Am 12.04.2013 um 11:49 hat Stefan Hajnoczi geschrieben: > On Fri, Apr 12, 2013 at 10:02:02AM +0200, Kevin Wolf wrote: > > Am 11.04.2013 um 17:44 hat Stefan Hajnoczi geschrieben: > > > Here's my entry to the "let's get rid of io_flush()" effort. It's based > > > on > > > Paolo's insight about bdrv

Re: [Qemu-devel] [PATCH 09/19] cpu: add helper cpu_exists(), to check if CPU with specified id exists

2013-04-12 Thread Igor Mammedov
On Thu, 11 Apr 2013 16:06:58 -0300 Eduardo Habkost wrote: > On Thu, Apr 11, 2013 at 04:51:48PM +0200, Igor Mammedov wrote: > > ... it should be used only on slow path since it does recursive search > > on /machine QOM tree for objects of TYPE_CPU > > > > Signed-off-by: Igor Mammedov > > Rev

Re: [Qemu-devel] [PATCH 11/19] target-i386: introduce apic-id property

2013-04-12 Thread Igor Mammedov
On Thu, 11 Apr 2013 16:12:33 -0300 Eduardo Habkost wrote: > On Thu, Apr 11, 2013 at 04:51:50PM +0200, Igor Mammedov wrote: > > ... and use it from board level to set APIC ID for CPUs > > it creates. > > > > Signed-off-by: Igor Mammedov > > Reviewed-by: Paolo Bonzini > > --- > > Note: > > * p

Re: [Qemu-devel] [RFC 00/13] aio: drop io_flush()

2013-04-12 Thread Paolo Bonzini
Il 12/04/2013 12:04, Kevin Wolf ha scritto: > Or actually, if you want to avoid .bdrv_drain for now, the patch that I > started when I thought a bit about this, had a default .bdrv_drain > implementation that just forwarded the request to bs->file if it wasn't > implemented by a block driver. For t

Re: [Qemu-devel] weird behaviour of numlock key

2013-04-12 Thread Nikola Ciprich
> Hi Nikola, Hello Lei, thanks for Your reply. > > I am working on this problem. And the proposal already send > as the refference link below, you might want to take a look. I'll gladly have a look.. > https://bugzilla.linux.ibm.com/show_bug.cgi?id=90304 bash-4.1$ ping bugzilla.linux.ibm.com

Re: [Qemu-devel] [PATCH] qemu-char: another io_add_watch_poll fix

2013-04-12 Thread Paolo Bonzini
Il 12/04/2013 11:24, Amit Shah ha scritto: > Can you try multiple writes from the guest? At least 3-4? QEMU > doesn't detect a backend getting closed right away (another bug), so > the freeze doesn't trigger til qemu detects there's no chardev > anymore. All writes after the second will hang and

[Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

2013-04-12 Thread Luke Kim
Janne Karhunen: Do you think if it is correct that return 0 when ts->signal_pending is true and select() returns '0' (timeout)? Because the caller doesn't expect to return select() with 0, should we return other error values such as EINTR? When I modified you patch to return EINTR if select() re

Re: [Qemu-devel] [PATCH 08/19] cpu: introduce get_arch_id() method and override it for target-i386

2013-04-12 Thread Igor Mammedov
On Thu, 11 Apr 2013 16:04:26 -0300 Eduardo Habkost wrote: > On Thu, Apr 11, 2013 at 04:51:47PM +0200, Igor Mammedov wrote: > > get_arch_id() adds possibility for generic code to get guest visible > > CPI id without accessing CPUArchState. If target doesn't override it, > > it will return cpu_inde

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-12 Thread Michael S. Tsirkin
On Thu, Apr 11, 2013 at 04:33:03PM -0400, Michael R. Hines wrote: > On 04/11/2013 03:15 PM, Michael S. Tsirkin wrote: > >On Thu, Apr 11, 2013 at 01:49:34PM -0400, Michael R. Hines wrote: > >>On 04/11/2013 10:56 AM, Michael S. Tsirkin wrote: > >>>On Thu, Apr 11, 2013 at 04:50:21PM +0200, Paolo Bonzi

Re: [Qemu-devel] [PATCH] net: make nic name unique

2013-04-12 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Thu, Apr 11, 2013 at 07:58:39PM +0800, Amos Kong wrote: >> If we don't assign 'id' for nic device, device's name will be $model.$idx. >> The $idx is always 0 if we use new style of cmdline. This problem was >> introduced by commit d33d93b2. >> >> eg: >> # qemu-upstr

Re: [Qemu-devel] [PATCH] bswap: fix compiler warning

2013-04-12 Thread Andreas Färber
Am 12.04.2013 03:41, schrieb Alexey Kardashevskiy: > The bswap functions use memcpy but the bswap.h header itself does not seem to > include it in some configuration such as cross compiling for powerpc64 > on x86_64 machine (gcc 4.6.3 from ftp.kernel.org, headers/libs from > FC18/ppc64), > the exa

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-12 Thread Paolo Bonzini
Il 12/04/2013 12:48, Michael S. Tsirkin ha scritto: > 1. You have two protocols already and this does not make sense in > version 1 of the patch. It makes sense if we consider it experimental (add x- in front of transport and capability) and would like people to play with it. Paolo

Re: [Qemu-devel] [PATCH 07/19] rtc: update rtc_cmos on CPU hot-plug

2013-04-12 Thread Igor Mammedov
On Thu, 11 Apr 2013 15:59:40 -0300 Eduardo Habkost wrote: > On Thu, Apr 11, 2013 at 04:51:46PM +0200, Igor Mammedov wrote: > > ... so that on reboot BIOS could read current available CPU count > > > > Signed-off-by: Igor Mammedov > > v2: > > * s/qemu_register_cpu_add_notifier()/qemu_register_

Re: [Qemu-devel] [PATCH 06/19] introduce CPU hot-plug notifier

2013-04-12 Thread Igor Mammedov
On Thu, 11 Apr 2013 15:46:47 -0300 Eduardo Habkost wrote: > On Thu, Apr 11, 2013 at 04:51:45PM +0200, Igor Mammedov wrote: > > hot-added CPU will be distributed to acpi_piix4, rtc_cmos and icc_bridge > > > > Signed-off-by: Igor Mammedov > > Reviewed-by: Paolo Bonzini > > Have you considered m

Re: [Qemu-devel] [PATCH 3/8] rdma: new QEMUFileOps hooks

2013-04-12 Thread Paolo Bonzini
Il 12/04/2013 07:52, mrhi...@linux.vnet.ibm.com ha scritto: > From: "Michael R. Hines" > > These are just the prototypes for optional new hooks > that RDMA takes advantage of to perform dynamic page > registration. > > An optional hook is also introduced for a custom function > to be able to

Re: [Qemu-devel] [PATCH 4/8] rdma: implement new QEMUFileOps hooks

2013-04-12 Thread Paolo Bonzini
Il 12/04/2013 07:52, mrhi...@linux.vnet.ibm.com ha scritto: > > +void ram_control_load_hook(QEMUFile *f, uint32_t flags) > +{ > +int ret = 0; > + > +if (f->ops->hook_ram_load) { > +qemu_fflush(f); > +ret = f->ops->hook_ram_load(f, f->opaque, flags); > +if (ret < 0)

Re: [Qemu-devel] [PATCH v2 0/2] New trace backend: ftrace

2013-04-12 Thread Stefan Hajnoczi
On Thu, Apr 11, 2013 at 08:25:14PM +0900, Eiichi Tsukata wrote: > This patchset introduces a new tracing backend "ftrace". > > Currently, QEMU tracing backends do not support userspace tracing with ftrace. > Collecting QEMU trace data and kernel trace data simultaneouly is useful for > latency ana

Re: [Qemu-devel] [PATCH 2/8] rdma: core rdma logic

2013-04-12 Thread Paolo Bonzini
Il 12/04/2013 07:52, mrhi...@linux.vnet.ibm.com ha scritto: > > + * > + * If we're using dynamic registration on the server-side, we have to > + * send a registration command first. > + */ > +static int __qemu_rdma_write(QEMUFile *f, RDMAContext *rdma, > +int current_index, > +uint

Re: [Qemu-devel] [PATCH 03/19] cpu: make kvm-stub.o a part of CPU library

2013-04-12 Thread Igor Mammedov
On Thu, 11 Apr 2013 14:45:42 -0300 Eduardo Habkost wrote: > On Thu, Apr 11, 2013 at 04:51:42PM +0200, Igor Mammedov wrote: > > Signed-off-by: Igor Mammedov > > --- > > Makefile.target | 13 +++-- > > include/hw/pci/msi.h | 2 ++ > > include/sysemu/kvm.h | 4 ++-- > > kvm-stub.c

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 0/4] m25p80: Fix debug printfery

2013-04-12 Thread Stefan Hajnoczi
On Sun, Apr 07, 2013 at 03:53:29PM +1000, Peter Crosthwaite wrote: > Fix up the debug printfery m25p80 in various ways. 0 functional diff. > > > Peter Crosthwaite (4): > m25p80: Fix debug messages. > m25p80: Convert guest errors to LOG_GUEST_ERROR > m25p80.c: Multiple debug verbosity levels

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-12 Thread Michael S. Tsirkin
On Fri, Apr 12, 2013 at 12:53:11PM +0200, Paolo Bonzini wrote: > Il 12/04/2013 12:48, Michael S. Tsirkin ha scritto: > > 1. You have two protocols already and this does not make sense in > > version 1 of the patch. > > It makes sense if we consider it experimental (add x- in front of > transport

Re: [Qemu-devel] [PATCH 0/8] rdma: migration support

2013-04-12 Thread Michael S. Tsirkin
On Fri, Apr 12, 2013 at 01:51:06AM -0400, mrhi...@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" > > Changes since v7: > > - Ran checkpatch.pl > - Finished additional cleanup requests > - Deleted zero scanning option > - Cleaned up docs/rdma.txt > > Wiki: http://wiki.qemu.org/Features/RDM

Re: [Qemu-devel] [Qemu-trivial] [PATCH] target-moxie: Fix VMState registration

2013-04-12 Thread Stefan Hajnoczi
On Mon, Apr 08, 2013 at 04:51:46PM +0100, Peter Maydell wrote: > Register the CPU VMState in the correct way, via cpu_class_set_vmsd(), > rather than doing it in two different wrong ways (once by providing > cpu_save and cpu_load functions, and once by setting the vmsd field in > DeviceClass). > >

Re: [Qemu-devel] [PATCH 04/19] cpu: call cpu_synchronize_post_init() from CPUClass.realize() if hotplugged

2013-04-12 Thread Igor Mammedov
On Thu, 11 Apr 2013 15:33:01 -0300 Eduardo Habkost wrote: > On Thu, Apr 11, 2013 at 04:51:43PM +0200, Igor Mammedov wrote: > > ... to synchronize CPU state to KVM > > > > Signed-off-by: Igor Mammedov > > --- > > v2: > > * linking kvm-stub.o to *-user target moved in separate patch > > --- > >

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Typo, spelling and grammatical fixes

2013-04-12 Thread Stefan Hajnoczi
On Mon, Apr 08, 2013 at 05:36:12PM +0100, Peter Maydell wrote: > Minor fixes to documentation and code comments, including > a set of lets-vs-let's corrections. > > Signed-off-by: Peter Maydell > --- > docs/bootindex.txt | 10 +- > docs/ccid.txt |2 +- > hw/arm

Re: [Qemu-devel] [Qemu-trivial] [PATCH] linux-user: pass correct host flags to eventfd2 call

2013-04-12 Thread Stefan Hajnoczi
On Mon, Apr 08, 2013 at 08:26:10PM +0200, Petar Jovanovic wrote: > This change makes conversion of TARGET_O_NONBLOCK and TARGET_O_CLOEXEC flags > to host flags before calling eventfd for TARGET_NR_eventfd2. > > Signed-off-by: Petar Jovanovic > --- > linux-user/syscall.c | 11 ++- > 1 f

Re: [Qemu-devel] [PATCH 05/19] cpu: resume CPU from CPUClass.cpu_common_realizefn() when it is hot-plugged

2013-04-12 Thread Igor Mammedov
On Thu, 11 Apr 2013 15:36:23 -0300 Eduardo Habkost wrote: > On Thu, Apr 11, 2013 at 04:51:44PM +0200, Igor Mammedov wrote: > > Signed-off-by: Igor Mammedov > > --- > > cpus.c| 11 --- > > include/sysemu/cpus.h | 3 +++ > > qom/cpu.c | 2 ++ > > stubs/Makefi

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Typo, spelling and grammatical fixes

2013-04-12 Thread Peter Maydell
On 12 April 2013 12:35, Stefan Hajnoczi wrote: > On Mon, Apr 08, 2013 at 05:36:12PM +0100, Peter Maydell wrote: >> Minor fixes to documentation and code comments, including >> a set of lets-vs-let's corrections. > Looks fine but please resend with hw/ reorganization conflicts resolved. I already

Re: [Qemu-devel] [PATCH v3] hw/i386/pc: prompt not multboot or morden kernel image

2013-04-12 Thread Stefan Hajnoczi
On Thu, Apr 11, 2013 at 10:18:56AM +0800, li guang wrote: > 在 2013-04-09二的 14:15 -0500,Jesse Larrew写道: > > On 04/09/2013 12:05 AM, li guang wrote: > > > 在 2013-04-08一的 23:36 -0500,Jesse Larrew写道: > > >> On 04/08/2013 09:27 PM, liguang wrote: > > >>> if head magic is missing or wrong unexpectedly, w

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Typo, spelling and grammatical fixes

2013-04-12 Thread Stefan Hajnoczi
On Mon, Apr 08, 2013 at 05:36:12PM +0100, Peter Maydell wrote: > Minor fixes to documentation and code comments, including > a set of lets-vs-let's corrections. > > Signed-off-by: Peter Maydell > --- > docs/bootindex.txt | 10 +- > docs/ccid.txt |2 +- > hw/arm

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] Typo, spelling and grammatical fixes

2013-04-12 Thread Stefan Hajnoczi
On Tue, Apr 09, 2013 at 12:48:19PM +0100, Peter Maydell wrote: > Minor fixes to documentation and code comments. > > Signed-off-by: Peter Maydell > --- > No actual changes, just rebased and resent following Paolo > moving everything around. > > docs/bootindex.txt | 10 +- > do

Re: [Qemu-devel] [PATCH V11 09/17] qmp: add interface query-snapshots

2013-04-12 Thread Markus Armbruster
Wenchao Xia writes: > 于 2013-4-12 11:22, Eric Blake 写道: >> On 04/11/2013 09:17 PM, Wenchao Xia wrote: >> > Hmm, as I typed that, I did another search of qemu-schema.json - we have > the type 'ImageInfo' defined, but none of the existing 'command's ever > call out the use of that

Re: [Qemu-devel] [Qemu-trivial] [PATCH] cpu-exec: Allow "-d exec" in non-debug builds (drop CONFIG_DEBUG_EXEC)

2013-04-12 Thread Stefan Hajnoczi
On Thu, Apr 11, 2013 at 09:21:46PM +0100, Peter Maydell wrote: > The CONFIG_DEBUG_EXEC define compiles out a single qemu_log_mask() > call, which is a pretty trivial cost even for something in the main > cpu_exec() loop. Having this be conditionally defined means that > '-d exec' on a non-debug bu

Re: [Qemu-devel] [PATCH V11 13/17] block: dump to buffer for bdrv_snapshot_dump() and bdrv_image_info_dump()

2013-04-12 Thread Markus Armbruster
Wenchao Xia writes: > 于 2013-4-11 20:05, Markus Armbruster 写道: >> Wenchao Xia writes: >> > > -void bdrv_image_info_dump(ImageInfo *info) > +void bdrv_image_info_dump(GString *buf, ImageInfo *info) >{ >char size_buf[128], dsize_buf[128]; >if (!info

Re: [Qemu-devel] [RFC 00/13] aio: drop io_flush()

2013-04-12 Thread Stefan Hajnoczi
On Fri, Apr 12, 2013 at 12:27 PM, Paolo Bonzini wrote: > Il 12/04/2013 12:04, Kevin Wolf ha scritto: >> Or actually, if you want to avoid .bdrv_drain for now, the patch that I >> started when I thought a bit about this, had a default .bdrv_drain >> implementation that just forwarded the request to

Re: [Qemu-devel] [PATCH 1/3] debugcon: fix always print "addr=0x0, val=0x0" bug

2013-04-12 Thread Andreas Färber
Am 12.04.2013 06:12, schrieb liguang: > when use DEBUG_DEBUGCON, screen spits: > debugcon: write addr=0x val=0x00 > Rdebugcon: write addr=0x val=0x00 > udebugcon: write addr=0x val=0x00 > ndebugcon: write addr=0x val=0x00 > ndebugcon: write addr=0x val=0x00 > idebugcon: write ad

Re: [Qemu-devel] [PATCH 3/3] debugcon: fix compiler warning when open DEBUG_DEBUGCON

2013-04-12 Thread Andreas Färber
Am 12.04.2013 06:12, schrieb liguang: > compiler warnings: > CChw/char/debugcon.o > hw/char/debugcon.c: In function ‘debugcon_ioport_write’: > hw/char/debugcon.c:58: warning: format ‘%02x’ expects type ‘unsigned int’, > but argument 3 has type ‘uint64_t’ > hw/char/debugcon.c: In function ‘de

Re: [Qemu-devel] [RFC 00/13] aio: drop io_flush()

2013-04-12 Thread Kevin Wolf
Am 12.04.2013 um 14:06 hat Stefan Hajnoczi geschrieben: > On Fri, Apr 12, 2013 at 12:27 PM, Paolo Bonzini wrote: > > Il 12/04/2013 12:04, Kevin Wolf ha scritto: > >> Or actually, if you want to avoid .bdrv_drain for now, the patch that I > >> started when I thought a bit about this, had a default

[Qemu-devel] [PULL 0/4] Trivial patches for 6 to 12 April 2013

2013-04-12 Thread Stefan Hajnoczi
The following changes since commit 93b48c201eb6c0404d15550a0eaa3c0f7937e35e: virtio-9p: Fix virtio-9p no longer building after hw-dirs branch merge (2013-04-09 07:47:00 -0500) are available in the git repository at: git://github.com/stefanha/qemu.git trivial-patches for you to fetch change

[Qemu-devel] [PATCH 1/4] target-moxie: Fix VMState registration

2013-04-12 Thread Stefan Hajnoczi
From: Peter Maydell Register the CPU VMState in the correct way, via cpu_class_set_vmsd(), rather than doing it in two different wrong ways (once by providing cpu_save and cpu_load functions, and once by setting the vmsd field in DeviceClass). Signed-off-by: Peter Maydell Reviewed-by: Andreas F

[Qemu-devel] [PATCH 3/4] Typo, spelling and grammatical fixes

2013-04-12 Thread Stefan Hajnoczi
From: Peter Maydell Minor fixes to documentation and code comments. Signed-off-by: Peter Maydell Signed-off-by: Stefan Hajnoczi --- docs/bootindex.txt | 10 +- docs/ccid.txt | 2 +- hw/block/virtio-blk.c | 4 ++-- hw/intc/armv7m_nvic.c | 2 +- hw/s390

[Qemu-devel] [PATCH 2/4] linux-user: pass correct host flags to eventfd2 call

2013-04-12 Thread Stefan Hajnoczi
From: Petar Jovanovic This change makes conversion of TARGET_O_NONBLOCK and TARGET_O_CLOEXEC flags to host flags before calling eventfd for TARGET_NR_eventfd2. Signed-off-by: Petar Jovanovic Reviewed-by: Peter Maydell Signed-off-by: Stefan Hajnoczi --- linux-user/syscall.c | 11 ++-

[Qemu-devel] [PATCH 4/4] cpu-exec: Allow "-d exec" in non-debug builds (drop CONFIG_DEBUG_EXEC)

2013-04-12 Thread Stefan Hajnoczi
From: Peter Maydell The CONFIG_DEBUG_EXEC define compiles out a single qemu_log_mask() call, which is a pretty trivial cost even for something in the main cpu_exec() loop. Having this be conditionally defined means that '-d exec' on a non-debug build will silently do nothing. Drop the define an

[Qemu-devel] Is FW_CFG_PPC_CPUFREQ deprecated?

2013-04-12 Thread Mark Cave-Ayland
Hi everyone, Has FW_CFG_PPC_CPUFREQ been removed from QEMU for some reason? I noticed that the value always comes back as 0 in OpenBIOS, and it looks as if the FW_CFG_PPC_CPUFREQ constant (FW_CFG_ARCH_LOCAL + 0x4) has been removed from hw/ppc.h? ATB, Mark.

Re: [Qemu-devel] [PULL 0/4] Trivial patches for 6 to 12 April 2013

2013-04-12 Thread Stefan Hajnoczi
On Fri, Apr 12, 2013 at 2:23 PM, Stefan Hajnoczi wrote: > The following changes since commit 93b48c201eb6c0404d15550a0eaa3c0f7937e35e: > > virtio-9p: Fix virtio-9p no longer building after hw-dirs branch merge > (2013-04-09 07:47:00 -0500) > > are available in the git repository at: > > git:/

Re: [Qemu-devel] [PATCH 18/19] target-i386: expose all possible CPUs as /machine/icc-bridge/cpu[0..N] links

2013-04-12 Thread Eduardo Habkost
On Fri, Apr 12, 2013 at 12:01:03PM +0200, Igor Mammedov wrote: > On Thu, 11 Apr 2013 14:19:37 -0300 > Eduardo Habkost wrote: > > > On Thu, Apr 11, 2013 at 04:51:57PM +0200, Igor Mammedov wrote: > > > ... and leave links for not present CPUs empty. > > > > > > It will allow users to query for pos

Re: [Qemu-devel] [PATCH 4/8] rdma: implement new QEMUFileOps hooks

2013-04-12 Thread Michael R. Hines
On 04/12/2013 07:05 AM, Paolo Bonzini wrote: Il 12/04/2013 07:52, mrhi...@linux.vnet.ibm.com ha scritto: +void ram_control_load_hook(QEMUFile *f, uint32_t flags) +{ +int ret = 0; + +if (f->ops->hook_ram_load) { +qemu_fflush(f); +ret = f->ops->hook_ram_load(f, f->opaque, f

Re: [Qemu-devel] [PATCH] bswap: fix compiler warning

2013-04-12 Thread Alexey Kardashevskiy
On 04/12/2013 08:51 PM, Andreas Färber wrote: Am 12.04.2013 03:41, schrieb Alexey Kardashevskiy: The bswap functions use memcpy but the bswap.h header itself does not seem to include it in some configuration such as cross compiling for powerpc64 on x86_64 machine (gcc 4.6.3 from ftp.kernel.org,

[Qemu-devel] [PATCH] virtio.h: drop unused function prototypes

2013-04-12 Thread Luiz Capitulino
They are unused since commit 5c7d0962f60498c3f11d402e1c857cb9d5d8568d. Signed-off-by: Luiz Capitulino --- include/hw/virtio/virtio.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h index 7e24b2b..2c57c47 100644 --- a/include/hw/virtio/

Re: [Qemu-devel] [PATCH 11/19] target-i386: introduce apic-id property

2013-04-12 Thread Eduardo Habkost
On Fri, Apr 12, 2013 at 12:20:45PM +0200, Igor Mammedov wrote: > On Thu, 11 Apr 2013 16:12:33 -0300 > Eduardo Habkost wrote: > > > On Thu, Apr 11, 2013 at 04:51:50PM +0200, Igor Mammedov wrote: > > > ... and use it from board level to set APIC ID for CPUs > > > it creates. > > > > > > Signed-off

Re: [Qemu-devel] [PATCH 2/8] rdma: core rdma logic

2013-04-12 Thread Michael R. Hines
On 04/12/2013 07:10 AM, Paolo Bonzini wrote: Il 12/04/2013 07:52, mrhi...@linux.vnet.ibm.com ha scritto: + * + * If we're using dynamic registration on the server-side, we have to + * send a registration command first. + */ +static int __qemu_rdma_write(QEMUFile *f, RDMAContext *rdma, +i

Re: [Qemu-devel] [PATCH 3/8] rdma: new QEMUFileOps hooks

2013-04-12 Thread Michael R. Hines
All good catches, acknowledged. On 04/12/2013 07:02 AM, Paolo Bonzini wrote: Il 12/04/2013 07:52, mrhi...@linux.vnet.ibm.com ha scritto: From: "Michael R. Hines" These are just the prototypes for optional new hooks that RDMA takes advantage of to perform dynamic page registration. An o

Re: [Qemu-devel] [PATCH 07/19] rtc: update rtc_cmos on CPU hot-plug

2013-04-12 Thread Eduardo Habkost
On Fri, Apr 12, 2013 at 12:53:51PM +0200, Igor Mammedov wrote: > On Thu, 11 Apr 2013 15:59:40 -0300 > Eduardo Habkost wrote: > > > On Thu, Apr 11, 2013 at 04:51:46PM +0200, Igor Mammedov wrote: > > > ... so that on reboot BIOS could read current available CPU count > > > > > > Signed-off-by: Igo

Re: [Qemu-devel] [RFC 00/13] aio: drop io_flush()

2013-04-12 Thread Stefan Hajnoczi
On Fri, Apr 12, 2013 at 2:22 PM, Kevin Wolf wrote: > Am 12.04.2013 um 14:06 hat Stefan Hajnoczi geschrieben: >> On Fri, Apr 12, 2013 at 12:27 PM, Paolo Bonzini wrote: >> > Il 12/04/2013 12:04, Kevin Wolf ha scritto: >> >> Or actually, if you want to avoid .bdrv_drain for now, the patch that I >>

Re: [Qemu-devel] [PATCH 2/8] rdma: core rdma logic

2013-04-12 Thread Paolo Bonzini
Il 12/04/2013 15:29, Michael R. Hines ha scritto: > > Oh, thank you. Huge bug - I need to introduce a "COMPRESS" > message for this page into the protocol just like we already have > for TCP and bypass the current chunk. It's okay to send the page uncompressed if it's been registered already. T

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-12 Thread Michael R. Hines
On 04/12/2013 06:48 AM, Michael S. Tsirkin wrote: On Thu, Apr 11, 2013 at 04:33:03PM -0400, Michael R. Hines wrote: On 04/11/2013 03:15 PM, Michael S. Tsirkin wrote: On Thu, Apr 11, 2013 at 01:49:34PM -0400, Michael R. Hines wrote: On 04/11/2013 10:56 AM, Michael S. Tsirkin wrote: On Thu, Apr

Re: [Qemu-devel] [PATCH 08/19] cpu: introduce get_arch_id() method and override it for target-i386

2013-04-12 Thread Eduardo Habkost
On Fri, Apr 12, 2013 at 12:31:22PM +0200, Igor Mammedov wrote: > On Thu, 11 Apr 2013 16:04:26 -0300 > Eduardo Habkost wrote: > > > On Thu, Apr 11, 2013 at 04:51:47PM +0200, Igor Mammedov wrote: > > > get_arch_id() adds possibility for generic code to get guest visible > > > CPI id without accessi

Re: [Qemu-devel] [PATCH 2/8] rdma: core rdma logic

2013-04-12 Thread Michael R. Hines
On 04/12/2013 09:41 AM, Paolo Bonzini wrote: Il 12/04/2013 15:29, Michael R. Hines ha scritto: Oh, thank you. Huge bug - I need to introduce a "COMPRESS" message for this page into the protocol just like we already have for TCP and bypass the current chunk. It's okay to send the page uncompres

[Qemu-devel] [PULL 0/3] QMP queue

2013-04-12 Thread Luiz Capitulino
The changes (since 93b48c201eb6c0404d15550a0eaa3c0f7937e35e) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp Eric Blake (1): qapi: use valid JSON in schema Michal Novotny (2): New cpu-max field in query-machines QMP command output Revert "New

[Qemu-devel] [PULL 1/3] New cpu-max field in query-machines QMP command output

2013-04-12 Thread Luiz Capitulino
From: Michal Novotny Alter the query-machines QMP command to output information about maximum number of CPUs for each machine type with default value set to 1 in case the number of max_cpus is not set. Signed-off-by: Michal Novotny Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- q

[Qemu-devel] [PULL 2/3] Revert "New QMP command query-cpu-max and HMP command cpu_max"

2013-04-12 Thread Luiz Capitulino
From: Michal Novotny This reverts commit 4d700430a20b3d53b7b15bc5ff7e570e3f2c as asked by Luiz. The patch has been obsoleted by extending MachineInfo structure by cpu-max field. Signed-off-by: Michal Novotny Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- hmp-commands.hx | 2

[Qemu-devel] [PULL 3/3] qapi: use valid JSON in schema

2013-04-12 Thread Luiz Capitulino
From: Eric Blake * qapi-schema.json: JSON doesn't allow trailing commas. Signed-off-by: Eric Blake Signed-off-by: Luiz Capitulino --- qapi-schema.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi-schema.json b/qapi-schema.json index a184ce6..751d3c2 100644 --- a/qa

Re: [Qemu-devel] [PATCH 04/19] cpu: call cpu_synchronize_post_init() from CPUClass.realize() if hotplugged

2013-04-12 Thread Eduardo Habkost
On Fri, Apr 12, 2013 at 01:34:09PM +0200, Igor Mammedov wrote: > On Thu, 11 Apr 2013 15:33:01 -0300 > Eduardo Habkost wrote: > > > On Thu, Apr 11, 2013 at 04:51:43PM +0200, Igor Mammedov wrote: > > > ... to synchronize CPU state to KVM > > > > > > Signed-off-by: Igor Mammedov > > > --- > > > v2

[Qemu-devel] [PULL v2 0/4] Trivial patches for 6 to 12 April 2013

2013-04-12 Thread Stefan Hajnoczi
v2: * Andreas Färber noticed my patch scripts aren't unicode safe, fix his name The following changes since commit 93b48c201eb6c0404d15550a0eaa3c0f7937e35e: virtio-9p: Fix virtio-9p no longer building after hw-dirs branch merge (2013-04-09 07:47:00 -0500) are available in the git repository

[Qemu-devel] [PATCH 1/4] target-moxie: Fix VMState registration

2013-04-12 Thread Stefan Hajnoczi
From: Peter Maydell Register the CPU VMState in the correct way, via cpu_class_set_vmsd(), rather than doing it in two different wrong ways (once by providing cpu_save and cpu_load functions, and once by setting the vmsd field in DeviceClass). Signed-off-by: Peter Maydell Reviewed-by: Andreas F

[Qemu-devel] [PATCH 2/4] linux-user: pass correct host flags to eventfd2 call

2013-04-12 Thread Stefan Hajnoczi
From: Petar Jovanovic This change makes conversion of TARGET_O_NONBLOCK and TARGET_O_CLOEXEC flags to host flags before calling eventfd for TARGET_NR_eventfd2. Signed-off-by: Petar Jovanovic Reviewed-by: Peter Maydell Signed-off-by: Stefan Hajnoczi --- linux-user/syscall.c | 11 ++-

[Qemu-devel] [PATCH 4/4] cpu-exec: Allow "-d exec" in non-debug builds (drop CONFIG_DEBUG_EXEC)

2013-04-12 Thread Stefan Hajnoczi
From: Peter Maydell The CONFIG_DEBUG_EXEC define compiles out a single qemu_log_mask() call, which is a pretty trivial cost even for something in the main cpu_exec() loop. Having this be conditionally defined means that '-d exec' on a non-debug build will silently do nothing. Drop the define an

[Qemu-devel] [PATCH 3/4] Typo, spelling and grammatical fixes

2013-04-12 Thread Stefan Hajnoczi
From: Peter Maydell Minor fixes to documentation and code comments. Signed-off-by: Peter Maydell Signed-off-by: Stefan Hajnoczi --- docs/bootindex.txt | 10 +- docs/ccid.txt | 2 +- hw/block/virtio-blk.c | 4 ++-- hw/intc/armv7m_nvic.c | 2 +- hw/s390

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-12 Thread Paolo Bonzini
Il 12/04/2013 13:25, Michael S. Tsirkin ha scritto: > On Fri, Apr 12, 2013 at 12:53:11PM +0200, Paolo Bonzini wrote: >> Il 12/04/2013 12:48, Michael S. Tsirkin ha scritto: >>> 1. You have two protocols already and this does not make sense in >>> version 1 of the patch. >> >> It makes sense if we c

Re: [Qemu-devel] [PATCH 07/19] rtc: update rtc_cmos on CPU hot-plug

2013-04-12 Thread Igor Mammedov
On Fri, 12 Apr 2013 10:35:53 -0300 Eduardo Habkost wrote: > On Fri, Apr 12, 2013 at 12:53:51PM +0200, Igor Mammedov wrote: > > On Thu, 11 Apr 2013 15:59:40 -0300 > > Eduardo Habkost wrote: > > > > > On Thu, Apr 11, 2013 at 04:51:46PM +0200, Igor Mammedov wrote: > > > > ... so that on reboot BIO

[Qemu-devel] [PATCH 0/3] Kill the "use flash device for BIOS unless KVM" misfeature

2013-04-12 Thread Markus Armbruster
See PATCH 3/3 for description, the other two are trivial preliminaries to simplify review. Markus Armbruster (3): pc: Inline pc_init_pci_1_3() into pc_init_pci_1_2() pc: Split pc_init_pci_1_0() off pc_init_pci_1_2() pc: Kill the "use flash device for BIOS unless KVM" misfeature hw/block/pc

[Qemu-devel] [PATCH 2/3] pc: Split pc_init_pci_1_0() off pc_init_pci_1_2()

2013-04-12 Thread Markus Armbruster
Just to make the next commit easier to review. Signed-off-by: Markus Armbruster --- hw/i386/pc_piix.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index da34d3b..f2d3d27 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc

[Qemu-devel] [PATCH 1/3] pc: Inline pc_init_pci_1_3() into pc_init_pci_1_2()

2013-04-12 Thread Markus Armbruster
Just to make the commit after next easier to review. Signed-off-by: Markus Armbruster --- hw/i386/pc_piix.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index cff8013..da34d3b 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@

[Qemu-devel] [PATCH 3/3] pc: Kill the "use flash device for BIOS unless KVM" misfeature

2013-04-12 Thread Markus Armbruster
Use of a flash memory device for the BIOS was added in series "[PATCH v10 0/8] PC system flash support", commit 4732dca..1b89faf, v1.1. Flash vs. ROM is a guest-visible difference. Thus, flash use had to be suppressed for machine types pc-1.0 and older. This was accomplished by adding a dummy de

Re: [Qemu-devel] Use of flash for x86 BIOS

2013-04-12 Thread Markus Armbruster
Jordan Justen writes: > On Fri, Mar 22, 2013 at 12:48 PM, Markus Armbruster wrote: >> Jordan Justen writes: >> >>> On Thu, Mar 21, 2013 at 12:45 AM, Markus Armbruster >>> wrote: x86 maintainers may wish to *switch it off* until it's done fully and properly, by setting "pc-sysfw" prop

  1   2   >