On Thu, Apr 11, 2013 at 09:21:46PM +0100, Peter Maydell wrote: > The CONFIG_DEBUG_EXEC define compiles out a single qemu_log_mask() > call, which is a pretty trivial cost even for something in the main > cpu_exec() loop. Having this be conditionally defined means that > '-d exec' on a non-debug build will silently do nothing. Drop the > define and the configure machinery that sets it, in favour of just > always allowing this log option to be enabled at runtime. As a > concession to the mainloopiness, we use qemu_loglevel_mask()+qemu_log() > rather than qemu_log_mask() to avoid the function call overhead. > > Note that DEBUG_DISAS is always defined, so removing the > '|| defined(CONFIG_DEBUG_EXEC)' from those conditionals makes > no behavioural change for that logging. > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > --- > I've been burnt at least once by asking a user to do a '-d exec' > log only to find it didn't actually log anything... > > configure | 3 --- > cpu-exec.c | 15 ++++++--------- > 2 files changed, 6 insertions(+), 12 deletions(-)
Thanks, applied to the trivial patches tree: https://github.com/stefanha/qemu/commits/trivial-patches Stefan
