Re: [Qemu-devel] [PATCH] translate: cleanup gen_intermediate_code_internal

2013-04-10 Thread Paolo Bonzini
Il 10/04/2013 05:30, liguang ha scritto: > Signed-off-by: liguang > --- > target-arm/translate.c | 17 - > target-i386/translate.c | 17 - > target-mips/translate.c | 16 > 3 files changed, 24 insertions(+), 26 deletions(-) > > diff --git a

Re: [Qemu-devel] [PATCH V11 11/17] qmp: add ImageInfo in BlockDeviceInfo used by query-block

2013-04-10 Thread Wenchao Xia
于 2013-4-8 21:33, Stefan Hajnoczi 写道: On Tue, Apr 02, 2013 at 07:47:24PM +0800, Wenchao Xia wrote: diff --git a/qmp-commands.hx b/qmp-commands.hx index 6b20684..b856be7 100644 --- a/qmp-commands.hx +++ b/qmp-commands.hx @@ -1703,6 +1703,47 @@ Each json-object contain the following: -

Re: [Qemu-devel] [RFC PATCH v3 0/5] port network layer onto glib

2013-04-10 Thread liu ping fan
On Tue, Apr 9, 2013 at 11:22 PM, Stefan Hajnoczi wrote: > On Mon, Apr 08, 2013 at 01:36:03PM +0800, Liu Ping Fan wrote: >> This series focus on network backend (excluding slirp). The related patch >> for core's re-entrant (queue.c net.c) will be sent out separatelly. > > Are changes required to ta

Re: [Qemu-devel] [RFC PATCH RDMA support v6: 7/7] introduce qemu_ram_foreach_block()

2013-04-10 Thread Paolo Bonzini
Il 10/04/2013 06:29, mrhi...@linux.vnet.ibm.com ha scritto: > From: "Michael R. Hines" > > This is used during RDMA initialization in order to transmit > a description of all the RAM blocks to the peer for later > dynamic chunk registration purposes. why did you move this after patch 5??? Paolo

Re: [Qemu-devel] latest master: major slowdown (something spinning?)

2013-04-10 Thread Paolo Bonzini
Il 09/04/2013 19:43, Michael R. Hines ha scritto: > *Here's the commit that causes the problem:* > > $ git checkout d185c094b404b4ff392b77d1244c0233da7d53bd > qemu-char: eliminate busy waiting on can_read returning zero Can you stil reproduce it after commit 1e885b25275fb6763eb947b1e53b2d6911b96

Re: [Qemu-devel] [RFC PATCH RDMA support v6: 4/7] Introduce two new capabilities

2013-04-10 Thread Paolo Bonzini
Il 10/04/2013 06:29, mrhi...@linux.vnet.ibm.com ha scritto: > From: "Michael R. Hines" > > RDMA performs very slowly with zero-page checking. > Without the ability to disable it, RDMA throughput and > latency promises and high performance links cannot be > fully realized. > > On the other hand,

Re: [Qemu-devel] [RFC PATCH RDMA support v6: 3/7] Introduce QEMURamControlOps

2013-04-10 Thread Paolo Bonzini
Il 10/04/2013 06:29, mrhi...@linux.vnet.ibm.com ha scritto: > From: "Michael R. Hines" > > RDMA requires hooks before and after each iteration round > in order to coordinate the new dynamic page registration support. > This is done now by introducing a new set of function pointers > which are onl

Re: [Qemu-devel] [RFC PATCH RDMA support v6: 1/7] ./configure and Makefile

2013-04-10 Thread Paolo Bonzini
Il 10/04/2013 06:29, mrhi...@linux.vnet.ibm.com ha scritto: > diff --git a/Makefile.objs b/Makefile.objs > index e568c01..10431bd 100644 > --- a/Makefile.objs > +++ b/Makefile.objs > @@ -49,6 +49,7 @@ common-obj-$(CONFIG_POSIX) += os-posix.o > common-obj-$(CONFIG_LINUX) += fsdev/ > > common-obj

Re: [Qemu-devel] [PATCH] translate: cleanup gen_intermediate_code_internal

2013-04-10 Thread li guang
在 2013-04-10三的 09:44 +0200,Paolo Bonzini写道: > Il 10/04/2013 05:30, liguang ha scritto: > > Signed-off-by: liguang > > --- > > target-arm/translate.c | 17 - > > target-i386/translate.c | 17 - > > target-mips/translate.c | 16 > > 3 files ch

Re: [Qemu-devel] [RFC PATCH RDMA support v6: 6/7] send pc.ram over RDMA

2013-04-10 Thread Paolo Bonzini
Il 10/04/2013 06:29, mrhi...@linux.vnet.ibm.com ha scritto: > From: "Michael R. Hines" > > All that is left for this part of the patch is: > > 1. use the new (optionally defined) save_ram_page function pointer >to decide what to do with the page if RDMA is enable or not >and return ENOTS

Re: [Qemu-devel] [PATCH v2] configure: remove duplicate test

2013-04-10 Thread Paolo Bonzini
Il 09/04/2013 19:22, Peter Maydell ha scritto: > On 9 April 2013 14:17, Paolo Bonzini wrote: >> We already had a test to add -march=i486 when needed. Make the >> existing test independent of vhost-net, so that it is also used >> under Win32. Also move the test earlier to avoid mucking with >> QE

Re: [Qemu-devel] [RFC PATCH 1/6] adlib: qdev-ify

2013-04-10 Thread Paolo Bonzini
Il 09/04/2013 19:28, Andreas Färber ha scritto: >> > +#ifdef HAS_YMF262 >> > +#define ADLIB_DESC "Yamaha YMF262 (OPL3)" >> > +#else >> > +#define ADLIB_DESC "Yamaha YM3812 (OPL2)" >> > +#endif > Shouldn't in the process of QOM'ifying this be split into two devices? > Is HAS_YMF262 user-selected or

[Qemu-devel] [PATCH 1/2] target-i386: remove cpu reset callback

2013-04-10 Thread liguang
we should remove it now, if not, cpu reset will do 2 times. Signed-off-by: liguang --- target-i386/cpu.c |9 - 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 356378c..6e13053 100644 --- a/target-i386/cpu.c +++ b/target-i386/

[Qemu-devel] [PATCH 2/2] target-i386: fix 2 malformed indents

2013-04-10 Thread liguang
Signed-off-by: liguang --- target-i386/cpu.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 6e13053..9806a60 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -2108,7 +2108,7 @@ static void x86_cpu_realizefn(DeviceSt

Re: [Qemu-devel] latest version qemu compile error

2013-04-10 Thread Paolo Bonzini
Il 10/04/2013 05:24, Zhanghaoyu (A) ha scritto: > The log of "make V=1" is identical with that of "make", shown as below, > > hw/virtio/dataplane/vring.c: In function 'vring_enable_notification': > hw/virtio/dataplane/vring.c:72: warning: implicit declaration of function > 'vring_avail_event' > h

Re: [Qemu-devel] [PATCH v18 0/7] Add pvpanic device to deal with guest panic event

2013-04-10 Thread Paolo Bonzini
Il 10/04/2013 05:33, Hu Tao ha scritto: > This series introduces a new simulated device, pvpanic, to notify > qemu when guest panic event happens. > > Along with this series, there are two patches to add seabios ACPI > driver and kernel ACPI driver for the device, respectively. > > Tested with: >

Re: [Qemu-devel] [PATCH 08/22] target-i386: ioapic: replace FROM_SYSBUS() with QOM type cast

2013-04-10 Thread Paolo Bonzini
Il 10/04/2013 02:21, li guang ha scritto: > > >> > > > >> > >>> > > sure, will do this on the next respin. >> > >> > Actually no, why? It's two different files. > because they do the same trivial thing, > do you want some mechanic changes separated? If it makes sense, yes. Paolo

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 08/12] new capabilities added and check for QMP string 'rdma'

2013-04-10 Thread Paolo Bonzini
Il 10/04/2013 03:11, Michael R. Hines ha scritto: > Actually, this capability needs to be a part of the same patch. > > RDMA must have the ability to turn this off or performance will die. Yes, but you can put it in a separate patch at the beginning of this series. RDMA depends on it, but it doe

Re: [Qemu-devel] [PATCH v3 2/2] rbd: link and load librbd dynamically

2013-04-10 Thread Stefan Hajnoczi
On Wed, Apr 10, 2013 at 2:05 AM, Josh Durgin wrote: > This allows the rbd block driver to detect symbols in the installed > version of librbd, and enable or disable features appropriately. This > obviates the #ifdefs regarding librbd versions. > > Loading librbd dynamically also makes the rbd blo

[Qemu-devel] [PATCH V18 0/6] add-cow file format

2013-04-10 Thread Dong Xu Wang
It will introduce a new file format: add-cow. The add-cow file format makes it possible to perform copy-on-write on top of a raw disk image. When we know that no backing file clusters remain visible (e.g. we have streamed the entire image and copied all data from the backing file), then it is pos

[Qemu-devel] [PATCH V18 6/6] qemu-iotests: add add-cow iotests support

2013-04-10 Thread Dong Xu Wang
This patch will use qemu-iotests to test add-cow file format. Signed-off-by: Dong Xu Wang --- v17-v18: 1) add 037 and 038 tests. tests/qemu-iotests/017 | 2 +- tests/qemu-iotests/020 | 2 +- tests/qemu-iotests/037 | 2 +- tests/qemu-iotests/038 | 2 +- tests/qemu-iot

[Qemu-devel] [PATCH V18 5/6] add-cow file format core code.

2013-04-10 Thread Dong Xu Wang
add-cow file format core code. It use block-cache.c as cache code. It lacks of snapshot_blkdev support. Signed-off-by: Dong Xu Wang --- v17-v18: 1) use error_report, not fprintf. 2) remove version field from header. 3) header_size is MAX(cluster_size, 4096). 4) introduce s->cluster_sectors. 5) us

[Qemu-devel] [PATCH V18 2/6] make path_has_protocol non static

2013-04-10 Thread Dong Xu Wang
We will use path_has_protocol outside block.c, so just make it public. Reviewed-by: Michael Roth Signed-off-by: Dong Xu Wang --- block.c | 2 +- include/block/block.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c index 45e1d96..1e7dab5 1006

Re: [Qemu-devel] [PATCH v3] migration: initialize RAM to zero

2013-04-10 Thread Markus Armbruster
Paolo Bonzini writes: > Using qemu_memalign only leaves the RAM zero by chance, because libc > will usually use mmap to satisfy our huge requests. But memory will > not be zero when using MALLOC_PERTURB_ with a nonzero value. In the > case of incoming migration, this breaks a recently-introduce

Re: [Qemu-devel] [PATCH v4 07/11] qapi: Convert savevm

2013-04-10 Thread Markus Armbruster
[Note Cc: Kevin] Eric Blake writes: > On 04/09/2013 11:23 AM, Markus Armbruster wrote: >>> If we mandate that a tag always be supplied, then we cannot create qcow2 >>> files with a snapshot that lacks a tag using just QMP; but even if we do >> >> Are you sure you can do that with the proposed p

[Qemu-devel] [PATCH V18 1/6] docs: document for add-cow file format

2013-04-10 Thread Dong Xu Wang
Document for add-cow format, the usage and spec of add-cow are introduced. Signed-off-by: Dong Xu Wang --- V17->V18: 1) remove version field. 2) header size is maximum value and cluster size value. 3) fix type. docs/specs/add-cow.txt | 165 + 1 fil

[Qemu-devel] [PATCH V18 3/6] qed_read_string to bdrv_read_string

2013-04-10 Thread Dong Xu Wang
Make qed_read_string function to a common interface, so move it to block.c. Signed-off-by: Dong Xu Wang --- block.c | 27 +++ block/qed.c | 34 -- include/block/block.h | 2 ++ 3 files changed, 33 insertions(+), 30

[Qemu-devel] [PATCH V18 4/6] rename qcow2-cache.c to block-cache.c

2013-04-10 Thread Dong Xu Wang
We will re-use qcow2-cache as block layer common cache code, so change its name and made some changes, define a struct named BlockTableType, pass BlockTableType and table size parameters to block cache initialization function. Signed-off-by: Dong Xu Wang --- v17-v18: 1) move struct to source file

Re: [Qemu-devel] [PATCH] Fix failure to create q35 machine

2013-04-10 Thread Markus Armbruster
Hu Tao writes: > This is a regression introduced by c0907c9e6417c. -M q35 > to reproduce the problem. Including a complete reproducer in the commit message would be a bit nicer. Here's one: $ qemu-system-x86_64 -nodefaults -vnc :0 -M q35 WARNING: failed to find q35-acpi-dsdt.aml u

Re: [Qemu-devel] [PATCH v4 00/11] convert savevm to use qapi and introduce qmp command

2013-04-10 Thread Markus Armbruster
Pavel Hrdina writes: > This patch series convert the savevm command into qapi and introduce QMP > command vm-snapshot-save. > It also rewrite error report for functions used by this command. > > The last patch introduce new functionality of savevm that you cannot override > existing snapshot with

Re: [Qemu-devel] [PATCH] i.MX: implement a more correct version of EPIT timer.

2013-04-10 Thread Peter Maydell
On 9 April 2013 23:32, Jean-Christophe DUBOIS wrote: > @@ -605,11 +735,13 @@ static const VMStateDescription vmstate_imx_timerp = { > .minimum_version_id_old = 1, > .fields = (VMStateField[]) { > VMSTATE_UINT32(cr, IMXTimerPState), > +VMSTATE_UINT32(sr, IMXTimerPSta

Re: [Qemu-devel] [PATCH 1/2] win32: do not set CPU affinity

2013-04-10 Thread Fabien Chouteau
Looks like I missed an important discussion once again :) In the future don't hesitate to put me in copy for Windows and or IO loop subjects. On 02/21/2013 09:13 AM, Roy Tam wrote: > 2013/2/21 Roy Tam : >> 2013/2/21 Paolo Bonzini : >>> Il 21/02/2013 01:35, Roy Tam ha scritto: >> QEMU system e

[Qemu-devel] [Bug 1042388] Re: qemu: Unsupported syscall: 257 (timer_create)

2013-04-10 Thread Erik de Castro Lopo
Still waiting on approval from my employer's lawyers to release it. Have no idea how long this is going to take. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1042388 Title: qemu: Unsupported sysca

[Qemu-devel] [PATCH] Add linux-headers to QEMU_INCLUDES

2013-04-10 Thread Jan Kiszka
From: Jan Kiszka virtio/dataplane/vring.c requires the Linux headers and is built for all targets. So we need to add the corresponding include to QEMU_INCLUDES to avoid that outdated distribution headers are used. Signed-off-by: Jan Kiszka --- configure |5 + 1 files changed, 1 inserti

Re: [Qemu-devel] [PATCH 16/18] console: stop using DisplayState in gfx hardware emulation

2013-04-10 Thread Jan Kiszka
On 2013-04-03 13:50, Gerd Hoffmann wrote: > Hi, > >>> No, it is not, and yes, this is where the inconsistency comes >>> from. We read wred+wgreen+wblue directly from the surface >>> whereas depth is cached in the vmware vga state struct. Patch >>> attached. Not fully tested yet. >> >> Unfo

Re: [Qemu-devel] [PATCH 1/2] target-i386: remove cpu reset callback

2013-04-10 Thread Igor Mammedov
On Wed, 10 Apr 2013 16:02:28 +0800 liguang wrote: > we should remove it now, if not, cpu reset > will do 2 times. Currently CPU is bus-less device so there isn't anything to reset it during reboot except callback. This patch will break reboot path, just try guest reboot from inside guest. > Si

Re: [Qemu-devel] [PATCH] Fix failure to create q35 machine

2013-04-10 Thread Hu Tao
On Wed, Apr 10, 2013 at 10:10:06AM +0200, Markus Armbruster wrote: > Hu Tao writes: > > > This is a regression introduced by c0907c9e6417c. -M q35 > > to reproduce the problem. > > Including a complete reproducer in the commit message would be a bit > nicer. Here's one: > > $ qemu-system-

[Qemu-devel] [PATCH v2] Fix failure to create q35 machine

2013-04-10 Thread Hu Tao
This is a regression introduced by c0907c9e6417c. How to reproduce: $ qemu-system-x86_64 -nodefaults -vnc :0 -M q35 qemu-system-x86_64: Unknown device 'q35-pcihost' for default sysbus Aborted (core dumped) Tested-by: Markus Armbruster Signed-off-by: Hu Tao --- default-configs/i386-softmmu.mak

Re: [Qemu-devel] [PATCH 1/2] target-i386: remove cpu reset callback

2013-04-10 Thread li guang
在 2013-04-10三的 10:34 +0200,Igor Mammedov写道: > On Wed, 10 Apr 2013 16:02:28 +0800 > liguang wrote: > > > we should remove it now, if not, cpu reset > > will do 2 times. > Currently CPU is bus-less device so there isn't anything to reset it during > reboot except callback. > This patch will break

Re: [Qemu-devel] VFIO-VGA Issue

2013-04-10 Thread Gleb Natapov
On Tue, Apr 09, 2013 at 04:17:48PM -0600, Alex Williamson wrote: > On Tue, 2013-04-09 at 11:18 -0600, Alex Williamson wrote: > > On Tue, 2013-04-09 at 08:22 -0400, de...@lavabit.com wrote: > > > Hi! > > > > > > I've tried passing through my ASUS Radeon HD7750, but qemu just hogs 100% > > > of one

Re: [Qemu-devel] [PATCH 1/2] target-i386: remove cpu reset callback

2013-04-10 Thread Igor Mammedov
On Wed, 10 Apr 2013 16:52:01 +0800 li guang wrote: > 在 2013-04-10三的 10:34 +0200,Igor Mammedov写道: > > On Wed, 10 Apr 2013 16:02:28 +0800 > > liguang wrote: > > > > > we should remove it now, if not, cpu reset > > > will do 2 times. > > Currently CPU is bus-less device so there isn't anything to

Re: [Qemu-devel] [PATCH] ide: refuse WIN_READ_NATIVE_MAX on empty device

2013-04-10 Thread Stefan Hajnoczi
On Fri, Apr 05, 2013 at 11:51:01AM +0200, Stefan Hajnoczi wrote: > What is the highest addressable sector on an empty CD-ROM? Nothing is > addressable so produce an error. > > This patch prevents a divide-by-zero in ide_set_sector() since > s->sectors and s->heads would be 0. Not to mention that

Re: [Qemu-devel] GSoC 2013, "Introduce API to query IP addresses for given domain" Libvirt project

2013-04-10 Thread Stefan Hajnoczi
On Wed, Apr 10, 2013 at 04:46:45AM +0200, Tabibel Sami wrote: > I am doing master degree of Cryptology and information security > I have good C and Python skills, and i am interested to work on > "Introduce API to query IP addresses for given domain" Libvirt > project. > > I am looking for any com

Re: [Qemu-devel] GSoC 2013, "Introduce API to query IP addresses for given domain" Libvirt project

2013-04-10 Thread Michal Privoznik
On 10.04.2013 11:12, Stefan Hajnoczi wrote: > On Wed, Apr 10, 2013 at 04:46:45AM +0200, Tabibel Sami wrote: >> I am doing master degree of Cryptology and information security >> I have good C and Python skills, and i am interested to work on >> "Introduce API to query IP addresses for given domain"

Re: [Qemu-devel] [PATCH][RFC v2 3/7] vl: create power chip device

2013-04-10 Thread Paolo Bonzini
Il 10/04/2013 02:09, li guang ha scritto: >> > >> > Then I explained in my other message why this is wrong. The API may >> > well be "bad" (if so, please explain why), but at least it is the right >> > tool to model this. QEMU models abstract concepts (memory, timers, >> > powerdown) with APIs,

Re: [Qemu-devel] [PATCH] Add linux-headers to QEMU_INCLUDES

2013-04-10 Thread Paolo Bonzini
Il 10/04/2013 10:29, Jan Kiszka ha scritto: > From: Jan Kiszka > > virtio/dataplane/vring.c requires the Linux headers and is built for all > targets. So we need to add the corresponding include to QEMU_INCLUDES to > avoid that outdated distribution headers are used. > > Signed-off-by: Jan Kiszk

Re: [Qemu-devel] [PATCH] translate: cleanup gen_intermediate_code_internal

2013-04-10 Thread Paolo Bonzini
Il 10/04/2013 09:55, li guang ha scritto: > 在 2013-04-10三的 09:44 +0200,Paolo Bonzini写道: >> Il 10/04/2013 05:30, liguang ha scritto: >>> Signed-off-by: liguang >>> --- >>> target-arm/translate.c | 17 - >>> target-i386/translate.c | 17 - >>> target-mips/transl

Re: [Qemu-devel] [PATCH v4 02/11] block: add error parameter to del_existing_snapshots()

2013-04-10 Thread Pavel Hrdina
On 9.4.2013 15:27, Markus Armbruster wrote: Pavel Hrdina writes: Signed-off-by: Pavel Hrdina Reviewed-by: Eric Blake --- savevm.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/savevm.c b/savevm.c index 77c5291..dc1f4a4 100644 --- a/savevm.c +++ b/savevm.

Re: [Qemu-devel] [PATCH v6 0/7] virtio-serial refactoring.

2013-04-10 Thread Amit Shah
On (Tue) 09 Apr 2013 [14:53:29], fred.kon...@greensocs.com wrote: > From: KONRAD Frederic > > This is the next part of virtio-refactoring. > > Basically it creates virtio-serial device which extends virtio-device. > Then a virtio-serial can be connected on a virtio-bus. > virtio-serial-pci, virt

Re: [Qemu-devel] [PATCH v4 00/11] convert savevm to use qapi and introduce qmp command

2013-04-10 Thread Pavel Hrdina
On 10.4.2013 10:18, Markus Armbruster wrote: Pavel Hrdina writes: This patch series convert the savevm command into qapi and introduce QMP command vm-snapshot-save. It also rewrite error report for functions used by this command. The last patch introduce new functionality of savevm that you c

Re: [Qemu-devel] latest version qemu compile error

2013-04-10 Thread Zhanghaoyu (A)
> > The log of "make V=1" is identical with that of "make", shown as below, > > > > hw/virtio/dataplane/vring.c: In function 'vring_enable_notification': > > hw/virtio/dataplane/vring.c:72: warning: implicit declaration of function > > 'vring_avail_event' > > hw/virtio/dataplane/vring.c:72: warni

Re: [Qemu-devel] latest version qemu compile error

2013-04-10 Thread Paolo Bonzini
Il 10/04/2013 13:03, Zhanghaoyu (A) ha scritto: >>> The log of "make V=1" is identical with that of "make", shown as below, >>> > > >>> > > hw/virtio/dataplane/vring.c: In function 'vring_enable_notification': >>> > > hw/virtio/dataplane/vring.c:72: warning: implicit declaration of >>> > > functi

Re: [Qemu-devel] [PATCH v4 02/11] block: add error parameter to del_existing_snapshots()

2013-04-10 Thread Markus Armbruster
Pavel Hrdina writes: > On 9.4.2013 15:27, Markus Armbruster wrote: >> Pavel Hrdina writes: >> >>> Signed-off-by: Pavel Hrdina >>> Reviewed-by: Eric Blake >>> --- >>> savevm.c | 12 +++- >>> 1 file changed, 7 insertions(+), 5 deletions(-) >>> >>> diff --git a/savevm.c b/savevm.c >>>

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 08/12] new capabilities added and check for QMP string 'rdma'

2013-04-10 Thread Michael S. Tsirkin
On Wed, Apr 10, 2013 at 10:07:47AM +0200, Paolo Bonzini wrote: > Il 10/04/2013 03:11, Michael R. Hines ha scritto: > > Actually, this capability needs to be a part of the same patch. > > > > RDMA must have the ability to turn this off or performance will die. > > Yes, but you can put it in a sepa

Re: [Qemu-devel] [PATCH] ui/gtk: Set QEMU window icon

2013-04-10 Thread Jan Kiszka
On 2013-03-30 15:21, Stefan Weil wrote: > The QEMU icon which is already used for SDL > is now also loaded by GTK. > > Signed-off-by: Stefan Weil > --- > ui/gtk.c | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/ui/gtk.c b/ui/gtk.c > index a5a8156..c15023b 100644 > ---

Re: [Qemu-devel] [PATCH v18 3/7] introduce a new qom device to deal with panicked event

2013-04-10 Thread Markus Armbruster
Hu Tao writes: > pvpanic device is used to send guest panic event from guest to qemu. > > When guest panic happens, pvpanic device driver will write a event > number to IO port 0x505(which is the IO port occupied by pvpanic device, > by default). On receiving the event, pvpanic device will pause

Re: [Qemu-devel] [RFC PATCH v3 0/5] port network layer onto glib

2013-04-10 Thread Stefan Hajnoczi
On Wed, Apr 10, 2013 at 03:47:15PM +0800, liu ping fan wrote: > On Tue, Apr 9, 2013 at 11:22 PM, Stefan Hajnoczi wrote: > > On Mon, Apr 08, 2013 at 01:36:03PM +0800, Liu Ping Fan wrote: > >> This series focus on network backend (excluding slirp). The related patch > >> for core's re-entrant (queue

[Qemu-devel] Nic devices' name are wrongly repeated

2013-04-10 Thread Amos Kong
Hi Stefan, If we don't assign 'id' for nic device, device name will be $model.$idx. The $idx are always 0 if we set nic by new style. # qemu-upstream -device virtio-net-pci,netdev=h1 -netdev tap,id=h1 -device virtio-net-pci,netdev=h2 -netdev tap,id=h2 ... (qemu) info network virtio-net-pci.0:

Re: [Qemu-devel] [PATCH v4 02/11] block: add error parameter to del_existing_snapshots()

2013-04-10 Thread Eric Blake
On 04/10/2013 03:57 AM, Pavel Hrdina wrote: >> Any particular reason for de-capitalizing "Error"? > > Yes, Eric told me that we should start the error message with lover case > and also we shouldn't print '.' at the end of the error message. More precisely, I pointed to 'git grep' results that p

Re: [Qemu-devel] [PATCH][RFC v2 3/7] vl: create power chip device

2013-04-10 Thread Andreas Färber
Am 10.04.2013 02:09, schrieb li guang: > 在 2013-04-09二的 13:06 +0200,Paolo Bonzini写道: >> Il 09/04/2013 10:26, li guang ha scritto: qemu_system_suspend_request, qemu_register_suspend_notifier for S0->S3 qemu_system_wakeup_request, qemu_register_wakeup_notifier for S3->S

Re: [Qemu-devel] [RFC PATCH RDMA support v6: 2/7] documentation (docs/rdma.txt)

2013-04-10 Thread Michael R. Hines
On 04/10/2013 01:35 AM, Michael S. Tsirkin wrote: On Wed, Apr 10, 2013 at 12:29:35AM -0400, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" Verbose documentation is included, for both the protocol and interface to QEMU. Additionally, there is a Features/RDMALiveMigration wiki as w

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 08/12] new capabilities added and check for QMP string 'rdma'

2013-04-10 Thread Michael R. Hines
On 04/10/2013 04:07 AM, Paolo Bonzini wrote: Il 10/04/2013 03:11, Michael R. Hines ha scritto: Actually, this capability needs to be a part of the same patch. RDMA must have the ability to turn this off or performance will die. Yes, but you can put it in a separate patch at the beginning of th

Re: [Qemu-devel] [PATCH v4 00/11] convert savevm to use qapi and introduce qmp command

2013-04-10 Thread Eric Blake
On 04/10/2013 04:53 AM, Pavel Hrdina wrote: > The first thing what we should discuss is the use of name as tak or > id. I think that the best solution should be that we will have separate > arguments of both. We will use the 'name' argument to specify the tag > of a snapshot and we will add a new a

Re: [Qemu-devel] Nic devices' name are wrongly repeated

2013-04-10 Thread Andreas Färber
Hi, Am 10.04.2013 14:05, schrieb Amos Kong: > If we don't assign 'id' for nic device, device name will be $model.$idx. The > $idx are always 0 if we set nic by new style. > > # qemu-upstream -device virtio-net-pci,netdev=h1 -netdev tap,id=h1 -device > virtio-net-pci,netdev=h2 -netdev tap,id=h2

Re: [Qemu-devel] [PATCH v4 0/5] usb: QOM realize support for SysBus EHCI and FUSBH200

2013-04-10 Thread Andreas Färber
Am 25.02.2013 18:06, schrieb Andreas Färber: > Hello Gerd, > > v4 fixes the bus naming by leaving usb_bus_new() in realize for now. > A mid-term fix will be to rework (q)bus initialization. Ping? > > Regards, > Andreas > > v3 -> v4: > * Reverted moving usb_bus_new() into instance_init. > > v1

Re: [Qemu-devel] [RFC PATCH RDMA support v6: 4/7] Introduce two new capabilities

2013-04-10 Thread Michael R. Hines
On 04/10/2013 03:50 AM, Paolo Bonzini wrote: Il 10/04/2013 06:29, mrhi...@linux.vnet.ibm.com ha scritto: From: "Michael R. Hines" RDMA performs very slowly with zero-page checking. Without the ability to disable it, RDMA throughput and latency promises and high performance links cannot be full

Re: [Qemu-devel] [RFC PATCH RDMA support v6: 7/7] introduce qemu_ram_foreach_block()

2013-04-10 Thread Michael R. Hines
On 04/10/2013 03:47 AM, Paolo Bonzini wrote: Il 10/04/2013 06:29, mrhi...@linux.vnet.ibm.com ha scritto: From: "Michael R. Hines" This is used during RDMA initialization in order to transmit a description of all the RAM blocks to the peer for later dynamic chunk registration purposes. why did

Re: [Qemu-devel] [RFC PATCH RDMA support v6: 1/7] ./configure and Makefile

2013-04-10 Thread Michael R. Hines
On 04/10/2013 03:52 AM, Paolo Bonzini wrote: Il 10/04/2013 06:29, mrhi...@linux.vnet.ibm.com ha scritto: diff --git a/Makefile.objs b/Makefile.objs index e568c01..10431bd 100644 --- a/Makefile.objs +++ b/Makefile.objs @@ -49,6 +49,7 @@ common-obj-$(CONFIG_POSIX) += os-posix.o common-obj-$(CONF

Re: [Qemu-devel] [RFC PATCH RDMA support v6: 3/7] Introduce QEMURamControlOps

2013-04-10 Thread Michael R. Hines
Acknowledged. On 04/10/2013 03:52 AM, Paolo Bonzini wrote: Il 10/04/2013 06:29, mrhi...@linux.vnet.ibm.com ha scritto: From: "Michael R. Hines" RDMA requires hooks before and after each iteration round in order to coordinate the new dynamic page registration support. This is done now by intro

Re: [Qemu-devel] [RFC PATCH RDMA support v6: 6/7] send pc.ram over RDMA

2013-04-10 Thread Michael R. Hines
Acknowledged. On 04/10/2013 03:57 AM, Paolo Bonzini wrote: Il 10/04/2013 06:29, mrhi...@linux.vnet.ibm.com ha scritto: From: "Michael R. Hines" All that is left for this part of the patch is: 1. use the new (optionally defined) save_ram_page function pointer to decide what to do with the

Re: [Qemu-devel] [PATCH v4 00/11] convert savevm to use qapi and introduce qmp command

2013-04-10 Thread Luiz Capitulino
On Wed, 10 Apr 2013 06:24:11 -0600 Eric Blake wrote: > > - If you want to overwrite an existing snapshot, you could specify > > the 'id' or the 'name' argument or both of them and also you will > > have to use the 'force' argument > > But the argument made in this thread is that QMP sh

Re: [Qemu-devel] [RFC PATCH RDMA support v6: 4/7] Introduce two new capabilities

2013-04-10 Thread Paolo Bonzini
Il 10/04/2013 14:34, Michael R. Hines ha scritto: > On 04/10/2013 03:50 AM, Paolo Bonzini wrote: >> Il 10/04/2013 06:29, mrhi...@linux.vnet.ibm.com ha scritto: >>> From: "Michael R. Hines" >>> >>> RDMA performs very slowly with zero-page checking. >>> Without the ability to disable it, RDMA throug

Re: [Qemu-devel] [RFC PATCH RDMA support v6: 1/7] ./configure and Makefile

2013-04-10 Thread Paolo Bonzini
Il 10/04/2013 14:37, Michael R. Hines ha scritto: >>> >>> +common-obj-$(CONFIG_RDMA) += migration-rdma.o >>> common-obj-y += qemu-char.o #aio.o >>> common-obj-y += block-migration.o >>> common-obj-y += page_cache.o xbzrle.o >> This is in patch 5. >> >> Paolo >> > > I don't understand this co

Re: [Qemu-devel] [RFC PATCH RDMA support v6: 4/7] Introduce two new capabilities

2013-04-10 Thread Orit Wasserman
On 04/10/2013 07:29 AM, mrhi...@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" > > RDMA performs very slowly with zero-page checking. > Without the ability to disable it, RDMA throughput and > latency promises and high performance links cannot be > fully realized. > > On the other hand, dy

Re: [Qemu-devel] latest master: major slowdown (something spinning?)

2013-04-10 Thread Paolo Bonzini
Il 10/04/2013 14:43, Michael R. Hines ha scritto: > Yes, it still happens at that commit string. > > Is there a specific test or trace I can provide to help track it down? You can try: 1) first, please post the exact QEMU command line your using; 2) put "strace -e poll" in front and post the fi

Re: [Qemu-devel] [PATCH 0/4] QEMUFile improvements and simplifications

2013-04-10 Thread Liuji (Jeremy)
Hi, Paolo I tested your 4 patches in the latest version of qemu.git/master(commit: 93b48c201eb6c0404d15550a0eaa3c0f7937e35e,2013-04-09). These patches resolve the "savevm hanging" problem, which is detailedly described in my preceding mail:"After executing "savevm", the QEMU process is hanging".

Re: [Qemu-devel] [PATCH v4 00/11] convert savevm to use qapi and introduce qmp command

2013-04-10 Thread Eric Blake
On 04/10/2013 06:40 AM, Luiz Capitulino wrote: > On Wed, 10 Apr 2013 06:24:11 -0600 > Eric Blake wrote: > >>> - If you want to overwrite an existing snapshot, you could specify >>> the 'id' or the 'name' argument or both of them and also you will >>> have to use the 'force' argument >>

Re: [Qemu-devel] [PATCH 0/4] QEMUFile improvements and simplifications

2013-04-10 Thread Paolo Bonzini
Il 10/04/2013 14:48, Liuji (Jeremy) ha scritto: > Hi, Paolo > > I tested your 4 patches in the latest version of qemu.git/master(commit: > 93b48c201eb6c0404d15550a0eaa3c0f7937e35e,2013-04-09). > These patches resolve the "savevm hanging" problem, which is detailedly > described > in my preceding

Re: [Qemu-devel] latest master: major slowdown (something spinning?)

2013-04-10 Thread Michael R. Hines
Yes, it still happens at that commit string. Is there a specific test or trace I can provide to help track it down? - Michael On 04/10/2013 03:43 AM, Paolo Bonzini wrote: Il 09/04/2013 19:43, Michael R. Hines ha scritto: *Here's the commit that causes the problem:* $ git checkout d185c094b40

Re: [Qemu-devel] [PATCH 0/4] QEMUFile improvements and simplifications

2013-04-10 Thread Juan Quintela
"Liuji (Jeremy)" wrote: > Hi, Paolo > > I tested your 4 patches in the latest version of qemu.git/master(commit: > 93b48c201eb6c0404d15550a0eaa3c0f7937e35e,2013-04-09). > These patches resolve the "savevm hanging" problem, which is detailedly > described > in my preceding mail:"After executing "s

Re: [Qemu-devel] [PATCH 06/22] cpu: introduce CPUClass.resume() method

2013-04-10 Thread Igor Mammedov
On Tue, 09 Apr 2013 13:20:27 +0200 Paolo Bonzini wrote: > Il 08/04/2013 22:13, Eduardo Habkost ha scritto: > > So you are initializing a field of CPUClass struct inside a CPU object > > initialization function. And that's a function that is not even > > converted to QOM yet, and buried inside a n

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-10 Thread Michael R. Hines
On 04/10/2013 01:27 AM, Michael S. Tsirkin wrote: Below is a great high level overview. the protocol looks correct. A bit more detail would be helpful, as noted below. The main thing I'd like to see changed is that there are already two protocols here: chunk-based and non chunk based. We'll need

Re: [Qemu-devel] [RFC PATCH RDMA support v6: 4/7] Introduce two new capabilities

2013-04-10 Thread Michael R. Hines
On 04/10/2013 08:40 AM, Paolo Bonzini wrote: Il 10/04/2013 14:34, Michael R. Hines ha scritto: On 04/10/2013 03:50 AM, Paolo Bonzini wrote: Il 10/04/2013 06:29, mrhi...@linux.vnet.ibm.com ha scritto: From: "Michael R. Hines" RDMA performs very slowly with zero-page checking. Without the abil

Re: [Qemu-devel] [RFC PATCH RDMA support v6: 1/7] ./configure and Makefile

2013-04-10 Thread Michael R. Hines
On 04/10/2013 08:42 AM, Paolo Bonzini wrote: Il 10/04/2013 14:37, Michael R. Hines ha scritto: +common-obj-$(CONFIG_RDMA) += migration-rdma.o common-obj-y += qemu-char.o #aio.o common-obj-y += block-migration.o common-obj-y += page_cache.o xbzrle.o This is in patch 5. Paolo I don't

Re: [Qemu-devel] [RFC PATCH RDMA support v6: 4/7] Introduce two new capabilities

2013-04-10 Thread Paolo Bonzini
Il 10/04/2013 15:10, Michael R. Hines ha scritto: > > > Also about qemu_ram_foreach_block: Why does this depend on patch 5, > exactly? It's patch 5 that depends on qemu_ram_foreach_block. I'm not sure how it is possible to link patch 5 if exec.c still does not provide qemu_ram_foreach_block. P

Re: [Qemu-devel] [RFC PATCH RDMA support v6: 4/7] Introduce two new capabilities

2013-04-10 Thread Michael R. Hines
On 04/10/2013 08:47 AM, Orit Wasserman wrote: On 04/10/2013 07:29 AM, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" RDMA performs very slowly with zero-page checking. Without the ability to disable it, RDMA throughput and latency promises and high performance links cannot be fully

Re: [Qemu-devel] latest master: major slowdown (something spinning?)

2013-04-10 Thread Michael R. Hines
Will do, in the meantime, QEMU just printed out this error message: main-loop: WARNING: I/O thread spun for 1000 iterations Will get the traces later for you - Michael On 04/10/2013 08:46 AM, Paolo Bonzini wrote: Il 10/04/2013 14:43, Michael R. Hines ha scritto: Yes, it still happens at

Re: [Qemu-devel] [PATCH v4 00/11] convert savevm to use qapi and introduce qmp command

2013-04-10 Thread Pavel Hrdina
On 10.4.2013 14:49, Eric Blake wrote: On 04/10/2013 06:40 AM, Luiz Capitulino wrote: On Wed, 10 Apr 2013 06:24:11 -0600 Eric Blake wrote: - If you want to overwrite an existing snapshot, you could specify the 'id' or the 'name' argument or both of them and also you will have to u

[Qemu-devel] [PATCH] qemu-char: another io_add_watch_poll fix

2013-04-10 Thread Paolo Bonzini
After attaching the source, we have to remove the reference we hold to it, because we do not hold anymore a pointer to the source. If we do not do this, removing the source will not finalize it and will not drop the "real" I/O watch source. This showed up when backporting the new flow control pat

Re: [Qemu-devel] [PATCH v4 00/11] convert savevm to use qapi and introduce qmp command

2013-04-10 Thread Luiz Capitulino
On Wed, 10 Apr 2013 15:22:49 +0200 Pavel Hrdina wrote: > On 10.4.2013 14:49, Eric Blake wrote: > > On 04/10/2013 06:40 AM, Luiz Capitulino wrote: > >> On Wed, 10 Apr 2013 06:24:11 -0600 > >> Eric Blake wrote: > >> > - If you want to overwrite an existing snapshot, you could specify > >>>

Re: [Qemu-devel] [PATCH][RFC v2 3/7] vl: create power chip device

2013-04-10 Thread guang li
Yes, you're right. The motivation is I want to implement a device called EC which is a notion from laptop for QEMU, EC has some main functions, like keyboard, mouse, low-speed device control(I2C), special ACPI space, i8042 and ps2 mouse has been done, power control was left, so I tried to add thi

Re: [Qemu-devel] [RFC PATCH RDMA support v6: 4/7] Introduce two new capabilities

2013-04-10 Thread Orit Wasserman
On 04/10/2013 04:13 PM, Michael R. Hines wrote: > On 04/10/2013 08:47 AM, Orit Wasserman wrote: >> On 04/10/2013 07:29 AM, mrhi...@linux.vnet.ibm.com wrote: >>> From: "Michael R. Hines" >>> >>> RDMA performs very slowly with zero-page checking. >>> Without the ability to disable it, RDMA throughpu

Re: [Qemu-devel] [PATCH v4 00/11] convert savevm to use qapi and introduce qmp command

2013-04-10 Thread Pavel Hrdina
On 10.4.2013 15:32, Luiz Capitulino wrote: On Wed, 10 Apr 2013 15:22:49 +0200 Pavel Hrdina wrote: On 10.4.2013 14:49, Eric Blake wrote: On 04/10/2013 06:40 AM, Luiz Capitulino wrote: On Wed, 10 Apr 2013 06:24:11 -0600 Eric Blake wrote: - If you want to overwrite an existing snapshot,

Re: [Qemu-devel] [PATCH][RFC v2 3/7] vl: create power chip device

2013-04-10 Thread Paolo Bonzini
Il 10/04/2013 15:41, guang li ha scritto: > Yes, you're right. > The motivation is I want to implement a device > called EC which is a notion from laptop for QEMU, > EC has some main functions, like keyboard, mouse, > low-speed device control(I2C), special ACPI space, > i8042 and ps2 mouse has bee

Re: [Qemu-devel] [PATCH v2] rbd: add an asynchronous flush

2013-04-10 Thread Josh Durgin
On 04/02/2013 07:10 AM, Kevin Wolf wrote: Am 29.03.2013 um 21:03 hat Josh Durgin geschrieben: The existing bdrv_co_flush_to_disk implementation uses rbd_flush(), which is sychronous and causes the main qemu thread to block until it is complete. This results in unresponsiveness and extra latency

Re: [Qemu-devel] [RFC PATCH RDMA support v6: 4/7] Introduce two new capabilities

2013-04-10 Thread Michael R. Hines
On 04/10/2013 09:13 AM, Paolo Bonzini wrote: Il 10/04/2013 15:10, Michael R. Hines ha scritto: Also about qemu_ram_foreach_block: Why does this depend on patch 5, exactly? Understood - I will move the patch up in the series and make it more clear.

Re: [Qemu-devel] [PATCH v4 00/11] convert savevm to use qapi and introduce qmp command

2013-04-10 Thread Pavel Hrdina
Here is another proposal how to handle vm snapshots: QMP vm-snapshot-save: - { 'command': 'vm-snapshot-save', 'data': { 'name': 'str' }, 'returns': 'SnapshotInfo' } - vm-snapshot-save returns an error if there is an existing snapshot with the same name - you cann

Re: [Qemu-devel] [RFC PATCH 1/6] adlib: qdev-ify

2013-04-10 Thread Paolo Bonzini
Il 09/04/2013 19:28, Andreas Färber ha scritto: >> -int Adlib_init (ISABus *bus) >> +static int Adlib_initfn (ISADevice *dev) > > Hm, obviously that conflicts with my series converting ISADevices to QOM > realize that I was hoping to still get into 1.5... Just put this patch in front of your seri

Re: [Qemu-devel] Nic devices' name are wrongly repeated

2013-04-10 Thread Amos Kong
On Wed, Apr 10, 2013 at 02:28:40PM +0200, Andreas Färber wrote: > Hi, > > Am 10.04.2013 14:05, schrieb Amos Kong: > > If we don't assign 'id' for nic device, device name will be $model.$idx. > > The $idx are always 0 if we set nic by new style. > > > > # qemu-upstream -device virtio-net-pci,netd

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-10 Thread Michael S. Tsirkin
On Wed, Apr 10, 2013 at 09:04:44AM -0400, Michael R. Hines wrote: > On 04/10/2013 01:27 AM, Michael S. Tsirkin wrote: > >Below is a great high level overview. the protocol looks correct. > >A bit more detail would be helpful, as noted below. > > > >The main thing I'd like to see changed is that the

  1   2   3   >