On 04/10/2013 03:57 AM, Pavel Hrdina wrote: >> Any particular reason for de-capitalizing "Error"? > > Yes, Eric told me that we should start the error message with lover case > and also we shouldn't print '.' at the end of the error message.
More precisely, I pointed to 'git grep' results that proved that the code base overwhelmingly avoids trailing '.', but that it was rather ambiguous on whether messages start with a capital or a lower case. Changing the period was important, changing the capitalization feels a bit like churn unless we set a coding standard in HACKING telling which way new code should use. I can live with the churn in this commit as long as you are changing other things in the same hunk at the same time, but I wasn't specifically asking for capitalization changes. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
